Re: [-mm PATCH] set enable bit instead of lock bit of Watchdog Timer in Intel 6300 chipset

2005-08-15 Thread Wim Van Sebroeck
Hi All, > >This patch sets the WDT_ENABLE bit of the Lock Register to enable the > >watchdog and WDT_LOCK bit only if nowayout is set. The old code always > >sets the WDT_LOCK bit of watchdog timer for Intel 6300ESB chipset. So, we > >end up locking the watchdog instead of enabling it. > > > >Sign

Re: [-mm PATCH] set enable bit instead of lock bit of Watchdog Timer in Intel 6300 chipset

2005-08-15 Thread David Härdeman
On Mon, Aug 15, 2005 at 02:21:05PM -0700, Naveen Gupta wrote: This patch sets the WDT_ENABLE bit of the Lock Register to enable the watchdog and WDT_LOCK bit only if nowayout is set. The old code always sets the WDT_LOCK bit of watchdog timer for Intel 6300ESB chipset. So, we end up locking the

Re: [-mm PATCH] set enable bit instead of lock bit of Watchdog Timer in Intel 6300 chipset

2005-08-15 Thread Naveen Gupta
David, Yes, I have tested these patches. In fact I found these bugs while trying to make the driver work on our machines. -Naveen On Tue, 16 Aug 2005, David Härdeman wrote: > On Mon, Aug 15, 2005 at 02:21:05PM -0700, Naveen Gupta wrote: > > > >This patch sets the WDT_ENABLE bit of the Lock Regi

Re: [-mm PATCH] set enable bit instead of lock bit of Watchdog Timer in Intel 6300 chipset

2005-08-15 Thread David Härdeman
On Mon, Aug 15, 2005 at 02:21:05PM -0700, Naveen Gupta wrote: This patch sets the WDT_ENABLE bit of the Lock Register to enable the watchdog and WDT_LOCK bit only if nowayout is set. The old code always sets the WDT_LOCK bit of watchdog timer for Intel 6300ESB chipset. So, we end up locking the

[-mm PATCH] set enable bit instead of lock bit of Watchdog Timer in Intel 6300 chipset

2005-08-15 Thread Naveen Gupta
This patch sets the WDT_ENABLE bit of the Lock Register to enable the watchdog and WDT_LOCK bit only if nowayout is set. The old code always sets the WDT_LOCK bit of watchdog timer for Intel 6300ESB chipset. So, we end up locking the watchdog instead of enabling it. Signed-off-by: Naveen Gupta <[