Re: [PATCH 1/3] debugfs: pass NULL as the last parameter of debugfs_print_regs32()

2012/10/27 Greg KH : > On Sat, Oct 27, 2012 at 01:55:42AM +0800, Yan Hong wrote: >> Pass NULL instead of empty string to debugfs_print_regs32() when >> prefix is not used, according to the intention of the code. > > Is this solving a problem? Is it wrong as-is? Is it causing an issue > today? > >

Re: [PATCH 1/3] proc: return -ENOMEM when inode allocation failed

2012/9/5 Cong Wang : >>> Why the !memcmp() case is related with ENOMEM ?? >> >> >> We are presetting 'error' here. The following proc_get_inode() will try >> to get an inode, either from inode cache or allocate a new one (and fill >> it). >> >> If we get a NULL inode, that means allocation failed.

Re: [PATCH 1/3] proc: return -ENOMEM when inode allocation failed

2012/9/4 Cong Wang : > On 09/03/2012 10:14 PM, yan wrote: >> >> Signed-off-by: yan > > > Please provide a changelog to explain why we need this patch. I think the title is self explained. >> --- >> fs/proc/generic.c |2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git

Re: [PATCH 3/3] proc: use kzalloc instead of kmalloc and memset

2012/9/4 Ryan Mallon > > On 04/09/12 00:14, yan wrote: > > Signed-off-by: yan > > --- > > fs/proc/generic.c |3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/fs/proc/generic.c b/fs/proc/generic.c > > index 9e8f631..38de015 100644 > > --- a/fs/proc/generic.c > >