Re: Re: [PATCH] Input: joystick: adi - change msleep to usleep_range for small msecs

2016-11-28 Thread vojt...@ucw.cz
On Mon, Nov 28, 2016 at 01:49:31PM +, Aniroop Mathur wrote: > Hello Mr. Vojtech Pavlik, > > On 28 Nov 2016 17:23, "vojt...@ucw.cz" wrote: > > > > Hi. > > > > ADI_INIT_DELAY/ADI_DATA_DELAY doesn't have to be exact, and a longer > &g

Re: [PATCH] Input: joystick: adi - change msleep to usleep_range for small msecs

2016-11-28 Thread vojt...@ucw.cz
Hi. ADI_INIT_DELAY/ADI_DATA_DELAY doesn't have to be exact, and a longer sleep doesn't matter. In the initilization sequence - first chunk of your patch - a way too long delay could in theory make the device fail to initialize. What's critical is that the mdelay() calls are precise. One day I'll