在 2021/4/12 20:40, Sven Van Asbroeck 写道:
On Sun, Apr 11, 2021 at 9:14 PM tiantao (H) wrote:
What about doing it like this?
-static void host_release(struct device *dev, void *res)
+static void host_release(void *res)
{
- struct anybuss_host **dr = res
在 2021/4/9 19:58, Sven Van Asbroeck 写道:
Hello Tian, thank you for the contribution. See below.
On Fri, Apr 9, 2021 at 4:33 AM Tian Tao wrote:
Use devm_add_action_or_reset() instead of devres_alloc() and
devres_add(), which works the same. This will simplify the
code. There is no functional c
Hi:
在 2021/3/1 21:09, Greg KH 写道:
On Mon, Mar 01, 2021 at 08:58:55PM +0800, Tian Tao wrote:
fix the below warnning:
/drivers/w1/slaves/w1_ds2780.c:93:60-61: WARNING opportunity for
kobj_to_dev()
What creates that warning?
This is reported by coccicheck.
Signed-off-by: Tian Tao
---
driv
Galbraith ; LKML ; linux-mm
; Sebastian Andrzej Siewior ;
NitinGupta ; Sergey Senozhatsky
; Andrew Morton
; tiantao (H)
Subject: Re: [PATCH] zsmalloc: do not use bit_spin_lock
On Tue, 22 Dec 2020, 03:11 Song Bao Hua (Barry Song),
wrote:
-Original Message-
From: Song Bao Hua (Barry Song
在 2020/12/15 20:01, Daniel Vetter 写道:
On Tue, Dec 15, 2020 at 12:59:53PM +0100, Daniel Vetter wrote:
On Tue, Dec 15, 2020 at 11:01:39AM +0800, Tian Tao wrote:
drm_irq_uninstall should be called before pci_disable_msi, if use
devm_drm_irq_install to register the interrupt, the system will
call
在 2020/12/7 17:22, Thomas Zimmermann 写道:
Hi
Am 07.12.20 um 10:05 schrieb Tian Tao:
Using drmm_mode_config_init() sets up managed release of modesetting
resources.
Individual patches usually contain a changelog to highlight the
difference to previous versions. Please add one before commit
Hi
在 2020/12/2 17:02, Thomas Zimmermann 写道:
Am 02.12.20 um 09:47 schrieb Tian Tao:
Use the devm_drm_dev_alloc provided by the drm framework to alloc
a structure hibmc_drm_private.
Signed-off-by: Tian Tao
This looks good now. Thanks for sticking to it.
Thank you for your continued patie
在 2020/12/2 10:06, tiantao (H) 写道:
在 2020/12/1 21:44, Thomas Zimmermann 写道:
Hi
Am 01.12.20 um 14:05 schrieb tiantao (H):
在 2020/12/1 20:36, Thomas Zimmermann 写道:
Hi
Am 01.12.20 um 13:26 schrieb tiantao (H):
在 2020/12/1 20:17, Thomas Zimmermann 写道:
Hi
Am 01.12.20 um 12:55 schrieb
在 2020/12/1 21:44, Thomas Zimmermann 写道:
Hi
Am 01.12.20 um 14:05 schrieb tiantao (H):
在 2020/12/1 20:36, Thomas Zimmermann 写道:
Hi
Am 01.12.20 um 13:26 schrieb tiantao (H):
在 2020/12/1 20:17, Thomas Zimmermann 写道:
Hi
Am 01.12.20 um 12:55 schrieb Tian Tao:
Assign local variable to
在 2020/12/1 20:36, Thomas Zimmermann 写道:
Hi
Am 01.12.20 um 13:26 schrieb tiantao (H):
在 2020/12/1 20:17, Thomas Zimmermann 写道:
Hi
Am 01.12.20 um 12:55 schrieb Tian Tao:
Assign local variable to struct drm_device *dev because they are
used multiple times within a function.
Signed-off
在 2020/12/1 20:17, Thomas Zimmermann 写道:
Hi
Am 01.12.20 um 12:55 schrieb Tian Tao:
Assign local variable to struct drm_device *dev because they are
used multiple times within a function.
Signed-off-by: Tian Tao
---
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 2 +-
drivers/gpu/dr
在 2020/11/20 16:23, Johan Hovold 写道:
On Thu, Nov 19, 2020 at 05:01:29PM +0800, Tian Tao wrote:
The code has been in a irq-disabled context since it is hard IRQ. There
is no necessity to do it again.
Signed-off-by: Tian Tao
---
drivers/tty/serial/owl-uart.c | 5 ++---
1 file changed, 2 in
在 2020/11/3 15:56, Thomas Zimmermann 写道:
Hi
Thanks, the code looks good already. There just are a few nits below.
Thanks for the help with the review code.
Add the new api devm_drm_irq_install and himbc use the new interface as
one patch or two?
Am 03.11.20 um 03:10 schrieb Tian Tao:
A
在 2020/11/2 20:09, Thomas Zimmermann 写道:
Hi
Am 02.11.20 um 12:19 schrieb Tian Tao:
Add the detection of false for irq, so that the EINVAL is not
returned when dev->irq_enabled is false.
Signed-off-by: Tian Tao
---
drivers/gpu/drm/drm_irq.c | 3 +++
1 file changed, 3 insertions(+)
diff
在 2020/11/2 17:03, Thomas Zimmermann 写道:
Hi
Am 02.11.20 um 09:46 schrieb tiantao (H):
在 2020/11/2 16:32, Thomas Zimmermann 写道:
Hi
Am 30.10.20 um 10:27 schrieb Tian Tao:
drm_irq_uninstall can handle the case where dev->irq_enable is false,
so Remove redundant null check.
Signed-off
在 2020/11/2 16:32, Thomas Zimmermann 写道:
Hi
Am 30.10.20 um 10:27 schrieb Tian Tao:
drm_irq_uninstall can handle the case where dev->irq_enable is false,
so Remove redundant null check.
Signed-off-by: Tian Tao
---
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 6 +++---
1 file changed
在 2020/9/29 15:24, Thomas Zimmermann 写道:
Am 29.09.20 um 02:45 schrieb Tian Tao:
The macro PADDING is no longer used. Delete it.
Signed-off-by: Tian Tao
Reviewed-by: Thomas Zimmermann
Thanks a lot for the timely help with the review code!
---
drivers/gpu/drm/hisilicon/hibmc/hibmc_d
Hi :
I alwaygs used scripts/get_maintainers.pl to get the recipient list.I
don't know why miss maintainers for a given piece of code.
tiantao@ubuntu:~$ git send-email -to e...@anholt.net -to
airl...@linux.ie -to dan...@ffwll.ch -to sumit.sem...@linaro.org -to
christian.koe...@amd.com -to dri-
在 2020/9/25 15:26, Thomas Zimmermann 写道:
Hi
Am 25.09.20 um 09:02 schrieb Thomas Zimmermann:
Hi,
just a few nits.
Am 25.09.20 um 08:49 schrieb Tian Tao:
drm_framebuffer.h contains drm/drm_device.h and struct drm_device is
contains -> includes
already declared in this file, so there is
在 2020/9/19 5:09, w...@kernel.org 写道:
static inline struct i2c_client *kobj_to_i2c_client(struct kobject *kobj)
{
- struct device * const dev = container_of(kobj, struct device, kobj);
+ struct device * const dev = kobj_to_dev(kobj);
return to_i2c_client(dev);
Can't
在 2020/8/12 15:04, Thomas Zimmermann 写道:
Hi
Am 03.08.20 um 02:38 schrieb Tian Tao:
patch #1 and #3 is clean up, patch #2 is for code refactoring
Sorry for all my reviews taking so long. Please merge patch #3 into
patch #2 and then the series is
thanks,I will send v3 to fix this.
Reviewe
Hi Thomas:
Thank you very much .
Best
-邮件原件-
发件人: Thomas Zimmermann [mailto:tzimmerm...@suse.de]
发送时间: 2020年7月29日 16:35
收件人: tiantao (H) ; airl...@linux.ie; dan...@ffwll.ch;
kra...@redhat.com; alexander.deuc...@amd.com; t...@linutronix.de;
dri-de...@lists.freedesktop.org
在 2020/7/8 21:48, Uladzislau Rezki 写道:
On 07/07/2020 02:43 PM, Tian Tao wrote:
It is not possible to increase size with vmalloc= in arm64
architecture and it will mislead.however vmalloc return failure
is a rare occurrence in 'many architectures including arm64'.
But there is a chance that
在 2020/7/7 21:24, Uladzislau Rezki 写道:
On Tue, Jul 07, 2020 at 03:18:54PM +0530, Anshuman Khandual wrote:
On 07/07/2020 02:43 PM, Tian Tao wrote:
It is not possible to increase size with vmalloc= in arm64
architecture and it will mislead.however vmalloc return failure
is a rare occurrence
Hi:
I am sorry for misunderstood you suggests. I will send v3 to fixed this.
Best
-邮件原件-
发件人: Thomas Zimmermann [mailto:tzimmerm...@suse.de]
发送时间: 2020年7月2日 15:20
收件人: tiantao (H) ; Chenfeng (puck)
; airl...@linux.ie; dan...@ffwll.ch;
kra...@redhat.com; alexander.deuc...@amd.com; t
Hi：
Thanks for the help with the review code. I will send v2 to fixed this.
Best
-邮件原件-
发件人: Thomas Zimmermann [mailto:tzimmerm...@suse.de]
发送时间: 2020年7月2日 14:43
收件人: tiantao (H) ; Chenfeng (puck)
; airl...@linux.ie; dan...@ffwll.ch;
kra...@redhat.com; alexander.deuc
26 matches
Mail list logo
