Re: pahole + BTF was: Re: [Question] bpf: about a new 'tools/bpf/bpf_dwarf2btf'

On 07/26/2018 03:27 AM, Taeung Song wrote: Hi Arnaldo, On 07/26/2018 02:52 AM, Arnaldo Carvalho de Melo wrote: Em Thu, Jul 26, 2018 at 02:23:32AM +0900, Taeung Song escreveu: Hi, Building bpf programs with .BTF section, I thought it'd be better to convert dwarf info to .BTF by a new

Re: pahole + BTF was: Re: [Question] bpf: about a new 'tools/bpf/bpf_dwarf2btf'

Hi Arnaldo, On 07/26/2018 02:52 AM, Arnaldo Carvalho de Melo wrote: Em Thu, Jul 26, 2018 at 02:23:32AM +0900, Taeung Song escreveu: Hi, Building bpf programs with .BTF section, I thought it'd be better to convert dwarf info to .BTF by a new tool such as 'tools/bpf/bpf_dwarf2btf&#

[Question] bpf: about a new 'tools/bpf/bpf_dwarf2btf'

bbtf.h), BPF developers would more easily use functionalities based on BTF. What do you think about this ? Do you think this is needed ? Or, already implementing something like this ? If it is needed, I want to try to make 'tools/bpf/bpf_dwarf2btf' based on the pahole code. I'd appreciate it, if you reply to this Thanks, Taeung

[PATCH] samples/bpf: Add BTF build flags to Makefile

To smoothly test BTF supported binary on samples/bpf, let samples/bpf/Makefile probe llc, pahole and llvm-objcopy for BPF support and use them like tools/testing/selftests/bpf/Makefile changed from the commit c0fa1b6c3efc ("bpf: btf: Add BTF tests") Cc: Martin KaFai Lau Signed-off-

[PATCH v2 bpf-next] tools/bpftool: ignore build products

For untracked things of tools/bpf, add this. Reviewed-by: Jakub Kicinski Signed-off-by: Taeung Song --- tools/bpf/.gitignore | 5 + tools/bpf/bpftool/.gitignore | 2 ++ 2 files changed, 7 insertions(+) create mode 100644 tools/bpf/.gitignore diff --git a/tools/bpf/.gitignore b

[PATCH bpf-next] tools/bpftool: ignore build products

For untracked things of tools/bpf, add this. Reviewed-by: Quentin Monnet Signed-off-by: Taeung Song --- tools/bpf/.gitignore | 5 + tools/bpf/bpftool/.gitignore | 2 ++ 2 files changed, 7 insertions(+) create mode 100644 tools/bpf/.gitignore diff --git a/tools/bpf/.gitignore b

[PATCH v2 2/2] tools/bpftool: Fix segfault case regarding 'pin' arguments

f: add bpftool") Reviewed-by: Jakub Kicinski Reported-by: Taehee Yoo Signed-off-by: Taeung Song --- tools/bpf/bpftool/common.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/tools/bpf/bpftool/common.c b/tools/bpf/bpftool/common.c index 32f9e397a6c0..3f140eff039f

[PATCH v2 2/4] samples/bpf: Check the result of system()

-off-by: Taeung Song --- samples/bpf/trace_event_user.c | 27 --- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/samples/bpf/trace_event_user.c b/samples/bpf/trace_event_user.c index 1fa1becfa641..d08046ab81f0 100644 --- a/samples/bpf/trace_event_user.c

[PATCH v2 0/4] samples/bpf: simple fixes

v2: - in error cases, do return; instead of break; in loop Hello, This patchset fixes trivial things that I found when testing 'samples/bpf/' sample code. I'd appreciate it, if you review this. Thanks, Taeung Taeung Song (4): samples/bpf: add missing samples/bpf: Check the r

[PATCH v2 1/4] samples/bpf: add missing

struct vlan_hdr' in sample code and include if_vlan.h Signed-off-by: Taeung Song --- samples/bpf/parse_varlen.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/samples/bpf/parse_varlen.c b/samples/bpf/parse_varlen.c index 95c16324760c..0b6f22feb2c9 100644 --- a/sample

[PATCH v2 4/4] samples/bpf: add .gitignore file

For untracked executables of samples/bpf, add this. Untracked files: (use "git add ..." to include in what will be committed) samples/bpf/cpustat samples/bpf/fds_example samples/bpf/lathist samples/bpf/load_sock_ops ... Signed-off-by: T

[tip:perf/core] tools lib traceevent: Fix missing break in FALSE case of pevent_filter_clear_trivial()

Commit-ID: 806efaed3cacab1521895d20bb3b5ed610909299 Gitweb: https://git.kernel.org/tip/806efaed3cacab1521895d20bb3b5ed610909299 Author: Taeung Song AuthorDate: Thu, 11 Jan 2018 19:47:50 -0500 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 17 Jan 2018 10:22:57 -0300 tools lib

Re: [PATCH 09/10] lib traceeevent: Fix missing break in FALSE case of pevent_filter_clear_trivial()

Hi Steven, I found a trivial typo "eee" on the commit log title It seems better to change "lib traceeevent" to " lib traceevent", if you want to do it.. Thanks, Taeung On 01/12/2018 09:47 AM, Steven Rostedt wrote:

Re: [PATCH 1/3] perf help: Document missing options

key-value pair top.children=true [acme@jouet linux]$ Unsure if this is something that got broken by the 'perf config' patches, Taeung? Looks like a bug in 8e99b6d4533c ("tools include: Adopt strstarts() from the kernel"). Following patch should fix it: Thanks, Namhyung I als

[tip:perf/urgent] perf record: Fix documentation for a inexistent option '-l'

Commit-ID: 3f50f614d61f91ad30b1947c429d1f235493a7f9 Gitweb: https://git.kernel.org/tip/3f50f614d61f91ad30b1947c429d1f235493a7f9 Author: Taeung Song AuthorDate: Sat, 14 Oct 2017 00:10:12 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 17 Oct 2017 09:05:36 -0300 perf record

[PATCH RESEND] perf record: Fix documentation for a disused option '-l'

Cc: Namhyung Kim Signed-off-by: Taeung Song --- tools/perf/Documentation/perf-record.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt index 68a1ffb..5a626ef 100644 --- a/tools/perf

[PATCH] perf record: Remove a disused option '-l'

Cc: Namhyung Kim Signed-off-by: Taeung Song --- tools/perf/Documentation/perf-record.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt index 68a1ffb..5a626ef 100644 --- a/tools/perf

[tip:perf/core] perf config: Allow creating empty config set for config file autogeneration

Commit-ID: 55421b4fb7054f85274b1b6a321e204dac696133 Gitweb: http://git.kernel.org/tip/55421b4fb7054f85274b1b6a321e204dac696133 Author: Taeung Song AuthorDate: Thu, 7 Sep 2017 12:18:56 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 13 Sep 2017 09:49:16 -0300 perf config

[tip:perf/core] perf config: Write a config file just once

Commit-ID: 5c2615556d4410baebc9b336f14befe0bb32cde4 Gitweb: http://git.kernel.org/tip/5c2615556d4410baebc9b336f14befe0bb32cde4 Author: Taeung Song AuthorDate: Thu, 7 Sep 2017 12:18:51 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 13 Sep 2017 09:49:15 -0300 perf config

[tip:perf/urgent] perf config: Check not only section->from_system_config but also item's

Commit-ID: cba225d6eeaf00bd8181a851fbaa7b8716337e0b Gitweb: http://git.kernel.org/tip/cba225d6eeaf00bd8181a851fbaa7b8716337e0b Author: Taeung Song AuthorDate: Thu, 7 Sep 2017 12:18:45 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 12 Sep 2017 12:35:11 -0300 perf config

Re: [PATCH v5 3/3] perf config: Allow creating empty config set for config file autogeneration

Thank you !! :) - Taeung On 09/08/2017 11:36 PM, Arnaldo Carvalho de Melo wrote: Em Thu, Sep 07, 2017 at 12:18:56PM +0900, Taeung Song escreveu: When there isn't a config file (e.g. ~/.perfconfig) or it has nothing, the config set wasn't created. If the config set not exists, a c

[PATCH v5 3/3] perf config: Allow creating empty config set for config file autogeneration

f cmd_config(). Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Taeung Song --- tools/perf/util/config.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c index bc75596..d2b6983 100644 --- a/tools/perf/util/config.c

[PATCH v5 1/3] perf config: Check not only section->from_system_config but also item's

Currently only section->from_system_config is being checked multiple times. items->from_system_config should be also checked, so fix it. Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v5 2/3] perf config: Once write a config file in the end, not a repeat

ff-by: Taeung Song --- tools/perf/builtin-config.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c index a1d82e3..b89417d 100644 --- a/tools/perf/builtin-config.c +++ b/tools/perf/builtin-config.c @@

[PATCH v5 0/3] perf config: Simple bugfixes & refactoring

Hi all, This is simple patchset for perf-config to fix small bugs and refactor code. I'd appreciate some feedback on this patchset. The code is also available at 'config/refactoring-v5' branch on git://github.com/taeung/linux-perf.git Thanks, Taeung v5: - rebase on current

[tip:perf/core] perf annotate browser: Circulate percent, total-period and nr-samples view

Commit-ID: 3a555c7799de69d73826eccc9a21948a5775d4d3 Gitweb: http://git.kernel.org/tip/3a555c7799de69d73826eccc9a21948a5775d4d3 Author: Taeung Song AuthorDate: Fri, 18 Aug 2017 17:47:08 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 18 Aug 2017 11:23:20 -0300 perf annotate

[tip:perf/core] perf annotate stdio: Support --show-nr-samples option

Commit-ID: 1ac39372e06f5009982aaaf890fc5bbd044bb047 Gitweb: http://git.kernel.org/tip/1ac39372e06f5009982aaaf890fc5bbd044bb047 Author: Taeung Song AuthorDate: Fri, 18 Aug 2017 17:46:48 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 18 Aug 2017 10:31:53 -0300 perf annotate

[tip:perf/core] perf annotate: Document --show-total-period option

Commit-ID: 01c85629f5e99958606da816f1df058c0722a570 Gitweb: http://git.kernel.org/tip/01c85629f5e99958606da816f1df058c0722a570 Author: Taeung Song AuthorDate: Fri, 18 Aug 2017 17:46:53 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 18 Aug 2017 10:34:08 -0300 perf annotate

[tip:perf/core] perf annotate browser: Support --show-nr-samples option

Commit-ID: 9cef4b0b5b7f64016f043609313aaa821d682d2e Gitweb: http://git.kernel.org/tip/9cef4b0b5b7f64016f043609313aaa821d682d2e Author: Taeung Song AuthorDate: Fri, 18 Aug 2017 17:47:03 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 18 Aug 2017 11:15:09 -0300 perf annotate

Re: [PATCH v3 5/5] perf annotate browser: Circulate percent, total period and samples view

On 08/18/2017 11:23 PM, Arnaldo Carvalho de Melo wrote: Em Fri, Aug 18, 2017 at 05:47:08PM +0900, Taeung Song escreveu: With a existing 't' hotkey, support the three view based on percent, total period and number of samples on the annotate TUI browser, circulating them like below:

Re: [PATCH v3 4/5] perf annotate browser: Support --show-nr-samples option

On 08/18/2017 11:17 PM, Arnaldo Carvalho de Melo wrote: Em Fri, Aug 18, 2017 at 05:47:03PM +0900, Taeung Song escreveu: Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song Ok, now that check for !--stdio is lifted and replaced with: - if (symbol_conf.show_nr_samples

Re: [PATCH v3 1/5] perf annotate stdio: Support --show-nr-samples option

On 08/18/2017 10:33 PM, Arnaldo Carvalho de Melo wrote: Em Fri, Aug 18, 2017 at 05:46:48PM +0900, Taeung Song escreveu: Add --show-nr-samples option to perf-annotate so that it corresponds with perf-report. So, at this point I tried to test it and forgot this was just about --stdio, which

[PATCH v3 2/5] perf annotate: Add a missing period option in documentation

Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/Documentation/perf-annotate.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/perf/Documentation/perf-annotate.txt b/tools/perf/Documentation/perf-annotate.txt index 2a5975c..c635eab 100644 --- a/tools/perf

[PATCH v3 4/5] perf annotate browser: Support --show-nr-samples option

Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/ui/browsers/annotate.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c index 80f38da..faca1b9 100644 --- a/tools

[PATCH v3 1/5] perf annotate stdio: Support --show-nr-samples option

Add --show-nr-samples option to perf-annotate so that it corresponds with perf-report. Cc: Namhyung Kim Cc: Milian Wolff Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/Documentation/perf-annotate.txt | 4 tools/perf/builtin-annotate.c | 2 ++ tools/perf/util

[PATCH v3 3/5] perf annotate: Period and samples view can't be used at the same time

If users give two options --show-total-period and --show-nr-samples, show their proper usage because the two options can not be used at the same time. Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/builtin-annotate.c | 8 ++-- 1 file changed, 6 insertions(+), 2

[PATCH v3 5/5] perf annotate browser: Circulate percent, total period and samples view

With a existing 't' hotkey, support the three view based on percent, total period and number of samples on the annotate TUI browser, circulating them like below: Percent -> Period -> Samples -> Percent ... Suggested-by: Namhyung Kim Cc: Milian Wolff Cc: Jiri Olsa Signed-

[PATCH v3 0/5] perf annotate: Support --show-nr-samples and circulating view

7;d appreciate some feedback on my patchkit. :) The code is available on 'perf/ann-nr-samples-v3' branch at git://github.com/taeung/linux-perf.git Thanks, Taeung v3: - Add --show-nr-samples option in documentation (Arnaldo) - Add a missing --show-total-period in documentation v2: - pe

Re: [PATCH v2 1/4] perf annotate stdio: Support --show-nr-samples option

Hi Arnaldo, On 08/18/2017 12:16 AM, Arnaldo Carvalho de Melo wrote: Em Tue, Aug 15, 2017 at 05:06:31PM -0300, Arnaldo Carvalho de Melo escreveu: Em Wed, Aug 16, 2017 at 12:13:09AM +0900, Taeung Song escreveu: Add --show-nr-samples option to perf-annotate so that it corresponds with perf

[PATCH v2 4/4] perf annotate browser: Circulate percent, total period and samples view

With a existing 't' hotkey, support the three view based on percent, total period and number of samples on the annotate TUI browser, circulating them like below: Percent -> Period -> Samples -> Percent ... Suggested-by: Namhyung Kim Cc: Milian Wolff Cc: Jiri Olsa Signed-

[PATCH v2 2/4] perf annotate: Period and samples view can't be used at the same time

If users give two options --show-total-period and --show-nr-samples, show their proper usage because the two options can not be used at the same time. Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/builtin-annotate.c | 8 ++-- 1 file changed, 6 insertions(+), 2

[PATCH v2 3/4] perf annotate browser: Support --show-nr-samples option

Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/ui/browsers/annotate.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c index 80f38da..faca1b9 100644 --- a/tools

[PATCH v2 0/4] perf annotate: Support --show-nr-samples and circulating view

7;d appreciate some feedback on my patchkit. :) The code is available on 'perf/ann-nr-samples' branch at git://github.com/taeung/linux-perf.git Thanks, Taeung v2: - period and nr-samples view can't be used at the same time (Arnaldo) Taeung Song (4): perf annotate stdio: Sup

[PATCH v2 1/4] perf annotate stdio: Support --show-nr-samples option

Add --show-nr-samples option to perf-annotate so that it corresponds with perf-report. Cc: Namhyung Kim Cc: Milian Wolff Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/builtin-annotate.c | 2 ++ tools/perf/util/annotate.c| 6 +- 2 files changed, 7 insertions(+), 1 deletion

Re: [PATCH v4 5/9] perf annotate stdio: Support --show-nr-samples option

On 08/15/2017 01:31 AM, Arnaldo Carvalho de Melo wrote: Em Mon, Aug 14, 2017 at 07:42:07PM +0900, Taeung Song escreveu: On 08/01/2017 03:24 PM, Taeung Song wrote: On 07/29/2017 01:26 AM, Arnaldo Carvalho de Melo wrote: Em Fri, Jul 28, 2017 at 01:16:16AM +0900, Taeung Song escreveu: Add

Re: [PATCH v4 5/9] perf annotate stdio: Support --show-nr-samples option

Hi Arnaldo, On 08/01/2017 03:24 PM, Taeung Song wrote: On 07/29/2017 01:26 AM, Arnaldo Carvalho de Melo wrote: Em Fri, Jul 28, 2017 at 01:16:16AM +0900, Taeung Song escreveu: Add --show-nr-samples option to perf-annotate so that it corresponds with perf-report. So this is not that

[PATCH 0/3] perf annotate: Support --show-nr-samples and circulating view

7;d appreciate some feedback on my patchkit. :) The code is available on 'perf/ann-nr-samples' branch at git://github.com/taeung/linux-perf.git Thanks, Taeung Taeung Song (3): perf annotate stdio: Support --show-nr-samples option perf annotate browser: Support --show-nr-sample

[PATCH 1/3] perf annotate stdio: Support --show-nr-samples option

Add --show-nr-samples option to perf-annotate so that it corresponds with perf-report. Cc: Namhyung Kim Cc: Milian Wolff Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/builtin-annotate.c | 2 ++ tools/perf/util/annotate.c| 6 +- 2 files changed, 7 insertions(+), 1 deletion

[PATCH 3/3] perf annotate browser: Circulate percent, total period and samples view

With a existing 't' hotkey, support the three view based on percent, total period and number of samples on the annotate TUI browser, circulating them like below: Percent -> Period -> Samples -> Percent ... Suggested-by: Namhyung Kim Cc: Milian Wolff Cc: Jiri Olsa Signed-

[PATCH 2/3] perf annotate browser: Support --show-nr-samples option

Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/ui/browsers/annotate.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c index 80f38da..faca1b9 100644 --- a/tools

Re: [PATCH v4 3/9] perf anntoate browser: Fix the toggle total period view showing number of samples

On 07/28/2017 01:57 AM, Arnaldo Carvalho de Melo wrote: Em Fri, Jul 28, 2017 at 01:16:02AM +0900, Taeung Song escreveu: Currently the toggle total period view on the annotate TUI shows the number of samples, not period like below. So fix the toggle total period view on the annotate TUI like

Re: [PATCH v4 5/9] perf annotate stdio: Support --show-nr-samples option

On 07/29/2017 01:26 AM, Arnaldo Carvalho de Melo wrote: Em Fri, Jul 28, 2017 at 01:16:16AM +0900, Taeung Song escreveu: Add --show-nr-samples option to perf-annotate so that it corresponds with perf-report. So this is not that intuitive, i.e. if one ask for: perf annotate --show-total

Re: [PATCH v4 5/9] perf annotate stdio: Support --show-nr-samples option

On 07/29/2017 01:26 AM, Arnaldo Carvalho de Melo wrote: Em Fri, Jul 28, 2017 at 01:16:16AM +0900, Taeung Song escreveu: Add --show-nr-samples option to perf-annotate so that it corresponds with perf-report. So this is not that intuitive, i.e. if one ask for: perf annotate --show-total

[tip:perf/core] perf annotate TUI: Fix --show-total-period

Commit-ID: 29dc267f270a4ad5ae1341e7fdc8539ac7dc907a Gitweb: http://git.kernel.org/tip/29dc267f270a4ad5ae1341e7fdc8539ac7dc907a Author: Taeung Song AuthorDate: Thu, 27 Jul 2017 11:33:20 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 28 Jul 2017 12:53:06 -0300 perf annotate

[tip:perf/core] perf annotate TUI: Fix column header when toggling period/percent

Commit-ID: f67d395c6e3895c3c8c67c8f7523f6a94d61a82d Gitweb: http://git.kernel.org/tip/f67d395c6e3895c3c8c67c8f7523f6a94d61a82d Author: Taeung Song AuthorDate: Fri, 28 Jul 2017 12:04:32 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 28 Jul 2017 12:53:08 -0300 perf annotate

[PATCH v4 5/9] perf annotate stdio: Support --show-nr-samples option

Add --show-nr-samples option to perf-annotate so that it corresponds with perf-report. Cc: Namhyung Kim Cc: Milian Wolff Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/builtin-annotate.c | 2 ++ tools/perf/util/annotate.c| 6 +- 2 files changed, 7 insertions(+), 1 deletion

[PATCH v4 7/9] perf annotate browser: Circulate percent, total period, samples view

Olsa Signed-off-by: Taeung Song --- tools/perf/ui/browsers/annotate.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c index 6b57e87..6c4db1d 100644 --- a/tools/perf/ui/browsers/annotate.c

[PATCH v4 9/9] perf annotate: Calculate the percentage with period or number of samples

To correspond with perf-report using the sample period for the percentage calculation, calculate the percentage with period. But if --show-nr-samples was used, figure out the percentage by number of samples. Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/util

[PATCH v4 8/9] perf annotate: Check total period before calculating percent

Before calculating percent, checking total period is clear and safer than checking just number of samples. So fix it. Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Taeung Song --- tools/perf/util/annotate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf

[PATCH v4 6/9] perf annotate browser: Support --show-nr-samples option

Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/ui/browsers/annotate.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c index 9fd4413..6b57e87 100644 --- a/tools

[PATCH v4 4/9] perf annotate browser: Show the proper header when using --show-total-period

Currently a first column is only "Percent", so fix it to show correct column name based on given options. (e.g. if using --show-total-period or a 't' hotkey, show "Event count" as a first column) Reported-by: Milian Wolff Cc: Namhyung Kim Cc: Jiri Olsa Signed-o

[PATCH v4 2/9] perf annotate: Initialize proper width for first column

When using --show-total-period or not, set the width value for first column. Suggested-by: Arnaldo Carvalho de Melo Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/util/annotate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/util

[PATCH v4 3/9] perf anntoate browser: Fix the toggle total period view showing number of samples

$0x38,%rsp 2204022 │ mov%rax,(%rsp) 2207405 │ mov%rcx,0x8(%rsp) Reported-by: Namhyung Kim Cc: Milian Wolff Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/ui/browsers/annotate.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/t

[PATCH v4 0/9] perf annotate: Fix --show-total-period and support --show-nr-samples

period So fix this option on both the annotate stdio and TUI browser. And support --show-nr-samples into perf-anntate so that it correpond with perf-report's. The code is available on 'perf/ann-fix-period-v4' branch at git://github.com/taeung/linux-perf.git Thanks, Taeung v4

[PATCH v4 1/9] perf annotate: Widen "Event count" column when using --show-total-period

Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Taeung Song --- tools/perf/util/annotate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c index c2b4b00..5963764 100644 --- a/tools/perf/util/annotate.c +++ b/tools/perf

Re: [PATCH v3 3/9] perf annotate: Fix wrong --show-total-period option showing number of samples

On 07/27/2017 05:17 AM, Arnaldo Carvalho de Melo wrote: Em Wed, Jul 26, 2017 at 08:57:13PM +0900, Taeung Song escreveu: On 07/26/2017 01:17 AM, Arnaldo Carvalho de Melo wrote: Em Wed, Jul 26, 2017 at 12:53:28AM +0900, Taeung Song escreveu: On 07/25/2017 11:42 PM, Arnaldo Carvalho de Melo

[tip:perf/core] perf annotate stdio: Fix column header when using --show-total-period

Commit-ID: 38d2dcd0ccf85b55d783edbfc14fd8dea4d55b73 Gitweb: http://git.kernel.org/tip/38d2dcd0ccf85b55d783edbfc14fd8dea4d55b73 Author: Taeung Song AuthorDate: Tue, 25 Jul 2017 06:28:42 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 25 Jul 2017 22:46:37 -0300 perf annotate

[tip:perf/core] perf annotate stdio: Fix --show-total-period

Commit-ID: 585d93c5ffccced26689e34095c0d74ef20a07d6 Gitweb: http://git.kernel.org/tip/585d93c5ffccced26689e34095c0d74ef20a07d6 Author: Taeung Song AuthorDate: Fri, 21 Jul 2017 11:58:20 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 25 Jul 2017 11:23:36 -0300 perf annotate

[tip:perf/core] perf annotate: Do not overwrite sample->period

Commit-ID: ecd5f9959d2c9540482977ff1208ea67fbfb8cc9 Gitweb: http://git.kernel.org/tip/ecd5f9959d2c9540482977ff1208ea67fbfb8cc9 Author: Taeung Song AuthorDate: Fri, 21 Jul 2017 11:38:48 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 21 Jul 2017 12:02:52 -0300 perf annotate

[tip:perf/core] perf hists: Pass perf_sample to __symbol__inc_addr_samples()

Commit-ID: bab89f6aed7e745893e009014354d0caaf62acf7 Gitweb: http://git.kernel.org/tip/bab89f6aed7e745893e009014354d0caaf62acf7 Author: Taeung Song AuthorDate: Thu, 20 Jul 2017 16:28:53 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 21 Jul 2017 08:23:50 -0300 perf hists

[tip:perf/core] perf annotate: Store the sample period in each histogram bucket

Commit-ID: 461c17f00f400f95116880d91d20a7fcd84263a9 Gitweb: http://git.kernel.org/tip/461c17f00f400f95116880d91d20a7fcd84263a9 Author: Taeung Song AuthorDate: Thu, 20 Jul 2017 17:18:05 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 21 Jul 2017 12:02:38 -0300 perf annotate

[tip:perf/core] perf annotate: Rename 'sum' to 'nr_samples' in struct sym_hist

Commit-ID: 8158683da3d30e0346275702a8e08f2b22726c45 Gitweb: http://git.kernel.org/tip/8158683da3d30e0346275702a8e08f2b22726c45 Author: Taeung Song AuthorDate: Thu, 20 Jul 2017 06:36:51 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 21 Jul 2017 08:23:49 -0300 perf annotate

[tip:perf/core] perf annotate: Introduce struct sym_hist_entry

Commit-ID: 896bccd3cb8d95cbc565687715516009c5169e71 Gitweb: http://git.kernel.org/tip/896bccd3cb8d95cbc565687715516009c5169e71 Author: Taeung Song AuthorDate: Thu, 20 Jul 2017 06:36:45 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 21 Jul 2017 08:23:38 -0300 perf annotate

Re: [PATCH v3 3/9] perf annotate: Fix wrong --show-total-period option showing number of samples

Hello Arnaldo :) On 07/26/2017 01:17 AM, Arnaldo Carvalho de Melo wrote: Em Wed, Jul 26, 2017 at 12:53:28AM +0900, Taeung Song escreveu: On 07/25/2017 11:42 PM, Arnaldo Carvalho de Melo wrote: Moreover there is the below case that is not aligned due to big period values. So, that "mor

Re: [PATCH v3 3/9] perf annotate: Fix wrong --show-total-period option showing number of samples

Hi Arnaldo, On 07/25/2017 11:42 PM, Arnaldo Carvalho de Melo wrote: Em Tue, Jul 25, 2017 at 06:28:42AM +0900, Taeung Song escreveu: On 07/25/2017 02:37 AM, Arnaldo Carvalho de Melo wrote: The one above, look further down, from 896bccd3cb8d to 0321d0281cbb, there are some more missing, but the

Re: [PATCH v3 3/9] perf annotate: Fix wrong --show-total-period option showing number of samples

On 07/25/2017 02:37 AM, Arnaldo Carvalho de Melo wrote: Em Mon, Jul 24, 2017 at 10:51:58AM +0900, Taeung Song escreveu: Hi Arnaldo, Sorry, I'm too late. On 07/21/2017 08:24 PM, Arnaldo Carvalho de Melo wrote: Em Fri, Jul 21, 2017 at 06:41:29PM +0900, Taeung Song escreveu: On 07/21/20

Re: [PATCH v3 3/9] perf annotate: Fix wrong --show-total-period option showing number of samples

Hi Arnaldo, Sorry, I'm too late. On 07/21/2017 08:24 PM, Arnaldo Carvalho de Melo wrote: Em Fri, Jul 21, 2017 at 06:41:29PM +0900, Taeung Song escreveu: On 07/21/2017 04:19 AM, Arnaldo Carvalho de Melo wrote: Em Thu, Jul 20, 2017 at 06:36:55AM +0900, Taeung Song escreveu: Currentl

Re: [PATCH v3 3/9] perf annotate: Fix wrong --show-total-period option showing number of samples

On 07/21/2017 04:19 AM, Arnaldo Carvalho de Melo wrote: Em Thu, Jul 20, 2017 at 06:36:55AM +0900, Taeung Song escreveu: Currently the --show-total-period option of perf-annotate is different from perf-report's. For example, perf-report ordinarily shows period and number of sa

Re: [PATCH v3 2/9] perf annotate: Properly rename 'sum' to 'total_samples' in struct sym_hist

Hi Arnaldo, On 07/21/2017 04:13 AM, Arnaldo Carvalho de Melo wrote: Em Thu, Jul 20, 2017 at 06:36:51AM +0900, Taeung Song escreveu: Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song Better to rename it to symhist->nr_samples, to be consistent with the per address nr_samples,

[RESEND PATCH v3 9/9] perf annotate: Calculate the percentage with period or number of samples

To correspond with perf-report using the sample period for the percentage calculation, calculate the percentage with period. But if --show-nr-samples was used, figure out the percentage by number of samples. Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/util

[PATCH v3 2/9] perf annotate: Properly rename 'sum' to 'total_samples' in struct sym_hist

Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/ui/gtk/annotate.c | 2 +- tools/perf/util/annotate.c | 22 +++--- tools/perf/util/annotate.h | 2 +- 3 files changed, 13 insertions(+), 13 deletions(-) diff --git a/tools/perf/ui/gtk/annotate.c b

[PATCH v3 4/9] perf annotate: Show the proper header when using --show-total-period

Currently a first column is only "Percent", so fix it to show correct column name based on given options. (e.g. if using --show-total-period, show "Event count" as a first column) Reported-by: Milian Wolff Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song

[PATCH v3 7/9] perf annotate: Support --show-nr-samples option

Add --show-nr-samples option to perf-annotate so that it corresponds with perf-report. Cc: Namhyung Kim Cc: Milian Wolff Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/builtin-annotate.c | 2 ++ tools/perf/util/annotate.c| 6 +- 2 files changed, 7 insertions(+), 1 deletion

[PATCH v3 5/9] perf anntoate browser: Fix the toggle total period view to show period, not number of samples

$0x38,%rsp 2204022 │ mov%rax,(%rsp) 2207405 │ mov%rcx,0x8(%rsp) Reported-by: Namhyung Kim Cc: Milian Wolff Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/ui/browsers/annotate.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/t

[PATCH v3 9/9] perf annotate: Use the sample period when calculating the percentage

Currently the percentages of perf-annotate are calculated with number of samples, not the sample period. So fix it to correspond with perf-report using the sample period for the calculation. Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/util/annotate.c | 23

[PATCH v3 8/9] perf annotate browser: Circulate percent, total period, samples view

Olsa Signed-off-by: Taeung Song --- tools/perf/ui/browsers/annotate.c | 28 1 file changed, 24 insertions(+), 4 deletions(-) diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c index 7800fe2..8ecc519 100644 --- a/tools/perf/ui/browsers/ann

[PATCH v3 6/9] perf annotate browser: Show the proper header when using --show-total-period

Currently a first column is only "Percent", so fix it to show correct column name based on given options. (e.g. if using --show-total-period or a 't' hotkey, show "Event count" as a first column) Reported-by: Milian Wolff Cc: Namhyung Kim Cc: Jiri Olsa Signed-o

[PATCH v3 0/9] perf annotate: Fix --show-total-period and support --show-nr-samples

period So fix this option on both the annotate stdio and TUI browser. And support --show-nr-samples into perf-anntate so that it correpond with perf-report's. The code is available on 'perf/ann-fix-period-v3' branch at git://github.com/taeung/linux-perf.git Thanks, Taeung

[PATCH v3 3/9] perf annotate: Fix wrong --show-total-period option showing number of samples

section .text: : : 00400816 : : knapsack(): 743737 :400816: push %rbp Reported-by: Namhyung Kim Cc: Milian Wolff Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/builtin-annotate.c | 4 +--- tools/perf/builtin-report.c | 13 ++---

[PATCH v3 1/9] perf annotate: Introduce struct sym_hist_entry

struct sym_hist has addr[] but it should have not only number of samples but also the sample period. So use new struct symhist_entry for that. Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/ui/browsers/annotate.c | 6 +++--- tools/perf/ui/gtk/annotate.c | 4

Re: [PATCH v2 9/9] perf annotate: Use the sample period when calculating the percentage

On 07/19/2017 01:23 AM, Namhyung Kim wrote: On Fri, Jul 14, 2017 at 02:46:20AM +0900, Taeung Song wrote: Currently the percentages of perf-annotate are calculated with number of samples, not the sample period. So fix it to correspond with perf-report using the sample period for the

Re: [PATCH v2 8/9] perf annotate browser: Support the toggle number of samples with a 'e' hotkey

On 07/19/2017 01:18 AM, Namhyung Kim wrote: On Fri, Jul 14, 2017 at 02:46:16AM +0900, Taeung Song wrote: Cc: Namhyung Kim Cc: Milian Wolff Cc: Jiri Olsa Signed-off-by: Taeung Song Hmm.. IIUC there're 3 modes of annotation view: percent, period and sample, right? The existing '

Re: [PATCH v2 0/9] perf annotate: Fix --show-total-period and support --show-nr-samples

Hi Namhyung, I'm late. Thanks for your review. On 07/19/2017 01:07 AM, Namhyung Kim wrote: Hi Taeung, On Fri, Jul 14, 2017 at 02:45:44AM +0900, Taeung Song wrote: Hello, Currently the --show-total-period option of perf-annotate is different from perf-report's. It has two problem

[PATCH v2 5/9] perf anntoate browser: Fix the toggle total period view to show period, not number of samples

$0x38,%rsp 2204022 │ mov%rax,(%rsp) 2207405 │ mov%rcx,0x8(%rsp) Reported-by: Namhyung Kim Cc: Milian Wolff Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/ui/browsers/annotate.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/t

[PATCH v2 2/9] perf annotate: Properly rename 'sum' to 'total_samples' in struct sym_hist

Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/ui/gtk/annotate.c | 2 +- tools/perf/util/annotate.c | 22 +++--- tools/perf/util/annotate.h | 2 +- 3 files changed, 13 insertions(+), 13 deletions(-) diff --git a/tools/perf/ui/gtk/annotate.c b

[PATCH v2 6/9] perf annotate browser: Show the proper header when using --show-total-period

Currently a first column is only "Percent", so fix it to show correct column name based on given options. (e.g. if using --show-total-period or a 't' hotkey, show "Event count" as a first column) Reported-by: Milian Wolff Cc: Namhyung Kim Cc: Jiri Olsa Signed-o

[PATCH v2 7/9] perf annotate: Support --show-nr-samples option

Add --show-nr-samples option to perf-annotate so that it corresponds with perf-report. Cc: Namhyung Kim Cc: Milian Wolff Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/builtin-annotate.c | 2 ++ tools/perf/util/annotate.c| 6 +- 2 files changed, 7 insertions(+), 1 deletion

[PATCH v2 8/9] perf annotate browser: Support the toggle number of samples with a 'e' hotkey

Cc: Namhyung Kim Cc: Milian Wolff Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/ui/browsers/annotate.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c index 34b3189..19173b1

[PATCH v2 9/9] perf annotate: Use the sample period when calculating the percentage

Currently the percentages of perf-annotate are calculated with number of samples, not the sample period. So fix it to correspond with perf-report using the sample period for the calculation. Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/util/annotate.c | 11

[PATCH v2 4/9] perf annotate: Show the proper header when using --show-total-period

Currently a first column is only "Percent", so fix it to show correct column name based on given options. (e.g. if using --show-total-period, show "Event count" as a first column) Reported-by: Milian Wolff Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song

  1   2   3   4   5   6   7   8   9   >