Re: [PATCH v2 1/6] dt-bindings: reset: Add PDC Global binding for SDM845 SoCs

Hi Matthias, Thanks for the review On 2018-08-28 06:08, Matthias Kaehlcke wrote: Hi Sibi, On Fri, Aug 24, 2018 at 06:48:55PM +0530, Sibi Sankar wrote: Add PDC Global(Power Domain Controller) binding for SDM845 SoCs. nit: missing blank before the opening parenthesis. Will fix it Signed-

[PATCH 4/6] dt-bindings: remoteproc: Add Q6v5 Modem PIL binding for SDM845

Add new compatible string for Qualcomm SDM845 SoCs Signed-off-by: sibis --- Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt b/Documentation/devicetree

[PATCH 5/6] remoteproc: qcom: Add support for mss remoteproc on SDM845

>From SDM845, the Q6SS reset sequence on software side has been simplified with the introduction of boot FSM which assists in bringing the Q6 out of reset Add GLINK subdevice to allow definition of GLINK edge as a child of modem-pil Signed-off-by: sibis --- drivers/remoteproc/qcom_q6v5_pi

[PATCH 1/6] reset: qcom: AOSS (Always on subsystem) reset controller

Add reset controller driver for Qualcomm SDM845 SoC to control reset signals provided by AOSS for Modem, Venus ADSP, GPU, Camera, Wireless, Display subsystem Signed-off-by: sibis --- .../devicetree/bindings/reset/qcom,aoss-reset.txt | 54 drivers/reset/Kconfig

[PATCH 2/6] dt-bindings: mailbox: Add APCS global binding for SDM845 SoCs

Include SDM845 APCS binding to the list of possible bindings Signed-off-by: sibis --- Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt b

[PATCH 3/6] mailbox: Add support for Qualcomm SDM845 SoCs

Add the corresponding APCS offset for SDM845 SoC Signed-off-by: sibis --- drivers/mailbox/qcom-apcs-ipc-mailbox.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c index 57bde0d..62d704d 100644 --- a/drivers

[PATCH 6/6] remoteproc: qcom: Always assert and deassert reset signals in SDM845

functions to handle SoC specific reset sequences Signed-off-by: sibis --- drivers/remoteproc/qcom_q6v5_pil.c | 100 ++--- 1 file changed, 94 insertions(+), 6 deletions(-) diff --git a/drivers/remoteproc/qcom_q6v5_pil.c b/drivers/remoteproc/qcom_q6v5_pil.c index 92bf125

[PATCH 0/6] Add support for remoteproc modem-pil on SDM845 SoCs

adds helper functions for arbitrary reset assert/deassert sequences V2: Addressed reset-qcom-aoss review suggestions and reworked re-ordering of the active clk and reset sequence in qcom_q6v5_pil sibis (6): reset: qcom: AOSS (Always on subsystem) reset controller dt-bindings: mailbox

[PATCH 2/6] dt-bindings: mailbox: Add APCS global binding for SDM845 SoCs

Include SDM845 APCS binding to the list of possible bindings Signed-off-by: sibis --- Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt b

[PATCH 4/6] dt-bindings: remoteproc: Add Q6v5 Modem PIL binding for SDM845

Add new compatible string for Qualcomm SDM845 SoCs Signed-off-by: sibis --- Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt b/Documentation/devicetree

[PATCH 5/6] remoteproc: qcom: Add support for mss remoteproc on SDM845

set start/stop helper functions to handle SoC specific reset sequences Signed-off-by: sibis --- drivers/remoteproc/qcom_q6v5_pil.c | 134 +++-- 1 file changed, 129 insertions(+), 5 deletions(-) diff --git a/drivers/remoteproc/qcom_q6v5_pil.c b/drivers/remotep

[PATCH 3/6] mailbox: Add support for Qualcomm SDM845 SoCs

Add the corresponding APCS offset for SDM845 SoC Signed-off-by: sibis --- drivers/mailbox/qcom-apcs-ipc-mailbox.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c index 57bde0d..62d704d 100644 --- a/drivers

[PATCH 6/6] remoteproc: qcom: Reorder active clks enable and reset

Active clks need to be enabled before Asserting/Deasserting the reset lines in SDM845 Signed-off-by: sibis --- drivers/remoteproc/qcom_q6v5_pil.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/remoteproc/qcom_q6v5_pil.c b/drivers/remoteproc

[PATCH 0/6] Add support for remoteproc modem-pil on SDM845 SoCs

adds helper functions for arbitrary reset assert/deassert sequences. sibis (6): reset: qcom: AOSS (Always on subsystem) reset controller dt-bindings: mailbox: Add APCS global binding for SDM845 SoCs mailbox: Add support for Qualcomm SDM845 SoCs dt-bindings: remoteproc: Add Q6v5 Modem PIL

[PATCH 1/6] reset: qcom: AOSS (Always on subsystem) reset controller

Add reset controller driver for Qualcomm SDM845 SoC to control reset signals provided by AOSS for Modem, Venus ADSP, GPU, Camera, Wireless, Display subsystem Signed-off-by: sibis --- .../devicetree/bindings/reset/qcom,aoss-reset.txt | 54 +++ drivers/reset/Kconfig