Hi Bjorn,
I just sent a patch regarding pcie Kconfig in arch/ . I just wanted to ask how
did you get these errors you pasted:
> drivers/pci/pcie/Kconfig:61:warning: choice value used outside its choice
> group
> drivers/pci/pcie/Kconfig:67:warning: choice value used outside its choice
> group
As Joe suggested I changed the “type * “ function params which I screwed up
along the way and amended and resend the patch
related to whitespace issues in drivers/pci.
Thanks, Sasa
{
name: Bogicevic Sasa
phone: +381606006200
}
--
To unsubscribe from this list: send the line "un
Hi Joe,
No this is not done with checkpatch.pl I just used it to verify that my changes
are correct. I was wondering why that “type” pointer threw errors since it
looks fine to me the way it was declared. This “type*” is just present in few
of the files I can just redo those changes and send the
Sure thing, back to the laboratory :)
{
name: Bogicevic Sasa
phone: +381606006200
}
> On Dec 17, 2015, at 22:55, Bjorn Helgaas wrote:
>
> Hi Bogicevic,
>
> On Fri, Dec 11, 2015 at 08:03:44AM -0800, Bogicevic Sasa wrote:
>> This fixes all sorts of whitespace errors and warnings
Hi Thomas,
I just went with checkpatch.pl approach I hope this patch didn’t ruin your day
:)
{
name: Bogicevic Sasa
phone: +381606006200
}
> On Dec 12, 2015, at 13:23, Thomas Petazzoni
> wrote:
>
> Dear Bogicevic Sasa,
>
> On Sat, 12 Dec 2015 03:41:48 -0800, Bogicevic Sasa
015 at 12:07:03AM +0100, sasa bogicevic wrote:
>> I wanted to start with approach one error one folder so I did “space
>> prohibited before ,” in just hotplug folder. I used checkpatch script to see
>> if I nailed it and the output was fine.
>> When I do grep -rl I also ge
Ha just found the lines when I removed the -l flag
drivers/pci/hotplug/shpchp_ctrl.c: ctrl_dbg(ctrl, "%s: p_slot->device,
slot_offset, hp_slot = %d, %d ,%d\n",
drivers/pci/hotplug/cpqphp_ctrl.c: dbg("%s: func->device, slot_offset,
hp_slot = %d, %d ,%d\n",
So there are spaces before th
I wanted to start with approach one error one folder so I did “space prohibited
before ,” in just hotplug folder. I used checkpatch script to see if I nailed
it and the output was fine.
When I do grep -rl I also get the same result eventhou when I look at the, for
example, drivers/pci/hotplug/sh
> On Nov 26, 2015, at 8:36 PM, Joe Perches wrote:
>
> On Thu, 2015-11-26 at 16:50 +0100, Bogicevic Sasa wrote:
>> This fixes all errors "space prohibited between function name and
>> open parenthesis '(' " in all files in drivers/pci/hotplug folder
>
> It's good when sending this sort of patch
9 matches
Mail list logo
