Re: [PATCH] parisc: avoid a warning on u8 cast for cmpxchg on u8 pointers

2021-04-06 Thread Rolf Eike Beer
Am Dienstag, 6. April 2021, 06:59:29 CEST schrieb Gao Xiang: > From: Gao Xiang > > commit b344d6a83d01 ("parisc: add support for cmpxchg on u8 pointers") > can generate a sparse warningi ("cast truncates bits from constant ^ > value"), which has been reported severa

[PATCH] typo: kthead -> kthread

2021-03-17 Thread Rolf Eike Beer
Signed-off-by: Rolf Eike Beer --- kernel/rcu/tree_plugin.h | 2 +- mm/oom_kill.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h index 2d603771c7dc..5f22869d7c66 100644 --- a/kernel/rcu/tree_plugin.h +++ b

Re: [PATCH RFCv2] mm/madvise: introduce MADV_POPULATE_(READ|WRITE) to prefault/prealloc memory

2021-03-08 Thread Rolf Eike Beer
diff --git a/mm/internal.h b/mm/internal.h index 9902648f2206..a5c4ed23b1db 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -340,6 +340,9 @@ void __vma_unlink_list(struct mm_struct *mm, struct vm_area_struct *vma); #ifdef CONFIG_MMU extern long populate_vma_page_range(struct vm_area_struct *vm

[PATCH] Kconfig: fix help text of TRACEPOINT_BENCHMARK

2021-03-02 Thread Rolf Eike Beer
Signed-off-by: Rolf Eike Beer --- kernel/trace/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig index 9c266b93cbc0..7fa82778c3e6 100644 --- a/kernel/trace/Kconfig +++ b/kernel/trace/Kconfig @@ -694,7 +694,7 @@ config

[PATCH] simplify copy_mm()

2021-02-18 Thread Rolf Eike Beer
All this can happen without a single goto. Signed-off-by: Rolf Eike Beer --- kernel/fork.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/kernel/fork.c b/kernel/fork.c index d66cd1014211..1cad8c622b34 100644 --- a/kernel/fork.c +++ b/kernel/fork.c

Re: [PATCH RFC] mm/madvise: introduce MADV_POPULATE to prefault/prealloc memory

2021-02-18 Thread Rolf Eike Beer
Let's introduce MADV_POPULATE with the following semantics 1. MADV_POPULATED does not work on PROT_NONE and special VMAs. It works on everything else. 2. Errors during MADV_POPULATED (especially OOM) are reported. If we hit hardware errors on pages, ignore them - nothing we really can or

Re: [PATCH] scripts: Fix linking extract-cert against libcrypto

2021-02-11 Thread Rolf Eike Beer
Am Donnerstag, 11. Februar 2021, 11:29:33 CET schrieb Rolf Eike Beer: > I'm just guessing, but your build error looks like you are also > cross-building the tools, which is wrong. You want them to be host-tools. > So don't export PKG_CONFIG_SYSROOT_DIR, it would then

Re: [PATCH] scripts: Fix linking extract-cert against libcrypto

2021-02-11 Thread Rolf Eike Beer
Am Dienstag, 9. Februar 2021, 09:44:33 CET schrieb Rolf Eike Beer: > Am Dienstag, 9. Februar 2021, 05:59:56 CET schrieb Daniel Díaz: > > When compiling under OpenEmbedded, the following error is seen > > > > as of recently: > > /srv/oe/build/tmp/hosttools/ld: cannot

Re: [PATCH] scripts: Fix linking extract-cert against libcrypto

2021-02-11 Thread Rolf Eike Beer
Am Dienstag, 9. Februar 2021, 09:44:33 CET schrieb Rolf Eike Beer: > Am Dienstag, 9. Februar 2021, 05:59:56 CET schrieb Daniel Díaz: > > When compiling under OpenEmbedded, the following error is seen > > > > as of recently: > > /srv/oe/build/tmp/hosttools/ld: cannot

Re: [PATCH] scripts: Fix linking extract-cert against libcrypto

2021-02-09 Thread Rolf Eike Beer
invoke the linker, ‘ld’. LOADLIBES is a > deprecated (but still supported) alternative to LDLIBS. > Non-library linker flags, such as -L, should go in the > LDFLAGS variable. Correct. And the patch I use for my local 4.19 build actually uses LDLIBS, so it must have gone wro

Re: [PATCH 5.10 000/120] 5.10.15-rc1 review

2021-02-08 Thread Rolf Eike Beer
_nonshared.a inside / | /srv/oe/build/tmp-lkft-glibc/hosttools/ld: cannot find /lib/ld-linux- x86-64.so.2 inside / Can you provide a log with V=1 where we can see what actually is going on? Eike -- Rolf Eike Beer, emlix GmbH, http://www.emlix.com Fon +49 551 30664-0, Fax +49 551 30664-11 Gothaer Pl

[PATCH v6] scripts: use pkg-config to locate libcrypto

2021-01-27 Thread Rolf Eike Beer
>From f467f251e44cd406c9556ea7d68d131f56e0d832 Mon Sep 17 00:00:00 2001 From: Rolf Eike Beer Date: Thu, 22 Nov 2018 16:40:49 +0100 Subject: [PATCH] scripts: use pkg-config to locate libcrypto Otherwise build fails if the headers are not in the default location. While at it also ask pkg-con

Re: [PATCH v5] scripts: use pkg-config to locate libcrypto

2021-01-26 Thread Rolf Eike Beer
Am Mittwoch, 13. Januar 2021, 13:49:12 CET schrieb Rolf Eike Beer: > Otherwise build fails if the headers are not in the default location. While > at it also ask pkg-config for the libs, with fallback to the existing > value. Can someone please take this through the kbuild-tree? Noone se

Re: [PATCH v5] scripts: use pkg-config to locate libcrypto

2021-01-26 Thread Rolf Eike Beer
Am Dienstag, 26. Januar 2021, 07:30:03 CET schrieb Masahiro Yamada: > On Tue, Jan 26, 2021 at 2:42 PM Rolf Eike Beer wrote: > > Am Mittwoch, 13. Januar 2021, 13:49:12 CET schrieb Rolf Eike Beer: > > > Otherwise build fails if the headers are not in the default location. >

[PATCH v5] scripts: use pkg-config to locate libcrypto

2021-01-13 Thread Rolf Eike Beer
Otherwise build fails if the headers are not in the default location. While at it also ask pkg-config for the libs, with fallback to the existing value. Signed-off-by: Rolf Eike Beer Cc: sta...@vger.kernel.org # 5.6.x --- scripts/Makefile | 10 -- 1 file changed, 8 insertions(+), 2

Re: [PATCH] kbuild: improve libelf detection

2021-01-13 Thread Rolf Eike Beer
LDFLAGS. > > This makes the check in the core Makefile match the check that is done > in tools/objtool/Makefile. Specifically, the C compiler is passed the > full KBUILD_HOSTCFLAGS and KBUILD_HOSTLDFLAGS, which may have set up > additional sysroot/include/library search paths to find li

[PATCH] Documentation: fix typos in split page table lock description

2021-01-12 Thread Rolf Eike Beer
Signed-off-by: Rolf Eike Beer --- Documentation/vm/split_page_table_lock.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/vm/split_page_table_lock.rst b/Documentation/vm/split_page_table_lock.rst index ff51f4a5494d..c08919662704 100644 --- a/Documentation/vm

Re: [RFC PATCH] treewide: remove bzip2 compression support

2020-11-19 Thread Rolf Eike Beer
Am 2020-11-17 23:32, schrieb Alex Xu (Hello71): bzip2 is either slower or larger than every other supported algorithm, according to benchmarks at [0]. It is far slower to decompress than any other algorithm, and still larger than lzma, xz, and zstd. diff --git a/Documentation/x86/boot.rst b/D

[PATCH] binfmt_elf: simplify error handling in load_elf_phdrs()

2020-11-03 Thread Rolf Eike Beer
Signed-off-by: Rolf Eike Beer --- fs/binfmt_elf.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index b588d1291b25..74827a7a06d0 100644 --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -458,7 +458,7 @@ static struct elf_phdr

fix typos in "compress" variants

2020-11-03 Thread Rolf Eike Beer
Signed-off-by: Rolf Eike Beer --- arch/x86/kernel/head64.c | 2 +- fs/f2fs/data.c | 2 +- scripts/kallsyms.c | 2 +- scripts/spelling.txt | 3 +++ 4 files changed, 6 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/head64.c b/arch/x86/kernel/head64.c index

Re: [PATCH 00/14] drop double zeroing

2020-09-23 Thread Rolf Reintjes
-next Thanks! I do not understand which of the 14 patches you applied. Your mail responds to the 00/14 mail. Rolf [1/1] spi/topcliff-pch: drop double zeroing commit: ca03dba30f2b8ff45a2972c6691e4c96d8c52b3b All being well this means that it will be integrated into the linux-next tree (us

binfmt_elf: simplify error handling in load_elf_phdrs()

2020-08-05 Thread Rolf Eike Beer
retval) { kfree(elf_phdata); elf_phdata = NULL; } -- 2.28.0 -- Rolf Eike Beer, emlix GmbH, http://www.emlix.com Fon +49 551 30664-0, Fax +49 551 30664-11 Gothaer Platz 3, 37083 Göttingen, Germany Sitz der Gesellschaft: Göttingen, Amtsgericht Göttingen HR

[PATCH] binfmt_elf: fix documented return value for load_elf_phdrs()

2020-08-05 Thread Rolf Eike Beer
This function has never returned anything but a plain NULL. Fixes: 6a8d38945cf4e6e819d6b550250615db763065a0 Signed-off-by: Rolf Eike Beer --- fs/binfmt_elf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index 9fe3b51c116a..251298d25c8c

Re: [PATCH v4] scripts: use pkg-config to locate libcrypto

2020-07-30 Thread Rolf Eike Beer
Am Montag, 27. April 2020, 10:11:28 CEST schrieb Rolf Eike Beer: > From 082ba542ca4c710dcf592a6f9233603b9275d05d Mon Sep 17 00:00:00 2001 > From: Rolf Eike Beer > Date: Thu, 22 Nov 2018 16:40:49 +0100 > Subject: [PATCH 1/2] scripts: use pkg-config to locate libcrypto > > Otherw

Re: [PATCH] parisc: suppress error messages for 'make clean'

2020-06-13 Thread Rolf Eike Beer
Helge Deller wrote: > On 10.05.20 03:19, Masahiro Yamada wrote: > > Hi Helge, > > > > On Sun, May 10, 2020 at 2:39 AM Helge Deller wrote: > > I will drop this patch from my kbuild tree, > > then you will apply what you think is best > > to your tree. > > > > What do you think? > > Sure, I'll t

Re: [PATCH 08/12] parisc: use pgtable-nopXd instead of 4level-fixup

2019-10-23 Thread Rolf Eike Beer
diff --git a/arch/parisc/include/asm/page.h b/arch/parisc/include/asm/page.h index 93caf17..1d339ee 100644 --- a/arch/parisc/include/asm/page.h +++ b/arch/parisc/include/asm/page.h @@ -42,48 +42,54 @@ typedef struct { unsigned long pte; } pte_t; /* either 32 or 64bit */ /* NOTE: even on 64 bits

Re: [PATCH v3][RESEND] scripts: use pkg-config to locate libcrypto

2019-09-11 Thread Rolf Eike Beer
causes the collision, the simple fix would probably be to manually use the old variable names when cherry-picking. > How should we proceed with this patch? I can send a backport or you manually fix it up when applying, as you wish. Greetings, Eike -- Rolf Eike Beer, emlix GmbH, http://www.emlix.c

[PATCH v3][RESEND] scripts: use pkg-config to locate libcrypto

2019-09-09 Thread Rolf Eike Beer
Otherwise build fails if the headers are not in the default location. While at it also ask pkg-config for the libs, with fallback to the existing value. Signed-off-by: Rolf Eike Beer Cc: sta...@vger.kernel.org --- scripts/Makefile | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions

Re: Linux 4.9.180 build fails with gcc 9 and 'cleanup_module' specifies less restrictive attribute than its target …

2019-08-02 Thread Rolf Eike Beer
ts to send me some patches I can actually apply, that > > would be best... > > I will give it a go whenever I get some free time :) I fear this has never happened, did it? Eike -- Rolf Eike Beer, emlix GmbH, http://www.emlix.com Fon +49 551 30664-0, Fax +49 551 30664-11 Goth

Re: Building arm64 EFI stub with -fpie breaks build of 4.9.x (undefined reference to `__efistub__GLOBAL_OFFSET_TABLE_')

2019-08-02 Thread Rolf Eike Beer
Nathan Chancellor wrote: > On Fri, Aug 02, 2019 at 09:57:45AM +0200, Greg KH wrote: > > On Thu, Jun 06, 2019 at 09:11:00AM +0200, Rolf Eike Beer wrote: > > > Nick Desaulniers wrote: > > > > On Wed, Jun 5, 2019 at 10:27 AM Nick Desaulniers > > > > > >

Re: [PATCH v3] scripts: use pkg-config to locate libcrypto

2019-07-03 Thread Rolf Eike Beer
> From 71e19be4247fbaa2540dfb321e2b148234680a13 Mon Sep 17 00:00:00 2001 > From: Rolf Eike Beer > Date: Thu, 22 Nov 2018 16:40:49 +0100 > Subject: [PATCH] scripts: use pkg-config to locate libcrypto > > Otherwise build fails if the headers are not in the default location. Whil

Re: [PATCH] parisc: asm: psw.h: missing header guard

2019-06-23 Thread Rolf Eike Beer
Denis Efremov wrote: > The psw.h header file contains #ifndef directive of the guard, > but the complimentary #define directive is missing. The patch > adds the appropriate #define to fix the header guard. > > Signed-off-by: Denis Efremov > --- > arch/parisc/include/asm/psw.h | 1 + > 1 file cha

riscv: remove unused barrier defines

2019-06-17 Thread Rolf Eike Beer
>From 947f9fe483dc6561e31f0d2294eb6fedc1d6d9bb Mon Sep 17 00:00:00 2001 From: Rolf Eike Beer Date: Mon, 17 Jun 2019 14:22:37 +0200 Subject: [PATCH] riscv: remove unused barrier defines They were introduced in fab957c11efe2f405e08b9f0d080524bc2631428 long af

[PATCH RESEND] H8300: remove unused barrier defines

2019-06-17 Thread Rolf Eike Beer
>From c907e749917f430e3dc62048985c8419778572f9 Mon Sep 17 00:00:00 2001 From: Rolf Eike Beer Date: Fri, 14 Jul 2017 11:19:08 +0200 Subject: [PATCH] H8300: remove unused barrier defines They were introduced in d2a5f4999f6c211adf30d9788349e13988d6f2a7 long af

[PATCH v2] sh: dma: Add missing IS_ERR_OR_NULL test

2019-06-12 Thread Rolf Evers-Fischer
get_dma_channel may return ERR_PTR or NULL, so a check is added. Changes since v1: - Removed unnecessary parentheses - Replaced IS_ERR with IS_ERR_OR_NULL Signed-off-by: Rolf Evers-Fischer --- arch/sh/drivers/dma/dma-api.c | 20 +++- arch/sh/drivers/dma/dma-sysfs.c | 2

Re: Linux 4.9.180 build fails with gcc 9 and 'cleanup_module' specifies less restrictive attribute than its target …

2019-06-12 Thread Rolf Eike Beer
__((alias(#exitfn))); #endif So the final question is: do we want 4.9.x to be buildable with gcc 9.x? If yes then we can probably get this patches into shape. Eike -- Rolf Eike Beer, emlix GmbH, http://www.emlix.com Fon +49 551 30664-0, Fax +49 551 30664-11 Gothaer Platz 3, 37083 Göttingen, G

Re: [PATCH] sh: dma: Add missing IS_ERR test

2019-06-11 Thread Rolf Evers-Fischer
On Sat, 8 Jun 2019, Geert Uytterhoeven wrote: Hi Geert, thank you for your reply and your additional findings. > Hi Rolf, > > Thanks for your patch! > > On Fri, Jun 7, 2019 at 2:04 PM Rolf Evers-Fischer > wrote: > > get_dma_channel may return ERR_PTR, so a check is

Re: [PATCH] sh: dma: Add missing IS_ERR test

2019-06-11 Thread Rolf Evers-Fischer
Hello Sergei, thanks for your feedback. On Sat, 8 Jun 2019, Sergei Shtylyov wrote: > Hello! > > On 07.06.2019 14:54, Rolf Evers-Fischer wrote: > > > get_dma_channel may return ERR_PTR, so a check is added. > > > > Signed-off-by: Rolf Evers-Fischer > > ---

[PATCH] sh: dma: Add missing IS_ERR test

2019-06-07 Thread Rolf Evers-Fischer
get_dma_channel may return ERR_PTR, so a check is added. Signed-off-by: Rolf Evers-Fischer --- arch/sh/drivers/dma/dma-api.c | 20 +++- arch/sh/drivers/dma/dma-sysfs.c | 2 +- 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/arch/sh/drivers/dma/dma-api.c b/arch

Linux 4.9.180 build fails with gcc 9 and 'cleanup_module' specifies less restrictive attribute than its target …

2019-06-06 Thread Rolf Eike Beer
2xx_lpbfifo_driver); | ^~ So this needs a6e60d84989fa0e91db7f236eda40453b0e44afa, which needs c0d9782f5b6d7157635ae2fd782a4b27d55a6013, which can't be applied cleanly because a3f8a30f3f0079c7edfc72e329eee8594fb3e3cb is missing in 4.9. I have applied a6e60d84989fa0e91db7f236eda40453b0e44afa and

Re: Building arm64 EFI stub with -fpie breaks build of 4.9.x (undefined reference to `__efistub__GLOBAL_OFFSET_TABLE_')

2019-06-06 Thread Rolf Eike Beer
Ard Biesheuvel wrote: > On Thu, 6 Jun 2019 at 09:50, Rolf Eike Beer wrote: > > Am Donnerstag, 6. Juni 2019, 09:38:41 CEST schrieb Rolf Eike Beer: > > > Greg KH wrote: > > > > On Wed, Jun 05, 2019 at 05:19:40PM +0200, Rolf Eike Beer wrote: > > > > > I

[PATCH v3] scripts: use pkg-config to locate libcrypto

2019-06-06 Thread Rolf Eike Beer
>From 71e19be4247fbaa2540dfb321e2b148234680a13 Mon Sep 17 00:00:00 2001 From: Rolf Eike Beer Date: Thu, 22 Nov 2018 16:40:49 +0100 Subject: [PATCH] scripts: use pkg-config to locate libcrypto Otherwise build fails if the headers are not in the default location. While at it also ask pkg-con

Re: [PATCH v2 RESEND] scripts: use pkg-config to locate libcrypto

2019-06-06 Thread Rolf Eike Beer
David Woodhouse wrote: > On Thu, 2019-06-06 at 09:55 +0200, Rolf Eike Beer wrote: > > +CRYPTO_LIBS = $(shell $(PKG_CONFIG) --libs libcrypto 2> /dev/null || > > -lcrypto) > That's going to run: > > $ pkg-config --libs libcrypto || -lcrypto > > > If li

[PATCH v2 RESEND] scripts: use pkg-config to locate libcrypto

2019-06-06 Thread Rolf Eike Beer
>From cca931322233827dc21c7609f21f4042d78f220e Mon Sep 17 00:00:00 2001 From: Rolf Eike Beer Date: Thu, 22 Nov 2018 16:40:49 +0100 Subject: scripts: use pkg-config to locate libcrypto Otherwise build fails if the headers are not in the default location. While at it also ask pkg-config for

Re: Building arm64 EFI stub with -fpie breaks build of 4.9.x (undefined reference to `__efistub__GLOBAL_OFFSET_TABLE_')

2019-06-06 Thread Rolf Eike Beer
Am Donnerstag, 6. Juni 2019, 09:38:41 CEST schrieb Rolf Eike Beer: > Greg KH wrote: > > On Wed, Jun 05, 2019 at 05:19:40PM +0200, Rolf Eike Beer wrote: > > > I decided to dig out a toy project which uses a DragonBoard 410c. This > > > has > > > been "run

Re: [PATCH linux] objtool: fix pkg-config query in case of cross-compilation

2019-04-11 Thread Rolf Eike Beer
Am Donnerstag, 11. April 2019, 11:26:12 CEST schrieb Nicolas Dichtel: > Le 11/04/2019 à 10:52, Rolf Eike Beer a écrit : > > Am Donnerstag, 11. April 2019, 10:39:40 CEST schrieb Nicolas Dichtel: > >> In case of cross-compilation, there may be two pkg-config tools, one for > &g

Re: [PATCH linux] objtool: fix pkg-config query in case of cross-compilation

2019-04-11 Thread Rolf Eike Beer
example is here: https://marc.info/?l=linux-acpi&m=153544231529066&w=2 For me it looks like you are trying to go into the wrong direction. Greetings, Eike -- Rolf Eike Beer, emlix GmbH, http://www.emlix.com Fon +49 551 30664-0, Fax +49 551 30664-11 Gothaer Platz 3, 37083 Götting

[tip:core/urgent] objtool: Query pkg-config for libelf location

2019-03-28 Thread tip-bot for Rolf Eike Beer
Commit-ID: 056d28d135bca0b1d0908990338e00e9dadaf057 Gitweb: https://git.kernel.org/tip/056d28d135bca0b1d0908990338e00e9dadaf057 Author: Rolf Eike Beer AuthorDate: Tue, 26 Mar 2019 12:48:39 -0500 Committer: Thomas Gleixner CommitDate: Thu, 28 Mar 2019 13:32:01 +0100 objtool: Query pkg

[PATCH v2] objtool: query pkg-config for libelf location

2019-03-20 Thread Rolf Eike Beer
If it is not in the default location compilation would fail at several points. Signed-off-by: Rolf Eike Beer --- Changes in v2: -also hide stderr when querying cflags -use ":=" assignment as in other places in that file Makefile | 4 +++- tools/objtool/Makefile | 7

Re: [PATCH] objtool: query pkg-config for libelf location

2019-03-20 Thread Rolf Eike Beer
Josh Poimboeuf wrote: > On Tue, Mar 19, 2019 at 08:20:12AM +0100, Rolf Eike Beer wrote: > > diff --git a/tools/objtool/Makefile b/tools/objtool/Makefile > > index c9d038f91af6..0c8dd1609348 100644 > > --- a/tools/objtool/Makefile > > +++ b/tools/objtool/Makefile > &

[PATCH] objtool: query pkg-config for libelf location

2019-03-19 Thread Rolf Eike Beer
If it is not in the default location compilation would fail at several points. Signed-off-by: Rolf Eike Beer --- Makefile | 4 +++- tools/objtool/Makefile | 7 +-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 9ef547fc7ffe

Re: [PATCH] phy: ti-pipe3: Do not overwrite the whole PROGRAMMABILITY register

2019-02-26 Thread Rolf Evers-Fischer
Kishon, On Tue, 26 Feb 2019, Kishon Vijay Abraham I wrote: > Rolf, > > On 26/02/19 2:54 PM, Rolf Evers-Fischer wrote: > > From: Rolf Evers-Fischer > > > > Previously, ti_pipe3_calibrate() wrote all bits in the > > PCIEPHYRX_ANA_PROGRAMMABILITY register, thus o

[PATCH] phy: ti-pipe3: Do not overwrite the whole PROGRAMMABILITY register

2019-02-26 Thread Rolf Evers-Fischer
From: Rolf Evers-Fischer Previously, ti_pipe3_calibrate() wrote all bits in the PCIEPHYRX_ANA_PROGRAMMABILITY register, thus overwriting bits, which should not be modified. Fix ti_pipe3_calibrate() so that it only modifies LOSD and INTERFACE bits. Signed-off-by: Rolf Evers-Fischer --- drivers

Re: [PATCH v2] scripts: use pkg-config to locate libcrypto

2018-12-14 Thread Rolf Eike Beer
Am Montag, 26. November 2018, 10:13:23 CET schrieb Rolf Eike Beer: > Am Samstag, 24. November 2018, 06:53:39 CET schrieb Sasha Levin: > > Hi, > > > > [This is an automated email] > > > > This commit has been processed because it contains a -stable tag. >

Re: [PATCH v2] scripts: use pkg-config to locate libcrypto

2018-11-26 Thread Rolf Eike Beer
pply! Possible dependencies: > Unable to calculate This would either need 8377bd2b9ee1be35b39b5523f640a2b75ddd7c4e as well, or a modified patch. Manually fixing this up should be trivial. Just tell me which way you prefer. Greetings, Eike -- Rolf Eike Beer, emlix GmbH, http://www.emli

[PATCH v2] scripts: use pkg-config to locate libcrypto

2018-11-22 Thread Rolf Eike Beer
Otherwise build fails if the headers are not in the default location. While at it also ask pkg-config for the libs, with fallback to the existing value. Signed-off-by: Rolf Eike Beer Cc: sta...@vger.kernel.org --- scripts/Makefile | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions

[PATCH] scripts: use pkg-config to locate libcrypto

2018-11-22 Thread Rolf Eike Beer
Otherwise build fails if the headers are not in the default location. While at it also ask pkg-config for the libs, with fallback to the existing value. Signed-off-by: Rolf Eike Beer Cc: sta...@vger.kernel.org --- scripts/Makefile | 7 +-- 1 file changed, 5 insertions(+), 2 deletions

Re: [PATCH v2 6/7] drivers: oprofile: Avoids building driver from direct make command

2018-09-27 Thread Rolf Eike Beer
Am 2018-09-27 13:23, schrieb Leonardo Bras: Hello Rolf, On Thu, Sep 27, 2018 at 3:34 AM, Rolf Eike Beer wrote: Am Donnerstag, 27. September 2018, 03:41:38 CEST schrieb Leonardo Brás: Creates new Makefile to avoid building driver if 'make drivers/oprofile/' is called directly. T

Re: [PATCH v2 1/7] drivers: dio: Avoids building driver if CONFIG_DIO is disabled

2018-09-26 Thread Rolf Eike Beer
Am Donnerstag, 27. September 2018, 03:39:56 CEST schrieb Leonardo Brás: > Avoids building driver if 'make drivers/dio/' is called and > CONFIG_DIO is disabled. > > Signed-off-by: Leonardo Brás > --- > drivers/dio/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/

Re: [PATCH v2 6/7] drivers: oprofile: Avoids building driver from direct make command

2018-09-26 Thread Rolf Eike Beer
Am Donnerstag, 27. September 2018, 03:41:38 CEST schrieb Leonardo Brás: > Creates new Makefile to avoid building driver if > 'make drivers/oprofile/' is called directly. > > This driver is usually built from arch/$ARCH and seems to have > no meaning building alone. > > Signed-off-by: Leonardo Brá

Re: [PATCH 6/7] drivers: oprofile: Avoids building driver from direct make command

2018-09-26 Thread Rolf Eike Beer
Leonardo Brás wrote: Creates new Makefile to avoid building driver if 'make drivers/oprofile/' is called directly. This driver is usually built from arch/$ARCH and seems to have no meaning building alone. Signed-off-by: Leonardo Brás --- drivers/oprofile/Makefile | 1 + 1 file changed, 1 inse

[PATCH v5 3/3] PCI: endpoint: pci_epf_create: remove goto labels

2018-02-28 Thread Rolf Evers-Fischer
From: Rolf Evers-Fischer Removes the goto labels completely, handles the errors at the respective call site and just returns instead of jumping around. Signed-off-by: Rolf Evers-Fischer --- drivers/pci/endpoint/pci-epf-core.c | 32 1 file changed, 12

[PATCH v5 2/3] PCI: endpoint: Fix kernel panic after put_device()

2018-02-28 Thread Rolf Evers-Fischer
From: Rolf Evers-Fischer 'put_device()' calls the relase function 'pci_epf_dev_release()', which already frees 'epf->name' and 'epf'. Therefore we must not free them again after 'put_device()'. Fixes: 5e8cb4033807 ("PCI: endpoint: A

[PATCH v5 1/3] PCI: endpoint: Simplify name allocation for EPF device

2018-02-28 Thread Rolf Evers-Fischer
From: Rolf Evers-Fischer This commit replaces allocating and freeing the intermediate 'buf'/'func_name' with a combination of 'kstrndup()' and 'len'. 'len' is the required length of 'epf->name'. 'epf->name' should be

[PATCH v5 0/3] pci: endpoint: Fix double free in pci_epf_create()

2018-02-28 Thread Rolf Evers-Fischer
reworked in order to eliminate the need for the second 'kstrdup' allocation and the 'kfree' of the first allocation. It was tested with name="pci_epf_test.0" and name="pci_epb": The 'epf->name' was "pci_epf_test" or "pci_epb"

Re: [PATCH v4 3/3] PCI: endpoint: pci_epf_create: remove goto labels

2018-02-28 Thread Rolf Evers-Fischer
Hi Kishon and Lorenzo, On Wed, 28 Feb 2018, Lorenzo Pieralisi wrote: > On Wed, Feb 28, 2018 at 02:07:19PM +0100, Rolf Evers-Fischer wrote: > > From: Rolf Evers-Fischer > > > > Removes the goto labels completely, handles the errors at the > > respective call site

[PATCH v4 3/3] PCI: endpoint: pci_epf_create: remove goto labels

2018-02-28 Thread Rolf Evers-Fischer
From: Rolf Evers-Fischer Removes the goto labels completely, handles the errors at the respective call site and just returns instead of jumping around. Signed-off-by: Rolf Evers-Fischer --- drivers/pci/endpoint/pci-epf-core.c | 30 +- 1 file changed, 9 insertions

[PATCH v4 2/3] PCI: endpoint: Fix kernel panic after put_device()

2018-02-28 Thread Rolf Evers-Fischer
From: Rolf Evers-Fischer 'put_device()' calls the relase function 'pci_epf_dev_release()', which already frees 'epf->name' and 'epf'. Therefore we must not free them again after 'put_device()'. Fixes: 5e8cb4033807 ("PCI: endpoint: A

[PATCH v4 1/3] PCI: endpoint: Simplify name allocation for EPF device

2018-02-28 Thread Rolf Evers-Fischer
From: Rolf Evers-Fischer This commit replaces allocating and freeing the intermediate 'buf'/'func_name' with a combination of 'kstrndup()' and 'len'. 'len' is the required length of 'epf->name'. 'epf->name' should be

[PATCH v4 0/3] pci: endpoint: Fix double free in pci_epf_create()

2018-02-28 Thread Rolf Evers-Fischer
rked in order to eliminate the need for the second 'kstrdup' allocation and the 'kfree' of the first allocation. It was tested with name="pci_epf_test.0" and name="pci_epb": The 'epf->name' was "pci_epf_test" or "pci_epb"

Re: [PATCH v3 0/2] pci: endpoint: Fix double free in pci_epf_create()

2018-02-28 Thread Rolf Evers-Fischer
Hello Bjorn! On Tue, 27 Feb 2018, Bjorn Helgaas wrote: > On Tue, Feb 27, 2018 at 10:20:30AM +, Lorenzo Pieralisi wrote: > > On Tue, Feb 27, 2018 at 11:02:28AM +0100, Rolf Evers-Fischer wrote: > > > This is version 3 of a patchset to avoid double free in function >

Re: [PATCH v3 2/2] pci: endpoint: Fix kernel panic after put_device()

2018-02-28 Thread Rolf Evers-Fischer
Hello Lorenzo! On Tue, 27 Feb 2018, Lorenzo Pieralisi wrote: > On Tue, Feb 27, 2018 at 11:02:30AM +0100, Rolf Evers-Fischer wrote: > > From: Rolf Evers-Fischer > > > > 'put_device()' calls the relase function 'pci_epf_dev_release()', >

Re: [PATCH v3 0/2] pci: endpoint: Fix double free in pci_epf_create()

2018-02-27 Thread Rolf Evers-Fischer
Hello Lorenzo, On Tue, 27 Feb 2018, Lorenzo Pieralisi wrote: > On Tue, Feb 27, 2018 at 11:02:28AM +0100, Rolf Evers-Fischer wrote: > > This is version 3 of a patchset to avoid double free in function > > 'pci_epf_create()'. > > > > When I accidentally create

Re: [PATCH v3 1/2] pci: endpoint: Simplify name allocation for epf device

2018-02-27 Thread Rolf Evers-Fischer
Hi, On Tue, 27 Feb 2018, Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 27 February 2018 03:32 PM, Rolf Evers-Fischer wrote: > > From: Rolf Evers-Fischer > > > > This commit replaces allocating and freeing the intermediate > > 'buf'/'func_n

[PATCH v3 1/2] pci: endpoint: Simplify name allocation for epf device

2018-02-27 Thread Rolf Evers-Fischer
From: Rolf Evers-Fischer This commit replaces allocating and freeing the intermediate 'buf'/'func_name' with a combination of 'kstrndup()' and 'len'. 'len' is the required length of 'epf->name'. 'epf->name' should be

[PATCH v3 2/2] pci: endpoint: Fix kernel panic after put_device()

2018-02-27 Thread Rolf Evers-Fischer
From: Rolf Evers-Fischer 'put_device()' calls the relase function 'pci_epf_dev_release()', which already frees 'epf->name' and 'epf'. Therefore we must not free them again after 'put_device()'. Fixes: 5e8cb4033807 ("PCI: endpoint: A

[PATCH v3 0/2] pci: endpoint: Fix double free in pci_epf_create()

2018-02-27 Thread Rolf Evers-Fischer
the first allocation. It was tested with name="pci_epf_test.0" and name="pci_epb": The 'epf->name' was "pci_epf_test" or "pci_epb" (=unchanged). Rolf Evers-Fischer (2): pci: endpoint: Simplify name allocation for epf device pci: endpoin

[PATCH v2 2/2] pci: endpoint: Fix kernel panic after put_device()

2018-02-26 Thread Rolf Evers-Fischer
From: Rolf Evers-Fischer 'put_device()' calls the relase function 'pci_epf_dev_release()', which already frees 'epf->name' and 'epf'. Therefore we must not free them again after 'put_device()'. Signed-off-by: Rolf Evers-Fischer --- drive

[PATCH v2 1/2] pci: endpoint: Simplify name allocation for epf device

2018-02-26 Thread Rolf Evers-Fischer
From: Rolf Evers-Fischer This commit replaces allocating and freeing the intermediate 'buf'/'func_name' with a combination of 'kstrndup()' and 'len'. 'len' is the required length of 'epf->name'. 'epf->name' should be

[PATCH v2 0/2] pci: endpoint: Fix double free in pci_epf_create()

2018-02-26 Thread Rolf Evers-Fischer
Change IDs removed - First patch completely reworked in order to eliminate the need for the second 'kstrdup' allocation and the 'kfree' of the first allocation. It was tested with name="pci_epf_test.0" and name="pci_epb": The 'epf->name&#

Re: [PATCH 1/2] pci: endpoint: Free func_name after last usage

2018-02-23 Thread Rolf Evers-Fischer
18 11:49 PM, Lorenzo Pieralisi wrote: > >>> On Wed, Feb 21, 2018 at 01:47:06PM +0100, Rolf Evers-Fischer wrote: > >>>> From: Rolf Evers-Fischer > >>>> > >>>> This commit decreases the number of jump labels and ensures > >>>> that t

Re: [PATCH 1/2] pci: endpoint: Free func_name after last usage

2018-02-22 Thread Rolf Evers-Fischer
> > Signed-off-by: Rolf Evers-Fischer > > Signed-off-by: Rolf Evers-Fischer > > Looks like bipolar disorder? > You are right: One "Signed-off" should be enough. > To the topic. > This is a slow path and your change makes code slightly less readable > b/c of

[PATCH 2/2] pci: endpoint: Fix kernel panic after put_device()

2018-02-21 Thread Rolf Evers-Fischer
From: Rolf Evers-Fischer 'put_device()' calls the relase function 'pci_epf_dev_release()', which already frees 'epf->name' and 'epf'. Therefore we must not free them again after 'put_device()'. Change-Id: I14ca19f96abfbbb489dd1f4d489e08532

[PATCH 1/2] pci: endpoint: Free func_name after last usage

2018-02-21 Thread Rolf Evers-Fischer
From: Rolf Evers-Fischer This commit decreases the number of jump labels and ensures that the next commit doesn't increase the number of occurrences of 'kfree(func_name)'. Change-Id: I0d1b6fd652395b85f82b11c43bf9b7db512854d1 Signed-off-by: Rolf Evers-Fischer Signed-off-by: Rol

[PATCH 0/2] pci: endpoint: Fix double free in pci_epf_create()

2018-02-21 Thread Rolf Evers-Fischer
'epf->name' and 'epf'. The first patch just simplifies the code, while the second patch fixes the problem. Rolf Evers-Fischer (2): pci: endpoint: Free func_name after last usage pci: endpoint: Fix kernel panic after put_device() drivers/pci/endpoint/pci-epf-core.c | 9 ++

[PATCH 2/2] x86/microcode: Do the family check first

2018-02-08 Thread Rolf Neugebauer
ov Cc: # 4.11.. Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Link: http://bugzilla.suse.com/show_bug.cgi?id=1061396 Link: http://lkml.kernel.org/r/20171012112316.977-1...@alien8.de Signed-off-by: Ingo Molnar Cc: # 4.4.x Signed-off-by: Rolf Neugebauer --- arch/x86/kernel/cpu/m

[PATCH 1/2] x86/microcode/AMD: Do not load when running on a hypervisor

2018-02-08 Thread Rolf Neugebauer
e Signed-off-by: Thomas Gleixner Cc: # 4.4.x Signed-off-by: Rolf Neugebauer --- arch/x86/kernel/cpu/microcode/core.c | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/arch/x86/kernel/cpu/microcode/core.c b/arch/x86/kernel/cpu/microcode/core.c ind

Re: x86/microcode/intel: Division by zero panic in 4.9.79 and 4.4.114

2018-02-08 Thread Rolf Neugebauer
On Thu, Feb 8, 2018 at 2:53 PM, Borislav Petkov wrote: > On Thu, Feb 08, 2018 at 01:55:48PM +0000, Rolf Neugebauer wrote: >> On the 4.4 kernel, 1f161f67a272c ("x86/microcode: Do the family check >> first") does not apply cleanly. Looks like it relies on 309aac77768c0 >

Re: x86/microcode/intel: Division by zero panic in 4.9.79 and 4.4.114

2018-02-08 Thread Rolf Neugebauer
On Wed, Feb 7, 2018 at 6:12 PM, Borislav Petkov wrote: > On Wed, Feb 07, 2018 at 04:31:59PM +0000, Rolf Neugebauer wrote: >> arch/x86/kernel/cpu/microcode/core.c | 28 +++- >> 1 file changed, 19 insertions(+), 9 deletions(-) >> >> diff

Re: x86/microcode/intel: Division by zero panic in 4.9.79 and 4.4.114

2018-02-07 Thread Rolf Neugebauer
On Wed, Feb 7, 2018 at 2:34 PM, Greg KH wrote: > On Tue, Feb 06, 2018 at 03:24:44PM +0100, Borislav Petkov wrote: >> On Tue, Feb 06, 2018 at 02:09:35PM +0000, Rolf Neugebauer wrote: >> > The backport of 7e702d17ed1 ("x86/microcode/intel: Extend BDW >> > late-loa

x86/microcode/intel: Division by zero panic in 4.9.79 and 4.4.114

2018-02-06 Thread Rolf Neugebauer
code changes for these kernels around where x86_max_cores is set. The obvious quick fix/hack is to check for x86_max_cores in calc_llc_size_per_core() and return 0. I'm happy to submit a patch for this, but a more correct fix might be back porting the relevant changes around where x86_max_cores is set. Thanks Rolf

[v2][PATCH 1/1] serial: 8250: 8250_omap: Fix spelling error.

2017-12-06 Thread Rolf Evers-Fischer
From: Rolf Evers-Fischer Fixed a spelling error in a comment. Signed-off-by: Rolf Evers-Fischer --- drivers/tty/serial/8250/8250_omap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/8250/8250_omap.c b/drivers/tty/serial/8250/8250_omap.c index

Re: Checkpatch ignores spelling error by using -f

2017-12-06 Thread Rolf Evers-Fischer
On Wed, 6 Dec 2017, Joe Perches wrote: > On Wed, 2017-12-06 at 15:13 +0100, Rolf Evers-Fischer wrote: > > Hello, > > I've just checked the file drivers/tty/serial/8250/8250_omap.c, using > > checkpatch.pl, but I forgot the '-f' option (for file). > &g

Checkpatch ignores spelling error by using -f

2017-12-06 Thread Rolf Evers-Fischer
/8250/8250_omap.c has no obvious style problems and is ready for submission." Is this a bug in checkpatch.pl? Or is it a feature? Kind regards, Rolf

[PATCH 1/1] serial: 8250: 8250_omap: Fix spelling error.

2017-12-06 Thread Rolf Evers-Fischer
From: Rolf Evers-Fischer Signed-off-by: Rolf Evers-Fischer --- drivers/tty/serial/8250/8250_omap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/8250/8250_omap.c b/drivers/tty/serial/8250/8250_omap.c index bd40ba402410..57f6eba47f44 100644 --- a

Re: [PATCH] video/fbdev/stifb: Delete an error message for a failed memory allocation in stifb_init_fb()

2017-11-24 Thread Rolf Eike Beer
Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 24 Nov 2017 22:22:06 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/video/fbdev/stifb.c

Re: [PATCH net] virtio-net: restore VIRTIO_HDR_F_DATA_VALID on receiving

2017-01-20 Thread Rolf Neugebauer
> receiving path. > > Cc: Rolf Neugebauer > Signed-off-by: Jason Wang Acked-by: Rolf Neugebauer Ah, I missed this use of the function. Looks like this patch does not regress the issue I was seeing with virtio_net. Rolf > --- > drivers/net/macvtap.c | 2 +- > dri

[PATCH 2/3] selftests: do not require bash to run bpf tests

2016-12-14 Thread Rolf Eike Beer
>From b9d6c1b7427d708ef2d4d57aac17b700b3694d71 Mon Sep 17 00:00:00 2001 From: Rolf Eike Beer Date: Wed, 14 Dec 2016 09:58:12 +0100 Subject: [PATCH 2/3] selftests: do not require bash to run bpf tests Nothing in this minimal script seems to require bash. We often run these tests on embed

Re: Long delays creating a netns after deleting one (possibly RCU related)

2016-11-11 Thread Rolf Neugebauer
On Thu, Nov 10, 2016 at 9:24 PM, Paul E. McKenney wrote: > On Thu, Nov 10, 2016 at 09:37:47AM -0800, Cong Wang wrote: >> (Cc'ing Paul) >> >> On Wed, Nov 9, 2016 at 7:42 AM, Rolf Neugebauer >> wrote: >> > Hi >> > >> > We notice

Re: [PATCH 6/8] char/genrtc: parisc: use asm-generic/rtc.h

2016-04-26 Thread Rolf Eike Beer
Arnd Bergmann wrote: > The asm-generic/rtc.h header can now be included by > architectures that provide their own set_rtc_time/get_rtc_time > macros, letting us remove most of the common contents in > the powerpc implementation. parisc in this case. Eike signature.asc Description: This is a digi

  1   2   3   >