[PATCH] Staging: ks7010: Use preffered kernel types

2016-11-15 Thread Punit Vara
Replace uint8_t, uint16_t and uint32_t with preferred kernel types u8, u16 and u32 respectively suggested by checkpatch.pl Signed-off-by: Punit Vara --- drivers/staging/ks7010/ks_wlan.h | 138 +-- drivers/staging/ks7010/michael_mic.c | 10 +-- drivers

Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared *wilc and implicit declaration of init_irq

2015-12-01 Thread punit vara
On Wed, Dec 2, 2015 at 12:30 PM, Sudip Mukherjee wrote: > On Wed, Dec 02, 2015 at 08:39:10AM +0530, punit vara wrote: >> On Mon, Nov 9, 2015 at 3:53 PM, Sudip Mukherjee >> wrote: >> > On Mon, Nov 09, 2015 at 03:43:38PM +0530, punit vara wrote: >> >> On M

Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared *wilc and implicit declaration of init_irq

2015-12-01 Thread punit vara
On Mon, Nov 9, 2015 at 3:53 PM, Sudip Mukherjee wrote: > On Mon, Nov 09, 2015 at 03:43:38PM +0530, punit vara wrote: >> On Mon, Nov 9, 2015 at 3:31 PM, glen lee wrote: >> > >> > >> > On 2015년 11월 09일 18:05, punit vara wrote: >> >> >&

Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared *wilc and implicit declaration of init_irq

2015-11-09 Thread punit vara
On Mon, Nov 9, 2015 at 3:53 PM, Sudip Mukherjee wrote: > On Mon, Nov 09, 2015 at 03:43:38PM +0530, punit vara wrote: >> On Mon, Nov 9, 2015 at 3:31 PM, glen lee wrote: >> > >> > >> > On 2015년 11월 09일 18:05, punit vara wrote: >> >> >&

Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared *wilc and implicit declaration of init_irq

2015-11-09 Thread punit vara
On Mon, Nov 9, 2015 at 3:31 PM, glen lee wrote: > > > On 2015년 11월 09일 18:05, punit vara wrote: >> >> On Mon, Nov 9, 2015 at 2:25 PM, glen lee wrote: >>> >>> On 2015년 11월 09일 17:18, Dan Carpenter wrote: >>>> >>>> On Mon, Nov 09, 2015

Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared *wilc and implicit declaration of init_irq

2015-11-09 Thread punit vara
On Mon, Nov 9, 2015 at 2:25 PM, glen lee wrote: > > On 2015년 11월 09일 17:18, Dan Carpenter wrote: >> >> On Mon, Nov 09, 2015 at 05:02:48PM +0900, glen lee wrote: >>> >>> Hi Punit Vara, >>> >>> I cannot find build errors on my build machines.

Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared *wilc and implicit declaration of init_irq

2015-11-09 Thread punit vara
On Mon, Nov 9, 2015 at 1:48 PM, Dan Carpenter wrote: > On Mon, Nov 09, 2015 at 05:02:48PM +0900, glen lee wrote: >> Hi Punit Vara, >> >> I cannot find build errors on my build machines. >> >> According the log which you have posted before says *wilc

[PATCH V2] Staging: wilc1000: Fix build break due to undeclared *wilc and implicit declaration of init_irq

2015-11-08 Thread Punit Vara
isr_uh_routine -removes unnecessary lines to declare *wilc Patch fixes 702c0e50f and 2c1d05d10 tags. Signed-off-by: Punit Vara --- -Fixes tag added suggested by Dan carpenter. -Remove declaration of autovariable with same type and same name suggested by Joe Perches drivers/staging/wilc1000

Re: [PATCH] Staging: wilc1000: Fix build break due to undeclared *wilc and implicit declaration of init_irq

2015-11-08 Thread punit vara
On Sun, Nov 8, 2015 at 2:21 AM, Dan Carpenter wrote: > I haven't looked at it, sorry. You'll have to figure it out or if you > complain to the original person who broken the build he can figure it > out. You are still missing a Fixes tag. > > regards, > dan carpenter Actually while building one

Re: [PATCH] Staging: wilc1000: Fix build break due to undeclared *wilc and implicit declaration of init_irq

2015-11-08 Thread punit vara
On Sun, Nov 8, 2015 at 2:21 AM, Dan Carpenter wrote: > I haven't looked at it, sorry. You'll have to figure it out or if you > complain to the original person who broken the build he can figure it > out. You are still missing a Fixes tag. > > regards, > dan carpenter Here I will remove struct wi

Re: [PATCH] Staging: wilc1000: Fix build break due to undeclared *wilc and implicit declaration of init_irq

2015-11-07 Thread punit vara
On Sat, Nov 7, 2015 at 7:24 PM, Dan Carpenter wrote: > On Sat, Nov 07, 2015 at 05:01:49PM +0530, Punit Vara wrote: >> int wilc1000_wlan_init(struct net_device *dev, perInterface_wlan_t *p_nic) >> { >> @@ -1791,6 +1794,7 @@ int wilc_netdev_init(struct wilc **wilc) >>

[PATCH] Staging: wilc1000: Fix build break due to undeclared *wilc and implicit declaration of init_irq

2015-11-07 Thread Punit Vara
WILC_SDIO) to defination isr_uh_routine Signed-off-by: Punit Vara --- drivers/staging/wilc1000/linux_wlan.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c index 09ddba2..0a21e62 100644 --- a

Re: [PATCH] Staging: wilc1000: Declare *wilc in init_wilc_driver to fix build error

2015-11-06 Thread punit vara
On Sat, Nov 7, 2015 at 3:47 AM, punit vara wrote: > On Sat, Nov 7, 2015 at 3:39 AM, punit vara wrote: >> On Sat, Nov 7, 2015 at 3:29 AM, Punit Vara wrote: >>> This patch is to the linux_wlan.c file that fixes declaration of *wilc >>> to remove following error whil

Re: [PATCH] Staging: wilc1000: Declare *wilc in init_wilc_driver to fix build error

2015-11-06 Thread punit vara
On Sat, Nov 7, 2015 at 3:39 AM, punit vara wrote: > On Sat, Nov 7, 2015 at 3:29 AM, Punit Vara wrote: >> This patch is to the linux_wlan.c file that fixes declaration of *wilc >> to remove following error while building it. >> >> make drivers/staging/wilc1000/linu

Re: [PATCH] Staging: wilc1000: Declare *wilc in init_wilc_driver to fix build error

2015-11-06 Thread punit vara
On Sat, Nov 7, 2015 at 3:29 AM, Punit Vara wrote: > This patch is to the linux_wlan.c file that fixes declaration of *wilc > to remove following error while building it. > > make drivers/staging/wilc1000/linux_wlan.o > drivers/staging/wilc1000/linux_wlan.c:1824:24: error: ‘w

[PATCH] Staging: wilc1000: Declare *wilc in init_wilc_driver to fix build error

2015-11-06 Thread Punit Vara
This patch is to the linux_wlan.c file that fixes declaration of *wilc to remove following error while building it. make drivers/staging/wilc1000/linux_wlan.o drivers/staging/wilc1000/linux_wlan.c:1824:24: error: ‘wilc’ undeclared Signed-off-by: Punit Vara --- drivers/staging/wilc1000

[RESEND PATCH v2] Staging: wilc1000: Prefer eth_broadcast_addr over memset()

2015-10-28 Thread Punit Vara
This patch is to the host_interface.c that fixes up following warning by checkpatch: -prefer eth_broadcast_addr() over memset() Signed-off-by: Punit Vara --- Applied on updated staging tree. drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH 1/6] block: Remove unneeded variable err for returning 0

2015-10-27 Thread punit vara
On Mon, Oct 26, 2015 at 12:18 AM, Punit Vara wrote: > This patch is to the mg_disk.c file that removes unnecessary err > and fixes following warning reported by coccicheck: > > Unneeded variable: "err". Return "0" on line 1077 > > Signed-off-by: Punit Vara

Re: [PATCH v4 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

2015-10-27 Thread punit vara
On Tue, Oct 27, 2015 at 1:42 PM, Kalle Valo wrote: > punit vara writes: > >> Will my other patches which are already correct be added to wireless >> tree ? or I have to resend everything ? > > Yes, please resend the whole patchset. I don't apply patches > individ

[RESEND PATCH 10/10] net: wireless: ath: Remove unneeded variable ret returning 0

2015-10-27 Thread Punit Vara
This patch is to the ath5k/eeprom.c that fixes up warning caught by coccicheck: -Unneeded variable: "ret". Return "0" on line 1733 Remove unneccesary variable ret created to return zero. Signed-off-by: Punit Vara --- drivers/net/wireless/ath/ath5k/eeprom.c | 4 ++-

[RESEND PATCH 09/10] net: wireless: brcm80211: Remove unneeded variable ret_code returning 0

2015-10-27 Thread Punit Vara
This patch is to the brcmsmac/stf.c that fixes up warning caught by coccicheck: -Unneeded variable: "ret_code". Return "0" on line 328 Remove unneccesary variable ret_code created to return zero. Signed-off-by: Punit Vara --- drivers/net/wireless/brcm80211/brcmsmac/stf

[RESEND PATCH 08/10] net: wireless: brcm80211: Remove unneeded variable which return 0

2015-10-27 Thread Punit Vara
This is patch to the brcmsmac/main.c that removes unnecessary variable which was declared to return zero. This patch fixes up warning reported by coccicheck: -Unneeded variable: "err". Return "0" on line 3788 Signed-off-by: Punit Vara --- drivers/net/wireless/brcm80211

[RESEND PATCH 07/10] net: wireless: iwlegacy: Remove unneeded variable ret

2015-10-27 Thread Punit Vara
This patch is to the 3945-mac.c file that fixes up following warning by coccicheck: drivers/net/wireless/iwlegacy/3945-mac.c:247:5-8: Unneeded variable: "ret". Return "- EOPNOTSUPP" on line 249 Return -EOPNOTSUPP directly instead of return using ret Signed-off-by: Punit Va

[RESEND PATCH 06/10] net: wireless: ath: simplify return flow for carl9170_regwrite_result()

2015-10-27 Thread Punit Vara
This patch is to the carl9170/phy.c file that fixes warning reported by coccicheck : WARNING: end returns can be simplified I have removed unneccessary variable declaration and simply return flow for carl9170_regwrite_result() Signed-off-by: Punit Vara --- drivers/net/wireless/ath/carl9170

[RESEND PATCH 03/10] net: wireless: rtwifi: Remove duplicated arguments to |

2015-10-27 Thread Punit Vara
Remove uncessary repeated arguments COMP_EFUSE, COMP_REGD, COMP_CHAN with OR(|) This is patch to the debug.c file that removes following warning reported by coccicheck: -duplicated argument to & or | Signed-off-by: Punit Vara --- drivers/net/wireless/rtlwifi/debug.c | 6 +++--- 1

[RESEND PATCH 02/10] net: wireless: ath: Remove unnecessary semicolon

2015-10-27 Thread Punit Vara
This patch is to the ath10k/wmi.h that removes unneeded semicolon which is reported by coccicheck. Here semicolon just create empty statement so please remote it. Signed-off-by: Punit Vara --- drivers/net/wireless/ath/ath10k/wmi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[RESEND PATCH 04/10] net: wireless: brcm80211: Remove duplicated arguments to |

2015-10-27 Thread Punit Vara
Remove uncessary repeated arguments with OR(|) This is patch to the brcmsmac/channel.c file that removes following warning reported by coccicheck: -duplicated argument to & or | Signed-off-by: Punit Vara --- drivers/net/wireless/brcm80211/brcmsmac/channel.c | 1 - 1 file changed, 1 dele

[RESEND PATCH 01/10] net: wireless: ath: Remove unnecessary semicolon

2015-10-27 Thread Punit Vara
This patch is to the htt_rx.c that removes unneeded semicolon which is reported by coccicheck. Here semicolon just create empty statement so please remote it. Signed-off-by: Punit Vara --- drivers/net/wireless/ath/ath10k/htt_rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[RESEND PATCH 05/10] net: wireless: simplify return flow for zd1201_setconfig16

2015-10-27 Thread Punit Vara
This patch is to the zd1201.c file that fixes up warning reported by coccicheck: WARNING: end returns can be simplified and declaration on line 1658 can be dropped Prefer direct return value instead of writing 2-3 more sentence. Signed-off-by: Punit Vara --- drivers/net/wireless/zd1201.c | 6

[PATCH v2] Staging: wilc1000: Prefer eth_broadcast_addr over memset()

2015-10-27 Thread Punit Vara
This patch is to the host_interface.c that fixes up following warning by checkpatch: -prefer eth_broadcast_addr() over memset() Signed-off-by: Punit Vara --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000

Re: [PATCH v4 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

2015-10-26 Thread punit vara
On Fri, Oct 23, 2015 at 12:26 AM, Sergei Shtylyov wrote: > On 10/22/2015 09:47 PM, Punit Vara wrote: > >> Remove black line suggested by Sergei > > >Such kind of comments should be under the --- tear line. > >> >> This patch is to the ath5k/eepr

[PATCH] Staging: wilc1000: Fix warning prefer eth_broadcast_addr over memset()

2015-10-26 Thread Punit Vara
This patch is to the host_interface.c that fixes up following warning by checkpatch.pl: -Prefer eth_broadcast_addr() over memset() Signed-off-by: Punit Vara --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

Re: [PATCH 1/3] staging: wilc1000: Remove reference preceded by free

2015-10-25 Thread punit vara
On Mon, Oct 26, 2015 at 1:01 AM, punit vara wrote: > On Mon, Oct 26, 2015 at 12:42 AM, Greg KH wrote: >> On Sun, Oct 25, 2015 at 04:01:23AM +0530, Punit Vara wrote: >>> This patch is to the wilc_wfi_cfgoperations.c file that fixes up >>> following error reported b

Re: [PATCH 1/3] staging: wilc1000: Remove reference preceded by free

2015-10-25 Thread punit vara
On Mon, Oct 26, 2015 at 12:42 AM, Greg KH wrote: > On Sun, Oct 25, 2015 at 04:01:23AM +0530, Punit Vara wrote: >> This patch is to the wilc_wfi_cfgoperations.c file that fixes up >> following error reported by coccicheck: >> >> ERROR: reference preceded by free on

Re: [PATCH 6/6] block: Coding style fix for comma and open , close parenthesis

2015-10-25 Thread punit vara
On Mon, Oct 26, 2015 at 12:18 AM, Punit Vara wrote: > Add and remove space as per coding style for loops,comma , open and > close parenthesis.It also removes whitespace. > > This patch is to the ataflop.c file that fixes up following ERRORs > reported by checkpatch: > > - sp

[PATCH 3/6] block: Remove unnedded semicolon

2015-10-25 Thread Punit Vara
This patch is to the sunvdc.c file that removes unnecessary semicolon reported by coccicheck Signed-off-by: Punit Vara --- drivers/block/sunvdc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/sunvdc.c b/drivers/block/sunvdc.c index 4b911ed..f81f637 100644

[PATCH 2/6] block: drbd: Remove unnedded semicolon

2015-10-25 Thread Punit Vara
This patch is to the drbd_req.c file that removes unnecessary semicolon reported by coccicheck Signed-off-by: Punit Vara --- drivers/block/drbd/drbd_req.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/drbd/drbd_req.c b/drivers/block/drbd/drbd_req.c index

[PATCH 1/6] block: Remove unneeded variable err for returning 0

2015-10-25 Thread Punit Vara
This patch is to the mg_disk.c file that removes unnecessary err and fixes following warning reported by coccicheck: Unneeded variable: "err". Return "0" on line 1077 Signed-off-by: Punit Vara --- drivers/block/mg_disk.c | 3 +-- 1 file changed, 1 insertion(+), 2 deleti

[PATCH 6/6] block: Coding style fix for comma and open , close parenthesis

2015-10-25 Thread Punit Vara
that open parenthesis '(' - trailing whitespace - space required after that ',' (ctx:VxV) - space required before the open parenthesis '(' Signed-off-by: Punit Vara --- drivers/block/ataflop.c | 244 1 file changed, 1

[PATCH 5/6] block: Coding style fix for comma and open , close parenthesis

2015-10-25 Thread Punit Vara
that open parenthesis '(' - trailing whitespace - space required after that ',' (ctx:VxV) - spaces required around that '=' (ctx:VxW) - space required before the open parenthesis '(' Signed-off-by: Punit Vara --- drivers/block/ataflop.c | 250 ++

[PATCH 4/6] block: Coding style fix for comma and open , close parenthesis

2015-10-25 Thread Punit Vara
that open parenthesis '(' - trailing whitespace - space required after that ',' (ctx:VxV) - spaces required around that '=' (ctx:VxW) - space required before the open parenthesis '(' Signed-off-by: Punit Vara --- drivers/block/ataflop.c | 82 +++

[PATCH 0/6] Fix coding style issues

2015-10-25 Thread Punit Vara
Fixed coding style issues reported by coccicheck and checkpatch tool Punit Vara (6): block: Remove unneeded variable err for returning 0 block: drbd: Remove unnedded semicolon block: Remove unnedded semicolon block: Coding style fix for comma and open , close parenthesis block: Coding

Re: [PATCH 1/2] scsi: lpfc: Use kzalloc instead of kmalloc

2015-10-25 Thread punit vara
On Sat, Oct 24, 2015 at 4:56 AM, Matthew R. Ochs wrote: > Hi Punit, > > Aren't you missing the removal of the memset() as part of this conversion? > > > -matt > >> On Oct 23, 2015, at 3:03 PM, Punit Vara wrote: >> >> This patch is to the lpfc_els.c whi

[PATCH 3/3] Staging: wilc1000: Remove boolean comparision

2015-10-24 Thread Punit Vara
This patch is to the host_interface.c file that fixes up following warning reported by coccicheck: WARNING: Comparison to bool Boolean tests do not need explicit comparison to true or false Signed-off-by: Punit Vara --- drivers/staging/wilc1000/host_interface.c | 4 ++-- 1 file changed, 2

[PATCH 2/3] Staging: wilc1000: Remove comparision of field address to NULL

2015-10-24 Thread Punit Vara
This is patch to the linux_wlan file that fixes up following error reported by coccicheck : ERROR: test of a variable/field address Signed-off-by: Punit Vara --- drivers/staging/wilc1000/linux_wlan.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging

[PATCH 1/3] staging: wilc1000: Remove reference preceded by free

2015-10-24 Thread Punit Vara
ree whenever params->seq_len <=0 remove it and place kfree inside (params->seq_len) >0 condition. Signed-off-by: Punit Vara --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/wil

[PATCH 0/3] Staging: wilc1000: Remove coccicheck warnings and error

2015-10-24 Thread Punit Vara
Punit Vara (3): staging: wilc1000: Remove reference preceded by free Staging: wilc1000: Remove comparision of field address to NULL Staging: wilc1000: Remove boolean comparision drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/linux_wlan.c

[PATCH] block: remove useless casting value returned by kmalloc to structure

2015-10-24 Thread Punit Vara
This is the patch to the cciss_scsi.c file that resolves following warning reported by coccicheck: WARNING: casting value returned by memory allocation function to (struct cciss_scsi_adapter_data_t *) is useless. Signed-off-by: Punit Vara --- drivers/block/cciss_scsi.c | 3 +-- 1 file changed

Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test

2015-10-24 Thread punit vara
On Fri, Oct 23, 2015 at 2:04 AM, Dan Carpenter wrote: > First fetch the changes, then check them out. > > $ git fetch git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > staging-next > $ git checkout FETCH_HEAD > > regards, > dan carpenter > Thank you very much Dan. Problem is solv

[PATCH v2 1/2] scsi: lpfc: Use kzalloc instead of kmalloc

2015-10-24 Thread Punit Vara
This patch is to the lpfc_els.c which resolves following warning reported by coccicheck: WARNING: kzalloc should be used for rdp_context, instead of kmalloc/memset Signed-off-by: Punit Vara --- drivers/scsi/lpfc/lpfc_els.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a

[PATCH 1/2] scsi: lpfc: Use kzalloc instead of kmalloc

2015-10-23 Thread Punit Vara
This patch is to the lpfc_els.c which resolves following warning reported by coccicheck: WARNING: kzalloc should be used for rdp_context, instead of kmalloc/memset Signed-off-by: Punit Vara --- drivers/scsi/lpfc/lpfc_els.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH 2/2] scsi: remove useless casting value returned by kmalloc to structure

2015-10-23 Thread Punit Vara
This is the patch to the hpsa.c file that resolves following warning reported by coccicheck: WARNING: casting value returned by memory allocation function to (BIG_IOCTL_Command_struct *) is useless. Signed-off-by: Punit Vara --- drivers/scsi/hpsa.c | 3 +-- 1 file changed, 1 insertion(+), 2

[PATCH 0/2] Fix warning by coccicheck

2015-10-23 Thread Punit Vara
Punit Vara (2): scsi: lpfc: Use kzalloc instead of kmalloc scsi: remove useless casting value returned by kmalloc to structure drivers/scsi/hpsa.c | 3 +-- drivers/scsi/lpfc/lpfc_els.c | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) -- 2.5.3 -- To unsubscribe from this

[PATCH v6 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

2015-10-23 Thread Punit Vara
This warning is reported by coccicheck: Signed-off-by: Punit Vara --- drivers/net/wireless/ath/wcn36xx/main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c index 900e72a..94bcc08 100644

Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test

2015-10-22 Thread punit vara
On Fri, Oct 23, 2015 at 12:52 AM, Dan Carpenter wrote: > On Fri, Oct 23, 2015 at 12:34:36AM +0530, punit vara wrote: >> I am working on linux-next .I have tried to rebase my local branch on >> your staging tree but I am getting too many conflict .and I have tried >> to cl

Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test

2015-10-22 Thread punit vara
On Mon, Oct 19, 2015 at 8:51 PM, punit vara wrote: > On Mon, Oct 19, 2015 at 8:14 AM, Larry Finger > wrote: >> On 10/18/2015 09:00 PM, Greg KH wrote: >>> >>> On Sun, Oct 18, 2015 at 12:02:53PM +0530, punit vara wrote: >>>> >>>> One more thin

[PATCH v5 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

2015-10-22 Thread Punit Vara
Remove empty line suggested by Sergei This patch is to the ath5k/eeprom.c that fixes up warning caught by coccicheck: Unneeded variable: "ret". Return "0" on line 980 Remove unneeded variable ret created to return zero. Signed-off-by: Punit Vara --- drivers/net/wireles

Re: [PATCH v3 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

2015-10-22 Thread punit vara
On Fri, Oct 23, 2015 at 12:05 AM, Sergei Shtylyov wrote: > Hello. > > On 10/22/2015 09:26 PM, Punit Vara wrote: > >> This patch is to the ath5k/eeprom.c that fixes up warning caught by >> coccicheck: >> >> -Unneeded variable: "ret". Return "0&

[PATCH v4 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

2015-10-22 Thread Punit Vara
Remove black line suggested by Sergei This patch is to the ath5k/eeprom.c that fixes up warning caught by coccicheck: Unneeded variable: "ret". Return "0" on line 980 Remove unneeded variable ret created to return zero. Signed-off-by: Punit Vara --- drivers/net/wireles

[PATCH v3 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

2015-10-22 Thread Punit Vara
This patch is to the ath5k/eeprom.c that fixes up warning caught by coccicheck: -Unneeded variable: "ret". Return "0" on line 1733 Remove unneccesary variable ret created to return zero. Also removed empty line suggested by Sergei Signed-off-by: Punit Vara --- drivers/ne

Re: [PATCH 15/15] net: wireless: ath: Remove unneeded variable ret returning 0

2015-10-22 Thread punit vara
On Thu, Oct 22, 2015 at 3:16 AM, Sergei Shtylyov wrote: > On 10/21/2015 05:55 PM, Punit Vara wrote: > >> This patch is to the ath5k/eeprom.c that fixes up warning caught by >> coccicheck: >> >> Unneeded variable: "ret". Return "0" on line 980 &g

Re: [PATCH 01/15] net: wireless: ath: use | instead of + for summing bitmasks

2015-10-22 Thread punit vara
On Thu, Oct 22, 2015 at 3:13 AM, Sergei Shtylyov wrote: > Hello. > > On 10/21/2015 05:55 PM, Punit Vara wrote: > >> This patch is to the ath10k/pci.h file that fixes following warning > > >pci.c, you mean? > > >> reported by coccicheck: >> &

[PATCH v2 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

2015-10-22 Thread Punit Vara
This patch is to the ath5k/eeprom.c that fixes up warning caught by coccicheck: -Unneeded variable: "ret". Return "0" on line 1733 Remove unneccesary variable ret created to return zero. Signed-off-by: Punit Vara --- drivers/net/wireless/ath/ath5k/eeprom.c | 5 ++--

[PATCH v2 05/15] net: wireless: ti: Return flow can be simplified for wl1271_cmd_interrogate

2015-10-21 Thread Punit Vara
Remove int ret suggested by kbuild test robot This patch is to the wlcore/acx.c file that fixes up warning reported by coccicheck: WARNING: end returns can be simplified if negative or 0 value Prefer direct return value instead of writing 2-3 more sentence. Signed-off-by: Punit Vara

[PATCH v2 08/15] net: wireless: simplify return flow for usb_control_msg

2015-10-21 Thread Punit Vara
remove int ret suggested by Jiri Slaby This patch is to the at76c50x-usb.c file that fixes up warning reported by coccicheck: WARNING: end returns can be simplified if negative or 0 value Prefer direct return value instead of writing 2-3 more sentence. Signed-off-by: Punit Vara --- drivers

Re: [PATCH 08/15] net: wireless: simplify return flow for usb_control_msg

2015-10-21 Thread punit vara
On Wed, Oct 21, 2015 at 8:30 PM, Jiri Slaby wrote: > On 10/21/2015, 04:55 PM, Punit Vara wrote: >> @@ -544,13 +544,10 @@ static void at76_ledtrig_tx_activity(void) >> static int at76_remap(struct usb_device *udev) >> { >> int ret; >> - ret = usb_contr

[PATCH 02/15] net: wireless: ath: Remove unnecessary semicolon

2015-10-21 Thread Punit Vara
This patch is to the htt_rx.c that removes unneeded semicolon which is reported by coccicheck. Here semicolon just create empty statement so please remote it. Signed-off-by: Punit Vara --- drivers/net/wireless/ath/ath10k/htt_rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 12/15] net: wireless: brcm80211: Remove unneeded variable which return 0

2015-10-21 Thread Punit Vara
This is patch to the brcmsmac/main.c that removes unnecessary variable which was declared to return zero. This patch fixes up warning reported by coccicheck: -Unneeded variable: "err". Return "0" on line 3788 Signed-off-by: Punit Vara --- drivers/net/wireless/brcm80211

[PATCH 09/15] net: wireless: simplify return flow for zd1201_setconfig16

2015-10-21 Thread Punit Vara
This patch is to the zd1201.c file that fixes up warning reported by coccicheck: WARNING: end returns can be simplified and declaration on line 1658 can be dropped Prefer direct return value instead of writing 2-3 more sentence. Signed-off-by: Punit Vara --- drivers/net/wireless/zd1201.c | 6

[PATCH 11/15] net: wireless: iwlegacy: Remove unneeded variable ret

2015-10-21 Thread Punit Vara
This patch is to the 3945-mac.c file that fixes up following warning by coccicheck: drivers/net/wireless/iwlegacy/3945-mac.c:247:5-8: Unneeded variable: "ret". Return "- EOPNOTSUPP" on line 249 Return -EOPNOTSUPP directly instead of return using ret Signed-off-by: Punit Va

[PATCH 08/15] net: wireless: simplify return flow for usb_control_msg

2015-10-21 Thread Punit Vara
This patch is to the at76c50x-usb.c file that fixes up warning reported by coccicheck: WARNING: end returns can be simplified if negative or 0 value Prefer direct return value instead of writing 2-3 more sentence. Signed-off-by: Punit Vara --- drivers/net/wireless/at76c50x-usb.c | 5 + 1

[PATCH 10/15] net: wireless: ath: simplify return flow for carl9170_regwrite_result()

2015-10-21 Thread Punit Vara
This patch is to the carl9170/phy.c file that fixes warning reported by coccicheck : WARNING: end returns can be simplified I have removed unneccessary variable declaration and simply return flow for carl9170_regwrite_result() Signed-off-by: Punit Vara --- drivers/net/wireless/ath/carl9170

[PATCH 13/15] net: wireless: brcm80211: Remove unneeded variable ret_code returning 0

2015-10-21 Thread Punit Vara
This patch is to the brcmsmac/stf.c that fixes up warning caught by coccicheck: -Unneeded variable: "ret_code". Return "0" on line 328 Remove unneccesary variable ret_code created to return zero. Siged-off-by: Punit Vara --- drivers/net/wireless/brcm80211/brcmsmac/stf

[PATCH 15/15] net: wireless: ath: Remove unneeded variable ret returning 0

2015-10-21 Thread Punit Vara
This patch is to the ath5k/eeprom.c that fixes up warning caught by coccicheck: Unneeded variable: "ret". Return "0" on line 980 Remove unneeded variable ret created to return zero. Signed-off-by: Punit Vara --- drivers/net/wireless/ath/wcn36xx/main.c | 3 +-- 1 file

[PATCH 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

2015-10-21 Thread Punit Vara
This patch is to the ath5k/eeprom.c that fixes up warning caught by coccicheck: -Unneeded variable: "ret". Return "0" on line 1733 Remove unneccesary variable ret created to return zero. Signed-off-by: Punit Vara --- drivers/net/wireless/ath/ath5k/eeprom.c | 4 ++-

[PATCH 01/15] net: wireless: ath: use | instead of + for summing bitmasks

2015-10-21 Thread Punit Vara
This patch is to the ath10k/pci.h file that fixes following warning reported by coccicheck: WARNING: sum of probable bitmasks, consider | I have replaced + with OR operator | for summing bitmasks Signed-off-by: Punit Vara --- drivers/net/wireless/ath/ath10k/pci.c | 10 +- 1 file

[PATCH 07/15] net: wireless: brcm80211: Remove duplicated arguments to |

2015-10-21 Thread Punit Vara
Remove uncessary repeated arguments with OR(|) This is patch to the brcmsmac/channel.c file that removes following warning reported by coccicheck: -duplicated argument to & or | Signed-off-by: Punit Vara --- drivers/net/wireless/brcm80211/brcmsmac/channel.c | 1 - 1 file changed, 1 dele

[PATCH 03/15] net: wireless: ath: Remove unnecessary semicolon

2015-10-21 Thread Punit Vara
This patch is to the ath10k/wmi.h that removes unneeded semicolon which is reported by coccicheck. Here semicolon just create empty statement so please remote it. Signed-off-by: Punit Vara --- drivers/net/wireless/ath/ath10k/wmi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 06/15] net: wireless: rtwifi: Remove duplicated arguments to |

2015-10-21 Thread Punit Vara
Remove uncessary repeated arguments COMP_EFUSE, COMP_REGD, COMP_CHAN with OR(|) This is patch to the debug.c file that removes following warning reported by coccicheck: -duplicated argument to & or | Signed-off-by: Punit Vara --- drivers/net/wireless/rtlwifi/debug.c | 6 +++--- 1

[PATCH 04/15] net: wireless: ipw2x00: use | instead of + for summing bitmasks

2015-10-21 Thread Punit Vara
This patch is to the libipw_rx.c file that fixes following warning reported by coccicheck: WARNING: sum of probable bitmasks, consider | I have replaced + with OR operator | for summing bitmasks Signed-off-by: Punit Vara --- drivers/net/wireless/ipw2x00/libipw_rx.c | 4 ++-- 1 file changed, 2

[PATCH 05/15] net: wireless: ti: Return flow can be simplified for wl1271_cmd_interrogate

2015-10-21 Thread Punit Vara
This patch is to the wlcore/acx.c file that fixes up warning reported by coccicheck: WARNING: end returns can be simplified if negative or 0 value Prefer direct return value instead of writing 2-3 more sentence. Signed-off-by: Punit Vara --- drivers/net/wireless/ti/wlcore/acx.c | 6 +- 1

[PATCH 00/15] Fix warnings reported by coccicheck

2015-10-21 Thread Punit Vara
Fix various warning reported by coccicheck: make coccicheck M=drivers/net/wireless Punit Vara (15): net: wireless: ath: use | instead of + for summing bitmasks net: wireless: ath: Remove unnecessary semicolon net: wireless: ath: Remove unnecessary semicolon net: wireless: ipw2x00: use

Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test

2015-10-19 Thread punit vara
On Mon, Oct 19, 2015 at 8:14 AM, Larry Finger wrote: > On 10/18/2015 09:00 PM, Greg KH wrote: >> >> On Sun, Oct 18, 2015 at 12:02:53PM +0530, punit vara wrote: >>> >>> One more thing I would like suggestion how can start switching this >>> driver to LIB8

Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test

2015-10-17 Thread punit vara
On Sat, Oct 17, 2015 at 10:46 AM, Greg KH wrote: > On Wed, Oct 14, 2015 at 11:55:55PM +0530, Punit Vara wrote: >> Put constant on the right side of a test.Problem found using checkpatch: >> >> Warning:Comparisons should place the constant on the right side of the test >&

[PATCH RESEND 3/4] Staging: rtl8712: Coding style warnings fix for block comments

2015-10-14 Thread Punit Vara
This patch is to the rtl871x_ioctl_linux.c file that fixes up following warnings reported by checkpatch.pl : -Block comments use * on subsequent lines -Block comments use a trailing */ on a separate line Signed-off-by: Punit Vara --- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 26

[PATCH v2 2/4] Staging: rtl8712: Use ether_addr_equal() over memcmp()

2015-10-14 Thread Punit Vara
This patch is to the rtl871x_ioctl_linux.c file that fixes up following warning reported by checkpatch.pl : -Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp() bssid and pnetwork->network.MacAddress both are 6 byte array which aligned with u16 Signed-off-by: Punit V

[PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test

2015-10-14 Thread Punit Vara
Put constant on the right side of a test.Problem found using checkpatch: Warning:Comparisons should place the constant on the right side of the test Signed-off-by: Punit Vara --- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 16 1 file changed, 8 insertions(+), 8 deletions

[PATCH RESEND 1/4] Staging: rtl8712: Fix warning prefer eth_broadcast_addr() over memset()

2015-10-14 Thread Punit Vara
This patch is to the rtl871x_ioctl_linux.c that fixes up following warning by checkpatch.pl: -Prefer eth_broadcast_addr() over memset() Signed-off-by: Punit Vara --- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers

[PATCH RESEND 0/4] Staging: rtl8712: Fix coding style warnings

2015-10-14 Thread Punit Vara
should place the constant on the right side of the test v2: Fixed API suggested by : Larry Finger larry.fin...@lwfinger.net Improved patch description suggested by Julia julia.law...@lip6.fr Punit Vara (4): Staging: rtl8712: Fix warning prefer eth_broadcast_addr() over memset() Staging

Re: [PATCH v2 2/4] Staging: rtl8712: Use ether_addr_equal() over memcmp()

2015-10-12 Thread punit vara
On Tue, Oct 13, 2015 at 12:16 AM, Punit Vara wrote: > This patch is to the rtl871x_ioctl_linux.c file that fixes up following > warning reported by checkpatch.pl : > > -Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp() > > bssid and pnetwork->network.

[PATCH v2 2/4] Staging: rtl8712: Use ether_addr_equal() over memcmp()

2015-10-12 Thread Punit Vara
This patch is to the rtl871x_ioctl_linux.c file that fixes up following warning reported by checkpatch.pl : -Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp() bssid and pnetwork->network.MacAddress both are 6 byte array which aligned with u16 Signed-off-by: Punit V

Re: [PATCH 2/4] Staging: rtl8712: Use ether_addr_equal() over memcmp()

2015-10-11 Thread punit vara
On Sun, Oct 11, 2015 at 6:07 AM, kbuild test robot wrote: > Hi Punit, > > [auto build test WARNING on v4.3-rc4 -- if it's inappropriate base, please > ignore] > > reproduce: > # apt-get install sparse > make ARCH=x86_64 allmodconfig > make C=1 CF=-D__CHECK_ENDIAN__ > > > s

Re: [PATCH 2/4] Staging: rtl8712: Use ether_addr_equal() over memcmp()

2015-10-10 Thread punit vara
On Sun, Oct 11, 2015 at 1:52 AM, punit vara wrote: > On Sun, Oct 11, 2015 at 1:20 AM, Julia Lawall wrote: >> >> >> On Sun, 11 Oct 2015, punit vara wrote: >> >>> On Sat, Oct 10, 2015 at 11:04 PM, Larry Finger >>> wrote: >>> > On 10/10/201

Re: [PATCH 2/4] Staging: rtl8712: Use ether_addr_equal() over memcmp()

2015-10-10 Thread punit vara
On Sun, Oct 11, 2015 at 1:20 AM, Julia Lawall wrote: > > > On Sun, 11 Oct 2015, punit vara wrote: > >> On Sat, Oct 10, 2015 at 11:04 PM, Larry Finger >> wrote: >> > On 10/10/2015 11:58 AM, Punit Vara wrote: >> >> >> >> This patch is

Re: [PATCH 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test

2015-10-10 Thread punit vara
On Sat, Oct 10, 2015 at 10:37 PM, Julia Lawall wrote: > > > On Sat, 10 Oct 2015, Punit Vara wrote: > >> This patch is to the rtl871x_ioctl_linux.c file that fixes up following > > The entire above line doesn't give any information (except the file name, > but t

Re: [PATCH 2/4] Staging: rtl8712: Use ether_addr_equal() over memcmp()

2015-10-10 Thread punit vara
On Sat, Oct 10, 2015 at 11:04 PM, Larry Finger wrote: > On 10/10/2015 11:58 AM, Punit Vara wrote: >> >> This patch is to the rtl871x_ioctl_linux.c file that fixes up following >> warning reported by checkpatch.pl : >> >> -Prefer ether_addr_equal() or ether_a

[PATCH 2/4] Staging: rtl8712: Use ether_addr_equal() over memcmp()

2015-10-10 Thread Punit Vara
This patch is to the rtl871x_ioctl_linux.c file that fixes up following warning reported by checkpatch.pl : -Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp() bssid has datatype u8 and pnetwork->network.MacAddress has data type unsigned char. Signed-off-by: Punit V

[PATCH 3/4] Staging: rtl8712: Coding style warnings fix for block comments

2015-10-10 Thread Punit Vara
This patch is to the rtl871x_ioctl_linux.c file that fixes up following warnings reported by checkpatch.pl : -Block comments use * on subsequent lines -Block comments use a trailing */ on a separate line Signed-off-by: Punit Vara --- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 26

[PATCH 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test

2015-10-10 Thread Punit Vara
This patch is to the rtl871x_ioctl_linux.c file that fixes up following warnings reported by checkpatch.pl: -Comparisons should place the constant on the right side of the test Signed-off-by: Punit Vara --- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 16 1 file changed, 8

[PATCH 1/4] Staging: rtl8712: Fix warning prefer eth_broadcast_addr() over memset()

2015-10-10 Thread Punit Vara
This patch is to the rtl871x_ioctl_linux.c that fixes up following warning by checkpatch.pl: -Prefer eth_broadcast_addr() over memset() Signed-off-by: Punit Vara --- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers

  1   2   >