Re: [PATCH 0/2] selftests: livepatch: test if ftrace can trace a livepatched function

2025-03-11 Thread Marcos Paulo de Souza
d all comments from me, Joe and Petr, per [2]. For the two patches: Reviewed-by: Marcos Paulo de Souza [1]: https://github.com/mricon/b4/issues/58 [2]: https://lore.kernel.org/live-patching/b2637bad-9022-496a-9b83-0d348a635...@gmail.com/T/#m14bc5c118490c1b17e782a0f0173c1fb70d187c7 > --- &

Re: [PATCH v2] selftests: livepatch: test if ftrace can trace a livepatched function

2025-01-14 Thread Marcos Paulo de Souza
ssed for the test to be merged. Either way, Reviewed-by: Marcos Paulo de Souza Tested-by: Marcos Paulo de Souza > --- > Changes in v2: > - functions.sh: added reset tracing on push and pop_config. > - test-ftrace.sh: enabled tracing_on before test init. > - nitpick: added double q

Re: [PATCH v5 0/3] selftests: livepatch: test livepatching a kprobed function

2024-10-21 Thread Marcos Paulo de Souza
modules in alphabetical order. > Rename module description. > > V2: > Save and restore kprobe state. With the syntax error pointed out by Joe resolved, you can add: Tested-by: Marcos Paulo de Souza Reviewed-by: Marcos Paulo de Souza > > Michael Vetter (3): >   selftests:

Re: [PATCH 1/1] selftests: livepatch: add test cases of stack_order sysfs interface

2024-10-10 Thread Marcos Paulo de Souza
On Tue, 2024-10-08 at 15:52 +0800, Wardenjohn wrote: > Add selftest test cases to sysfs attribute 'stack_order'. > > Signed-off-by: Wardenjohn > --- >  .../testing/selftests/livepatch/test-sysfs.sh | 71 > +++ >  .../selftests/livepatch/test_modules/Makefile |  5 +- >  .../test_klp

Re: [PATCH v4 0/3] selftests: livepatch: test livepatching a kprobed function

2024-10-02 Thread Marcos Paulo de Souza
On Mon, 2024-09-30 at 11:33 +0200, Michael Vetter wrote: > Thanks to Miroslav, Petr and Marcos for the reviews! As the only changes were regarding bash nitpicks I keep my review from earlier patchset, so: Reviewed-by: Marcos Paulo de Souza > > V4: > Use variable for /sys/kernel

Re: [PATCH 0/2] livepatch: introduce 'stack_order' sysfs interface to klp_patch

2024-09-25 Thread Marcos Paulo de Souza
ute should contain a new test to exercise the correct behavior. Other than that, for the series: Acked-by: Marcos Paulo de Souza > > V1 -> V2: > 1. According to the suggestion from Petr, to make the meaning more > clear, rename > 'order' to 'stack_order'.

Re: [PATCH v3 0/3] selftests: livepatch: test livepatching a kprobed function

2024-09-23 Thread Marcos Paulo de Souza
selftests: livepatch: save and restore kprobe state >   selftests: livepatch: test livepatching a kprobed function > Thanks for the new version! LGTM, so the series is Reviewed-by: Marcos Paulo de Souza >  tools/testing/selftests/livepatch/Makefile    |  3 +- >  .../testing/selftests/li

Re: [PATCH 1/2] docs/livepatch: Add new compiler considerations doc

2024-05-29 Thread Marcos Paulo de Souza
to/aesni-intel_glue.c:682:12) [REMOVED] [edges: 4] > constprop: gcmaes_crypt_by_sg.constprop.13/4182 > (arch/x86/crypto/aesni-intel_glue.c:682:12) > > Affected functions: 3 > scatterwalk_unmap.isra.8/4117 (./include/crypto/scatterwalk.h:59:20) > [REMOVED] > gcmaes_crypt_by_sg/4019 (arch/x86/crypto/aesni-intel_glue.c:682:12) > [REMOVED] > gcmaes_crypt_by_sg.constprop.13/4182 > (arch/x86/crypto/aesni-intel_glue.c:682:12) > > > > The rest looks great. Thanks a lot, Joe, for putting it together. I think that we should start provinding a "Livepatch creation how-to", something similar, but for now I believe that some documentation is better than no documentation. This document can evolve to reach such point in the future, but for now, with Miroslav suggestions applied: Acked-by: Marcos Paulo de Souza > > Miroslav

Re: [PATCH v2 0/5] livepatch: klp-convert tool - Minimal version

2024-05-29 Thread Marcos Paulo de Souza
to be > resolved by this tool > - klp-convert: code simplification > - selftests: add selftest livepatching function using an external symbol Thanks for sending this new version Lukas! It currently fails to apply on current Linux master, but the conflict is very simple to address (attache

Re: [PATCH 2/2] samples/livepatch: Add README.rst disclaimer

2024-05-29 Thread Marcos Paulo de Souza
st > file to warn readers. > > Suggested-by: Josh Poimboeuf > Signed-off-by: Joe Lawrence > --- > samples/livepatch/README.rst | 15 +++ > 1 file changed, 15 insertions(+) > create mode 100644 samples/livepatch/README.rst Acked-by: Marcos Paulo de Souza > &

Re: [PATCH v1 0/5] livepatch: klp-convert tool - Minimal version

2024-04-10 Thread Marcos Paulo de Souza
On Mon, 6 Nov 2023 17:25:08 +0100 Lukas Hruska wrote: > Summary > --- > > This is a significantly simplified version of the original klp-convert tool. > The klp-convert code has never got a proper review and also clean ups > were not easy. The last version was v7, see > https://lore.kerne

iMX8MP Cortex-M7 Relation to Audio Power Domain

2024-04-04 Thread João Paulo Silva Gonçalves
}; Do any of you know anything about the relationship between the audio domain and the Cortex-M7 on iMX8MP? The TRM is not very clear on this, and the only thing I could find is that there are some mailboxes for Cortex-M7/Audio processor communication managed by the audio power domain. Thanks for the help! [1] https://github.com/torvalds/linux/commit/b86c3afabb4f4ea146c206508527eb2a15485bcc Regards, João Paulo S. Goncalves

Re: [PATCH v1 5/5] documentation: Update on livepatch elf format

2024-01-10 Thread Marcos Paulo de Souza
On Mon, 2023-11-06 at 17:25 +0100, Lukas Hruska wrote: > Add a section to Documentation/livepatch/module-elf-format.rst > describing how klp-convert works for fixing relocations. > > Signed-off-by: Lukas Hruska Reviewed-by: Marcos Paulo de Souza > --- >  Documentation/li

Re: [PATCH v1 3/5] kbuild/modpost: integrate klp-convert

2024-01-10 Thread Marcos Paulo de Souza
gt; Signed-off-by: Lukas Hruska Reviewed-by: Marcos Paulo de Souza (The patch currently conflicts with Linus tree on Makefile and modpost.c, but nothing to worry, AFAICS) > --- >  .gitignore    |  1 + >  Makefile  | 10 ++ >  scripts/Makefile.modf

Re: [PATCH v1 2/5] livepatch: Add klp-convert tool

2024-01-10 Thread Marcos Paulo de Souza
> + * > > + */ > > + > > +#define SHN_LIVEPATCH 0xff20 > > +#define SHF_RELA_LIVEPATCH 0x0010 > > +#define MODULE_NAME_LEN(64 - sizeof(GElf_Addr)) > > +#define WARN(format, ...) \ > > + fprintf(stderr, "klp-convert: " format "\n", > > ##__VA_ARGS__) > > + > > +struct sympos { > > + char *symbol_name; > > + char *object_name; > > + char *loading_obj_name; > > + int pos; > > +}; > > It seems that this structure is not longer used. > > > +/* > > + * klp-convert uses macros and structures defined in the linux > > sources > > + * package (see include/uapi/linux/livepatch.h). To prevent the > > + * dependency when building locally, they are defined below. Also > > notice > > + * that these should match the definitions from the targeted > > kernel. > > + */ > > + > > +#define KLP_RELA_PREFIX".klp.rela." > > +#define KLP_SYM_RELA_PREFIX".klp.sym.rela." > > +#define KLP_SYM_PREFIX ".klp.sym." > > + > > +#ifndef __packed > > +#define __packed    __attribute__((packed)) > > +#endif > > + > > +struct klp_module_reloc { > > + union { > > + void *sym; > > + uint64_t sym64; /* Force 64-bit width */ > > + }; > > + uint32_t sympos; > > +} __packed; > > And this one as well. > > I do not see any other obvious problem. And it seems to work > at least for the later added sample module. I agree with Petr in all his other comments. With the comments addressed, you can add: Reviewed-by: Marcos Paulo de Souza > > Best Regards, > Petr

Re: [PATCH v1 1/5] livepatch: Create and include UAPI headers

2024-01-10 Thread Marcos Paulo de Souza
kas Hruska Reviewed-by: Marcos Paulo de Souza > --- >  MAINTAINERS    |  1 + >  include/uapi/linux/livepatch.h | 15 +++ >  kernel/livepatch/core.c    |  5 +++-- >  3 files changed, 19 insertions(+), 2 deletions(-) >  create mode 100644 includ

Re: [EXTERNAL] Re: [PATCH 4.19 013/247] cifs: Set CIFS_MOUNT_USE_PREFIX_PATH flag on setting cifs_sb->prepath.

2021-04-19 Thread Paulo Alcantara
Salvatore Bonaccorso writes: > So just to be clear, first apply again a738c93fb1c1 and then your > additional patch on top? Yes.

Re: [EXTERNAL] Re: [PATCH 4.19 013/247] cifs: Set CIFS_MOUNT_USE_PREFIX_PATH flag on setting cifs_sb->prepath.

2021-04-19 Thread Paulo Alcantara
Salvatore Bonaccorso writes: > Thanks Greg! Shyam, Steven, now the commit was reverted for the older > brnaches. But did you got a chance to find why it breaks for the older > series? That commit has revealed another bug in cifs_mount() where we failed to update the super's prefix path after cha

Re: [PATCH v3] cifs: Silently ignore unknown oplock break handle

2021-03-25 Thread Paulo Alcantara
commit message > > fs/cifs/smb2misc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Paulo Alcantara (SUSE)

Re: [PATCH] Input: i8042 - fix Pegatron C15B ID entry

2021-03-23 Thread Marcos Paulo de Souza
'i8042_dmi_noselftest_table[0].matches') > > Add the missing separator between the two. Oops, my bad... Thanks for fixing it Arnd. Reviewed-by: Marcos Paulo de Souza > > Fixes: b5d6e7ab7fe7 ("Input: i8042 - add ASUS Zenbook Flip to > noselftest list") > Sig

[PATCH v3] btrfs: block-group: Fix free-space bitmap threshould

2020-08-21 Thread Marcos Paulo de Souza
From: Marcos Paulo de Souza [BUG] After commit 9afc66498a0b ("btrfs: block-group: refactor how we read one block group item"), cache->length is being assigned after calling btrfs_create_block_group_cache. This causes a problem since set_free_space_tree_thresholds is calculate t

[PATCH v2] btrfs: block-group: Fix free-space bitmap threshould

2020-08-21 Thread Marcos Paulo de Souza
From: Marcos Paulo de Souza [BUG] After commit 9afc66498a0b ("btrfs: block-group: refactor how we read one block group item"), cache->length is being assigned after calling btrfs_create_block_group_cache. This causes a problem since set_free_space_tree_thresholds is calculate t

[PATCH] btrfs: block-group: Fix free-space bitmap threshould

2020-08-20 Thread Marcos Paulo de Souza
From: Marcos Paulo de Souza [BUG] After commit 9afc66498a0b ("btrfs: block-group: refactor how we read one block group item"), cache->length is being assigned after calling btrfs_create_block_group_cache. This causes a problem since set_free_space_tree_thresholds is calculate t

Re: [PATCH v2 1/3] cifs: Add support for root file systems

2019-09-20 Thread Paulo Alcantara
"Paulo Alcantara (SUSE)" writes: > Introduce a new CONFIG_CIFS_ROOT option to handle root file systems > over a SMB share. > > In order to mount the root file system during the init process, make > cifs.ko perform non-blocking socket operations while mounting and >

[PATCH v2 1/3] cifs: Add support for root file systems

2019-09-19 Thread Paulo Alcantara (SUSE)
Introduce a new CONFIG_CIFS_ROOT option to handle root file systems over a SMB share. In order to mount the root file system during the init process, make cifs.ko perform non-blocking socket operations while mounting and accessing it. Signed-off-by: Paulo Alcantara (SUSE) Signed-off-by

[PATCH v2 2/3] init: Support mounting root file systems over SMB

2019-09-19 Thread Paulo Alcantara (SUSE)
appropriate mount options for cifs.ko. Cc: Andrew Morton Signed-off-by: Paulo Alcantara (SUSE) --- init/do_mounts.c | 49 1 file changed, 49 insertions(+) diff --git a/init/do_mounts.c b/init/do_mounts.c index 53cb37b66227..cffef647a95b 100644 --- a

[PATCH v2 3/3] ipconfig: Handle CONFIG_CIFS_ROOT option

2019-09-19 Thread Paulo Alcantara (SUSE)
The experimental root file system support in cifs.ko relies on ipconfig to set up the network stack and then accessing the SMB share that contains the rootfs files. Cc: "David S. Miller" Cc: Alexey Kuznetsov Cc: Hideaki YOSHIFUJI Signed-off-by: Paulo Alcantara (SUSE) --- net/ipv4/

[PATCH 1/3] cifs: Add support for root file systems

2019-07-16 Thread Paulo Alcantara (SUSE)
Introduce a new CONFIG_CIFS_ROOT option to handle root file systems over a SMB share. In order to mount the root file system during the init process, make cifs.ko perform non-blocking socket operations while mounting and accessing it. Cc: Steve French Signed-off-by: Paulo Alcantara (SUSE

[PATCH 2/3] init: Support mounting root file systems over SMB

2019-07-16 Thread Paulo Alcantara (SUSE)
appropriate mount options for cifs.ko. Cc: Andrew Morton Signed-off-by: Paulo Alcantara (SUSE) --- init/do_mounts.c | 49 1 file changed, 49 insertions(+) diff --git a/init/do_mounts.c b/init/do_mounts.c index 2d1ea3028454..28c5b583afef 100644 --- a

[PATCH 3/3] ipconfig: Handle CONFIG_CIFS_ROOT option

2019-07-16 Thread Paulo Alcantara (SUSE)
The experimental root file system support in cifs.ko relies on ipconfig to set up the network stack and then accessing the SMB share that contains the rootfs files. Cc: "David S. Miller" Cc: Alexey Kuznetsov Cc: Hideaki YOSHIFUJI Signed-off-by: Paulo Alcantara (SUSE) --- net/ipv4/

[PATCH 4/4] Documentation:kernel-per-CPU-kthreads.txt: Remove reference to elevator=

2019-07-13 Thread Marcos Paulo de Souza
This argument was not being considered since blk-mq was set by default, so removed this documentation to avoid confusion. Signed-off-by: Marcos Paulo de Souza --- Documentation/kernel-per-CPU-kthreads.txt | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/Documentation

[PATCH 2/4] kernel-parameters.txt: Remove elevator argument

2019-07-13 Thread Marcos Paulo de Souza
This argument was not being used since the legacy IO path was removed, when blk-mq was enabled by default. So removed it from the kernel parameters documentation. Signed-off-by: Marcos Paulo de Souza --- Documentation/admin-guide/kernel-parameters.txt | 6 -- 1 file changed, 6 deletions

[PATCH 1/4] block: elevator.c: Remove now unused elevator= argument

2019-07-13 Thread Marcos Paulo de Souza
Since the inclusion of blk-mq, elevator argument was not being considered anymore, and it's utility died long with the legacy IO path, now removed too. Signed-off-by: Marcos Paulo de Souza --- block/elevator.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/block/elevato

Re: [PATCH] driver: block: nbd: Replace magic number 9 with SECTOR_SHIFT

2019-07-02 Thread Marcos Paulo de Souza
ping? On Mon, Jun 24, 2019 at 01:09:33PM -0300, Marcos Paulo de Souza wrote: > set_capacity expects the disk size in sectors of 512 bytes, and changing > the magic number 9 to SECTOR_SHIFT clarifies this intent. > > Signed-off-by: Marcos Paulo de Souza > --- > drivers/block

Re: [PATCH v2] usb: storage: scsiglue: Do not skip VPD if try_vpd_pages is set

2019-07-02 Thread Marcos Paulo de Souza
ping? On Tue, Jun 18, 2019 at 07:44:54PM -0300, Marcos Paulo de Souza wrote: > If BLIST_TRY_VPD_PAGES is set for a device, even for an USB, it should > be honored, so only set skip_vpd_pages is try_vpd_pages is not set. > > Signed-off-by: Marcos Paulo de Souza > Acked

Re: [PATCH 1/2] scsi: devinfo: BLIST_TRY_VPD_PAGES for SanDisk Cruzer Blade

2019-07-02 Thread Marcos Paulo de Souza
On Thu, Jun 20, 2019 at 04:32:38PM -0400, Martin K. Petersen wrote: > > Marcos, > > > My first idea was to add a vendor:product mapping at SCSI layer, but > > so far I haven't found one, so I added the model/vendor found by > > INQUIRY. Would it be better to check for prod:vendor (as values, > >

Re: [PATCH v2] usb: storage: scsiglue: Do not skip VPD if try_vpd_pages is set

2019-06-25 Thread Marcos Paulo de Souza
humble ping :) On Tue, Jun 18, 2019 at 07:44:54PM -0300, Marcos Paulo de Souza wrote: > If BLIST_TRY_VPD_PAGES is set for a device, even for an USB, it should > be honored, so only set skip_vpd_pages is try_vpd_pages is not set. > > Signed-off-by: Marcos Paulo de Souza > Acked

Re: [PATCH 1/2] scsi: devinfo: BLIST_TRY_VPD_PAGES for SanDisk Cruzer Blade

2019-06-19 Thread Marcos Paulo de Souza
On Wed, Jun 19, 2019 at 06:45:43AM -0300, Marcos Paulo de Souza wrote: > On Tue, Jun 18, 2019 at 11:21:22PM -0400, Martin K. Petersen wrote: > > > > Marcos, > > > > > Currently, all USB devices skip VPD pages, even when the device > > > supports them (SPC

Re: [PATCH] scsi: scsi_sysfs.c: Hide wwid sdev attr if VPD is not supported

2019-06-19 Thread Marcos Paulo de Souza
On Wed, Jun 19, 2019 at 08:34:56AM +0200, Hannes Reinecke wrote: > On 6/19/19 5:35 AM, Martin K. Petersen wrote: > > > > Marcos, > > > >> WWID composed from VPD data from device, specifically page 0x83. So, > >> when a device does not have VPD support, for example USB storage > >> devices where V

Re: [PATCH 1/2] scsi: devinfo: BLIST_TRY_VPD_PAGES for SanDisk Cruzer Blade

2019-06-19 Thread Marcos Paulo de Souza
On Tue, Jun 18, 2019 at 11:21:22PM -0400, Martin K. Petersen wrote: > > Marcos, > > > Currently, all USB devices skip VPD pages, even when the device > > supports them (SPC-3 and later), but some of them support VPD, like > > Cruzer Blade. > > What's your confidence level wrt. all Cruzer Blades

Re: [PATCH] scsi: scsi_sysfs.c: Hide wwid sdev attr if VPD is not supported

2019-06-18 Thread Marcos Paulo de Souza
ping? Can anybody take a look at this patch? Thanks, Marcos On Tue, Jun 11, 2019 at 11:08:28PM -0300, Marcos Paulo de Souza wrote: > WWID composed from VPD data from device, specifically page 0x83. So, > when a device does not have VPD support, for example USB storage devices > whe

Re: [PATCH 2/2] usb: storage: scsiglue: Do not skip VPD if try_vpd_pages is set

2019-06-18 Thread Marcos Paulo de Souza
On Tue, Jun 18, 2019 at 06:07:24PM +0200, Greg Kroah-Hartman wrote: > On Tue, Jun 18, 2019 at 12:17:39PM -0300, Marcos Paulo de Souza wrote: > > On Tue, Jun 18, 2019 at 09:48:01AM -0400, Alan Stern wrote: > > > On Mon, 17 Jun 2019, Marcos Paulo de Souza wrote: > > > >

[PATCH v2] usb: storage: scsiglue: Do not skip VPD if try_vpd_pages is set

2019-06-18 Thread Marcos Paulo de Souza
If BLIST_TRY_VPD_PAGES is set for a device, even for an USB, it should be honored, so only set skip_vpd_pages is try_vpd_pages is not set. Signed-off-by: Marcos Paulo de Souza Acked-by: Alan Stern --- Changes from v1: changed the check of try_vpd_pages from: sdev->try_vpd_pages =

Re: [PATCH 2/2] usb: storage: scsiglue: Do not skip VPD if try_vpd_pages is set

2019-06-18 Thread Marcos Paulo de Souza
On Tue, Jun 18, 2019 at 09:48:01AM -0400, Alan Stern wrote: > On Mon, 17 Jun 2019, Marcos Paulo de Souza wrote: > > > If BLIST_TRY_VPD_PAGES is set for a device, even for an USB, it should > > be honored, so only set skip_vpd_pages is try_vpd_pages is not set. > > > &g

Re: [PATCH 2/2] usb: storage: scsiglue: Do not skip VPD if try_vpd_pages is set

2019-06-18 Thread Marcos Paulo de Souza
On Tue, Jun 18, 2019 at 12:52:03PM +0200, Greg Kroah-Hartman wrote: > On Tue, Jun 18, 2019 at 07:30:04AM -0300, Marcos Paulo de Souza wrote: > > On Tue, Jun 18, 2019 at 08:49:47AM +0200, Greg Kroah-Hartman wrote: > > > On Mon, Jun 17, 2019 at 10:31:46PM -0300, Marcos Pa

Re: [PATCH 2/2] usb: storage: scsiglue: Do not skip VPD if try_vpd_pages is set

2019-06-18 Thread Marcos Paulo de Souza
On Tue, Jun 18, 2019 at 08:49:47AM +0200, Greg Kroah-Hartman wrote: > On Mon, Jun 17, 2019 at 10:31:46PM -0300, Marcos Paulo de Souza wrote: > > If BLIST_TRY_VPD_PAGES is set for a device, even for an USB, it should > > be honored, so only set skip_vpd_pages is try_vpd_p

[PATCH 0/2] Honor VPD check in usb/storage for SanDisk device

2019-06-17 Thread Marcos Paulo de Souza
://lkml.org/lkml/2019/6/11/1408 Marcos Paulo de Souza (2): scsi: devinfo: BLIST_TRY_VPD_PAGES for SanDisk Cruzer Blade usb: storage: scsiglue: Do not skip VPD if try_vpd_pages is set drivers/scsi/scsi_devinfo.c| 2 ++ drivers/usb/storage/scsiglue.c | 7 +-- 2 files changed, 7 insertions

[PATCH 1/2] scsi: devinfo: BLIST_TRY_VPD_PAGES for SanDisk Cruzer Blade

2019-06-17 Thread Marcos Paulo de Souza
Currently, all USB devices skip VPD pages, even when the device supports them (SPC-3 and later), but some of them support VPD, like Cruzer Blade. Signed-off-by: Marcos Paulo de Souza --- drivers/scsi/scsi_devinfo.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi

[PATCH 2/2] usb: storage: scsiglue: Do not skip VPD if try_vpd_pages is set

2019-06-17 Thread Marcos Paulo de Souza
If BLIST_TRY_VPD_PAGES is set for a device, even for an USB, it should be honored, so only set skip_vpd_pages is try_vpd_pages is not set. Signed-off-by: Marcos Paulo de Souza --- drivers/usb/storage/scsiglue.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH] scsi: scsi_sysfs.c: Hide wwid sdev attr if VPD is not supported

2019-06-11 Thread Marcos Paulo de Souza
hide wwid sysfs file when the devices does not support VPD. Signed-off-by: Marcos Paulo de Souza --- drivers/scsi/scsi_sysfs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c index dbb206c90ecf..bfd890fa0c69 100644 --- a/drivers/scsi

Re: [PATCH] platform/x86: asus-wmi: Only Tell EC the OS will handle display hotkeys from asus_nb_wmi

2019-05-29 Thread João Paulo Rechi Vita
On Wed, May 29, 2019 at 1:55 AM Hans de Goede wrote: > > Hi João, > > On 5/28/19 11:22 PM, João Paulo Rechi Vita wrote: > > On Mon, May 20, 2019 at 11:28 PM Hans de Goede wrote: > >> > >> Commit 78f3ac76d9e5 ("platform/x86: asus-wmi: Tell the EC the O

Re: [PATCH] platform/x86: asus-wmi: Only Tell EC the OS will handle display hotkeys from asus_nb_wmi

2019-05-28 Thread João Paulo Rechi Vita
C > 1015BX, Asus EeePC 1025C). > > The asus_wmi_set_devstate(ASUS_WMI_DEVID_BACKLIGHT, 2, NULL) call added > by that commit is made conditional in this commit and only enabled in > the quirk_entry structs in the asus-nb-wmi driver fixing the broken > display / backlight on various

[PATCH] md: md.c: Return -ENODEV when mddev is NULL in rdev_attr_show

2019-05-23 Thread Marcos Paulo de Souza
Commit c42d3240990814eec1e4b2b93fa0487fc4873aed ("md: return -ENODEV if rdev has no mddev assigned") changed rdev_attr_store to return -ENODEV when rdev->mddev is NULL, now do the same to rdev_attr_show. Signed-off-by: Marcos Paulo de Souza --- drivers/md/md.c | 2 +- 1 fi

[PATCH] Bluetooth: Add new 13d3:3501 QCA_ROME device

2019-05-23 Thread João Paulo Rechi Vita
#=0x0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb I: If#=0x1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb Signed-off-by: João Paulo Rechi Vita --- drivers/bluetooth/btusb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth

[PATCH] Bluetooth: Add new 13d3:3491 QCA_ROME device

2019-05-23 Thread João Paulo Rechi Vita
#=0x0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb I: If#=0x1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb Signed-off-by: João Paulo Rechi Vita --- drivers/bluetooth/btusb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth

[PATCH 0/5] raid1-10 and raid0 cleanups

2019-05-20 Thread Marcos Paulo de Souza
ks Marcos Paulo de Souza (5): md cleanup raid1-10: Unify r{1,10}bio_pool_free raid0: Remove return statement from void function md: raid0: Return md_integrity_register result directly md: raid0: Make ret local in raid0_run drivers/md/raid0.c| 8 ++-- drivers/md/raid1

[PATCH 1/4] md: raid1-10: Unify r{1,10}bio_pool_free

2019-05-20 Thread Marcos Paulo de Souza
Avoiding duplicated code, since they just execute a kfree. Signed-off-by: Marcos Paulo de Souza --- drivers/md/raid1-10.c | 5 + drivers/md/raid1.c| 13 - drivers/md/raid10.c | 11 +++ 3 files changed, 12 insertions(+), 17 deletions(-) diff --git a/drivers/md

[PATCH 2/4] md: raid0: Remove return statement from void function

2019-05-20 Thread Marcos Paulo de Souza
This return statement was introduced in commit 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 ("Linux-2.6.12-rc2") and can be safely removed. Signed-off-by: Marcos Paulo de Souza --- drivers/md/raid0.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/md/raid0.c b/drivers/md/rai

[PATCH 3/4] md: raid0: Return md_integrity_register result directly

2019-05-20 Thread Marcos Paulo de Souza
Commit 0c35bd4723e4a39ba2da4c13a22cb97986ee10c8 ("md: fix problems with freeing private data after ->run failure") removed the check for the result of md_integrity_register, so we don't need to store it anymore, so return it directly. Signed-off-by: Marcos Paulo de Souza ---

[PATCH 4/4] md: raid0: Make ret local in raid0_run

2019-05-20 Thread Marcos Paulo de Souza
ret variable is only used in a specific situation, so make it local instead of global. Signed-off-by: Marcos Paulo de Souza --- drivers/md/raid0.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/md/raid0.c b/drivers/md/raid0.c index e72255464c09..b28dbb797f76

Re: [PATCH] drivers: md: Unify common definitions of raid1 and raid10

2019-05-16 Thread Marcos Paulo de Souza
ping. On Thu, May 09, 2019 at 08:18:49AM -0300, Marcos Paulo de Souza wrote: > These definitions are being moved to raid1-10.c. > > Signed-off-by: Marcos Paulo de Souza > --- > drivers/md/raid1-10.c | 25 + > drivers/

[PATCH] drivers: md: Unify common definitions of raid1 and raid10

2019-05-09 Thread Marcos Paulo de Souza
These definitions are being moved to raid1-10.c. Signed-off-by: Marcos Paulo de Souza --- drivers/md/raid1-10.c | 25 + drivers/md/raid1.c| 29 ++--- drivers/md/raid10.c | 27 +-- 3 files changed, 28 insertions(+), 53

[PATCH] Bluetooth: Ignore CC events not matching the last HCI command

2019-04-24 Thread João Paulo Rechi Vita
Address type: 0x06 LE Public LE Random Discovery: Enabled (0x01) @ MGMT Event: Discovering (0x0013) plen 2 {0x0001} [hci0] 27.422067 Address type: 0x06 LE Public LE Random Discovery: Enabled (0x01) Signed-off-by:

[PATCH 0/2] Quirk to enable QCA9377 to discover BLE devices

2019-04-23 Thread João Paulo Rechi Vita
sage, and the extra command complete event can be seen at timestamp 27.420131. Best regards, João Paulo Rechi Vita (2): Bluetooth: Create new HCI_QUIRK_WAIT_FOR_MATCHING_CC Bluetooth: Set HCI_QUIRK_WAIT_FOR_MATCHING_CC for QCA9377 drivers/bluetooth/btusb.c| 9 + include/net/bl

[PATCH v2 2/3] blk-mq.c: Rework documention of blk_mq_init_sq_queue function

2019-04-15 Thread Marcos Paulo de Souza
Describing better what the function does, what the arguments are meant for, and what SQ stands for. Signed-off-by: Marcos Paulo de Souza --- Changes from v1: * Change "SQ" to "only one hw_queue (SQ)" in the function signature documentation (suggested by Chaitan

Re: X450LCP lost abillity to turn the screen off

2019-02-22 Thread Marcos Paulo de Souza
Hi João, On 2/13/19 7:46 PM, Marcos Paulo de Souza wrote: Hello João, On 2/12/19 2:30 PM, João Paulo Rechi Vita wrote: On Mon, Feb 11, 2019 at 6:31 PM Marcos Paulo de Souza wrote: Hello João, On 2/11/19 5:14 PM, João Paulo Rechi Vita wrote: Hello Marcos, On Sun, Feb 10, 2019 at 5:05 PM

Re: [PATCH] Input: uinput - Allow uinput_request to be interrupted

2019-02-21 Thread Marcos Paulo de Souza
Hi Dmitry, On 2/18/19 5:15 PM, Dmitry Torokhov wrote: On Mon, Feb 18, 2019 at 03:21:10PM +0100, Rodrigo Rivas Costa wrote: On Sun, Feb 17, 2019 at 09:42:52PM -0300, Marcos Paulo de Souza wrote: - if (!wait_for_completion_timeout(&request->done, 30 * HZ)) { +

Re: X450LCP lost abillity to turn the screen off

2019-02-13 Thread Marcos Paulo de Souza
Hello João, On 2/12/19 2:30 PM, João Paulo Rechi Vita wrote: > On Mon, Feb 11, 2019 at 6:31 PM Marcos Paulo de Souza > wrote: >> >> Hello João, >> >> On 2/11/19 5:14 PM, João Paulo Rechi Vita wrote: >>> Hello Marcos, >>> >>> On Sun,

Re: X450LCP lost abillity to turn the screen off

2019-02-12 Thread João Paulo Rechi Vita
On Mon, Feb 11, 2019 at 6:31 PM Marcos Paulo de Souza wrote: > > Hello João, > > On 2/11/19 5:14 PM, João Paulo Rechi Vita wrote: > > Hello Marcos, > > > > On Sun, Feb 10, 2019 at 5:05 PM Marcos Paulo de Souza > > wrote: > >> > >> > >&g

Re: X450LCP lost abillity to turn the screen off

2019-02-11 Thread Marcos Paulo de Souza
Hello João, On 2/11/19 5:14 PM, João Paulo Rechi Vita wrote: > Hello Marcos, > > On Sun, Feb 10, 2019 at 5:05 PM Marcos Paulo de Souza > wrote: >> >> >> >> On 2/10/19 9:45 PM, Andy Shevchenko wrote: >>> On Sun, Feb 10, 2019 at 9:24 PM M

Re: X450LCP lost abillity to turn the screen off

2019-02-11 Thread João Paulo Rechi Vita
Hello Marcos, On Sun, Feb 10, 2019 at 5:05 PM Marcos Paulo de Souza wrote: > > > > On 2/10/19 9:45 PM, Andy Shevchenko wrote: > > On Sun, Feb 10, 2019 at 9:24 PM Marcos Paulo de Souza > > wrote: > >> > >> Hi, > >> > >> Since 5.0.

Re: X450LCP lost abillity to turn the screen off

2019-02-10 Thread Marcos Paulo de Souza
On 2/10/19 9:45 PM, Andy Shevchenko wrote: > On Sun, Feb 10, 2019 at 9:24 PM Marcos Paulo de Souza > wrote: >> >> Hi, >> >> Since 5.0.0-rc4 I vefiried that my ASUS laptop > > Can you be more specific, what model, BIOS version, etc (also would be > ni

X450LCP lost abillity to turn the screen off

2019-02-10 Thread Marcos Paulo de Souza
Hi, Since 5.0.0-rc4 I vefiried that my ASUS laptop cannot turn the screen of anymore. There were several commits in 5.0 merge window touching this functionality like: 71b12beaf12f platform/x86: asus-nb-wmi: Drop mapping of 0x33 and 0x34 scan codes b3f2f3799a97 platform/x86: asus-nb-wmi: Map

[PATCH v2] blk-sysfs: Rework documention of __blk_release_queue

2019-02-10 Thread Marcos Paulo de Souza
The Notes section of the comment was removed, because now blk_release_queue can only be executed from blk_cleanup_queue (being called when the q->kobj reaches zero), and also blk_init_queue was removed in a1ce35fa4985. Signed-off-by: Marcos Paulo de Souza --- Changes from v1: * Ty

Re: [PATCH] blk-sysfs: Rework documention of __blk_release_queue

2019-02-09 Thread Marcos Paulo de Souza
Ping :) On 1/30/19 11:11 PM, Marcos Paulo de Souza wrote: > The Notes section of the comment was removed, because now > blk_release_queue can only be executed from blk_cleanup_queue (being > called when the q->kobj reaches zero), and also blk_init_queue was removed > in a1ce35fa49

Re: [PATCH] blk-cgroup: Fix doc related to blkcg_exit_queue

2019-02-09 Thread Marcos Paulo de Souza
Ping :) On 1/25/19 1:50 AM, Bart Van Assche wrote: > On 1/24/19 6:01 PM, Marcos Paulo de Souza wrote: >> Since 4cf6324b17e9, a portion of function blk_cleanup_queue was moved to >> a newly created function called blk_exit_queue, including the call of >> blkcg_exit_

[PATCH] blk-sysfs: Rework documention of __blk_release_queue

2019-01-30 Thread Marcos Paulo de Souza
The Notes section of the comment was removed, because now blk_release_queue can only be executed from blk_cleanup_queue (being called when the q->kobj reaches zero), and also blk_init_queue was removed in a1ce35fa4985. Signed-off-by: Marcos Paulo de Souza --- This is basically a v2 of ht

[PATCH] blk-cgroup: Fix doc related to blkcg_exit_queue

2019-01-24 Thread Marcos Paulo de Souza
Since 4cf6324b17e9, a portion of function blk_cleanup_queue was moved to a newly created function called blk_exit_queue, including the call of blkcg_exit_queue. So, adjust the documenation according. Signed-off-by: Marcos Paulo de Souza --- block/blk-cgroup.c | 2 +- 1 file changed, 1 insertion

Re: [PATCH] block/blk-sysfs.c: Remove last reference of blk_init_queue

2019-01-15 Thread Marcos Paulo de Souza
HI Jeans, On 1/15/19 1:54 AM, Jens Axboe wrote: > On 1/14/19 8:06 PM, Marcos Paulo de Souza wrote: >> blk_init_queue was removed in a1ce35fa4985. > > Honestly, most of that comment is wrong anyway. Since this isn't > a visible API, I'd just kill the comment complete

[PATCH] block/blk-sysfs.c: Remove last reference of blk_init_queue

2019-01-14 Thread Marcos Paulo de Souza
blk_init_queue was removed in a1ce35fa4985. Signed-off-by: Marcos Paulo de Souza --- There are more two references in Documentation/block/biodoc.txt, but maybe that file needs a rewrite in rst anyway? block/blk-sysfs.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

[PATCH] block/blk-core.c: Remove doc about request_count argument

2019-01-10 Thread Marcos Paulo de Souza
This argument was removed in 5f0ed774ed29. Signed-off-by: Marcos Paulo de Souza --- block/blk-core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/blk-core.c b/block/blk-core.c index c78042975737..eba494f528cb 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -661,7 +661,6

Re: [PATCH] drivers/md.c: Make bio_alloc_mddev return bio_alloc_bioset

2019-01-10 Thread Marcos Paulo de Souza
ping? On Sat, Dec 22, 2018 at 08:08:45AM -0200, Marcos Paulo de Souza wrote: > bio_alloc_bioset return a bio pointer or NULL, so we can avoid storing > the returned data into a new variable. > > Signed-off-by: Marcos Paulo de Souza > --- > drivers/md/md.c | 7 +-- &g

Re: [PATCH] blk_types.h: Use REQ_OP_WRITE in op_is_write

2019-01-10 Thread Marcos Paulo de Souza
ping? On Sat, Dec 22, 2018 at 08:03:54AM -0200, Marcos Paulo de Souza wrote: > Instead of just using plain '1', as it improves readability. > > Signed-off-by: Marcos Paulo de Souza > --- > include/linux/blk_types.h | 2 +- > 1 file changed, 1 insertion(+), 1 d

Re: [PATCH 3/3] iwlwifi: Load firmware exclusively for Intel WiFi

2019-01-09 Thread João Paulo Rechi Vita
: hci0: Found Intel DDC parameters: intel/ibt-11-5.ddc Jan 09 16:54:34 endless kernel: Bluetooth: hci0: Applying Intel DDC parameters completed Jan 09 16:54:34 endless kernel: Bluetooth: RFCOMM TTY layer initialized Jan 09 16:54:34 endless kernel: Bluetooth: RFCOMM socket layer initialized Jan 09 16:54:34 endless kernel: Bluetooth: RFCOMM ver 1.11 -- João Paulo Rechi Vita http://about.me/jprvita

Re: [PATCH AUTOSEL 4.20 008/117] platform/x86: asus-wmi: Tell the EC the OS will handle the display off hotkey

2019-01-08 Thread João Paulo Rechi Vita
Hello Sasha, On Tue, Jan 8, 2019 at 11:26 AM Sasha Levin wrote: > > From: João Paulo Rechi Vita > > [ Upstream commit 78f3ac76d9e5219589718b9e4733bee21627b3f5 ] > > In the past, Asus firmwares would change the panel backlight directly > through the EC when the display o

Re: [PATCH 3/3] iwlwifi: Load firmware exclusively for Intel WiFi

2019-01-08 Thread João Paulo Rechi Vita
Hello Marcel, On Wed, Dec 5, 2018 at 11:27 AM João Paulo Rechi Vita wrote: > > Hello Marcel, > > On Fri, Nov 9, 2018 at 4:36 PM João Paulo Rechi Vita > wrote: > > > > Hello Marcel, > > > > On Thu, Nov 8, 2018 at 11:49 PM Marcel Holtmann wrote: > >

Re: [PATCH] Docs/kernel-api.rst: Remove removed blk-tag.c reference

2019-01-01 Thread Marcos Paulo de Souza
Patch sent by mistake. The commit message should be: "Docs/kernel-api.rst: Remove blk-tag.c reference" Thanks, On Tue, Jan 01, 2019 at 10:40:14PM -0200, Marcos Paulo de Souza wrote: > After 7ca01926463a, legacy rq tagging was removed, so block/blk-tag.c > does not exists anymore.

[PATCH] Docs/kernel-api.rst: Remove removed blk-tag.c reference

2019-01-01 Thread Marcos Paulo de Souza
: Cannot open file ./block/blk-tag.c So remove blk-tag.c traces from kernel-api.rst file to silence these warnings. Signed-off-by: Marcos Paulo de Souza --- Documentation/core-api/kernel-api.rst | 6 -- 1 file changed, 6 deletions(-) diff --git a/Documentation/core-api/kernel-api.rst b

[PATCH] drivers/md.c: Make bio_alloc_mddev return bio_alloc_bioset

2018-12-22 Thread Marcos Paulo de Souza
bio_alloc_bioset return a bio pointer or NULL, so we can avoid storing the returned data into a new variable. Signed-off-by: Marcos Paulo de Souza --- drivers/md/md.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/md/md.c b/drivers/md/md.c index fc488cb30a94

[PATCH] blk_types.h: Use REQ_OP_WRITE in op_is_write

2018-12-22 Thread Marcos Paulo de Souza
Instead of just using plain '1', as it improves readability. Signed-off-by: Marcos Paulo de Souza --- include/linux/blk_types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h index 1dcf652ba0aa..905c666a0101 10

Re: [PATCH] ACPI / battery: Fix reporting "Not charging" when capacity is 100%

2018-11-19 Thread João Paulo Rechi Vita
land ABI and I don't think it has good enough reasons to do that. > This only changes which state will be reported when the battery is 100% charged and not discharging, it does not introduce / remove any values. I don't think that is considered ABI change, and on other hardware like the Dell Latitude 5480, /sys/class/power_supply//status already reports "Full" under these conditions. I still believe it is a bug that makes the ABI inconsistent across different hardware. -- João Paulo Rechi Vita http://about.me/jprvita

Re: [PATCH] ACPI / battery: Fix reporting "Not charging" when capacity is 100%

2018-11-06 Thread João Paulo Rechi Vita
On Mon, Nov 5, 2018 at 1:19 AM Pavel Machek wrote: > > On Fri 2018-11-02 23:57:32, João Paulo Rechi Vita wrote: > > Commit 19fffc8450d4378580a8f019b195c4617083176f fixed reporting > > "Discharging" on some machines when AC was connected but the battery was > &

Re: [PATCH] ACPI / battery: Fix reporting "Not charging" when capacity is 100%

2018-11-06 Thread João Paulo Rechi Vita
Hello Hans, thanks for your quick response, On Sat, Nov 3, 2018 at 4:28 AM Hans de Goede wrote: > > Hi, > > On 03-11-18 07:57, João Paulo Rechi Vita wrote: > > Commit 19fffc8450d4378580a8f019b195c4617083176f fixed reporting > > "Discharging" on some machines whe

[PATCH] ACPI / battery: Fix reporting "Not charging" when capacity is 100%

2018-11-02 Thread João Paulo Rechi Vita
it takes the battery capacity into consideration when checking if "Not charging" should be returned and "Full" is returned when the capacity is 100%. Signed-off-by: João Paulo Rechi Vita --- drivers/acpi/battery.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff

[PATCH 2/3] asus-nb-wmi: Map 0x35 to KEY_SCREENLOCK

2018-10-31 Thread João Paulo Rechi Vita
-off-by: João Paulo Rechi Vita --- drivers/platform/x86/asus-nb-wmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c index db2af09067db..5a00a7665f9b 100644 --- a/drivers/platform/x86/asus-nb-wmi.c +++ b/drivers/platform

[PATCH 3/3] asus-nb-wmi: Drop mapping of 0x33 and 0x34 scan codes

2018-10-31 Thread João Paulo Rechi Vita
-by: João Paulo Rechi Vita --- drivers/platform/x86/asus-nb-wmi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c index 5a00a7665f9b..b6f2ff95c3ed 100644 --- a/drivers/platform/x86/asus-nb-wmi.c +++ b/drivers/platform/x86

[PATCH 0/3] Fix display off hotkey on Asus machines

2018-10-31 Thread João Paulo Rechi Vita
with Wayland, so any clarifications in that regard would be greatly appreciated. João Paulo Rechi Vita (3): asus-wmi: Tell the EC the OS will handle the display off hotkey asus-nb-wmi: Map 0x35 to KEY_SCREENLOCK asus-nb-wmi: Drop mapping of 0x33 and 0x34 scan codes drivers/platform/x86/asus-nb-wm

[PATCH 1/3] asus-wmi: Tell the EC the OS will handle the display off hotkey

2018-10-31 Thread João Paulo Rechi Vita
IANE (Local0) } } ElseIf ((BLCT == One)) { If (ATKP) { ATKD.IANE (0x35) } } } (...) } Signed-off-by: João Paulo Rechi Vita --- drivers/platform/x86/asus-wmi.c | 3 ++- 1

[PATCH 2/2] rfkill: Create rfkill-none LED trigger

2018-05-22 Thread João Paulo Rechi Vita
Creates a new trigger rfkill-none, as a complement to rfkill-any, which drives LEDs when any radio is enabled. The new trigger is meant to turn a LED ON whenever all radios are OFF, and turn it OFF otherwise. Signed-off-by: João Paulo Rechi Vita --- net/rfkill/core.c | 27

[PATCH] platform/x86: asus-wmi: Fix NULL pointer dereference

2018-05-22 Thread João Paulo Rechi Vita
fa7cb512 ]--- note: modprobe[3275] exited with preempt_count 2 https://bugzilla.kernel.org/show_bug.cgi?id=196467 Reported-by: red.f0...@gmail.com Signed-off-by: João Paulo Rechi Vita --- drivers/platform/x86/asus-wmi.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-)

  1   2   3   4   5   6   >