Re: [PATCH v2 2/5] ASoC: qcom: sm8250: set card driver name from match data

2025-04-18 Thread neil . armstrong
5-rb5-sndcard"}, + { .compatible = "qcom,qrb4210-rb2-sndcard", .data = "sm8250" }, + { .compatible = "qcom,qrb5165-rb5-sndcard", .data = "sm8250" }, + { .compatible = "qcom,sm8250-sndcard", .data = "sm8250" }, {} }; Thanks :-) Reviewed-by: Neil Armstrong

Re: [PATCH v2 4/5] ASoC: qcom: sm8250: Add Fairphone 5 soundcard compatible

2025-04-18 Thread neil . armstrong
.compatible = "qcom,qrb5165-rb5-sndcard", .data = "sm8250" }, { .compatible = "qcom,sm8250-sndcard", .data = "sm8250" }, Reviewed-by: Neil Armstrong

Re: [PATCH 3/3] remoteproc: Use of_reserved_mem_region_* functions for "memory-region"

2025-03-18 Thread neil . armstrong
Hi, On 18/03/2025 00:24, Rob Herring (Arm) wrote: Use the newly added of_reserved_mem_region_to_resource() and of_reserved_mem_region_count() functions to handle "memory-region" properties. The error handling is a bit different in some cases. Often "memory-region" is optional, so failed lookup

Re: [PATCH v3 2/2] Input: goodix_berlin - Add support for Berlin-A series

2025-03-07 Thread Neil Armstrong
.name = "gt9916", .driver_data = (long)>9916_data }, { }, }; MODULE_DEVICE_TABLE(spi, goodix_berlin_spi_ids); static const struct of_device_id goodix_berlin_spi_of_match[] = { - { .compatible = "goodix,gt9916", }, + { .compatible = "goodix,gt9897", .data = >9897_data }, + { .compatible = "goodix,gt9916", .data = >9916_data }, { } }; MODULE_DEVICE_TABLE(of, goodix_berlin_spi_of_match); Thanks ! Reviewed-by: Neil Armstrong

Re: [PATCH v2 2/2] Input: goodix_berlin - Add support for Berlin-A series

2025-02-24 Thread Neil Armstrong
Hi, On 14/02/2025 06:29, Jens Reidel wrote: The current implementation of the goodix_berlin driver lacks support for revisions A and B of the Berlin IC. This change adds support for the gt9897 IC, which is a Berlin-A revision part. The differences between revision D and A are rather minor, a ha

Re: [PATCH 2/2] Input: goodix_berlin - Add support for Berlin-A series

2025-02-04 Thread Neil Armstrong
Hi, On 03/02/2025 18:43, Jens Reidel wrote: The current implementation of the goodix_berlin driver lacks support for revisions A and B of the Berlin IC. This change adds support for the gt9897 IC, which is a Berlin-A revision part. The differences between revision D and A are rather minor, a ha

Re: [PATCH 2/2] Input: goodix-berlin - fix vddio regulator references

2025-01-03 Thread Neil Armstrong
iaxyga.com/ But it's still valid: Reviewed-by: Neil Armstrong Fixes: 44362279bdd4 ("Input: add core support for Goodix Berlin Touchscreen IC") Cc: sta...@vger.kernel.org Signed-off-by: Luca Weiss --- drivers/input/touchscreen/goodix_berlin_core.c | 24

Re: [PATCH 1/2] Input: goodix-berlin - fix comment referencing wrong regulator

2025-01-03 Thread Neil Armstrong
ndor waits 15ms for AVDD to settle */ usleep_range(15000, 15100); gpiod_set_value_cansleep(cd->reset_gpio, 0); Reviewed-by: Neil Armstrong

Re: [PATCH 3/3] remoteproc: qcom: pas: enable SAR2130P audio DSP support

2024-10-28 Thread neil . armstrong
.compatible = "qcom,sc7280-adsp-pas", .data = &sm8350_adsp_resource}, Reviewed-by: Neil Armstrong

Re: [PATCH 2/3] remoteproc: qcom: pas: add minidump_id to SM8350 resources

2024-10-28 Thread neil . armstrong
.auto_boot = true, .proxy_pd_names = (char*[]){ "cx", Reviewed-by: Neil Armstrong

Re: [PATCH 6/6] remoteproc: qcom: Enable map/unmap and SHM bridge support

2024-10-11 Thread neil . armstrong
On 11/10/2024 07:05, Shiraz Hashim wrote: On Thu, Oct 10, 2024 at 08:57:56AM +0200, neil.armstr...@linaro.org wrote: On 08/10/2024 08:21, Mukesh Ojha wrote: On Mon, Oct 07, 2024 at 08:22:39PM +0530, Mukesh Ojha wrote: On Mon, Oct 07, 2024 at 10:05:08AM +0200, neil.armstr...@linaro.org wrote:

Re: [PATCH 3/6] remoteproc: qcom: Add helper function to support IOMMU devmem translation

2024-10-09 Thread neil . armstrong
Hi, On 07/10/2024 16:37, Mukesh Ojha wrote: On Mon, Oct 07, 2024 at 10:08:16AM +0200, neil.armstr...@linaro.org wrote: On 04/10/2024 23:23, Mukesh Ojha wrote: From: Shiraz Hashim Qualcomm SoCs runnning with Qualcomm EL2 hypervisor(QHEE), IOMMU translation set up for remote processors is mana

Re: [PATCH 6/6] remoteproc: qcom: Enable map/unmap and SHM bridge support

2024-10-09 Thread neil . armstrong
On 08/10/2024 08:21, Mukesh Ojha wrote: On Mon, Oct 07, 2024 at 08:22:39PM +0530, Mukesh Ojha wrote: On Mon, Oct 07, 2024 at 10:05:08AM +0200, neil.armstr...@linaro.org wrote: On 04/10/2024 23:23, Mukesh Ojha wrote: For Qualcomm SoCs runnning with Qualcomm EL2 hypervisor(QHEE), IOMMU translati

Re: [PATCH 3/6] remoteproc: qcom: Add helper function to support IOMMU devmem translation

2024-10-07 Thread neil . armstrong
On 04/10/2024 23:23, Mukesh Ojha wrote: From: Shiraz Hashim Qualcomm SoCs runnning with Qualcomm EL2 hypervisor(QHEE), IOMMU translation set up for remote processors is managed by QHEE itself however, for a case when these remote processors has to run under KVM This is not true, KVM is a Linu

Re: [PATCH 6/6] remoteproc: qcom: Enable map/unmap and SHM bridge support

2024-10-07 Thread neil . armstrong
On 04/10/2024 23:23, Mukesh Ojha wrote: For Qualcomm SoCs runnning with Qualcomm EL2 hypervisor(QHEE), IOMMU translation for remote processors is managed by QHEE and if the same SoC run under KVM, remoteproc carveout and devmem region should be IOMMU mapped from Linux PAS driver before remoteproc

Re: [PATCH] usb: typec: fsa4480: Relax CHIP_ID check

2024-08-19 Thread neil . armstrong
ot;Found FSA4480 v%lu.%lu (Vendor ID = %lu)\n", --- base-commit: ccdbf91fdf5a71881ef32b41797382c4edd6f670 change-id: 20240818-fsa4480-chipid-fix-2c7cf5810135 Best regards, Reviewed-by: Neil Armstrong

Re: [PATCH v8 0/5] soc: qcom: add in-kernel pd-mapper implementation

2024-06-06 Thread Neil Armstrong
1-qcom-pd-mapper-e12d622d4ad0 Best regards, Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Neil Armstrong # on SM8550-HDK Tested-by: Neil Armstrong # on SM8650-QRD Thanks, Neil

Re: [PATCH 1/5] dt-bindings: remoteproc: qcom,sm8550-pas: Document the SA8775p ADSP, CDSP and GPDSP

2024-05-22 Thread neil . armstrong
On 22/05/2024 15:04, Bartosz Golaszewski wrote: On Wed, May 22, 2024 at 2:42 PM wrote: On 22/05/2024 14:08, Bartosz Golaszewski wrote: From: Tengfei Fan Document the compatibles for the components used to boot the ADSP, CDSP0, CDSP1, GPDSP0 and GPDSP1 on the SA8775p SoC. Signed-off-by: Ten

Re: [PATCH 1/5] dt-bindings: remoteproc: qcom,sm8550-pas: Document the SA8775p ADSP, CDSP and GPDSP

2024-05-22 Thread neil . armstrong
On 22/05/2024 14:08, Bartosz Golaszewski wrote: From: Tengfei Fan Document the compatibles for the components used to boot the ADSP, CDSP0, CDSP1, GPDSP0 and GPDSP1 on the SA8775p SoC. Signed-off-by: Tengfei Fan Co-developed-by: Bartosz Golaszewski Signed-off-by: Bartosz Golaszewski --- .

Re: [PATCH 01/12] soc: qcom: add firmware name helper

2024-05-21 Thread neil . armstrong
On 21/05/2024 11:45, Dmitry Baryshkov wrote: Qualcomm platforms have different sets of the firmware files, which differ from platform to platform (and from board to board, due to the embedded signatures). Rather than listing all the firmware files, including full paths, in the DT, provide a way t

Re: [PATCH 06/12] remoteproc: qcom_q6v5_pas: switch to mbn files by default

2024-05-21 Thread neil . armstrong
On 21/05/2024 11:45, Dmitry Baryshkov wrote: We have been pushing userspace to use mbn files by default for ages. As a preparation for making the firmware-name optional, make the driver use .mbn instead of .mdt files by default. I think we should have a mechanism to fallback to .mdt since downs

[PATCH v7 4/4] arm64: dts: qcom: sm8650: add missing qlink_logging reserved memory for mpss

2024-01-23 Thread Neil Armstrong
The qlink_logging memory region is also used by the modem firmware, add it to the reserved memories and add it to the MPSS memory regions. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8650.dtsi | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/arm64

[PATCH v7 3/4] remoteproc: qcom: pas: Add SM8650 remoteproc support

2024-01-23 Thread Neil Armstrong
Add DSP Peripheral Authentication Service support for the SM8650 platform. Reviewed-by: Dmitry Baryshkov Signed-off-by: Neil Armstrong --- drivers/remoteproc/qcom_q6v5_pas.c | 50 ++ 1 file changed, 50 insertions(+) diff --git a/drivers/remoteproc

[PATCH v7 2/4] remoteproc: qcom: pas: make region assign more generic

2024-01-23 Thread Neil Armstrong
more generic in order to support more than a single memory region and also permit setting the regions permissions as shared. Reviewed-by: Mukesh Ojha Signed-off-by: Neil Armstrong --- drivers/remoteproc/qcom_q6v5_pas.c | 100 - 1 file changed, 66 insertions

[PATCH v7 1/4] dt-bindings: remoteproc: qcom,sm8550-pas: document the SM8650 PAS

2024-01-23 Thread Neil Armstrong
Document the DSP Peripheral Authentication Service on the SM8650 Platform. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Neil Armstrong --- .../bindings/remoteproc/qcom,sm8550-pas.yaml | 45 +- 1 file changed, 44 insertions(+), 1 deletion(-) diff --git a

[PATCH v7 0/4] remoteproc: qcom: Introduce DSP support for SM8650

2024-01-23 Thread Neil Armstrong
available at: https://git.codelinaro.org/neil.armstrong/linux/-/tree/topic/sm8650/upstream/integ Signed-off-by: Neil Armstrong --- Changes in v7: - Rebased on v6.8-rc1 - Add another memory region for MPSS, in bindings, code and DT - Kepts Krzysztof's review on bindings after agreement on irc -

[PATCH v6 2/3] remoteproc: qcom: pas: make region assign more generic

2023-12-18 Thread Neil Armstrong
more generic in order to support more than a single memory region and also permit setting the regions permissions as shared. Reviewed-by: Mukesh Ojha Signed-off-by: Neil Armstrong --- drivers/remoteproc/qcom_q6v5_pas.c | 100 - 1 file changed, 66 insertions

[PATCH v6 3/3] remoteproc: qcom: pas: Add SM8650 remoteproc support

2023-12-18 Thread Neil Armstrong
Add DSP Peripheral Authentication Service support for the SM8650 platform. Reviewed-by: Dmitry Baryshkov Signed-off-by: Neil Armstrong --- drivers/remoteproc/qcom_q6v5_pas.c | 50 ++ 1 file changed, 50 insertions(+) diff --git a/drivers/remoteproc

[PATCH v6 1/3] dt-bindings: remoteproc: qcom,sm8550-pas: document the SM8650 PAS

2023-12-18 Thread Neil Armstrong
Document the DSP Peripheral Authentication Service on the SM8650 Platform. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Neil Armstrong --- .../bindings/remoteproc/qcom,sm8550-pas.yaml | 44 +- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a

[PATCH v6 0/3] remoteproc: qcom: Introduce DSP support for SM8650

2023-12-18 Thread Neil Armstrong
available at: https://git.codelinaro.org/neil.armstrong/linux/-/tree/topic/sm8650/upstream/integ Signed-off-by: Neil Armstrong --- Changes in v6: - Rebased on next-20231218, last patch did not apply anymore - Link to v5: https://lore.kernel.org/r/20231212-topic-sm8650-upstream-remoteproc-v5-0

[PATCH v5 3/3] remoteproc: qcom: pas: Add SM8650 remoteproc support

2023-12-12 Thread Neil Armstrong
Add DSP Peripheral Authentication Service support for the SM8650 platform. Reviewed-by: Dmitry Baryshkov Signed-off-by: Neil Armstrong --- drivers/remoteproc/qcom_q6v5_pas.c | 50 ++ 1 file changed, 50 insertions(+) diff --git a/drivers/remoteproc

[PATCH v5 2/3] remoteproc: qcom: pas: make region assign more generic

2023-12-12 Thread Neil Armstrong
more generic in order to support more than a single memory region and also permit setting the regions permissions as shared. Reviewed-by: Mukesh Ojha Signed-off-by: Neil Armstrong --- drivers/remoteproc/qcom_q6v5_pas.c | 100 - 1 file changed, 66 insertions

[PATCH v5 1/3] dt-bindings: remoteproc: qcom,sm8550-pas: document the SM8650 PAS

2023-12-12 Thread Neil Armstrong
Document the DSP Peripheral Authentication Service on the SM8650 Platform. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Neil Armstrong --- .../bindings/remoteproc/qcom,sm8550-pas.yaml | 44 +- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a

[PATCH v5 0/3] remoteproc: qcom: Introduce DSP support for SM8650

2023-12-12 Thread Neil Armstrong
available at: https://git.codelinaro.org/neil.armstrong/linux/-/tree/topic/sm8650/upstream/integ Signed-off-by: Neil Armstrong --- Changes in v5: - Rename _perms to _owners per Konrad suggestion - Link to v4: https://lore.kernel.org/r/20231208-topic-sm8650-upstream-remoteproc-v4-0-a96c3e5f0

Re: [PATCH v4 2/3] remoteproc: qcom: pas: make region assign more generic

2023-12-11 Thread neil . armstrong
On 11/12/2023 10:54, Konrad Dybcio wrote: On 11.12.2023 10:37, Neil Armstrong wrote: On 09/12/2023 19:06, Konrad Dybcio wrote: On 8.12.2023 16:04, Neil Armstrong wrote: The current memory region assign only supports a single memory region. But new platforms introduces more regions to make

Re: [PATCH v4 2/3] remoteproc: qcom: pas: make region assign more generic

2023-12-11 Thread Neil Armstrong
On 09/12/2023 19:06, Konrad Dybcio wrote: On 8.12.2023 16:04, Neil Armstrong wrote: The current memory region assign only supports a single memory region. But new platforms introduces more regions to make the memory requirements more flexible for various use cases. Those new platforms also

[PATCH v4 3/3] remoteproc: qcom: pas: Add SM8650 remoteproc support

2023-12-08 Thread Neil Armstrong
Add DSP Peripheral Authentication Service support for the SM8650 platform. Reviewed-by: Dmitry Baryshkov Signed-off-by: Neil Armstrong --- drivers/remoteproc/qcom_q6v5_pas.c | 50 ++ 1 file changed, 50 insertions(+) diff --git a/drivers/remoteproc

[PATCH v4 2/3] remoteproc: qcom: pas: make region assign more generic

2023-12-08 Thread Neil Armstrong
more generic in order to support more than a single memory region and also permit setting the regions permissions as shared. Reviewed-by: Mukesh Ojha Signed-off-by: Neil Armstrong --- drivers/remoteproc/qcom_q6v5_pas.c | 100 - 1 file changed, 66 insertions

[PATCH v4 1/3] dt-bindings: remoteproc: qcom,sm8550-pas: document the SM8650 PAS

2023-12-08 Thread Neil Armstrong
Document the DSP Peripheral Authentication Service on the SM8650 Platform. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Neil Armstrong --- .../bindings/remoteproc/qcom,sm8550-pas.yaml | 44 +- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a

[PATCH v4 0/3] remoteproc: qcom: Introduce DSP support for SM8650

2023-12-08 Thread Neil Armstrong
available at: https://git.codelinaro.org/neil.armstrong/linux/-/tree/topic/sm8650/upstream/integ Signed-off-by: Neil Armstrong --- Changes in v4: - Collected review from Mukesh Ojha - Fixed adsp_unassign_memory_region() as suggested by Mukesh Ojha - Link to v3: https://lore.kernel.org/r/20231106

[PATCH v3 3/3] remoteproc: qcom: pas: Add SM8650 remoteproc support

2023-11-06 Thread Neil Armstrong
Add DSP Peripheral Authentication Service support for the SM8650 platform. Reviewed-by: Dmitry Baryshkov Signed-off-by: Neil Armstrong --- drivers/remoteproc/qcom_q6v5_pas.c | 50 ++ 1 file changed, 50 insertions(+) diff --git a/drivers/remoteproc

[PATCH v3 1/3] dt-bindings: remoteproc: qcom,sm8550-pas: document the SM8650 PAS

2023-11-06 Thread Neil Armstrong
Document the DSP Peripheral Authentication Service on the SM8650 Platform. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Neil Armstrong --- .../bindings/remoteproc/qcom,sm8550-pas.yaml | 44 +- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a

[PATCH v3 2/3] remoteproc: qcom: pas: make region assign more generic

2023-11-06 Thread Neil Armstrong
more generic in order to support more than a single memory region and also permit setting the regions permissions as shared. Signed-off-by: Neil Armstrong --- drivers/remoteproc/qcom_q6v5_pas.c | 101 - 1 file changed, 66 insertions(+), 35 deletions(-) diff

[PATCH v3 0/3] remoteproc: qcom: Introduce DSP support for SM8650

2023-11-06 Thread Neil Armstrong
available at: https://git.codelinaro.org/neil.armstrong/linux/-/tree/topic/sm8650/upstream/integ Signed-off-by: Neil Armstrong --- Changes in v3: - Collected bindings review tags - Small fixes suggested by Mukesh Ojha - Link to v2: https://lore.kernel.org/r/20231030-topic-sm8650-upstream-remoteproc

Re: [PATCH v2 2/3] remoteproc: qcom: pas: make region assign more generic

2023-11-02 Thread neil . armstrong
On 01/11/2023 15:42, Mukesh Ojha wrote: On 10/31/2023 10:36 PM, Neil Armstrong wrote: Hi, On 30/10/2023 14:10, Mukesh Ojha wrote: On 10/30/2023 3:33 PM, Neil Armstrong wrote: The current memory region assign only supports a single memory region. But new platforms introduces more regions

Re: [PATCH v2 2/3] remoteproc: qcom: pas: make region assign more generic

2023-10-31 Thread Neil Armstrong
Hi, On 30/10/2023 14:10, Mukesh Ojha wrote: On 10/30/2023 3:33 PM, Neil Armstrong wrote: The current memory region assign only supports a single memory region. But new platforms introduces more regions to make the memory requirements more flexible for various use cases. Those new platforms

[PATCH v2 2/3] remoteproc: qcom: pas: make region assign more generic

2023-10-30 Thread Neil Armstrong
more generic in order to support more than a single memory region and also permit setting the regions permissions as shared. Signed-off-by: Neil Armstrong --- drivers/remoteproc/qcom_q6v5_pas.c | 102 - 1 file changed, 66 insertions(+), 36 deletions(-) diff

[PATCH v2 0/3] remoteproc: qcom: Introduce DSP support for SM8650

2023-10-30 Thread Neil Armstrong
available at: https://git.codelinaro.org/neil.armstrong/linux/-/tree/topic/sm8650/upstream/integ Signed-off-by: Neil Armstrong --- Changes in v2: - Fixed sm8650 entries in allOf:if:then to match Krzysztof's comments - Collected reviewed-by on patch 3 - Link to v1: https://lore.kernel.org/r/202

[PATCH v2 1/3] dt-bindings: remoteproc: qcom,sm8550-pas: document the SM8650 PAS

2023-10-30 Thread Neil Armstrong
Document the DSP Peripheral Authentication Service on the SM8650 Platform. Signed-off-by: Neil Armstrong --- .../bindings/remoteproc/qcom,sm8550-pas.yaml | 44 +- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/remoteproc

[PATCH v2 3/3] remoteproc: qcom: pas: Add SM8650 remoteproc support

2023-10-30 Thread Neil Armstrong
Add DSP Peripheral Authentication Service support for the SM8650 platform. Reviewed-by: Dmitry Baryshkov Signed-off-by: Neil Armstrong --- drivers/remoteproc/qcom_q6v5_pas.c | 50 ++ 1 file changed, 50 insertions(+) diff --git a/drivers/remoteproc

Re: [PATCH 1/3] dt-bindings: remoteproc: qcom,sm8550-pas: document the SM8650 PAS

2023-10-30 Thread Neil Armstrong
On 27/10/2023 09:36, Krzysztof Kozlowski wrote: On 25/10/2023 09:35, Neil Armstrong wrote: Document the DSP Peripheral Authentication Service on the SM8650 Platform. Signed-off-by: Neil Armstrong --- .../bindings/remoteproc/qcom,sm8550-pas.yaml | 41 +- 1 file

[PATCH 2/3] remoteproc: qcom: pas: make region assign more generic

2023-10-25 Thread Neil Armstrong
more generic in order to support more than a single memory region and also permit setting the regions permissions as shared. Signed-off-by: Neil Armstrong --- drivers/remoteproc/qcom_q6v5_pas.c | 102 - 1 file changed, 66 insertions(+), 36 deletions(-) diff

[PATCH 0/3] remoteproc: qcom: Introduce DSP support for SM8650

2023-10-25 Thread Neil Armstrong
available at: https://git.codelinaro.org/neil.armstrong/linux/-/tree/topic/sm85650/upstream/integ Signed-off-by: Neil Armstrong --- Neil Armstrong (3): dt-bindings: remoteproc: qcom,sm8550-pas: document the SM8650 PAS remoteproc: qcom: pas: make region assign more generic remoteproc

[PATCH 1/3] dt-bindings: remoteproc: qcom,sm8550-pas: document the SM8650 PAS

2023-10-25 Thread Neil Armstrong
Document the DSP Peripheral Authentication Service on the SM8650 Platform. Signed-off-by: Neil Armstrong --- .../bindings/remoteproc/qcom,sm8550-pas.yaml | 41 +- 1 file changed, 40 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/remoteproc

[PATCH 3/3] remoteproc: qcom: pas: Add SM8650 remoteproc support

2023-10-25 Thread Neil Armstrong
Add DSP Peripheral Authentication Service support for the SM8650 platform. Signed-off-by: Neil Armstrong --- drivers/remoteproc/qcom_q6v5_pas.c | 50 ++ 1 file changed, 50 insertions(+) diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc

Re: [PATCH 2/2] usb: typec: add support for PTN36502 redriver

2023-10-20 Thread Neil Armstrong
On 20/10/2023 08:13, Luca Weiss wrote: On Tue Oct 17, 2023 at 10:34 AM CEST, Heikki Krogerus wrote: Hi, On Fri, Oct 13, 2023 at 04:24:48PM +0200, Luca Weiss wrote: Add a driver for the NXP PTN36502 Type-C USB 3.1 Gen 1 and DisplayPort v1.2 combo redriver. Signed-off-by: Luca Weiss Looks OK

Re: [PATCH 1/3] dt-bindings: usb: fsa4480: Add data-lanes property to endpoint

2023-10-16 Thread Neil Armstrong
On 16/10/2023 16:22, Rob Herring wrote: On Fri, Oct 13, 2023 at 01:38:05PM +0200, Luca Weiss wrote: Allow specifying data-lanes to reverse the SBU muxing orientation where necessary by the hardware design. What situation in the hardware design makes this necessary. Please describe the problem.

Re: [PATCH 2/3] usb: typec: fsa4480: Add support to swap SBU orientation

2023-10-13 Thread Neil Armstrong
p_init_i2c(client, &fsa4480_regmap_config); if (IS_ERR(fsa->regmap)) return dev_err_probe(dev, PTR_ERR(fsa->regmap), "failed to initialize regmap\n"); But since I did the same in nb7vpq904m, and the SBU can be inverted, LGTM Reviewed-by: Neil Armstrong Neil

Re: [PATCH v11 2/4] arm64: dts: mt8183: Add node for the Mali GPU

2021-04-20 Thread Neil Armstrong
On 26/01/2021 02:17, Nicolas Boichat wrote: > Add a basic GPU node for mt8183. > > Signed-off-by: Nicolas Boichat > --- > The binding we use with out-of-tree Mali drivers includes more > clocks, this is used for devfreq: the out-of-tree driver switches > clk_mux to clk_sub_parent (26Mhz), adjusts

Re: [PATCH 0/2] drm/bridge: dw-hdmi: disable loading of DW-HDMI CEC sub-driver

2021-04-20 Thread Neil Armstrong
On 20/04/2021 17:13, Hans Verkuil wrote: > On 16/04/2021 13:38, Neil Armstrong wrote: >> On 16/04/2021 11:58, Laurent Pinchart wrote: >>> Hi Neil, >>> >>> On Fri, Apr 16, 2021 at 11:27:35AM +0200, Neil Armstrong wrote: >>>> This adds DW-HDMI dr

Re: [v2,PATCH 1/3] drm/mediatek: dpi dual edge sample mode support

2021-04-19 Thread Neil Armstrong
Hi, On 14/04/2021 15:35, Rex-BC Chen wrote: > DPI can sample on falling, rising or both edge. > When DPI sample the data both rising and falling edge. > It can reduce half data io pins. > > Signed-off-by: Jitao Shi > Signed-off-by: Rex-BC Chen > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 12 ++

[PATCH v3 4/5] gpu/drm: mediatek: hdmi: add optional limit on maximal HDMI mode clock

2021-04-19 Thread Neil Armstrong
Some SoCs like the MT8167 have a hard limit on the maximal supported HDMI TMDS clock, so add a configuration value to filter out those modes. Signed-off-by: Fabien Parent Signed-off-by: Neil Armstrong --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 5 + 1 file changed, 5 insertions(+) diff

[PATCH v3 5/5] gpu/drm: mediatek: hdmi: add MT8167 configuration

2021-04-19 Thread Neil Armstrong
The MT8167 SoC have a hard limit on the maximal supported HDMI TMDS clock, and is not validated and supported for HDMI modes out of HDMI CEA modes, so add a configuration entry linked to the MT8167 compatible. Signed-off-by: Fabien Parent Signed-off-by: Neil Armstrong --- drivers/gpu/drm

[PATCH v3 3/5] gpu/drm: mediatek: hdmi: add check for CEA modes only

2021-04-19 Thread Neil Armstrong
Some SoCs like the MT8167 are not validated and supported for HDMI modes out of HDMI CEA modes, so add a configuration boolean to filter out non-CEA modes. Signed-off-by: Fabien Parent Signed-off-by: Neil Armstrong --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 4 1 file changed, 4 insertions

[PATCH v3 2/5] dt-bindings: mediatek: add mt8167 to hdmi, hdmi-ddc and cec bindings

2021-04-19 Thread Neil Armstrong
Add mt8167 SoC compatible to Mediatek hdmi, hdmi-ddc and cec schema bindings. Signed-off-by: Neil Armstrong --- .../devicetree/bindings/display/mediatek/mediatek,cec.yaml | 1 + .../devicetree/bindings/display/mediatek/mediatek,hdmi-ddc.yaml | 1 + .../devicetree/bindings/display

[PATCH v3 1/5] dt-bindings: display: mediatek,hdmi: Convert to use graph schema

2021-04-19 Thread Neil Armstrong
Update the mediatek,dpi binding to use the graph schema. Signed-off-by: Neil Armstrong --- .../display/mediatek/mediatek,cec.yaml| 51 +++ .../display/mediatek/mediatek,hdmi-ddc.yaml | 57 .../display/mediatek/mediatek,hdmi.txt| 136

[PATCH v3 0/5] mediatek: hdmi: add MT8167 configuration

2021-04-19 Thread Neil Armstrong
to specify mac TMDS supported clock - add a conf entry for the MT8167 compatible Changes since v4: - fixed bindings Neil Armstrong (5): dt-bindings: display: mediatek,hdmi: Convert to use graph schema dt-bindings: mediatek: add mt8167 to hdmi, hdmi-ddc and cec bindings gpu/drm: mediatek: hdmi

[PATCH v4 1/3] dt-bindings: display: bridge: add it66121 bindings

2021-04-19 Thread Neil Armstrong
From: Phong LE Add the ITE bridge HDMI it66121 bindings. Signed-off-by: Phong LE Signed-off-by: Neil Armstrong Reviewed-by: Rob Herring Reviewed-by: Laurent Pinchart --- .../bindings/display/bridge/ite,it66121.yaml | 124 ++ 1 file changed, 124 insertions(+) create mode

[PATCH v4 3/3] MAINTAINERS: add it66121 HDMI bridge driver entry

2021-04-19 Thread Neil Armstrong
From: Phong LE Add Neil Armstrong and myself as maintainers Signed-off-by: Phong LE Signed-off-by: Neil Armstrong Reviewed-by: Robert Foss --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9ae8444c96b4..313b3374a51e 100644 --- a

[PATCH v4 2/3] drm: bridge: add it66121 driver

2021-04-19 Thread Neil Armstrong
From: Phong LE This commit is a simple driver for bridge HMDI it66121. The input format is RBG and there is no color conversion. Audio, HDCP and CEC are not supported yet. Signed-off-by: Phong LE Signed-off-by: Neil Armstrong --- drivers/gpu/drm/bridge/Kconfig |8 + drivers/gpu/drm

[PATCH v4 0/3] drm/bridge: Add it66121 driver

2021-04-19 Thread Neil Armstrong
The IT66121 is a high-performance and low-power single channel HDMI transmitter, fully compliant with HDMI 1.3a, HDCP 1.2 and backward compatible to DVI 1.0 specifications. It supports pixel rates from 25MHz to 165MHz. This series contains document bindings, add vendor prefix, Kconfig to enable or

Re: [PATCH 0/2] drm/bridge: dw-hdmi: disable loading of DW-HDMI CEC sub-driver

2021-04-16 Thread Neil Armstrong
On 16/04/2021 11:58, Laurent Pinchart wrote: > Hi Neil, > > On Fri, Apr 16, 2021 at 11:27:35AM +0200, Neil Armstrong wrote: >> This adds DW-HDMI driver a glue option to disable loading of the CEC >> sub-driver. >> >> On some SoCs, the CEC functionality is enabl

[PATCH v2] mmc: meson-gx: replace WARN_ONCE with dev_warn_once about scatterlist size alignment in block mode

2021-04-16 Thread Neil Armstrong
rning should be removed. Fixes: e085b51c74cc ("mmc: meson-gx: check for scatterlist size alignment in block mode") Reported-by: Marek Szyprowski Signed-off-by: Neil Armstrong --- Changes since v1: - replace WARN_ONCE with dev_warn_once and explicit the warning message drivers/mmc/host/me

Re: [PATCH] mmc: meson-gx: remove useless warning about scatterlist size alignment in block mode

2021-04-16 Thread Neil Armstrong
On 15/04/2021 11:07, Ulf Hansson wrote: > On Wed, 14 Apr 2021 at 12:00, Neil Armstrong wrote: >> >> Since commit e085b51c74cc ("mmc: meson-gx: check for scatterlist size >> alignment in block mode"), >> support for SDIO SD_IO_RW_EXTENDED transferts are

[PATCH 1/2] drm/bridge/synopsys: dw-hdmi: Add an option to suppress loading CEC driver

2021-04-16 Thread Neil Armstrong
connected to a physical pin, leading to some confusion when the DW-HDMI CEC controller can't communicate on the bus. Reviewed-by: Neil Armstrong Signed-off-by: Jernej Skrabec Signed-off-by: Neil Armstrong --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 2 +- include/drm/bridge/dw_h

[PATCH 2/2] drm/meson: dw-hdmi: disable DW-HDMI CEC sub-driver

2021-04-16 Thread Neil Armstrong
On the Amlogic SoCs, the DW-HDMI HW support is here but the DW-HDMI CEC signal is not connected to a physical pin, leading to confusion when the dw-hdmi cec controller can't communicate on the bus. Disable it to avoid exposing a non-functinal bus. Signed-off-by: Neil Armstrong --- driver

[PATCH 0/2] drm/bridge: dw-hdmi: disable loading of DW-HDMI CEC sub-driver

2021-04-16 Thread Neil Armstrong
pin, leading to some confusion when the DW-HDMI CEC controller can't communicate on the bus. Jernej Skrabec (1): drm/bridge/synopsys: dw-hdmi: Add an option to suppress loading CEC driver Neil Armstrong (1): drm/meson: dw-hdmi: disable DW-HDMI CEC sub-driver drivers/gpu/drm/b

Re: [PATCH v3 2/3] drm: bridge: add it66121 driver

2021-04-15 Thread Neil Armstrong
On 14/04/2021 19:35, Paul Cercueil wrote: > Hi Neil, > > Le mer. 14 avril 2021 à 8:17, Neil Armstrong a > écrit : >> Hi, >> >> Le 13/04/2021 à 22:56, Paul Cercueil a écrit : >>>  Hi Neil, >>> >>>  I get build failures locally: &

Re: [PATCH v3 2/3] drm: bridge: add it66121 driver

2021-04-14 Thread Neil Armstrong
On 14/04/2021 10:16, Laurent Pinchart wrote: > Hi Neil, > > On Wed, Apr 14, 2021 at 10:08:46AM +0200, Neil Armstrong wrote: >> On 14/04/2021 10:06, Robert Foss wrote: >>> On Wed, 14 Apr 2021 at 08:13, Neil Armstrong >>> wrote: >>>> Le 13/04/2021

[PATCH] mmc: meson-gx: remove useless warning about scatterlist size alignment in block mode

2021-04-14 Thread Neil Armstrong
ven if the transfer works in degraded mode. This should be ultimately fixed in brcmfmac, but since it's only a performance issue the warning should be removed. Fixes: e085b51c74cc ("mmc: meson-gx: check for scatterlist size alignment in block mode") Reported-by: Marek Szyprowski Sign

Re: [PATCH v3 1/3] dt-bindings: display: bridge: add it66121 bindings

2021-04-14 Thread Neil Armstrong
On 13/04/2021 18:03, Laurent Pinchart wrote: > Hi Neil, > > Thank you for the patch. > > On Mon, Apr 12, 2021 at 05:46:46PM +0200, Neil Armstrong wrote: >> From: Phong LE >> >> Add the ITE bridge HDMI it66121 bindings. >> >> Signed-off-b

Re: [PATCH v3 2/3] drm: bridge: add it66121 driver

2021-04-14 Thread Neil Armstrong
On 14/04/2021 10:06, Robert Foss wrote: > On Wed, 14 Apr 2021 at 08:13, Neil Armstrong wrote: >> >> Hi Rob, >> >> Le 13/04/2021 à 22:21, Robert Foss a écrit : >>> Hey Neil & Phong, >>> >>> Thanks for submitting this ser

Re: [PATCH v3 2/3] drm: bridge: add it66121 driver

2021-04-13 Thread Neil Armstrong
d failures, I'll fix these for v4. Were you able to test on your setup ? The v2 always forced DDR mode, with this v3, I also switch to normal 24input mode, but totally untested. Thanks, Neil > > Cheers, > -Paul > > > Le lun. 12 avril 2021 à 17:46, Neil Armstrong a &

Re: [PATCH v3 2/3] drm: bridge: add it66121 driver

2021-04-13 Thread Neil Armstrong
Hi Rob, Le 13/04/2021 à 22:21, Robert Foss a écrit : > Hey Neil & Phong, > > Thanks for submitting this series! > >> + >> +static const struct drm_bridge_funcs it66121_bridge_funcs = { >> + .attach = it66121_bridge_attach, >> + .enable = it66121_bridge_enable, >> + .disable = i

Re: [PATCH v2 1/5] dt-bindings: display: mediatek,hdmi: Convert to use graph schema

2021-04-12 Thread Neil Armstrong
On 12/04/2021 11:39, Neil Armstrong wrote: > Update the mediatek,dpi binding to use the graph schema. > > Signed-off-by: Neil Armstrong > --- > .../display/mediatek/mediatek,cec.yaml| 51 +++ > .../display/mediatek/mediatek,hdmi-ddc.yaml | 57 >

Re: [PATCH v3 3/3] MAINTAINERS: add it66121 HDMI bridge driver entry

2021-04-12 Thread Neil Armstrong
On 12/04/2021 17:46, Neil Armstrong wrote: > From: Phong LE > > Add Neil Armstrong and myself as maintainers > > Signed-off-by: Phong LE Obviously: Signed-off-by: Neil Armstrong > --- > MAINTAINERS | 8 > 1 file changed, 8 insertions(+) > > diff --g

[PATCH v3 2/3] drm: bridge: add it66121 driver

2021-04-12 Thread Neil Armstrong
From: Phong LE This commit is a simple driver for bridge HMDI it66121. The input format is RBG and there is no color conversion. Audio, HDCP and CEC are not supported yet. Signed-off-by: Phong LE Signed-off-by: Neil Armstrong --- drivers/gpu/drm/bridge/Kconfig |8 + drivers/gpu/drm

[PATCH v3 3/3] MAINTAINERS: add it66121 HDMI bridge driver entry

2021-04-12 Thread Neil Armstrong
From: Phong LE Add Neil Armstrong and myself as maintainers Signed-off-by: Phong LE --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9ae8444c96b4..ff6450c83049 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9515,6 +9515,14 @@ Q

[PATCH v3 1/3] dt-bindings: display: bridge: add it66121 bindings

2021-04-12 Thread Neil Armstrong
From: Phong LE Add the ITE bridge HDMI it66121 bindings. Signed-off-by: Phong LE Signed-off-by: Neil Armstrong --- .../bindings/display/bridge/ite,it66121.yaml | 123 ++ 1 file changed, 123 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge

[PATCH v3 0/3] drm/bridge: Add it66121 driver

2021-04-12 Thread Neil Armstrong
The IT66121 is a high-performance and low-power single channel HDMI transmitter, fully compliant with HDMI 1.3a, HDCP 1.2 and backward compatible to DVI 1.0 specifications. It supports pixel rates from 25MHz to 165MHz. This series contains document bindings, add vendor prefix, Kconfig to enable or

[PATCH] media: meson-ge2d: fix rotation parameters

2021-04-12 Thread Neil Armstrong
With these settings, 90deg and 270deg rotation leads to inverted vertical, fix them to have correct rotation. Fixes: 59a635327ca7 ("media: meson: Add M2M driver for the Amlogic GE2D Accelerator Unit") Signed-off-by: Neil Armstrong --- drivers/media/platform/meson/ge2d/ge2d.c | 4 ++

Re: [PATCH v2] staging: media: meson: vdec: declare u32 as const and static const

2021-04-12 Thread Neil Armstrong
On 12/04/2021 14:45, Mitali Borkar wrote: > On Mon, Apr 12, 2021 at 11:17:22AM +0200, Hans Verkuil wrote: >> On 10/04/2021 21:59, Mitali Borkar wrote: >>> Declared 32 bit unsigned int as static constant inside a function and >>> replaced u32[] {x,y} as canvas1, canvas2 in codec_mpeg12.c >>> This in

[PATCH v2 2/5] dt-bindings: mediatek: add mt8167 to hdmi, hdmi-ddc and cec bindings

2021-04-12 Thread Neil Armstrong
Add mt8167 SoC compatible to Mediatek hdmi, hdmi-ddc and cec schema bindings. Signed-off-by: Neil Armstrong --- .../devicetree/bindings/display/mediatek/mediatek,cec.yaml | 1 + .../devicetree/bindings/display/mediatek/mediatek,hdmi-ddc.yaml | 1 + .../devicetree/bindings/display

[PATCH v2 4/5] gpu/drm: mediatek: hdmi: add optional limit on maximal HDMI mode clock

2021-04-12 Thread Neil Armstrong
Some SoCs like the MT8167 have a hard limit on the maximal supported HDMI TMDS clock, so add a configuration value to filter out those modes. Signed-off-by: Fabien Parent Signed-off-by: Neil Armstrong --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 5 + 1 file changed, 5 insertions(+) diff

[PATCH v2 5/5] gpu/drm: mediatek: hdmi: add MT8167 configuration

2021-04-12 Thread Neil Armstrong
The MT8167 SoC have a hard limit on the maximal supported HDMI TMDS clock, and is not validated and supported for HDMI modes out of HDMI CEA modes, so add a configuration entry linked to the MT8167 compatible. Signed-off-by: Fabien Parent Signed-off-by: Neil Armstrong --- drivers/gpu/drm

[PATCH v2 1/5] dt-bindings: display: mediatek,hdmi: Convert to use graph schema

2021-04-12 Thread Neil Armstrong
Update the mediatek,dpi binding to use the graph schema. Signed-off-by: Neil Armstrong --- .../display/mediatek/mediatek,cec.yaml| 51 +++ .../display/mediatek/mediatek,hdmi-ddc.yaml | 57 .../display/mediatek/mediatek,hdmi.txt| 136

[PATCH v2 3/5] gpu/drm: mediatek: hdmi: add check for CEA modes only

2021-04-12 Thread Neil Armstrong
Some SoCs like the MT8167 are not validated and supported for HDMI modes out of HDMI CEA modes, so add a configuration boolean to filter out non-CEA modes. Signed-off-by: Fabien Parent Signed-off-by: Neil Armstrong --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 4 1 file changed, 4 insertions

[PATCH v2 0/5] mediatek: hdmi: add MT8167 configuration

2021-04-12 Thread Neil Armstrong
to specify mac TMDS supported clock - add a conf entry for the MT8167 compatible Neil Armstrong (5): dt-bindings: display: mediatek,hdmi: Convert to use graph schema dt-bindings: mediatek: add mt8167 to hdmi, hdmi-ddc and cec bindings gpu/drm: mediatek: hdmi: add check for CEA modes only gpu

Re: [PATCH] gpu/drm: mediatek: hdmi: check for valid modes on MT8167

2021-04-12 Thread Neil Armstrong
On 10/04/2021 00:41, Chun-Kuang Hu wrote: > Hi, Neil: > > Neil Armstrong 於 2021年4月9日 週五 下午4:43寫道: >> >> On MT8167, only CEA modes and anything using a clock below 148500 is >> supported for HDMI. This change adds some checks to make sure the >> video format is

[PATCH] gpu/drm: mediatek: hdmi: check for valid modes on MT8167

2021-04-09 Thread Neil Armstrong
On MT8167, only CEA modes and anything using a clock below 148500 is supported for HDMI. This change adds some checks to make sure the video format is OK for MT8167. Signed-off-by: Fabien Parent Signed-off-by: Neil Armstrong --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 17 + 1

  1   2   3   4   5   6   7   8   9   10   >