Re: [PATCH 3/3] pinctrl: at91-pio4: fix "Prefer 'unsigned int' to bare use of 'unsigned'"

2021-01-27 Thread Ludovic Desroches
On Mon, Jan 25, 2021 at 12:19:14PM +0200, Claudiu Beznea wrote: > Fix "Prefer 'unsigned int' to bare use of 'unsigned'" checkpatch.pl > warning. > > Signed-off-by: Claudiu Beznea Acked-by: Ludovic Desroches Thanks > ---

Re: [PATCH 2/3] pinctrl: at91-pio4: add support for slew-rate

2021-01-27 Thread Ludovic Desroches
banks; > unsigned last_bank_count; > + unsigned int sr; Hi Claudiu, Nitpicking: I tend to prefer a verbose name as slew_rate or even slew_rate_support. Otherwise, Acked-by: Ludovic Desroches Regards Ludovic > }; > > struct atmel_group { > @@ -117,6 +120,7 @@ s

Re: [PATCH 1/3] dt-bindings: pinctrl: at91-pio4: add slew-rate

2021-01-27 Thread Ludovic Desroches
On Mon, Jan 25, 2021 at 12:19:12PM +0200, Claudiu Beznea wrote: > Document slew-rate DT binding for SAMA7G5. > > Signed-off-by: Claudiu Beznea Acked-by: Ludovic Desroches Thanks > --- > .../devicetree/bindings/pinctrl/atmel,at91-pio4-pinctrl.txt | 8 > +--- &g

Re: [PATCH] mmc: Assign boolean values to a bool variable

2021-01-21 Thread Ludovic Desroches
0/1 to bool variable. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Zhong Acked-by: Ludovic Desroches Thanks > --- > drivers/mmc/host/atmel-mci.c | 46 > ++-- > 1 file changed, 23 insertions(+), 23 deletions(-) > > diff --

FÜR IHRE KREDITANWENDUNGEN

2020-11-25 Thread bokossa ludovic
Hallo Wir bieten individuelle Kredite und Investitionen mit einer Rückzahlungsrate von 2% an. Kontaktieren Sie uns für Kreditanfragen. financialintercreditfics...@gmail.com

Re: [PATCH] pinctrl: at91-pio4: add support for fewer lines on last PIO bank

2020-11-24 Thread Ludovic Desroches
ading/writing to invalid register > > addresses. > > > > Signed-off-by: Eugen Hristev > > Nico/Ludovic: can you please look at this patch? I acked it one week ago but I get some nasty behaviors with my emails. Maybe you didn't receive the answer. https://lore.kernel.org/linux-gpio/20201116061549.ks6hfonyplwhknmq@sekiro/ Regards Ludovic > > Yours, > Linus Walleij

Re: [PATCH 0/3] ARM: dts: at91: add pincontrol node for USB Host

2020-11-18 Thread Ludovic Desroches
On Wed, Nov 18, 2020 at 04:26:52PM +0100, Alexandre Belloni wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Hello, > > On 18/11/2020 16:03:36+0100, Ludovic Desroches wrote: > > At first glance, there is no trivial

Re: [PATCH 0/3] ARM: dts: at91: add pincontrol node for USB Host

2020-11-18 Thread Ludovic Desroches
g pincontrol > configuration. The patch was tested on SAM9x60EK, SAMA5D4-EK and SAMA5D3-EK. > No problem on my side with this set of patches, it's consistent with what we have. Acked-by: Ludovic Desroches I just want to share the full picture leading to this situation. You told me the brea

Re: [PATCH 0/9] iio: adc: at91_adc: cleanup DT bindings

2020-11-15 Thread Ludovic Desroches
options and names and the triggers description > back in the driver. > > There are also other cleanups, like removing platform data support, this > was pending for a while. > Nice cleanup of this old and obscur binding. Reviewed-by: Ludovic Desroches Thanks. > Alexandre Bell

Re: [PATCH] pinctrl: at91-pio4: add support for fewer lines on last PIO bank

2020-11-15 Thread Ludovic Desroches
the actual 136, as this > product supports, and to avoid reading/writing to invalid register addresses. > > Signed-off-by: Eugen Hristev Acked-by: Ludovic Desroches Thanks. > --- > drivers/pinctrl/pinctrl-at91-pio4.c | 18 -- > 1 file changed, 16 inser

Re: [PATCH 4.19] dmaengine: at_hdmac: Fix memory leak

2020-09-22 Thread Ludovic Desroches
ludovic.desroc...@microchip.com, sta...@vger.kernel.org, > Greg KH > Subject: [PATCH 4.19] dmaengine: at_hdmac: Fix memory leak > > > This fixes memory leak in at_hdmac. Mainline does not have the same > problem. > > Signed-off-by: Pavel Machek (CIP) Acked-by: Ludovic Desroch

Re: [PATCH] irqchip/stm32: fix return value of stm32_exti_h_set_affinity

2020-09-21 Thread Ludovic BARRE
Hi Marc Just a gentleman ping about this patch. I verified, you could always apply this patch on linux master branch. Regards Ludo Le 6/12/20 à 9:29 AM, Ludovic Barre a écrit : exti hardware point of view, there is no specific action on set_affinity. So the affinity must be forwarded to

Re: [PATCH 1/2] dt-bindings: pinctrl: at91-pio4: add microchip,sama7g5

2020-09-20 Thread Ludovic Desroches
On Thu, Sep 17, 2020 at 04:12:56PM +0300, Eugen Hristev wrote: > Add compatible string for microchip sama7g5 SoC. > > Signed-off-by: Eugen Hristev Acked-by: Ludovic Desroches Thanks Ludovic > --- > .../devicetree/bindings/pinctrl/atmel,at91-pio4-pinctrl.txt | 4 +++- >

Re: [PATCH 2/2] pinctrl: at91-pio4: add support for sama7g5 SoC

2020-09-20 Thread Ludovic Desroches
On Thu, Sep 17, 2020 at 04:12:57PM +0300, Eugen Hristev wrote: > Add support for sama7g5 pinctrl block, which has 5 PIO banks. > > Signed-off-by: Eugen Hristev Acked-by: Ludovic Desroches Thanks. Ludovic > --- > drivers/pinctrl/pinctrl-at91-pio4.c | 7 +++ > 1 file cha

Re: [PATCH 05/10] gpio: gpio-sama5d2-piobu: Demote all kerneldoc headers to basic comment blocks

2020-07-01 Thread Ludovic Desroches
_output' > drivers/gpio/gpio-sama5d2-piobu.c:154: warning: Function parameter or member > 'chip' not described in 'sama5d2_piobu_get' > drivers/gpio/gpio-sama5d2-piobu.c:154: warning: Function parameter or member > 'pin' not described in 'sama5d2_p

[PATCH] irqchip/stm32: fix return value of stm32_exti_h_set_affinity

2020-06-12 Thread Ludovic Barre
exti hardware point of view, there is no specific action on set_affinity. So the affinity must be forwarded to parent if there is a descendent irqchips, otherwise just return IRQ_SET_MASK_OK_DONE. Signed-off-by: Ludovic Barre --- drivers/irqchip/irq-stm32-exti.c | 2 +- 1 file changed, 1

[PATCH] mmc: mmci: add sdio datactrl mask for sdmmc revisions

2020-06-11 Thread Ludovic Barre
This patch adds datactrl_mask_sdio for sdmmc revisions. sdmmc revisions used same bit of previous ST variant. Signed-off-by: Ludovic Barre --- drivers/mmc/host/mmci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c index a69d6a0c2e15

Re: [PATCH] iio: Kconfig: at91_adc: add COMPILE_TEST dependency to driver

2020-06-01 Thread Ludovic Desroches
when trying to apply a change for this. > > > > Signed-off-by: Alexandru Ardelean > Makes sense. Given this sort of change can expose weird an wonderful > dependencies that were previously hidden, I'll be wanting an > ack from at91 people. Agree. Acked-by: Ludovic De

[PATCH 1/2] mmc: mmci_sdmmc: fix DMA API warning overlapping mappings

2020-05-26 Thread Ludovic Barre
his case. This patch adds dma_unmap_sg when the dma is finalized and the data cookie is zero (request not prepared). Signed-off-by: Ludovic Barre --- drivers/mmc/host/mmci_stm32_sdmmc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mmc/host/mmci_stm32_sdmmc.c b/drivers/mmc/h

[PATCH 2/2] mmc: mmci_sdmmc: fix DMA API warning max segment size

2020-05-26 Thread Ludovic Barre
c core (host->mmc->max_seg_size). Signed-off-by: Ludovic Barre --- drivers/mmc/host/mmci_stm32_sdmmc.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/mmc/host/mmci_stm32_sdmmc.c b/drivers/mmc/host/mmci_stm32_sdmmc.c index 2965b1c062e1..51db30a

[PATCH 0/2] mmc: mmci_sdmmc: fix dma api warnings

2020-05-26 Thread Ludovic Barre
This patch series fixes warnings see with DMA_API_DEBUG_SG=y Ludovic Barre (2): mmc: mmci_sdmmc: fix DMA API warning overlapping mappings mmc: mmci_sdmmc: fix DMA API warning max segment size drivers/mmc/host/mmci_stm32_sdmmc.c | 14 -- 1 file changed, 8 insertions(+), 6

Re: [PATCH] dmaengine: at_hdmac: Replace zero-length array with flexible-array

2020-05-10 Thread Ludovic Desroches
ions) will also > help to get completely rid of those sorts of issues. > > This issue was found with the help of Coccinelle. > > [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html > [2] https://github.com/KSPP/linux/issues/21 > [3] commit 76497732932f ("cxg

Re: [PATCH] dmaengine: at_xdmac: Replace zero-length array with flexible-array

2020-05-10 Thread Ludovic Desroches
ions) will also > help to get completely rid of those sorts of issues. > > This issue was found with the help of Coccinelle. > > [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html > [2] https://github.com/KSPP/linux/issues/21 > [3] commit 76497732932f ("cxgb3/l2t: Fix

Re: [PATCH v2 1/3] dt-bindings: sdhci-of-at91: new compatible string and update properties

2019-10-18 Thread Ludovic Desroches
On Fri, Oct 18, 2019 at 12:56:14PM +0200, Ulf Hansson wrote: > On Fri, 11 Oct 2019 at 12:33, Ludovic Desroches > wrote: > > > > There is a new compatible string for the SAM9X60 sdhci device. It involves > > an update of the properties about the clocks stuff. > &

[PATCH 0/2] mmc: add unstuck function if host is in deadlock state

2019-10-11 Thread Ludovic Barre
From: Ludovic Barre As discussed in this thread: https://patchwork.kernel.org/patch/10786421/ After a request, the host could be in deadlock state, and waiting for a specific action to unstuck the hardware block before resending a new command. This series adds mmc_hw_unstuck callback (structure

[PATCH 2/2] mmc: mmci: add unstuck feature

2019-10-11 Thread Ludovic Barre
From: Ludovic Barre On busy_timeout feature if busy is too long on R1B command a datatimeout occurs and a specific actions is needed to clear the DPSM bit: -reset the controller to clear the DPSM bit. -restore registers: clk, pwr, datactrl. Signed-off-by: Ludovic Barre --- drivers/mmc/host

[PATCH 1/2] mmc: add unstuck function if host is in deadlock state

2019-10-11 Thread Ludovic Barre
From: Ludovic Barre After a request a host may be in deadlock state, and wait a specific action to unstuck the hardware block before re-sending a new command. This patch adds an optional callback mmc_hw_unstuck which allows the host to unstuck the controller. In order to avoid a critical

Re: [PATCH 2/2] mmc: sdhci-of-at91: add DT property to enable calibration on full reset

2019-10-11 Thread Ludovic Desroches
d reduce > power consumption on some SAMA5D2 SiP revisions. > > Signed-off-by: Nicolas Ferre Acked-by: Ludovic Desroches Thanks Ludovic > --- > drivers/mmc/host/sdhci-of-at91.c | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git a/drivers/mmc/host/s

[PATCH v2 3/3] ARM: dts: at91: sama5d2: set the sdmmc gclk frequency

2019-10-11 Thread Ludovic Desroches
Set the frequency of the generated clock used by sdmmc devices in order to not rely on the configuration done by previous components. Signed-off-by: Ludovic Desroches --- Changes: -v2: none arch/arm/boot/dts/sama5d2.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot

[PATCH v2 2/3] mmc: sdhci-of-at91: rework clocks management to support SAM9x60 device

2019-10-11 Thread Ludovic Desroches
clock which can take several rates. As we can't trust those values, take them from the clock tree and update the capabilities according to. As we can have the same pitfall, in some cases, with the SAMA5D2 Soc, stop relying on capabilities too. Signed-off-by: Ludovic Desroches --- Changes:

[PATCH v2 1/3] dt-bindings: sdhci-of-at91: new compatible string and update properties

2019-10-11 Thread Ludovic Desroches
There is a new compatible string for the SAM9X60 sdhci device. It involves an update of the properties about the clocks stuff. Signed-off-by: Ludovic Desroches --- Changes: - v2: remove the extra example and fix node label This patch conflicts with Nicolas' one: "dt-bindings: sdh

Re: [PATCH 2/4] i2c: at91: implement i2c bus recovery

2019-10-09 Thread Ludovic Desroches
On Wed, Oct 09, 2019 at 04:01:47PM +0200, Alexandre Belloni wrote: > > On 09/10/2019 15:55:00+0200, Ludovic Desroches wrote: > > On Wed, Oct 02, 2019 at 04:46:56PM +0200, Kamel Bouhara wrote: > > > External E-Mail > > > > > > > > > Implement i2c

Re: [PATCH 2/4] i2c: at91: implement i2c bus recovery

2019-10-09 Thread Ludovic Desroches
he future... Are you able to test these points? It would be nice to be aware of possible side effects. Regards Ludovic > Signed-off-by: Kamel Bouhara > --- > drivers/i2c/busses/i2c-at91-master.c | 63 > drivers/i2c/busses/i2c-at91.h| 8

Re: [PATCH] dmaengine: at_xdmac: Use devm_platform_ioremap_resource() in at_xdmac_probe()

2019-10-09 Thread Ludovic Desroches
> Signed-off-by: Markus Elfring Acked-by: Ludovic Desroches Thanks > --- > drivers/dma/at_xdmac.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c > index b58ac720d9a1..f71c9f77d405 100644 &

[PATCH V7 3/3] mmc: mmci: sdmmc: add busy_complete callback

2019-10-08 Thread Ludovic Barre
From: Ludovic Barre This patch adds a specific busy_complete callback for sdmmc variant. sdmmc has 2 status flags: -busyd0: This is a hardware status flag (inverted value of d0 line). it does not generate an interrupt. -busyd0end: This indicates only end of busy following a CMD response. On

[PATCH V7 2/3] mmc: mmci: add busy_complete callback

2019-10-08 Thread Ludovic Barre
From: Ludovic Barre This patch adds busy_completion callback at mmci_host_ops to allow to define a specific busy completion by variant. The legacy code corresponding to busy completion used by ux500 variants is moved to ux500_busy_complete function. Signed-off-by: Ludovic Barre --- drivers

[PATCH V7 0/3] mmc: mmci: add busy detect for stm32 sdmmc variant

2019-10-08 Thread Ludovic Barre
From: Ludovic Barre This patch series adds busy detect for stm32 sdmmc variant. Some adaptations are required: -On sdmmc the data timer is started on data transfert and busy state, so we must add hardware busy timeout support. -Add busy_complete callback at mmci_host_ops to allow to define a

[PATCH V7 1/3] mmc: mmci: add hardware busy timeout feature

2019-10-08 Thread Ludovic Barre
From: Ludovic Barre In the stm32_sdmmc variant, the datatimer is active not only during data transfers with the DPSM, but also while waiting for the busyend IRQs from commands having the MMC_RSP_BUSY flag set. This leads to an incorrect IRQ being raised to signal MCI_DATATIMEOUT error, which

Re: [PATCH 1/3] dt-bindings: sdhci-of-at91: new compatible string and update properties

2019-10-08 Thread Ludovic Desroches
On Mon, Sep 30, 2019 at 09:56:13AM -0500, Rob Herring wrote: > On Thu, Sep 12, 2019 at 10:09:06PM +0200, Ludovic Desroches wrote: > > There is a new compatible string for the SAM9X60 sdhci device. It involves > > an update of the properties about the clocks stuff. > > >

Re: [PATCH 2/3] mmc: sdhci-of-at91: rework clocks management to support SAM9x60 device

2019-10-08 Thread Ludovic Desroches
On Fri, Sep 20, 2019 at 11:34:50AM +0200, Eugen Hristev - M18282 wrote: > > > On 12.09.2019 23:09, Ludovic Desroches wrote: > > > > > In the SAM9x60 SoC, there are only two clocks instead of three for the > > SDHCI device. The base clk is no longer provided, it is

Re: [PATCH V6 3/3] mmc: mmci: sdmmc: add busy_complete callback

2019-10-07 Thread Ludovic BARRE
hi Ulf Le 10/4/19 à 9:31 AM, Ulf Hansson a écrit : On Thu, 5 Sep 2019 at 14:22, Ludovic Barre wrote: From: Ludovic Barre This patch adds a specific busy_complete callback for sdmmc variant. sdmmc has 2 status flags: -busyd0: This is a hardware status flag (inverted value of d0 line). it

Re: [PATCH V6 1/3] mmc: mmci: add hardware busy timeout feature

2019-10-04 Thread Ludovic BARRE
hi Ulf Le 10/4/19 à 8:20 AM, Ulf Hansson a écrit : On Fri, 4 Oct 2019 at 08:12, Ulf Hansson wrote: On Thu, 5 Sep 2019 at 14:21, Ludovic Barre wrote: From: Ludovic Barre In some variants, the data timer starts and decrements when the DPSM enters in Wait_R or Busy state (while data

Re: [PATCH V6 0/3] mmc: mmci: add busy detect for stm32 sdmmc variant

2019-09-18 Thread Ludovic BARRE
hi Ulf Just a "gentleman ping" about this series and https://lkml.org/lkml/2019/9/4/747 Regards Ludo Le 9/5/19 à 2:21 PM, Ludovic Barre a écrit : From: Ludovic Barre This patch series adds busy detect for stm32 sdmmc variant. Some adaptations are required: -On sdmmc the dat

Re: [PATCH] pinctrl: at91-pio4: implement .get_multiple and .set_multiple

2019-09-14 Thread Ludovic Desroches
; > Signed-off-by: Alexandre Belloni Acked-by: Ludovic Desroches Thanks for this improvement. You can keep my ack for v3 as the changes should be the commit message only. I'll be off for three weeks. Regards Ludovic > --- > drivers/pinctrl/pinctrl-at91-pio4.c | 60 ++

Re: [PATCH v5 0/9] i2c: add support for filters

2019-09-14 Thread Ludovic Desroches
s is the result of the comments on the ML in the direction > requested: to make the bindings globally available for i2c drivers. > > Changes in v5: > - renamed i2c-filter-width-ns to i2c-digital-filter-width-ns as this > is applicable only to digital filter > - created new binding i2c-digit

Re: [PATCH] i2c: at91: Send bus clear command if SCL or SDA is down

2019-09-14 Thread Ludovic Desroches
ubotariu Acked-by: Ludovic Desroches I'll be off for three weeks so if there are minor changes, you can keep my ack. Thanks Ludovic > --- > drivers/i2c/busses/i2c-at91-master.c | 20 > drivers/i2c/busses/i2c-at91.h| 6 +- > 2 files chang

[PATCH 3/3] ARM: dts: at91: sama5d2: set the sdmmc gclk frequency

2019-09-12 Thread Ludovic Desroches
Set the frequency of the generated clock used by sdmmc devices in order to not rely on the configuration done by previous components. Signed-off-by: Ludovic Desroches --- arch/arm/boot/dts/sama5d2.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch

[PATCH 1/3] dt-bindings: sdhci-of-at91: new compatible string and update properties

2019-09-12 Thread Ludovic Desroches
There is a new compatible string for the SAM9X60 sdhci device. It involves an update of the properties about the clocks stuff. Signed-off-by: Ludovic Desroches --- .../devicetree/bindings/mmc/sdhci-atmel.txt | 25 --- 1 file changed, 22 insertions(+), 3 deletions(-) diff

[PATCH 2/3] mmc: sdhci-of-at91: rework clocks management to support SAM9x60 device

2019-09-12 Thread Ludovic Desroches
clock which can take several rates. As we can't trust those values, take them from the clock tree and update the capabilities according to. As we can have the same pitfall, in some cases, with the SAMA5D2 Soc, stop relying on capabilities too. Signed-off-by: Ludovic Desroches --- drivers/mmc

[PATCH V6 3/3] mmc: mmci: sdmmc: add busy_complete callback

2019-09-05 Thread Ludovic Barre
From: Ludovic Barre This patch adds a specific busy_complete callback for sdmmc variant. sdmmc has 2 status flags: -busyd0: This is a hardware status flag (inverted value of d0 line). it does not generate an interrupt. -busyd0end: This indicates only end of busy following a CMD response. On

[PATCH V6 2/3] mmc: mmci: add busy_complete callback

2019-09-05 Thread Ludovic Barre
From: Ludovic Barre This patch adds busy_completion callback at mmci_host_ops to allow to define a specific busy completion by variant. The legacy code corresponding to busy completion used by ux500 variants is moved to ux500_busy_complete function. The busy_detect boolean property is replaced

[PATCH V6 0/3] mmc: mmci: add busy detect for stm32 sdmmc variant

2019-09-05 Thread Ludovic Barre
From: Ludovic Barre This patch series adds busy detect for stm32 sdmmc variant. Some adaptations are required: -On sdmmc the data timer is started on data transfert and busy state, so we must add hardware busy timeout support. -Add busy_complete callback at mmci_host_ops to allow to define a

[PATCH V6 1/3] mmc: mmci: add hardware busy timeout feature

2019-09-05 Thread Ludovic Barre
From: Ludovic Barre In some variants, the data timer starts and decrements when the DPSM enters in Wait_R or Busy state (while data transfer or MMC_RSP_BUSY), and generates a data timeout error if the counter reach 0. -Define max_busy_timeout (in ms) according to clock. -Set data timer register

Re: [PATCH V5 1/3] mmc: mmci: add hardware busy timeout feature

2019-09-04 Thread Ludovic BARRE
hi Ulf On 8/26/19 1:39 PM, Ulf Hansson wrote: On Tue, 13 Aug 2019 at 12:00, Ludovic Barre wrote: From: Ludovic Barre In some variants, the data timer starts and decrements when the DPSM enters in Wait_R or Busy state (while data transfer or MMC_RSP_BUSY), and generates a data timeout error

[PATCH V5 0/3] mmc: mmci: add busy detect for stm32 sdmmc variant

2019-08-13 Thread Ludovic Barre
From: Ludovic Barre This patch series adds busy detect for stm32 sdmmc variant. Some adaptations are required: -On sdmmc the data timer is started on data transfert and busy state, so we must add hardware busy timeout support. -Add busy_complete callback at mmci_host_ops to allow to define a

[PATCH V5 2/3] mmc: mmci: add busy_complete callback

2019-08-13 Thread Ludovic Barre
From: Ludovic Barre This patch adds busy_completion callback at mmci_host_ops to allow to define a specific busy completion by variant. The legacy code corresponding to busy completion used by ux500 variants is moved to ux500_busy_complete function. The busy_detect boolean property is replaced

[PATCH V5 1/3] mmc: mmci: add hardware busy timeout feature

2019-08-13 Thread Ludovic Barre
From: Ludovic Barre In some variants, the data timer starts and decrements when the DPSM enters in Wait_R or Busy state (while data transfer or MMC_RSP_BUSY), and generates a data timeout error if the counter reach 0. -Define max_busy_timeout (in ms) according to clock. -Set data timer register

[PATCH V5 3/3] mmc: mmci: sdmmc: add busy_complete callback

2019-08-13 Thread Ludovic Barre
From: Ludovic Barre This patch adds a specific busy_complete callback for sdmmc variant. sdmmc has 2 status flags: -busyd0: This is a hardware status flag (inverted value of d0 line). it does not generate an interrupt. -busyd0end: This indicates only end of busy following a CMD response. On

Re: [PATCH 2/2] ARM: dts: at91: sama5d27_som1_ek: add mmc capabilities for SDMMC0

2019-08-12 Thread Ludovic Desroches
On Mon, Aug 12, 2019 at 03:38:34PM +, eugen.hris...@microchip.com wrote: > On 09.08.2019 09:23, Ludovic Desroches wrote: > > On Thu, Aug 08, 2019 at 03:57:30PM +0300, Adrian Hunter wrote: > >> On 8/08/19 3:42 PM, Ludovic Desroches wrote: > >>> On Thu, Aug 08, 2

Re: [PATCH 1/2] mmc: sdhci-of-at91: add quirk for broken HS200

2019-08-09 Thread Ludovic Desroches
c commit that it fixes? I think so, I would say: Fixes: bb5f8ea4d514 ("mmc: sdhci-of-at91: introduce driver for the Atmel SDMMC") Cc: sta...@vger.kernel.org #v4.4 and later It doesn't apply on 4.4 but resolution is trivial. Regards Ludovic > > Kind regards > Uffe > &

Re: [PATCH 2/2] ARM: dts: at91: sama5d27_som1_ek: add mmc capabilities for SDMMC0

2019-08-08 Thread Ludovic Desroches
On Thu, Aug 08, 2019 at 03:57:30PM +0300, Adrian Hunter wrote: > On 8/08/19 3:42 PM, Ludovic Desroches wrote: > > On Thu, Aug 08, 2019 at 10:35:43AM +0200, Eugen Hristev - M18282 wrote: > >> From: Eugen Hristev > >> > >> Add mmc capabilities for SDMMC0 for this

Re: [PATCH 1/2] mmc: sdhci-of-at91: add quirk for broken HS200

2019-08-08 Thread Ludovic Desroches
ll fail, > and the eMMC initialization will fail. > > Signed-off-by: Eugen Hristev Acked-by: Ludovic Desroches Thanks Ludovic > --- > drivers/mmc/host/sdhci-of-at91.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-of-at91.c > b/dri

Re: [PATCH 2/2] ARM: dts: at91: sama5d27_som1_ek: add mmc capabilities for SDMMC0

2019-08-08 Thread Ludovic Desroches
Eugen Hristev Acked-by: Ludovic Desroches I am interested to have the some insights about the use of sd-uhs-* properties. Our IP can't deal with 1V8 by itself. It has a 1V8SEL signal which can be used as the logic control input of a mux. So even if the IP claims to support UHS modes, it depends

[PATCH V4 0/3] mmc: mmci: add busy detect for stm32 sdmmc variant

2019-08-05 Thread Ludovic Barre
From: Ludovic Barre This patch series adds busy detect for stm32 sdmmc variant. Some adaptations are required: -On sdmmc the data timer is started on data transfert and busy state, so we must add hardware busy timeout support. -Add busy_complete callback at mmci_host_ops to allow to define a

[PATCH V4 2/3] mmc: mmci: add busy_complete callback

2019-08-05 Thread Ludovic Barre
From: Ludovic Barre This patch adds busy_completion callback at mmci_host_ops to allow to define a specific busy completion by variant. The legacy code corresponding to busy completion used by ux500 variants is moved to ux500_busy_complete function. The busy_detect boolean property is replaced

[PATCH V4 1/3] mmc: mmci: add hardware busy timeout feature

2019-08-05 Thread Ludovic Barre
From: Ludovic Barre In some variants, the data timer starts and decrements when the DPSM enters in Wait_R or Busy state (while data transfer or MMC_RSP_BUSY), and generates a data timeout error if the counter reach 0. -Define max_busy_timeout (in ms) according to clock. -Set data timer register

[PATCH V4 3/3] mmc: mmci: sdmmc: add busy_complete callback

2019-08-05 Thread Ludovic Barre
From: Ludovic Barre This patch adds a specific busy_complete callback for sdmmc variant. sdmmc has 2 status flags: -busyd0: This is a hardware status flag (inverted value of d0 line). it does not generate an interrupt. -busyd0end: This indicates only end of busy following a CMD response. On

Re: [Linux-stm32] [PATCH V3 1/3] mmc: mmci: fix read status for busy detect

2019-08-05 Thread Ludovic BARRE
hi Ulf On 7/26/19 11:41 AM, Ludovic BARRE wrote: hi Ulf Thanks to your "Clarify comments ..." commit, like is closes I resumed upstream of this series. On 7/15/19 6:31 PM, Ulf Hansson wrote: On Mon, 3 Jun 2019 at 17:55, Ludovic Barre wrote: From: Ludovic Barre "busy_detec

Re: [PATCH] mmc: atmel-mci: Mark expected switch fall-throughs

2019-08-01 Thread Ludovic Desroches
On Wed, Jul 31, 2019 at 09:06:07AM -0700, Kees Cook wrote: > On Wed, Jul 31, 2019 at 01:32:16PM +0200, Ludovic Desroches wrote: > > > drivers/mmc/host/atmel-mci.c:2426:40: warning: this statement may fall > > > through [-Wimplicit-fallthrough=] > > >host->c

Re: [PATCH] crypto: atmel-sha204a: Use device-managed registration API

2019-07-31 Thread Ludovic Desroches
On Tue, Jul 23, 2019 at 03:19:36PM +0800, Chuhong Yuan wrote: > > Use devm_hwrng_register to get rid of manual > unregistration. > > Signed-off-by: Chuhong Yuan Acked-by: Ludovic Desroches Thanks > --- > drivers/crypto/atmel-sha204a.c | 3 +-- > 1 file changed, 1 i

Re: [PATCH] mmc: atmel-mci: Mark expected switch fall-throughs

2019-07-31 Thread Ludovic Desroches
y: Gustavo A. R. Silva I don't know if there is a policy in the kernel about the expression to use. As this one does the job Acked-by: Ludovic Desroches Thanks > --- > drivers/mmc/host/atmel-mci.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/drivers/mmc/host/

Re: [PATCH V3 1/3] mmc: mmci: fix read status for busy detect

2019-07-26 Thread Ludovic BARRE
hi Ulf Thanks to your "Clarify comments ..." commit, like is closes I resumed upstream of this series. On 7/15/19 6:31 PM, Ulf Hansson wrote: On Mon, 3 Jun 2019 at 17:55, Ludovic Barre wrote: From: Ludovic Barre "busy_detect_flag" is used to read & clear b

RE: [PATCH V3 0/3] mmc: mmci: add busy detect for stm32 sdmmc variant

2019-07-15 Thread Ludovic BARRE
Hi Ulf like scheduled, I send you a "gentleman ping" about this series. Regards, Ludo De : Ulf Hansson Envoyé : jeudi 20 juin 2019 15:50 À : Ludovic BARRE Cc : Rob Herring; Srinivas Kandagatla; Maxime Coquelin; Alexandre TORGUE; Linux ARM; Li

Re: [PATCH v3 0/9] i2c: add support for filters

2019-07-12 Thread Ludovic Desroches
2c-core-base.c| 2 + > include/linux/i2c.h | 2 + > 9 files changed, 121 insertions(+), 4 deletions(-) Hi, I don't know if it will fit other vendors need concerning the binding but for Microchip it sounds good. Acked-by: Ludovic Desroches for the whole serie. Regards Ludovic

Re: [PATCH] dmaengine: at_xdmac: check for non-empty xfers_list before invoking callback

2019-07-01 Thread Ludovic Desroches
On Sat, Jun 29, 2019 at 01:50:48PM +0530, Raag Jadav wrote: > > tx descriptor retrieved from an empty xfers_list may not have valid > pointers to the callback functions. > Avoid calling dmaengine_desc_get_callback_invoke if xfers_list is empty. > > Signed-off-by: Raag Jadav

[PATCH] ARM: dts: stm32: activate dma for qspi on stm32mp157

2019-06-27 Thread Ludovic Barre
From: Ludovic Barre This patch activates dma for qspi on stm32mp157. Signed-off-by: Ludovic Barre --- arch/arm/boot/dts/stm32mp157c.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi index 2afeee6..205ea1d

[PATCH] spi: stm32-qspi: remove signal sensitive on completion

2019-06-27 Thread Ludovic Barre
From: Ludovic Barre On umount step a sigkill signal is set (without user specific action), due to sigkill signal the completion will be interrupted and the data transfer can't be finished if a sync is needed. Signed-off-by: Ludovic Barre --- drivers/spi/spi-stm32-qspi.c | 10 +++-

[PATCH] dt-bindings: spi: stm32-qspi: add dma properties

2019-06-27 Thread Ludovic Barre
From: Ludovic Barre This patch adds description of dma properties (optional). Signed-off-by: Ludovic Barre --- Documentation/devicetree/bindings/spi/spi-stm32-qspi.txt | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/spi/spi-stm32

Re: [PATCH V3 0/3] mmc: mmci: add busy detect for stm32 sdmmc variant

2019-06-13 Thread Ludovic BARRE
hi Ulf Just a "gentleman ping" about this series. I know you are busy, it's just to be sure you do not forget me :-) Regards Ludo On 6/3/19 5:55 PM, Ludovic Barre wrote: From: Ludovic Barre This patch series adds busy detect for stm32 sdmmc variant. Some adaptations are r

Re: [PATCH] clk: at91: generated: Truncate divisor to GENERATED_MAX_DIV + 1

2019-06-12 Thread Ludovic Desroches
Fixes: 8c7aa6328947 ("clk: at91: clk-generated: remove useless divisor > > loop") > > Signed-off-by: Codrin Ciubotariu > > Yes: > Acked-by: Nicolas Ferre Acked-by: Ludovic Desroches Thanks Ludovic > > Thanks for having fixed this Codrin. Best regards, >

[PATCH V3 0/3] mmc: mmci: add busy detect for stm32 sdmmc variant

2019-06-03 Thread Ludovic Barre
From: Ludovic Barre This patch series adds busy detect for stm32 sdmmc variant. Some adaptations are required: -Clear busy status bit if busy_detect_flag and busy_detect_mask are different. -Add hardware busy timeout with MMCIDATATIMER register. V3: -rebase on latest mmc next -replace re-read

[PATCH V3 1/3] mmc: mmci: fix read status for busy detect

2019-06-03 Thread Ludovic Barre
From: Ludovic Barre "busy_detect_flag" is used to read & clear busy value of mmci status. "busy_detect_mask" is used to manage busy irq of mmci mask. So to read mmci status the busy_detect_flag must be take account. if the variant does not support busy detect feature th

[PATCH V3 2/3] mmc: mmci: add hardware busy timeout feature

2019-06-03 Thread Ludovic Barre
From: Ludovic Barre In some variants, the data timer is enabled when the DPSM is in busy state (while data transfer or MMC_RSP_BUSY), and could generate a data timeout error if the counter reach 0. -Define max_busy_timeout (in ms) according to clock. -Set data timer register if the command has

[PATCH V3 3/3] mmc: mmci: add busy detect for stm32 sdmmc variant

2019-06-03 Thread Ludovic Barre
From: Ludovic Barre This patch enables busy detection for stm32 sdmmc which requires to set data timer to define the busy timeout. sdmmc has 2 flags: -busyd0: inverted value of d0 line. -busyd0end which indicates only end of busy following a cmd response. Only one interrupt on busyd0end. Signed

Re: [PATCH V2 3/5] mmc: mmci: fix clear of busy detect status

2019-05-29 Thread Ludovic BARRE
hi Ulf On 5/27/19 8:17 PM, Ulf Hansson wrote: On Fri, 26 Apr 2019 at 09:46, Ludovic Barre wrote: From: Ludovic Barre The "busy_detect_flag" is used to read/clear busy value of mmci status. The "busy_detect_mask" is used to manage busy irq of mmci mask. For sdmmc varia

Re: [PATCH V2 0/5] mmc: mmci: add busy detect for stm32 sdmmc variant

2019-05-21 Thread Ludovic BARRE
On 5/21/19 9:56 AM, Ulf Hansson wrote: On Tue, 21 May 2019 at 09:38, Ludovic BARRE wrote: hi Ulf Just a "gentleman ping" about the rest of series. "mmc: mmci: add busy detect for stm32 sdmmc variant" Thanks! It's been a busy period and I am currently traveling.

Re: [PATCH V2 0/5] mmc: mmci: add busy detect for stm32 sdmmc variant

2019-05-21 Thread Ludovic BARRE
hi Ulf Just a "gentleman ping" about the rest of series. "mmc: mmci: add busy detect for stm32 sdmmc variant" Regards Ludo On 5/3/19 3:29 PM, Ulf Hansson wrote: On Tue, 30 Apr 2019 at 14:06, Ludovic BARRE wrote: On 4/30/19 1:13 PM, Ulf Hansson wrote: On Fri,

Re: [PATCH] i2c: at91: handle TXRDY interrupt spam

2019-05-14 Thread Ludovic Desroches
On Mon, May 06, 2019 at 10:19:01AM +0200, Eugen Hristev - M18282 wrote: > > > On 04.05.2019 02:58, Raag Jadav wrote: > > > On Thu, May 02, 2019 at 04:01:16PM +0200, Ludovic Desroches wrote: > >> On Tue, Apr 30, 2019 at 04:03:32AM +0530, Raag Jadav w

Re: [PATCH] i2c: at91: handle TXRDY interrupt spam

2019-05-14 Thread Ludovic Desroches
On Sat, May 04, 2019 at 05:28:51AM +0530, Raag Jadav wrote: > On Thu, May 02, 2019 at 04:01:16PM +0200, Ludovic Desroches wrote: > > On Tue, Apr 30, 2019 at 04:03:32AM +0530, Raag Jadav wrote: > > > External E-Mail > > > > > > > > > On Mon, Apr 29

[PATCH] mtd: spi-nor: stm32: remove the driver as it was replaced by spi-stm32-qspi.c

2019-05-07 Thread Ludovic Barre
From: Ludovic Barre There's a new driver using the SPI memory interface of the SPI framework at spi/spi-stm32-qspi.c, which can be used together with m25p80.c to replace the functionality of this SPI NOR driver. The "new" driver uses the same dt properties and not aff

Re: [PATCH V2 0/5] mmc: mmci: add busy detect for stm32 sdmmc variant

2019-05-03 Thread Ludovic BARRE
hi Ulf On 5/3/19 3:29 PM, Ulf Hansson wrote: On Tue, 30 Apr 2019 at 14:06, Ludovic BARRE wrote: On 4/30/19 1:13 PM, Ulf Hansson wrote: On Fri, 26 Apr 2019 at 09:46, Ludovic Barre wrote: From: Ludovic Barre This patch series adds busy detect for stm32 sdmmc variant. Some adaptations

[PATCH V3] watchdog: stm32: add dynamic prescaler support

2019-05-03 Thread Ludovic Barre
From: Ludovic Barre This patch allows to define the max prescaler by compatible. To set a large range of timeout, the prescaler should be set dynamically (from the timeout request) to improve the resolution in order to have a timeout close to the expected value. Signed-off-by: Ludovic Barre

Re: [PATCH V2 1/3] watchdog: stm32: update to devm_watchdog_register_device

2019-05-03 Thread Ludovic BARRE
hi Guenter On 5/2/19 10:21 PM, Guenter Roeck wrote: On Thu, May 02, 2019 at 04:08:44PM +0200, Ludovic Barre wrote: From: Ludovic Barre This patch updates to devm_watchdog_register_device interface Not that easy. See below. A more complete solution is at https://patchwork.kernel.org/patch

[PATCH V2 2/3] watchdog: stm32: update return values recommended by watchdog kernel api

2019-05-02 Thread Ludovic Barre
From: Ludovic Barre This patch updates return values on watchdog-kernel-api.txt: return 0 on succes, -EINVAL for "parameter out of range" and -EIO for "could not write value to the watchdog". Signed-off-by: Ludovic Barre --- drivers/watchdog/stm32_iwdg.c | 21 +

[PATCH V2 0/3] watchdog: stm32: add dynamic prescaler support

2019-05-02 Thread Ludovic Barre
From: Ludovic Barre This patch series updates stm32 watchdog driver on: -use devm_watchdog_register_device -Guenter's recommendation about return value: set_timeout return 0 on succes, -EINVAL for "parameter out of range" and -EIO for "could not write value to the watchdog

[PATCH V2 3/3] watchdog: stm32: add dynamic prescaler support

2019-05-02 Thread Ludovic Barre
From: Ludovic Barre This patch allows to define the max prescaler by compatible. To set a large range of timeout, the prescaler should be set dynamically (from the timeout request) to improve the resolution in order to have a timeout close to the expected value. Signed-off-by: Ludovic Barre

[PATCH V2 1/3] watchdog: stm32: update to devm_watchdog_register_device

2019-05-02 Thread Ludovic Barre
From: Ludovic Barre This patch updates to devm_watchdog_register_device interface Signed-off-by: Ludovic Barre --- drivers/watchdog/stm32_iwdg.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/watchdog/stm32_iwdg.c b/drivers/watchdog/stm32_iwdg.c index e00e3b3

Re: [PATCH] i2c: at91: handle TXRDY interrupt spam

2019-05-02 Thread Ludovic Desroches
On Tue, Apr 30, 2019 at 04:03:32AM +0530, Raag Jadav wrote: > External E-Mail > > > On Mon, Apr 29, 2019 at 11:00:05AM +0200, Ludovic Desroches wrote: > > Hello Raag, > > > > On Tue, Apr 23, 2019 at 01:06:48PM +0530, Raag Jadav wrote: > > > External E-

Re: [PATCH V2 0/5] mmc: mmci: add busy detect for stm32 sdmmc variant

2019-04-30 Thread Ludovic BARRE
On 4/30/19 1:13 PM, Ulf Hansson wrote: On Fri, 26 Apr 2019 at 09:46, Ludovic Barre wrote: From: Ludovic Barre This patch series adds busy detect for stm32 sdmmc variant. Some adaptations are required: -Avoid to check and poll busy status when is not expected. -Clear busy status bit if

Re: [PATCH] watchdog: stm32: add dynamic prescaler support

2019-04-29 Thread Ludovic BARRE
Hi Guenter On 4/26/19 4:16 PM, Guenter Roeck wrote: On Fri, Apr 26, 2019 at 03:41:15PM +0200, Ludovic Barre wrote: From: Ludovic Barre This patch allows to define the max prescaler by compatible. To set a large range of timeout, the prescaler should be set dynamically (from the timeout

  1   2   3   4   5   6   7   8   9   10   >