RE: [PATCHv2 0/4] LS1021A: Add dcfb framebuffer driver support.

2014-12-04 Thread li.xi...@freescale.com
t.com; linux-fb...@vger.kernel.org; linux- > ker...@vger.kernel.org; shawn@linaro.org; alexander.stein@systec- > electronic.com > Subject: Re: [PATCHv2 0/4] LS1021A: Add dcfb framebuffer driver support. > > On 04/12/14 11:54, li.xi...@freescale.com wrote: > > Hi Tomi, > >

RE: [PATCHv2 0/4] LS1021A: Add dcfb framebuffer driver support.

2014-12-04 Thread li.xi...@freescale.com
Hi Tomi, Thanks for your information very much. > > Sorry for confusing, it was delayed for other reasons internal. > > > > I am not familiar about the DRM, and I'd like to know if the DRM driver will > be > > support, should I also develop the libdrm too ? Or just coding in kernel > level ? > >

RE: [PATCHv2 0/4] LS1021A: Add dcfb framebuffer driver support.

2014-12-04 Thread li.xi...@freescale.com
awn@linaro.org; alexander.stein@systec- > electronic.com > Subject: Re: [PATCHv2 0/4] LS1021A: Add dcfb framebuffer driver support. > > Hi Xiubo, > > On 04/12/14 03:56, li.xi...@freescale.com wrote: > > Hi Arnd, > > > > Thanks for you advice. > > > >

RE: [PATCHv2 0/4] LS1021A: Add dcfb framebuffer driver support.

2014-12-03 Thread li.xi...@freescale.com
Hi Arnd, Thanks for you advice. Because this is very emergency for customers and have delayed for monthes, and the DRM/KMS will have a little long time to be supported. So I'd like to add this first and will add DRM/KMS version later. Thanks very much, BRs Xiubo > -Original Message-

RE: [PATCH 1/4] video: fsl-dcfb: Add dcfb framebuffer driver for LS1021A platform

2014-12-01 Thread li.xi...@freescale.com
Hi Alexander, Thanks very much for your comments. > On Monday 24 November 2014 18:20:51, Xiubo Li wrote: > > [...] > > +static int fsl_dcfb_init_fbinfo(struct fb_info *info) > > +{ > > + struct fsl_dcfb_mfb_info *mfbi = info->par; > > + struct fb_var_screeninfo *var = &info->var; > > + stru

RE: [PATCH v2 0/3] pwm: ftm: add Power Management support

2014-12-01 Thread li.xi...@freescale.com
> Subject: Re: [PATCH v2 0/3] pwm: ftm: add Power Management support > > On Mon, Dec 01, 2014 at 03:25:02AM +0000, li.xi...@freescale.com wrote: > > Ping :) . > > > > Thanks very much. > > Applied with a few whitespace cleanups. > Hi Thierry, Thanks verrr

RE: [PATCH v2 0/3] pwm: ftm: add Power Management support

2014-11-30 Thread li.xi...@freescale.com
Ping :) . Thanks very much. BRs Xiubo > -Original Message- > From: Xiubo Li [mailto:li.xi...@freescale.com] > Sent: Wednesday, October 15, 2014 1:22 PM > To: thierry.red...@gmail.com; linux-...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org; Xiubo Li-B47053 > Subject: [PATCH v2 0/3

RE: [PATCH 0/4] LS1021A: Add dcfb framebuffer driver support.

2014-11-30 Thread li.xi...@freescale.com
Hi, I'd like to know the status of this patches for internal release needed. Thanks very much, BRs Xiubo > -Original Message- > From: Xiubo Li [mailto:li.xi...@freescale.com] > Sent: Monday, November 24, 2014 6:21 PM > To: plagn...@jcrosoft.com; tomi.valkei...@ti.com > Cc: shawn@li

RE: [PATCH] audio: sai: Add Power Management support

2014-10-29 Thread li.xi...@freescale.com
Hi, > -Original Message- > From: linux-arm-kernel [mailto:linux-arm-kernel-boun...@lists.infradead.org] > On Behalf Of Mark Brown > Sent: Wednesday, October 29, 2014 7:37 PM > To: Wang Huan-B18965 > Cc: alsa-de...@alsa-project.org; ti...@suse.de; linux-kernel@vger.kernel.org; > lgirdw...@

RE: [PATCH v2 0/3] pwm: ftm: add Power Management support

2014-10-27 Thread li.xi...@freescale.com
Hi Thierry, Ping... Thanks, BRs Xiubo > -Original Message- > From: Xiubo Li [mailto:li.xi...@freescale.com] > Sent: Wednesday, October 15, 2014 1:22 PM > To: thierry.red...@gmail.com; linux-...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org; Xiubo Li-B47053 > Subject: [PATCH v2 0

RE: [PATCH v3] ARM: ls1021a: add gating clocks to IP blocks.

2014-10-15 Thread li.xi...@freescale.com
Hi Shawn, [...] > > + DCFG_CCSR_DEVDISR1, > > + ls1021a_clk_shift(0)); > > I think we can ignore the 80 columns warning and put these on one line > to make the code a bit easier to read. > Yes, it looks better,

RE: [PATCH] mfd: syscon: binding: Add syscon endianness support.

2014-10-13 Thread li.xi...@freescale.com
Hi DT guys, Could someone help me review or ack this patch? Thanks very much. BRs Xiubo > -Original Message- > From: Xiubo Li [mailto:li.xi...@freescale.com] > Sent: Thursday, September 18, 2014 3:27 PM > To: Dong Aisheng-B29396; pankaj.du...@samsung.com; robh...@kernel.org; > pawel.m

RE: [PATCH 6/6] regmap: cache: Fix possible ZERO_SIZE_PTR pointer dereferencing error.

2014-10-13 Thread li.xi...@freescale.com
> Subject: Re: [PATCH 6/6] regmap: cache: Fix possible ZERO_SIZE_PTR pointer > dereferencing error. > > On Thu, Oct 09, 2014 at 05:02:57PM +0800, Xiubo Li wrote: > > When all the registers are volatile(unlikely, but logically and mostly > > will happen for some 'device' who has very few registers)

RE: [PATCH 2/6] regmap: cache: cleanup regcache_hw_init().

2014-10-13 Thread li.xi...@freescale.com
Hi Mark, > Subject: Re: [PATCH 2/6] regmap: cache: cleanup regcache_hw_init(). > > On Thu, Oct 09, 2014 at 05:02:53PM +0800, Xiubo Li wrote: > > Remove the redundant code for regmap cache. > > Applied, thanks. With changes like this it is much better if the > changelog explains why the code is

RE: [PATCH] regmap: fix possible ZERO_SIZE_PTR pointer dereferencing error.

2014-09-29 Thread li.xi...@freescale.com
Hi, > > > diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c > > index 455a877..3d93e38 100644 > > --- a/drivers/base/regmap/regmap.c > > +++ b/drivers/base/regmap/regmap.c > > @@ -1716,6 +1716,9 @@ out: > > Whatever you're using to generate the patches isn't annotating wit

RE: [PATCH v2] clocksource: Add BE APIs support for clocksource counter reading.

2014-09-29 Thread li.xi...@freescale.com
Hi, > Subject: RE: [PATCH v2] clocksource: Add BE APIs support for clocksource > counter reading. > > On Sun, 28 Sep 2014, li.xi...@freescale.com wrote: > > > Subject: Re: [PATCH v2] clocksource: Add BE APIs support for clocksource > > > counter reading. > > &

RE: [PATCH] regmap: fix possible ZERO_SIZE_PTR pointer dereferencing error.

2014-09-28 Thread li.xi...@freescale.com
Hi Mark, > Subject: [PATCH] regmap: fix possible ZERO_SIZE_PTR pointer dereferencing > error. > > Since we cannot make sure the 'val_count' will always be none zero > here, and then if it equals to zero, the kmemdup() will return > ZERO_SIZE_PTR, which equals to ((void *)16). > > So this patch

RE: [PATCH v2] clocksource: Add BE APIs support for clocksource counter reading.

2014-09-27 Thread li.xi...@freescale.com
Hi, > Subject: Re: [PATCH v2] clocksource: Add BE APIs support for clocksource > counter reading. > > On Fri, 26 Sep 2014, Xiubo Li wrote: > > For now I just added _be() support using ioread{16,32}be. > > And i have a check of the clocksource drivers, didn't find anyone > > using LE mode on one

RE: [PATCH] ARM: Kconfig: Open force maximum zone order for all SoCs

2014-09-26 Thread li.xi...@freescale.com
> Subject: Re: [PATCH] ARM: Kconfig: Open force maximum zone order for all SoCs > > On Fri, Sep 26, 2014 at 08:39:04AM +0000, li.xi...@freescale.com wrote: > > [...] > > > On Fri, Sep 26, 2014 at 05:30:40AM +, li.xi...@freescale.com wrote: > > > > Hi Russe

RE: [PATCH] ARM: Kconfig: Open force maximum zone order for all SoCs

2014-09-26 Thread li.xi...@freescale.com
[...] > On Fri, Sep 26, 2014 at 05:30:40AM +0000, li.xi...@freescale.com wrote: > > Hi Russell, > > > > I'd like to know the status of this patch. > > > > Our Platforms depend on it. > > I'm not applying it. This option should not be exposed fo

RE: [PATCH] ARM: Kconfig: Open force maximum zone order for all SoCs

2014-09-25 Thread li.xi...@freescale.com
Hi Russell, I'd like to know the status of this patch. Our Platforms depend on it. Thanks, BRs Xiubo > -Original Message- > From: Xiubo Li [mailto:li.xi...@freescale.com] > Sent: Monday, September 01, 2014 12:42 PM > To: li...@arm.linux.org.uk; linux-arm-ker...@lists.infradead.org > Cc

RE: [PATCH v3] ARM: ls1021a: add gating clocks to IP blocks.

2014-09-25 Thread li.xi...@freescale.com
> > > As the parent of the clocks registered by this function is "dummy" from > > > what I see, what is the point of setting flag CLK_SET_RATE_PARENT then? > > > > > > > + CLK_IGNORE_UNUSED, reg, shift, > > > > > > Why flag CLK_IGNORE_UNUSED? > > > > > > > As the SoC reference

RE: [PATCH v3] ARM: ls1021a: add gating clocks to IP blocks.

2014-09-25 Thread li.xi...@freescale.com
Hi, [...] > > +Required properties: > > +- compatible: Should be "fsl,ls1021a-gate" > > +- reg: Address and length of the register set > > +- #clock-cells:Should be <1> > > + > > +Optional property: > > +- big-endian: If present the gate cl

RE: [PATCH] fbdev: fsl-sii902x: HDMI support for Freescale SoCs

2014-09-23 Thread li.xi...@freescale.com
Hi, [...] > >>> 4 files changed, 551 insertions(+) > >>> create mode 100644 Documentation/devicetree/bindings/video/fsl- > sii902x.txt > >>> create mode 100644 drivers/video/fbdev/fsl-sii902x.c > >> > >> I don't know how you picked the names of the people you sent this patch > >> to, but looks

RE: [PATCH v2] watchdog: imx2_wdt: Add power management support.

2014-09-23 Thread li.xi...@freescale.com
Hi, [...] > > +#ifdef CONFIG_PM_SLEEP > > +/* Disable watchdog if it is active or non-active but still running */ > > +static int imx2_wdt_suspend(struct device *dev) > > +{ > > + struct watchdog_device *wdog = dev_get_drvdata(dev); > > + struct imx2_wdt_device *wdev = watchdog_get_drvdata(wd

RE: [PATCH v5] mfd: syscon: Decouple syscon interface from platform devices

2014-09-22 Thread li.xi...@freescale.com
Hi, [...] > +static struct regmap_config syscon_regmap_config = { > + .reg_bits = 32, > + .val_bits = 32, > + .reg_stride = 4, > }; > > -static int syscon_match_node(struct device *dev, void *data) > +static struct syscon *of_syscon_register(struct device_node *np) > { > - struc

RE: [PATCH v2] ARM: ls1021a: add gating clocks to IP blocks.

2014-09-22 Thread li.xi...@freescale.com
Hi, [...] > > +++ b/arch/arm/mach-imx/clk-ls1021a.c > > @@ -0,0 +1,124 @@ > > +/* > > + * Copyright 2014 Freescale Semiconductor, Inc. > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License as published by

RE: [PATCH] ARM: ls1021a: add gating clocks to IP blocks.

2014-09-21 Thread li.xi...@freescale.com
Hi, > Subject: Re: [PATCH] ARM: ls1021a: add gating clocks to IP blocks. > > On Fri, Sep 19, 2014 at 11:37:27AM +0100, Xiubo Li wrote: > > A given application may not use all the peripherals on the device. > > In this case, it may be desirable to disable unused peripherals. > > DCFG provides a me

RE: [PATCH v3] mfd: syscon: Decouple syscon interface from platform devices

2014-09-18 Thread li.xi...@freescale.com
[...] > >create child: /dcsr@2000/dcsr-atbrepl@3a8000 > >create child: /dcsr@2000/dcsr-tsgen-ctrl@3a9000 > >create child: /dcsr@2000/dcsr-tsgen-read@3aa000 > >create child: /regulators/regulator@0 > >... > > > > As default the Linux will create all the platform devic

RE: [PATCH v3] mfd: syscon: Decouple syscon interface from platform devices

2014-09-18 Thread li.xi...@freescale.com
> > Thanks for testing. In that case I will post this change, as I feel this > > should be > > fixed irrespective of my syscon patch. > > > > > But as Xiubo pointed in another mail, it may still cause other issues. > > > Looking at regmap.c, there're still some other places using the device > > poi

RE: [PATCH v3] mfd: syscon: Decouple syscon interface from platform devices

2014-09-18 Thread li.xi...@freescale.com
[...] > > I think there should have been a check for NULL on "dev" in > > "regmap_get_val_endian", so that if dev pointer exist then only it makes > > sense to get > > endianness property from DT. > > > > I will suggest following fix in regmap.c for this. With following fix I > > tested it and it w

RE: [PATCH v3] mfd: syscon: Decouple syscon interface from platform devices

2014-09-18 Thread li.xi...@freescale.com
Hi, [...] > > please see regmap_get_val_endian called in regmap_init function. > > static enum regmap_endian regmap_get_val_endian(struct device *dev, > > const struct regmap_bus *bus, > > const struct regmap_config >

RE: [PATCH v3] mfd: syscon: Decouple syscon interface from platform devices

2014-09-17 Thread li.xi...@freescale.com
Hi Pankaj, One more question: For example: regmap_read() > _regmap_read() > 2112 #ifdef LOG_DEVICE > 2113 if (strcmp(dev_name(map->dev), LOG_DEVICE) == 0) > 2114 dev_info(map->dev, "%x => %x\n", reg, *val);

RE: [PATCH] fbdev: fsl-sii902x: HDMI support for Freescale SoCs

2014-09-14 Thread li.xi...@freescale.com
Hi Tomi, Thanks very much for your comments. > Subject: Re: [PATCH] fbdev: fsl-sii902x: HDMI support for Freescale SoCs > > Hi, > > On 05/09/14 07:48, Xiubo Li wrote: > > Some Freescale SoCs, there has an DVI/HDMI controller and a PHY, > > attached to one of their display controller unit's LCD

RE: [PATCH] clocksource: Add BE/LE APIs support for clocksource counter reading.

2014-09-10 Thread li.xi...@freescale.com
> Cc: daniel.lezc...@linaro.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] clocksource: Add BE/LE APIs support for clocksource > counter reading. > > On Wed, 10 Sep 2014, Xiubo Li wrote: > > So you add BE/LE APIs according to the subject line, but you fail > again to tell WHY. If that w

RE: [PATCHv3 3/3] ASoC: simple-card: binding: update binding to support the new style.

2014-09-09 Thread li.xi...@freescale.com
Hi, > Subject: Re: [PATCHv3 3/3] ASoC: simple-card: binding: update binding to > support the new style. > > On 09/09/2014 03:09 PM, Mark Brown wrote: > > On Wed, Sep 03, 2014 at 10:23:41AM +0800, Xiubo Li wrote: > >> This update patch will split the DT node into old style and new style: > >> The

RE: [PATCHv3 2/3] ASoC: simple-card: Adjust the comments of simple card.

2014-09-09 Thread li.xi...@freescale.com
> Subject: Re: [PATCHv3 2/3] ASoC: simple-card: Adjust the comments of simple > card. > > On Wed, Sep 03, 2014 at 10:23:40AM +0800, Xiubo Li wrote: > > Signed-off-by: Xiubo Li > > This doesn't apply against current code. I will send one new version about this. Thanks, BRs Xiubo -- To unsubscri

RE: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-09 Thread li.xi...@freescale.com
Hi, > Subject: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module > > Move the ipg clock enable and disable operation to startup and shutdown, > that is only enable ipg clock when ssi is working. we don't need to enable > ipg clock in probe. > Another register accessing need the ipg

RE: [PATCHv2 1/4] Clocksource: Flextimer: Use internal clocksource read API.

2014-09-08 Thread li.xi...@freescale.com
Hi Thomas, Okay. I will try to fix this. Thanks, BRs Xiubo > -Original Message- > From: Thomas Gleixner [mailto:t...@linutronix.de] > Sent: Friday, September 05, 2014 11:40 PM > To: Xiubo Li-B47053 > Cc: daniel.lezc...@linaro.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCHv2

RE: [PATCHv2] watchdog: imx2_wdt: Convert to use regmap framework's endianness method.

2014-09-08 Thread li.xi...@freescale.com
vger.kernel.org; > linux- > ker...@vger.kernel.org; devicet...@vger.kernel.org > Subject: Re: [PATCHv2] watchdog: imx2_wdt: Convert to use regmap framework's > endianness method. > > On Fri, Sep 05, 2014 at 07:11:31AM +, li.xi...@freescale.com wrote: > > Hi, > &

RE: [PATCHv2] watchdog: imx2_wdt: Convert to use regmap framework's endianness method.

2014-09-05 Thread li.xi...@freescale.com
Hi, Ping :) Thanks, BRs Xiubo > -Original Message- > From: Xiubo Li [mailto:li.xi...@freescale.com] > Sent: Monday, August 25, 2014 3:55 PM > To: w...@iguana.be; li...@roeck-us.net; m...@pengutronix.de; linux- > watch...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org; devicet...@vg

RE: [PATCH 2/5] Clocksource: Flextimer: Use internal clocksource read API.

2014-09-04 Thread li.xi...@freescale.com
Hi Thomas, > Subject: RE: [PATCH 2/5] Clocksource: Flextimer: Use internal clocksource read > API. > > Hi Thomas, > > > > > > Since the FTM will be in BE mode on LS1 platform, but will be in LE > mode > > > > > On LS2 platform. > > > > > > > > > > And ftm_clocksource_read_up() will adapt to this

RE: [PATCH 2/5] Clocksource: Flextimer: Use internal clocksource read API.

2014-09-04 Thread li.xi...@freescale.com
Hi Thomas, > > > > Since the FTM will be in BE mode on LS1 platform, but will be in LE mode > > > > On LS2 platform. > > > > > > > > And ftm_clocksource_read_up() will adapt to this different. > > > > > > You are missing the point. Why do you want a conditional in a hot > > > path? You know at ini

RE: [PATCH 2/5] Clocksource: Flextimer: Use internal clocksource read API.

2014-09-04 Thread li.xi...@freescale.com
> > > > Since the FTM will be in BE mode on LS1 platform, but will be in LE mode > > On LS2 platform. > > > > And ftm_clocksource_read_up() will adapt to this different. > > You are missing the point. Why do you want a conditional in a hot > path? You know at init time whether the thing is BE or L

RE: [PATCH 4/5] Clocksource: Flextimer: Fix counter clock prescaler calculation.

2014-09-03 Thread li.xi...@freescale.com
> Subject: Re: [PATCH 4/5] Clocksource: Flextimer: Fix counter clock prescaler > calculation. > > On Tue, 26 Aug 2014, Xiubo Li wrote: > > > We should minus one after calculating the counter input clock's > > prescaler. > > > > Signed-off-by: Xiubo Li > > Signed-off-by: Jingchang Lu > > --- > >

RE: [PATCH 5/5] Clocksource: Flextimer: Use Macro for clock source selection.

2014-09-03 Thread li.xi...@freescale.com
> Subject: Re: [PATCH 5/5] Clocksource: Flextimer: Use Macro for clock source > selection. > > On Tue, 26 Aug 2014, Xiubo Li wrote: > > FTM source clock is selectable: > > Source clock can be the system clock, the fixed frequency clock, > > or an external clock. > > Fixed frequency clock is an ad

RE: [PATCH 4/5] Clocksource: Flextimer: Fix counter clock prescaler calculation.

2014-09-03 Thread li.xi...@freescale.com
Hi Thomas, Thanks very much for your comments. Firstly I must tell the true that English is not my mother language. > Subject: Re: [PATCH 4/5] Clocksource: Flextimer: Fix counter clock prescaler > calculation. > > On Tue, 26 Aug 2014, Xiubo Li wrote: > > > We should minus one after calculatin

RE: [PATCH 2/5] Clocksource: Flextimer: Use internal clocksource read API.

2014-09-03 Thread li.xi...@freescale.com
> Subject: Re: [PATCH 2/5] Clocksource: Flextimer: Use internal clocksource read > API. > > On Tue, 26 Aug 2014, Xiubo Li wrote: > > > Since the Flextimer device will be implemented in BE mode on > > LS1 SoC, and in LE mode on Vybrid, LS2 SoCs, so here we need > > the endianness judgment before d

RE: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-03 Thread li.xi...@freescale.com
> Subject: Re: [PATCHv2 1/4] ASoC: simple-card: add > asoc_simple_card_fmt_master() > to simplify the code. > > On 09/03/2014 05:37 AM, li.xi...@freescale.com wrote: > >> Subject: Re: [PATCHv2 1/4] ASoC: simple-card: add > asoc_simple_card_fmt_master() > ... > &

RE: [alsa-devel] [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-02 Thread li.xi...@freescale.com
> Subject: Re: [alsa-devel] [PATCHv2 1/4] ASoC: simple-card: add > asoc_simple_card_fmt_master() to simplify the code. > > > Hi Xiubo > > > Yes your patch has fixed the bug Jyri has pointed out. > > > > So I has discard my [PATCHv2 1/4] patch. > > > > Please send your patch out to replace this o

RE: [PATCH 0/5] Clocksource: Flextimer: Merged to LS1

2014-09-02 Thread li.xi...@freescale.com
Ping :) Thanks, BRs Xiubo > -Original Message- > From: Xiubo Li [mailto:li.xi...@freescale.com] > Sent: Tuesday, August 26, 2014 1:46 PM > To: daniel.lezc...@linaro.org; t...@linutronix.de > Cc: Wang Dongsheng-B40534; linux-kernel@vger.kernel.org; Xiubo Li-B47053 > Subject: [PATCH 0/5

RE: [alsa-devel] [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-02 Thread li.xi...@freescale.com
> Subject: Re: [alsa-devel] [PATCHv2 1/4] ASoC: simple-card: add > asoc_simple_card_fmt_master() to simplify the code. > > > Hi Xiubo > > > Yes, I think it make sense to set all fmt in one function, and will > > Be more readable. > > > > I agree with you, could you please just wait, because ther

RE: [alsa-devel] [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-02 Thread li.xi...@freescale.com
Hi Kuninori-san, Yes your patch has fixed the bug Jyri has pointed out. So I has discard my [PATCHv2 1/4] patch. Please send your patch out to replace this one. Thanks, BRs Xiubo > -Original Message- > From: Xiubo Li-B47053 > Sent: Wednesday, September 03, 2014 10:22 AM > To: 'Kunin

RE: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-02 Thread li.xi...@freescale.com
> Subject: Re: [PATCHv2 1/4] ASoC: simple-card: add > asoc_simple_card_fmt_master() > to simplify the code. > > On 09/02/2014 12:26 PM, Xiubo Li wrote: > > Signed-off-by: Xiubo Li > > --- > > sound/soc/generic/simple-card.c | 61 - > > > 1 file changed

RE: [alsa-devel] [PATCHv2 3/4] ASoC: simple-card: Adjust the comments of simple card.

2014-09-02 Thread li.xi...@freescale.com
> Subject: Re: [alsa-devel] [PATCHv2 3/4] ASoC: simple-card: Adjust the comments > of simple card. > > > Hi Xiubo > > > > > /* > > > > -* soc_bind_dai_link() will check cpu name > > > > -* after of_node matching if dai_link has cpu_dai_name. > > > > -* but, it wil

RE: [alsa-devel] [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-02 Thread li.xi...@freescale.com
Hi Kuninori-san, Yes, I think it make sense to set all fmt in one function, and will Be more readable. I agree with you, could you please just wait, because there has many Replications and good Ideas about this patch, and I will revise it. Then you can improve it as your patch blow. Thanks, BR

RE: [PATCHv2 3/4] ASoC: simple-card: Adjust the comments of simple card.

2014-09-02 Thread li.xi...@freescale.com
> Subject: Re: [PATCHv2 3/4] ASoC: simple-card: Adjust the comments of simple > card. > > On Tue, 2 Sep 2014 17:26:08 +0800 > Xiubo Li wrote: > > > @@ -285,11 +287,11 @@ static int asoc_simple_card_dai_link_of(struct > device_node *node, > > dai_props->codec_dai.sysclk); > > > >

RE: [PATCHv2 4/4] ASoC: simple-card: binding: update binding to support the new style.

2014-09-02 Thread li.xi...@freescale.com
> Subject: Re: [PATCHv2 4/4] ASoC: simple-card: binding: update binding to > support the new style. > > On Tue, 2 Sep 2014 17:26:09 +0800 > Xiubo Li wrote: > > > +Example 4 - many DAI links: > > sound { > > compatible = "simple-audio-card"; > > simple-audio-card,name = "Cubox Audio"; >

RE: [alsa-devel] [PATCHv1 1/7] ASoC: simple-card: Merge single and muti DAI link code.

2014-09-02 Thread li.xi...@freescale.com
Hi Kuninori-san This patch series will break the old DTs, and I will follow Mark's Advice to maintain compatibility with the old DTs. I will send another version, please help me to review it. And I will also split the update patch series to many small ones. Thanks very much, BRs Xiubo > -O

RE: [PATCHv1 4/7] ASoC: dts: kirkwood-t5325: To support simple card newest style.

2014-09-02 Thread li.xi...@freescale.com
Hi Andrew, Thanks very much for you comment and advice. I will resend this patch series to compatibility with the old DTs, and it will Up to the owners to update the DTs to support the new style of DTs. BRs Xiubo > -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent

RE: [RFC][PATCH] ASoC: simple-card: Merge single and muti DAI link code.

2014-09-02 Thread li.xi...@freescale.com
Hi Jyri, I'll follow Mark's advice of maintaining compatibility with the old DTs. Thanks very much for your comments, and this is very important for me. And I will also update the binding documet for simple card, please help me review it, any comment and advice are welcome. The goal is to simpl

RE: [PATCHv1 1/7] ASoC: simple-card: Merge single and muti DAI link code.

2014-09-01 Thread li.xi...@freescale.com
> > On Mon, Sep 01, 2014 at 03:34:12PM +0200, Andrew Lunn wrote: > > On Mon, Sep 01, 2014 at 12:29:35PM +0800, Xiubo Li wrote: > > > This patch merge single DAI link and muti-DAI links code together, > > > and simply the simple-card driver code. > > > It would be good to note that this breaks the

RE: [alsa-devel] [PATCHv1 1/7] ASoC: simple-card: Merge single and muti DAI link code.

2014-09-01 Thread li.xi...@freescale.com
> Hi Xiubo > > Thank you for your patch. > This clean-up is very nice for me. > But, I have 1 small comment > > > asoc_simple_card_sub_parse_of(struct device_node *np, > > struct asoc_simple_dai *dai, > > struct device_node **p_node, > > -

RE: [PATCHv2 2/2] ASoC: simple-card: Fix bug of wrong decrement DT node's refcount

2014-09-01 Thread li.xi...@freescale.com
> > DAI links's cpu_of_node's and codec_of_node's refcounts shouldn't > > be decremented immediately at the end of the probe() fucntion. > > Because we will still use them before the audio card is removed. > > Right, but your patch seems a bit complicated. See below. > > > > > Signed-off-by: Xiub

RE: [PATCHv2 1/2] ASoC: simple-card: Fix bug of forgetting decrement DT node's refcount

2014-08-31 Thread li.xi...@freescale.com
> > Signed-off-by: Xiubo Li > > --- > > sound/soc/generic/simple-card.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/sound/soc/generic/simple-card.c b/sound/soc/generic/simple- > card.c > > index fd8b045..9e170fe 100644 > > --- a/sound/soc/generic/simple-card.c > > +++ b/sound/

RE: [RFC][PATCH] ASoC: simple-card: Merge single and muti DAI link code.

2014-08-31 Thread li.xi...@freescale.com
> > --- > > > > Hi, > > > > This patch will break the old DT, so i just send one RFC version, and > > will add the old DT patches in next version if this patch can work > > well. > > > > Any comments and advices are welcome. > > Hi Xiubo, > > My DT is > > sound { > compatible

RE: [RFC][PATCH] ASoC: simple-card: Merge single and muti DAI link code.

2014-08-31 Thread li.xi...@freescale.com
Hi Mark, Kuninori-san, Very sorry, I just missed that patch series. See the next version. Thanks, BRs Xiubo > -Original Message- > From: Mark Brown [mailto:broo...@kernel.org] > Sent: Friday, August 29, 2014 8:01 PM > To: Xiubo Li-B47053 > Cc: alsa-de...@alsa-project.org; linux-kern

RE: [PATCH] ASoC: fsl-sai: using 'lsb-first' property instead of 'big-endian-data'.

2014-08-27 Thread li.xi...@freescale.com
> Subject: Re: [PATCH] ASoC: fsl-sai: using 'lsb-first' property instead of > 'big-endian-data'. > > On Tue, Aug 26, 2014 at 11:53:56PM -0700, Nicolin Chen wrote: > > > That's why I suggested previously: mention it in the commit comment. > > > People will have no idea about what's the exact reas

RE: [PATCH] ASoC: fsl-sai: using 'lsb-first' property instead of 'big-endian-data'.

2014-08-27 Thread li.xi...@freescale.com
> Subject: Re: [PATCH] ASoC: fsl-sai: using 'lsb-first' property instead of > 'big-endian-data'. > > On Tue, Aug 26, 2014 at 7:12 PM, li.xi...@freescale.com > wrote: > > > > This property used for configuring whether the LSB or the MSB i

RE: [PATCH] ASoC: fsl-sai: using 'lsb-first' property instead of 'big-endian-data'.

2014-08-26 Thread li.xi...@freescale.com
> -Original Message- > From: Mark Rutland [mailto:mark.rutl...@arm.com] > Sent: Tuesday, August 26, 2014 5:04 PM > To: Xiubo Li-B47053 > Cc: broo...@kernel.org; nicoleots...@gmail.com; ti...@tabi.org; > lgirdw...@gmail.com; pe...@perex.cz; ti...@suse.de; alsa-devel@alsa- > project.org;

RE: [PATCHv3] ASoC: fsl-sai: rename big_endian_data to is_lsb_first.

2014-08-25 Thread li.xi...@freescale.com
Hi all, Please ignore this patch. Have sent the wrong one. Thanks, BRs Xiubo > -Original Message- > From: Xiubo Li [mailto:li.xi...@freescale.com] > Sent: Monday, August 25, 2014 3:03 PM > To: broo...@kernel.org; nicoleots...@gmail.com; ti...@tabi.org; > lgirdw...@gmail.com; pe...@pe

RE: [PATCHv6 2/2] dt/bindings: Add the DT binding documentation for endianness

2014-08-20 Thread li.xi...@freescale.com
> Subject: Re: [PATCHv6 2/2] dt/bindings: Add the DT binding documentation for > endianness > > On Tue, Jul 15, 2014 at 12:23:03PM +0800, Xiubo Li wrote: > > Device-Tree binding for device endianness > > Index Device Endianness properties > > ---

RE: [alsa-devel] [PATCH V1 1/3] ASoC: fsl: Kconfig: remove dependence of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA

2014-08-19 Thread li.xi...@freescale.com
How about the following : diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig index 5ae777a..d42f18c 100644 --- a/sound/soc/fsl/Kconfig +++ b/sound/soc/fsl/Kconfig @@ -15,7 +15,7 @@ config SND_SOC_FSL_ASRC config SND_SOC_FSL_SAI tristate "Synchronous Audio Interface (SAI) module s

RE: [alsa-devel] [PATCH V1 1/3] ASoC: fsl: Kconfig: remove dependence of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA

2014-08-19 Thread li.xi...@freescale.com
> > > Lars-Peter Clausen & Arnd > > > > > > The purpose of Arnd's patch is same with me, which is to resolve the build > > > error when SND_SOC_IMX_PCM_DMA=m & SND_SOC_FSL_SSI/SAI/ESAI/SPDIF=y, the > > > error is "undefined reference to `imx_pcm_dma_init'". > > > But Arnd's patch didn't involve thi

RE: [alsa-devel] [PATCH V1 1/3] ASoC: fsl: Kconfig: remove dependence of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA

2014-08-19 Thread li.xi...@freescale.com
> Subject: Re: [alsa-devel] [PATCH V1 1/3] ASoC: fsl: Kconfig: remove dependence > of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA > > On Mon, Aug 18, 2014 at 06:52:46PM +0200, Lars-Peter Clausen wrote: > > On 08/18/2014 10:38 AM, Shengjiu Wang wrote: > > >Build kernel with SND_SOC_IMC_PCM_DMA=m && SND_IMX

RE: [PATCH] regmap: fix of_regmap_get_endian()

2014-08-18 Thread li.xi...@freescale.com
Hi, I found this patch has some confliction with the Mark's newest Remgap-Tree's origin/topic/dt-endian branch. Javier Martinez has already fix some of these. Thanks, BRs Xiubo > -Original Message- > From: Thierry Reding [mailto:thierry.red...@gmail.com] > Sent: Tuesday, August 19, 2

RE: [PATCHv2] i2c: i2c-imx: Fix format warning for dev_dbg

2014-08-05 Thread li.xi...@freescale.com
Hi Jingoo, Thanks for your advice. This patch is mainly resolving the warning issue. And some thing like : 'i2c: i2c-imx: Fix format warning for dev_db' Could be more obvious. I think adding 'printf extension %pR for struct resource' to the commit comment will better. BRs Xiubo > -Orig

RE: [PATCH] i2c: i2c-imx: Fix format warning for dev_dbg

2014-08-05 Thread li.xi...@freescale.com
> > drivers/i2c/busses/i2c-imx.c: In function i2c_imx_probe() > > drivers/i2c/busses/i2c-imx.c:689:2: warning: format 0x%x expects argument > > of type unsigned int, but argument 4 has type resource_size_t [-Wformat=] > > dev_dbg(&i2c_imx->adapter.dev, "device resources from 0x%x to 0x%x\n", > []

RE: [PATCHv6 0/2] add DT endianness binding support for regmap

2014-08-05 Thread li.xi...@freescale.com
Hi, I'd like to know the status about this patch series, there are many patches Based the Regmap still waiting for these. Thanks, BRs Xiubo > -Original Message- > From: Xiubo Li [mailto:li.xi...@freescale.com] > Sent: Tuesday, July 15, 2014 12:23 PM > To: broo...@kernel.org; mark.rutl..

RE: [PATCH 0/2] ASoC: fsl_sai: Two bug fixes for fsl_sai driver

2014-07-17 Thread li.xi...@freescale.com
> -Original Message- > From: Nicolin Chen [mailto:nicoleots...@gmail.com] > Sent: Thursday, July 17, 2014 9:22 PM > To: broo...@kernel.org > Cc: linux-kernel@vger.kernel.org; linuxppc-...@lists.ozlabs.org; alsa- > de...@alsa-project.org; ti...@tabi.org; Xiubo Li-B47053; Wang Shengjiu-B02247

RE: [PATCHv6 2/2] dt/bindings: Add the DT binding documentation for endianness

2014-07-14 Thread li.xi...@freescale.com
> > +For one device driver, which will run in different scenarios above > > +on different SoCs using the devicetree, we need one way to simplify > > +this. > > + > > +Required properties: > > +- {big,little}-endian: these are boolean properties, if absent > > + meaning that the CPU and the Device

RE: [PATCHv5 2/2] dt/bindings: Add the DT binding documentation for endianness

2014-07-14 Thread li.xi...@freescale.com
Hi, Please ignore this V5 patch series. Thanks, BRs > -Original Message- > From: Xiubo Li [mailto:li.xi...@freescale.com] > Sent: Tuesday, July 15, 2014 12:18 PM > To: broo...@kernel.org; mark.rutl...@arm.com > Cc: robh...@kernel.org; pawel.m...@arm.com; ijc+devicet...@hellion.org.uk

RE: [PATCH] clocksource: arch_arm_timer: Fix timecounter initialization

2014-06-12 Thread li.xi...@freescale.com
> > drivers/clocksource/arm_arch_timer.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/clocksource/arm_arch_timer.c > b/drivers/clocksource/arm_arch_timer.c > > index 5163ec1..6c3cfd8 100644 > > --- a/drivers/clocksource/arm_arch_timer.c > > +++ b/driv

RE: [PATCH] watchdog: imx2_wdt: adds big endianness support.

2014-06-02 Thread li.xi...@freescale.com
> > @@ -201,6 +204,10 @@ static int __init imx2_wdt_probe(struct platform_device > *pdev) > > if (!wdev) > > return -ENOMEM; > > > > + big_endian = of_property_read_bool(np, "big-endian"); > > + if (big_endian) > > + imx2_wdt_regmap_config.val_format_endian = REGMAP_EN

RE: [PATCHv5 0/2] imx2-wdt: Add regmap-mmio support

2014-05-26 Thread li.xi...@freescale.com
> > Xiubo Li (2): > > watchdog: imx2_wdt: Sort the header files alphabetically > > watchdog: imx2_wdt: convert to use regmap API. > > > > drivers/watchdog/Kconfig| 1 + > > drivers/watchdog/imx2_wdt.c | 62 +++--- > --- > > 2 files changed, 39 insertio

RE: linux-next: manual merge of the clockevents tree with the arm-soc tree

2014-05-25 Thread li.xi...@freescale.com
> Subject: linux-next: manual merge of the clockevents tree with the arm-soc > tree > > Hi Daniel, > > Today's linux-next merge of the clockevents tree got a conflict in > arch/arm/boot/dts/vf610.dtsi between commit 0517fe6aa880 ("ARM: dts: > vf610-twr: Add support for sdhc1") from the arm-soc tr

RE: [PATCH] regmap: irq: Fix possible ZERO_SIZE_PTR pointer dereferencing error.

2014-05-19 Thread li.xi...@freescale.com
> Subject: Re: [PATCH] regmap: irq: Fix possible ZERO_SIZE_PTR pointer > dereferencing error. > > On Mon, May 19, 2014 at 03:13:45PM +0800, Xiubo Li wrote: > > Since we cannot make sure the 'chip->num_regs' will always be none zero > > from the users, and then if 'chip->num_regs' equals to zero by

RE: [PATCHv3 0/3] clocksource: Add Freescale FlexTimer Module (FTM) timer support

2014-05-19 Thread li.xi...@freescale.com
> > Xiubo Li (3): > >clocksource: ftm: Add FlexTimer Module (FTM) Timer devicetree > > Documentation > >ARM: dts: vf610: Add Freescale FlexTimer Module timer node. > >clocksource: Add Freescale FlexTimer Module (FTM) timer support > > > > .../devicetree/bindings/timer/fsl,ftm-tim

RE: [PATCHv3 3/3] clocksource: Add Freescale FlexTimer Module (FTM) timer support

2014-05-19 Thread li.xi...@freescale.com
> >>> +static inline u32 ftm_readl(void __iomem *addr) > >>> +{ > >>> + if (big_endian) > >> > >> I am not a big fan of addressing global variables in the functions, so > >> if you can pass the structure pointer around here and the other > >> functions instead that would be nice. > >> > >> Otherwis

RE: [PATCHv2 1/2] clocksource: fix type confusion for clocksource_mmio_readX_Y

2014-05-19 Thread li.xi...@freescale.com
> Subject: Re: [PATCHv2 1/2] clocksource: fix type confusion for > clocksource_mmio_readX_Y > > On 05/19/2014 04:35 AM, li.xi...@freescale.com wrote: > > Hi, > > > > I'd like to know the status about this patch series... > > :) > > I think the p

RE: [PATCHv4 2/2] regmap: add DT endianness binding support.

2014-05-18 Thread li.xi...@freescale.com
> Subject: Re: [PATCHv4 2/2] regmap: add DT endianness binding support. > > On Fri, May 09, 2014 at 03:04:33AM +0100, Xiubo Li wrote: > > For many drivers which will support rich endianness of CPU<-->Dev > > need define DT properties by itself without the binding support. > > > > The endianness us

RE: [PATCH v3] arm: ioremap: Fix static vm area boundary check.

2014-05-18 Thread li.xi...@freescale.com
> > For each vmalloc area, there is one guard page at the end of it. > > so the vm->size = PAGE_ALIGN(offset + request size) + guard page size. > > Nope. There is no guard page for statically created vmalloc areas. > Yes, you are right, I'm thinking why the static area has no guard page? Thank

RE: [PATCHv2 1/2] clocksource: fix type confusion for clocksource_mmio_readX_Y

2014-05-18 Thread li.xi...@freescale.com
Hi, I'd like to know the status about this patch series... :) Thanks, BRs Xiubo > -Original Message- > From: Xiubo Li [mailto:li.xi...@freescale.com] > Sent: Wednesday, April 23, 2014 10:12 AM > To: daniel.lezc...@linaro.org; t...@linutronix.de; linux- > ker...@vger.kernel.org > Cc: Xi

RE: [PATCHv3 3/3] clocksource: Add Freescale FlexTimer Module (FTM) timer support

2014-05-18 Thread li.xi...@freescale.com
> > +#define FTM_CNTIN 0x4C > > + > > +static void __iomem *clksrc_base; > > +static void __iomem *clkevt_base; > > +static unsigned long peroidic_cyc; > > +static unsigned long ps; > > +bool big_endian; > > + > > Usually this is encaspulated in a structure. > > struct ftm_clock_device { >

RE: [PATCHv3 3/3] clocksource: Add Freescale FlexTimer Module (FTM) timer support

2014-05-18 Thread li.xi...@freescale.com
> Subject: Re: [PATCHv3 3/3] clocksource: Add Freescale FlexTimer Module (FTM) > timer support > > On 04/28/14 19:18, Xiubo Li wrote: > > +bool big_endian; > > + > > static? > I will fix this. Thanks, BRs Xiubo > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > host

RE: [PATCHv3 3/3] clocksource: Add Freescale FlexTimer Module (FTM) timer support

2014-05-18 Thread li.xi...@freescale.com
> > +static void __iomem *clksrc_base; > > +static void __iomem *clkevt_base; > > +static unsigned long peroidic_cyc; > > peroidic_cyc ? Did you mean periodic_cyc ? :) > Yes, I'll fix it. Thanks, BRs Xiubo > > > -- > Linaro.org │ Open source software for ARM SoCs

RE: [PATCHv2] ARM: ioremap: Fix static vm area boundary checking.

2014-05-16 Thread li.xi...@freescale.com
> Subject: Re: [PATCHv2] ARM: ioremap: Fix static vm area boundary checking. > > On Fri, May 16, 2014 at 1:28 AM, Nicolas Pitre > wrote: > > On Thu, 15 May 2014, Richard Lee wrote: > > > >> Static vm area boundary check: > >> > >> paddr1 --->| | > >> | | > >>

RE: [PATCH] ARM: ioremap: Fix static vm area boundary checking.

2014-05-15 Thread li.xi...@freescale.com
> Subject: [PATCH] ARM: ioremap: Fix static vm area boundary checking. > > Static vm area boundary check: > > paddr1 --->| | > | | > |---| <-\--- svm->vm->addr(is page aligned) > paddr2 --->| || > | --| <

RE: [PATCHv2 0/4] FTM PWM adds regmap and endianness support.

2014-05-13 Thread li.xi...@freescale.com
Thierry, Ping:) > -Original Message- > From: Xiubo Li [mailto:li.xi...@freescale.com] > Sent: Tuesday, April 29, 2014 11:34 AM > To: thierry.red...@gmail.com; linux-...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org; Xiubo Li-B47053 > Subject: [PATCHv2 0/4] FTM PWM adds regmap and e

RE: [PATCH] ASoC: cq93vc: fix cq93vc_get_regmap build error

2014-04-30 Thread li.xi...@freescale.com
> Subject: [PATCH] ASoC: cq93vc: fix cq93vc_get_regmap build error > > 49101a25acd69c "ASoC: cq93vc: Remove the set_cache_io() entirely from > ASoC probe" introduced the cq93vc_get_regmap function that has an > obvious build error referring to the 'codec' variable that is not > declared anywhere"

  1   2   3   >