[PATCH 1/1] leds: LED Bitpattern Trigger

2007-06-08 Thread kogiidena
s repeated forever. # echo 1010R > /sys/class/leds/LED/bitdata In addition, string of "on", "off", and "blink" can be set to "bitdata". The transition time of "bitdata" is set by "delay". Signed-off-by: kogiidena <[EMAIL PROTECTED

Re: [PATCH 1/2] leds:arch/sh/boards/landisk LEDs supports

2007-05-11 Thread kogiidena
To: Richard-san I'm sorry. The patch sent yesterday is corrected. Only the ledtrig_bitpat_default function was changed. The patch of "Custom triggers support, which are might not supported by all LEDs" is necessary. LED driver of I-O DATA LANDISK and USL-5P Signed-off-by: ko

Re: [PATCH 2/2] leds:arch/sh/boards/landisk LEDs supports

2007-05-11 Thread kogiidena
uot;, and "blink" can be set to "bitdata". The transition time of "bitdata" is set by "delay". Signed-off-by: kogiidena <[EMAIL PROTECTED]> --- diff -urpN OLD/drivers/leds/Kconfig NEW/drivers/leds/Kconfig --- OLD/drivers/leds/Kconfig

Re: [PATCH 1/2] leds:arch/sh/boards/landisk LEDs supports

2007-05-11 Thread kogiidena
nt. 3. > You may also want some sanity checking here, while PA_LED is only 8-bits, > your bitmask is not. To: Richard-san Please apply. LED driver of I-O DATA LANDISK and USL-5P Signed-off-by: kogiidena <[EMAIL PROTECTED]> --- diff -urpN OLD/drivers/leds/Kconfig NEW/drivers/leds

Re: [PATCH 2/2] leds:arch/sh/boards/landisk LEDs supports

2007-05-11 Thread kogiidena
he "bitdata". In addition, the character string of "on", "off", and "blink" can be set to "bitdata". The transition time of "bitdata" is set by "delay". Signed-off-by: kogiidena <[EMAIL PROTECTED]> --- diff -urpN OLD/driv

Re: [PATCH 1/2] leds:arch/sh/boards/landisk LEDs supports

2007-05-10 Thread kogiidena
> Following patch sitting for a long time in our handhelds.org tree. > > kogiidena, I'm almost sure you'll find it useful, just apply patch, > and implement .is_led_supported function for your trigger, which will > eliminate trigger sho

Re: [PATCH 2/2] leds:arch/sh/boards/landisk LEDs supports

2007-05-09 Thread kogiidena
_variable; > }; > > If you then: > > echo "timer" > /sys/class/leds/power/trigger > > your patch will use random data and possibly oops. Thank you for explaining. I understood the problem. However, a complete solution is not hit on. I think that it is the easies

Re: [PATCH 1/2] leds:arch/sh/boards/landisk LEDs supports

2007-05-09 Thread kogiidena
> On Wed, 2007-05-09 at 23:26 +0900, kogiidena wrote: >> Hi Richard-san >> The following three points were corrected. >> 1. >> > You can't do this since the trigger will appear for all LEDs and it only >> > applies to a single LED. There has been previ

Re: [PATCH 1/2] leds:arch/sh/boards/landisk LEDs supports

2007-05-09 Thread kogiidena
t; is solved. 2. > Broken error handling - you should check the return code of > led_trigger_register(). 3. > void functions don't return. it is fixed. I think that I want to reflect the correction of BLINK, when the policy is decided. Signed-off-by: kogiidena <[EMAIL PROTECT

Re: [PATCH 2/2] leds:arch/sh/boards/landisk LEDs supports

2007-05-09 Thread kogiidena
> On Wed, 2007-05-09 at 20:42 +0900, kogiidena wrote: >> >As far as I can tell, the existing timer trigger can do everything the >> >blink trigger can (and more besides). >> I want to blink LED in the initial state. > > Are you after to set that per LED or

[PATCH 2/3] rtc:rtc-rs5c313.c : rtc_time value are fixed.

2007-05-09 Thread kogiidena
The following patch is a patch that corrects an initial value of suruct rtc_ time. please apply. Signed-off-by: kogiidena <[EMAIL PROTECTED]> --- diff -urpN OLD/drivers/rtc/rtc-rs5c313.c NEW/drivers/rtc/rtc-rs5c313.c --- OLD/drivers/rtc/rtc-rs5c313.c 2007-05-08 19:42:05.0

[PATCH 3/3] rtc:rtc-rs5c313.c : add error handling toavoidhardware hangup.

2007-05-09 Thread kogiidena
It is a patch that adds error processing. Hanging up by an infinite loop is evaded. Please apply. Signed-off-by: kogiidena <[EMAIL PROTECTED]> --- diff -urpN OLD/drivers/rtc/rtc-rs5c313.c NEW/drivers/rtc/rtc-rs5c313.c --- OLD/drivers/rtc/rtc-rs5c313.c 2007-05-08 19:52:11.0

[PATCH 1/3] rtc:rtc-rs5c313.c : error and warning are fixed.

2007-05-09 Thread kogiidena
The following patch is a patch that corrects the compile error and warning. Please apply. Signed-off-by: kogiidena <[EMAIL PROTECTED]> --- diff -urpN OLD/drivers/rtc/Kconfig NEW/drivers/rtc/Kconfig --- OLD/drivers/rtc/Kconfig 2007-05-07 12:12:02.0 +0900 +++ NEW/drivers/rtc/K

Re: [PATCH 2/2] leds:arch/sh/boards/landisk LEDs supports

2007-05-09 Thread kogiidena
r solution. Can the change that sets an initial value to delay_on and delay_off be added? The matter of "Bitshift" is reserved until this case is solved. kogiidena --- diff -urpN OLD/include/linux/leds.h NEW/include/linux/leds.h --- OLD/include/linux/leds.h2007-05-07 12:12:15.

[PATCH 2/2] leds:arch/sh/boards/landisk LEDs supports

2007-05-08 Thread kogiidena
.6.21-rc4 Signed-off-by: kogiidena <[EMAIL PROTECTED]> --- diff -urpN OLD/drivers/leds/Kconfig NEW/drivers/leds/Kconfig --- OLD/drivers/leds/Kconfig2007-03-27 18:30:44.0 +0900 +++ NEW/drivers/leds/Kconfig2007-03-27 18:52:42.0 +0900 @@ -134,5 +134,14 @@ con

[PATCH 1/2] leds:arch/sh/boards/landisk LEDs supports

2007-05-08 Thread kogiidena
To:Richard-san CC:all LED driver of I-O DATA LANDISK and USL-5P Please apply following patch Signed-off-by: kogiidena <[EMAIL PROTECTED]> --- diff -urpN linux-2.6.21-rc4.orig/drivers/leds/Kconfig NEW/drivers/leds/Kconfig --- linux-2.6.21-rc4.orig/drivers/leds/Kconfig2007-03-16