On 2021-03-15 17:51, Daniel Thompson wrote:
On Sun, Mar 14, 2021 at 11:11:10AM +0100, Marijn Suijten wrote:
From: Obeida Shamoun
WLED3_SINK_REG_SYNC is, as the name implies, a sink register offset.
Therefore, use the sink address as base instead of the ctrl address.
This fixes the sync toggle
On 2021-03-01 15:32, Daniel Thompson wrote:
On Mon, Mar 01, 2021 at 02:58:36PM +0530, Kiran Gunda wrote:
As per the current implementation, after FSC (Full Scale Current)
and brightness update the sync bits are transitioned from
set-then-clear.
This does not makes sense since there are too ma
On 2021-02-26 22:56, Daniel Thompson wrote:
On Fri, Feb 26, 2021 at 05:42:24PM +0530, Kiran Gunda wrote:
As per the current implementation, after FSC (Full Scale Current)
and brightness update the sync bits are transitioned from 1 to 0.
This still seems to incorrectly describe the current beha
On 2021-02-24 16:56, Daniel Thompson wrote:
On Wed, Feb 24, 2021 at 09:20:48AM +0530, Kiran Gunda wrote:
Currently the FSC SYNC_BIT and MOD_SYNC_BIT are toggled
from 1 to 0 to update the FSC and brightenss settings.
Change this sequence form 0 to 1 as per the hardware team
recommendation to upda
On 2021-02-24 16:45, Daniel Thompson wrote:
On Wed, Feb 24, 2021 at 09:20:47AM +0530, Kiran Gunda wrote:
Currently, for WLED5, after FSC register update MOD_SYNC_BIT
is toggled instead of SYNC_BIT. MOD_SYNC_BIT has to be toggled
after the brightness update and SYNC_BIT has to be toggled after
FS
On 2021-02-19 23:38, Pavel Machek wrote:
Hi!
The FSC (Full scale current) setting is not updated properly due to
the
wrong register toggling for WLED5. Also the ILED_SYNC toggle and
MOD_SYNC
toggle sequence is updated as per the hardware team recommendation to
fix
the FSC update and brightne
On 2021-01-12 03:12, Rob Herring wrote:
On Wed, Dec 30, 2020 at 05:26:22PM +0530, Kiran Gunda wrote:
Convert the bindings from .txt to .yaml format.
Signed-off-by: Kiran Gunda
---
.../devicetree/bindings/mfd/qcom,spmi-pmic.txt | 80
--
.../devicetree/bindings/mfd/qcom,spmi-p
On 2020-12-20 05:17, Stephen Boyd wrote:
Quoting Kiran Gunda (2020-12-18 00:14:51)
Convert the bindings from .txt to .yaml format.
Signed-off-by: Kiran Gunda
---
.../devicetree/bindings/mfd/qcom,spmi-pmic.txt | 80
-
.../devicetree/bindings/mfd/qcom,spmi-pmic.yaml| 127
On 2020-12-21 14:20, Lee Jones wrote:
On Fri, 18 Dec 2020, Kiran Gunda wrote:
Convert the bindings from .txt to .yaml format.
Signed-off-by: Kiran Gunda
---
.../devicetree/bindings/mfd/qcom,spmi-pmic.txt | 80
-
.../devicetree/bindings/mfd/qcom,spmi-pmic.yaml| 127
On 2020-10-03 03:15, Stephen Boyd wrote:
Quoting kgu...@codeaurora.org (2020-02-06 21:57:49)
On 2020-02-07 00:36, Stephen Boyd wrote:
> Quoting Kiran Gunda (2020-02-06 05:55:26)
>> Convert the bindings from .txt to .yaml format.
>>
>> Signed-off-by: Kiran Gunda
>> ---
>
> Did something change?
On 2019-10-21 15:49, Daniel Thompson wrote:
On Fri, Oct 18, 2019 at 06:03:27PM +0530, Kiran Gunda wrote:
WLED4 peripheral is present on some PMICs like pmi8998 and
pm660l. It has a different register map and configurations
are also different. Add support for it.
Signed-off-by: Kiran Gunda
Revi
On 2019-10-16 13:45, Vinod Koul wrote:
On 04-10-19, 16:50, Kiran Gunda wrote:
Add support for the PM6150 and PM6150L GPIO support to the
Qualcomm PMIC GPIO binding.
Signed-off-by: Kiran Gunda
---
Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 4
drivers/pinctrl/qcom/pinct
On 2019-08-23 11:35, kgu...@codeaurora.org wrote:
On 2019-08-22 00:12, Vinod Koul wrote:
Add the regulators found in the mtp platform. This platform consists
of
pmic PM8150, PM8150L and PM8009.
Signed-off-by: Vinod Koul
Reviewed-by: Niklas Cassel
---
arch/arm64/boot/dts/qcom/sm8150-mtp.dts
On 2019-08-22 00:12, Vinod Koul wrote:
Add the regulators found in the mtp platform. This platform consists of
pmic PM8150, PM8150L and PM8009.
Signed-off-by: Vinod Koul
Reviewed-by: Niklas Cassel
---
arch/arm64/boot/dts/qcom/sm8150-mtp.dts | 324
1 file changed, 324
On 2018-06-20 11:17, Vinod wrote:
On 19-06-18, 16:43, Kiran Gunda wrote:
struct wled {
const char *name;
struct device *dev;
struct regmap *regmap;
+ struct mutex lock; /* Lock to avoid race from ISR */
the comment is wrong as you avoid race with thread han
On 2018-05-17 18:01, Rob Herring wrote:
On Thu, May 17, 2018 at 4:47 AM, wrote:
On 2018-05-08 15:55, kgu...@codeaurora.org wrote:
On 2018-05-07 21:50, Bjorn Andersson wrote:
On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote:
WLED4 peripheral is present on some PMICs like pmi8998
and pm660l
On 2018-05-08 15:55, kgu...@codeaurora.org wrote:
On 2018-05-07 21:50, Bjorn Andersson wrote:
On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote:
WLED4 peripheral is present on some PMICs like pmi8998
and pm660l. It has a different register map and also
configurations are different. Add support f
On 2018-05-14 22:27, Pavel Machek wrote:
Hi!
WLED4 peripheral is present on some PMICs like pmi8998
and pm660l. It has a different register map and also
configurations are different. Add support for it.
Signed-off-by: Kiran Gunda
---
.../bindings/leds/backlight/qcom-wled.txt | 172 +
On 2018-05-14 22:32, Bjorn Andersson wrote:
On Wed 09 May 00:14 PDT 2018, kgu...@codeaurora.org wrote:
On 2018-05-07 23:40, Bjorn Andersson wrote:
> On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote:
>
> [..]
> > +
> > +#define WLED_AUTO_DETECT_OVP_COUNT 5
> > +#define WLED_AUTO_DETECT_
On 2018-05-07 23:40, Bjorn Andersson wrote:
On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote:
[..]
+
+#define WLED_AUTO_DETECT_OVP_COUNT 5
+#define WLED_AUTO_DETECT_CNT_DLY_USHZ /* 1 second */
+static bool wled_auto_detection_required(struct wled *wled)
So cfg.auto_dete
On 2018-05-09 10:36, kgu...@codeaurora.org wrote:
On 2018-05-08 22:49, Bjorn Andersson wrote:
On Tue 08 May 05:26 PDT 2018, kgu...@codeaurora.org wrote:
On 2018-05-07 22:51, Bjorn Andersson wrote:
> On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote:
[..]
> > @@ -220,7 +255,12 @@ static int wle
On 2018-05-08 16:05, Daniel Thompson wrote:
On Thu, May 03, 2018 at 03:42:30PM +0530, Kiran Gunda wrote:
Handle the short circuit interrupt and check if the short circuit
interrupt is valid. Re-enable the module to check if it goes
away. Disable the module altogether if the short circuit event
p
On 2018-05-08 16:09, Daniel Thompson wrote:
On Thu, May 03, 2018 at 03:42:31PM +0530, Kiran Gunda wrote:
WLED peripheral has over voltage protection(OVP) circuitry and the OVP
fault is notified through an interrupt. Though this fault condition
rising
is due to an incorrect hardware configuratio
On 2018-05-08 22:47, Bjorn Andersson wrote:
On Tue 08 May 03:25 PDT 2018, kgu...@codeaurora.org wrote:
On 2018-05-07 21:50, Bjorn Andersson wrote:
> On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote:
[..]
> > +- qcom,ovp
> > + Usage:optional
> > + Value type:
> > + Defini
On 2018-05-08 22:49, Bjorn Andersson wrote:
On Tue 08 May 05:26 PDT 2018, kgu...@codeaurora.org wrote:
On 2018-05-07 22:51, Bjorn Andersson wrote:
> On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote:
[..]
> > @@ -220,7 +255,12 @@ static int wled_module_enable(struct wled
> > *wled, int val)
> >
On 2018-05-07 22:51, Bjorn Andersson wrote:
On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote:
WLED peripheral has over voltage protection(OVP) circuitry and the OVP
fault is notified through an interrupt. Though this fault condition
rising
is due to an incorrect hardware configuration is mitiga
On 2018-05-07 22:36, Bjorn Andersson wrote:
On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote:
Handle the short circuit interrupt and check if the short circuit
interrupt is valid. Re-enable the module to check if it goes
away. Disable the module altogether if the short circuit event
persists.
S
On 2018-05-07 22:10, Rob Herring wrote:
On Thu, May 03, 2018 at 03:42:28PM +0530, Kiran Gunda wrote:
pm8941-wled.c driver is supporting the WLED peripheral
on pm8941. Rename it to qcom-wled.c so that it can support
WLED on multiple PMICs.
Signed-off-by: Kiran Gunda
---
.../bindings/leds/backl
On 2018-05-07 21:50, Bjorn Andersson wrote:
On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote:
WLED4 peripheral is present on some PMICs like pmi8998
and pm660l. It has a different register map and also
configurations are different. Add support for it.
Several things are going on in this patch
On 2018-05-07 22:15, Rob Herring wrote:
On Thu, May 03, 2018 at 03:42:29PM +0530, Kiran Gunda wrote:
WLED4 peripheral is present on some PMICs like pmi8998
and pm660l. It has a different register map and also
configurations are different. Add support for it.
Signed-off-by: Kiran Gunda
---
...
On 2018-05-08 14:06, Daniel Thompson wrote:
On Mon, May 07, 2018 at 11:26:59AM +0530, kgu...@codeaurora.org wrote:
Hi Jingoo Han,
Thanks for the response.
Thanks,
Kiran
On 2018-05-04 21:25, Jingoo Han wrote:
> On Thursday, May 3, 2018 6:12 AM, Kiran Gunda wrote:
>
> If you really want someone t
On 2018-05-07 13:36, Dan Carpenter wrote:
Hi Kiran,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on backlight/for-backlight-next]
[also build test WARNING on v4.17-rc3 next-20180504]
[if your patch is applied to the wrong git tree, please drop us a note
to hel
Hi Jingoo Han,
Thanks for the response.
Thanks,
Kiran
On 2018-05-04 21:25, Jingoo Han wrote:
On Thursday, May 3, 2018 6:12 AM, Kiran Gunda wrote:
If you really want someone to review your patch, please add more
detailed
explanations.
1. Please add 0th patch.
I have already added the 0th patc
On 2018-04-20 21:33, Bjorn Andersson wrote:
On Thu 19 Apr 22:43 PDT 2018, kgu...@codeaurora.org wrote:
On 2018-04-19 21:28, Bjorn Andersson wrote:
> On Thu 19 Apr 03:45 PDT 2018, kgu...@codeaurora.org wrote:
> > On 2017-12-05 11:10, Bjorn Andersson wrote:
[..]
> > > When is this feature neede
On 2018-04-20 11:13, kgu...@codeaurora.org wrote:
On 2018-04-19 21:28, Bjorn Andersson wrote:
On Thu 19 Apr 03:45 PDT 2018, kgu...@codeaurora.org wrote:
On 2017-12-05 11:10, Bjorn Andersson wrote:
> On Thu 16 Nov 04:18 PST 2017, Kiran Gunda wrote:
>
> > The auto-calibration algorithm checks i
On 2018-04-19 21:28, Bjorn Andersson wrote:
On Thu 19 Apr 03:45 PDT 2018, kgu...@codeaurora.org wrote:
On 2017-12-05 11:10, Bjorn Andersson wrote:
> On Thu 16 Nov 04:18 PST 2017, Kiran Gunda wrote:
>
> > The auto-calibration algorithm checks if the current WLED sink
> > configuration is valid.
On 2017-12-05 11:10, Bjorn Andersson wrote:
On Thu 16 Nov 04:18 PST 2017, Kiran Gunda wrote:
The auto-calibration algorithm checks if the current WLED sink
configuration is valid. It tries enabling every sink and checks
if the OVP fault is observed. Based on this information it
detects and ena
On 2017-12-05 10:15, Bjorn Andersson wrote:
On Thu 16 Nov 04:18 PST 2017, Kiran Gunda wrote:
WLED peripheral has over voltage protection(OVP) circuitry and the OVP
fault is notified through an interrupt. Though this fault condition
rising
is due to an incorrect hardware configuration is mitiga
On 2017-12-05 10:05, Bjorn Andersson wrote:
On Thu 16 Nov 04:18 PST 2017, Kiran Gunda wrote:
Handle the short circuit(SC) interrupt and check if the SC interrupt
is valid. Re-enable the module to check if it goes away. Disable the
module altogether if the SC event persists.
Signed-off-by: Kira
On 2017-12-05 07:31, Bjorn Andersson wrote:
On Thu 16 Nov 04:18 PST 2017, Kiran Gunda wrote:
WLED driver provides the interface to the display driver to
adjust the brightness of the display backlight.
Signed-off-by: Kiran Gunda
---
.../bindings/leds/backlight/qcom-spmi-wled.txt | 90 +++
On 2017-11-18 02:00, Rob Herring wrote:
On Thu, Nov 16, 2017 at 05:48:35PM +0530, Kiran Gunda wrote:
Handle the short circuit(SC) interrupt and check if the SC interrupt
is valid. Re-enable the module to check if it goes away. Disable the
module altogether if the SC event persists.
Signed-off-b
On 2017-11-17 14:03, Lee Jones wrote:
On Thu, 16 Nov 2017, Bjorn Andersson wrote:
On Thu 16 Nov 22:36 PST 2017, kgu...@codeaurora.org wrote:
> On 2017-11-16 22:25, Bjorn Andersson wrote:
> > On Thu 16 Nov 04:18 PST 2017, Kiran Gunda wrote:
> >
> > > WLED driver provides the interface to the di
On 2017-11-17 12:26, Bjorn Andersson wrote:
On Thu 16 Nov 22:36 PST 2017, kgu...@codeaurora.org wrote:
On 2017-11-16 22:25, Bjorn Andersson wrote:
> On Thu 16 Nov 04:18 PST 2017, Kiran Gunda wrote:
>
> > WLED driver provides the interface to the display driver to
> > adjust the brightness of th
On 2017-11-16 22:25, Bjorn Andersson wrote:
On Thu 16 Nov 04:18 PST 2017, Kiran Gunda wrote:
WLED driver provides the interface to the display driver to
adjust the brightness of the display backlight.
Hi Kiran,
This driver has a lot in common with the already upstream
pm8941-wled.c,
becau
On 2017-08-26 04:49, Stephen Boyd wrote:
On 08/25, Zhang Rui wrote:
On Thu, 2017-08-17 at 13:12 +0530, kgu...@codeaurora.org wrote:
> On 2017-08-16 17:53, kgu...@codeaurora.org wrote:
> >
> > On 2017-08-08 13:42, Zhang Rui wrote:
> > >
> > > On Thu, 2017-07-13 at 17:39 +0530, Kiran Gunda wrote:
On 2017-08-23 02:01, Stephen Boyd wrote:
On 08/22, Shawn Guo wrote:
On Mon, Aug 21, 2017 at 04:18:58PM -0700, Stephen Boyd wrote:
> On 08/18/2017 08:28 AM, Kiran Gunda wrote:
> > The peripheral ownership check is not necessary on single master
> > platforms. Hence, enforce the peripheral ownersh
On 2017-08-18 16:43, kgu...@codeaurora.org wrote:
On 2017-08-17 17:58, Shawn Guo wrote:
On Thu, Aug 17, 2017 at 03:38:30PM +0530, kgu...@codeaurora.org wrote:
The intention of this check is to avoid the access to the
peripherals those are
not owned by the current EE (APSS) and it is expected to
On 2017-08-17 17:58, Shawn Guo wrote:
On Thu, Aug 17, 2017 at 03:38:30PM +0530, kgu...@codeaurora.org wrote:
The intention of this check is to avoid the access to the
peripherals those are
not owned by the current EE (APSS) and it is expected to return a
failure if the
peripheral that is not own
On 2017-08-17 13:11, Shawn Guo wrote:
Hi Kiran,
On Fri, Jul 28, 2017 at 12:40:46PM +0530, Kiran Gunda wrote:
From: David Collins
Add support for version 5 of the SPMI PMIC arbiter. It utilizes
different offsets for registers than those found on version 3.
Also, the procedure to determine if
On 2017-08-16 17:53, kgu...@codeaurora.org wrote:
On 2017-08-08 13:42, Zhang Rui wrote:
On Thu, 2017-07-13 at 17:39 +0530, Kiran Gunda wrote:
From: David Collins
Add support for the TEMP_ALARM GEN2 PMIC peripheral subtype. The
GEN2 subtype defines an over temperature state with hysteresis
in
On 2017-08-08 13:42, Zhang Rui wrote:
On Thu, 2017-07-13 at 17:39 +0530, Kiran Gunda wrote:
From: David Collins
Add support for the TEMP_ALARM GEN2 PMIC peripheral subtype. The
GEN2 subtype defines an over temperature state with hysteresis
instead of stage in the status register. There are t
On 2017-07-28 12:40, Kiran Gunda wrote:
v2:
* [PATCH V2 04/12] spmi: pmic-arb: optimize qpnpint_irq_set_type
function
Added Stephen's Reviewed-by tag.
* [PATCH V2 05/12] spmi: pmic-arb: fix memory allocation for
mapping_table
Added Fixes tag and Stephen's Reviewed-by tag.
* [PATCH V2 0
On 2017-07-28 05:30, Stephen Boyd wrote:
On 07/20, Kiran Gunda wrote:
This patch cleans up the following.
- Rename the "pa" to "pmic_arb".
- Rename the spmi_pmic_arb *dev to spmi_pmic_arb *pmic_arb.
- Rename the pa_{read,write}_data() functions to
pmic_arb_{read,write}_data().
- Rename channe
On 2017-07-28 05:31, Stephen Boyd wrote:
On 07/20, Kiran Gunda wrote:
Replace the writel_relaxed with __raw_writel to avoid byte swapping
in pmic_arb_write_data() function. That way the code is independent
of the CPU endianness.
Signed-off-by: Kiran Gunda
Reviewed-by: Stephen Boyd
This also
On 2017-07-28 06:48, Stephen Boyd wrote:
On 07/20, Kiran Gunda wrote:
Clean up the pmic_arb_find_apid() by using the local
variables to improve the code readability.
Signed-off-by: Kiran Gunda
---
Reviewed-by: Stephen Boyd
One nit below:
break;
re
On 2017-07-28 05:19, Stephen Boyd wrote:
On 07/20, Kiran Gunda wrote:
Allocate the correct memory size (max_pmic_peripherals) for the
mapping_table that holds the apid to ppid mapping. Also use a local
variable for mapping_table for better alignment of the code.
Signed-off-by: Kiran Gunda
Th
On 2017-07-19 03:47, Stephen Boyd wrote:
On 07/18, Kiran Gunda wrote:
v4:
* spmi: pmic-arb: add support for HW version 5
Clean-up as per Stephen's comments
v3:
* spmi: pmic-arb: add support for HW version 5
Modified #define INVALID (-1) to
#define INVALID_EE0xFF.
On 2017-07-19 04:16, Stephen Boyd wrote:
On 07/18, Kiran Gunda wrote:
This patch cleans up the following.
- Rename the "pa" to "pmic_arb".
- Rename the spmi_pmic_arb *dev to spmi_pmic_arb *pmic_arb.
- Rename the pa_{read,write}_data() functions to
pmic_arb_{read,write}_data().
- Rename channe
On 2017-06-13 07:40, Stephen Boyd wrote:
On 06/06, kgu...@codeaurora.org wrote:
On 2017-06-02 12:56, kgu...@codeaurora.org wrote:
>On 2017-05-31 23:23, Stephen Boyd wrote:
>>On 05/30, Kiran Gunda wrote:
>>>From: Subbaraman Narayanamurthy
>>>
>>>Currently, cleanup_irq() is invoked when a periphe
On 2017-06-01 03:37, Stephen Boyd wrote:
On 05/30, Kiran Gunda wrote:
@@ -1384,7 +1384,12 @@ static int spmi_pmic_arb_remove(struct
platform_device *pdev)
.of_match_table = spmi_pmic_arb_match_table,
},
};
-module_platform_driver(spmi_pmic_arb_driver);
+
+int __init spm
On 2017-07-14 23:00, Stephen Boyd wrote:
On 07/11, Kiran Gunda wrote:
@@ -420,7 +440,8 @@ static int pmic_arb_write_cmd(struct
spmi_controller *ctrl, u8 opc, u8 sid,
Mostly style nitpicks!
Will check and address in the next patch.
/* Start the transaction */
pmic_arb_base_
On 2017-07-14 23:50, Stephen Boyd wrote:
On 07/10, Kiran Gunda wrote:
-static u16 pmic_arb_find_apid(struct spmi_pmic_arb *pa, u16 ppid)
+static u16 pmic_arb_find_apid(struct spmi_pmic_arb *pmic_arb, u16
ppid)
{
+ struct apid_data *apid_info =
&pmic_arb->apid_data[pmic_arb->last_apid];
On 2017-07-06 12:19, Stephen Boyd wrote:
On 07/03, Kiran Gunda wrote:
This patch cleans up the following.
- Rename the "pa" to "pmic_arb".
- Rename the spmi_pmic_arb *dev to spmi_pmic_arb *pmic_arb.
- Rename the pa_{read,write}_data() functions to
pmic_arb_{read,write}_data().
- Rename channe
On 2017-07-06 12:29, Stephen Boyd wrote:
On 07/03, Kiran Gunda wrote:
From: David Collins
Add support for version 5 of the SPMI PMIC arbiter. It utilizes
different offsets for registers than those found on version 3.
Also, the procedure to determine if writing and IRQ access is
allowed for a
On 2017-07-06 12:16, Stephen Boyd wrote:
On 07/03, Kiran Gunda wrote:
diff --git a/drivers/spmi/spmi-pmic-arb.c
b/drivers/spmi/spmi-pmic-arb.c
index 5285245..2d2e39c 100644
--- a/drivers/spmi/spmi-pmic-arb.c
+++ b/drivers/spmi/spmi-pmic-arb.c
@@ -621,6 +621,19 @@ static int qpnpint_irq_set_type
On 2017-07-06 12:23, Stephen Boyd wrote:
On 07/03, Kiran Gunda wrote:
From: Fenglin Wu
The opc parameter in pmic_arb_write_cmd() function is defined with
type
u8 and it's always greater than or equal to 0. Checking that it's not
less than 0 is redundant and it can cause a forbidden warning d
On 2017-06-27 07:47, Stephen Boyd wrote:
After commit 7f1d4e58dabb ("spmi: pmic-arb: optimize table
lookups") we always need the ppid_to_apid table regardless of the
version of pmic arbiter we have. Otherwise, we will try to deref
the array when we don't allocate it on v2 hardware like the
msm897
On 2017-06-17 02:41, Stephen Boyd wrote:
On 06/14, kgu...@codeaurora.org wrote:
On 2017-06-01 02:09, Stephen Boyd wrote:
>On 05/30, Kiran Gunda wrote:
>>From: Abhijeet Dharmapurikar
>>
>>The driver currently invokes the apid handler (periph_handler())
>
>You mean periph_interrupt()?
>
Yes.
>>on
On 2017-06-01 02:09, Stephen Boyd wrote:
On 05/30, Kiran Gunda wrote:
From: Abhijeet Dharmapurikar
The driver currently invokes the apid handler (periph_handler())
You mean periph_interrupt()?
Yes.
once it sees that the summary status bit for that apid is set.
However the hardware is des
On 2017-06-13 07:39, Stephen Boyd wrote:
On 06/12, kgu...@codeaurora.org wrote:
On 2017-05-31 06:03, Stephen Boyd wrote:
>On 05/30, Kiran Gunda wrote:
>>From: Abhijeet Dharmapurikar
>>
>>The system crashes due to bad access when reading from an non
>>configured
>>peripheral and when writing to
On 2017-06-13 07:41, Stephen Boyd wrote:
On 06/06, kgu...@codeaurora.org wrote:
On 2017-05-31 07:27, Stephen Boyd wrote:
>On 05/30, Kiran Gunda wrote:
>>From: Abhijeet Dharmapurikar
>>
>>We see a unmapped irqs trigger right around bootup. This could
>>likely be because the bootloader exited lea
On 2017-05-31 06:03, Stephen Boyd wrote:
On 05/30, Kiran Gunda wrote:
From: Abhijeet Dharmapurikar
The system crashes due to bad access when reading from an non
configured
peripheral and when writing to peripheral which is not owned by
current
ee. This patch verifies ownership to avoid cras
On 2017-05-31 22:43, Stephen Boyd wrote:
On 05/30, Kiran Gunda wrote:
Currently the SPMI interrupt will not wake the device. Enable this
interrupt as a wakeup source.
Signed-off-by: Nicholas Troast
Signed-off-by: Kiran Gunda
---
drivers/spmi/spmi-pmic-arb.c | 1 +
1 file changed, 1 insertion
On 2017-06-01 11:38, Stephen Boyd wrote:
On 05/30, Kiran Gunda wrote:
diff --git a/drivers/spmi/spmi-pmic-arb.c
b/drivers/spmi/spmi-pmic-arb.c
index 412481d..b755c24 100644
--- a/drivers/spmi/spmi-pmic-arb.c
+++ b/drivers/spmi/spmi-pmic-arb.c
@@ -112,7 +123,8 @@ enum pmic_arb_cmd_op_code {
st
On 2017-06-02 12:56, kgu...@codeaurora.org wrote:
On 2017-05-31 23:23, Stephen Boyd wrote:
On 05/30, Kiran Gunda wrote:
From: Subbaraman Narayanamurthy
Currently, cleanup_irq() is invoked when a peripheral's interrupt
fires and there is no mapping present in the interrupt domain of
spmi inter
On 2017-06-01 03:48, Stephen Boyd wrote:
On 05/30, Kiran Gunda wrote:
/* PMIC Arbiter channel registers offsets */
@@ -96,6 +97,17 @@ enum pmic_arb_cmd_op_code {
/* interrupt enable bit */
#define SPMI_PIC_ACC_ENABLE_BITBIT(0)
+#define HWIRQ(slave_id, periph_id, irq_id, apid
On 2017-06-01 00:33, Stephen Boyd wrote:
On 05/30, Kiran Gunda wrote:
From: Abhijeet Dharmapurikar
The current code uses handle_level_irq flow handler even if the
trigger type of the interrupt is edge. This can lead to missing
of an edge transition that happens when the interrupt is being
hand
On 2017-06-01 03:33, Stephen Boyd wrote:
On 05/30, Kiran Gunda wrote:
From: Abhijeet Dharmapurikar
PMIC interrupts each have an internal latched status bit which is
not visible from any register. This status bit is set as soon as
the conditions specified in the interrupt type and polarity
reg
On 2017-05-31 07:27, Stephen Boyd wrote:
On 05/30, Kiran Gunda wrote:
From: Abhijeet Dharmapurikar
We see a unmapped irqs trigger right around bootup. This could
likely be because the bootloader exited leaving the interrupts
in an unknown or unhandled state. Ack and mask the interrupt
if one
On 2017-06-03 00:01, Stephen Boyd wrote:
On 06/01, kgu...@codeaurora.org wrote:
On 2017-05-31 07:14, Stephen Boyd wrote:
>On 05/30, Kiran Gunda wrote:
>>diff --git a/drivers/spmi/spmi-pmic-arb.c
>>b/drivers/spmi/spmi-pmic-arb.c
>>index 7201611..6320f1f 100644
>>--- a/drivers/spmi/spmi-pmic-arb.c
On 2017-06-02 23:59, Stephen Boyd wrote:
On 06/01, kgu...@codeaurora.org wrote:
>>@@ -209,23 +210,24 @@ static void pa_read_data(struct
>>spmi_pmic_arb_dev *dev, u8 *buf, u32 reg, u8 bc)
>> * @buf: buffer to write. length must be bc + 1.
>> */
>> static void
>>-pa_write_data(struct spmi_
On 2017-05-31 23:23, Stephen Boyd wrote:
On 05/30, Kiran Gunda wrote:
From: Subbaraman Narayanamurthy
Currently, cleanup_irq() is invoked when a peripheral's interrupt
fires and there is no mapping present in the interrupt domain of
spmi interrupt controller.
The cleanup_irq clears the arbite
On 2017-05-31 22:59, Stephen Boyd wrote:
On 05/30, Kiran Gunda wrote:
diff --git a/drivers/spmi/spmi-pmic-arb.c
b/drivers/spmi/spmi-pmic-arb.c
index 2afe359..412481d 100644
--- a/drivers/spmi/spmi-pmic-arb.c
+++ b/drivers/spmi/spmi-pmic-arb.c
@@ -1003,6 +1003,12 @@ static int spmi_pmic_arb_prob
On 2017-05-31 07:30, Stephen Boyd wrote:
On 05/30, Kiran Gunda wrote:
From: Abhijeet Dharmapurikar
irq_enable is called when the device resumes. Note that the
irq_enable is called regardless of whether the interrupt was
marked enabled/disabled in the descriptor or whether it was
masked/unmaske
On 2017-05-31 07:14, Stephen Boyd wrote:
On 05/30, Kiran Gunda wrote:
diff --git a/drivers/spmi/spmi-pmic-arb.c
b/drivers/spmi/spmi-pmic-arb.c
index 7201611..6320f1f 100644
--- a/drivers/spmi/spmi-pmic-arb.c
+++ b/drivers/spmi/spmi-pmic-arb.c
@@ -164,6 +164,8 @@ struct spmi_pmic_arb {
*
On 2017-05-31 07:01, Stephen Boyd wrote:
On 05/30, Kiran Gunda wrote:
From: Abhijeet Dharmapurikar
The driver currently uses "apid" and "chan" to mean apid. Remove
the use of chan and use only apid.
I'm not so sure. It currently uses "chan" to mean the offset to
add to the "PMIC Arbiter chan
Thanks Stephen for reviewing the patches. Responses inline.
Thanks,
Kiran
On 2017-05-31 06:16, Stephen Boyd wrote:
On 05/30, Kiran Gunda wrote:
From: Abhijeet Dharmapurikar
Usually *_dev best used for structures that embed a struct device in
them. spmi_pmic_arb_dev doesn't embed one. It is s
On 2016-10-04 02:33, Stephen Boyd wrote:
On 09/30, kgu...@codeaurora.org wrote:
On 2016-09-29 23:30, Mark Brown wrote:
>On Thu, Sep 29, 2016 at 05:06:26PM +0530, Kiran Gunda wrote:
>
>>-#undef REGMAP_ALLOW_WRITE_DEBUGFS
>>+#define REGMAP_ALLOW_WRITE_DEBUGFS
>
>This is completely inappropriate fo
On 2016-09-29 23:30, Mark Brown wrote:
On Thu, Sep 29, 2016 at 05:06:26PM +0530, Kiran Gunda wrote:
-#undef REGMAP_ALLOW_WRITE_DEBUGFS
+#define REGMAP_ALLOW_WRITE_DEBUGFS
This is completely inappropriate for upstream, if you need to do
debugging on your platform you can enable this locally bu
89 matches
Mail list logo
