Re: [PATCH] staging: andriod: ashmem: Declared file operation with const keyword

On Sat, Mar 13, 2021 at 10:57 PM namratajanawade wrote: > > Warning found by checkpatch.pl script. That doesn't tell what you did or why you did it. Please write an appropriate commit description and resend the patch. karthik

[PATCH] staging: media/atomisp: don't compile unused code

currently the functions defined in ibuf_ctrl_rmgr.c file are only used by isys_init.c when CONFIG_VIDEO_ATOMISP_ISP2401 is selected so dont't compile it when not needed, also fixes some sparse warnings Signed-off-by: karthik alapati --- drivers/staging/media/atomisp/Makefile | 5 +++-- 1

[PATCH 0/2] fix sparse warnings

drivers/staging//wimax/i2400m/op-rfkill.c:89:25:got unsigned long . drivers/staging//wimax/i2400m/fw.c:514:27: warning: restricted __le32 degrades to integer karthik alapati (2): staging: wimax/i2400m: fix byte-order issue staging: wimax/i2400m: convert __le32 type to host byte-order

[PATCH 2/2] staging: wimax/i2400m: convert __le32 type to host byte-order

fix sparse type warning by converting __le32 types to host byte-order types before comparison Signed-off-by: karthik alapati --- drivers/staging/wimax/i2400m/fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wimax/i2400m/fw.c b/drivers/staging/wimax

[PATCH 1/2] staging: wimax/i2400m: fix byte-order issue

fix sparse byte-order warnings by converting host byte-order type to __le16 byte-order types before assigning to hdr.length Signed-off-by: karthik alapati --- drivers/staging/wimax/i2400m/op-rfkill.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wimax

[PATCH 3/3] staging: media/atomisp: don't compile unused code

currently the functions defined in ibuf_ctrl_rmgr.c file are only used by isys_init.c when CONFIG_VIDEO_ATOMISP_ISP2401 is selected so dont't compile it when not needed, also fixes some sparse warnings Signed-off-by: karthik alapati --- drivers/staging/media/atomisp/Makefile | 5 +++-- 1

[PATCH 2/3] staging: wimax/i2400m: convert __le32 type to host byte-order

fix sparse type warning by converting __le32 types to host byte-order types before comparison Signed-off-by: karthik alapati --- drivers/staging/wimax/i2400m/fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wimax/i2400m/fw.c b/drivers/staging/wimax

[PATCH 0/3] fix sparse warnings

:6: warning: symbol 'ia_css_isys_ibuf_rmgr_acquire' was not declared. Should it be static? drivers/staging//media/atomisp/pci/runtime/isys/src/ibuf_ctrl_rmgr.c:106:6: warning: symbol 'ia_css_isys_ibuf_rmgr_release' was not declared. Should it be static? karthik alapati (3):

[PATCH 1/3] staging: wimax/i2400m: fix byte-order issue

fix sparse byte-order warnings by converting host byte-order type to __le16 byte-order types before assigning to hdr.length Signed-off-by: karthik alapati --- drivers/staging/wimax/i2400m/op-rfkill.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wimax

[PATCH] staging: media/atomisp: don't compile unused code

currently the functions defined in ibuf_ctrl_rmgr.c file are only used by isys_init.c when CONFIG_VIDEO_ATOMISP_ISP2401 is selected so dont't compile it when not needed, also fixes some sparse warnings Signed-off-by: karthik alapati --- is this the right patch or just compiling out

[PATCH] staging: wimax/i2400m: fix byte-order type issue

fix sparse type warning by converting le32 types to host byte-order types before comparison Signed-off-by: karthik alapati --- drivers/staging/wimax/i2400m/fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wimax/i2400m/fw.c b/drivers/staging/wimax/i2400m

[PATCH] staging: wimax/i2400m: fix byte-order issue

fix sparse byte-order warnings by converting host byte-order types to le32 types Signed-off-by: karthik alapati --- drivers/staging/wimax/i2400m/op-rfkill.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wimax/i2400m/op-rfkill.c b/drivers/staging/wimax

[PATCH] staging: wimax: fix sparse incorrect type issue

fix sparse warning by casting to explicit user address-space pointer type Signed-off-by: karthik alapati --- drivers/staging/wlan-ng/p80211netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/p80211netdev.c b/drivers/staging/wlan-ng

[PATCH] staging: i2400m: use explicit host byte-order types in comparison

convert le32 types to host byte-order types before comparison Signed-off-by: karthik alapati --- i wonder how these could be false-positives drivers/staging/wimax/i2400m/fw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wimax/i2400m/fw.c b/drivers

[PATCH] use explicit host byte-order types in comparison

convert le32 types to host byte-order types before comparison Signed-off-by: karthik alapati --- i wonder how these could be false-positives drivers/staging/wimax/i2400m/fw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wimax/i2400m/fw.c b/drivers

[PATCH v4 2/2] staging: rtl8723bs: remove obsolete commented out code

There is a bunch of messy, commented out code. Just delete it. Suggested-by: Dan Carpenter Signed-off-by: karthik alapati --- .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 40 +-- 1 file changed, 2 insertions(+), 38 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal

[PATCH v4 0/2] staging: rtl8723bs: driver cleanup

karthik alapati (2): staging: rtl8723bs: fix function comments to follow kernel-doc staging: rtl8723bs: remove obsolete commented out code .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 225 ++ 1 file changed, 75 insertions(+), 150 deletions(-) -- 2.30.0

[PATCH v4 1/2] staging: rtl8723bs: fix function comments to follow kernel-doc

there are some good function comments not following kernel-doc. Make them follow kernel-doc style Signed-off-by: karthik alapati --- .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 185 +++--- 1 file changed, 73 insertions(+), 112 deletions(-) diff --git a/drivers/staging/rtl8723bs

[PATCH] staging: rtl8723bs: fix function comments to follow kernel-doc

fix checkpatch.pl warning for "block comments should align the * on each line" and make function comments follow kernel-doc Signed-off-by: karthik alapati --- .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 185 +++--- 1 file changed, 73 insertions(+), 112 deletions(-)

[PATCH] staging: rtl8723bs: remove obsolete commented out code

fix some checkpatch "Block comments use * on subsequent lines" warnings and remove obsolete code Suggested-by: Dan Carpenter Signed-off-by: karthik alapati --- .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 44 --- 1 file changed, 9 insertions(+), 35 deletions(-) di

[PATCH] staging: rtl8723bs: fix function comments to follow kernel-doc

fix checkpatch.pl warning for "block comments should align the * on each line" and make function comments follow kernel-doc Signed-off-by: karthik alapati --- .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 209 -- 1 file changed, 91 insertions(+), 118 deletions(-)

[PATCH] staging: rtl8723bs: fix block comments alignment

fix checkpatch.pl warning for "block comments should align the * on each line" Signed-off-by: karthik alapati --- .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 204 +- 1 file changed, 102 insertions(+), 102 deletions(-) diff --git a/drivers/staging/rtl

[PATCH] staging: greybus: audio_helper.c: Replace strlcpy() with strscpy()

showing this warning. Signed-off-by: B K Karthik --- drivers/staging/greybus/audio_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/audio_helper.c b/drivers/staging/greybus/audio_helper.c index 3011b8abce38..1ed4772d2771 100644 --- a/drivers

Re: KASAN: use-after-free Read in __xfrm6_tunnel_spi_lookup

You can see on the dashboard (or in mailing list archives) that B K > Karthik tested a patch for this bug in July: > https://syzkaller.appspot.com/bug?extid=72ff2fa98097767b5a27 > > So perhaps that patch fixes it? Karthik, did you send it? Was it > merged? Did the commit include the

Re: [PATCH v2] tty: serial: fsl_lpuart.c: prevent a bad shift operation

On Wed, Aug 5, 2020 at 6:26 PM Greg Kroah-Hartman wrote: > > On Wed, Aug 05, 2020 at 12:09:34PM +, Vabhav Sharma (OSS) wrote: > > > > > > > -Original Message- > > > From: Greg Kroah-Hartman > > > Sent: Wednesday, July 29, 2020 9:34 P

Re: [PATCH] net: tipc: fix general protection fault in tipc_conn_delete_sub

On Mon, Jul 27, 2020 at 6:53 PM Greg KH wrote: > > On Mon, Jul 27, 2020 at 06:40:57PM +0530, B K Karthik wrote: > > fix a general protection fault in tipc_conn_delete_sub > > by checking for the existance of con->server. > > prevent a null-ptr-deref by returning -EIN

[PATCH] net: tipc: fix general protection fault in tipc_conn_delete_sub

002080 CR3: 91b8e000 CR4: 001406e0 DR0: DR1: DR2: DR3: DR6: fffe0ff0 DR7: 0400 Reported-and-tested-by: syzbot+55a38037455d0351e...@syzkaller.appspotmail.com Signed-off-by: B K Karthik --- net

Re: [PATCH v2] net: ipv6: fix use-after-free Read in __xfrm6_tunnel_spi_lookup

On Mon, Jul 27, 2020 at 1:37 AM Cong Wang wrote: > > On Sat, Jul 25, 2020 at 11:12 PM B K Karthik wrote: > > > > On Sun, Jul 26, 2020 at 11:05 AM Cong Wang wrote: > > > > > > On Sat, Jul 25, 2020 at 8:09 PM B K Karthik > > > wr

Re: [PATCH v2] net: ipv6: fix use-after-free Read in __xfrm6_tunnel_spi_lookup

On Sun, Jul 26, 2020 at 11:05 AM Cong Wang wrote: > > On Sat, Jul 25, 2020 at 8:09 PM B K Karthik wrote: > > @@ -103,10 +103,10 @@ static int __xfrm6_tunnel_spi_check(struct net *net, > > u32 spi) > > { > > struct xfrm6_tunnel_net *xfrm

[PATCH v2] net: ipv6: fix use-after-free Read in __xfrm6_tunnel_spi_lookup

-by: syzbot+72ff2fa98097767b5...@syzkaller.appspotmail.com Reported-by: kernel test robot Signed-off-by: B K Karthik --- v1 -> v2: added cast in arguement from u32 to (const xfrm_address_t *) added Reported-by: kernel test robot removed Reported-by: syzbot+72ff2fa9809

[PATCH] net: xfrm: xfrm_policy.c: remove some unnecessary cases in decode_session6

remove some unnecessary cases in decode_session6 Signed-off-by: B K Karthik --- net/xfrm/xfrm_policy.c | 4 1 file changed, 4 deletions(-) diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c index 19c5e0fa3f44..e1c988a89382 100644 --- a/net/xfrm/xfrm_policy.c +++ b/net/xfrm

[PATCH] net: ipv6: fix slab-out-of-bounds Read in __xfrm6_tunnel_spi_check

fc fc fc fc fc fc 8880a93a5f00: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc == Reported-by: syzbot+7da3fdf292816554b...@syzkaller.appspotmail.com Signed-off-by: B K Karthik --- net/ipv6/xfrm6_tunnel.c | 4 ++-- 1 file changed

[PATCH] smack: fix slab-out-of-bounds by checking for overflow

fc fc fc fc 888097d68380: 00 00 00 00 01 fc fc fc fc fc fc fc fc fc fc fc == Reported-and-testedby: syzbot+a22c6092d003d6fe1...@syzkaller.appspotmail.com Signed-off-by: B K Karthik --- security/smack/smackfs.c | 5 + 1 f

[PATCH] net: ipv6: fix slab-out-of-bounda Read in xfrm6_tunnel_alloc_spi

com Signed-off-by: B K Karthik --- net/ipv6/xfrm6_tunnel.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/ipv6/xfrm6_tunnel.c b/net/ipv6/xfrm6_tunnel.c index 25b7ebda2fab..2d049244be81 100644 --- a/net/ipv6/xfrm6_tunnel.c +++ b/net/ipv6/xfrm6_tunnel.c @@ -121,8 +12

Re: WARNING in pvr2_i2c_core_done

_del() goes before the release cb in kobject_cleanup() and > kobj is removed from sysfs, see [3] above. Oh, thank you for letting me know about this. Forgive me, but I did not understand you very clearly. I presume you are saying that the second call to i2c_unregister_device() is where the problem occurs? please let me know. thanks, karthik

[PATCH v2] i2c: fix WARNING in pvr2_i2c_core_done

: syzbot+e74a998ca8f1df9cc...@syzkaller.appspotmail.com Signed-off-by: B K Karthik --- v1 -> v2: remove a call to acpi_ut_delete_generic state and set linked flag after adding adapter to i2c as suggested by Hillf Danton drivers/acpi/acpica/utdelete.c

[PATCH v2] tty: serial: fsl_lpuart.c: prevent a bad shift operation

prevent a bad shift operation by verifying that the argument to fls is non zero. Reported-by: "Vabhav Sharma (OSS)" Signed-off-by: B K Karthik --- v1 -> v2: added Reported-by tag drivers/tty/serial/fsl_lpuart.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[PATCH 2/2] tty: serial: fsl_lpuart.c: fix a parentheses coding style issue

add parentheses to expression to improve code readability. Signed-off-by: B K Karthik --- drivers/tty/serial/fsl_lpuart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c index 0cc64279cd2d..3108f5ab57fa 100644

[PATCH 1/2] tty: serial: fsl_lpuart.c: prevent a bad shift operation

prevent a bad shift operation by verifying that sport->rx_dma_rng_buf_len is non zero. Signed-off-by: B K Karthik --- drivers/tty/serial/fsl_lpuart.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c in

Re: WARNING in pvr2_i2c_core_done

On Tue, Jul 21, 2020 at 4:50 PM syzbot wrote: > > Hello, > > syzbot has tested the proposed patch but the reproducer is still triggering > an issue: > general protection fault in kernfs_find_ns > > pvrusb2: Invalid write control endpoint > pvrusb2: Invalid write control endpoint > pvrusb2: Invali

[PATCH] i2c: fix WARNING in pvr2_i2c_core_done

#syz test: https://github.com/google/kasan.git usb-fuzzer fix WARNING in pvr2_i2c_core_done by unregistering device in the release handler instead of the disconnect handler. Reported-by: syzbot+e74a998ca8f1df9cc...@syzkaller.appspotmail.com Signed-off-by: B K Karthik --- drivers/i2c/i2c-core

[PATCH] MAINTAINERS: mark usbvision as obsolete

mark staging/media/usbvision as obsolete so checkpatch tells people not to send patches. Signed-off-by: B K Karthik --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index a88bf0759c90..82120c2fcedd 100644 --- a/MAINTAINERS +++ b

Re: [PATCH 2/4] staging: rtl8188eu: include: fixed multiple parentheses coding style issues

On Sun, Jul 19, 2020 at 5:26 AM Greg Kroah-Hartman wrote: > > On Sat, Jul 18, 2020 at 05:16:26AM -0400, B K Karthik wrote: > > fixed multiple parentheses coding style issues reported by checkpatch. > > > > Signed-off-by: B K Karthik > > --- > > drivers/stagin

Re: [PATCH 4/4] staging: rtl8188eu: include: placed constant on the right side of the test in comparisons

On Sat, Jul 18, 2020 at 9:17 AM Joe Perches wrote: > > On Sat, 2020-07-18 at 05:18 -0400, B K Karthik wrote: > > placed constant on the right side of the test > > to fix warnings issued by checkpatch > [] > > diff --git a/drivers/staging/rtl8188eu/include/wifi.h >

[PATCH 4/4] staging: rtl8188eu: include: placed constant on the right side of the test in comparisons

placed constant on the right side of the test to fix warnings issued by checkpatch Signed-off-by: B K Karthik --- drivers/staging/rtl8188eu/include/rtw_mlme.h | 4 ++-- drivers/staging/rtl8188eu/include/wifi.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH 3/4] staging: rtl8188eu: include: enclosed macros in do-while loops

enclosed macros starting with if inside do-while loops to avoid possible if-else logic defects Signed-off-by: B K Karthik --- drivers/staging/rtl8188eu/include/odm_debug.h | 28 +++ 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rtl8188eu/include

[PATCH 2/4] staging: rtl8188eu: include: fixed multiple parentheses coding style issues

fixed multiple parentheses coding style issues reported by checkpatch. Signed-off-by: B K Karthik --- drivers/staging/rtl8188eu/include/ieee80211.h | 4 +-- .../staging/rtl8188eu/include/osdep_service.h | 4 +-- drivers/staging/rtl8188eu/include/wifi.h | 34 +-- 3 files

[PATCH 1/4] staging: rtl8188eu: include: fixed multiple blank space coding style issues

fixed multiple blank space coding style issues reported by checkpatch Signed-off-by: B K Karthik --- drivers/staging/rtl8188eu/include/hal_com.h | 2 +- drivers/staging/rtl8188eu/include/osdep_service.h | 2 +- drivers/staging/rtl8188eu/include/rtl8188e_hal.h | 2 +- drivers/staging

[PATCH v5] staging: comedi: comedi_fops.c: added casts to get rid of sparse warnings

fixed sparse warnings by adding a cast in assignment from void [noderef] __user * to unsigned int __force * and a reverse cast in argument from unsigned int * to unsigned int __user * . Signed-off-by: B K Karthik Reviewed-by: Ian Abbott --- v1 -> v2: - Added a reverse cast in argument v2 -&

[PATCH v4] staging: comedi: comedi_fops.c: added casts to get rid of sparse warnings

ott v3 -> v4: - Add versioning information in commit description Signed-off-by: B K Karthik --- drivers/staging/comedi/comedi_fops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c index 3f7

Re: [PATCH v3] staging: comedi: comedi_fops.c: added casts to get rid of sparse warnings

On Thu, Jul 16, 2020 at 10:25 AM Greg Kroah-Hartman wrote: > > On Thu, Jul 16, 2020 at 10:17:47AM -0400, B K Karthik wrote: > > fixed sparse warnings by adding a cast in assignment from > > void [noderef] __user * to unsigned int __force * > > and a reverse cast in argume

[PATCH v3] staging: comedi: comedi_fops.c: added casts to get rid of sparse warnings

fixed sparse warnings by adding a cast in assignment from void [noderef] __user * to unsigned int __force * and a reverse cast in argument from unsigned int * to unsigned int __user * . Signed-off-by: B K Karthik --- drivers/staging/comedi/comedi_fops.c | 4 ++-- 1 file changed, 2 insertions

[PATCH] fs: block_dev.c: fix WARNING in submit_bio_check

e avoided by doing the same with bdev_get_by_dev. Reported-by: syzbot+4c50ac32e5b10e413...@syzkaller.appspotmail.com Signed-off-by: B K Karthik --- fs/block_dev.c | 5 + 1 file changed, 5 insertions(+) diff --git a/fs/block_dev.c b/fs/block_dev.c index 64c4fe8181f2..472e3b046406 100644 --- a/fs

[PATCH v2] staging: comedi: comedi_fops.c: added casts to get rid of sparse warnings

fixed sparse warnings by adding a cast in assignment from void [noderef] __user * to unsigned int __force * and a reverse cast in argument from void [noderef] __user * to unsigned int __user * . Signed-off-by: B K Karthik --- drivers/staging/comedi/comedi_fops.c | 4 ++-- 1 file changed, 2

Re: [PATCH] staging: comedi: comedi_fops.c: changed type in assignment to unsigned int *

On Wed, Jul 15, 2020 at 7:19 AM Ian Abbott wrote: > > On 15/07/2020 05:48, B K Karthik wrote: > > fixed a sparse warning by changing the type in > > assignment from void [noderef] __user * to unsigned int * > > (different address space) > > > > Signed-off-by

Re: [PATCH] staging: comedi: comedi_fops.c: changed type in assignment to unsigned int *

On Wed, Jul 15, 2020 at 5:29 AM Greg Kroah-Hartman wrote: > > On Wed, Jul 15, 2020 at 05:21:01AM -0400, B K Karthik wrote: > > On Wed, Jul 15, 2020 at 5:14 AM Greg Kroah-Hartman > > wrote: > > > > > > On Wed, Jul 15, 2020 at 04:41:52AM -0400, B K Karthik wrot

Re: [PATCH] staging: comedi: comedi_fops.c: changed type in assignment to unsigned int *

On Wed, Jul 15, 2020 at 5:19 AM Greg Kroah-Hartman wrote: > > On Wed, Jul 15, 2020 at 04:47:48AM -0400, B K Karthik wrote: > > On Wed, Jul 15, 2020 at 4:41 AM B K Karthik wrote: > > > > > > On Wed, Jul 15, 2020 at 4:31 AM Greg Kroah-Hartman > > > wrote:

Re: [PATCH] staging: comedi: comedi_fops.c: changed type in assignment to unsigned int *

On Wed, Jul 15, 2020 at 5:14 AM Greg Kroah-Hartman wrote: > > On Wed, Jul 15, 2020 at 04:41:52AM -0400, B K Karthik wrote: > > On Wed, Jul 15, 2020 at 4:31 AM Greg Kroah-Hartman > > wrote: > > > > > > On Wed, Jul 15, 2020 at 01:56:45PM +0530, B K Karthik wro

Re: [PATCH] staging: comedi: comedi_fops.c: changed type in assignment to unsigned int *

On Wed, Jul 15, 2020 at 4:41 AM B K Karthik wrote: > > On Wed, Jul 15, 2020 at 4:31 AM Greg Kroah-Hartman > wrote: > > > > On Wed, Jul 15, 2020 at 01:56:45PM +0530, B K Karthik wrote: > > > On Wed, Jul 15, 2020, 12:38 PM Greg Kroah-Hartman < > &

Re: [PATCH] staging: comedi: comedi_fops.c: changed type in assignment to unsigned int *

On Wed, Jul 15, 2020 at 4:31 AM Greg Kroah-Hartman wrote: > > On Wed, Jul 15, 2020 at 01:56:45PM +0530, B K Karthik wrote: > > On Wed, Jul 15, 2020, 12:38 PM Greg Kroah-Hartman < > > gre...@linuxfoundation.org> wrote: > > > > > On Wed, Jul 15, 2020

Re: [PATCH] staging: comedi: comedi_fops.c: changed type in assignment to unsigned int *

On Wed, Jul 15, 2020 at 3:08 AM Greg Kroah-Hartman wrote: > > On Wed, Jul 15, 2020 at 12:48:13AM -0400, B K Karthik wrote: > > fixed a sparse warning by changing the type in > > assignment from void [noderef] __user * to unsigned int * > > (different address space) &g

[PATCH] staging: comedi: comedi_fops.c: changed type in assignment to unsigned int *

fixed a sparse warning by changing the type in assignment from void [noderef] __user * to unsigned int * (different address space) Signed-off-by: B K Karthik --- drivers/staging/comedi/comedi_fops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi

[PATCH v2] staging: media: atomisp: mark some csi_rx.c symbols static

changed symbols N_SHORT_PACKET_LUT_ENTRIES, N_LONG_PACKET_ENTRIES, N_CSI_RX_FE_CTRL_DLANES, N_CSI_RX_BE_SID_WIDTH to static because they were not declared earlier. Signed-off-by: B K Karthik --- .../media/atomisp/pci/css_2401_system/host/csi_rx.c | 8 1 file changed, 4 insertions

[PATCH] drivers: staging: media: atomisp: pci: css_2401_system: host: csi_rx.c: fixed a sparse warning by making undeclared symbols static

changed symbols N_SHORT_PACKET_LUT_ENTRIES, N_LONG_PACKET_ENTRIES, N_CSI_RX_FE_CTRL_DLANES, N_CSI_RX_BE_SID_WIDTH to static because they were not declared earlier. Signed-off-by: B K Karthik --- .../media/atomisp/pci/css_2401_system/host/csi_rx.c | 8 1 file changed, 4 insertions

[PATCH 2/2] staging: rtl8188eu: include: rtw_pwrctrl.h: fixed a blank space coding style issue.

add blank spaces to improve code readability. Signed-off-by: B K Karthik --- drivers/staging/rtl8188eu/include/rtw_pwrctrl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_pwrctrl.h b/drivers/staging/rtl8188eu/include/rtw_pwrctrl.h

[PATCH 1/2] staging: rtl8188eu: include: rtw_pwrctrl.h: fixed multiple parentheses coding style issues.

add parentheses since complex valued macros must be enclosed within parentheses. Signed-off-by: B K Karthik --- drivers/staging/rtl8188eu/include/rtw_pwrctrl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_pwrctrl.h b/drivers

[PATCH] staging: rtl8188eu: include: rtw_recv.h: fixed a blank space coding style issue.

added blank spaces to improve code readability. Signed-off-by: B K Karthik --- drivers/staging/rtl8188eu/include/rtw_recv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h b/drivers/staging/rtl8188eu/include/rtw_recv.h index

[PATCH] staging: rtl8188eu: include: rtw_cmd.h: fixed a blank space coding style issue.

add blank spaces for improved code readability. Signed-off-by: B K Karthik --- drivers/staging/rtl8188eu/include/rtw_cmd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_cmd.h b/drivers/staging/rtl8188eu/include/rtw_cmd.h index

[PATCH] staging: rtl8188eu: include: rtl8188e_xmit.h: fixed multiple blank space coding style issues

added blank spaces to improve code readability. (coding style issue) Signed-off-by: B K Karthik --- drivers/staging/rtl8188eu/include/rtl8188e_xmit.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtl8188e_xmit.h b/drivers

[PATCH 2/2] staging: rtl8188eu: include: rtw_pwrctrl.h: fixed a blank space coding style issue.

add blank spaces to improve code readability. Signed-off-by: B K Karthik --- drivers/staging/rtl8188eu/include/rtw_pwrctrl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_pwrctrl.h b/drivers/staging/rtl8188eu/include/rtw_pwrctrl.h

[PATCH 1/2] staging: rtl8188eu: include: rtw_pwrctrl.h: fixed multiple parentheses coding style issues.

add parentheses since complex valued macros must be enclosed within parentheses. Signed-off-by: B K Karthik --- drivers/staging/rtl8188eu/include/rtw_pwrctrl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_pwrctrl.h b/drivers

[PATCH] staging: rtl8188eu: include: rtl8188e_xmit.h: fixed multiple blank space coding style issues

added blank spaces to improve code readability. (coding style issue) Signed-off-by: B K Karthik --- drivers/staging/rtl8188eu/include/rtl8188e_xmit.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtl8188e_xmit.h b/drivers

[PATCH] staging: rtl8188eu: include: rtw_recv.h: fixed a blank space coding style issue.

added blank spaces to improve code readability. Signed-off-by: B K Karthik --- drivers/staging/rtl8188eu/include/rtw_recv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h b/drivers/staging/rtl8188eu/include/rtw_recv.h index

[PATCH 2/2] staging: rtl8188eu: include: rtw_pwrctrl.h: fixed a blank space coding style issue.

add blank spaces to improve code readability. Signed-off-by: B K Karthik --- drivers/staging/rtl8188eu/include/rtw_pwrctrl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_pwrctrl.h b/drivers/staging/rtl8188eu/include/rtw_pwrctrl.h

[PATCH 1/2] staging: rtl8188eu: include: rtw_pwrctrl.h: fixed multiple parentheses coding style issues.

add parentheses since complex valued macros must be enclosed within parentheses. Signed-off-by: B K Karthik --- drivers/staging/rtl8188eu/include/rtw_pwrctrl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_pwrctrl.h b/drivers

[PATCH] staging: rtl8188eu: include: rtw_cmd.h: fixed a blank space coding style issue.

add blank spaces for improved code readability. Signed-off-by: B K Karthik --- drivers/staging/rtl8188eu/include/rtw_cmd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_cmd.h b/drivers/staging/rtl8188eu/include/rtw_cmd.h index

[PATCH] staging: rtl8188eu: include: rtl8188e_xmit.h: fixed multiple blank space coding style issues

added blank spaces to improve code readability. Signed-off-by: B K Karthik --- drivers/staging/rtl8188eu/include/rtl8188e_xmit.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtl8188e_xmit.h b/drivers/staging/rtl8188eu

[PATCH] staging: rtl8188eu: include: hal8188e_rate_adaptive.h: fixed a blank space coding style issue

added blank space around arithmetic operators to improve readability Signed-off-by: B K Karthik --- .../rtl8188eu/include/hal8188e_rate_adaptive.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/hal8188e_rate_adaptive.h b

[PATCH] staging: rtl8188eu: include: odm.h: fixed a blank space coding style issue.

added blank space and enclosed a complex valued macro within parentheses for improved code readability. Signed-off-by: B K Karthik --- drivers/staging/rtl8188eu/include/odm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/include/odm.h b/drivers

Re: [PATCH] staging: media: atomisp: i2c: atomisp-ov2680.c: fixed a brace coding style issue.

Did this get burried in along with a bunch of other patches? I am sending this email only because I did not recieve a negetive acknowledgement on the patch. I apologize if this message was hurtful / disrespectfull in any manner, thank you for reading this message. karthik On 20/06/28 12:38AM

[PATCH] staging: rtl8188eu: include: ieee80211.h: fixed multiple blank line coding style issues.

removed multiple blank lines to improve code readability. Signed-off-by: B K Karthik --- drivers/staging/rtl8188eu/include/ieee80211.h | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/ieee80211.h b/drivers/staging/rtl8188eu/include/ieee80211.h index

[REPORT] False positive errors found while using scripts/checkpatch.pl

The following are reported while using checkpatch.pl on drivers/staging/fbtft/fbtft-bus.c ERROR: space prohibited before that close parenthesis ')' #65: FILE: drivers/staging/fbtft/fbtft-bus.c:65: +define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, ) ERROR: space prohibited before that close

[PATCH] init: main.c: Fixed a brace coding style issue.

Fixed a coding style issue. Signed-off-by: B K Karthik --- init/main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/init/main.c b/init/main.c index 9127b240fd26..d8477fb95bec 100644 --- a/init/main.c +++ b/init/main.c @@ -385,11 +385,11 @@ static u32

[PATCH] staging: media: atomisp: i2c: atomisp-ov2680.c: fixed a brace coding style issue.

Fixed a coding style issue. Signed-off-by: B K Karthik --- drivers/staging/media/atomisp/i2c/atomisp-ov2680.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c index

Re: [PATCH] staging: media: usbvision: removing prohibited space before ',' (ctx:WxW)

Thank you for the information. I will take care of all these things from the next time. sorry for wasting your time thanks, karthik On Sat, Jun 27, 2020 at 4:49 AM Greg Kroah-Hartman wrote: > > On Sat, Jun 27, 2020 at 10:28:31AM +0200, Hans Verkuil wrote: > > On 27/06/2020 07:07

[PATCH] staging: rtl8712: rtl8712_recv.h: Removing unnecessary blank line

Removing unnecessary blank line Signed-off-by: B K Karthik --- drivers/staging/rtl8712/rtl8712_recv.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8712/rtl8712_recv.h b/drivers/staging/rtl8712/rtl8712_recv.h index 3e385b2242d8..69d3d5b287d3 100644 --- a/drivers/staging

[PATCH] qlge.h: Adding the missing blank line after declarations

Signed-off-by: B K Karthik --- drivers/staging/qlge/qlge.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/qlge/qlge.h b/drivers/staging/qlge/qlge.h index fc8c5ca8935d..0b971a633001 100644 --- a/drivers/staging/qlge/qlge.h +++ b/drivers/staging/qlge/qlge.h @@ -2224,6 +2224,7

[PATCH] fbtft-bus.c: Removing that prohibited space before ')'

fbtft-bus.c: fixing ERROR: space prohibited before that close parenthesis ')' by removing that space and ',' in line 65 and 67. Signed-off-by: B K Karthik --- drivers/staging/fbtft/fbtft-bus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH] fbtft-bus.c:

fbtft-bus.c: fixing ERROR: space prohibited before that close parenthesis ')' by removing that space and ',' in line 65 and 67. Signed-off-by: B K Karthik --- drivers/staging/fbtft/fbtft-bus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

Re: [PATCH] staging: media: usbvision: removing prohibited space before ',' (ctx:WxW)

reg's patch-bot, or the driver is scheduled for removal. Please do think about adding a file that lists all drivers scheduled for removal. I apologize if my message was hurtful or disrespectful in any way. Thank you for reading this message, Karthik On Fri, Jun 26, 2020 at 10:32 AM B K Karthi

[PATCH] staging: media: usbvision: removing prohibited space before ',' (ctx:WxW)

fixing ERROR: space prohibited before that ',' (ctx:WxW) Signed-off-by: B K Karthik --- drivers/staging/media/usbvision/usbvision-i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/usbvision/usbvision-i2c.c b/drivers/staging/media

[PATCH] fixing ERROR: Macros with complex values must be enclosed within parentheses.

soc_camera.c: fixing ERROR: Macros with complex values must be enclused within parentheses. Signed-off-by: B K Karthik --- drivers/staging/media/soc_camera/soc_camera.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/media/soc_camera/soc_camera.c b

[PATCH 1/1] staging: media: soc_camera: Adding parentheses to macro defination at line 241, Clearing alignment issues at lines 410 and 1270, fixing return values at EPOLLERR

yle problem "Alignment should match open parenthesis" by adding tab spaces in line 1270. Signed-off-by: B K Karthik --- drivers/staging/media/soc_camera/soc_camera.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/media/soc_camera/soc_camera.

[PATCH] staging: nvec: changed coding style, line should not end with a (

Signed-off-by: B K Karthik --- drivers/staging/nvec/nvec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c index 360ec0407740..16afbe1dfdeb 100644 --- a/drivers/staging/nvec/nvec.c +++ b/drivers/staging/nvec/nvec.c

[PATCH v2] Staging: rtlwifi: remove unnecessary NULL check

~ ~^~~~ 1 warning generated. Link: https://github.com/ClangBuiltLinux/linux/issues/170 Signed-off-by: Karthik Nishanth --- v2: changed the subject drivers/staging/rtlwifi/regd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtlwifi/regd.c b/

Re: [PATCH] Fix clang warning -Wpointer-bool-conversion by removing unnecessary check in regd.c

Do I submit a new patch with the modified subject? On Sat, Sep 22, 2018 at 03:44:32PM +0300, Dan Carpenter wrote: >The subject needs a subsystem prefix. It's also slightly long. > >[PATCH] Staging: rtlwifi: remove unnecessary NULL check > >regards, >dan carpenter > Karthik Nishanth

[PATCH] Fix clang warning -Wpointer-bool-conversion by removing unnecessary check in regd.c

~ ~^~~~ 1 warning generated. Link: https://github.com/ClangBuiltLinux/linux/issues/170 Signed-off-by: Karthik Nishanth --- drivers/staging/rtlwifi/regd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtlwifi/regd.c b/drivers/staging/rtl

Re: [PATCH v7 1/4] i2c: i2c-qcom-geni: Add bus driver for the Qualcomm GENI I2C controller

; >> +pm_runtime_use_autosuspend(gi2c->se.dev); >> +pm_runtime_enable(gi2c->se.dev); >> +i2c_add_adapter(&gi2c->adap); >> + >> +return 0; > > i2c_add_adapter can fail. So, I'd guess you want to check the return > value and move it above

Re: [PATCH] i2c: i2c-qcom-geni: Fix suspend clock handling

On 7/9/2018 5:49 PM, Evan Green wrote: > pm_runtime_suspended can return 0 even if the last runtime power > management function called in the device was a suspend call. This > trips up the i2c-qcom-geni's suspend_noirq accounting, which was > trying to use the function to determine if it should

Re: [PATCH v5 4/4] arm64: dts: sdm845: Add serial console support

quot;se" in v3 of the GENI patchset, with that this boots nicely again. Thanks Bjorn for testing. Karthik, it would be good if you could include just this patch from this series as part of your GENI series for the next (and subsequent) repost, with updates as needed based on binding c

  1   2   >