t; test this patch, please? Thanks!
> That fixed it, thanks (though the patch was badly wrapped and
> whitespace damaged :-))
can confirm, that patch fixes building from latest net-next also for me.
Here's an updated version.
Regards
/Joachim
diff --git a/include/linux/ind
On Mon, Jan 18, 2021 at 13:53, Nikolay Aleksandrov wrote:
> On 16/01/2021 17:39, Joachim Wiberg wrote:
>> We have discussed at length at work if an IGMP snooping implementation
>> really belongs in the bridge, or if it's better suited as a user space
>> daemon? Simil
br0.
And then there's the issue of detecting and forwarding to a multicast
routing daemon on top of br0. That br0 is not a brport in the MDB, or
that host_joined cannot be set/seen with iproute2 is quite limiting.
These issues can of course be addressed, but are they of interest to
the
No need to call chmod three times when it can do everything at once.
Signed-off-by: Sven Joachim
---
scripts/package/builddeb | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/scripts/package/builddeb b/scripts/package/builddeb
index 91a502bb97e8..6a100c449579 100755
On 2020-10-28 15:00 +0900, Masahiro Yamada wrote:
> On Tue, Oct 27, 2020 at 4:32 AM Sven Joachim wrote:
>>
>> Building 5.10-rc1 in a setgid directory failed with the following
>> error:
>>
>> dpkg-deb: error: control directory has bad permissions 2755 (must be
No need to call chmod three times when it can do everything at once.
Signed-off-by: Sven Joachim
---
scripts/package/builddeb | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/scripts/package/builddeb b/scripts/package/builddeb
index 91a502bb97e8..81ec6414726c 100755
Fixes: 3e8541803624 ("builddeb: Enable rootless builds")
Cc: Guillem Jover
Signed-off-by: Sven Joachim
---
scripts/package/builddeb | 2 ++
1 file changed, 2 insertions(+)
diff --git a/scripts/package/builddeb b/scripts/package/builddeb
index 1b11f8993629..91a502bb97e8 100755
--- a
On 2020-09-15 12:32 +0200, Peter Zijlstra wrote:
> The C3 BusMaster idle code takes lock in a number of places, some deep
> inside the ACPI code. Instead of wrapping it all in RCU_NONIDLE, have
> the driver take over RCU-idle duty and avoid flipping RCU state back
> and forth a lot.
>
> ( by marki
On 2020-08-28 16:42 -0700, Randy Dunlap wrote:
> On 8/28/20 4:16 PM, Brian Vazquez wrote:
>> On Fri, Aug 28, 2020 at 8:12 AM Randy Dunlap wrote:
>>>
>>> On 8/28/20 8:09 AM, Sven Joachim wrote:
>>>> On 2020-08-27 11:12 -0700, Brian Vazquez wrote:
>>&
I usually use "make bindebpkg", but just running "make" is sufficient to
reproduce the problem, as it happens when linking vmlinux.
Cheers,
Sven
> On Mon, Aug 24, 2020 at 1:08 AM Sven Joachim wrote:
>>
>> On 2020-08-22 08:16 +0200, Sven Joachim wrote:
&g
On 2020-08-22 08:16 +0200, Sven Joachim wrote:
> On 2020-08-21 09:23 -0700, Brian Vazquez wrote:
>
>> Hi Sven,
>>
>> Sorry for the late reply, did you still see this after:
>> https://patchwork.ozlabs.org/project/netdev/patch/20200803131948.41736-1-yuehaib...@huawe
b1672e7, so
yes I'm still seeing it.
Cheers,
Sven
> On Mon, Aug 17, 2020 at 12:21 AM Sven Joachim wrote:
>
>> On 2020-07-29 21:27 +1000, Stephen Rothwell wrote:
>>
>> > Hi all,
>> >
>> > After merging the net-next tree, today's linux-
On 2020-07-29 21:27 +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the net-next tree, today's linux-next build (i386 defconfig)
> failed like this:
>
> x86_64-linux-gnu-ld: net/core/fib_rules.o: in function `fib_rules_lookup':
> fib_rules.c:(.text+0x5c6): undefined reference to `fib6_r
On 2019-06-11 22:08 +0300, Thomas Backlund wrote:
> Den 11-06-2019 kl. 20:40, skrev Greg Kroah-Hartman:
>> On Tue, Jun 11, 2019 at 07:33:16PM +0200, Daniel Vetter wrote:
>>> On Tue, Jun 11, 2019 at 5:37 PM Greg Kroah-Hartman
>>> wrote:
>>>> On Tue, Jun 11,
On 2019-06-11 19:33 +0200, Daniel Vetter wrote:
> On Tue, Jun 11, 2019 at 5:37 PM Greg Kroah-Hartman
> wrote:
>> On Tue, Jun 11, 2019 at 03:56:35PM +0200, Sven Joachim wrote:
>> > Commit 1e07d63749 ("drm/nouveau: add kconfig option to turn off nouveau
>> > l
Commit 1e07d63749 ("drm/nouveau: add kconfig option to turn off nouveau
legacy contexts. (v3)") has caused a build failure for me when I
actually tried that option (CONFIG_NOUVEAU_LEGACY_CTX_SUPPORT=n):
,
| Kernel: arch/x86/boot/bzImage is ready (#1)
| Building modules, stage 2.
| MODPOST
On 2018-10-13 10:50 +0200, Greg KH wrote:
> I'm announcing the release of the 3.18.124 kernel.
$Subject inadvertently says 3.18.123, something wrong with your scripts?
Cheers,
Sven
On 2018-08-16 15:05 +0200, Adam Borowski wrote:
> On Thu, Aug 16, 2018 at 12:14:29PM +0200, Greg KH wrote:
>> I'm announcing the release of the 4.18.1 kernel.
>
> I'm afraid that I get a build failure; v4.18 is ok, v4.18.1 fails with:
>
> ld: arch/x86/kvm/x86.o: in function `kvm_get_arch_capabilit
On 2018-08-15 19:01 +0200, Sebastian Gottschall wrote:
> nother issue seen on xscale and as it affects all non SMP configured kernels
>
>
> kernel/cpu.c: In function 'boot_cpu_hotplug_init':
> kernel/cpu.c:2204:28: error: 'struct cpuhp_cpu_state' has no member
> named 'booted_once'
> this_cpu_wr
g and drop AUTO mode") for
gcc-x86_32-has-stack-protector.sh.
Signed-off-by: Sven Joachim
---
scripts/gcc-x86_64-has-stack-protector.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/gcc-x86_64-has-stack-protector.sh
b/scripts/gcc-x86_64-has-stack-protecto
On 2018-03-05 07:38 -0600, Josh Poimboeuf wrote:
> On Mon, Mar 05, 2018 at 11:17:48AM +0100, Peter Zijlstra wrote:
>> On Mon, Mar 05, 2018 at 09:09:31AM +0100, Sven Joachim wrote:
>> > On 2018-03-04 15:15 -0800, Linus Torvalds wrote:
>> >
>> > > Hmm. A re
On 2018-03-04 15:15 -0800, Linus Torvalds wrote:
> Hmm. A reasonably calm week - the biggest change is to the 'kvm-stat'
> tool, not any actual kernel files.
>
> But there's small changes all over, with architecture updates (x86,
> s390, arm, parisc) and drivers (media, md, gpu, sound) being the b
On 2017-11-07 11:55 -0600, Josh Poimboeuf wrote:
> [ Adding Ingo to cc because I believe it was his suggestion to hide the
> guess unwinder behind CONFIG_EXPERT. ]
>
> On Mon, Nov 06, 2017 at 06:27:53PM -0500, Mikulas Patocka wrote:
>> This patch fixes building of 64-bit kernel on 32-bit userspa
left them alone, see https://bugs.debian.org/856547.
The result is an incomplete description of the linux-headers package
in the generated .changes file. Fix it by passing the kernel:debarch
substitution variable to dpkg-genchanges.
Signed-off-by: Sven Joachim
---
scripts/package/builddeb |
On 2016-11-27 00:35 +0100, Adam Borowski wrote:
> On Sat, Nov 26, 2016 at 05:12:35PM +0100, Greg KH wrote:
>> I'm announcing the release of the 4.8.11 kernel.
>
> ... which splats during early boot where 4.8.10 worked fine.
>
> [ 0.00] Linux version 4.8.11+ (kilobyte@umbar) (gcc version 6.2.1
On 2016-11-02 18:20 +0100, Sebastian Andrzej Siewior wrote:
> Debian Woody is pre-gcc3.2 and Sarge ships 3.3 gcc. I tried to compile
> v4.8.6 on Sarge failed due to binutils:
> |arch/x86/entry/entry_32.S: Assembler messages:
> |arch/x86/entry/entry_32.S:379: Error: invalid character '"' in operand
Hi Neil,
On 31 October 2016 at 11:54, Neil Armstrong wrote:
> Add Synopsys Designware MAC Glue layer for the Oxford Semiconductor OX820.
>
> Acked-by: Joachim Eastwood
> Signed-off-by: Neil Armstrong
> ---
> +static int oxnas_dwmac_init(struct oxnas_dwmac *dwmac)
> +{
&
3.242253] stmmac - user ID: 0x11, Synopsys ID: 0x36
[3.247653] Ring mode enabled
[3.251491] DMA HW capability register supported
[3.256336] Enhanced/Alternate descriptors
[3.261537] Enabled extended descriptors
[3.265968] RX Checksum Offload Engine supported (type 2)
[3.272249] TX Checksum insertion supported
[3.276874] Wake-Up On Lan supported
[3.283743] Enable RX Mitigation via HW Watchdog Timer
[3.326701] libphy: stmmac: probed
Synopsys ID: 0x36 and user UD: 0x11, gives us DWMAC version 3.611
regards,
Joachim Eastwood
r?
You will need to add a regmap layer since the PCA21125 is SPI while
the PCF8563 is I2C.
regards,
Joachim Eastwood
ing a new one? If so; send a
patch for rtc-pcf8563 that adds "pca8565" to the set of i2c ids.
regards,
Joachim Eastwood
On 2016-10-29 21:21 +0200, Tomas Janousek wrote:
> On Sat, Oct 29, 2016 at 07:03:30PM +0200, Sven Joachim wrote:
>> I cannot reproduce that, FWIW. Also, arch/x86/entry/vdso/Makefile seems
>> to explicitly filter out -mfentry from the compiler flags, but maybe I
>> mi
On 2016-10-29 12:10 +0200, Tomas Janousek wrote:
> On Mon, Oct 24, 2016 at 07:32:30PM +0200, Sven Joachim wrote:
>> The attached patch works for me with Debian's gcc-6 package.
>
> I tried your patch when building 4.8.5 on an up-to-date Debian testing and
> still got this:
On 2016-10-25 09:30 +0200, Sebastian Andrzej Siewior wrote:
> On 2016-10-24 19:32:30 [+0200], Sven Joachim wrote:
>> On 2016-10-24 09:43 +0200, Sebastian Andrzej Siewior wrote:
>>
>> > On 2016-10-24 09:38:49 [+0200], Sven Joachim wrote:
>> >>
On 2016-10-24 09:43 +0200, Sebastian Andrzej Siewior wrote:
> On 2016-10-24 09:38:49 [+0200], Sven Joachim wrote:
>>
>> But make still fails with it. :-(
>
> try setting CONFIG_CC_STACKPROTECTOR_NONE=y and please let me know if
> the resulting kernel built with v3.2 gcc
On 2016-10-23 12:23 -0700, Joe Perches wrote:
> On Sun, 2016-10-23 at 18:19 +0200, Sven Joachim wrote:
>> On 2016-10-21 23:21 +0200, Adam Borowski wrote:
>> > On Fri, Oct 21, 2016 at 01:16:00PM +0200, Sebastian Andrzej Siewior wrote:
>> > > Debian started to build
On 2016-10-21 23:21 +0200, Adam Borowski wrote:
> On Fri, Oct 21, 2016 at 01:16:00PM +0200, Sebastian Andrzej Siewior wrote:
>> Debian started to build the gcc with --enable-default-pie by default
>
> To be exact: this is since gcc-6 6.2.0-7 dated Tue, 18 Oct 2016 13:53:00 +0200
> on amd64 arm64 a
nd(struct device *dev)
> +{
> + struct net_device *ndev = dev_get_drvdata(dev);
> + struct stmmac_priv *priv = netdev_priv(ndev);
> + struct oxnas_dwmac *dwmac = priv->plat->bsp_priv;
get_stmmac_bsp_priv()
> + int ret;
> +
> + ret = stmmac_suspend(dev);
> + clk_disable_unprepare(dwmac->clk);
> +
> + return ret;
> +}
> +
> +static int oxnas_dwmac_resume(struct device *dev)
> +{
> + struct net_device *ndev = dev_get_drvdata(dev);
> + struct stmmac_priv *priv = netdev_priv(ndev);
> + struct oxnas_dwmac *dwmac = priv->plat->bsp_priv;
get_stmmac_bsp_priv()
> + int ret;
> +
> + ret = oxnas_dwmac_init(dwmac);
> + if (ret)
> + return ret;
> +
> + ret = stmmac_resume(dev);
> +
> + return ret;
> +}
> +#endif /* CONFIG_PM_SLEEP */
With these changes:
Acked-by: Joachim Eastwood
best regards,
Joachim Eastwood
ad. I.e: PM resume/suspend and driver remove.
Shouldn't you call oxnas_dwmac_init() from probe as well?
As it is now it will only be called during PM resume and that can't be right.
> +
> + return stmmac_dvr_probe(&pdev->dev, plat_dat, &stmmac_res);
If stmmac_dvr_probe() fails you should disable your clocks.
regards,
Joachim Eastwood
On 2016-09-15 11:04 -0400, Jerome Glisse wrote:
>> On Mon, Sep 5, 2016 at 10:25 PM, Jerome Glisse wrote:
>> >> Recently I got myself a new laptop with the following integrated GPU:
>> >>
>> >> 00:01.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI]
>> >> Mullins [Radeon R3 Graph
Hi Arvind,
On 20 September 2016 at 12:39, Arvind Yadav wrote:
> From: Arvind Yadav
>
> Free memory mapping, if lpc18xx_ccu_init is not successful.
>
> Signed-off-by: Arvind Yadav
Acked-by: Joachim Eastwood
One comment below:
> ---
> drivers/clk/nxp/clk-lpc18xx-ccu.c |
ion(chip, offset, true);
> }
>
> -static struct gpio_chip lpc18xx_chip = {
> +static const struct gpio_chip lpc18xx_chip = {
> .label = "lpc18xx/43xx-gpio",
> .request= gpiochip_generic_request,
> .free = gpiochip_generic_free,
For lpc18xx:
Acked-by: Joachim Eastwood
regards,
Joachim Eastwood
Recently I got myself a new laptop with the following integrated GPU:
00:01.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI]
Mullins [Radeon R3 Graphics] (rev 40)
I found that hibernation is broken in Linux 4.7+ (it works in Linux 4.6)
and bisected it to commit 274ad65c9d02 ("
Recently I got myself a new laptop with the following integrated GPU:
00:01.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI]
Mullins [Radeon R3 Graphics] (rev 40)
I found that hibernation is broken in Linux 4.7+ (it works in Linux 4.6)
and bisected it to commit 274ad65c9d02 ("
Hi Philipp,
On 24 August 2016 at 15:28, Philipp Zabel wrote:
> Visible only if COMPILE_TEST is enabled, this allows to include the
> driver in build tests.
>
> Cc: Joachim Eastwood
> Signed-off-by: Philipp Zabel
> ---
> drivers/reset/Kconfig | 7 +++
> drivers/re
viewing, avoiding the patch bomb is probably a good thing.
>
> Should go via subsystem tree, I'd think.
>
> Wolfram Sang (1):
> i2c: don't print error when adding adapter fails
For
> drivers/i2c/busses/i2c-lpc2k.c | 4 +---
Acked-by: Joachim Eastwood
regards,
Joachim Eastwood
t = (const void *)of_id->data;
You can retrieve OF match data using of_device_get_match_data(). Saves
you a couple of lines and better explains what your doing.
> + if (parse_dt)
> + err = parse_dt(pdev, pdata, flags);
> + if (err)
> + return ERR_PTR(err);
> +
> + return pdata;
> +}
regards,
Joachim Eastwood
On 1 May 2016 at 12:36, Masahiro Yamada wrote:
> Use devm_reset_controller_register() for the reset controller
> registration and remove the unregister call from the .remove callback.
>
> Signed-off-by: Masahiro Yamada
> ---
Acked-by: Joachim Eastwood
regards,
Joachim Eastwood
RITY_NORMAL) {
> set_event = lpc18xx_pwm->period_event;
> clear_event = lpc18xx_data->duty_event;
> res_action = LPC18XX_PWM_RES_SET;
For the lpc18xx-sct part:
Acked-by: Joachim Eastwood
regards,
Joachim Eastwood
Hi Marc,
On 11 April 2016 at 17:15, Marc Zyngier wrote:
> Hi Joachim,
>
> On 02/04/16 17:35, Joachim Eastwood wrote:
>> Signed-off-by: Joachim Eastwood
>
> As a start, a commit message would be appreciated.
Ops! I wonder where that disappeared to. The previous versio
On 10 April 2016 at 14:47, Joachim Eastwood wrote:
> Hi Cristina,
>
> On 9 April 2016 at 10:24, Cristina Moraru wrote:
>> Add implementation for Maxim MAX5487, MAX5488, MAX5489
>> digital potentiometers.
>>
>> Datasheet:
>> http://datasheets.maximi
27;s you might as well have used spi_write()
directly. I am not telling you to switch, but I don't see the point of
using regmap here.
Which reminds me; for regmap you need to select REGMAP_SPI in your
Kconfig entry.
regards,
Joachim Eastwood
l/mma7455_core.c
> +++ b/drivers/iio/accel/mma7455_core.c
> @@ -55,11 +55,11 @@
>
> struct mma7455_data {
> struct regmap *regmap;
> - struct device *dev;
> };
>
> static int mma7455_drdy(struct mma7455_data *mma7455)
> {
> + struct device *dev = regmap_get
Add binding documentation for NXP LPC1850 GPIO Pin Interrupt (PINT)
controller.
Signed-off-by: Joachim Eastwood
---
.../interrupt-controller/nxp,lpc1850-gpio-pint.txt | 26 ++
1 file changed, 26 insertions(+)
create mode 100644
Documentation/devicetree/bindings/interrupt
Signed-off-by: Joachim Eastwood
---
drivers/irqchip/Kconfig | 5 +
drivers/irqchip/Makefile| 1 +
drivers/irqchip/irq-lpc18xx-gpio-pint.c | 219
3 files changed, 225 insertions(+)
create mode 100644 drivers/irqchip/irq-lpc18xx
in handler
- describe the interrupts property better in dt doc
Joachim Eastwood (2):
irqchip: add lpc18xx gpio pin interrupt driver
devicetree: document NXP LPC1850 PINT irq controller binding
.../interrupt-controller/nxp,lpc1850-gpio-pint.txt | 26 +++
drivers/irqch
-controller@0xe000e100 {
While changing the line it might be good idea to use the standard
'interrupt-controller' name instead.
I posted the same patch couple of days ago, btw.
http://marc.info/?l=devicetree&m=145929088915714&w=2
But I don't care which one that is applied.
regards,
Joachim Eastwood
arch/arm/boot/dts/s3c2416-smdk2416.dtb
| grep -A2 memory
memory {
device_type = "memory";
reg = <0x0 0x0>;
};
--
memory@3000 {
reg = <0x3000 0x400>;
};
regards,
Joachim Eastwood
[1] http://marc.info/?l=linux-arm-kernel&m=145933287125938&w=2
ngpong with it.
>
> A very nice, clean driver. Thanks for your hard work on this.
>
> Note it is in a branch I happy to rebase for the next week, so if Joachim
> in particular would like to add a reviewed by tag, I'd be delighted to append
> it. Often reviewers don'
data->buf[1] = val & 0xFF; /* 8 bits here */
> +
> + err = spi_write(data->spi, data->buf, 2);
> + if (err) {
> + mutex_unlock(&data->lock);
> + return err;
> + }
> + mutex_unlock(&data->lock);
> +
> + return 0;
This last part could be written as:
err = spi_write(data->spi, data->buf, 2);
mutex_unlock(&data->lock);
return err;
Other than the things I noted driver looks good to me.
regards,
Joachim Eastwood
ould be able to check which clocks
the MAC really needs.
Rockchip bindings have two clocks named "mac_clk_rx" and "mac_clk_tx".
These are probably the same as stm32 needs so maybe use these names
and move them into the main doc and update the rockchip binding.
regards,
Joachim Eastwood
've been better if the versioned strings were
> only used to indicate functionality, and not used to bind
> the drivers. But the bindings were set some time ago.
Since Alexandre has not added "snps,dwmac-3.50a" to dwmac-generic
doesn't he use it as you suggest here?
Note that we can not remove all the generic compatible strings from
dwmac-generic because there is one platform that depend on one of
them.
(see arch/arm/boot/dts/exynos5440.dtsi:190)
So we can not remove "snps,dwmac-3.70a" from the dwmac-generic driver
if we want to keep backwards compatibility with exynos5440. But I
guess we could remove the others if we want to.
regards,
Joachim Eastwood
Hi Jonathan,
On 20 March 2016 at 18:25, Jonathan Cameron wrote:
> On 20/03/16 16:12, Joachim Eastwood wrote:
>>> +static int mcp4131_exec(struct mcp4131_data *data,
>>> + u8 addr, u8 cmd,
>>> + u16 val)
>>> +{
>>> +
mutex_unlock(&data->lock);
> + return -EINVAL;
> + }
> + break;
> + default:
> + mutex_unlock(&data->lock);
> + return -EINVAL;
> + }
> +
> + err = mcp4131_exec(data, address, MCP4131_WRITE, val);
> + mutex_unlock(&data->lock);
While this is not a huge function it is usually good practice to keep
the locking scope as small as possible.
So wouldn't this be sufficient here.
mutex_lock(&data->lock);
err = mcp4131_exec(data, address, MCP4131_WRITE, val);
mutex_unlock(&data->lock);
Of course if you are able move the lock into mcp4131_exec this will go away.
regards,
Joachim Eastwood
8xx_pwm_probe(struct platform_device
> *pdev)
> }
>
> lpc18xx_pwm->clk_rate = clk_get_rate(lpc18xx_pwm->pwm_clk);
> + if (!lpc18xx_pwm->clk_rate) {
> + dev_err(&pdev->dev, "pwm clock has no frequency\n");
> +
pc18xx_pwm->clk_rate) {
ret = -EINVAL;
goto disable_pwmclk;
}
I would also prefer an explicit check against 0 here. ie.:
'lpc18xx_pwm->clk_rate == 0'
A dev_err() message would also be nice to have.
regards,
Joachim Eastwood
On 2 March 2016 at 19:13, Rob Herring wrote:
> On Thu, Feb 25, 2016 at 11:04:47PM +0100, Joachim Eastwood wrote:
>> Add binding documentation for NXP LPC1850 GPIO Pin Interrupt (PINT)
>> controller.
>>
>> Signed-off-by: Joachim Eastwood
>> ---
>> ..
Hi Stephen,
On 1 March 2016 at 19:59, Stephen Boyd wrote:
> This flag is a no-op now. Remove usage of the flag.
>
> Cc: Joachim Eastwood
> Signed-off-by: Stephen Boyd
> ---
Acked-by: Joachim Eastwood
Hi Thomas,
On 26 February 2016 at 11:26, Thomas Gleixner wrote:
> On Thu, 25 Feb 2016, Joachim Eastwood wrote:
>> +static void lpc18xx_gpio_pint_handler(struct irq_desc *desc)
>> +{
>> + struct lpc18xx_gpio_pint_chip *pint = irq_desc_get_handler_data(desc);
>
.
>
> Signed-off-by: Alexandre TORGUE
Driver looks good now, thanks.
Reviewed-by: Joachim Eastwood
regards,
Joachim Eastwood
;macirq", "eth_wake_irq";
> + clock-names = "stmmaceth", "tx-clk", "rx-clk";
> + clocks = <&rcc 0 25>, <&rcc 0 26>, <&rcc 0 27>;
> + st,syscon = <&syscfg 0x4>;
> + snps,pbl = <8>;
> + snps,mixed-burst;
> + dma-ranges;
> + };
Looks just like any other dwmac-driver binding so:
Acked-by: Joachim Eastwood
regards,
Joachim Eastwood
el or edge trigger and supports
any polarity.
This patch set adds an irqchip driver for the PINT found on lpc18xx.
Joachim Eastwood (2):
irqchip: add lpc18xx gpio pin interrupt driver
devicetree: document NXP LPC1850 PINT irq controller binding
.../interrupt-controller/nxp,lpc1850-gpio-pint
Add binding documentation for NXP LPC1850 GPIO Pin Interrupt (PINT)
controller.
Signed-off-by: Joachim Eastwood
---
.../interrupt-controller/nxp,lpc1850-gpio-pint.txt | 22 ++
1 file changed, 22 insertions(+)
create mode 100644
Documentation/devicetree/bindings/interrupt
y polarity.
Selection of which GPIOs that are connected to the PINT is done by
the lpc18xx pinctrl driver (SCU).
Signed-off-by: Joachim Eastwood
---
drivers/irqchip/Kconfig | 5 +
drivers/irqchip/Makefile| 1 +
drivers/irqchip/irq-lpc18xx-gpio-pi
= 0; func < FUNC_MAX; func++) {
> + for (ngroups = 0, i = 0; i < ARRAY_SIZE(lpc18xx_pins); i++) {
Good catch!
Reviewed-by: Joachim Eastwood
regards,
Joachim Eastwood
Hi Laxman,
On 24 February 2016 at 14:16, Laxman Dewangan wrote:
> Use devm_pinctrl_register() for pin control registration.
>
> Signed-off-by: Laxman Dewangan
> Cc: Joachim Eastwood
> ---
> drivers/pinctrl/pinctrl-lpc18xx.c | 3 +--
> 1 file changed, 1 insertion(+), 2 d
rq", "eth_wake_irq";
> + clock-names = "stmmaceth", "tx-clk", "rx-clk";
> + clocks = <&rcc 0 25>, <&rcc 0 26>, <&rcc 0 27>;
> + st,syscon = <&syscfg 0x4>;
> + snps,pbl = <32>;
Regarding snps,pbl; using 32 here might not give you what you would except.
See comment in dwmac1000_dma_init().
The driver is hard coded to use PBL4X/PBL8X mode. Just a heads up.
regards,
Joachim Eastwood
xit(priv->plat->bsp_priv);
> +
> + return ret;
> +}
> +
> +#ifdef CONFIG_PM_SLEEP
> +static int stm32_dwmac_suspend(struct device *dev)
> +{
> + struct net_device *ndev = dev_get_drvdata(dev);
> + struct stmmac_priv *priv = netdev_priv(ndev);
> + int ret;
> +
> + ret = stmmac_suspend(ndev);
> + stm32_dwmac_exit(priv->plat->bsp_priv);
> +
> + return ret;
> +}
> +
> +static int stm32_dwmac_resume(struct device *dev)
> +{
> + struct net_device *ndev = dev_get_drvdata(dev);
> + struct stmmac_priv *priv = netdev_priv(ndev);
> + int ret;
> +
> + ret = stm32_dwmac_init(priv->plat->bsp_priv);
> + if (ret)
> + goto out_regmap;
> +
> + ret = stmmac_resume(ndev);
> +
> +out_regmap:
> + return ret;
Why the goto?
This could be written:
ret = stm32_dwmac_init(priv->plat->bsp_priv);
if (ret)
return ret;
return stmmac_resume(ndev);
regards,
Joachim Eastwood
On 23 February 2016 at 10:59, Alexandre Torgue
wrote:
> 2016-02-22 22:52 GMT+01:00 Joachim Eastwood :
>> On 22 February 2016 at 15:50, Alexandre Torgue
>> wrote:
>>> 2016-02-13 14:48 GMT+01:00 Joachim Eastwood :
>>>> On 3 February 2016 at
On 22 February 2016 at 03:29, Masahiro Yamada
wrote:
> Hi Joachim,
>
>
> 2016-02-22 6:39 GMT+09:00 Joachim Eastwood :
>> Hi everyone,
>>
>> On 28 December 2015 at 11:10, Masahiro Yamada
>> wrote:
>>> Currently, clk_register() never checks a circular
On 22 February 2016 at 15:50, Alexandre Torgue
wrote:
> 2016-02-13 14:48 GMT+01:00 Joachim Eastwood :
>> On 3 February 2016 at 15:54, Alexandre TORGUE
>> wrote:
>>> + plat_dat->bsp_priv = dwmac;
>>> + plat_dat->init = stm32_dwmac_init;
>&g
manabian/linux-lpc/wiki/LPC18xx-LPC43xx-clocks
All PLLs can feed clock into the dividers and the dividers can feed
clock into the PLLs.
The reason why this is made possible in the CGU is because you can
then choose where to put your divider; either before the PLL or after.
regards,
Joachim Eastwood
On 17 February 2016 at 23:11, Andrew Lunn wrote:
> On Wed, Feb 17, 2016 at 11:02:56PM +0100, Joachim Eastwood wrote:
>> Hi Andrew,
>>
>> On 17 February 2016 at 21:07, Andrew Lunn wrote:
>> > Add a regmap for accessing the EEPROM, and then use that with the
>>
On 17 February 2016 at 23:02, Joachim Eastwood wrote:
> Hi Andrew,
>
> On 17 February 2016 at 21:07, Andrew Lunn wrote:
>> +/*
>> + * Provide a regmap interface, which is registered with the NVMEM
>> + * framework
>> +*/
>> +static int eeprom_93xx46_reg
return err;
> + return 0;
Can be:
return eeprom_93xx46_read(eeprom_93xx46, val, offset, val_size);
Allows you to remove the 'err' variable also.
> +}
> +
> +static int eeprom_93xx46_regmap_write(void *context, const void *data,
> +
onst struct of_device_id stm32_dwmac_match[] = {
> + { .compatible = "st,stm32-dwmac"},
> + { }
> +};
> +MODULE_DEVICE_TABLE(of, stm32_dwmac_match);
> +
> +static struct platform_driver stm32_dwmac_driver = {
> + .probe = stm32_dwmac_probe,
> + .remove = stmmac_pltfr_remove,
Could you implement the .remove callback in your driver instead of
using stmmac_pltfr_remove?
Same reasons as above.
> + .driver = {
> + .name = "stm32-dwmac",
> + .pm = &stmmac_pltfr_pm_ops,
> + .of_match_table = stm32_dwmac_match,
> + },
> +};
> +module_platform_driver(stm32_dwmac_driver);
> +
> +MODULE_AUTHOR("Alexandre Torgue ");
> +MODULE_DESCRIPTION("STMicroelectronics MCU DWMAC Specific Glue layer");
> +MODULE_LICENSE("GPL");
Since you state:
> + * License terms: GNU General Public License (GPL), version 2
You might want to switch use: MODULE_LICENSE("GPL v2");
regards,
Joachim Eastwood
return !(readl(rc->base + offset) & bit);
> }
>
> -static struct reset_control_ops lpc18xx_rgu_ops = {
> +static const struct reset_control_ops lpc18xx_rgu_ops = {
> .reset = lpc18xx_rgu_reset,
> .assert = lpc18xx_rgu_assert,
> .deasser
ers/pwm/pwm-lpc18xx-sct.c
> @@ -249,7 +249,7 @@ static int lpc18xx_pwm_enable(struct pwm_chip *chip,
> struct pwm_device *pwm)
>LPC18XX_PWM_EVSTATEMSK(lpc18xx_data->duty_event),
>LPC18XX_PWM_EVSTATEMSK_ALL);
>
> - if (pwm->polarity == PWM_POLARITY_NORMAL) {
st->dev)->data;
> + of_id = of_match_device(atmel_nand_dt_ids, host->dev);
> + if (!of_id)
> + return -ENODEV;
> + host->caps = of_id->data;
It might be cleaner to use of_device_get_match_data() here.
regards,
Joachim Eastwood
--
To uns
t being built as a module by anyone.
>
> When targetting orphaned modular code in non-modular drivers, this
> came up. Joachim indicated that the driver was actually meant to
> be tristate but ended up bool by accident. So here we make it
> tristate instead of removing the m
On 2015-08-14 18:55 +0200, Greg KH wrote:
> On Thu, Jul 02, 2015 at 10:19:34AM +0200, Dick Snippe wrote:
>> Hello,
>>
>> I'm sorry to bother you with this, but lwn.net reported a rather serious
>> security issue a couple of weeks ago:
>>
>> http://lwn.net/Articles/646590/
>> https://bugzilla.red
l see if I can find the time to test your patch set. Thanks for
working on this.
regards,
Joachim Eastwood
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majord
ble as module and it builds
just fine with 'm'.
Want me send a patch changing it to tristate or will you handle it?
regards,
Joachim Eastwood
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
On 6 August 2015 at 08:46, Shawn Lin wrote:
> DesignWare MMC Controller's transfer mode should be decided
> at runtime instead of compile-time. So we remove this config
> option and read dw_mmc's register to select DMA master.
>
> Signed-off-by: Shawn Lin
Acked-by: J
} else if (trans_mode == 1 || trans_mode == 2) {
> + trans_mode = TRANS_MODE_EDMAC;
> + } else {
> + trans_mode = TRANS_MODE_PIO;
> + goto no_dma;
> + }
> +
> /* Check ADDR_CONFIG bit in HCON to find IDMAC addr
On 11 July 2015 at 01:33, Stephen Boyd wrote:
> Clock provider drivers generally shouldn't include clk.h because
> it's the consumer API. Remove the include here because this is a
> provider driver.
>
> Cc: Joachim Eastwood
> Signed-off-by: Stephen Boyd
Acked
; {
> struct osc_page *opg = cl2osc_page(slice);
> - int rc = 0;
> + int rc;
>
> rc = osc_flush_async_page(env, io, opg);
> return rc;
>
The whole rc variable is kinda useless.
Why not make it just:
return osc_flush_async_page(env, io, opg);
re
d-off-by: Matthias Brugger
I think it looks fine now and I have no further comments, so:
Acked-by: Joachim Eastwood
Hope this can go in for 4.3.
regards,
Joachim Eastwood
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/
gmap;
};
u32 offset;
}
What do you think?
I would also like to see this land so thanks for doing this work Matthias.
Hope some clk maintainer will have the time to look at it soon also.
regards,
Joachim Eastwood
--
To unsubscribe from this list: send the li
2 code (and show that without the patch it doesn't
> build).
>
> From my side I think that makes it good to go.
Since next didn't build for me either I applied this and it works for
the LPC18xx (Cortex-M4) platform.
Tested-by: Joachim Eastwood
regards,
Joachim Eastwood
--
T
LY BIT(3) /* mux can't be changed */
> #define CLK_MUX_ROUND_CLOSEST BIT(4)
> +#define CLK_MUX_USE_REGMAP BIT(5)
Since you are adding both fields and a flag to struct clk_mux it would
be nice if you could update the documentation above the struct
definition in clk-provider.h also.
regards,
Joachim Eastwood
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
1 - 100 of 355 matches
Mail list logo
