[PATCH] arm64: dts: mt2712: Remove un-used property for PCIe

2019-03-18 Thread honghui.zhang
From: Honghui Zhang The "num-lanes" property for PCIe is not used, remove it. Signed-off-by: Honghui Zhang --- arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm64/boot/dts/mediatek/mt2712e.dtsi b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi i

[RFC PATCH v2] PCI/portdrv: Support for subtractive decode bridge

2019-02-13 Thread honghui.zhang
From: Honghui Zhang The Class Code for subtractive decode PCI-to-PCI bridge is 060401h, add one entry to make portdrv support this type bridge. Signed-off-by: Honghui Zhang --- drivers/pci/pcie/portdrv_pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pci/pcie/portdrv_pci.c b

[PATCH v3 2/2] PCI: mediatek: Enlarge PCIe2AHB window size to support 4GB DRAM

2019-01-31 Thread honghui.zhang
From: Honghui Zhang The PCIE_AXI_WINDOW0 defines the translate window size for the request from EP side. Request outside of this window will be treated as unsupported request. Enlarge this window size from fls(0x) to 2^33 to support 8GB translate address range then EP DMA is capable of f

[PATCH v3 0/2] PCI: mediatek: enable whole MMIO range and enlarge the PCIe2AHB window size

2019-01-31 Thread honghui.zhang
From: Honghui Zhang Two patches: patch 1 enable whole MMIO range which also fix the complain of scripts/coccinelle/api/resource_size.cocci patch 2 enlarge the PCIe2AHB window size to support fully access of 4GB DRAM from EP DMA. v3: - update the changlog title for patch1 and update commit mes

[PATCH v3 1/2] PCI: mediatek: Enable the whole memory mapped IO range

2019-01-31 Thread honghui.zhang
From: Honghui Zhang Mediatek's HW assigned a bus address range(typically start from 0x2000_ to 0x2fff_ for both mt2712 and mt7622) for PCIe usage. This bus address range is called memory mapped IO range, when CPU or other HW access those address, PCIe RC HW should response to this access.

[PATCH v2 1/2] PCI: mediatek: Use resource_size function on resource object

2019-01-31 Thread honghui.zhang
From: Honghui Zhang scripts/coccinelle/api/resource_size.cocci complain about the following warning: pcie-mediatek.c:720:13-16: WARNING: Suspicious code. resource_size is maybe missing with mem Use resource_size(mem) instead of mem->end - mem->start to eliminate the complain. Since the MMIO wi

[PATCH v2 2/2] PCI: mediatek: Enlarge PCIe2AHB window size to support 4GB DRAM

2019-01-31 Thread honghui.zhang
From: Honghui Zhang The PCIE_AXI_WINDOW0 defines the translate window size for the request from EP side. Request outside of this window will be treated as unsupported request. Enlarge this window size from fls(0x) to 2^33 to support 8GB translate address range then EP DMA is capable of f

[PATCH v2 0/2] PCI: mediatek: fix warning and enlarge the PCIe2AHB window size

2019-01-31 Thread honghui.zhang
From: Honghui Zhang Two patches: patch 1 fix the complain of scripts/coccinelle/api/resource_size.cocci patch 2 enlarge the PCIe2AHB window size to support fully access of 4GB DRAM from EP DMA. v2: - Fix the checkpatch complains for patch 1. - update the commit message and change title of pat

[PATCH] PCI: Mediatek: Use resource_size function on resource object

2019-01-01 Thread honghui.zhang
From: Honghui Zhang drivers/pci/pcie-mediatek.c:720:13-16: WARNING: Suspicious code. resource_size is maybe missing with mem Generated by: scripts/coccinelle/api/resource_size.cocci Signed-off-by: Honghui Zhang --- drivers/pci/controller/pcie-mediatek.c | 4 +--- 1 file changed, 1 insertion(

[RFC PATCH] PCI/portdrv: Support for subtractive decode bridge

2018-12-13 Thread honghui.zhang
From: Honghui Zhang The Class Code for subtractive decode PCI-to-PCI bridge is 060401h, change the class_mask values to make portdrv support this type bridge. Signed-off-by: Honghui Zhang --- drivers/pci/pcie/portdrv_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dri

[PATCH 1/4] PCI: mediatek: Remove un-used variant in struct mtk_pcie_port

2018-12-13 Thread honghui.zhang
From: Honghui Zhang The "lane" variant in struct mtk_pcie_port is not used, remove it. Signed-off-by: Honghui Zhang --- drivers/pci/controller/pcie-mediatek.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/pci/controller/pcie-mediatek.c b/drivers/pci/controller/pcie-mediat

[PATCH 2/4] dt-bindings: PCI: MediaTek: Remove un-used property

2018-12-13 Thread honghui.zhang
From: Honghui Zhang The "num-lanes" property is not used, remove it. Signed-off-by: Honghui Zhang --- Documentation/devicetree/bindings/pci/mediatek-pcie.txt | 8 1 file changed, 8 deletions(-) diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie.txt b/Documentation/devi

[PATCH 4/4] arm64: dts: mt7622: Remove un-used property for PCIe

2018-12-13 Thread honghui.zhang
From: Honghui Zhang The "num-lanes" property for PCIe is not used, remove it. Signed-off-by: Honghui Zhang --- arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi inde

[PATCH 3/4] arm: dts: mt7623: Remove un-used property for PCIe

2018-12-13 Thread honghui.zhang
From: Honghui Zhang The "num-lanes" property for PCIe is not used, remove it. Signed-off-by: Honghui Zhang --- arch/arm/boot/dts/mt7623.dtsi | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/arm/boot/dts/mt7623.dtsi b/arch/arm/boot/dts/mt7623.dtsi index 1cdc346..4ca56d8 100644 --- a/a

[PATCH 0/4] Cleanup un-used variant and un-used property for MediaTek PCIe

2018-12-13 Thread honghui.zhang
From: Honghui Zhang The "num-lanes" property in MediaTek's PCIe device node is not used by its driver or anyone else, cleanup those related code. Honghui Zhang (4): PCI: mediatek: Remove un-used variant in struct mtk_pcie_port dt-bindings: PCI: MediaTek: Remove un-used property arm: dts: m

[PATCH v3] PCI: mediatek: Use devm_of_pci_get_host_bridge_resources() to parse DT

2018-11-29 Thread honghui.zhang
From: Honghui Zhang Use the devm_of_pci_get_host_bridge_resources() API in place of the PCI OF DT parser. Signed-off-by: Honghui Zhang Acked-by: Ryder Lee --- drivers/pci/controller/pcie-mediatek.c | 101 + 1 file changed, 27 insertions(+), 74 deletions(-) dif

[PATCH v2] PCI: mediatek: Use devm_of_pci_get_host_bridge_resources() to parse DT

2018-11-07 Thread honghui.zhang
From: Honghui Zhang Use the devm_of_pci_get_host_bridge_resources() API in place of the PCI OF DT parser. Signed-off-by: Honghui Zhang --- drivers/pci/controller/pcie-mediatek.c | 98 +- 1 file changed, 24 insertions(+), 74 deletions(-) diff --git a/drivers/pci

[PATCH] PCI: mediatek: Use devm_of_pci_get_host_bridge_resources() to parse DT

2018-10-17 Thread honghui.zhang
From: Honghui Zhang Use the devm_of_pci_get_host_bridge_resources() API in place of the PCI OF DT parser. Signed-off-by: Honghui Zhang --- drivers/pci/controller/pcie-mediatek.c | 109 + 1 file changed, 29 insertions(+), 80 deletions(-) diff --git a/drivers/pci

[PATCH v9 3/9] PCI: mediatek: Remove the redundant dev->pm_domain check

2018-10-16 Thread honghui.zhang
From: Honghui Zhang It's no needed to check whether device have pm_domain attached before calling the pm_runtime_XXX interface, remove it. Signed-off-by: Honghui Zhang Acked-by: Ryder Lee --- drivers/pci/controller/pcie-mediatek.c | 18 ++ 1 file changed, 6 insertions(+), 12 d

[PATCH v9 1/9] PCI: mediatek: Using slot's devfn for compare to fix mtk_pcie_find_port logic

2018-10-16 Thread honghui.zhang
From: Honghui Zhang The Mediatek's host controller has two slots, each with it's own control registers. The host driver need to identify which slot was connected in order to access the device's configuration space. There's problem for current host driver to find out which slot was connected to fo

[PATCH v9 2/9] PCI: Using PCI configuration space header type instead of class type to assign resource

2018-10-16 Thread honghui.zhang
From: Honghui Zhang The PCI configuration space header type defines the layout of the rest of the header (PCI r3.0 sec 6.1, PCIe r4.0 sec 7.5.1.1.9) while the resource assignment is based on the configuration space layout instead of its class type. Using configuration space header type instead of

[PATCH v9 5/9] PCI: mediatek: Move the mtk_pcie_startup_port_v2 function's define after mtk_pcie_setup_irq

2018-10-16 Thread honghui.zhang
From: Honghui Zhang This is a prepare patch to fix enable MSI logic, move the function's define later to avoid forward declaration of mtk_pcie_enable_msi in the future. No functional changed. Signed-off-by: Honghui Zhang Acked-by: Ryder Lee --- drivers/pci/controller/pcie-mediatek.c | 138 +++

[PATCH v9 8/9] PCI: mediatek: Save the GIC IRQ in mtk_pcie_port

2018-10-16 Thread honghui.zhang
From: Honghui Zhang Need to save the PCIe's GIC IRQ for dispose_irq, this is a prepare patch for add mediatek PCIe module support to tear down the IRQ, no functional changed. Signed-off-by: Honghui Zhang Acked-by: Ryder Lee --- drivers/pci/controller/pcie-mediatek.c | 9 ++--- 1 file chan

[PATCH v9 7/9] PCI: mediatek: Add system PM support for MT2712 and MT7622

2018-10-16 Thread honghui.zhang
From: Honghui Zhang In order to reduce the PCIe power consuming while system suspend, the physical layer should be gated. And the PCIe link should be re-established and the related control register values should be re-initialized after system resume. Register suspend_noirq & resume_noirq callbac

[PATCH v9 0/9] PCI: mediatek: fixup find_port, enable_msi and add PM, module support

2018-10-16 Thread honghui.zhang
From: Honghui Zhang This patchset includes misc patchs: The patch 1 fixup the mtk_pcie_find_port logic which will cause system could not touch the EP's configuration space that connected to PCIe slot 1. The patch fixup the PCI core defect which assign resource base on device's class type. Logic

[PATCH v9 4/9] PCI: mediatek: Convert to use pci_host_probe()

2018-10-16 Thread honghui.zhang
From: Honghui Zhang Part of mtk_pcie_register_host is an open-coded version of pci_host_probe(). So instead of duplicating this code, use pci_host_probe() directly and remove mtk_pcie_register_host. Signed-off-by: Honghui Zhang Acked-by: Ryder Lee --- drivers/pci/controller/pcie-mediatek.c |

[PATCH v9 6/9] PCI: mediatek: Fixup enable MSI logic by enable MSI after clock enabled

2018-10-16 Thread honghui.zhang
From: Honghui Zhang The commit 43e6409db64d ("PCI: mediatek: Add MSI support for MT2712 and MT7622") added MSI support but enable MSI in wrong place, clocks was not enabled when enable MSI. This patch fix this issue by calling mtk_pcie_enable_msi in mtk_pcie_startup_port_v2 since the clock was al

[PATCH v9 9/9] PCI: mediatek: Add loadable kernel module support

2018-10-16 Thread honghui.zhang
From: Honghui Zhang Implement remove callback function for Mediatek PCIe driver to add loadable kernel module support. Signed-off-by: Honghui Zhang Reviewed-by: Ryder Lee --- drivers/pci/controller/Kconfig | 2 +- drivers/pci/controller/pcie-mediatek.c | 51 ++

[PATCH v8 7/9] PCI: mediatek: Add system PM support for MT2712 and MT7622

2018-10-15 Thread honghui.zhang
From: Honghui Zhang In order to reduce the PCIe power consuming while system suspend, the physical layer should be gated. And the PCIe link should be re-established and the related control register values should be re-initialized after system resume. Register suspend_noirq & resume_noirq callbac

[PATCH v8 6/9] PCI: mediatek: Fixup enable MSI logic by enable MSI after clock enabled

2018-10-15 Thread honghui.zhang
From: Honghui Zhang The commit 43e6409db64d ("PCI: mediatek: Add MSI support for MT2712 and MT7622") added MSI support but enable MSI in wrong place, clocks was not enabled when enable MSI. This patch fix this issue by calling mtk_pcie_enable_msi in mtk_pcie_startup_port_v2 since the clock was al

[PATCH v8 2/9] PCI: mediatek: Fix class type for MT7622 as PCI_CLASS_BRIDGE_PCI

2018-10-15 Thread honghui.zhang
From: Honghui Zhang The commit 101c92dc80c8 ("PCI: mediatek: Set up vendor ID and class type for MT7622") have set the class type for MT7622 as un-properly value of PCI_CLASS_BRIDGE_HOST. The PCIe controller of MT7622 is complexed with Root Port and PCI-to-PCI bridge, the bridge has type 1 confi

[PATCH v8 1/9] PCI: mediatek: Using slot's devfn for compare to fix mtk_pcie_find_port logic

2018-10-15 Thread honghui.zhang
From: Honghui Zhang The Mediatek's host controller has two slots, each with it's own control registers. The host driver need to identify which slot was connected in order to access the device's configuration space. There's problem for current host driver to find out which slot was connected to fo

[PATCH v8 8/9] PCI: mediatek: Save the GIC IRQ in mtk_pcie_port

2018-10-15 Thread honghui.zhang
From: Honghui Zhang Need to save the PCIe's GIC IRQ for dispose_irq, this is a prepare patch for add mediatek PCIe module support to tear down the IRQ, no functional changed. Signed-off-by: Honghui Zhang Acked-by: Ryder Lee --- drivers/pci/controller/pcie-mediatek.c | 9 ++--- 1 file chan

[PATCH v8 5/9] PCI: mediatek: Move the mtk_pcie_startup_port_v2 function's define after mtk_pcie_setup_irq

2018-10-15 Thread honghui.zhang
From: Honghui Zhang This is a prepare patch to fix enable MSI logic, move the function's define later to avoid forward declaration of mtk_pcie_enable_msi in the future. No functional changed. Signed-off-by: Honghui Zhang Acked-by: Ryder Lee --- drivers/pci/controller/pcie-mediatek.c | 138 +++

[PATCH v8 9/9] PCI: mediatek: Add loadable kernel module support

2018-10-15 Thread honghui.zhang
From: Honghui Zhang Implement remove callback function for Mediatek PCIe driver to add loadable kernel module support. Signed-off-by: Honghui Zhang Reviewed-by: Ryder Lee --- drivers/pci/controller/Kconfig | 2 +- drivers/pci/controller/pcie-mediatek.c | 51 ++

[PATCH v8 3/9] PCI: mediatek: Remove the redundant dev->pm_domain check

2018-10-15 Thread honghui.zhang
From: Honghui Zhang It's no needed to check whether device have pm_domain attached before calling the pm_runtime_XXX interface, remove it. Signed-off-by: Honghui Zhang Acked-by: Ryder Lee --- drivers/pci/controller/pcie-mediatek.c | 18 ++ 1 file changed, 6 insertions(+), 12 d

[PATCH v8 0/9] PCI: mediatek: fixup find_port, enable_msi and add PM, module support

2018-10-15 Thread honghui.zhang
From: Honghui Zhang This patchset includes misc patchs: The patch 1 fixup the mtk_pcie_find_port logic which will cause system could not touch the EP's configuration space that connected to PCIe slot 1. The patch 2 fixup the class type for MT7622. The patch 6 fixup the enable msi logic, the ope

[PATCH v8 4/9] PCI: mediatek: Convert to use pci_host_probe()

2018-10-15 Thread honghui.zhang
From: Honghui Zhang Part of mtk_pcie_register_host is an open-coded version of pci_host_probe(). So instead of duplicating this code, use pci_host_probe() directly and remove mtk_pcie_register_host. Signed-off-by: Honghui Zhang Acked-by: Ryder Lee --- drivers/pci/controller/pcie-mediatek.c |

[PATCH v7 6/9] PCI: mediatek: Fixup enable MSI logic by enable MSI after clock enabled

2018-10-14 Thread honghui.zhang
From: Honghui Zhang The commit 43e6409db64d ("PCI: mediatek: Add MSI support for MT2712 and MT7622") added MSI support but enable MSI in wrong place, clocks was not enabled when enable MSI. This patch fix this issue by calling mtk_pcie_enable_msi in mtk_pcie_startup_port_v2 since the clock was al

[PATCH v7 3/9] PCI: mediatek: Remove the redundant dev->pm_domain check

2018-10-14 Thread honghui.zhang
From: Honghui Zhang It's no needed to check whether device have pm_domain attached before calling the pm_runtime_XXX interface, remove it. Signed-off-by: Honghui Zhang --- drivers/pci/controller/pcie-mediatek.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --g

[PATCH v7 8/9] PCI: mediatek: Save the GIC IRQ in mtk_pcie_port

2018-10-14 Thread honghui.zhang
From: Honghui Zhang Need to save the PCIe's GIC IRQ for dispose_irq, this is a prepare patch for add mediatek PCIe module support to tear down the IRQ, no functional changed. Signed-off-by: Honghui Zhang --- drivers/pci/controller/pcie-mediatek.c | 9 ++--- 1 file changed, 6 insertions(+),

[PATCH v7 5/9] PCI: mediatek: Move the mtk_pcie_startup_port_v2 function's define after mtk_pcie_setup_irq

2018-10-14 Thread honghui.zhang
From: Honghui Zhang This is a prepare patch to fix enable MSI logic, move the function's define later to avoid forward declaration of mtk_pcie_enable_msi in the future. No functional changed. Signed-off-by: Honghui Zhang --- drivers/pci/controller/pcie-mediatek.c | 138

[PATCH v7 2/9] PCI: mediatek: Fix class type for MT7622 as PCI_CLASS_BRIDGE_PCI

2018-10-14 Thread honghui.zhang
From: Honghui Zhang The commit 101c92dc80c8 ("PCI: mediatek: Set up vendor ID and class type for MT7622") have set the class type for MT7622 as un-properly value of PCI_CLASS_BRIDGE_HOST. The PCIe controller of MT7622 is complexed with Root Port and PCI-to-PCI bridge, the bridge has type 1 confi

[PATCH v7 9/9] PCI: mediatek: Add loadable kernel module support

2018-10-14 Thread honghui.zhang
From: Honghui Zhang Implement remove callback function for Mediatek PCIe driver to add loadable kernel module support. Signed-off-by: Honghui Zhang Reviewed-by: Ryder Lee --- drivers/pci/controller/Kconfig | 2 +- drivers/pci/controller/pcie-mediatek.c | 51 ++

[PATCH v7 1/9] PCI: mediatek: Using slot's devfn for compare to fix mtk_pcie_find_port logic

2018-10-14 Thread honghui.zhang
From: Honghui Zhang The Mediatek's host controller has two slots, each with it's own control registers. The host driver need to identify which slot was connected in order to access the device's configuration space. There's problem for current host driver to find out which slot was connected to fo

[PATCH v7 7/9] PCI: mediatek: Add system PM support for MT2712 and MT7622

2018-10-14 Thread honghui.zhang
From: Honghui Zhang In order to reduce the PCIe power consuming while system suspend, the physical layer should be gated. And the PCIe link should be re-established and the related control register values should be re-initialized after system resume. Register suspend_noirq & resume_noirq callbac

[PATCH v7 0/9] PCI: mediatek: fixup find_port, enable_msi and add PM, module support

2018-10-14 Thread honghui.zhang
From: Honghui Zhang This patchset includes misc patchs: The patch 1 fixup the mtk_pcie_find_port logic which will cause system could not touch the EP's configuration space that connected to PCIe slot 1. The patch 2 fixup the class type for MT7622. The patch 6 fixup the enable msi logic, the ope

[PATCH v7 4/9] PCI: mediatek: Convert to use pci_host_probe()

2018-10-14 Thread honghui.zhang
From: Honghui Zhang Part of mtk_pcie_register_host is an open-coded version of pci_host_probe(). So instead of duplicating this code, use pci_host_probe() directly and remove mtk_pcie_register_host. Signed-off-by: Honghui Zhang --- drivers/pci/controller/pcie-mediatek.c | 37 --

[PATCH v6 9/9] PCI: mediatek: Add loadable kernel module support

2018-10-07 Thread honghui.zhang
From: Honghui Zhang Implement remove callback function for Mediatek PCIe driver to add loadable kernel module support. Signed-off-by: Honghui Zhang Reviewed-by: Ryder Lee --- drivers/pci/controller/Kconfig | 2 +- drivers/pci/controller/pcie-mediatek.c | 52 ++

[PATCH v6 2/9] PCI: mediatek: Fixup class ID for MT7622 as PCI_CLASS_BRIDGE_PCI

2018-10-07 Thread honghui.zhang
From: Honghui Zhang The PCIe controller of MT7622 has TYPE 1 configuration space type, but the HW default class type values is invalid. The commit 101c92dc80c8 ("PCI: mediatek: Set up vendor ID and class type for MT7622") have set the class ID for MT7622 as PCI_CLASS_BRIDGE_HOST, but it's not wo

[PATCH v6 3/9] PCI: mediatek: Remove the redundant dev->pm_domain check

2018-10-07 Thread honghui.zhang
From: Honghui Zhang It's no needed to check whether device have pm_domain attached before calling the pm_runtime_XXX interface, remove it. Signed-off-by: Honghui Zhang Acked-by: Ryder Lee --- drivers/pci/controller/pcie-mediatek.c | 18 ++ 1 file changed, 6 insertions(+), 12 d

[PATCH v6 4/9] PCI: mediatek: Convert to use pci_host_probe()

2018-10-07 Thread honghui.zhang
From: Honghui Zhang Part of mtk_pcie_register_host is an open-coded version of pci_host_probe(). So instead of duplicating this code, use pci_host_probe() directly and remove mtk_pcie_register_host. Signed-off-by: Honghui Zhang Acked-by: Ryder Lee --- drivers/pci/controller/pcie-mediatek.c |

[PATCH v6 7/9] PCI: mediatek: Add system pm support for MT2712 and MT7622

2018-10-07 Thread honghui.zhang
From: Honghui Zhang In order to reduce the PCIe power consuming while system suspend, the physical layer should be gated. And the PCIe link should be re-established and the related control register values should be re-initialized after system resume. Register suspend_noirq & resume_noirq callbac

[PATCH v6 8/9] PCI: mediatek: Save the GIC IRQ in mtk_pcie_port

2018-10-07 Thread honghui.zhang
From: Honghui Zhang Need to save the PCIe's GIC IRQ for dispose_irq, this is a prepare patch for add mediatek PCIe module support to tear down the IRQ, no functional changed. Signed-off-by: Honghui Zhang Acked-by: Ryder Lee --- drivers/pci/controller/pcie-mediatek.c | 9 ++--- 1 file chan

[PATCH v6 5/9] PCI: mediatek: Move the mtk_pcie_startup_port_v2 function's define after mtk_pcie_setup_irq

2018-10-07 Thread honghui.zhang
From: Honghui Zhang This is a prepare patch to fix enable MSI logic, move the function's define later to avoid forward declaration of mtk_pcie_enable_msi in the future. No functional changed. Signed-off-by: Honghui Zhang Acked-by: Ryder Lee --- drivers/pci/controller/pcie-mediatek.c | 138 +++

[PATCH v6 1/9] PCI: mediatek: Using slot's devfn for compare to fix mtk_pcie_find_port logic

2018-10-07 Thread honghui.zhang
From: Honghui Zhang The Mediatek's host controller has two slots, each with it's own control registers. The host driver need to identify which slot was connected in order to access the device's configuration space. There's problem for current host driver to find out which slot was connected to fo

[PATCH v6 6/9] PCI: mediatek: Fixup enable msi logic by enable msi after clock enabled

2018-10-07 Thread honghui.zhang
From: Honghui Zhang The commit 43e6409db64d ("PCI: mediatek: Add MSI support for MT2712 and MT7622") added MSI support but enable MSI in wrong place, clocks was not enabled when enable MSI. This patch fix this issue by calling mtk_pcie_enable_msi in mtk_pcie_startup_port_v2 since the clock was al

[PATCH v6 0/9] PCI: mediatek: fixup find_port, enable_msi and add pm, module support

2018-10-07 Thread honghui.zhang
From: Honghui Zhang This patchset includes misc patchs: The patch 1 fixup the mtk_pcie_find_port logic which will cause system could not touch the EP's configuration space that connected to PCIe slot 1. The patch 2 fixup the class type for MT7622. The patch 6 fixup the enable msi logic, the ope

[PATCH v5 4/9] PCI: mediatek: Convert to use pci_host_probe()

2018-09-28 Thread honghui.zhang
From: Honghui Zhang Part of mtk_pcie_register_host is an open-coded version of pci_host_probe(). So instead of duplicating this code, use pci_host_probe() directly and remove mtk_pcie_register_host. Signed-off-by: Honghui Zhang --- drivers/pci/controller/pcie-mediatek.c | 37 --

[PATCH v5 3/9] PCI: mediatek: Remove the redundant dev->pm_domain check

2018-09-28 Thread honghui.zhang
From: Honghui Zhang It's no needed to check whether device have pm_domain attached before calling the pm_runtime_XXX interface, remove it. Signed-off-by: Honghui Zhang --- drivers/pci/controller/pcie-mediatek.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --g

[PATCH v5 2/9] PCI: mediatek: Fixup class ID for MT7622 as PCI_CLASS_BRIDGE_PCI

2018-09-28 Thread honghui.zhang
From: Honghui Zhang The PCIe controller of MT7622 has TYPE 1 configuration space type, but the HW default class type values is invalid. The commit 101c92dc80c8 ("PCI: mediatek: Set up vendor ID and class type for MT7622") have set the class ID for MT7622 as PCI_CLASS_BRIDGE_HOST, but it's not wo

[PATCH v5 7/9] PCI: mediatek: Add system pm support for MT2712 and MT7622

2018-09-28 Thread honghui.zhang
From: Honghui Zhang In order to reduce the PCIe power consuming while system suspend, the physical layer should be gated. And the PCIe link should be re-established and the related control register values should be re-initialized after system resume. Register suspend_noirq & resume_noirq callbac

[PATCH v5 5/9] PCI: mediatek: Move the mtk_pcie_startup_port_v2 function's define after mtk_pcie_setup_irq

2018-09-28 Thread honghui.zhang
From: Honghui Zhang This is a prepare patch to fix enable MSI logic, move the function's define later to avoid forward declaration of mtk_pcie_enable_msi in the future. No functional changed. Signed-off-by: Honghui Zhang --- drivers/pci/controller/pcie-mediatek.c | 138

[PATCH v5 8/9] PCI: mediatek: Save the GIC IRQ in mtk_pcie_port

2018-09-28 Thread honghui.zhang
From: Honghui Zhang Need to save the PCIe's GIC IRQ for dispose_irq, this is a prepare patch for add mediatek PCIe module support to tear down the IRQ, no functional changed. Signed-off-by: Honghui Zhang --- drivers/pci/controller/pcie-mediatek.c | 9 ++--- 1 file changed, 6 insertions(+),

[PATCH v5 0/9] PCI: mediatek: fixup find_port, enable_msi and add pm, module support

2018-09-28 Thread honghui.zhang
From: Honghui Zhang This patchset includes misc patchs: The patch 1 fixup the mtk_pcie_find_port logic which will cause system could not touch the EP's configuration space that connected to PCIe slot 1. The patch 2 fixup the class type for MT7622. The patch 6 fixup the enable msi logic, the ope

[PATCH v5 1/9] PCI: mediatek: Using slot's devfn for compare to fix mtk_pcie_find_port logic

2018-09-28 Thread honghui.zhang
From: Honghui Zhang The Mediatek's host controller has two slots, each with it's own control registers. The host driver need to identify which slot was connected in order to access the device's configuration space. There's problem for current host driver to find out which slot was connected to fo

[PATCH v5 6/9] PCI: mediatek: Enable msi after clock enabled

2018-09-28 Thread honghui.zhang
From: Honghui Zhang The clocks was not enabled when enable MSI. This patch fix this issue by calling mtk_pcie_enable_msi in mtk_pcie_startup_port_v2 since the clock was all enabled at that time. Signed-off-by: Honghui Zhang --- drivers/pci/controller/pcie-mediatek.c | 5 +++-- 1 file changed,

[PATCH v5 9/9] PCI: mediatek: Add loadable kernel module support

2018-09-28 Thread honghui.zhang
From: Honghui Zhang Implement remove callback function for Mediatek PCIe driver to add loadable kernel module support. Signed-off-by: Honghui Zhang --- drivers/pci/controller/Kconfig | 2 +- drivers/pci/controller/pcie-mediatek.c | 52 +- 2 files change

[PATCH v4 0/4] PCI: mediatek: fixup find_port, enable_msi and add pm, module support

2018-09-10 Thread honghui.zhang
From: Honghui Zhang This patchset includes misc patchs: The first patch fixup the mtk_pcie_find_port logical which will cause system could not touch the EP's configuration space which was connected to PCIe slot 1. The second patch fixup the enable msi logical, the operation to enable msi should

[PATCH v4 3/4] PCI: mediatek: Add system pm support for MT2712 and MT7622

2018-09-10 Thread honghui.zhang
From: Honghui Zhang The MTCMOS of PCIe Host for MT2712 and MT7622 will be off when system suspend, and all the internal control register will be reset after system resume. The PCIe link should be re-established and the related control register values should be re-set after system resume. Signed-

[PATCH v4 4/4] PCI: mediatek: Add loadable kernel module support

2018-09-10 Thread honghui.zhang
From: Honghui Zhang Implement remove callback function for Mediatek PCIe driver to add loadable kernel module support. Signed-off-by: Honghui Zhang Reviewed-by: Ryder Lee --- drivers/pci/controller/Kconfig | 2 +- drivers/pci/controller/pcie-mediatek.c | 60 ++

[PATCH v4 1/4] PCI: mediatek: fixup mtk_pcie_find_port logical

2018-09-10 Thread honghui.zhang
From: Honghui Zhang The Mediatek's host controller has two slots, each with it's own control registers. The host driver need to identify which slot was connected in order to access the device's configuration space. There's problem for current host driver to find out which slot was connected to fo

[PATCH v4 2/4] PCI: mediatek: enable msi after clock enabled

2018-09-10 Thread honghui.zhang
From: Honghui Zhang The clocks was not enabled when enable MSI. This patch fix this issue by calling mtk_pcie_enable_msi in mtk_pcie_startup_port_v2 since the clock was all enabled at that time. The function of mtk_pcie_startup_port_v2's define location is re-arranged to avoid mtk_pcie_enable_ms

[PATCH v3 2/4] PCI: mediatek: enable msi after clock enabled

2018-07-02 Thread honghui.zhang
From: Honghui Zhang The clocks was not enabled when enable MSI. This patch fix this issue by calling mtk_pcie_enable_msi in mtk_pcie_startup_port_v2 since the clock was all enabled at that time. The function of mtk_pcie_startup_port_v2's define location is re-arranged to avoid mtk_pcie_enable_ms

[PATCH v3 1/4] PCI: mediatek: fixup mtk_pcie_find_port logical

2018-07-02 Thread honghui.zhang
From: Honghui Zhang The Mediatek's host controller has two slots, each with it's own control registers. The host driver need to identify which slot was connected in order to access the device's configuration space. There's problem for current host driver to find out which slot was connected to fo

[PATCH v3 3/4] PCI: mediatek: Add system pm support for MT2712 and MT7622

2018-07-02 Thread honghui.zhang
From: Honghui Zhang The MTCMOS of PCIe Host for MT2712 and MT7622 will be off when system suspend, and all the internal control register will be reset after system resume. The PCIe link should be re-established and the related control register values should be re-set after system resume. Signed-

[PATCH v3 0/4] PCI: mediatek: fixup find_port, enable_msi and add pm, module support

2018-07-02 Thread honghui.zhang
From: Honghui Zhang This patchset includes misc patchs: The first patch fixup the mtk_pcie_find_port logical which will cause system could not touch the EP's configuration space which was connected to PCIe slot 1. The second patch fixup the enable msi logical, the operation to enable msi should

[PATCH v3 4/4] PCI: mediatek: Add loadable kernel module support

2018-07-02 Thread honghui.zhang
From: Honghui Zhang Implement remove callback function for Mediatek PCIe driver to add loadable kernel module support. Signed-off-by: Honghui Zhang Reviewed-by: Ryder Lee --- drivers/pci/controller/Kconfig | 2 +- drivers/pci/controller/pcie-mediatek.c | 60 ++

[PATCH v2 3/4] PCI: mediatek: Add system pm support for MT2712 and MT7622

2018-07-01 Thread honghui.zhang
From: Honghui Zhang The MTCMOS of PCIe Host for MT2712 and MT7622 will be off when system suspend, and all the internal control register will be reset after system resume. The PCIe link should be re-established and the related control register values should be re-set after system resume. Signed-

[PATCH v2 1/4] PCI: mediatek: fixup mtk_pcie_find_port logical

2018-07-01 Thread honghui.zhang
From: Honghui Zhang The Mediatek's host controller has two slots, each with it's own control registers. The host driver need to identify which slot was connected in order to access the device's configuration space. There's problem for current host driver to find out which slot was connected to fo

[PATCH v2 4/4] PCI: mediatek: Add loadable kernel module support

2018-07-01 Thread honghui.zhang
From: Honghui Zhang Implement remove callback function for Mediatek PCIe driver to add loadable kernel module support. Signed-off-by: Honghui Zhang --- drivers/pci/controller/Kconfig | 2 +- drivers/pci/controller/pcie-mediatek.c | 60 +++--- 2 files change

[PATCH v2 2/4] PCI: mediatek: enable msi after clock enabled

2018-07-01 Thread honghui.zhang
From: Honghui Zhang The clocks was not enabled when enable MSI. This patch fix this issue by calling mtk_pcie_enable_msi in mtk_pcie_startup_port_v2 since the clock was all enabled at that time. The function of mtk_pcie_startup_port_v2's define location is re-arranged to avoid mtk_pcie_enable_ms

[PATCH v2 0/4] PCI: mediatek: fixup find_port, enable_msi and add pm, module support

2018-07-01 Thread honghui.zhang
From: Honghui Zhang This patchset includes misc patchs: The first patch fixup the mtk_pcie_find_port logical which will cause system could not touch the EP's configuration space which was connected to PCIe slot 1. The second patch fixup the enable msi logical, the operation to enable msi should

[PATCH 1/4] PCI: mediatek: fixup mtk_pcie_find_port logical

2018-06-27 Thread honghui.zhang
From: Honghui Zhang Mediatek's host controller have two slots, each have it's own control registers. The host driver need to identify which slot was connected in order to access the device's configuration space. There's problem for current host driver to find out which slot was connected to for a

[PATCH 2/4] PCI: mediatek: enable msi after clock enabled

2018-06-27 Thread honghui.zhang
From: Honghui Zhang The clocks was not enabled when enable MSI. This patch fix this issue by calling mtk_pcie_enable_msi in mtk_pcie_startup_port_v2 since the clock was all enabled at that time. The function of mtk_pcie_startup_port_v2's define location is re-arranged to avoid mtk_pcie_enable_ms

[PATCH 3/4] PCI: mediatek: Add system pm support for MT2712 and MT7622

2018-06-27 Thread honghui.zhang
From: Honghui Zhang The MTCMOS of PCIe Host for MT2712 and MT7622 will be off when system suspend, and all the internal control register will be reset after system resume. The PCIe link should be re-established and the related control register values should be re-set after system resume. Signed-

[PATCH 4/4] PCI: mediatek: Add loadable kernel module support

2018-06-27 Thread honghui.zhang
From: Honghui Zhang Implement remove callback function for Mediatek PCIe driver to add loadable kernel module support. Signed-off-by: Honghui Zhang Reviewed-by: Ryder Lee --- drivers/pci/controller/Kconfig | 2 +- drivers/pci/controller/pcie-mediatek.c | 63 ++

[PATCH 0/4] PCI: mediatek: fixup find_port, enable_msi and add pm, module support

2018-06-27 Thread honghui.zhang
From: Honghui Zhang This patchset includes misc patchs: The first patch fixup the mtk_pcie_find_port logical which will cause system could not touch the EP's configuration space which was connected to PCIe slot 1. The second patch fixup the enable msi logical, the operation to enable msi should

[PATCH v4] PCI: mediatek: Add system pm support for MT2712

2018-06-20 Thread honghui.zhang
From: Honghui Zhang The MTCMOS of PCIe Host for MT2712 will be off when system suspend, and all the internal control register will be reset after system resume. The PCIe link should be re-established and the related control register values should be re-set after system resume. Signed-off-by: Hon

[PATCH v3] PCI: mediatek: Add system pm support for MT2712

2018-05-31 Thread honghui.zhang
From: Honghui Zhang The MTCMOS of PCIe Host for MT2712 will be off when system suspend, and all the internal control register will be reset after system resume. The PCIe link should be re-established and the related control register values should be re-set after system resume. Signed-off-by: Hon

[PATCH v2] PCI: mediatek: Add system pm support for MT2712

2018-05-31 Thread honghui.zhang
From: Honghui Zhang The MTCMOS of PCIe Host for MT2712 will be off when system suspend, and all the internal control register will be reset after system resume. The PCIe link should be re-established and the related control register values should be re-set after system resume. Signed-off-by: Hon

[PATCH] PCI: mediatek: Add system pm support for MT2712

2018-05-29 Thread honghui.zhang
From: Honghui Zhang The MTCMOS of PCIe Host for MT2712 will be off when system suspend, and all the internel control register will be reset after system resume. The PCIe link should be re-established and the related control register values should be re-set after system resume. Signed-off-by: Hon

[PATCH v7 2/2] PCI: mediatek: Using chained IRQ to setup IRQ handle

2018-05-03 Thread honghui.zhang
From: Honghui Zhang Using irq_chip solution to setup IRQs in order to consist with IRQ framework. Signed-off-by: Honghui Zhang Acked-by: Ryder Lee --- drivers/pci/host/pcie-mediatek.c | 206 ++- 1 file changed, 115 insertions(+), 91 deletions(-) diff --git

[PATCH v7 0/2] PCI: mediatek: Fixups for the IRQ handle routine and MT7622's class code

2018-05-03 Thread honghui.zhang
From: Honghui Zhang Two fixups for mediatek's host bridge: The first patch fixup class type and vendor ID for MT7622. The second patch fixup the IRQ handle routine by using irq_chip solution to avoid IRQ reentry which may exist for both MT2712 and MT7622. Change since v6: - Remove the irq_mask,

[PATCH v7 1/2] PCI: mediatek: Set up vendor ID and class type for MT7622

2018-05-03 Thread honghui.zhang
From: Honghui Zhang MT7622's hardware default value of vendor ID and class type is not correct, fix that by setup the correct values before linkup with Endpoint. Signed-off-by: Honghui Zhang Acked-by: Ryder Lee --- drivers/pci/host/pcie-mediatek.c | 30 +++--- include/

[PATCH v6 0/2] PCI: mediatek: Fixups for the IRQ handle routine and MT7622's class code

2018-04-19 Thread honghui.zhang
From: Honghui Zhang Two fixups for mediatek's host bridge: The first patch fixup class type and vendor ID for MT7622. The second patch fixup the IRQ handle routine by using irq_chip solution to avoid IRQ reentry which may exist for both MT2712 and MT7622. Change since v5: - Make the comments co

[PATCH 2/2] PCI: mediatek: Using chained IRQ to setup IRQ handle

2018-04-19 Thread honghui.zhang
From: Honghui Zhang Using irq_chip solution to setup IRQs for the consistent with IRQ framework. Signed-off-by: Honghui Zhang --- drivers/pci/host/pcie-mediatek.c | 192 +-- 1 file changed, 105 insertions(+), 87 deletions(-) diff --git a/drivers/pci/host/pc

[PATCH v6 1/2] PCI: mediatek: Set up vendor ID and class type for MT7622

2018-04-19 Thread honghui.zhang
From: Honghui Zhang MT7622's hardware default value of vendor ID and class type is not correct, fix that by setup the correct values before linkup with Endpoint. Signed-off-by: Honghui Zhang --- drivers/pci/host/pcie-mediatek.c | 30 +++--- include/linux/pci_ids.h

[PATCH v5 2/2] PCI: mediatek: Set up class type and vendor ID for MT7622

2017-12-26 Thread honghui.zhang
From: Honghui Zhang The hardware default value of IDs and class type is not correct, fix that by setup the correct values before start up. Signed-off-by: Honghui Zhang --- drivers/pci/host/pcie-mediatek.c | 12 include/linux/pci_ids.h | 2 ++ 2 files changed, 14 insertio

[PATCH v5 1/2] PCI: mediatek: Clear IRQ status after IRQ dispatched to avoid reentry

2017-12-26 Thread honghui.zhang
From: Honghui Zhang There maybe a same IRQ reentry scenario after IRQ received in current IRQ handle flow: EP device PCIe host driverEP driver 1. issue an IRQ 2. received IRQ 3. clear IRQ status

  1   2   >