[PATCH v2] checkpatch: enhance check for seq_printf uses that could be seq_puts

This patch enhances the check for seq_printf uses that could be seq_puts. It was considering the escape of % is \%, but it is %%. This led to skipping some valid cases related to that warning. Signed-off-by: Heba Aamer --- v2: remove not needed if condition scripts/checkpatch.pl |3 ++- 1

[PATCH v2] staging: lustre: lustre: osc: modifying seq_printf statements

This patch modifies the seq_printf statements in drivers/staging/lustre/lustre/osc/lproc_osc.c file. It changes it to seq_puts and seq_putc wherever applicable. Signed-off-by: Heba Aamer --- v2: changing %% to % drivers/staging/lustre/lustre/osc/lproc_osc.c | 20 ++-- 1 file

[PATCH] checkpatch: enhance check for seq_printf uses that could be seq_puts

This patch enhances the check for seq_printf uses that could be seq_puts. It was considering the escape of % is \%, but it is %%. This led to skipping some valid cases related to that warning. Signed-off-by: Heba Aamer --- scripts/checkpatch.pl | 13 - 1 file changed, 8

[PATCH] staging: lustre: lustre: osc: modifying seq_printf statements

This patch modifies the seq_printf statements in drivers/staging/lustre/lustre/osc/lproc_osc.c file. It changes it to seq_puts and seq_putc wherever applicable. Signed-off-by: Heba Aamer --- drivers/staging/lustre/lustre/osc/lproc_osc.c | 20 ++-- 1 file changed, 10 insertions

Re: [PATCH] staging: lustre: lustre: osc: fix Prefer seq_puts to seq_printf

On Wed, Jan 28, 2015 at 05:56:07PM -0800, Joe Perches wrote: > On Wed, 2015-01-28 at 16:05 +0200, Heba Aamer wrote: > > This patch fixes the following checkpatch.pl warning: > > Prefer seq_puts to seq_printf > > checkpatch is pretty stupid. > Please don't jus

[PATCH v2] staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()

set. Signed-off-by: Heba Aamer --- v2: modifying patch description drivers/staging/rtl8712/usb_intf.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/usb_intf.c b/drivers/staging/rtl8712/usb_intf.c index 15f0d42..a2f2dfb 100644 --- a/drivers/stag

[PATCH] staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()

+ 65(holes), diff = 36 */ }; Moreover mac and pdata are simple arrays and pointers. Signed-off-by: Heba Aamer --- drivers/staging/rtl8712/usb_intf.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/usb_intf.c b/drivers/staging/rtl8712

[PATCH 2/5] staging: fbtft: fix do not initialise statics to 0 or NULL

This patch fixes the following checkpatch.pl error: fix do not initialise statics to 0 or NULL Signed-off-by: Heba Aamer --- drivers/staging/fbtft/fb_pcd8544.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/staging/fbtft

[PATCH] staging: lustre: lustre: osc: fix Prefer seq_puts to seq_printf

This patch fixes the following checkpatch.pl warning: Prefer seq_puts to seq_printf Signed-off-by: Heba Aamer --- drivers/staging/lustre/lustre/osc/lproc_osc.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/lustre/lustre/osc/lproc_osc.c b/drivers

[PATCH 4/5] staging: fbtft: fix trailing whitespace

This patch fixes the following checkpatch.pl error: trailing whitespace Signed-off-by: Heba Aamer --- drivers/staging/fbtft/fb_pcd8544.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/staging/fbtft/fb_pcd8544.c index

[PATCH 3/5] staging: fbtft: fix horizontal spaces errors

This patch fixes the following checkpatch.pl errors: spaces required around that '=' space required after that ';' spaces required around that '<' Signed-off-by: Heba Aamer --- drivers/staging/fbtft/fb_pcd8544.c |6 +++--- 1 file changed, 3 insertions

[PATCH 0/5] Fix fbtft/fb_pcd8544.c coding style errors and warnings

This patch set fixes most of the checkpatch.pl coding style errors and warnings found in drivers/staging/fbtft/fb_pcd8544.c Regarding the spaces fixes the git diff -w showed no difference, and the objdiff was empty. Heba Aamer (5): staging: fbtft: fix Macros with complex values should be

[PATCH 1/5] staging: fbtft: fix Macros with complex values should be enclosed in parentheses

This patch fixes the following checkpatch.pl error: fix Macros with complex values should be enclosed in parentheses Signed-off-by: Heba Aamer --- drivers/staging/fbtft/fb_pcd8544.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fb_pcd8544.c b

[PATCH] staging: fbtft: remove redundant .owner

This patch fixes the following coccicheck warning: No need to set .owner here. The core will do it. Signed-off-by: Heba Aamer --- drivers/staging/fbtft/flexfb.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/staging/fbtft/flexfb.c index 45574a0

[PATCH] staging: rtl8712: remove useless printing line

This patch removes an unneeded call to printk. Signed-off-by: Heba Aamer --- drivers/staging/rtl8712/usb_intf.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8712/usb_intf.c b/drivers/staging/rtl8712/usb_intf.c index 7d0d171..f1fd7e8 100644 --- a/drivers/staging

[PATCH 5/5] staging: fbtft: fix braces {} are not necessary for single statement blocks

This patch fixes the following checkpatch.pl warning: braces {} are not necessary for single statement blocks Signed-off-by: Heba Aamer --- drivers/staging/fbtft/fb_pcd8544.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers

[PATCH 6/6] staging: fbtft: fix trailing whitespace

This patch fixes the following checkpatch.pl error: fix trailing whitespace Signed-off-by: Heba Aamer --- drivers/staging/fbtft/fb_pcd8544.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/staging/fbtft/fb_pcd8544.c

[PATCH 5/6] staging: fbtft: fix do not initialise statics to 0 or NULL

This patch fixes the following checkpatch.pl error: fix do not initialise statics to 0 or NULL Signed-off-by: Heba Aamer --- drivers/staging/fbtft/fb_pcd8544.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/staging/fbtft

[PATCH 4/6] staging: fbtft: fix Macros with complex values should be enclosed in parentheses

This patch fixes the following checkpatch.pl error: fix Macros with complex values should be enclosed in parentheses Signed-off-by: Heba Aamer --- drivers/staging/fbtft/fb_pcd8544.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fb_pcd8544.c b

[PATCH 3/6] staging: fbtft: fix spaces required around that '<'

This patch fixes the following checkpatch.pl error: fix spaces required around that '<' Signed-off-by: Heba Aamer --- drivers/staging/fbtft/fb_pcd8544.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/

[PATCH 2/6] staging: fbtft: fix spaces required around that '='

This patch fixes the following checkpatch.pl error: fix spaces required around that '=' Signed-off-by: Heba Aamer --- drivers/staging/fbtft/fb_pcd8544.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/sta

[PATCH 1/6] staging: fbtft: fix space required after that ';'

This patch fixes the following checkpatch.pl error: fix space required after that ';' Signed-off-by: Heba Aamer --- drivers/staging/fbtft/fb_pcd8544.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/sta

[PATCH 0/6] Fix fbtft/fb_pcd8544.c coding style errors

This patch set fixes most of the checkpatch.pl coding style errors found in drivers/staging/fbtft/fb_pcd8544.c Heba Aamer (6): staging: fbtft: fix space required after that ';' staging: fbtft: fix spaces required around that '=' staging: fbtft: fix spaces required aroun

[PATCH] staging: media: lirc: adjust boolean assignments

This patch adjusts boolean assignments from 0/1 to false/true. And accordingly, it also adjusts the if conditions. Signed-off-by: Heba Aamer --- drivers/staging/media/lirc/lirc_serial.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/media/lirc

[PATCH v2] staging: rtl8712: fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...

This patch fixes the following checkpatch.pl warning: fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... Signed-off-by: Heba Aamer --- v2: changed netdev_info to pr_info drivers/staging/rtl8712/usb_intf.c |2 +- 1

Re: [PATCH] staging: rtl8712: fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...

On Sun, Jan 25, 2015 at 07:57:55PM +0800, Greg KH wrote: > On Sat, Jan 24, 2015 at 10:20:53PM +0200, Heba Aamer wrote: > > This patch fixes the following checkpatch.pl warning: > > fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then > > dev_info(dev, ... then p

[PATCH] staging: rtl8712: fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...

This patch fixes the following checkpatch.pl warning: fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... netdev_info was used since it is a network subsystem Signed-off-by: Heba Aamer --- drivers/staging/rtl8712

[PATCH] staging: vt6656: fix Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2)

addr4[6]; /*24 6 */ /* size: 30, cachelines: 1, members: 7 */ /* last cacheline: 30 bytes */ }; Signed-off-by: Heba Aamer --- drivers/staging/vt6656/rxtx.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6656/rxtx.c b

[PATCH v2] staging: vt6655: fix space prohibited before that ','

This patch fixes the following checkpatch.pl error: fix space prohibited before that ',' Signed-off-by: Heba Aamer --- v2: added Signed-off line drivers/staging/vt6655/mac.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/mac.c b/drive

[PATCH] staging: vt6655: fix space prohibited before that ','

This patch fixes the following checkpatch.pl error: fix space prohibited before that ',' --- drivers/staging/vt6655/mac.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/mac.c b/drivers/staging/vt6655/mac.c index 63c9c7e..3653a2b 100644 --- a/drivers/