[PATCH v7] ASoC: Intel: kbl_rt5663_rt5514_max98927: Fix kabylake_ssp_fixup function

2020-07-21 Thread Harsha Priya
dmic and speakers. One is for capture and one is for playback respectively. Based on the direction of the stream, the snd_soc_dpcm is extracted from the snd_soc_pcm_runtime structure. Tested for all use cases of the driver. Signed-off-by: Harsha Priya Signed-off-by: Vamshi Krishna Gopal Tested-by

[PATCH v6] ASoC: Intel: kbl_rt5663_rt5514_max98927: Fix kabylake_ssp_fixup function

2020-07-16 Thread Harsha Priya
). The 2 codecs on this SSP are dmic and speakers. One is for capture and one is for playback respectively. Based on the direction of the stream, the snd_soc_dpcm is extracted from the snd_soc_pcm_runtime structure. Tested for all use cases of the driver. Signed-off-by: Harsha Priya Signed-off-by

Re: [PATCH v5] drm/i915: Replace *_reference/unreference() or *_ref/unref with _get/put()

2017-10-16 Thread Harsha Sharma
On Tue, Oct 17, 2017 at 12:15 AM, Sean Paul wrote: > On Sat, Oct 14, 2017 at 2:36 PM, Harsha Sharma > wrote: >> Replace instances of drm_framebuffer_reference/unreference() with >> *_get/put() suffixes and drm_dev_unref with *_put() suffix >> because get/put is shorter

[PATCH] drm/tinydrm: Replace list_for_each with list_for_each_entry

2017-10-14 Thread Harsha Sharma
@ identifier s.i,s.f; expression s.e; statement S; @@ list_for_each_entry(i,e,f) - { S - } Signed-off-by: Harsha Sharma --- drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c b

[PATCH] drm/omap: Replace list_for_each with list_for_each_entry

2017-10-14 Thread Harsha Sharma
@ identifier s.i,s.f; expression s.e; statement S; @@ list_for_each_entry(i,e,f) - { S - } Signed-off-by: Harsha Sharma --- drivers/gpu/drm/omapdrm/dss/display.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/display.c b/dri

[PATCH v5] drm/i915: Replace *_reference/unreference() or *_ref/unref with _get/put()

2017-10-14 Thread Harsha Sharma
; @@ ( -drm_framebuffer_unreference(ex); +drm_framebuffer_put(ex); | -drm_dev_unref(ex); +drm_dev_put(ex); | -drm_framebuffer_reference(ex); +drm_framebuffer_get(ex); ) Signed-off-by: Harsha Sharma --- Changes in v5: -rebase drm_dev_put change on drm-tip Changes in v4: -change one instance of *_put to *_get Changes in

[PATCH v4] drm/amd/powerplay: Remove unnecessary cast on void pointer

2017-10-13 Thread Harsha Sharma
Done with following coccinelle patch @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: Harsha Sharma --- Changes in v4: -Removed git diff warning "No newline at end of file" Changes in v3: -Remove

[PATCH v3] drm/amd/powerplay: Remove unnecessary cast on void pointer

2017-10-13 Thread Harsha Sharma
Done with following coccinelle patch @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: Harsha Sharma --- Changes in v3: -Removed unnecessary lines -Remove more useless casts Changes in v2: -Remove unnecess

[PATCH v2] drm/amd/powerplay: Remove unnecessary cast on void pointer

2017-10-13 Thread Harsha Sharma
Done with following coccinelle patch @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: Harsha Sharma --- Changes in v2: -Remove unnecessary parentheses -Remove one more useless cast drivers/gpu/drm/

Re: [PATCH v4] drm/i915: Replace *_reference/unreference() or *_ref/unref with _get/put()

2017-10-13 Thread Harsha Sharma
On Mon, Oct 9, 2017 at 5:36 PM, Harsha Sharma wrote: > Replace instances of drm_framebuffer_reference/unreference() with > *_get/put() suffixes and drm_dev_unref with *_put() suffix > because get/put is shorter and consistent with the > kernel use of *_get/put suffixes. > Done

[PATCH] drm/amd/powerplay: Remove unnecessary cast on void pointer

2017-10-13 Thread Harsha Sharma
Done with following coccinelle patch @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: Harsha Sharma --- drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c| 6 +++--- drivers/gpu/drm/amd/powerplay/hw

[PATCH v2] drm: Replace kzalloc with kcalloc

2017-10-13 Thread Harsha Sharma
Prefer kcalloc over kzalloc to allocate an array. This patch fixes checkcpatch issue. Signed-off-by: Harsha Sharma --- Changes in v2: -kcalloc will take 3 arguments drivers/gpu/drm/drm_crtc_helper.c | 4 ++-- drivers/gpu/drm/drm_fb_helper.c| 2 +- drivers/gpu/drm/drm_plane_helper.c | 2

[PATCH] netfilter: nf_conntrack_h323: Remove typedef struct

2017-10-12 Thread Harsha Sharma
ccinelle.T2 = T[:-2]; else: coccinelle.T2 = T; print T, coccinelle.T2 @r2@ type r1.T; identifier c1.T2; @@ -typedef struct + T2 { ... } -T ; @r3@ type r1.T; identifier c1.T2; @@ -T +struct T2 Signed-off-by: Harsha Sharma --- net/netfilter/nf_conntrack_h323_asn1.c | 80 +---

[PATCH] drm: Replace kzalloc with kcalloc

2017-10-12 Thread Harsha Sharma
Prefer kcalloc over kzalloc to allocate an array. This patch fixes checkcpatch issue. Signed-off-by: Harsha Sharma --- drivers/gpu/drm/drm_crtc_helper.c | 4 ++-- drivers/gpu/drm/drm_fb_helper.c| 2 +- drivers/gpu/drm/drm_plane_helper.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions

[PATCH v4] drm/i915: Replace *_reference/unreference() or *_ref/unref with _get/put()

2017-10-09 Thread Harsha Sharma
; @@ ( -drm_framebuffer_unreference(ex); +drm_framebuffer_put(ex); | -drm_dev_unref(ex); +drm_dev_put(ex); | -drm_framebuffer_reference(ex); +drm_framebuffer_get(ex); ) Signed-off-by: Harsha Sharma --- Changes in v4: -change one instance of *_put to *_get Changes in v3: -Removed changes in selftests Changes in v2

[PATCH v3] drm/i915: Replace *_reference/unreference() or *_ref/unref with _get/put()

2017-10-08 Thread Harsha Sharma
; @@ ( -drm_framebuffer_unreference(ex); +drm_framebuffer_put(ex); | -drm_dev_unref(ex); +drm_dev_put(ex); | -drm_framebuffer_reference(ex); +drm_framebuffer_get(ex); ) Signed-off-by: Harsha Sharma --- Changes in v3: -Removed changes in selftests Changes in v2: -Added cocinelle patch in log message -cc to all driver

[PATCH v3 06/10] staging: rtl8723bs: Add space after ','

2017-10-08 Thread Harsha Sharma
Space is required after ',' according to linux-kernel coding style. Signed-off-by: Harsha Sharma --- Other patches from this patchset have already been merged and only this one is remaining. Changes in v3: -Change log message and rebase against staging-testing Changes in v2: -Reba

Re: [PATCH v2] drm/i915: Replace *_reference/unreference() or *_ref/unref with _get/put()

2017-10-08 Thread Harsha Sharma
On Fri, Sep 29, 2017 at 10:00 AM, Harsha Sharma wrote: > Replace instances of drm_framebuffer_reference/unreference() with > *_get/put() suffixes and drm_dev_unref with *_put() suffix > because get/put is shorter and consistent with the > kernel use of *_get/put suffixes. > Done

Re: [PATCH v2 06/10] staging: rtl8723bs: Add space after ','

2017-10-08 Thread Harsha Sharma
On Wed, Sep 13, 2017 at 2:11 AM, Greg KH wrote: > On Tue, Sep 12, 2017 at 07:05:23PM +0530, Harsha Sharma wrote: >> Space required after ',' >> >> Signed-off-by: Harsha Sharma >> --- >> Changes in v2: >> -Rebase against staging-testing and solve

[PATCH v3] drm/tinydrm: Replace dev_error with DRM_DEV_ERROR

2017-10-06 Thread Harsha Sharma
Convert instances of dev_error to DRM_DEV_ERROR as we have DRM_DEV_ERROR variants of drm print macros. Signed-off-by: Harsha Sharma --- Changes in v3: -Solve merge conflicts Changes in v2: -Fix alignment issues drivers/gpu/drm/tinydrm/mi0283qt.c | 8 drivers/gpu/drm/tinydrm

[PATCH] test: shell: execute shell/run-tests.sh from any directory

2017-10-05 Thread Harsha Sharma
Update shell/run-tests.sh to refer /src/nft with a relative path Signed-off-by: Harsha Sharma --- tests/shell/run-tests.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/shell/run-tests.sh b/tests/shell/run-tests.sh index 4eba0a8..dbddd8d 100755 --- a/tests/shell/run

[PATCH] INSTALL: Update dependency list and configure with libxtables support

2017-10-05 Thread Harsha Sharma
Add configure with lixtables in INSTALL and required dependencies for the same Signed-off-by: Harsha Sharma --- INSTALL | 11 +++ 1 file changed, 11 insertions(+) diff --git a/INSTALL b/INSTALL index 3e9a6ad..04981f1 100644 --- a/INSTALL +++ b/INSTALL @@ -18,6 +18,12 @@ Installation

[PATCH 2/3] evaluate: Place constant on right side in comparison

2017-10-02 Thread Harsha Sharma
Comparisons should place the constant on the right side of the test as per linux-kernel coding style Signed-off-by: Harsha Sharma --- src/evaluate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/evaluate.c b/src/evaluate.c index 5624ca2..b783054 100644 --- a/src

[PATCH 3/3] evaluate: make pointers in string arrays constant

2017-10-02 Thread Harsha Sharma
static const char * array should probably be static const char * const array as per linux-kernel coding style Signed-off-by: Harsha Sharma --- src/evaluate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/evaluate.c b/src/evaluate.c index b783054..f48801a 100644

[PATCH 1/3] evaluate: Remove unnecessary spaces

2017-10-02 Thread Harsha Sharma
Code indent should use tabs wherever possible Signed-off-by: Harsha Sharma --- src/evaluate.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/evaluate.c b/src/evaluate.c index e767542..5624ca2 100644 --- a/src/evaluate.c +++ b/src/evaluate.c @@ -122,7 +122,7

[PATCH 0/3] evaluate: Follow linux-kernel coding style

2017-10-02 Thread Harsha Sharma
Issues found using checkpatch.pl As per linux-kernel coding style, code indent should use tabs wherever possible and avoid unnecessary spaces. Comparisons shoukd place the constant on the right side of the test. static const char * array should be static const * char const array Harsha Sharma

[PATCH] exthdr: Add support for reserved header and address

2017-10-01 Thread Harsha Sharma
Add support for IPV6 type 0 routing header reserved field and address unable to test it with nft-test.py Signed-off-by: Harsha Sharma --- include/exthdr.h | 2 ++ src/exthdr.c | 7 +-- tests/py/ip6/rt.t | 2 ++ 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/include

[PATCH v2] drm/tinydrm: Replace dev_error with DRM_DEV_ERROR

2017-09-29 Thread Harsha Sharma
Convert instances of dev_error to DRM_DEV_ERROR as we have DRM_DEV_ERROR variants of drm print macros. Signed-off-by: Harsha Sharma --- Changes in v2: -Fix alignment issues drivers/gpu/drm/tinydrm/mi0283qt.c | 8 drivers/gpu/drm/tinydrm/repaper.c | 26

[PATCH v2] drm/i915: Replace *_reference/unreference() or *_ref/unref with _get/put()

2017-09-28 Thread Harsha Sharma
; @@ ( -drm_framebuffer_unreference(ex); +drm_framebuffer_put(ex); | -drm_dev_unref(ex); +drm_dev_put(ex); | -drm_framebuffer_reference(ex); +drm_framebuffer_get(ex); ) Signed-off-by: Harsha Sharma --- Changes in v2: -Added coccinelle patch in log message -cc to all driver-specific mailing lists

[PATCH] drm/i915: Replace *_reference/unreference() or *_ref/unref with _get/put()

2017-09-28 Thread Harsha Sharma
Replace instances of drm_framebuffer_reference/unreference() with *_get/put() suffixes and drm_dev_unref with *_put() suffix because get/put is shorter and consistent with the kernel use of *_get/put suffixes . Signed-off-by: Harsha Sharma --- drivers/gpu/drm/i915/i915_pci.c

[PATCH] iptables: Constify option struct

2017-09-27 Thread Harsha Sharma
; expression e; position p; @@ e = i@p @bad@ position p != {r1.p,ok1.p}; identifier r1.i; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r1.i; @@ static +const struct option i[] = { ... }; Signed-off-by: Harsha Sharma --- iptables/ip6tables.c | 2 +- iptables/iptables.c | 2

[PATCH] staging: iio: trigger: Move header file content to source file

2017-09-26 Thread Harsha Sharma
The contents of the header file are used only by this single source file. Moved content into iio-trig-bfin-timer.c and removed iio-trig-bfin-timer.h Signed-off-by: Harsha Sharma --- drivers/staging/iio/trigger/iio-trig-bfin-timer.c | 20 ++- drivers/staging/iio/trigger/iio-trig

[PATCH v2] drm/tegra: Replace dev_* with DRM_DEV_*

2017-09-24 Thread Harsha Sharma
Replace all occurences of dev_info/err/dbg with DRM_DEV_INFO/ ERROR/DEBUG as we have DRM_DEV_* variants of drm print macros Done using following coccinelle semantic patch @r@ @@ ( -dev_info +DRM_DEV_INFO | -dev_err +DRM_DEV_ERROR | -dev_dbg +DRM_DEV_DEBUG ) Signed-off-by: Harsha Sharma

[PATCH] drm/tegra: Replace dev_* with DRM_DEV_*

2017-09-23 Thread Harsha Sharma
Replace all occurences of dev_info/err/dbg with DRM_DEV_INFO/ ERROR/DEBUG as we have DRM_DEV_* variants of drm print macros Done using following coccinelle semantic patch @r@ @@ ( -dev_info +DRM_DEV_INFO | -dev_err +DRM_DEV_ERROR | -dev_dbg +DRM_DEV_DEBUG ) Signed-off-by: Harsha Sharma

[PATCH] drm/tinydrm: Replace dev_error with DRM_DEV_ERROR

2017-09-23 Thread Harsha Sharma
Convert instances of dev_error to DRM_DEV_ERROR as we have DRM_DEV_ERROR variants of drm print macros. Signed-off-by: Harsha Sharma --- drivers/gpu/drm/tinydrm/mi0283qt.c | 8 drivers/gpu/drm/tinydrm/repaper.c | 26 +- drivers/gpu/drm/tinydrm/st7586.c | 6

[PATCH v2] staging: vc04_services: Remove typedef struct

2017-09-22 Thread Harsha Sharma
ccinelle.T2 = T[:-2]; else: coccinelle.T2 = T; print T, coccinelle.T2 @r2@ type r1.T; identifier c1.T2; @@ -typedef struct + T2 { ... } -T ; @r3@ type r1.T; identifier c1.T2; @@ -T +struct T2 Signed-off-by: Harsha Sharma --- Changes in v2: -Convert structure name to lowercase .../vc04_se

[PATCH] staging: vc04_services: Remove typedef struct

2017-09-21 Thread Harsha Sharma
ccinelle.T2 = T[:-2]; else: coccinelle.T2 = T; print T, coccinelle.T2 @r2@ type r1.T; identifier c1.T2; @@ -typedef struct + T2 { ... } -T ; @r3@ type r1.T; identifier c1.T2; @@ -T +struct T2 Signed-off-by: Harsha Sharma --- .../vc04_services/interface/vchiq_arm/vchiq_shim.c | 44 +++-

[PATCH] staging: rtlwifi: delete double assignment

2017-09-15 Thread Harsha Sharma
e2; | (<+...++e1...+>)=e2; | (<+...--e1...+>)=e2; | e1=e2; e1 = <+...e1...+>; | *e1=e2; *e1=e3; ) Signed-off-by: Harsha Sharma --- drivers/staging/rtlwifi/base.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtlwifi/base.c b/drivers/staging/rtlwifi/base.c

[PATCH] staging: rtl8723bs: Remove unused variable ret

2017-09-14 Thread Harsha Sharma
Remove unused variable ret as it is not used anywhere. Remove multiple blank lines. Done using following coccinelle semantic patch @@ type T; identifier i; constant C; @@ ( extern T i; | - T i; <+... when != i - i = C; ...+> ) Signed-off-by: Harsha Sharma --- drivers/staging/rtl

[PATCH] staging: rtl8723bs: Merge assignment with return

2017-09-14 Thread Harsha Sharma
Merge assignment with return statement to directly return the value. Done using following coccinelle semantic patch @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Harsha Sharma --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 20

[PATCH v2 06/10] staging: rtl8723bs: Add space after ','

2017-09-12 Thread Harsha Sharma
Space required after ',' Signed-off-by: Harsha Sharma --- Changes in v2: -Rebase against staging-testing and solve merge conflicts drivers/staging/rtl8723bs/os_dep/os_intfs.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl872

[PATCH] staging: rtl8723bs: Remove unnecessary spaces

2017-09-12 Thread Harsha Sharma
Space between function name and open parentheses '(' is prohibited. Space is required around most binary operators '=', '==', '+=', '<', ':', '+', '-' Space required before '&', '*' Space i

[PATCH v3 07/10] staging: rtl8723bs: Remove unnecessary space

2017-09-12 Thread Harsha Sharma
Remove space between function name and open parenthesis '(' Remove space before ';', '++', ',' Signed-off-by: Harsha Sharma --- Change in v3: -Fix small spelling mistake Change in v2: -Merge patches 07/10 and 08/10 drivers/staging/rtl8723bs/os_dep/os_i

[PATCH v2 07/10] staging: rtl8723bs: Remove unneccesary space

2017-09-12 Thread Harsha Sharma
Remove space between function name and open parenthesis '(' Remove space before ';', '++', ',' Signed-off-by: Harsha Sharma --- Change in v2: -Merge patches 07/10 and 08/10 drivers/staging/rtl8723bs/os_dep/os_intfs.c | 12 ++-- 1 file change

[PATCH v3] staging: rtl8723bs: Change coding style to (foo *bar)

2017-09-11 Thread Harsha Sharma
This coding style (foo *bar) is more common for the kernel code. Change foo* bar to foo *bar. Change foo * bar to foo *bar. Change (foo*) to (foo *). Signed-off-by: Harsha Sharma --- Change in v3: -Rebase against staging-testing branch Change in v2: -Updated log message and subject drivers

[PATCH 10/10] staging: rtl8723bs: Remove unnecessary blank lines

2017-09-10 Thread Harsha Sharma
Blank lines aren't necessary after an open brace and before a close brace Signed-off-by: Harsha Sharma --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/o

[PATCH 09/10] staging: rtl8723bs: Remove unneccesary braces and change position of open brace

2017-09-10 Thread Harsha Sharma
Follow linux-kernel code style for conditional statements Signed-off-by: Harsha Sharma --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 63 + 1 file changed, 19 insertions(+), 44 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers

[PATCH 08/10] staging: rtl8723bs: Remove unnecessary space

2017-09-10 Thread Harsha Sharma
Remove space before ';', '++', ',' Signed-off-by: Harsha Sharma --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/o

[PATCH 07/10] staging: rtl8723bs: Removed unneccesary space

2017-09-10 Thread Harsha Sharma
Remove space between function name and open parenthesis '(' Signed-off-by: Harsha Sharma --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl872

[PATCH 06/10] staging: rtl8723bs: Add space after ','

2017-09-10 Thread Harsha Sharma
Space required after ',' Signed-off-by: Harsha Sharma --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c ind

[PATCH 05/10] staging: rtl8723bs: Add space between concatenated strings

2017-09-10 Thread Harsha Sharma
Use spaces between concatenated strings Signed-off-by: Harsha Sharma --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 50 ++--- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs

[PATCH 04/10] staging: rtl8723bs: Remove unnecessary spaces at the start of line

2017-09-10 Thread Harsha Sharma
No spaces at the start of a line Signed-off-by: Harsha Sharma --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c index 5ceccd7..97ff3ab

[PATCH 03/10] staging: rtl8723bs: Add spaces around '?', '==', '||', '!='

2017-09-10 Thread Harsha Sharma
Use spaces around most binary operators Signed-off-by: Harsha Sharma --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c index

[PATCH 02/10] staging: rtl8723bs: Add spaces around '+', '|', '*'

2017-09-10 Thread Harsha Sharma
Use one space around most binary operators Signed-off-by: Harsha Sharma --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c

[PATCH 01/10] staging: rtl8723bs: Add spaces around '='

2017-09-10 Thread Harsha Sharma
Use one space around (on each side of) '=' operator Signed-off-by: Harsha Sharma --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging

[PATCH 00/10] staging: rtl8723bs: Follow linux-kernel coding style

2017-09-10 Thread Harsha Sharma
e a single statement will do and put the opening brace last on the line, and put the closing brace first. Unnecessary spaces and blank lines should be avoided. Harsha Sharma (10): staging: rtl8723bs: Add spaces around '=' staging: rtl8723bs: Add spaces around '+', '|

[PATCH] staging: rtl8723bs: Add spaces around '=', '|', '<<'

2017-09-09 Thread Harsha Sharma
Use one space around most binary operators Signed-off-by: Harsha Sharma --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs

[PATCH v2] staging: rtl8723bs: Change coding style to (foo *bar)

2017-09-09 Thread Harsha Sharma
This coding style (foo *bar) is more common for the kernel code. Change foo* bar to foo *bar. Change foo * bar to foo *bar. Change (foo*) to (foo *). Signed-off-by: Harsha Sharma --- Change in v2: -Updated log message and subject drivers/staging/rtl8723bs/os_dep/os_intfs.c | 10 +- 1

[PATCH] staging: rtl8723bs: Change foo* bar to foo *bar

2017-09-09 Thread Harsha Sharma
This coding style (foo *bar) is more common for the kernel code. Signed-off-by: Harsha Sharma --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs

[PATCH] staging: rtl8723bs: Do not initialise statics to 0

2017-09-09 Thread Harsha Sharma
Static variables are initialised to 0 by gcc Signed-off-by: Harsha Sharma --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 48 ++--- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs

[PATCH] staging: sm750fb: Remove extra blank lines

2017-09-09 Thread Harsha Sharma
This was reported by checkpatch.pl Signed-off-by: Harsha Sharma --- drivers/staging/sm750fb/sm750_cursor.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_cursor.c b/drivers/staging/sm750fb/sm750_cursor.c index aa47a16..6b27b06 100644 --- a/drivers/staging

[PATCH] staging: unisys: visorbus: Declared char * array as static const

2017-09-09 Thread Harsha Sharma
State explicitly that individual entries in array will not change. Signed-off-by: Harsha Sharma --- drivers/staging/unisys/visorbus/visorchipset.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys

[PATCH v3] staging: typec: tcpm: Rewrite comparison to NULL pointer

2017-09-08 Thread Harsha Sharma
Make code more concise and readable Signed-off-by: Harsha Sharma --- Change in v3: -Change in subject and log message Change in v2: -Change in subject -Change in log message drivers/staging/typec/tcpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH v2] staging: typec: tcpm: Comparison to NULL pointer

2017-09-08 Thread Harsha Sharma
Makes code more concise and readable Signed-off-by: Harsha Sharma --- Change in v2: -Change in subject -Change in log message drivers/staging/typec/tcpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/typec/tcpm.c b/drivers/staging/typec/tcpm.c index

[PATCH] staging: typec: tcpm: Comparison to NULL changed as "!port->partner_altmode[pmdata->altmodes]"

2017-09-08 Thread Harsha Sharma
Fixes coding style issue Signed-off-by: Harsha Sharma --- drivers/staging/typec/tcpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/typec/tcpm.c b/drivers/staging/typec/tcpm.c index 630fe75..9f4a5a5 100644 --- a/drivers/staging/typec/tcpm.c +++ b/drivers

[PATCH v6] staging: pi433: Fixes minor typo errors

2017-09-08 Thread Harsha Sharma
Fixes checkpatch warning -- "occured" and "succesfully" are misspelled Signed-off-by: Harsha Sharma --- Changes in v6: -Added changes from other versions Changes in v5: -Signed-off properly with correct author name in .gitconfig Changes in v4: -Correct the format of the s

[PATCH v5] staging: pi433: Fixes minor typo errors

2017-09-08 Thread Harsha Sharma
Fixes checkpatch warning -- "occured" and "succesfully" are misspelled Signed-off-by: Harsha Sharma --- Changes in v5: -Correct the format of the subject. -Signed-off properly with correct author name in .gitconfig drivers/staging/pi433/pi433_if.c | 4 ++-- 1 file changed

[PATCH v4] staging: pi433: Fixes minor typo errors

2017-09-08 Thread harsha
From: Harsha Sharma Fixes checkpatch warning -- "occured" and "succesfully" are misspelled Signed-off-by: Harsha Sharma --- Changes in v4: -Correct the format of the subject. -Signed-off properly. drivers/staging/pi433/pi433_if.c | 4 ++-- 1 file changed, 2 insert

[PATCH v3] staging: pi433: Fixes minor typo errors

2017-09-08 Thread harsha
Fixes checkpatch warning -- "occured" and "succesfully" are misspelled Signed-off-by: Harsha Sharma --- drivers/staging/pi433/pi433_if.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi43

[PATCH] staging: rt8712: xmit_linux: Avoid multiple assignments in a single line

2017-09-08 Thread harsha
Fixed coding style issue Signed-off-by: Harsha Sharma --- drivers/staging/rtl8712/xmit_linux.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/xmit_linux.c b/drivers/staging/rtl8712/xmit_linux.c index d13fd15..03c6b0c 100644 --- a/drivers

[PATCH] staging: pi433: pi433_if: Fixes minor typo errors

2017-09-08 Thread harsha
Fixes checkpatch warning -- "occured" and "succesfully" are misspelled Signed-off-by: Harsha Sharma --- drivers/staging/pi433/pi433_if.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi43

[PATCH] Staging:pi433:pi433_if.c:Fixes minor typo errors

2017-09-07 Thread harsha
Fixes checkpatch warning -- "occured" and "succesfully" are misspelled Signed-off-by: Harsha Sharma --- drivers/staging/pi433/pi433_if.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi43

[PATCH] Staging:pi433:pi433_if.c:Fixes minor typo errors

2017-09-06 Thread harsha
Fixes checkpatch warning -- "occured" and "succesfully" are misspelled Signed-off-by: Harsha Sharma --- drivers/staging/pi433/pi433_if.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi43

[PATCH] staging:rt8712:xmit_linux.c: Avoid multiple assignments in a single line

2017-08-31 Thread harsha
Fixed coding style issue Signed-off-by: Harsha Sharma --- drivers/staging/rtl8712/xmit_linux.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/xmit_linux.c b/drivers/staging/rtl8712/xmit_linux.c index d13fd15..03c6b0c 100644 --- a/drivers

[PATCH] staging:rt8712:xmit_linux.c: Avoid multiple assignments in a single line

2017-08-29 Thread harsha
Fixed coding style issue Signed-off-by: Harsha Sharma --- drivers/staging/rtl8712/xmit_linux.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/xmit_linux.c b/drivers/staging/rtl8712/xmit_linux.c index d13fd15..03c6b0c 100644 --- a/drivers

[PATCH] Staging:android:ion:ion.c : Using WARN_ON() rather than BUG()

2017-08-29 Thread harsha
Fixes checkpatch.pl warning: Use WARN_ON() rather than BUG_ON() and BUG() Signed-off-by: harsha --- drivers/staging/android/ion/ion.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index 93e2c90..a2d36b3

[PATCH] Staging:android:ion:ion.c : Using WARN_ON() rather than BUG()

2017-08-29 Thread harsha
Hi, harsha, this is my real name. There is no need to call BUG() over here as this error is not very basic and BUG() tends to bring the system down so calling WARN_ON() is preferable. Please correct me if I am wrong as this is my first contribution. I am unable to send any direct mail from gmail

[PATCH] Staging:android:ion:ion.c : Using WARN_ON() rather than BUG()

2017-08-29 Thread harsha
Fixes checkpatch.pl warning: Use WARN_ON() rather than BUG_ON() and BUG() Signed-off-by: harsha --- drivers/staging/android/ion/ion.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index 93e2c90..a2d36b3

[PATCH] Staging:android:ion:ion.c : Using WARN_ON() rather than BUG()

2017-08-29 Thread harsha
Signed-off-by: harsha --- drivers/staging/android/ion/ion.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index 93e2c90..a2d36b3 100644 --- a/drivers/staging/android/ion/ion.c +++ b/drivers/staging

[PATCH] staging:rtl8712:rtl871x_xmit.c : Removed unnecessary blank line

2017-08-25 Thread harsha
Signed-off-by: harsha --- drivers/staging/rtl8712/rtl871x_xmit.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c index 4e28209..6ecfe0f 100644 --- a/drivers/staging/rtl8712/rtl871x_xmit.c +++ b/drivers/staging

[PATCH] staging:unisys:visornic:visornic_main.c: Avoid multiple line derefernece

2017-08-25 Thread harsha
Signed-off-by: harsha --- drivers/staging/unisys/visornic/visornic_main.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers/staging/unisys/visornic/visornic_main.c index 0b39676..57fc65f 100644 --- a/drivers

[PATCH] staging:unisys:visorbus:visorchipset.c: Declared char * array as static const

2017-08-25 Thread harsha
Signed-off-by: harsha --- drivers/staging/unisys/visorbus/visorchipset.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c index 6d4498f..6f2a010 100644 --- a/drivers/staging

[PATCH] staging:unisys:visorbus:visorchipset.c: Added a blank line after function declaration

2017-08-25 Thread harsha
Signed-off-by: harsha --- drivers/staging/unisys/visorbus/visorchipset.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c index 6f2a010..6789c04 100644 --- a/drivers/staging/unisys/visorbus

[PATCH] staging:typec:tcpm.c : Fixed warning line over 80 characters Signed-off-by: harsha

2017-08-25 Thread harsha
--- drivers/staging/typec/tcpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/typec/tcpm.c b/drivers/staging/typec/tcpm.c index a30c01b..630fe75 100644 --- a/drivers/staging/typec/tcpm.c +++ b/drivers/staging/typec/tcpm.c @@ -991,7 +991,7 @@ static void svdm_

[PATCH] Staging:typec:tcpm.c : Fixed error Macros with complex values should be enclosed in parentheses Added comment after spinlock_t_definition Signed-off-by: harsha

2017-08-25 Thread harsha
--- drivers/staging/typec/tcpm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/typec/tcpm.c b/drivers/staging/typec/tcpm.c index b800313..a30c01b 100644 --- a/drivers/staging/typec/tcpm.c +++ b/drivers/staging/typec/tcpm.c @@ -217,7 +217,9 @@ struct tcpm_po

[PATCH] staging:typec:tcpm.c: Fixed check by adding comment after spinlock_t definition

2017-08-25 Thread harsha
Signed-off-by: harsha --- drivers/staging/typec/tcpm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/typec/tcpm.c b/drivers/staging/typec/tcpm.c index 9f4a5a5..9ab8d82 100644 --- a/drivers/staging/typec/tcpm.c +++ b/drivers/staging/typec/tcpm.c @@ -217,9

[PATCH] staging:typec:tcpm.c : Comparison to null changed as "!port->partner_altmode[pmdata->altmodes]"

2017-08-25 Thread harsha
--- drivers/staging/typec/tcpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/typec/tcpm.c b/drivers/staging/typec/tcpm.c index 630fe75..9f4a5a5 100644 --- a/drivers/staging/typec/tcpm.c +++ b/drivers/staging/typec/tcpm.c @@ -982,7 +982,7 @@ static void svdm_

[PATCH] staging:rtl8712:xmit_linux.c: Removed unnecessary blank line

2017-08-25 Thread harsha
Signed-off-by: harsha --- drivers/staging/rtl8712/xmit_linux.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8712/xmit_linux.c b/drivers/staging/rtl8712/xmit_linux.c index 03c6b0c..5d915c9 100644 --- a/drivers/staging/rtl8712/xmit_linux.c +++ b/drivers/staging/rtl8712

[PATCH] staging:rtl8712:xmit_linux.c: Avoid CamelCase

2017-08-25 Thread harsha
Signed-off-by: harsha --- drivers/staging/rtl8712/xmit_linux.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8712/xmit_linux.c b/drivers/staging/rtl8712/xmit_linux.c index 5d915c9..fd3380d 100644 --- a/drivers/staging/rtl8712/xmit_linux.c

[PATCH] staging:rtl8712:usb_ops_linux.c: Removed unnecessary parentheses around pio_q->intf

2017-08-25 Thread harsha
Signed-off-by: harsha --- drivers/staging/rtl8712/usb_ops_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/usb_ops_linux.c b/drivers/staging/rtl8712/usb_ops_linux.c index 32bac18..31f204a 100644 --- a/drivers/staging/rtl8712/usb_ops_linux.c

[PATCH] staging:rtl8712:usb_ops_linux.c: Removed paragraoh about writing to Free Software Foundation's mailing address

2017-08-25 Thread harsha
Signed-off-by: harsha --- drivers/staging/rtl8712/usb_ops_linux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/usb_ops_linux.c b/drivers/staging/rtl8712/usb_ops_linux.c index 441e76b..32bac18 100644 --- a/drivers/staging/rtl8712/usb_ops_linux.c

[PATCH] staging:rtl8712:usb_ops_linux.c: Avoid CamelCase

2017-08-25 Thread harsha
Signed-off-by: harsha --- drivers/staging/rtl8712/usb_ops_linux.c | 35 + 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/drivers/staging/rtl8712/usb_ops_linux.c b/drivers/staging/rtl8712/usb_ops_linux.c index 31f204a..7939902 100644 --- a/drivers

[PATCH] staging:rtl8712:usb_ops.c: Removed paragraph about writing to Free Software Foundation's mailing address

2017-08-25 Thread harsha
Signed-off-by: harsha --- drivers/staging/rtl8712/usb_ops.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/usb_ops.c b/drivers/staging/rtl8712/usb_ops.c index 332e2e5..e5d28b4 100644 --- a/drivers/staging/rtl8712/usb_ops.c +++ b/drivers/staging

[PATCH] staging:rtl8712:rtl871x_xmit.c: Removed unnecessary spaces after cast

2017-08-25 Thread harsha
Signed-off-by: harsha --- drivers/staging/rtl8712/rtl871x_xmit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c index e9af897..13c81680 100644 --- a/drivers/staging/rtl8712/rtl871x_xmit.c

[PATCH] staging:rtl8712:rtl871x_xmit.c: break line over 80 characters

2017-08-25 Thread harsha
Signed-off-by: harsha --- drivers/staging/rtl8712/rtl871x_xmit.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c index 6ecfe0f..e9af897 100644 --- a/drivers/staging/rtl8712/rtl871x_xmit.c

[PATCH] staging:rtl8712:rt871x_xmit.c: Removed the paragraph about writing to the Free Software Foundation's mailing address

2017-08-25 Thread harsha
Signed-off-by: harsha --- drivers/staging/rtl8712/rtl871x_xmit.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c index eda2aee..4e28209 100644 --- a/drivers/staging/rtl8712/rtl871x_xmit.c +++ b

[PATCH] staging:rt8712:xmit_linux.c: removed paragraph about writing to the Free software Foundation's mailing list

2017-08-25 Thread harsha
Signed-off-by: harsha --- drivers/staging/rtl8712/xmit_linux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/xmit_linux.c b/drivers/staging/rtl8712/xmit_linux.c index 4ee4136..d13fd15 100644 --- a/drivers/staging/rtl8712/xmit_linux.c +++ b/drivers

[PATCH] staging:rt8712:xmit_linux.c: Avoid multiple assignments in a single line

2017-08-25 Thread harsha
Signed-off-by: harsha --- drivers/staging/rtl8712/xmit_linux.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/xmit_linux.c b/drivers/staging/rtl8712/xmit_linux.c index d13fd15..03c6b0c 100644 --- a/drivers/staging/rtl8712/xmit_linux.c +++ b

[PATCH] Staging:android:ion:ion_system_heap.c : Using WARN_ON() rather than BUG_ON() Signed-off-by: harsha

2017-08-25 Thread harsha
--- drivers/staging/android/ion/ion_system_heap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion_system_heap.c b/drivers/staging/android/ion/ion_system_heap.c index 4dc5d7a..46125bc 100644 --- a/drivers/staging/android/ion/ion_system_heap.c +

[PATCH] Staging:android:ion:ion_heap.c : Using WARN_ON() rather than BUG_ON()

2017-08-25 Thread harsha
--- drivers/staging/android/ion/ion_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion_heap.c b/drivers/staging/android/ion/ion_heap.c index 91faa7f..476e741 100644 --- a/drivers/staging/android/ion/ion_heap.c +++ b/drivers/staging/android/i

  1   2   >