essy.
Also as you know Werner has already relicensed all the out of tree
drivers which Tuxedo could easily relicense to GPL v2 to GPL v2.
TL;DR: I do not believe that Tuxedo/Werner are acting in bad
faith here and IMHO it would be good to give them some leeway
here while they sort this out.
Regards,
Hans
le, it is recommended to
> relocate the time-sensitive applications to other cores for the
> duration of the test.
Thank you for your patch-series, I've applied the series to my
review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
as already been merged, superseding your patch:
https://lore.kernel.org/linux-media/20240213100439.457403-1-a...@kernel.org/
Marking your patch as Obsolete in patchwork.
Regards,
Hans
>
> Reviewed-by: Nathan Chancellor
> Signed-off-by: Ricardo Ribalda
> ---
> drivers/
//lore.kernel.org/linux-media/20240213095451.454142-1-a...@kernel.org/
So I'm marking your patch as 'Obsolete' in patchwork.
Regards,
Hans
> ---
> drivers/media/pci/sta2x11/sta2x11_vip.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>
mon/mtk_vcodec_fw_vpu.c but
otherwise
they are different, which is a bit odd.
Can you take a look at Arnd's patch and see if you need to incorporate his
changes
into your patch?
Regards,
Hans
On 26/02/2024 18:32, Ricardo Ribalda wrote:
> Building with LLVM=1 throws the following warning
On 10/4/23 15:57, Steven Rostedt wrote:
> On Wed, 4 Oct 2023 08:33:12 +0200
> Hans Verkuil wrote:
>
>> On 03/10/2023 23:41, Steven Rostedt wrote:
>>>
>>> Could this go through the linux-media tree, or if you give it an Ack, I'll
>>> take it through
ger.kernel.org?
The patch looks fine, so I'll pick it up.
Regards,
Hans
>
> -- Steve
>
>
> On Tue, 29 Aug 2023 14:46:01 -0600
> Ross Zwisler wrote:
>
>> From: Ross Zwisler
>>
>> The canonical location for the tracefs filesystem is a
Hi,
On 9/6/23 16:09, Ingo Molnar wrote:
>
> * Hans de Goede wrote:
>
>> Hi Ingo,
>>
>> On 9/6/23 14:10, Ingo Molnar wrote:
>>>
>>> * Justin Stitt wrote:
>>>
>>>> Both `strncpy` and `strcpy` are deprecated for use on NUL-termi
On 20/04/2021 19:19, Deepak R Varma wrote:
> On Tue, Apr 20, 2021 at 03:24:32PM +0200, Hans Verkuil wrote:
>> On 19/04/2021 21:12, Deepak R Varma wrote:
>>> Improve multi-line function argument alignment according to the code style
>>> guidelines. Resolves checkpatch
> Reported-by: kernel test robot
> Signed-off-by: Dan Carpenter
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branc
e
>> CEC or not ?
>
> Actually, the CEC config bit is right, the HW exists and should be
> functional, but
> this bit doesn't tell if the CEC signal is connected to something.
>
> This lies in the IP integration, like other bits under the
> "amlogic,meson-*-
> Addresses-Coverity: ("Unsigned compared against 0")
> Fixes: 8074a79fad2e ("platform/x86: intel_pmc_core: Add option to set/clear
> LPM mode")
> Signed-off-by: Colin Ian King
Thank you for the patch, but I already send out the same patch myself
yesterday, so thi
int analog_gain, digital_gain;
>> +u32 analog_gain_to_write = 0;
>>
>
> this patch is made of multiple logical changes, i.e. more than one
> variable at a time are renamed. Maybe this should be split in
> one patch per variable name.
I'm OK with this, it's pretty readable and obvious what is going on.
Regards,
Hans
y: email address mismatch: 'From: Deepak R Varma
' != 'Signed-off-by: Deepak R Varma
'
Which email should I use? Ideally you should post from the same email
as the Signed-off-by.
Regards,
Hans
> ---
> drivers/staging/media/atomisp/i2c/atomisp-gc0310.c |
t; +const struct atomisp_format_bridge*
Keep the space before the *!
Regards,
Hans
> +get_atomisp_format_bridge_from_mbus(u32 mbus_code);
> bool atomisp_is_mbuscode_raw(uint32_t code);
> int atomisp_get_frame_pgnr(struct atomisp_device *isp,
> const struct
(!vf_info))
>>
>>
>> While here, please get rid of the unneeded parenthesis:
>>
>> if (!out_info || !vf_info)
>>
>>
>>> return -EINVAL;
>>>
>>> out_width = out_info->res.width;
>>
>>
>>
>> Thanks,
>> Mauro
> Updated Patch as per your feedback
Please don't post patches as an attachment. Just post it inline as you did the
first time, but with Subject prefix [PATCHv2].
Thanks!
Hans
On 20/04/2021 11:31, Benjamin Gaignard wrote:
>
> Le 20/04/2021 à 11:16, Hans Verkuil a écrit :
>> On 20/04/2021 11:10, Benjamin Gaignard wrote:
>>> Le 16/04/2021 à 17:14, Lucas Stach a écrit :
>>>> Am Freitag, dem 16.04.2021 um 15:08 +0200 schrieb Benjamin Gaig
art, so I wonder if pure hevc patches
>>> could be merged anyway ?
>>> They are reviewed and don't depend of how the ctrl block is managed.
>> I'm not really in a position to give any informed opinion about that
>> hvec patches, as I only skimmed them, but
residency in microseconds
> - Patch 8 adds missing LTR IPs for TGL
> - Patch 9 adds support for ADL-P which is based on TGL
>
> Applied on top of latest hans-review/review-hans
Thank you for your patch-series, I've applied the series to my
review-hans branch:
https://git.kernel
Hi,
On 4/19/21 10:02 AM, Luke Jones wrote:
> NP Hans, sorry about the length of time this took. Other duties etc.
>
> I appreciated the wealth of insight you were able to provide to enable this.
BTW, I see that your drivers/acpi/video_detect.c patch is marked as [PATCH 1/3]
I
gues
ing
drivers/acpi/video_detect.c patch.
Regards,
Hans
> Luke D. Jones (2):
> Revert "platform/x86: asus-nb-wmi: Drop duplicate DMI quirk
> structures"
> Revert "platform/x86: asus-nb-wmi: add support for ASUS ROG Zephyrus
> G14 and G15"
residency in microseconds
> - Patch 8 adds missing LTR IPs for TGL
> - Patch 9 adds support for ADL-P which is based on TGL
>
> Applied on top of latest hans-review/review-hans
Thank you, the series looks good to me know, except for one very minor
issue in patch 5, which as I already
mory mapped but are
> available from an ACPI _DSM. Collect the requirements for Tiger Lake using
> the _DSM method and store in a buffer.
>
> Signed-off-by: Gayatri Kammela
> Co-developed-by: David E. Box
> Signed-off-by: David E. Box
> Reviewed-by: Hans de Goede
> ---
are not memory mapped but are
> available from an ACPI _DSM. Collect the requirements for Tiger Lake using
> the _DSM method and store in a buffer.
>
> Signed-off-by: Gayatri Kammela
> Co-developed-by: David E. Box
> Signed-off-by: David E. Box
> Reviewed-by: Hans de Goede
irqreturn_t atomisp_isr_thread(int irq, void *isp_ptr);
> -const struct atomisp_format_bridge *get_atomisp_format_bridge_from_mbus(
> -u32 mbus_code);
> +const struct atomisp_format_bridge
> +*get_atomisp_format_bridge_from_mbus(u32 mbus_code);
You keep the * on the previous line sin
remote,
Add this line to the previous line. That looks a bit better and is one line
shorter.
Regards,
Hans
> + struct
> tegra_vi_graph_entity);
> if (IS_ERR(tvge)) {
> ret = PTR_ERR(tvge);
> dev_err(vi->dev,
>
(start of frame) segment depends on width, height and sampling ratio
> of each color component */
> +/*
> + * SOF (start of frame) segment depends on width,
> + * height and sampling ratio of each color component
> + */
> +
No need for this extra newline. The comment block d
C(debug, "Debug level (0-4)");
> } while (0)
>
> /* =
/* should be on a line by itself:
/*
* =
That said, I would just delete those '=
g to do though.
I've tested that the driver still works after this.
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch o
mehow forgot to pass -s to "git am", this is fixed now.
Regards,
Hans
On 13/04/2021 20:21, ascordeiro wrote:
> Em ter, 2021-04-13 às 17:06 +0200, Hans Verkuil escreveu:
>> On 12/04/2021 15:42, Aline Santana Cordeiro wrote:
>>> Remove unused macro functions "to_iss_device()", "to_device()",
>>> and "v4l2_dev_to_iss
On 13/04/2021 17:49, Stanimir Varbanov wrote:
> Hi Hans,
>
> Any comments?
Thanks for the reminder, I replied to the patch.
Regards,
Hans
>
> On 3/2/21 11:53 AM, Stanimir Varbanov wrote:
>> Hi,
>>
>> This series add a new intra-refresh period control
t V4L2_CID_MPEG_VIDEO_CYCLIC_INTRA_REFRESH_MB is
enumerated in the venus driver, but doesn't do anything. Wouldn't it be
better to remove it?
Regards,
Hans
> +Applicable to H264 and HEVC encoders.
> +
> ``V4L2_CID_MPEG_VIDEO_FRAME_RC_ENABLE (boolean)``
>
e almost a language by themselves, and the
usual alignment rules do not apply. Look at other existing trace.h files
in the kernel and you'll see that they have their own coding style.
So I prefer not to apply this patch.
You couldn't have known that, so it's not your fault.
Regards,
ut:
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per
line)
#9:
This indicates the value of canvas indexes will remain constant throughout
execution.
Regards,
Hans
>
> Reported-by: kernel test robot
> Signed-off-by: Mitali Borkar
> ---
> Cha
ly v4l2_dev_to_iss_device appears to be unused.
Regards,
Hans
>
> Signed-off-by: Aline Santana Cordeiro
> ---
> drivers/staging/media/omap4iss/iss.h | 8
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/staging/media/omap4iss/iss.h
> b/driver
Missing commit message.
You used to have one in v1 of this patch!
Regards,
Hans
On 10/04/2021 17:33, Mitali Borkar wrote:
> Signed-off-by: Mitali Borkar
> ---
> Changes from v2:- No changes.
> Changes from v1:- NO changes.
>
> drivers/staging/media/zo
ssue as the other patches: this patch depends on other local changes
so won't apply to mainline code...
Regards,
Hans
> -#define ZR36057_VFEHCR_H_START 10
> -#define ZR36057_VFEHCR_H_END 0
> -#define ZR36057_VFEHCR_HMASK 0x3ff
> +#define ZR
n applied in the media subsystem tree.
Regards,
Hans
> ---
> drivers/staging/media/omap4iss/iss.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/omap4iss/iss.c
> b/drivers/staging/media/omap4iss/iss.c
> index dae9073
h, so
it won't apply against the mainline code.
Regards,
Hans
>
> diff --git a/drivers/staging/media/zoran/zr36050.c
> b/drivers/staging/media/zoran/zr36050.c
> index 703064009c6b..b89afa239b0c 100644
> --- a/drivers/staging/media/zoran/zr36050.c
> +++ b/drivers
36060_set_sof(struct zr36060 *ptr)
>
Same problem as with other patches: this sits on top of your v1, so won't apply
to mainline code.
Regards,
Hans
On 13/04/2021 13:09, Mitali Borkar wrote:
> On Tue, Apr 13, 2021 at 09:26:01AM +0200, Hans Verkuil wrote:
>> On 13/04/2021 08:27, Mitali Borkar wrote:
>>> Declared 32 bit unsigned int as static constant inside a function
>>> appropriately.
>>>
>>> Repo
gt;micmute_led ? LED_ON :LED_OFF);
> 7) If "LED" is set to on dell-privacy notifies EC, and timeout is cancelled,
>HW mic mute activated. If EC not notified, HW mic mute will also be
>activated when timeout used up, it is just later than active ack
>
> Signed-off-by
e clocks
> turned on is not an issue.
>
> Fixes: 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")
> Reviewed-by: Andy Shevchenko
> Signed-off-by: Steffen Dirkwinkel
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://gi
This driver implements such an ACPI driver.
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
ing and the file is set to read-only mode via is_visible
> handler.
>
> The register in MMIO space is defined for Cannon Lake and newer PCHs.
>
> Cc: Hans de Goede
> Cc: David E Box
> Reviewed-by: Andy Shevchenko
> Signed-off-by: Tamar Mashiah
> Signed-off-by: Tomas Winkl
s is a patch on top of your previous (v1) patch. That won't work
since the v1 is not merged, you need to make a patch against the current
mainline code.
Regards,
Hans
>
> amvdec_set_canvases(sess, canvas3, canvas4);
>
>
erged upstream and is
currently in for-nex.t. So IMHO you should use the new sysfs mechanism
for this rather then adding quirks to individual codec drivers.
Regards,
Hans
>
>
> v5 -> v6:
> * addresed review comments from Jaroslav
> * add quirks for micmute led control as s
On 11/04/2021 13:47, Mitali Borkar wrote:
> On Fri, Apr 09, 2021 at 12:53:35PM +0200, Hans Verkuil wrote:
>> On 09/04/2021 12:49, Mitali Borkar wrote:
>>> Added '*' before every line inside long(multi-line) comments. Removed
>>> '*/' from end of the c
ability.
>
> Signed-off-by: Mitali Borkar
> ---
> drivers/staging/media/meson/vdec/codec_mpeg12.c | 5 +++--
Also change drivers/staging/media/meson/vdec/codec_h264.c.
It's a nice improvement, so let's do this for both callers of
amvdec_set_canvases().
Regards,
i.o
>>
>> # Acer
>> obj-$(CONFIG_ACERHDF) += acerhdf.o
>> diff --git a/drivers/platform/x86/gigabyte-wmi.c
>> b/drivers/platform/x86/gigabyte-wmi.c
>> new file mode 100644
>> index ..fb4e6d4c1823
>> --- /dev/nul
quot;Forcing load on unknown platform"
If you are ok with these changes I can fix this up while merging, no need
to send a v4. Although if you prefer to send a v4 that is fine too.
Either way let me know.
Regards,
Hans
p.s.
For v4 or for a next patch, the way to add the changelog so that it
Hi,
On 4/10/21 8:56 AM, Guenter Roeck wrote:
> On 4/8/21 11:02 PM, Thomas Weißschuh wrote:
>> On Do, 2021-04-08T08:00-0700, Guenter Roeck wrote:
>>> On 4/8/21 2:36 AM, Hans de Goede wrote:
>>>> On 4/7/21 9:43 PM, Thomas Weißschuh wrote:
>>>>> On M
On 09/04/2021 17:11, Mitali Borkar wrote:
> On Fri, Apr 09, 2021 at 09:23:22AM +0200, Hans Verkuil wrote:
>> Hi Mitali,
>>
>> On 08/04/2021 22:38, Mitali Borkar wrote:
>>> Added spaces around '<<' operator to improve readability and meet linux
>&
uot;videocodec.h"
>
> /* it doesn't make sense to have more than 20 or so,
The coding style says that /* is on a line of its own. So change that too.
Regards,
Hans
> - * just to prevent some unwanted loops */
> + * just to prevent some unwanted loops
> + */
&g
kpatch.pl warns about that, so did you run checkpatch.pl after your
modifications
were made? After fixing checkpatch issues, always run it again to make sure the
issue
is really fixed and not just replaced by another issue.
Regards,
Hans
> #define MAX_CODECS 20
>
> /* amo
});
The alignment here is because the 2nd and 3rd arguments belong together, so
the alignment indicates that. In order to keep that I would add a newline
after 'sess,' as well. Same as is done in meson/vdec/codec_h264.c.
Regards,
Hans
> if (ret)
> goto free_workspace;
>
>
coding style guidelines: the preferred style for long comments is:
/*
* text
* text
*/
Regards,
Hans
> static int zr36060_set_sof(struct zr36060 *ptr)
> {
> char sof_data[34]; // max. size of register set
>
ND0
#define ZR36057_VFEHCR_HMASK0x3ff
Same for all the other register blocks. Use tabs to do the alignment
instead of spaces, as is currently the case.
The second patch can replace the (0<<3) etc. to BIT(0).
That would be a nice cleanup of this rather messy header.
Thanks!
Hans
.
I have dropped the ball a bit on posting a v2 of my series using this.
I'll prepare a v2 of my series, addressing Heikki's review comments
to my v1 right away. I'll post a v2 at the latest tomorrow.
This is something which is on my TODO list anyways and this way we will
sa
is one over to drivers/hwmon if that has your
preference.
As for other cases then this driver, if you want to make sure you are at
least Cc-ed on all hwmon related changes I'm fine with adding you as a
reviewer to the pdx86 MAINTAINERS entry.
Regards,
Hans
>
> Guenter
>
>
merge
from an immutable branch from the tip folks, but I did a rebase -i
to fixup a typo in a commit message and that seems to have flattened
the merge :|
I'll redo the last 3 commits in pdx/for-next to re-add the merge
and do a forced push.
Regards,
Hans
Hi,
On 4/8/21 11:25 AM, Heikki Krogerus wrote:
> On Thu, Apr 08, 2021 at 11:10:38AM +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 4/7/21 11:15 AM, Zhen Lei wrote:
>>> Fixes the following W=1 kernel build warning:
>>>
>>> drivers/usb/typec/tcpm/tcp
Hi,
On 4/7/21 9:43 PM, Thomas Weißschuh wrote:
> Hi Hans,
>
> On Mi, 2021-04-07T17:54+0200, Hans de Goede wrote:
>> Thank you for your new driver and thank you for the quick respin
>> addressing Barnabás' request to make it a WMI driver.
>>
>> The code look
gned-off-by: Zhen Lei
I have a patch pending:
https://www.spinics.net/lists/linux-usb/msg197684.html
Which actually uses this. I really need to (and plan to) brush the dust of
this one soon and submit a new version.
As such I would prefer for these ops to not get removed. But I guess I
can alwa
ponsive for users.
>
> To achieve that delay switch to updating via a delayed work struct,
> which means that we can also get rid of some locking.
>
> Signed-off-by: Maximilian Luz
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kerne
they want you to sign a NDA
of sorts to view docs, then make sure that it contains some language
about them allowing you to release an opensource driver for their
hardware based on the "protected" information.
Regards,
Hans
On 4/5/21 10:48 PM, Thomas Weißschuh wrote:
> Cha
u can use this reference to record your contributions:
https://patchwork.linuxtv.org/project/linux-media/list/?series=5052
The patch states will change to Accepted once it is merged in our media tree
here: https://git.linuxtv.org/media_tree.git/log/
I hate CamelCase, so this is a nice cleanup :-)
Regards,
Hans
ect/linux-media/patch/475dbbe5774cbfed2d924807d8a3cfeb84b3d845.1617287509.git.martinsdecarvalhobeat...@gmail.com/
The state will change to Accepted once it is merged in our media tree
here: https://git.linuxtv.org/media_tree.git/log/
Regards,
Hans
>
> Signed-off-by:
ancelled,
>>HW mic mute activated. If EC not notified, HW mic mute will also be
>>activated when timeout used up, it is just later than active ack
>>
>> Signed-off-by: Perry Yuan
>> ---
>> v5 -> v6:
>> * addressed feedback from Hans
>> * a
RS: Adjust Dell drivers to email alias
> MAINTAINERS: Add missing section for alienware-wmi driver
> platform/x86: Adjust Dell drivers to a personal email address
Thank you for your patch-series, I've applied the series to my
review-hans branch:
https://git.kernel.org/pub/scm/linux
residency in microseconds
> - Patch 8 adds missing LTR IPs for TGL
> - Patch 9 adds support for ADL-P which is based on TGL
>
> Applied on top of latest 5.12-rc2 based hans-review/review-hans
Thnak you for this series, this mostly is fine, a few small remarks
on patch 5/9 and 7/9 if you
Hi,
On 4/1/21 5:05 AM, David E. Box wrote:
> Alder PCH-P is based on Tiger Lake PCH.
>
> Signed-off-by: David E. Box
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
> ---
> drivers/platform/x86/intel_pmc_core.c | 1 +
> 1 file changed, 1 inse
o adjust the number of LTR IPs for Tiger Lake to the correct amount.
>
> Signed-off-by: Gayatri Kammela
> Signed-off-by: David E. Box
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
> ---
> drivers/platform/x86/intel_pmc_core.c | 2 ++
> drivers
lease refer to the patch changelogs for details.
Thanks, the entire series looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
_residency_offset;
> @@ -313,4 +319,18 @@ struct pmc_dev {
>i < pmcdev->num_modes; \
>i++, mode = pmcdev->lpm_en_modes[i])
>
> +#define DEFINE_PMC_CORE_ATTR_WRITE(__name) \
> +static int __name ## _open(struct inode *inode, struct file *file) \
> +{\
> + return single_open(file, __name ## _show, inode->i_private);\
> +}\
> + \
> +static const struct file_operations __name ## _fops = {
> \
> + .owner = THIS_MODULE, \
> + .open = __name ## _open, \
> + .read = seq_read, \
> + .write = __name ## _write, \
> + .release= single_release, \
> +}
> +
> #endif /* PMC_CORE_H */
>
Regards,
Hans
gt; Signed-off-by: David E. Box
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
> ---
> drivers/platform/x86/intel_pmc_core.c | 86 +++
> 1 file changed, 86 insertions(+)
>
> diff --git a/drivers/platform/x86/intel_pmc_core.c
Hi,
On 4/1/21 5:05 AM, David E. Box wrote:
> From: Gayatri Kammela
>
> Platforms that support low power modes (LPM) such as Tiger Lake maintain
> requirements for each sub-state that a readable in the PMC. However, unlike
> LPM status registers, requirement registers are not memory mapped but ar
this value then divide
> by two to maintain accuracy.
>
> Signed-off-by: Gayatri Kammela
> Signed-off-by: David E. Box
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
> ---
> drivers/platform/x86/intel_pmc_core.c | 14 --
> driver
S0i3.2 0
>
> Suggested-by: David E. Box
> Signed-off-by: Gayatri Kammela
> Signed-off-by: David E. Box
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
> ---
> drivers/platform/x86/intel_pmc_core.c | 59 ++-
> d
his directly. Since the driver now binds to an ACPI device,
> remove the global pmc_dev in favor of one that is allocated during probe.
> Modify users of the global to obtain the object by argument instead.
>
> Signed-off-by: David E. Box
Thanks, patch looks good to me:
Reviewed-by:
o a function that will handle each quirk if its variable
> condition is met. This allows removing the global pmc_dev later.
>
> Signed-off-by: David E. Box
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
> ---
> drivers/platfor
ned by different people as well.
The patch itself looks OK, but it really has to be two separate patches.
Regards,
Hans
>
> Signed-off-by: Muhammad Usama Anjum
> ---
> drivers/staging/axis-fifo/axis-fifo.c | 1 -
> drivers/staging/media/meson/vdec/vdec.c | 8 ++--
runtime
> PM counter on error.
Nice that a new function was created for this. Good news.
Just a heads up: if you make more patches like this, make sure you
fix the typo 'rumtime' to 'runtime'. I'll fix it manually, no need
to repost. And 'rumtime' does sound
d_link(&iss->ipipeif.subdev.entity,
> IPIPEIF_PAD_SOURCE_VP,
> + &iss->ipipe.subdev.entity, IPIPE_PAD_SINK,
> 0);
> if (ret < 0)
> return ret;
>
> - ret = media_create_pad_link(
> - &iss->ipipe.subdev.entity, IPIPE_PAD_SOURCE_VP,
> - &iss->resizer.subdev.entity, RESIZER_PAD_SINK, 0);
> + ret = media_create_pad_link(&iss->ipipe.subdev.entity,
> IPIPE_PAD_SOURCE_VP,
> + &iss->resizer.subdev.entity,
> RESIZER_PAD_SINK, 0);
> if (ret < 0)
> return ret;
>
>
These, however, are readability improvements, so I'm happy with that.
Regards,
Hans
nline kernel doesn't have
host1x_syncpt_put, only host1x_syncpt_free.
Also, the subject line is very vague, something like this is much more
descriptive:
[PATCH] media: tegra-video: replace host1x_syncpt_free by host1x_syncpt_put
Regards,
Hans
>
> Fixes: 3028a00c55bf ('
real
> timeout in micro-seconds using ktime. When the command response takes
> more than average processing time, yield to other tasks. The worst case
> timeout is extended upto 1 milli-second.
>
> Signed-off-by: Srinivas Pandruvada
Thank you for your patch, I've applied t
ater. Internally we have some more code for
> hardware monitoring, more leds, watchdogs etc. This will follow some
> day.
IT seems there still is significant discussion surrounding the LED and watchdog
drivers which use patch 1/4 as parent-driver.
I'm going to hold of on merging 1/4 and
ed value")
> Signed-off-by: Colin Ian King
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've push
igned-off-by: Dan Carpenter
>
> Good catch, thanks!
>
> Reviewed-by: Maximilian Luz
Thank you for the review, I've merged this now:
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-driver
nk you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I&#
Hi Linus,
Here is a single bugfix (on top of platform-drivers-x86-v5.12-2) to fix
spurious wakeups from suspend caused by recent intel-hid driver changes.
Regards,
Hans
The following changes since commit d1635448f1105e549b4041aab930dbc6945fc635:
platform/x86: intel_pmc_core: Ignore GBE LTR
Ack.
> I've left it in register form in order to keep the user space as it has
> access to the register (/dev/mem)
>>
>> Also the Documentation/ABI/testing/sysfs-platform-intel-pm file pretty much
>> describes this as direct register access rather then as some reset mecha
hat it has to be converted to yaml, and I will do that if
> it looks good.
This series looks good to me.
One thing that can be improved in a v3 is a short explanation of the various
abbreviations: CBV, RLP, HIS, DPC, etc.
Regards,
Hans
>
> Feedback is appreciated.
> T
ntel-pm file pretty much
describes this as direct register access rather then as some reset mechanism.
So I think it would be better to call the new file extended_test_mode_register3,
this will also be useful if we need to provide access to other bits in the
same register later; and this will be a g
Hi,
On 4/6/21 9:40 PM, Wolfram Sang wrote:
>
>> What is the plan for merging this patch / this series ?
>
> I'll take the series via I2C.
Ok, that works for me.
Regards,
Hans
0->subdev, client, &tw9900_subdev_ops);
> + tw9900->subdev.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE |
> + V4L2_SUBDEV_FL_HAS_EVENTS;
> +
> + hdl = &tw9900->hdl;
> +
> + v4l2_ctrl_handler_init(hdl, 2);
> +
> + v4l2_ctrl_new_std(hdl, &tw9900_ctrl_ops, V4L2_CID_BRIGHTNESS,
> + -128, 127, 1, 0);
> + v4l2_ctrl_new_std(hdl, &tw9900_ctrl_ops, V4L2_CID_CONTRAST,
> + 0, 255, 1, 0x60);
> +
> + tw9900->subdev.ctrl_handler = hdl;
> + if (hdl->error) {
> + int err = hdl->error;
> +
> + v4l2_ctrl_handler_free(hdl);
> + return err;
> + }
> +
> + ret = tw9900_power_on(tw9900);
> + if (ret)
> + return ret;
> +
> + ret = tw9900_check_id(tw9900, client);
> + if (ret)
> + goto err_power_off;
> +
> + tw9900->subdev.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
> + tw9900->pad.flags = MEDIA_PAD_FL_SOURCE;
> + tw9900->subdev.entity.function = MEDIA_ENT_F_DV_DECODER;
> +
> + ret = media_entity_pads_init(&tw9900->subdev.entity, 1, &tw9900->pad);
> + if (ret < 0)
> + goto err_power_off;
> +
> + ret = v4l2_async_register_subdev(&tw9900->subdev);
> + if (ret) {
> + dev_err(dev, "v4l2 async register subdev failed\n");
> + goto err_clean_entity;
> + }
> +
> + pm_runtime_set_active(dev);
> + pm_runtime_enable(dev);
> + pm_runtime_idle(dev);
> +
> + return 0;
> +
> +err_clean_entity:
> + media_entity_cleanup(&tw9900->subdev.entity);
> +err_power_off:
> + tw9900_power_off(tw9900);
> +
> + return ret;
> +}
> +
> +static int tw9900_remove(struct i2c_client *client)
> +{
> + struct v4l2_subdev *sd = i2c_get_clientdata(client);
> + struct tw9900 *tw9900 = to_tw9900(sd);
> +
> + v4l2_async_unregister_subdev(sd);
> + media_entity_cleanup(&sd->entity);
> +
> + pm_runtime_disable(&client->dev);
> + if (!pm_runtime_status_suspended(&client->dev))
> + tw9900_power_off(tw9900);
> + pm_runtime_set_suspended(&client->dev);
> +
> + return 0;
> +}
> +
> +static const struct of_device_id tw9900_of_match[] = {
> + { .compatible = "techwell,tw9900" },
> + {},
> +};
> +MODULE_DEVICE_TABLE(of, tw9900_of_match);
> +
> +static struct i2c_driver tw9900_i2c_driver = {
> + .driver = {
> + .name = "tw9900",
> + .pm = &tw9900_pm_ops,
> + .of_match_table = tw9900_of_match
> + },
> + .probe = tw9900_probe,
> + .remove = tw9900_remove,
> +};
> +
> +module_i2c_driver(tw9900_i2c_driver);
> +
> +MODULE_DESCRIPTION("tw9900 decoder driver");
> +MODULE_LICENSE("GPL v2");
>
Regards,
Hans
esirable.
Can you please provide a new version where the purpsoe of the newly
introduced sysfs file is made more clear, both in the commit-msg
as well as in the:
Documentation/ABI/testing/sysfs-platform-intel-pmc
File ?
Regards,
Hans
>
> The register in MMIO space is defined for Can
;
use -> use the
> reg-name even if it is deprecated now.
Regards,
Hans
>
> Signed-off-by: Benjamin Gaignard
> Reviewed-by: Rob Herring
> Reviewed-by: Philipp Zabel
> ---
> version 7:
> - Add Rob and Philipp reviewed-by tag
> - Change syscon phandle
ssible syscon.
in -> to
> It will used to access to the VPU control registers.
to the -> the
Regards,
Hans
>
> Signed-off-by: Benjamin Gaignard
> Acked-by: Rob Herring
> Acked-by: Lee Jones
> ---
> version 8:
> - Add Lee ack
>
> version 7:
>
1 - 100 of 2664 matches
Mail list logo
