Re: [PATCH] lib/crc32: add SPDX license identifier

2025-05-14 Thread Greg KH
On Tue, May 13, 2025 at 11:14:25PM -0700, Eric Biggers wrote: > On Wed, May 14, 2025 at 08:11:40AM +0200, Thomas Gleixner wrote: > > On Tue, May 13 2025 at 22:24, Eric Biggers wrote: > > > > > From: Eric Biggers > > > > > > lib/crc32.c and include/linux/crc32.h got missed by the bulk SPDX > > > c

Re: [PATCH 8/9] CodingStyle: tell people how to split long "for" loops

2025-05-12 Thread Greg KH
On Mon, May 12, 2025 at 07:20:23PM +0300, Alexey Dobriyan wrote: > On Sat, May 10, 2025 at 07:56:03PM +0100, David Laight wrote: > > On Fri, 9 May 2025 23:34:29 +0300 > > Alexey Dobriyan wrote: > > > > > Signed-off-by: Alexey Dobriyan > > > --- > > > Documentation/process/coding-style.rst | 16

Re: [PATCH 1/9] CodingStyle: make Documentation/CodingStyle into symlink

2025-05-12 Thread Greg KH
On Mon, May 12, 2025 at 07:08:53PM +0300, Alexey Dobriyan wrote: > On Sat, May 10, 2025 at 04:05:29AM -0600, Jonathan Corbet wrote: > > Alexey Dobriyan writes: > > > > > Every time I open Documentation/CodingStyle it says the party moved > > > somewhere else. :-( > > > > > > Of course, I forget w

Re: [PATCH 9/9] CodingStyle: flip the rule about curlies

2025-05-12 Thread Greg KH
On Mon, May 12, 2025 at 09:43:10AM -0700, Jeff Johnson wrote: > On 5/9/2025 11:18 PM, Greg KH wrote: > > On Fri, May 09, 2025 at 11:34:30PM +0300, Alexey Dobriyan wrote: > >> Require set of curlies {} in all if/else branches and all loops > >> not matter how simple. >

Re: [RESEND PATCH] selftests/bpf: Fix bpf selftest build warning

2025-05-12 Thread Greg KH
On Mon, May 12, 2025 at 02:45:11PM +0530, Saket Kumar Bhaskar wrote: > On linux-next, build for bpf selftest displays a warning: > > Warning: Kernel ABI header at 'tools/include/uapi/linux/if_xdp.h' > differs from latest version at 'include/uapi/linux/if_xdp.h'. > > Commit 8066e388be48 ("net: add

Re: [PATCH 6/9] CodingStyle: recommend static_assert/_Static_assert

2025-05-09 Thread Greg KH
On Fri, May 09, 2025 at 11:34:27PM +0300, Alexey Dobriyan wrote: > Linux's BUG_ON is done backwards (condition is inverted). > But it is a long story. > > However C11/C23 allow to partially transition to what all normal > programmers are used to, namely assert(). > > Deprecate BUILD_BUG_ON, recom

Re: [PATCH 4/9] CodingStyle: mention "typedef struct S {} S;" if typedef is used

2025-05-09 Thread Greg KH
On Fri, May 09, 2025 at 11:34:25PM +0300, Alexey Dobriyan wrote: > Signed-off-by: Alexey Dobriyan > --- > Documentation/process/coding-style.rst | 14 ++ > 1 file changed, 14 insertions(+) We can't take patches without any changelog text, sorry.

Re: [PATCH 9/9] CodingStyle: flip the rule about curlies

2025-05-09 Thread Greg KH
On Fri, May 09, 2025 at 11:34:30PM +0300, Alexey Dobriyan wrote: > Require set of curlies {} in all if/else branches and all loops > not matter how simple. Sorry, but no, we are not going to change this long-term coding style rule for no real reason at this point in time. greg k-h

Re: [PATCH v3 0/5] module: Strict per-modname namespaces

2025-05-02 Thread Greg KH
On Fri, May 02, 2025 at 04:12:04PM +0200, Peter Zijlstra wrote: > Hi! > > Implement means for exports to be available to an explicit list of named > modules. By explicitly limiting the usage of certain exports, the abuse > potential/risk is greatly reduced. > > Changes since v2: > > - switch to

Re: [PATCH v10 0/3] rust: extend `module!` macro with integer parameter support

2025-05-01 Thread Greg KH
On Thu, May 01, 2025 at 09:53:36AM +0200, Andreas Hindborg wrote: > Extend the `module!` macro with support module parameters. Also add some > string > to integer parsing functions and updates `BStr` with a method to strip a > string > prefix. > > Based on code by Adam Bratschi-Kaye lifted from

Re: [PATCH v4 4/4] drivers: base: handle module_kobject creation

2025-04-15 Thread Greg KH
On Thu, Feb 27, 2025 at 10:49:30AM -0800, Shyam Saini wrote: > module_add_driver() relies on module_kset list for > /sys/module//drivers directory creation. > > Since, > commit 96a1a2412acba ("kernel/params.c: defer most of param_sysfs_init() to > late_initcall time") > drivers which are initiali

Re: [PATCH v4 0/4] Properly handle module_kobject creation

2025-04-08 Thread Greg KH
On Tue, Apr 08, 2025 at 12:19:22PM -0700, Shyam Saini wrote: > Hi Greg, > > > On 2/27/25 19:49, Shyam Saini wrote: > > > Hi Everyone, > > > > > > This patch series fixes handling of module_kobject creation. > > > A driver expect module_kset list populated with its corresponding > > > module_kobje

Re: [PATCH v2] remoteproc: Add device awake calls in rproc boot and shutdown path

2025-03-16 Thread Greg KH
On Mon, Mar 17, 2025 at 12:08:03PM +0530, Souradeep Chowdhury wrote: > Add device awake calls in case of rproc boot and rproc shutdown path. > Currently, device awake call is only present in the recovery path > of remoteproc. If a user stops and starts rproc by using the sysfs > interface, then on

Re: [PATCH v1] remoteproc: Add device awake calls in rproc boot and shutdown path

2025-03-13 Thread Greg KH
On Thu, Mar 13, 2025 at 02:42:10PM +0530, Souradeep Chowdhury wrote: > Gentle Reminder. > > > On 3/3/2025 2:38 PM, Souradeep Chowdhury wrote: > > Add device awake calls in case of rproc boot and rproc shutdown path. > > Currently, device awake call is only present in the recovery path > > of remo

Re: [PATCH] selftests/mount: Explicitly define buffer size

2025-02-22 Thread Greg KH
On Sat, Feb 22, 2025 at 01:47:11PM +0530, ritvikf...@gmail.com wrote: > From: Ritvik Gupta > > Define macro ('MAX_BUF_SIZE') for buffer size > instead of hardcoded value '4096', to improve > readability. > > Signed-off-by: Ritvik Gupta > --- > tools/testing/selftests/mount/unprivileged-remount

Re: [PATCH v3 4/4] drivers: base: handle module_kobject creation

2025-02-20 Thread Greg KH
On Tue, Feb 11, 2025 at 01:48:42PM -0800, Shyam Saini wrote: > module_add_driver() relies on module_kset list for > /sys/module//drivers directory creation. > > Since, > commit 96a1a2412acba ("kernel/params.c: defer most of param_sysfs_init() to > late_initcall time") > drivers which are initiali

Re: [PATCH v2] selftests:sysctl:Fix minor typos in sysctl test

2025-02-19 Thread Greg KH
On Wed, Feb 19, 2025 at 07:33:01PM +, Sumya Hoque wrote: > > Signed-off-by: Sumya Hoque > --- > tools/testing/selftests/sysctl/sysctl.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/sysctl/sysctl.sh > b/tools/testing/selftests/sysctl/

Re: [PATCH v4 4/4] rust: add parameter support to the `module!` macro

2025-01-09 Thread Greg KH
On Thu, Jan 09, 2025 at 02:03:39PM +0100, Andreas Hindborg wrote: > "Greg KH" writes: > > > On Thu, Jan 09, 2025 at 11:54:59AM +0100, Andreas Hindborg wrote: > >> This patch includes changes required for Rust kernel modules to utilize > >> module pa

Re: [PATCH v4 4/4] rust: add parameter support to the `module!` macro

2025-01-09 Thread Greg KH
On Thu, Jan 09, 2025 at 11:54:59AM +0100, Andreas Hindborg wrote: > This patch includes changes required for Rust kernel modules to utilize > module parameters. This code implements read only support for integer > types without `sysfs` support. I know you want to keep this simple for now, but will

Re: [PATCH v7 00/16] Device / Driver PCI / Platform Rust abstractions

2024-12-20 Thread Greg KH
On Thu, Dec 19, 2024 at 06:04:02PM +0100, Danilo Krummrich wrote: > This patch series implements the necessary Rust abstractions to implement > device drivers in Rust. > > This includes some basic generalizations for driver registration, handling of > ID > tables, MMIO operations and device resou

Re: [PATCH v6 15/16] samples: rust: add Rust platform sample driver

2024-12-15 Thread Greg KH
On Thu, Dec 12, 2024 at 05:33:46PM +0100, Danilo Krummrich wrote: > Add a sample Rust platform driver illustrating the usage of the platform > bus abstractions. > > This driver probes through either a match of device / driver name or a > match within the OF ID table. > > Reviewed-by: Rob Herring

Re: [PATCH v6 09/16] rust: pci: add basic PCI device / driver abstractions

2024-12-15 Thread Greg KH
On Thu, Dec 12, 2024 at 05:33:40PM +0100, Danilo Krummrich wrote: > +impl DeviceId { > +const PCI_ANY_ID: u32 = !0; > + > +/// PCI_DEVICE macro. > +pub const fn new(vendor: u32, device: u32) -> Self { > +Self(bindings::pci_device_id { > +vendor, > +device

Re: [PATCH -v2 1/7] module: Convert symbol namespace to string literal

2024-12-02 Thread Greg KH
On Mon, Dec 02, 2024 at 04:15:33PM +0100, Peter Zijlstra wrote: > On Mon, Dec 02, 2024 at 03:59:47PM +0100, Peter Zijlstra wrote: > > Clean up the existing export namespace code along the same lines of > > 33def8498fdd ("treewide: Convert macro and uses of __section(foo) to > > __section("foo")") a

Re: [PATCH v2 1/4] PCI: qcom-ep: Mark BAR0/BAR2 as 64bit BARs and BAR1/BAR3 as RESERVED

2024-11-30 Thread Greg KH
On Fri, Nov 29, 2024 at 01:55:37PM -0600, Bjorn Helgaas wrote: > On Fri, Nov 29, 2024 at 02:54:12PM +0530, Manivannan Sadhasivam wrote: > > On all Qcom endpoint SoCs, BAR0/BAR2 are 64bit BARs by default and software > > cannot change the type. So mark the those BARs as 64bit BARs and also mark > >

Re: [PATCH 0/2] module: Block modules by Tuxedo from accessing GPL symbols

2024-11-15 Thread Greg KH
On Fri, Nov 15, 2024 at 11:59:47AM +0100, Werner Sembach wrote: > > Am 15.11.24 um 11:22 schrieb Greg KH: > > On Fri, Nov 15, 2024 at 10:40:56AM +0100, Werner Sembach wrote: > > > Am 15.11.24 um 10:18 schrieb Greg KH: > > > > On Fri, Nov 15, 2024 at 10:00

Re: [PATCH 0/2] module: Block modules by Tuxedo from accessing GPL symbols

2024-11-15 Thread Greg KH
On Fri, Nov 15, 2024 at 10:40:56AM +0100, Werner Sembach wrote: > > Am 15.11.24 um 10:18 schrieb Greg KH: > > On Fri, Nov 15, 2024 at 10:00:23AM +0100, Werner Sembach wrote: > > > I guess what I try to convince you and others is that we _are_ taking Open > > > Source

Re: [PATCH 0/2] module: Block modules by Tuxedo from accessing GPL symbols

2024-11-15 Thread Greg KH
On Fri, Nov 15, 2024 at 10:00:23AM +0100, Werner Sembach wrote: > I guess what I try to convince you and others is that we _are_ taking Open > Source licenses seriously, but still there are mistakes to be made, > especially with complex projects like the Linux kernel, e.g. I'm not aware > of any ot

Re: [PATCH 1/2] module: Put known GPL offenders in an array

2024-11-14 Thread Greg KH
On Thu, Nov 14, 2024 at 11:31:33AM +0100, Uwe Kleine-König wrote: > Instead of repeating the add_taint_module() call for each offender, create > an array and loop over that one. This simplifies adding new entries > considerably. > > Signed-off-by: Uwe Kleine-König > --- > kernel/module/main.c |

Re: [PATCH 0/2] module: Block modules by Tuxedo from accessing GPL symbols

2024-11-14 Thread Greg KH
On Fri, Nov 15, 2024 at 07:09:49AM +0100, Werner Sembach wrote: > Hi, > > Am 15.11.24 um 05:43 schrieb Greg KH: > > On Thu, Nov 14, 2024 at 11:49:04AM +0100, Werner Sembach wrote: > > > Hello, > > > > > > Am 14.11.24 um 11:31 schrieb Uwe Kleine-König:

Re: [PATCH 0/2] module: Block modules by Tuxedo from accessing GPL symbols

2024-11-14 Thread Greg KH
On Thu, Nov 14, 2024 at 11:49:04AM +0100, Werner Sembach wrote: > Hello, > > Am 14.11.24 um 11:31 schrieb Uwe Kleine-König: > > Hello, > > > > the kernel modules provided by Tuxedo on > > https://gitlab.com/tuxedocomputers/development/packages/tuxedo-drivers > > are licensed under GPLv3 or later.

Re: [PATCH 2/2] module: Block modules by Tuxedo from accessing GPL symbols

2024-11-14 Thread Greg KH
On Thu, Nov 14, 2024 at 11:31:34AM +0100, Uwe Kleine-König wrote: > Tuxedo licenses the modules used on their hardware under GPLv3+, to > "keep control of the upstream pacing" – and want to re-license the code > while upstreaming. > > They were asked to then at least not use MODULE_LICENSE("GPL")

Re: [PATCH 2/2] module: Block modules by Tuxedo from accessing GPL symbols

2024-11-14 Thread Greg KH
On Thu, Nov 14, 2024 at 12:56:20PM +0100, Daniel Gomez wrote: > On Thu Nov 14, 2024 at 11:31 AM CET, Uwe Kleine-König wrote: > > Tuxedo licenses the modules used on their hardware under GPLv3+, to > > "keep control of the upstream pacing" – and want to re-license the code > > while upstreaming. > >

Re: [RFC] module: Strict per-modname namespaces

2024-11-06 Thread Greg KH
On Wed, Nov 06, 2024 at 08:02:40PM +0100, Peter Zijlstra wrote: > Hi, > > I've been wanting $topic for a while, and having just stumbled into the > whole namespace thing by accident, I figured I'd give it a go, most if > the hard parts seem to have already been done. > > It reserves and disallows

Re: [PATCH RESEND] vdpa: solidrun: Fix UB bug with devres

2024-10-16 Thread Greg KH
On Wed, Oct 16, 2024 at 01:16:32PM +0200, Philipp Stanner wrote: > On Wed, 2024-10-16 at 12:51 +0200, Greg KH wrote: > > On Wed, Oct 16, 2024 at 11:22:48AM +0200, Philipp Stanner wrote: > > > On Wed, 2024-10-16 at 12:08 +0300, Andy Shevchenko wrote: > > > > On Wed, Oc

Re: [PATCH RESEND] vdpa: solidrun: Fix UB bug with devres

2024-10-16 Thread Greg KH
On Wed, Oct 16, 2024 at 11:22:48AM +0200, Philipp Stanner wrote: > On Wed, 2024-10-16 at 12:08 +0300, Andy Shevchenko wrote: > > On Wed, Oct 16, 2024 at 09:25:54AM +0200, Philipp Stanner wrote: > > > In psnet_open_pf_bar() and snet_open_vf_bar() a string later passed > > > to > > > pcim_iomap_regio

Re: [PATCH RFC v3 03/10] openat2: explicitly return -E2BIG for (usize > PAGE_SIZE)

2024-10-09 Thread Greg KH
On Thu, Oct 10, 2024 at 07:40:36AM +1100, Aleksa Sarai wrote: > While we do currently return -EFAULT in this case, it seems prudent to > follow the behaviour of other syscalls like clone3. It seems quite > unlikely that anyone depends on this error code being EFAULT, but we can > always revert this

Re: [PATCH v4.19-v5.10] virtio_net: Fix napi_skb_cache_put warning

2024-09-05 Thread Greg KH
On Wed, Sep 04, 2024 at 02:08:53AM -0700, Shivani Agarwal wrote: > From: Breno Leitao > > [ Upstream commit f8321fa75102246d7415a6af441872f6637c93ab ] > > After the commit bdacf3e34945 ("net: Use nested-BH locking for > napi_alloc_cache.") was merged, the following warning began to appear: > >

Re: [PATCH] rust: add `module_params` macro

2024-07-09 Thread Greg KH
On Tue, Jul 09, 2024 at 06:00:46AM +, nmi wrote: > Hi Luis, > > On Monday, July 8th, 2024 at 23:42, Luis Chamberlain > wrote: > > > I'm starting to feel the same way about modules, but modules requires > > more work than the firmware loader. And since I also know Andreas has > > already a l

Re: [PATCH 05/14] tracefs: replace call_rcu by kfree_rcu for simple kmem_cache_free callback

2024-06-10 Thread Greg KH
On Mon, Jun 10, 2024 at 11:40:54PM +0200, Vlastimil Babka wrote: > On 6/10/24 10:36 PM, Steven Rostedt wrote: > > On Mon, 10 Jun 2024 08:46:42 -0700 > > "Paul E. McKenney" wrote: > > > >> > > index 7c29f4afc23d..338c52168e61 100644 > >> > > --- a/fs/tracefs/inode.c > >> > > +++ b/fs/tracefs/inode

Re: Bug in Kernel 6.8.x, 6.9.x Causing Trace/Panic During Shutdown/Reboot

2024-05-27 Thread Greg KH
On Mon, May 27, 2024 at 07:40:21PM +0300, Ilkka Naulapää wrote: > Hi Steven, > > I took some time and bisected the 6.8.9 - 6.8.10 and git gave the > panic inducing commit: > > 414fb08628143 (tracefs: Reset permissions on remount if permissions are > options) > > I reverted that commit to 6.9.2

Re: Please create the email alias do-not-apply-to-sta...@kernel.org -> /dev/null

2024-04-22 Thread Greg KH
On Mon, Apr 22, 2024 at 10:46:37PM +0100, Mauro Carvalho Chehab wrote: > Em Mon, 22 Apr 2024 15:25:18 -0400 > Konstantin Ryabitsev escreveu: > > > On Mon, Apr 22, 2024 at 05:49:29PM +0200, Thorsten Leemhuis wrote: > > > @Greg, BTW: should this be stable+noauto...@kernel.org or have a > > > 'vger

Re: Please create the email alias do-not-apply-to-sta...@kernel.org -> /dev/null

2024-04-18 Thread Greg KH
On Thu, Apr 18, 2024 at 09:04:53AM +0200, Thorsten Leemhuis wrote: > On 17.04.24 15:38, Greg KH wrote: > > On Wed, Apr 17, 2024 at 03:21:12PM +0200, Thorsten Leemhuis wrote: > >> On 17.04.24 14:52, Konstantin Ryabitsev wrote: > >>> On Wed, Apr 17, 2024 at 09:48:18AM

Re: Please create the email alias do-not-apply-to-sta...@kernel.org -> /dev/null

2024-04-17 Thread Greg KH
On Wed, Apr 17, 2024 at 03:21:12PM +0200, Thorsten Leemhuis wrote: > On 17.04.24 14:52, Konstantin Ryabitsev wrote: > > On Wed, Apr 17, 2024 at 09:48:18AM +0200, Thorsten Leemhuis wrote: > >> > >> Could you please create the email alias > >> do-not-apply-to-sta...@kernel.org which redirects all mai

Re: Please create the email alias do-not-apply-to-sta...@kernel.org -> /dev/null

2024-04-17 Thread Greg KH
On Wed, Apr 17, 2024 at 09:09:26AM +0100, Mauro Carvalho Chehab wrote: > Em Wed, 17 Apr 2024 09:48:18 +0200 > Thorsten Leemhuis escreveu: > > > Hi kernel.org helpdesk! > > > > Could you please create the email alias > > do-not-apply-to-sta...@kernel.org which redirects all mail to /dev/null, > >

Re: Please create the email alias do-not-apply-to-sta...@kernel.org -> /dev/null

2024-04-17 Thread Greg KH
On Wed, Apr 17, 2024 at 09:48:18AM +0200, Thorsten Leemhuis wrote: > Hi kernel.org helpdesk! > > Could you please create the email alias > do-not-apply-to-sta...@kernel.org which redirects all mail to /dev/null, > just like sta...@kernel.org does? > > That's an idea GregKH brought up a few days a

Re: [PATCH v6.1.y-v4.19.y] vhost: use kzalloc() instead of kmalloc() followed by memset()

2024-02-13 Thread Greg KH
On Mon, Feb 05, 2024 at 10:49:37AM +0530, Ajay Kaher wrote: > From: Prathu Baronia > > From: Prathu Baronia > > commit 4d8df0f5f79f747d75a7d356d9b9ea40a4e4c8a9 upstream > > Use kzalloc() to allocate new zeroed out msg node instead of > memsetting a node allocated with kmalloc(). > > Signed-of

Re: [PATCH] tracing/timerlat: Move hrtimer_init to timerlat_fd open()

2024-02-01 Thread Greg KH
On Thu, Feb 01, 2024 at 01:08:23PM -0500, Steven Rostedt wrote: > On Thu, 1 Feb 2024 10:05:59 -0800 > Greg KH wrote: > > > > timerlat_fd = > > > open("/sys/kernel/tracing/osnoise/per_cpu/cpu0/timerlat_fd", 'r') > > > timerlat_fd.c

Re: [PATCH] tracing/timerlat: Move hrtimer_init to timerlat_fd open()

2024-02-01 Thread Greg KH
On Thu, Feb 01, 2024 at 05:02:56PM +0100, Daniel Bristot de Oliveira wrote: > On 2/1/24 16:44, Greg KH wrote: > > On Thu, Feb 01, 2024 at 04:13:39PM +0100, Daniel Bristot de Oliveira wrote: > >> Currently, the timerlat's hrtimer is initialized at the first read of > >

Re: [PATCH] tracing/timerlat: Move hrtimer_init to timerlat_fd open()

2024-02-01 Thread Greg KH
On Thu, Feb 01, 2024 at 04:13:39PM +0100, Daniel Bristot de Oliveira wrote: > Currently, the timerlat's hrtimer is initialized at the first read of > timerlat_fd, and destroyed at close(). It works, but it causes an error > if the user program open() and close() the file without reading. What erro

Re: [PATCH] usb: typec: anx7688: Add driver for ANX7688 USB-C HDMI bridge

2024-02-01 Thread Greg KH
On Thu, Feb 01, 2024 at 11:41:56AM +0100, Pavel Machek wrote: > +#define DEBUG Please don't. This is dynamic, use the dynamic debugging and set it from userspace if you want to debug the driver. > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#in

Re: [PATCH] usb: typec: anx7688: Add driver for ANX7688 USB-C HDMI bridge

2024-02-01 Thread Greg KH
On Thu, Feb 01, 2024 at 11:41:56AM +0100, Pavel Machek wrote: > --- /dev/null > +++ b/drivers/usb/typec/anx7688.c > @@ -0,0 +1,1866 @@ > +/* > + * ANX7688 USB-C HDMI bridge/PD driver > + * Did this pass checkpatch? I need a spdx line for new files please, don't force us to go back and guess in

Re: [PATCH RFC 0/4] Introduce uts_release

2024-01-31 Thread Greg KH
On Wed, Jan 31, 2024 at 05:16:09PM +, John Garry wrote: > On 31/01/2024 16:22, Greg KH wrote: > > > before: > > > real0m53.591s > > > user1m1.842s > > > sys 0m9.161s > > > > > > after: > > > real0m37.481s >

Re: [PATCH RFC 0/4] Introduce uts_release

2024-01-31 Thread Greg KH
On Wed, Jan 31, 2024 at 10:48:47AM +, John Garry wrote: > When hacking it is a waste of time and compute energy that we need to > rebuild much kernel code just for changing the head git commit, like this: > > > touch include/generated/utsrelease.h > > time make -j3 > mkdir -p /home/john/mnt_

Re: [PATCH] driver core: Add a guard() definition for the device_lock()

2023-12-14 Thread Greg KH
On Wed, Dec 13, 2023 at 03:02:35PM -0800, Dan Williams wrote: > At present there are ~200 usages of device_lock() in the kernel. Some of > those usages lead to "goto unlock;" patterns which have proven to be > error prone. Define a "device" guard() definition to allow for those to > be cleaned up a

Re: [PATCH v2 0/5] MODVERSIONS + RUST Redux

2023-11-28 Thread Greg KH
On Tue, Nov 28, 2023 at 08:05:26AM +, Greg KH wrote: > On Mon, Nov 27, 2023 at 11:27:07AM -0800, Matthew Maurer wrote: > > > > > > > > > > > With regards to future directions that likely won't work for > > > > > > loosening it: > &

Re: [PATCH v2 0/5] MODVERSIONS + RUST Redux

2023-11-28 Thread Greg KH
On Mon, Nov 27, 2023 at 11:27:07AM -0800, Matthew Maurer wrote: > > > > > > > > > With regards to future directions that likely won't work for > > > > > loosening it: > > > > > Unfortunately, the .rmeta format itself is not stable, so I wouldn't > > > > > want to > > > > > teach genksyms to open

Re: [PATCH v2 0/5] MODVERSIONS + RUST Redux

2023-11-23 Thread Greg KH
On Thu, Nov 23, 2023 at 08:38:45PM +0900, Masahiro Yamada wrote: > On Thu, Nov 23, 2023 at 6:05 PM Greg KH wrote: > > > > On Wed, Nov 22, 2023 at 01:04:09PM -0800, Matthew Maurer wrote: > > > > So, even if you enable CONFIG_MODVERSIONS, > > > > nothin

Re: [PATCH v2 0/5] MODVERSIONS + RUST Redux

2023-11-23 Thread Greg KH
On Wed, Nov 22, 2023 at 01:04:09PM -0800, Matthew Maurer wrote: > > So, even if you enable CONFIG_MODVERSIONS, > > nothing is checked for Rust. > > Genksyms computes a CRC from "int foo", and > > the module subsystem confirms it is a "int" > > variable. > > > > We know this check always succeeds. >

Re: [PATCH v2 2/5] modules: Refactor + kdoc elf_validity_cached_copy

2023-11-18 Thread Greg KH
On Sat, Nov 18, 2023 at 02:54:43AM +, Matthew Maurer wrote: > Functionality is almost identical, just structured for better > documentation and readability. Changes: > > * Section names are checked for *all* non-SHT_NULL sections, not just > SHF_ALLOC sections. We have code that accesses sec

Re: [PATCH v2 1/5] export_report: Rehabilitate script

2023-11-18 Thread Greg KH
On Sat, Nov 18, 2023 at 02:54:42AM +, Matthew Maurer wrote: > * modules.order has .o files when in a build dir, support this > * .mod.c source layout has changed, update regexes to match > * Add a stage 3, to be more robust against additional .mod.c content When you have to list different thin

Re: [PATCH 3/3] get_maintainer: add patch-only pattern matching type

2023-09-27 Thread Greg KH
On Wed, Sep 27, 2023 at 03:46:30PM +0900, Justin Stitt wrote: > On Wed, Sep 27, 2023 at 3:14 PM Greg KH wrote: > > > > On Wed, Sep 27, 2023 at 03:19:16AM +, Justin Stitt wrote: > > > Note that folks really shouldn't be using get_maintainer on tree files > >

Re: [PATCH 3/3] get_maintainer: add patch-only pattern matching type

2023-09-26 Thread Greg KH
On Wed, Sep 27, 2023 at 03:19:16AM +, Justin Stitt wrote: > Note that folks really shouldn't be using get_maintainer on tree files > anyways [1]. That's not true, Linus and I use it on a daily basis this way, it's part of our normal workflow, AND the workflow of the kernel security team. So p

Re: SPDX: Appletalk FW license in the kernel

2023-09-26 Thread Greg KH
On Tue, Sep 26, 2023 at 12:34:03AM -0700, Christoph Hellwig wrote: > On Fri, Sep 15, 2023 at 09:39:05AM -0400, Prarit Bhargava wrote: > > To be clear, I am not asking for their removal, however, I do think a better > > license should be issued for these files. The files were trivially modified > >

Re: [PATCH] printk: add cpu id information to printk() output

2023-09-15 Thread Greg KH
On Fri, Sep 15, 2023 at 04:46:02PM +0800, Enlin Mu wrote: > John Ogness 于2023年9月15日周五 16:34写道: > > > > On 2023-09-15, Enlin Mu wrote: > > > Sometimes we want to print cpu id of printk() messages to consoles > > > > > > diff --git a/include/linux/threads.h b/include/linux/threads.h > > > index c34

Re: [PATCH] printk: add cpu id information to printk() output

2023-09-15 Thread Greg KH
On Fri, Sep 15, 2023 at 03:40:34PM +0800, Enlin Mu wrote: > From: Enlin Mu > > Sometimes we want to print cpu id of printk() messages to consoles This is rejected every few years. What has changes from the previous times this was sent? And why can't you use trace_printk()? thanks, greg k-h

Re: [PATCH 5/5] misc: zynqmp: Add afi config driver

2021-04-20 Thread Greg KH
On Tue, Apr 20, 2021 at 01:47:17PM +, Nava kishore Manne wrote: > Hi Greg, > > Please find my response inline. > > > -Original Message----- > > From: Greg KH > > Sent: Tuesday, April 20, 2021 2:21 PM > > To: Nava kishore Manne > > Cc

Re: [PATCH 2/5] misc: zynq: Add afi config driver

2021-04-20 Thread Greg KH
On Tue, Apr 20, 2021 at 01:36:51PM +, Nava kishore Manne wrote: > Hi Greg, > > Please find my response inline. > > > -Original Message----- > > From: Greg KH > > Sent: Tuesday, April 20, 2021 2:17 PM > > To: Nava kishore Manne > > Cc

Re: [PATCH 5/5] misc: zynqmp: Add afi config driver

2021-04-20 Thread Greg KH
On Tue, Apr 20, 2021 at 01:41:53PM +0530, Nava kishore Manne wrote: > This patch adds zynqmp afi config driver.This is useful for > the configuration of the PS-PL interface on Zynq US+ MPSoC > platform. > > Signed-off-by: Nava kishore Manne > --- > drivers/misc/Kconfig | 11 ++ > driver

Re: [PATCH 5/5] misc: zynqmp: Add afi config driver

2021-04-20 Thread Greg KH
On Tue, Apr 20, 2021 at 01:41:53PM +0530, Nava kishore Manne wrote: > This patch adds zynqmp afi config driver.This is useful for > the configuration of the PS-PL interface on Zynq US+ MPSoC > platform. Again, please spell out what those terms mean, as I have no idea :( > > Signed-off-by: Nava k

Re: [PATCH 2/5] misc: zynq: Add afi config driver

2021-04-20 Thread Greg KH
On Tue, Apr 20, 2021 at 01:41:50PM +0530, Nava kishore Manne wrote: > This patch adds zynq afi config driver. This is useful for > the configuration of the PS-PL interface on zynq platform. What is "PS-PL"? Can you describe it better please? > > Signed-off-by: Nava kishore Manne > --- > drive

Re: [PATCH] video: fbdev: sm501fb: Fix deallocation of buffers order

2021-04-20 Thread Greg KH
On Tue, Apr 06, 2021 at 06:35:17PM -0500, Aditya Pakki wrote: > The resource release in sm501fb_remove() is not in the inverse order of > sm501fb_probe(), for the buffers. Release the info object after > deallocating the buffers. > > Signed-off-by: Aditya Pakki > --- > drivers/video/fbdev/sm501f

Re: [PATCH] scsi: be2iscsi: Reset the address passed in beiscsi_iface_create_default

2021-04-20 Thread Greg KH
On Tue, Apr 06, 2021 at 07:24:45PM -0500, Aditya Pakki wrote: > if_info is a local variable that is passed to beiscsi_if_get_info. In > case of failure, the variable is free'd but not reset to NULL. The patch > avoids security issue by passing NULL to if_info. That is just not true at all. Stop s

Re: [PATCH] SUNRPC: Add a check for gss_release_msg

2021-04-20 Thread Greg KH
On Tue, Apr 06, 2021 at 07:16:56PM -0500, Aditya Pakki wrote: > In gss_pipe_destroy_msg(), in case of error in msg, gss_release_msg > deletes gss_msg. The patch adds a check to avoid a potential double > free. > > Signed-off-by: Aditya Pakki > --- > net/sunrpc/auth_gss/auth_gss.c | 3 ++- > 1 fi

Re: linux-next: manual merge of the rust tree with the char-misc tree

2021-04-16 Thread Greg KH
On Fri, Apr 16, 2021 at 05:58:06PM +1000, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the rust tree got a conflict in: > > include/uapi/linux/android/binder.h > > between commits: > > 432ff1e91694 ("binder: BINDER_FREEZE ioctl") > ae28c1be1e54 ("binder: BINDER_GET_FR

Re: [PATCH 0/1] coresight: Fix for v5.12-rc7

2021-04-16 Thread Greg KH
On Fri, Apr 16, 2021 at 08:54:00AM +0200, Greg KH wrote: > On Thu, Apr 15, 2021 at 02:24:03PM -0600, Mathieu Poirier wrote: > > Hi Greg, > > > > Please consider this patch as a fix for v5.12-rc7. Applies cleanly > > to your char-misc-linus branch (e49d033bddf5). >

Re: [PATCH 0/1] coresight: Fix for v5.12-rc7

2021-04-15 Thread Greg KH
On Thu, Apr 15, 2021 at 02:24:03PM -0600, Mathieu Poirier wrote: > Hi Greg, > > Please consider this patch as a fix for v5.12-rc7. Applies cleanly > to your char-misc-linus branch (e49d033bddf5). It's too late for 5.12-final, and really my tree should be closed for 5.13-rc1 now. I can sneak thi

Re: [RFC PATCH] USB:XHCI:skip hub registration

2021-04-15 Thread Greg KH
On Fri, Apr 16, 2021 at 10:43:34AM +0800, liulongfang wrote: > On 2021/4/15 20:34, Greg KH wrote: > > On Thu, Apr 15, 2021 at 08:22:38PM +0800, Longfang Liu wrote: > >> When the number of ports on the USB hub is 0, skip the registration > >> operation of the USB hub.

Re: [PATCH v2 4/5] staging: rtl8192e: rectified spelling mistake and replace memcmp with ether_oui_equal

2021-04-15 Thread Greg KH
On Thu, Apr 15, 2021 at 07:12:47PM +0530, Mitali Borkar wrote: > On Wed, Apr 14, 2021 at 10:16:59AM +0200, Greg KH wrote: > > On Wed, Apr 14, 2021 at 12:26:01PM +0530, Mitali Borkar wrote: > > > Added a generic function of static inline bool in > > > include/linux/ethe

Re: backport patches to linux-5.4.y

2021-04-15 Thread Greg KH
On Tue, Apr 13, 2021 at 02:11:54PM +0200, Anders Roxell wrote: > Hi, > > Can these patches be backported to linux-5.4.y, I've tried to build > perf on arm and it failed without these patches. > fc8c0a992233 ("perf tools: Use %define api.pure full instead of %pure-parser") > 20befbb10803 ("perf too

Re: [RFC PATCH] USB:XHCI:skip hub registration

2021-04-15 Thread Greg KH
On Thu, Apr 15, 2021 at 08:22:38PM +0800, Longfang Liu wrote: > When the number of ports on the USB hub is 0, skip the registration > operation of the USB hub. That's crazy. Why not fix the hardware? How has this hub passed the USB certification process? > The current Kunpeng930's XHCI hardware

Re: [PATCH v3] USB: Don't set USB_PORT_FEAT_SUSPEND on WD19's Realtek Hub

2021-04-15 Thread Greg KH
On Thu, Apr 15, 2021 at 07:48:56PM +0800, chris.c...@canonical.com wrote: > From: Chris Chiu > > Realtek Hub (0bda:5487) in Dell Dock WD19 sometimes fails to work > after the system resumes from suspend with remote wakeup enabled > device connected: > [ 1947.640907] hub 5-2.3:1.0: hub_ext_port_st

Re: [GIT PULL] interconnect changes for 5.13

2021-04-15 Thread Greg KH
On Thu, Apr 15, 2021 at 11:09:48AM +0300, Georgi Djakov wrote: > Hello Greg, > > This is the pull request with the interconnect changes for the 5.13-rc1 > merge window. These include two new drivers. > > Patches have been in linux-next without any reported issues. Please pull > into char-misc-nex

Re: [GIT PULL]: Generic phy updates for v5.13 -second round

2021-04-15 Thread Greg KH
On Wed, Apr 14, 2021 at 08:47:33PM +0530, Vinod Koul wrote: > Hi Greg, > > As promised, here are some minor fixes for earlier pull request. This > includes fixes which came in after the request was sent > > The following changes since commit cbc336c09b6d6dfb24d20c955599123308fa2fe2: > > phy: f

Re: [Resend RFC PATCH V2 08/12] UIO/Hyper-V: Not load UIO HV driver in the isolation VM.

2021-04-14 Thread Greg KH
On Wed, Apr 14, 2021 at 10:49:41AM -0400, Tianyu Lan wrote: > From: Tianyu Lan > > UIO HV driver should not load in the isolation VM for security reason. > Return ENOTSUPP in the hv_uio_probe() in the isolation VM. > > Signed-off-by: Tianyu Lan > --- > drivers/uio/uio_hv_generic.c | 5 + >

Re: [RFC V2 PATCH 8/12] UIO/Hyper-V: Not load UIO HV driver in the isolation VM.

2021-04-14 Thread Greg KH
On Wed, Apr 14, 2021 at 11:20:19PM +0800, Tianyu Lan wrote: > Hi Greg: > Thanks for your review. > > On 4/14/2021 12:00 AM, Greg KH wrote: > > On Tue, Apr 13, 2021 at 11:22:13AM -0400, Tianyu Lan wrote: > > > From: Tianyu Lan > > > > > > UIO

Re: [PATCH 4/7] staging: rtl8723bs: replace DBG_871X_SEL_NL with netdev_dbg()

2021-04-14 Thread Greg KH
On Wed, Apr 14, 2021 at 11:43:41AM +0200, Fabio Aiuto wrote: > On Wed, Apr 14, 2021 at 10:26:01AM +0200, Greg KH wrote: > > > - DBG_871X_SEL_NL(sel, "%10s %16s %8s %10s %11s %14s\n", > > > - "TH_L2H_ini", "TH_EDCCA_HL_diff&quo

Re: [PATCH v6 1/2] staging: rtl8192e: remove parentheses around boolean expression

2021-04-14 Thread Greg KH
On Wed, Apr 14, 2021 at 12:51:55PM +0530, Mitali Borkar wrote: > Removed unnecessary parentheses around '!xyz' boolean expression as '!' > has higher precedance than '||' > > Signed-off-by: Mitali Borkar > --- This series does not apply to my tree :(

Re: [PATCH 4/7] staging: rtl8723bs: replace DBG_871X_SEL_NL with netdev_dbg()

2021-04-14 Thread Greg KH
On Tue, Apr 13, 2021 at 04:56:32PM +0200, Fabio Aiuto wrote: > replace DGB_871X_SEL_NL macro with netdev_dbg(). > > DBG_871X_SEL_NL macro expands to a raw prink call or a > seq_printf if selected stream _is not_ a local > debug symbol set to null. > This second scenario never occurs so replace > a

Re: [PATCH 5/7] staging: rtl8723bs: put a new line after ';'

2021-04-14 Thread Greg KH
On Tue, Apr 13, 2021 at 04:56:33PM +0200, Fabio Aiuto wrote: > fix the following post commit hook checkpatch issue: > > ERROR: space required after that ';' (ctx:VxV) > 232: FILE: drivers/staging/rtl8723bs/core/rtw_odm.c:160: > +"AdapEn_RSSI", "IGI_LowerBound");netdev_dbg >

Re: Subject: [PATCH v2 0/5] staging: rtl8192e: CLeanup patchset for style issues in rtl819x_Y.c files

2021-04-14 Thread Greg KH
On Wed, Apr 14, 2021 at 12:24:44PM +0530, Mitali Borkar wrote: > Changes from v1:- Dropped 6/6 from and made this as a patchset of 5 as > alignment of code is done in following patches. Why is "Subject:" listed in your subject line? Do not manually add it after git format-patch has created it...

Re: [PATCH v2 4/5] staging: rtl8192e: rectified spelling mistake and replace memcmp with ether_oui_equal

2021-04-14 Thread Greg KH
On Wed, Apr 14, 2021 at 12:26:01PM +0530, Mitali Borkar wrote: > Added a generic function of static inline bool in > include/linux/etherdevice.h to replace memcmp with > ether_oui_equal throughout the execution. > Corrected the misspelled words in this file. > > Signed-off-by: Mitali Borkar > ---

Re: [PATCH 5.4 v3 1/1] iommu/vt-d: Fix agaw for a supported 48 bit guest address width

2021-04-13 Thread Greg KH
On Mon, Apr 12, 2021 at 01:27:35PM -0700, Saeed Mirzamohammadi wrote: > The IOMMU driver calculates the guest addressability for a DMA request > based on the value of the mgaw reported from the IOMMU. However, this > is a fused value and as mentioned in the spec, the guest width > should be calcula

Re: [PATCH] usb: core: remove unused including

2021-04-13 Thread Greg KH
On Wed, Apr 14, 2021 at 02:05:40PM +0800, Yang Li wrote: > Fix the following versioncheck warning: > ./drivers/usb/core/hcd.c: 14 linux/version.h not needed. > > Reported-by: Abaci Robot > Signed-off-by: Yang Li > --- > drivers/usb/core/hcd.c | 1 - > 1 file changed, 1 deletion(-) I am now add

Re: [PATCH 1/2] kunit: Fix formatting of KUNIT tests to meet the standard

2021-04-13 Thread Greg KH
On Wed, Apr 14, 2021 at 12:33:02AM -0400, Nico Pache wrote: > There are few instances of KUNIT tests that are not properly defined. > This commit focuses on correcting these issues to match the standard > defined in the Documentation. > > Issues Fixed: > - Tests should default to KUNIT_ALL_TE

Re: [PATCH 1/2] kunit: Fix formatting of KUNIT tests to meet the standard

2021-04-13 Thread Greg KH
On Wed, Apr 14, 2021 at 12:33:02AM -0400, Nico Pache wrote: > There are few instances of KUNIT tests that are not properly defined. > This commit focuses on correcting these issues to match the standard > defined in the Documentation. > > Issues Fixed: > - Tests should default to KUNIT_ALL_TE

Re: [PATCH 5.4 v3 1/1] iommu/vt-d: Fix agaw for a supported 48 bit guest address width

2021-04-13 Thread Greg KH
On Tue, Apr 13, 2021 at 11:05:34AM -0700, Saeed Mirzamohammadi wrote: > Hi Greg, > > I don’t have any commit ID since the fix is not in mainline or any Linus’ > tree yet. The driver has completely changed for newer stable versions (and > also mainline) and the fix only applies for 5.4, 4.19, and

Re: [PATCH] hrtimer: Update softirq_expires_next correctly after __hrtimer_get_next_event()

2021-04-13 Thread Greg KH
On Tue, Apr 13, 2021 at 09:55:08AM -0700, Maciej Żenczykowski wrote: > This patch (or at least the version of it that showed up in 5.10.24 > LTS when combined with Android Common Kernel and some arm phone > platform drivers) causes a roughly 60% regression (from ~5.3-6 gbps > down to ~2.2gbps) on r

Re: [RFC V2 PATCH 8/12] UIO/Hyper-V: Not load UIO HV driver in the isolation VM.

2021-04-13 Thread Greg KH
On Tue, Apr 13, 2021 at 11:22:13AM -0400, Tianyu Lan wrote: > From: Tianyu Lan > > UIO HV driver should not load in the isolation VM for security reason. Why? I need a lot more excuse than that. Why would the vm allow UIO devices to bind to it if it was not possible? Shouldn't the VM be handli

Re: [RFC V2 PATCH 8/12] UIO/Hyper-V: Not load UIO HV driver in the isolation VM.

2021-04-13 Thread Greg KH
On Tue, Apr 13, 2021 at 11:22:13AM -0400, Tianyu Lan wrote: > From: Tianyu Lan > > UIO HV driver should not load in the isolation VM for security reason. > Return ENOTSUPP in the hv_uio_probe() in the isolation VM. > > Signed-off-by: Tianyu Lan > --- > drivers/uio/uio_hv_generic.c | 5 + >

Re: [PATCH v5 0/3] staging: rtl8192e: Cleanup patchset for style issues in rtl819x_HTProc.c

2021-04-13 Thread Greg KH
On Tue, Apr 13, 2021 at 04:15:03PM +0530, Mitali Borkar wrote: > On Tue, Apr 13, 2021 at 09:52:48AM +0200, Greg KH wrote: > > On Tue, Apr 13, 2021 at 08:55:03AM +0530, Mitali Borkar wrote: > > > Changes from v4:- > > > [PATCH v4 1/3]:- No changes. > > > [PATCH v

  1   2   3   4   5   6   7   8   9   10   >