Re: [PATCH v2 3/3] remoteproc: imx_rproc: add power mode check for remote core attachment

2025-05-26 Thread Peng Fan
On Mon, May 26, 2025 at 09:05:10PM -0300, Hiago De Franco wrote: >On Mon, May 26, 2025 at 12:07:49PM +0200, Ulf Hansson wrote: >> On Fri, 23 May 2025 at 21:17, Hiago De Franco wrote: >> > >> > Hi Ulf, >> > >> > On Wed, May 21, 2025 at 02:11:02PM +0200, Ulf Hansson wrote: >> > > You should not prov

Re: [PATCH v3 0/3] remoteproc: imx_rproc: allow attaching to running core kicked by the bootloader

2025-05-20 Thread Peng Fan
On Mon, May 19, 2025 at 02:15:11PM -0300, Hiago De Franco wrote: >From: Hiago De Franco Let's wait for V2 discussion a bit, then I will give a look if we reach an agreement on using firmware power API here. Thanks, Peng

Re: [PATCH v2 3/3] remoteproc: imx_rproc: add power mode check for remote core attachment

2025-05-20 Thread Peng Fan
On Wed, May 21, 2025 at 12:13:06PM +0800, Peng Fan wrote: >Hi Ulf, > >On Tue, May 20, 2025 at 02:21:49PM +0200, Ulf Hansson wrote: >>On Mon, 19 May 2025 at 19:24, Hiago De Franco wrote: >>> >>> Hi Ulf, >>> >>> On Mon, May 19, 2025 at 04:33:30PM

Re: [PATCH v2 3/3] remoteproc: imx_rproc: add power mode check for remote core attachment

2025-05-20 Thread Peng Fan
it only >> > > > > > > checks for cores running in different partitions. If the core >> > > > > > > was kicked >> > > > > > > by the bootloader, it is in the same partition as Linux and it is >> > > > > &g

Re: [PATCH v9 00/19] DCD: Add support for Dynamic Capacity Devices (DCD)

2025-05-13 Thread Fan Ni
On Mon, Apr 14, 2025 at 09:37:02PM -0500, Ira Weiny wrote: > Fan Ni wrote: > > On Sun, Apr 13, 2025 at 05:52:08PM -0500, Ira Weiny wrote: > > > A git tree of this series can be found here: > > > > > > https://github.com/weiny2/linux-kernel/tree/dcd-v6-2025-

Re: [PATCH v2 1/3] firmware: imx: move get power mode function from scu-pd.c to misc.c

2025-05-12 Thread Peng Fan
Hi Hiago, On Wed, May 07, 2025 at 01:00:54PM -0300, Hiago De Franco wrote: >From: Hiago De Franco > >Move imx_sc_get_pd_power() from pmdomain/imx/scu-pd.c to >firmware/imx/misc.c and rename it to imx_sc_pm_get_resource_power_mode() >to maintain the same naming logic with other functions in misc.c

Re: [PATCH v9 12/19] cxl/extent: Process dynamic partition events and realize region extents

2025-05-12 Thread Fan Ni
ed on "cnt" after each iteration. > + } > + } > + > + if (!pl_index) /* nothing more to do */ > + return 0; ... > +/* > + * Add Dynamic Capacity Response > + * CXL rev 3.1 section 8.2.9.9.9.3; Table 8-168 & Table 8-169 &

Re: [PATCH v2 3/3] remoteproc: imx_rproc: add power mode check for remote core attachment

2025-05-11 Thread Peng Fan
it is >> > > > already up and running. >> > > > >> > > > This adds power mode verification through the SCU interface, enabling >> > > > the driver to detect when the remote core is already running and >> > > > properly

Re: [PATCH v2 3/3] remoteproc: imx_rproc: add power mode check for remote core attachment

2025-05-11 Thread Peng Fan
rface, enabling >> the driver to detect when the remote core is already running and >> properly attach to it. >> >> Signed-off-by: Hiago De Franco >> Suggested-by: Peng Fan >> --- >> v2: Dropped unecessary include. Removed the imx_rproc_is_on function, as >

Re: [PATCH v9 07/19] cxl/region: Add sparse DAX region support

2025-05-08 Thread Fan Ni
t; Signed-off-by: Ira Weiny LGTM, although I am not very familiar with dax. Reviewed-by: Fan Ni > > --- > Changes: > [iweiny: adjust to new partition mode and new singular dynamic ram > partition] > --- > Documentation/ABI/testing/sysfs-bus-cxl | 22 +

Re: [PATCH v9 07/19] cxl/region: Add sparse DAX region support

2025-05-08 Thread Fan Ni
ecoder *cxled; > struct device *dev; > > dev = bus_find_device_by_name(&cxl_bus_type, NULL, buf); > @@ -2209,8 +2215,13 @@ static size_t store_targetN(struct cxl_region *cxlr, > const char *buf, int pos, > goto out; > } >

Re: [PATCH v9 06/19] cxl/port: Add 'dynamic_ram_a' to endpoint decoder mode

2025-05-07 Thread Fan Ni
einy > Reviewed-by: Fan Ni > --- > Changes: > [iweiny: completely re-written] > --- > Documentation/ABI/testing/sysfs-bus-cxl | 18 +- > drivers/cxl/core/port.c | 4 > 2 files changed, 13 insertions(+), 9 deletions(-) > > d

Re: [PATCH v9 02/19] cxl/mem: Read dynamic capacity configuration from the device

2025-05-07 Thread Fan Ni
cmd(struct cxl_mailbox *cxl_mbox, > struct cxl_mbox_cmd *cmd); > int cxl_dev_state_identify(struct cxl_memdev_state *mds); > + > +struct cxl_mem_dev_info { > + u64 total_bytes; > + u64 volatile_bytes; > + u64 persistent_bytes; > +}; Def

Re: [PATCH v2 0/4] of: Common "memory-region" parsing

2025-05-06 Thread Peng Fan
e_wc() > remoteproc: Use of_reserved_mem_region_* functions for "memory-region" > > drivers/of/device.c | 31 +--- > drivers/of/of_reserved_mem.c | 80 +++ > drivers/remoteproc/imx_dsp_rproc.c| 4

Re: [PATCH v9 01/19] cxl/mbox: Flag support for Dynamic Capacity Devices (DCD)

2025-05-06 Thread Fan Ni
On Tue, May 06, 2025 at 11:09:09AM -0500, Ira Weiny wrote: > Fan Ni wrote: > > On Mon, Apr 14, 2025 at 03:19:50PM +0100, Jonathan Cameron wrote: > > > On Sun, 13 Apr 2025 17:52:09 -0500 > > > Ira Weiny wrote: > > [snip] > > > > > > &g

Re: [PATCH v3 0/2] Fix two memory leaks in rproc_attach()

2025-05-06 Thread Peng Fan
: cleanup acquired resources when rproc_handle_resources() >fails in rproc_attach() > remoteproc: core: release rproc->clean_table after rproc_attach() >fails > > drivers/remoteproc/remoteproc_core.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Peng Fan

Re: [PATCH 3/3] remoteproc: imx_rproc: add power mode check for remote core attachment

2025-05-06 Thread Peng Fan
> >Signed-off-by: Hiago De Franco >Suggested-by: Peng Fan >--- > drivers/remoteproc/imx_rproc.c | 23 +++ > 1 file changed, 23 insertions(+) > >diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c >index 627e57a88db2..86541d9d8640

Re: [PATCH 1/3] remoteproc: imx_rproc: skip clock enable when M-core is managed by the SCU

2025-05-06 Thread Peng Fan
ock. " You may update if you wanna. > >Signed-off-by: Hiago De Franco >Suggested-by: Peng Fan -> peng@nxp.com Thanks, Peng >--- > drivers/remoteproc/imx_rproc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/drivers/remoteproc

Re: [PATCH 2/3] firmware: imx: move get power mode function from scu-pd.c to misc.c

2025-05-06 Thread Peng Fan
On Mon, May 05, 2025 at 12:48:48PM -0300, Hiago De Franco wrote: >From: Hiago De Franco > >Move imx_sc_get_pd_power() from pmdomain/imx/scu-pd.c to >firmware/imx/misc.c and rename it to imx_sc_pm_get_resource_power_mode() >to maintain the same naming logic with other functions in misc.c. > >This m

Re: [PATCH V2] remoteproc: core: Clear table_sz when rproc_shutdown

2025-05-06 Thread Peng Fan
On Wed, Apr 09, 2025 at 02:46:10PM +0800, Peng Fan wrote: >On Tue, Apr 08, 2025 at 10:59:58AM -0600, Mathieu Poirier wrote: >>On Tue, 8 Apr 2025 at 09:02, Peng Fan wrote: >>> >>> On Thu, Apr 03, 2025 at 10:32:39PM +0800, Peng Fan wrote: >>> >Hi Bjorn, &g

Re: [PATCH v9 01/19] cxl/mbox: Flag support for Dynamic Capacity Devices (DCD)

2025-05-05 Thread Fan Ni
() return value wasn't obvious to me either! The code only checks if any DCD command (48xx) is supported, if any is set, it will set "dcd_supported". As you mentioned, it seems we should check all the related commands are supported, otherwise it is not valid imple

Re: [PATCH] remoteproc: imx_rproc: replace devm_clk_get() with devm_clk_get_optional()

2025-04-29 Thread Peng Fan
On Mon, Apr 28, 2025 at 02:12:57PM -0300, Hiago De Franco wrote: >On Sat, Apr 26, 2025 at 09:49:58PM +0800, Peng Fan wrote: >> On Wed, Apr 23, 2025 at 04:21:56PM -0300, Hiago De Franco wrote: >> >Hi Mathieu, >> > >> >On Wed, Apr 23, 2025 at 11:14:17AM -060

Re: [PATCH V2 1/2] remoteproc: imx_rproc: release carveout under imx_rproc after rproc_attach() fails

2025-04-26 Thread Peng Fan
safe. >> >> On Sat, 26 Apr 2025 at 07:46, xiaolei wang >> wrote: >> > >> > On 4/26/25 21:18, Peng Fan wrote: >> > > CAUTION: This email comes from a non Wind River email account! >> > > Do not click links or open attachments unless

Re: [PATCH] remoteproc: imx_rproc: replace devm_clk_get() with devm_clk_get_optional()

2025-04-26 Thread Peng Fan
On Sat, Apr 26, 2025 at 03:47:50PM -0600, Mathieu Poirier wrote: >On Sat, 26 Apr 2025 at 06:41, Peng Fan wrote: >> >> On Wed, Apr 23, 2025 at 04:21:56PM -0300, Hiago De Franco wrote: >> >Hi Mathieu, >> > >> >On Wed, Apr 23, 2025 at 11:14:17AM -0600,

Re: [PATCH] remoteproc: imx_rproc: replace devm_clk_get() with devm_clk_get_optional()

2025-04-26 Thread Peng Fan
On Wed, Apr 23, 2025 at 04:21:56PM -0300, Hiago De Franco wrote: >Hi Mathieu, > >On Wed, Apr 23, 2025 at 11:14:17AM -0600, Mathieu Poirier wrote: >> Good morning, >> >> On Wed, Apr 23, 2025 at 12:51:31PM -0300, Hiago De Franco wrote: >> > From: Hiago De Franco >> > >> > The "clocks" device tree

Re: [PATCH V2 1/2] remoteproc: imx_rproc: release carveout under imx_rproc after rproc_attach() fails

2025-04-26 Thread Peng Fan
On Sat, Apr 26, 2025 at 02:53:47PM +0800, Xiaolei Wang wrote: >When rproc->state = RPROC_DETACHED and rproc_attach() is used >to attach to the remote processor, if rproc_handle_resources() >returns a failure, the resources allocated by rproc_prepare_device() >should be released, otherwise the follo

Re: [PATCH v9 00/19] DCD: Add support for Dynamic Capacity Devices (DCD)

2025-04-14 Thread Fan Ni
On Mon, Apr 14, 2025 at 09:37:02PM -0500, Ira Weiny wrote: > Fan Ni wrote: > > On Sun, Apr 13, 2025 at 05:52:08PM -0500, Ira Weiny wrote: > > > A git tree of this series can be found here: > > > > > > https://github.com/weiny2/linux-kernel/tree/dcd-v6-2025-

Re: [PATCH v9 00/19] DCD: Add support for Dynamic Capacity Devices (DCD)

2025-04-14 Thread Fan Ni
egion extent HPA [range 0x-0x0fff] [ 1745.516576] cxl_core:cxlr_notify_extent:285: cxl dax_region0: Trying notify: type 0 HPA [range 0x-0x00000fff] [ 1745.517768] cxl_core:cxl_bus_probe:2087: cxl_region region0: probe: 0 [ 1745.524984] cxl dax_region0: R

Re: [PATCH V2] remoteproc: core: Clear table_sz when rproc_shutdown

2025-04-08 Thread Peng Fan
On Tue, Apr 08, 2025 at 10:59:58AM -0600, Mathieu Poirier wrote: >On Tue, 8 Apr 2025 at 09:02, Peng Fan wrote: >> >> On Thu, Apr 03, 2025 at 10:32:39PM +0800, Peng Fan wrote: >> >Hi Bjorn, >> > >> > >> >Thanks for replying this thread. >&

Re: [PATCH V2] remoteproc: core: Clear table_sz when rproc_shutdown

2025-04-08 Thread Peng Fan
On Thu, Apr 03, 2025 at 10:32:39PM +0800, Peng Fan wrote: >Hi Bjorn, > > >Thanks for replying this thread. > >On Wed, Apr 02, 2025 at 08:48:58AM -0500, Bjorn Andersson wrote: >>On Wed, Apr 02, 2025 at 09:43:55AM +0800, Peng Fan wrote: >>> On Tue, Apr 01, 2025 at

[PATCH] remoteproc: imx_rproc: Add mutex protection for workqueue

2025-04-05 Thread Peng Fan (OSS)
From: Peng Fan Same as commit 47e6ab07018e ("remoteproc: imx_dsp_rproc: Add mutex protection for workqueue") and commit 35bdafda40cc ("remoteproc: stm32_rproc: Add mutex protection for workqueue"), imx_rproc driver also has similar issue, although no issue reported until no

Re: [PATCH] remoteproc: imx_rproc: Add mutex protection for workqueue

2025-04-04 Thread Peng Fan
On Mon, Mar 31, 2025 at 07:22:45PM +0800, Peng Fan (OSS) wrote: >From: Peng Fan > >Same as >commit 47e6ab07018e ("remoteproc: imx_dsp_rproc: Add mutex >protection for workqueue") and commit 35bdafda40cc ("remoteproc: >stm32_rproc: Add mutex protection for workqu

Re: [PATCH V2] remoteproc: core: Clear table_sz when rproc_shutdown

2025-04-03 Thread Peng Fan
Hi Bjorn, Thanks for replying this thread. On Wed, Apr 02, 2025 at 08:48:58AM -0500, Bjorn Andersson wrote: >On Wed, Apr 02, 2025 at 09:43:55AM +0800, Peng Fan wrote: >> On Tue, Apr 01, 2025 at 10:05:03AM -0600, Mathieu Poirier wrote: >> >On Tue, Apr 01, 2025 at 09:41:24AM +08

Re: [PATCH V2] remoteproc: core: Clear table_sz when rproc_shutdown

2025-04-01 Thread Peng Fan
On Tue, Apr 01, 2025 at 10:05:03AM -0600, Mathieu Poirier wrote: >On Tue, Apr 01, 2025 at 09:41:24AM +0800, Peng Fan wrote: >> On Mon, Mar 31, 2025 at 09:40:41AM -0600, Mathieu Poirier wrote: >> >On Sat, Mar 29, 2025 at 08:56:29PM +0800, Peng Fan wrote: >> >> On F

Re: [PATCH V2] remoteproc: core: Clear table_sz when rproc_shutdown

2025-04-01 Thread Peng Fan
On Mon, Mar 31, 2025 at 09:40:41AM -0600, Mathieu Poirier wrote: >On Sat, Mar 29, 2025 at 08:56:29PM +0800, Peng Fan wrote: >> On Fri, Mar 28, 2025 at 08:14:41AM -0600, Mathieu Poirier wrote: >> >On Fri, Mar 28, 2025 at 12:50:12PM +0800, Peng Fan wrote: >> >> On T

[PATCH V2] remoteproc: imx_rproc: Add mutex protection for workqueue

2025-04-01 Thread Peng Fan (OSS)
From: Peng Fan Same as commit 47e6ab07018e ("remoteproc: imx_dsp_rproc: Add mutex protection for workqueue") and commit 35bdafda40cc ("remoteproc: stm32_rproc: Add mutex protection for workqueue"), imx_rproc driver also has similar issue, although no issue reported until now

Re: [PATCH V2] remoteproc: core: Clear table_sz when rproc_shutdown

2025-03-29 Thread Peng Fan
On Fri, Mar 28, 2025 at 08:14:41AM -0600, Mathieu Poirier wrote: >On Fri, Mar 28, 2025 at 12:50:12PM +0800, Peng Fan wrote: >> On Thu, Mar 27, 2025 at 11:46:33AM -0600, Mathieu Poirier wrote: >> >Hi, >> > >> >On Wed, Mar 26, 2025 at 10:02:14AM +0800, Peng F

Re: [PATCH V2] remoteproc: core: Clear table_sz when rproc_shutdown

2025-03-27 Thread Peng Fan
On Thu, Mar 27, 2025 at 11:46:33AM -0600, Mathieu Poirier wrote: >Hi, > >On Wed, Mar 26, 2025 at 10:02:14AM +0800, Peng Fan (OSS) wrote: >> From: Peng Fan >> >> There is case as below could trigger kernel dump: >> Use U-Boot to start remote processor(rproc) with

[PATCH V2] remoteproc: core: Clear table_sz when rproc_shutdown

2025-03-25 Thread Peng Fan (OSS)
From: Peng Fan There is case as below could trigger kernel dump: Use U-Boot to start remote processor(rproc) with resource table published to a fixed address by rproc. After Kernel boots up, stop the rproc, load a new firmware which doesn't have resource table ,and start rproc. When sta

[PATCH] remoteproc: core: Clear table_sz when rproc_shutdown

2025-03-19 Thread Peng Fan (OSS)
From: Peng Fan There is case as below could trigger kernel dump: Use U-Boot to start remote processor(rproc) with resource table published to a fixed address by rproc. After Kernel boots up, stop the rproc, load a new firmware which doesn't have resource table ,and start rproc. When sta

RE: [PATCH v4 7/8] reset: imx8mp-audiomix: Add support for DSP run/stall

2025-03-06 Thread Peng Fan
> Reviewed-by: Frank Li > Signed-off-by: Daniel Baluta Reviewed-by: Peng Fan

RE: [PATCH v4 5/8] reset: imx8mp-audiomix: Prepare the code for more reset bits

2025-03-05 Thread Peng Fan
ore reset bits in the > future. > > Reviewed-by: Frank Li > Signed-off-by: Daniel Baluta Reviewed-by: Peng Fan > ---

RE: [PATCH v4 3/8] arm64: dts: imx8mp: Use resets property

2025-03-05 Thread Peng Fan
> Subject: [PATCH v4 3/8] arm64: dts: imx8mp: Use resets property > > Add resets property to dsp node in order to be able to control the dsp > run/stall bit from audio block control. > > Reviewed-by: Frank Li > Signed-off-by: Daniel Baluta > --- Reviewed-by: Peng Fan

Re: [PATCH 1/5] reset: imx8mp-audiomix: Add prefix for internal macro

2025-02-18 Thread Peng Fan
On Tue, Feb 18, 2025 at 10:57:08AM +0200, Daniel Baluta wrote: >This adds IMX8MP_AUDIOMIX_ prefix to internal macros >in order to show that specific macros are related to >audiomix. > >Signed-off-by: Daniel Baluta Reviewed-by: Peng Fan

Re: [PATCH 5/5] imx_dsp_rproc: Use reset controller API to control the DSP

2025-02-18 Thread Peng Fan
On Tue, Feb 18, 2025 at 10:57:12AM +0200, Daniel Baluta wrote: >Use the reset controller API to control the DSP on i.MX8MP. This way >we can have a better control of the resources and avoid using a syscon >to access the audiomix bits. > >Signed-off-by: Daniel Baluta LGTM: Reviewed-by: Peng Fan

Re: [PATCH 3/5] reset: imx8mp-audiomix: Introduce active_low configuration option

2025-02-18 Thread Peng Fan
n future in case. If you tend to use bool, also ok to me: Reviewed-by: Peng Fan

Re: [PATCH 4/5] reset: imx8mp-audiomix: Add support for DSP run/stall

2025-02-18 Thread Peng Fan
On Tue, Feb 18, 2025 at 10:57:11AM +0200, Daniel Baluta wrote: >We can Run/Stall the DSP via audio block control bits found in audiomix. >Implement this functionality using the reset controller and use assert >for Stall and deassert for Run. > >Signed-off-by: Daniel Baluta >--- > drivers/reset/res

Re: [PATCH 2/5] reset: imx8mp-audiomix: Prepare the code for more reset bits

2025-02-18 Thread Peng Fan
On Tue, Feb 18, 2025 at 10:57:09AM +0200, Daniel Baluta wrote: >Current code supports EARC PHY Software Reset and EARC Software >Reset but it is not easily extensible to more reset bits. > >So, refactor the code in order to easily allow more reset bits >in the future. > >Signed-off-by: Dani

[PATCH] remoteproc: omap: add comment for is_iomem

2025-02-17 Thread Peng Fan (OSS)
From: Peng Fan Address warning: "Function parameter or struct member 'is_iomem' not described in 'omap_rproc_da_to_va'" with adding comment for is_iomem. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202502161648.wzwrfv7i-...@intel

RE: [RFC PATCH 00/39] 1G page support for guest_memfd

2024-09-13 Thread Du, Fan
@google.com; > sea...@google.com; pbonz...@redhat.com; Li, Zhiquan1 > ; Du, Fan ; Miao, Jun > ; Yamahata, Isaku ; > muchun.s...@linux.dev; mike.krav...@oracle.com > Cc: Aktas, Erdem ; Annapurve, Vishal > ; ackerley...@google.com; qper...@google.com; > jhubb...@nvidia.com; wi...@

[PATCH v3 2/2] remoteproc: imx_rproc: Add support for poweroff and reboot

2024-08-22 Thread Peng Fan (OSS)
From: Peng Fan On some NXP platforms (e.g i.MX7ULP) the poweroff and reboot operations are done via a separate remote core. Typically Linux needs to send a message to the remote core and requests for poweroff or reboot. By default the communication between Linux core and the remote core is is

[PATCH v3 1/2] remoteproc: imx_rproc: Allow setting of the mailbox transmit mode

2024-08-22 Thread Peng Fan (OSS)
From: Peng Fan Current mailbox is blocking by default, but there are cases where we don't need to wait for a response. Linux just needs to send data to the remote processor, so let's allow tx_block mode to be set (true/false) depending on usecase. No functional changes. Signed-of

[PATCH v3 0/2] remoteproc: imx_rproc: support non-blocking tx for i.MX7ULP

2024-08-22 Thread Peng Fan (OSS)
tion_timeout. In the poweroff or restart case, there is no need to wait, because after M4 got the message, M4 will put A7 to reboot or poweroff. patch 1 is to support non-blocking tx mailbox channel patch 2 is to switch to non-blocking tx for system poweroff or restart. Signed-off-by: Peng Fan --

RE: [PATCH v2 2/2] remoteproc: imx_rproc: handle system off for i.MX7ULP

2024-08-14 Thread Peng Fan
> Subject: Re: [PATCH v2 2/2] remoteproc: imx_rproc: handle system off > for i.MX7ULP > > On Fri, Aug 02, 2024 at 04:59:45AM +0000, Peng Fan wrote: > > > Subject: Re: [PATCH v2 2/2] remoteproc: imx_rproc: handle system > off > > > for i.MX7ULP > > > >

RE: [PATCH 6/6] remoteproc: imx_rproc: handle system off for i.MX7ULP

2024-08-07 Thread Peng Fan
> Subject: Re: [PATCH 6/6] remoteproc: imx_rproc: handle system off for > i.MX7ULP > > On Fri, Jul 12, 2024 at 04:34:59PM +0800, Peng Fan (OSS) wrote: > > From: Peng Fan > > > > The i.MX7ULP Cortex-A7 is under control of Cortex-M4. The > i.MX7ULP > > L

RE: [PATCH v2 2/2] remoteproc: imx_rproc: handle system off for i.MX7ULP

2024-08-01 Thread Peng Fan
> Subject: Re: [PATCH v2 2/2] remoteproc: imx_rproc: handle system off > for i.MX7ULP > > On Tue, Jul 30, 2024 at 08:06:22AM +0000, Peng Fan wrote: > > > Subject: Re: [PATCH v2 2/2] remoteproc: imx_rproc: handle system > off > > > for i.MX7ULP > > > >

RE: [PATCH] remoteproc: Use of_property_present()

2024-07-31 Thread Peng Fan
ers/remoteproc/xlnx_r5_remoteproc.c | 6 +++--- > 3 files changed, 5 insertions(+), 5 deletions(-) For i.MX: Acked-by: Peng Fan

RE: [PATCH v2 2/2] remoteproc: imx_rproc: handle system off for i.MX7ULP

2024-07-30 Thread Peng Fan
> Subject: Re: [PATCH v2 2/2] remoteproc: imx_rproc: handle system off > for i.MX7ULP > > On Fri, Jul 19, 2024 at 04:49:04PM +0800, Peng Fan (OSS) wrote: > > From: Peng Fan > > > > The i.MX7ULP Cortex-A7 is under control of Cortex-M4. The > i.MX7ULP > > L

[PATCH v2 1/2] remoteproc: imx_rproc: allow tx_block to be set

2024-07-19 Thread Peng Fan (OSS)
From: Peng Fan Current tx_block is set to true, but there is case that no need to wait response. Linux just needs to send data to remote processor, so let's allow tx_block could be set to false. No functional changes. Signed-off-by: Peng Fan --- drivers/remoteproc/imx_rproc.c

[PATCH v2 3/4] remoteproc: imx_rproc: initialize workqueue earlier

2024-07-19 Thread Peng Fan (OSS)
From: Peng Fan Initialize workqueue before requesting mailbox channel, otherwise if mailbox interrupt comes before workqueue ready, the imx_rproc_rx_callback will trigger issue. Fixes: 2df7062002d0 ("remoteproc: imx_proc: enable virtio/mailbox") Signed-off-by: Peng Fan --- drivers/

[PATCH v2 1/4] remoteproc: imx_rproc: correct ddr alias for i.MX8M

2024-07-19 Thread Peng Fan (OSS)
From: Peng Fan The DDR Alias address should be 0x4000 according to RM, so correct it. Fixes: 4ab8f9607aad ("remoteproc: imx_rproc: support i.MX8MQ/M") Reported-by: Terry Lv Reviewed-by: Iuliana Prodan Signed-off-by: Peng Fan --- drivers/remoteproc/imx_rproc.c | 2 +- 1 file

[PATCH v2 4/4] remoteproc: imx_rproc: merge TCML/U

2024-07-19 Thread Peng Fan (OSS)
From: Peng Fan Merge contiguous TCML/U regions into one to avoid load elf files which has large sections failure. Reviewed-by: Iuliana Prodan Signed-off-by: Peng Fan --- drivers/remoteproc/imx_rproc.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a

RE: [PATCH 3/6] remoteproc: imx_rproc: initialize workqueue earlier

2024-07-19 Thread Peng Fan
> Subject: Re: [PATCH 3/6] remoteproc: imx_rproc: initialize workqueue > earlier > > On Fri, Jul 12, 2024 at 04:34:56PM +0800, Peng Fan (OSS) wrote: > > From: Peng Fan > > > > Initialize workqueue before requesting mailbox channel, otherwise if > > mailbox in

RE: [PATCH 1/6] remoteproc: imx_rproc: correct ddr alias for i.MX8M

2024-07-19 Thread Peng Fan
> Subject: Re: [PATCH 1/6] remoteproc: imx_rproc: correct ddr alias for > i.MX8M > > Good morning, > > On Fri, Jul 12, 2024 at 04:34:54PM +0800, Peng Fan (OSS) wrote: > > From: Peng Fan > > > > The DDR Alias address should be 0x4000 according to RM

[PATCH v2 2/2] remoteproc: imx_rproc: handle system off for i.MX7ULP

2024-07-19 Thread Peng Fan (OSS)
From: Peng Fan The i.MX7ULP Cortex-A7 is under control of Cortex-M4. The i.MX7ULP Linux poweroff and restart rely on rpmsg driver to send a message to Cortex-M4 firmware. Then Cortex-A7 could poweroff or restart by Cortex-M4 to configure the i.MX7ULP power controller properly. However the

[PATCH v2 0/2] remoteproc: imx_rproc: support non-blocking tx for i.MX7ULP

2024-07-19 Thread Peng Fan (OSS)
tx for system poweroff or restart. Based on patchset: https://lore.kernel.org/all/20240719-imx_rproc-v2-0-10d0268c7...@nxp.com/ Signed-off-by: Peng Fan --- Changes in v2: - Separated patch 5,6 from v1 - Update commit patch 1 with adding "No functional changes" - Link to

[PATCH v2 2/4] remoteproc: imx_rproc: use imx specific hook for find_loaded_rsc_table

2024-07-19 Thread Peng Fan (OSS)
From: Peng Fan If there is a resource table device tree node, use the address as the resource table address, otherwise use the address(where .resource_table section loaded) inside the Cortex-M elf file. And there is an update in NXP SDK that Resource Domain Control(RDC) enabled to protect TCM

[PATCH v2 0/4] remoteproc: imx_rproc: various patches for misc

2024-07-19 Thread Peng Fan (OSS)
/2022011103.403448-1-peng@oss.nxp.com/#25144792 this is just a resend Patch 3 is to avoid mu interrupt trigger earlier. Patch 4 is merge small area to support elf that has large section Signed-off-by: Peng Fan --- Changes in v2: - Add R-b for patch 1,2,4 - Add Fixes tag for patch 3 - Drop

RE: [PATCH 5/6] remoteproc: imx_rproc: allow tx_block to be set

2024-07-18 Thread Peng Fan
> Subject: Re: [PATCH 5/6] remoteproc: imx_rproc: allow tx_block to be > set > > On Fri, Jul 12, 2024 at 04:34:58PM +0800, Peng Fan (OSS) wrote: > > From: Peng Fan > > > > Current tx_block is set to true, but there is case that no need to > > wait respon

RE: [PATCH 4/6] remoteproc: imx_rproc: merge TCML/U

2024-07-18 Thread Peng Fan
> Subject: Re: [PATCH 4/6] remoteproc: imx_rproc: merge TCML/U > > On Fri, Jul 12, 2024 at 04:34:57PM +0800, Peng Fan (OSS) wrote: > > From: Peng Fan > > > > Merge contiguous TCML/U regions into one to avoid load elf files > which > > has large sections fail

[PATCH 6/6] remoteproc: imx_rproc: handle system off for i.MX7ULP

2024-07-12 Thread Peng Fan (OSS)
From: Peng Fan The i.MX7ULP Cortex-A7 is under control of Cortex-M4. The i.MX7ULP Linux poweroff and restart rely on rpmsg driver to send a message to Cortex-M4 firmware. Then Cortex-A7 could poweroff or restart by Cortex-M4 to configure the i.MX7ULP power controller properly. However the

[PATCH 5/6] remoteproc: imx_rproc: allow tx_block to be set

2024-07-12 Thread Peng Fan (OSS)
From: Peng Fan Current tx_block is set to true, but there is case that no need to wait response. Linux just needs to send data to remote processor, so let's allow tx_block could be set to false. Reviewed-by: Jacky Bai Signed-off-by: Peng Fan --- drivers/remoteproc/imx_rproc.c

[PATCH 4/6] remoteproc: imx_rproc: merge TCML/U

2024-07-12 Thread Peng Fan (OSS)
From: Peng Fan Merge contiguous TCML/U regions into one to avoid load elf files which has large sections failure. Signed-off-by: Peng Fan --- drivers/remoteproc/imx_rproc.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/remoteproc/imx_rproc.c b

[PATCH 3/6] remoteproc: imx_rproc: initialize workqueue earlier

2024-07-12 Thread Peng Fan (OSS)
From: Peng Fan Initialize workqueue before requesting mailbox channel, otherwise if mailbox interrupt comes before workqueue ready, the imx_rproc_rx_callback will trigger issue. Reviewed-by: Richard Zhu Signed-off-by: Peng Fan --- drivers/remoteproc/imx_rproc.c | 4 ++-- 1 file changed, 2

[PATCH 2/6] remoteproc: imx_rproc: use imx specific hook for find_loaded_rsc_table

2024-07-12 Thread Peng Fan (OSS)
From: Peng Fan If there is a resource table device tree node, use the address as the resource table address, otherwise use the address(where .resource_table section loaded) inside the Cortex-M elf file. And there is an update in NXP SDK that Resource Domain Control(RDC) enabled to protect TCM

[PATCH 1/6] remoteproc: imx_rproc: correct ddr alias for i.MX8M

2024-07-12 Thread Peng Fan (OSS)
From: Peng Fan The DDR Alias address should be 0x4000 according to RM, so correct it. Fixes: 4ab8f9607aad ("remoteproc: imx_rproc: support i.MX8MQ/M") Reported-by: Terry Lv Signed-off-by: Peng Fan --- drivers/remoteproc/imx_rproc.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH 0/6] remoteproc: imx_rproc: various patches for misc

2024-07-12 Thread Peng Fan (OSS)
message. Signed-off-by: Peng Fan --- Peng Fan (6): remoteproc: imx_rproc: correct ddr alias for i.MX8M remoteproc: imx_rproc: use imx specific hook for find_loaded_rsc_table remoteproc: imx_rproc: initialize workqueue earlier remoteproc: imx_rproc: merge TCML/U

[PATCH V2] test/vsock: add install target

2024-07-10 Thread Peng Fan (OSS)
From: Peng Fan Add install target for vsock to make Yocto easy to install the images. Signed-off-by: Peng Fan --- V2: Use VSOCK_INSTALL_PATH, drop INSTALL_PATH tools/testing/vsock/Makefile | 13 + 1 file changed, 13 insertions(+) diff --git a/tools/testing/vsock/Makefile b

RE: [PATCH] test/vsock: add install target

2024-07-10 Thread Peng Fan
> Subject: Re: [PATCH] test/vsock: add install target > > On Wed, Jul 10, 2024 at 08:11:32AM GMT, Peng Fan wrote: > >> Subject: Re: [PATCH] test/vsock: add install target > >> > >> On Tue, Jul 09, 2024 at 09:50:51PM GMT, Peng Fan (OSS) wrote: > >> >

RE: [PATCH] test/vsock: add install target

2024-07-10 Thread Peng Fan
> Subject: Re: [PATCH] test/vsock: add install target > > On Tue, Jul 09, 2024 at 09:50:51PM GMT, Peng Fan (OSS) wrote: > >From: Peng Fan > > > >Add install target for vsock to make Yocto easy to install the images. > > > >Signed-off-by: Peng Fan >

[PATCH] test/vsock: add install target

2024-07-09 Thread Peng Fan (OSS)
From: Peng Fan Add install target for vsock to make Yocto easy to install the images. Signed-off-by: Peng Fan --- tools/testing/vsock/Makefile | 12 1 file changed, 12 insertions(+) diff --git a/tools/testing/vsock/Makefile b/tools/testing/vsock/Makefile index a7f56a09ca9f

RE: [PATCH] remoteproc: imx_rproc: Adjust phandle parsing issue while remapping optional addresses in imx_rproc_addr_init()

2024-06-06 Thread Peng Fan
r (linuxtesting.org) with SVACE. > > Fixes: a0ff4aa6f010 ("remoteproc: imx_rproc: add a NXP/Freescale imx_rproc > driver") > Signed-off-by: Aleksandr Mishin Anyway LGTM: Reviewed-by: Peng Fan Thanks, Peng.

Re: [PATCH v2 4/5] arm64: dts: qcom: sa8775p: add ADSP, CDSP and GPDSP nodes

2024-05-27 Thread Tengfei Fan
On 5/27/2024 4:43 PM, Bartosz Golaszewski wrote: From: Tengfei Fan Add nodes for remoteprocs: ADSP, CDSP0, CDSP1, GPDSP0 and GPDSP1 for SA8775p SoCs. Signed-off-by: Tengfei Fan Co-developed-by: Bartosz Golaszewski Signed-off-by: Bartosz Golaszewski --- arch/arm64/boot/dts/qcom

Re: [PATCH v2 3/5] remoteproc: qcom_q6v5_pas: Add support for SA8775p ADSP, CDSP and GPDSP

2024-05-27 Thread Tengfei Fan
On 5/27/2024 4:43 PM, Bartosz Golaszewski wrote: From: Tengfei Fan Add support for PIL loading on ADSP, CDSP0, CDSP1, GPDSP0 and GPDSP1 on SA8775p SoCs. Signed-off-by: Tengfei Fan Co-developed-by: Bartosz Golaszewski Signed-off-by: Bartosz Golaszewski --- drivers/remoteproc

Re: [PATCH v2 1/5] dt-bindings: remoteproc: qcom,sa8775p-pas: Document the SA8775p ADSP, CDSP and GPDSP

2024-05-27 Thread Tengfei Fan
On 5/27/2024 4:56 PM, Krzysztof Kozlowski wrote: On 27/05/2024 10:43, Bartosz Golaszewski wrote: From: Bartosz Golaszewski Document the components used to boot the ADSP, CDSP0, CDSP1, GPDSP0 and GPDSP1 on the SA8775p SoC. Co-developed-by: Tengfei Fan Missing SoB. Signed-off-by

RE: [PATCH] vhost: use pr_err for vq_err

2024-05-16 Thread Peng Fan
> Subject: Re: [PATCH] vhost: use pr_err for vq_err > > On Thu, May 16, 2024 at 03:46:29PM +0800, Peng Fan (OSS) wrote: > > From: Peng Fan > > > > Use pr_err to print out error message without enabling DEBUG. This > > could make people catch error easier

[PATCH] vhost: use pr_err for vq_err

2024-05-16 Thread Peng Fan (OSS)
From: Peng Fan Use pr_err to print out error message without enabling DEBUG. This could make people catch error easier. Signed-off-by: Peng Fan --- drivers/vhost/vhost.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h index

Re: [PATCH v9 1/3] mm/memory_hotplug: replace an open-coded kmemdup() in add_memory_resource()

2023-11-06 Thread fan
al Hocko > Cc: Oscar Salvador > Cc: Dan Williams > Reported-by: Dan Williams > Reviewed-by: David Hildenbrand > Signed-off-by: Vishal Verma > --- Reviewed-by: Fan Ni > mm/memory_hotplug.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > dif

Re: [PATCH v8 2/3] mm/memory_hotplug: split memmap_on_memory requests across memblocks

2023-11-03 Thread fan
+ mem = find_memory_block(pfn_to_section_nr(PFN_DOWN(cur_start))); > + WARN_ON_ONCE(!mem); > + if (!mem) > + continue; > + > + altmap = mem->altmap; > + mem->altmap = NULL; > + > + re

Re: [PATCH v8 1/3] mm/memory_hotplug: replace an open-coded kmemdup() in add_memory_resource()

2023-11-03 Thread fan
al Hocko > Cc: Oscar Salvador > Cc: Dan Williams > Reported-by: Dan Williams > Reviewed-by: David Hildenbrand > Signed-off-by: Vishal Verma > --- Reviewed-by: Fan Ni > mm/memory_hotplug.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > dif

RE: [PATCH V3 8/8] remoteproc: imx_rproc: support i.MX8MN/P

2021-04-15 Thread Peng Fan (OSS)
eng. > > On Thu, Apr 08, 2021 at 09:54:58AM +0800, peng@oss.nxp.com wrote: > > From: Peng Fan > > > > Add i.MX8MN/P remote processor(Cortex-M7) support, we are using ARM > > SMCCC to start/stop M core, not using regmap interface. > > > > Signed-off-

[PATCH V4 7/8] remoteproc: imx_rproc: support i.MX7ULP

2021-04-15 Thread peng . fan
From: Peng Fan i.MX7ULP A7 core runs under control of M4 core, M4 core starts by ROM and powers most serivces used by A7 core, so A7 core has no power to start and stop M4 core. And the M4 core's state is default RPROC_DETACHED and remoteproc framework not able to stop the M4 core. Signe

[PATCH V4 8/8] remoteproc: imx_rproc: support i.MX8MN/P

2021-04-15 Thread peng . fan
From: Peng Fan Add i.MX8MN/P remote processor(Cortex-M7) support, we are using ARM SMCCC to start/stop M core, not using regmap interface. Signed-off-by: Peng Fan --- drivers/remoteproc/imx_rproc.c | 87 ++ 1 file changed, 80 insertions(+), 7 deletions

[PATCH V4 6/8] remoteproc: imx_rproc: make clk optional

2021-04-15 Thread peng . fan
From: Peng Fan To i.MX7ULP, M4 is the master to control everything, no need to provide clk from Linux side. So make clk optional when method is IMX_RPROC_NONE. Signed-off-by: Peng Fan --- drivers/remoteproc/imx_rproc.c | 46 -- 1 file changed, 31

[PATCH V4 5/8] remoteproc: imx_rproc: initial support for mutilple start/stop method

2021-04-15 Thread peng . fan
From: Peng Fan Add three methods IMX_RPROC_NONE(no need start/stop), IMX_RPROC_MMIO (start/stop through mmio) and IMX_RPROC_SMC(start/stop through ARM SMCCC). The current SoCs supported are all using IMX_RPROC_MMIO, add a restrict in imx_rproc_detect_mode that only SoCs using IMX_RPROC_MMIO

[PATCH V4 4/8] remoteproc: imx_rproc: parse fsl,auto-boot

2021-04-15 Thread peng . fan
From: Peng Fan Parse fsl,auto-boot to indicate whether need remoteproc framework auto boot or not. When remote processor is booted before Linux Kernel up, do not parse fsl,auto-boot, so only need to parse the property when rproc state is RPROC_DETACHED. Signed-off-by: Peng Fan --- drivers

[PATCH V4 3/8] dt-bindings: remoteproc: imx_rproc: support i.MX8MN/P

2021-04-15 Thread peng . fan
From: Peng Fan Add i.MX8MN/P remote processor(Cortex-M7) compatible string Signed-off-by: Peng Fan Acked-by: Rob Herring --- Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/remoteproc/fsl

[PATCH V4 2/8] dt-bindings: remoteproc: imx_rproc: add i.MX7ULP support

2021-04-15 Thread peng . fan
From: Peng Fan Add i.MX7ULP compatible. We use i.MX7ULP dual mode and in which case i.MX7ULP A7 core runs under control of M4 core, M4 core starts by ROM and powers most services used by A7 core, so A7 core has no power to start and stop M4 core. So clocks and syscon are not required. Signed

[PATCH V4 1/8] dt-bindings: remoteproc: imx_rproc: add fsl,auto-boot property

2021-04-15 Thread peng . fan
From: Peng Fan Add an optional property "fsl,auto-boot" to indicate remote processor auto boot. Signed-off-by: Peng Fan Acked-by: Rob Herring --- Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/

[PATCH V4 0/8] remoteproc: imx_rproc: support i.MX7ULP/8MN/8MP

2021-04-15 Thread peng . fan
From: Peng Fan V4: Typo fix patch 4: take state as a check condition patch 5: move regmap lookup/attach to imx_rproc_detect_mode patch 6: add imx_rproc_clk_enable for optional clk patch 8: use switch/case in imx_rproc_detect_mode V3: Add A-b tag for Patch 1/2 Fix the checkpatch warning

  1   2   3   4   5   6   7   8   9   10   >