Re: FEC_MPC52xx_MDIO oddness.

2007-10-31 Thread Domen Puncer
On 31/10/07 17:30 +0100, Gabriel C wrote: > Domen Puncer wrote: > > On 31/10/07 10:22 -0400, Dave Jones wrote: > >> The Kconfig for this reads.. > >> > >> +config FEC_MPC52xx_MDIO > >> + bool "MPC52xx FEC MDIO bus driver" >

Re: FEC_MPC52xx_MDIO oddness.

2007-10-31 Thread Domen Puncer
d as module, and built-in if fec is built-in. from Makefile: obj-$(CONFIG_FEC_MPC52xx) += fec_mpc52xx.o ifeq ($(CONFIG_FEC_MPC52xx_MDIO),y) obj-$(CONFIG_FEC_MPC52xx) += fec_mpc52xx_phy.o endif Yes, a bit weird, but it's best I could come up with. (fec_mdio=m and fec=y is

Re: [PATCH] mpc5200: psc-spi driver must not touch port_config or cdm registers

2007-10-23 Thread Domen Puncer
x27;s a property of the > board. > > Drivers should never touch these registers. They are completely > unprotected and the platform may do odd things with them that the > driver must not interfere with. > > Signed-off-by: Grant Likely <[EMAIL PROTECTED]> > --- >

Re: [PATCH] sb1000: prevent a potential NULL pointer dereference in sb1000_dev_ioctl()

2007-07-28 Thread Domen Puncer
L test of 'dev', yet we > dereference the pointer prior to that check. > This patch simply moves the dereference after the NULL test. But... it can't be called without a valid 'dev', no? A quick 'grep do_ioctl net/' confirms that all calls are in the form of 'de

Re: [PATCH] introduce __init_exit function annotation

2007-07-17 Thread Domen Puncer
07 at 04:52:12PM +0200, Takashi Iwai wrote: > > > > > > > At Tue, 17 Jul 2007 15:02:30 +0200, > > > > > > > Sam Ravnborg wrote: > > > > > > > > > > > > > > > > On Tue, Jul 17, 2007 at 10:02:48AM +0200, Domen Puncer wrote: >

Re: [PATCH] introduce __init_exit function annotation

2007-07-17 Thread Domen Puncer
> > > > > On Tue, Jul 17, 2007 at 04:52:12PM +0200, Takashi Iwai wrote: > > > > > At Tue, 17 Jul 2007 15:02:30 +0200, > > > > > Sam Ravnborg wrote: > > > > > > > > > > > > On Tue, Jul 17, 2007 at 10:02:48AM +0200, Dome

Re: [PATCH] introduce __init_exit function annotation

2007-07-17 Thread Domen Puncer
On 17/07/07 10:31 +0200, Adrian Bunk wrote: > On Tue, Jul 17, 2007 at 10:02:48AM +0200, Domen Puncer wrote: > > Introduce __init_exit, which is useful ie. for drivers that call > > cleanup functions when they fail in __init functions. > > > > > > Signed-off-b

[PATCH] introduce __init_exit function annotation

2007-07-17 Thread Domen Puncer
Introduce __init_exit, which is useful ie. for drivers that call cleanup functions when they fail in __init functions. Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- include/linux/init.h |2 ++ 1 file changed, 2 insertions(+) Index: work-powerpc.git/include/linux/

[patch 12/16] ide/ide-cs: replace schedule_timeout() with msleep()

2005-08-08 Thread domen
From: Nishanth Aravamudan <[EMAIL PROTECTED]> Uses msleep() in place of schedule_timeout() to guarantee the task delays as expected. Signed-off-by: Nishanth Aravamudan <[EMAIL PROTECTED]> Signed-off-by: Maximilian Attems <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer

[patch 07/16] block/umem: replace PRINTK with pr_debug

2005-08-08 Thread domen
From: Domen Puncer <[EMAIL PROTECTED]> Removed unused dprintk, replaced PRINTK with pr_debug. Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> Signed-off-by: Maximilian Attems <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- umem.c | 11 ---

[patch 15/16] reiserfs: super.c - vfree() checking cleanups

2005-08-08 Thread domen
From: [EMAIL PROTECTED] super.c vfree() checking cleanups. Signed-off by: James Lamanna <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- super.c |3 +-- 1 files changed, 1 insertion(+), 2 deletions(-) Index: quilt/fs/reis

[patch 13/16] net/stir4200: replace direct assignment with set_current_state()

2005-08-08 Thread domen
From: Nishanth Aravamudan <[EMAIL PROTECTED]> Use set_current_state() instead of direct assignment of current->state. Signed-off-by: Nishanth Aravamudan <[EMAIL PROTECTED]> Signed-off-by: Maximilian Attems <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PRO

[patch 04/16] fs/namespace.c: list_for_each_entry

2005-08-08 Thread domen
From: Domen Puncer <[EMAIL PROTECTED]> Make code more readable with list_for_each_entry. Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> Signed-off-by: Maximilian Attems <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- namespace.c |4

[patch 16/16] block/ps2esdi: replace sleep_on() with wait_event()

2005-08-08 Thread domen
as the condition to pass to wait_event() to guarantee the same behavior; I think this is the best choice, though. Signed-off-by: Nishanth Aravamudan <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- ps2esdi.c |7 +++ 1 files changed, 3 insertions(+), 4 d

[patch 01/16] ide: min/max macros in ide-timing.h

2005-08-08 Thread domen
From: Clemens Buchacher <[EMAIL PROTECTED]> I replaced the custom MIN/MAX macros with the type safe min/max macros from linux/kernel.h. >From Clemens Buchacher <[EMAIL PROTECTED]> Signed-off-by: Maximilian Attems <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EM

[patch 11/16] block/xd: replace schedule_timeout() with msleep()/msleep_interruptible()

2005-08-08 Thread domen
lt;[EMAIL PROTECTED]> Signed-off-by: Maximilian Attems <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- xd.c | 15 ++- 1 files changed, 6 insertions(+), 9 deletions(-) Index:

[patch 00/16] old kernel janitor patches

2005-08-08 Thread domen
Hi Andrew, folks. Here are patches I'm sending for inclusion in -mm tree. Patches were in -kj tree for more than five months, and as far as I can tell, they received no negative feedback. List of them, which is a bit descriptive: min-max-ide_ide-timing.h.patch list-for-each-entry-drivers_net_pp

[patch 06/16] ide-tape: replace schedule_timeout() with msleep()

2005-08-08 Thread domen
From: Nishanth Aravamudan <[EMAIL PROTECTED]> Uses msleep() instead of schedule_timeout() to guarantee the task delays at least the desired time amount. Signed-off-by: Nishanth Aravamudan <[EMAIL PROTECTED]> Signed-off-by: Maximilian Attems <[EMAIL PROTECTED]> Signed-of

[patch 14/16] net/tms380tr: replace direct assignment with set_current_state()

2005-08-08 Thread domen
From: Nishanth Aravamudan <[EMAIL PROTECTED]> Use set_current_state() instead of direct assignment of current->state. Signed-off-by: Nishanth Aravamudan <[EMAIL PROTECTED]> Signed-off-by: Maximilian Attems <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PRO

Re: [PATCH rc4-mm1] drivers/char/isicom.c old api rewritten

2005-08-06 Thread Domen Puncer
On 02/08/05 00:02 +0200, Jiri Slaby wrote: > Hello. > Could you send me critics and bugs? You have much bigger chances of someone reviewing the patch if you at least split code changes and whitespace/type cleanups. 65k is a lot. > Could somebody test it (but NOT now)? > Thanks. > > drivers/char/

[patch 1/5] drivers/char/lp.c : Use of the time_after() macro

2005-07-31 Thread domen
From: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Use of the time_after() macro, defined at linux/jiffies.h, which deal with wrapping correctly and are nicer to read. Signed-off-by: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]>

[patch 3/5] Driver core: Documentation: use snprintf and strnlen

2005-07-31 Thread domen
From: Jan Veldeman <[EMAIL PROTECTED]> Documentation should give the good example of using snprintf and strnlen in stead of sprintf and strlen. PAGE_SIZE is used as the maximal length to reflect the behaviour of show/store. Signed-off-by: Jan Veldeman <[EMAIL PROTECTED]> Signed-o

[patch 5/5] Driver core: Documentation: use S_IRUSR | ... in stead of 0644

2005-07-31 Thread domen
From: Jan Veldeman <[EMAIL PROTECTED]> Change filemode to use defines in stead of 0644, based on suggestions by Walter Harms and Domen Puncer. Signed-off-by: Jan Veldeman <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- sysfs.txt |4 ++--

[patch 1/1] drivers/block/floppy.c : Use of the time_after() and time_before() macros

2005-07-31 Thread domen
From: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Use of the time_after() and time_before() macros, defined at linux/jiffies.h, which deal with wrapping correctly and are nicer to read. Signed-off-by: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[

[patch 2/5] Spelling and whitespace fixes for REPORTING-BUGS

2005-07-31 Thread domen
From: Tobias Klauser <[EMAIL PROTECTED]> The attached patch fixes some spelling errors in REPORTING-BUGS and also removes all trailing whitespaces (I hope this OK with the trivial patch monkey). Signed-off-by: Tobias Klauser <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[

[patch 1/1] drivers/char/agp/nvidia-agp.c : Use of the time_before_eq() macro

2005-07-31 Thread domen
From: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Use of the time_before_eq() macro, defined at linux/jiffies.h, which deal with wrapping correctly and are nicer to read. Signed-off-by: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]>

[patch 4/5] Driver core: Documentation: fix whitespace between parameters

2005-07-31 Thread domen
From: Jan Veldeman <[EMAIL PROTECTED]> Fix whitespace after comma between parameters. Signed-off-by: Jan Veldeman <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- sysfs.txt | 26 +- 1 files changed, 13 insertions(+), 13 d

2.6.13-rc4-kj

2005-07-29 Thread Domen Puncer
A new release from kernel janitors (http://janitor.kernelnewbies.org/). Patchset is at http://coderock.org/kj/2.6.13-rc4-kj/ new in this release: time_after-drivers_net_eth16i From: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Subject: [KJ] [PATCH] drivers/net/eth16i.c : Use

Re: [PATCH][1/3] ppc32: add 440ep support

2005-07-28 Thread Domen Puncer
On 27/07/05 18:56 -0400, Paul Mackerras wrote: > Andrew Morton writes: > > > Matt Porter <[EMAIL PROTECTED]> wrote: > > > > > > +static u64 dma_mask = 0xULL; How about just DMA_32BIT_MASK from dma-mapping.h, that one has to be correct. ;-) > > > > I'm sure you're totally uninterested in

[patch 1/2] block/cpqarray: Audit return code of create_proc_*

2005-07-14 Thread domen
From: Christophe Lucas <[EMAIL PROTECTED]> Audit return of create_proc_* functions. Signed-off-by: Christophe Lucas <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- cpqarray.c |7 ++- 1 files changed, 6 insertions(+), 1 deletion(-) Index: q

[patch 2/2] drivers/block/umem.c: Use DMA_{32,64}BIT_MASK and correct call to pci_set_dma_mask()

2005-07-14 Thread domen
aimsgroup.com/?t=10800199301&r=1&w=2 for details Signed-off-by: Tobias Klauser <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- umem.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-

[patch 1/1] Audit return code of create_proc_*

2005-07-14 Thread domen
From: Christophe Lucas <[EMAIL PROTECTED]> Audit return of create_proc_* functions. Signed-off-by: Christophe Lucas <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- ecard.c | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) Index

[patch 1/1] arm/kernel: Audit return code of create_proc_*

2005-07-14 Thread domen
From: Christophe Lucas <[EMAIL PROTECTED]> --- apm.c |5 - ecard.c | 14 -- 2 files changed, 16 insertions(+), 3 deletions(-) Index: quilt/arch/arm/kernel/apm.c === --- quilt.orig/arch/arm/kernel/apm.c +++ q

[patch 3/5] dmapool: Fix "nocast type" warnings

2005-07-14 Thread domen
From: Victor Fusco <[EMAIL PROTECTED]> Fix the sparse warning "implicit cast to nocast type" File/Subsystem:drivers/base/dmapool Signed-off-by: Victor Fusco <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> -- --- drivers/base/dmapool.c |3

[patch 4/5] telephony/ixj: use msleep() instead of schedule_timeout()

2005-07-14 Thread domen
From: Nishanth Aravamudan <[EMAIL PROTECTED]> Replace schedule_timeout() with msleep() to guarantee the task delays as expected. Patch is compile-tested. Signed-off-by: Nishanth Aravamudan <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]>

[patch 5/5] i386/smpboot: use msleep() instead of schedule_timeout()

2005-07-14 Thread domen
From: Nishanth Aravamudan <[EMAIL PROTECTED]> From: Nishanth Aravamudan <[EMAIL PROTECTED]> Replace schedule_timeout() with msleep() to guarantee the task delays as expected. Patch is compile-tested. Signed-off-by: Nishanth Aravamudan <[EMAIL PROTECTED]> Signed-off-by: Do

[patch 1/1] mca/mca-proc: Audit return code of create_proc_*

2005-07-14 Thread domen
From: Christophe Lucas <[EMAIL PROTECTED]> --- mca-proc.c | 13 ++--- 1 files changed, 10 insertions(+), 3 deletions(-) Index: quilt/drivers/mca/mca-proc.c === --- quilt.orig/drivers/mca/mca-proc.c +++ quilt/drivers/mca/m

[patch 1/1] dm-crypt: Fix "nocast type" warnings

2005-07-14 Thread domen
From: Victor Fusco <[EMAIL PROTECTED]> Fix the sparse warning "implicit cast to nocast type" File/Subsystem:drivers/md/dm-crypt.c Signed-off-by: Victor Fusco <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> -- --- dm-crypt.c |2 +- 1 file

[patch 1/5] Spelling fixes for Documentation/

2005-07-14 Thread domen
y others which I forgot ;-) Trailing whitespaces on the same line as the typo are also deleted. Signed-off-by: Tobias Klauser <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- 00-INDEX |2 +- DMA-API.txt

[patch 2/5] lib/radix-tree: Fix "nocast type" warnings

2005-07-14 Thread domen
From: Victor Fusco <[EMAIL PROTECTED]> Fix the sparse warning "implicit cast to nocast type" File/Subsystem:lib/radix-tree Signed-off-by: Victor Fusco <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> -- --- include/linux/radix-tree.h |

2.6.13-rc3-kj

2005-07-13 Thread Domen Puncer
A new release from kernel janitors (http://janitor.kernelnewbies.org/). Lots of new patches this time! Patchset is at http://coderock.org/kj/2.6.13-rc3-kj/ new in this release: flashpoint_01-remove_unused_things From: Alexey Dobriyan <[EMAIL PROTECTED]> Subject: [KJ] [PATCH

Re: kernel guide to space

2005-07-12 Thread Domen Puncer
On 12/07/05 10:12 +0300, Denis Vlasenko wrote: > > 3c. * in types > > Leave space between name and * in types. > > Multiple * dont need additional space between them. > > > > struct foo **bar; > > unless you declare a fuction: > > int* > function_style_for_easy_grep(...) > { >

[patch 4/4] as-iosched: fix sparse warnings (__nocast type)

2005-07-07 Thread domen
From: Victor Fusco <[EMAIL PROTECTED]> Fix the sparse warning "implicit cast to nocast type" File/Subsystem: drivers/block/as-iosched Signed-off-by: Victor Fusco <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- as-iosched.c |2 +-

[patch 2/4] deadline-iosched: fix sparse warnings (__nocast type)

2005-07-07 Thread domen
From: Victor Fusco <[EMAIL PROTECTED]> Fix the sparse warning "implicit cast to nocast type" File/Subsystem: drivers/block/deadline-iosched Signed-off-by: Victor Fusco <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- deadline-iosched.c |

[patch 1/1] drivers/cdrom/sbpcd.c: replace direct assignment with set_current_state()

2005-07-07 Thread domen
From: Christophe Lucas <[EMAIL PROTECTED]> Use set_current_state() instead of direct assignment of current->state. Signed-off-by: Christophe Lucas <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- sbpcd.c |2 +- 1 files changed, 1 insertion(+),

[patch 1/4] fix sparse warnings

2005-07-07 Thread domen
From: Victor Fusco <[EMAIL PROTECTED]> Fix the sparse warning "implicit cast to nocast type" Signed-off-by: Victor Fusco <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- drivers/block/elevator.c |2 +- drivers/block/ll_rw_blk.c | 1

[patch 1/4] drivers/char/ip2/i2lib.c: replace direct assignment with set_current_state()

2005-07-07 Thread domen
From: Christophe Lucas <[EMAIL PROTECTED]> Use set_current_state() instead of direct assignment of current->state. Signed-off-by: Christophe Lucas <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- i2lib.c |4 ++-- 1 files changed, 2 inser

[patch 3/4] char/n_tty: fix sparse warnings (__nocast type)

2005-07-07 Thread domen
From: Victor Fusco <[EMAIL PROTECTED]> Fix the sparse warning "implicit cast to nocast type" File/Subsystem: drivers/char/n_tty.c Signed-off-by: Victor Fusco <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- n_tty.c |2 +- 1 file

[patch 2/4] kernel/audit.c: fix sparse warnings (__nocast type)

2005-07-07 Thread domen
From: Victor Fusco <[EMAIL PROTECTED]> Fix the sparse warning "implicit cast to nocast type" File/Subsystem: kernel/audit.c Signed-off-by: Victor Fusco <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- audit.c |2 +- 1 files changed

[patch 1/1] kernel/module.c use __set_current_state() instead of direct assigment

2005-07-07 Thread domen
From: aLeJ <[EMAIL PROTECTED]> Use of __set_current_state() instead of direct assigment of current->state. Signed-off-by: Alejandro Andres <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- module.c |2 +- 1 files changed, 1 insertion(+), 1 dele

[patch 4/4] cleanup indenting on drivers/char/Makefile

2005-07-07 Thread domen
From: Jim Cromie <[EMAIL PROTECTED]> items in makefile are partially tabbed into columns, this patch finishes that indenting, minus an ifeq block, which I think should stand out, so I left it. Signed-of-by: Jim Cromie <[EMAIL PROTECTED]> --- Makefile | 70 +++

[patch 3/5] autoparam: extract script

2005-07-07 Thread domen
From: Domen Puncer <[EMAIL PROTECTED]> A simple perl script which extracts parameters, types and descriptions from binary file. Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> scripts/kernelparams.pl | 49 1 files changed, 4

[patch 2/5] autoparam: makefile

2005-07-07 Thread domen
From: Domen Puncer <[EMAIL PROTECTED]> Build .kernel-parameters.o when vmlinux is (re)built. Add target "kernelparams" which generates descriptions of parameters in Documentation/kernel-parameters-gen.txt Signed-off-by: Domen Puncer <[EMAIL PROTECTED]

[patch 5/5] autoparam: ide workarounds

2005-07-07 Thread domen
From: Magnus Damm <[EMAIL PROTECTED]> This patch contains quick fixes that prevents KBUILD_MODNAME conflicts. Signed-off-by: Magnus Damm <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> drivers/ide/ide-disk.c |2 ++ drivers/ide/ide-floppy.c |2 +

[patch 4/5] autoparam: af_unix workaround

2005-07-07 Thread domen
From: Magnus Damm <[EMAIL PROTECTED]> This is a quick fix that removes the "KBUILD_MODNAME -> unix -> 1" conflict. Signed-off-by: Magnus Damm <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> net/unix/af_unix.c |2 ++ 1 files changed,

[patch 1/5] autoparam: includes

2005-07-07 Thread domen
From: Magnus Damm <[EMAIL PROTECTED]> The code of autoparam - modified include files. Stores parameter name, type and description in a section called __param_strings. Signed-off-by: Magnus Damm <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> in

[patch 0/5] autoparam v0.2: generating parameter descriptions on compile

2005-07-07 Thread domen
imple perl script to extract descriptions. autoparam_4-af_unix_workaround autoparam_5-ide_workaround Workarounds needed. Comments, improvements? Domen - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED

2.6.13-rc2-kj

2005-07-06 Thread Domen Puncer
A new release from kernel janitors (http://janitor.kernelnewbies.org/). Patchset is at http://coderock.org/kj/2.6.13-rc2-kj/ new in this release: sparse-net From: Victor Fusco <[EMAIL PROTECTED]> Subject: Re: [KJ] [PATCH 2.6.13-rc1 14/17] fix sparse warnings [UPDATE 2/2

Re: [KJ] 2.6.13-rc2-kj (Should work now, was: (Broken Link))

2005-07-06 Thread Domen Puncer
That's what happens if you close the console with reminder to copy. :-) Domen - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please

Re: [PATCH 2.6.12-rc2] aoe [1/6]: improve allowed interfaces configuration

2005-04-21 Thread Domen Puncer
l parameter for the built-in aoe driver be > the same as the parameter for the modular driver. The __setup() stuff is redundancy too, as module parameters already work as boot parameters (ie. aoe.iflist). Domen - To unsubscribe from this list: send the line "unsubscribe linux-kernel&quo

Re: [PATCH] introduce generic 64bit rotations and i386 asm optimized version

2005-04-19 Thread Domen Puncer
itmask_order(unsigned int count) > > { > > int order; > > > > Please keep using __inline__, not inline. Why? Couldn't find any threads about this, and even SubmittingPatches has: "'static inline' is preferred over 'static __inline__'..."

Re: [patch 1/1] nbd: Don't create all MAX_NBD devices by default all the time

2005-04-14 Thread Domen Puncer
On 14/04/05 13:23 +0200, Lars Marowsky-Bree wrote: > From: Lars Marowsky-Bree <[EMAIL PROTECTED]> > > This patches adds the "nbds_max" parameter to the nbd kernel module, > which limits the number of nbds allocated. Previously, always all 128 > entries were allocated unconditionally, which used to

Re: 2.6.12-rc2: Compose key doesn't work

2005-04-14 Thread Domen Puncer
. is that "-n" really necessary? Had too look at the code to figure out why it's not working :-) > > X is X.org 6.8.1, keyboard is regular PS/2 keyboard, directly connected. Same here. Domen - To unsubscribe from this list: send the line "unsubscribe linux-

Re: [PATCH 0/5] autoparam

2005-04-09 Thread Domen Puncer
m the boot loader. And kernel-parameters.txt will never again have obsoleted options :-) Domen section2text.pl Description: Perl program

Re: [patch 3/8] lib/c: documentation strncpy()

2005-04-08 Thread Domen Puncer
this clarifys the documentation on the behavier of strncpy(). From: walter harms <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- [Geez, again, next time i'll send them to myself first] kj-domen/lib/string.c |4 1 files changed, 4 insertions(

[patch 1/1] printk : drivers/block/DAC960.c

2005-04-08 Thread domen
printk() calls should include appropriate KERN_* constant. Signed-off-by: Christophe Lucas <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/drivers/block/DAC960.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff -puN drivers/bl

[patch 1/1] block/cpqarray: Use the DMA_32BIT_MASK constant

2005-04-08 Thread domen
&r=1&w=2 for details Signed-off-by: Tobias Klauser <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/drivers/block/cpqarray.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff -puN drivers/block/cpqarray.c~dma_mask-drivers_blo

[patch 7/8] lib/sha1.c: fix sparse warning

2005-04-08 Thread domen
Fix lib/sha1.c:44:10: warning: cast to restricted type Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/lib/sha1.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -puN lib/sha1.c~sparse-lib_sha1 lib/s

[patch 5/8] printk : drivers/char/applicom.c

2005-04-08 Thread domen
printk() calls should include appropriate KERN_* constant. Signed-off-by: Christophe Lucas <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/drivers/char/applicom.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/cha

[patch 6/8] printk : drivers/char/ftape/compressor/zftape-compress.c

2005-04-08 Thread domen
printk() calls should include appropriate KERN_* constant. Signed-off-by: Christophe Lucas <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/drivers/char/ftape/compressor/zftape-compress.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-

[patch 3/8] string.linux-2.6.10/lib/c: documentation strncpy()

2005-04-08 Thread domen
this clarifys the documentation on the behavier of strncpy(). Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/lib/string.c |4 1 files changed, 4 insertions(+) diff -L lib/c.bak -puN /dev/null /dev/null diff -puN lib/string.c~comment-lib_string lib/string.c ---

[patch 4/8] serial/icom: Remove custom msescs_to_jiffies() macro

2005-04-08 Thread domen
Remove the MSECS_TO_JIFFIES() macro because msescs_to_jiffies() from jiffies.h should be used. The macro isn't referenced anywhere anyway. Signed-off-by: Tobias Klauser <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/drivers/serial/icom.h |

[patch 2/8] correctly name the Shell sort

2005-04-08 Thread domen
As per http://www.nist.gov/dads/HTML/shellsort.html, this should be referred to as a Shell sort. Shell-Metzner is a misnomer. Signed-off-by: Daniel Dickman <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/kernel/sys.c |2 +- 1 files changed,

[patch 1/8] fix lib/sort regression test

2005-04-08 Thread domen
Dickman <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/lib/sort.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -puN lib/sort.c~bug-lib_sort lib/sort.c --- kj/lib/sort.c~bug-lib_sort 2005-04-05 12:57:40.0 +0200 +++ kj-dome

2.6.12-rc2-kj

2005-04-05 Thread Domen Puncer
A new release from kernel janitors (http://janitor.kernelnewbies.org/). Patchset is at http://coderock.org/kj/2.6.12-rc2-kj/ new in this release: bug-lib_sort.patch From: Daniel Dickman <[EMAIL PROTECTED]> Subject: [KJ] [patch 1/1] fix lib/sort regression test comment-

Re: [patch 4/4 with proper signed-off] security/selinux/ss/conditional.c: fix sparse warnings

2005-03-20 Thread Domen Puncer
Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/security/selinux/ss/conditional.c | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff -puN security/selinux/ss/conditio

Re: [patch 3/4 with proper signed-off] security/selinux/ss/avtab.c: fix sparse warnings

2005-03-20 Thread Domen Puncer
Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/security/selinux/ss/avtab.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff -puN security/selinux/ss/avtab.c~sparse-security_selinux_ss_avtab securit

Re: [patch 2/4 with proper signed-off] security/selinux/ss/ebitmap.c: fix sparse warnings

2005-03-20 Thread Domen Puncer
Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/security/selinux/ss/ebitmap.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff -puN security/selinux/ss/ebitmap.c~sparse-security_selinux_ss_ebitm

Re: [patch 1/4 with proper signed-off] security/selinux/ss/policydb.c: fix sparse warnings

2005-03-20 Thread Domen Puncer
Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/security/selinux/ss/policydb.c | 35 ++-- 1 files changed, 20 insertions(+), 15 deletions(-) diff -puN security/selinux/ss/polic

Re: [patch 4/4 with proper signed-off] crypto/tea.c: fix sparse warnings

2005-03-20 Thread Domen Puncer
Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/crypto/tea.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff -puN crypto/tea.c~sparse-crypto_tea crypto/tea.c --- kj/crypto/tea.c~sparse-crypto_tea

Re: [patch 3/4 with proper signed-off] crypto/blowfish.c: fix sparse warnings

2005-03-20 Thread Domen Puncer
Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/crypto/blowfish.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff -puN crypto/blowfish.c~sparse-crypto_blowfish crypto/blowfish.c --- kj/crypt

Re: [patch 2/4 with proper signed-off] crypto/sha512.c: fix sparse warnings

2005-03-20 Thread Domen Puncer
Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/crypto/sha512.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -puN crypto/sha512.c~sparse-crypto_sha512 crypto/sha512.c --- kj/crypto/sha512.c~sparse-c

Re: [patch 1/4 with proper signed-off] crypto/sha256.c: fix sparse warnings

2005-03-20 Thread Domen Puncer
Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/crypto/sha256.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -puN crypto/sha256.c~sparse-crypto_sha256 crypto/sha256.c --- kj/crypto/sha256.c~sparse-c

Re: [patch 10/10 with proper signed-off] arch/i386/crypto/aes.c: fix sparse warnings

2005-03-20 Thread Domen Puncer
Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/arch/i386/crypto/aes.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -puN arch/i386/crypto/aes.c~sparse-arch_i386_crypto_aes arch/i386/crypto/aes.c

Re: [patch 09/10 with proper signed-off] arch/i386/mm/fault.c: fix sparse warnings

2005-03-20 Thread Domen Puncer
Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/arch/i386/mm/fault.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff -puN arch/i386/mm/fault.c~sparse-arch_i386_mm_fault arch/i386/mm/fault.c --- kj/

Re: [patch 08/10 with proper signed-off] arch/i386/kernel/apm.c: fix sparse warnings

2005-03-20 Thread Domen Puncer
Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/arch/i386/kernel/apm.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff -puN arch/i386/kernel/apm.c~sparse-arch_i386_kernel_apm arch/i386/kernel/

Re: [patch 07/10 with proper signed-off] arch/i386/kernel/traps.c: fix sparse warnings

2005-03-20 Thread Domen Puncer
Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/arch/i386/kernel/traps.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff -puN arch/i386/kernel/traps.c~sparse-arch_i386_kernel_traps arch

Re: [patch 06/10 with proper signed-off] init/do_mounts_initrd.c: fix sparse warning

2005-03-20 Thread Domen Puncer
Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/init/do_mounts_initrd.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff -puN init/do_mounts_initrd.c~sparse-init_do_mounts_initrd init/do_mounts_ini

[patch 3/4] security/selinux/ss/avtab.c: fix sparse warnings

2005-03-19 Thread domen
Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/security/selinux/ss/avtab.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff -puN security/selinux/ss/avtab.c~sparse-security_selinux_ss_avtab security/selinux/ss/avtab.c --- kj/security/selinux/ss/a

[patch 2/4] security/selinux/ss/ebitmap.c: fix sparse warnings

2005-03-19 Thread domen
Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/security/selinux/ss/ebitmap.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff -puN security/selinux/ss/ebitmap.c~sparse-security_selinux_ss_ebitmap security/selinux/ss/ebitmap.c --- kj/security/seli

[patch 1/4] security/selinux/ss/policydb.c: fix sparse warnings

2005-03-19 Thread domen
Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/security/selinux/ss/policydb.c | 35 ++-- 1 files changed, 20 insertions(+), 15 deletions(-) diff -puN security/selinux/ss/policydb.c~sparse-security_selinux_ss_policydb security/seli

[patch 4/4] security/selinux/ss/conditional.c: fix sparse warnings

2005-03-19 Thread domen
Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/security/selinux/ss/conditional.c | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff -puN security/selinux/ss/conditional.c~sparse-security_selinux_ss_conditional security/selinux/ss/conditional.c

[patch 1/4] crypto/sha256.c: fix sparse warnings

2005-03-19 Thread domen
Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/crypto/sha256.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -puN crypto/sha256.c~sparse-crypto_sha256 crypto/sha256.c --- kj/crypto/sha256.c~sparse-crypto_sha256 2005-03-18 20:05:34.0 +0100

[patch 1/1] printk : drivers/char/watchdog/wdt285.c

2005-03-19 Thread domen
printk() calls should include appropriate KERN_* constant. Signed-off-by: Christophe Lucas <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/drivers/char/watchdog/wdt285.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff -puN

[patch 1/1] drivers/block/sx8.c: Use the DMA_{64, 32}BIT_MASK constants

2005-03-19 Thread domen
;w=2 for details Signed-off-by: Tobias Klauser <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/drivers/block/sx8.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff -puN drivers/block/sx8.c~dma_mask-drivers_block_sx8 drivers/block/

[patch 09/10] arch/i386/mm/fault.c: fix sparse warnings

2005-03-19 Thread domen
Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/arch/i386/mm/fault.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff -puN arch/i386/mm/fault.c~sparse-arch_i386_mm_fault arch/i386/mm/fault.c --- kj/arch/i386/mm/fault.c~sparse-arch_i386_mm_fault 2005

[patch 10/10] arch/i386/crypto/aes.c: fix sparse warnings

2005-03-19 Thread domen
Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/arch/i386/crypto/aes.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -puN arch/i386/crypto/aes.c~sparse-arch_i386_crypto_aes arch/i386/crypto/aes.c --- kj/arch/i386/crypto/aes.c~sparse-arch_i386_cryp

[patch 06/10] init/do_mounts_initrd.c: fix sparse warning

2005-03-19 Thread domen
Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/init/do_mounts_initrd.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff -puN init/do_mounts_initrd.c~sparse-init_do_mounts_initrd init/do_mounts_initrd.c --- kj/init/do_mounts_initrd.c~

[patch 04/10] ixj* - compile warning cleanup

2005-03-19 Thread domen
compile warning cleanup - suggested by Adrian Bunk; remove unmaintained rcs char strings from source and handle the occurrences of their use, make sure kernel-userspace issues taken care of; break out into separate patch Signed-off-by: Stephen Biggs <[EMAIL PROTECTED]> Signed-off-by:

[patch 07/10] arch/i386/kernel/traps.c: fix sparse warnings

2005-03-19 Thread domen
Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- kj-domen/arch/i386/kernel/traps.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff -puN arch/i386/kernel/traps.c~sparse-arch_i386_kernel_traps arch/i386/kernel/traps.c --- kj/arch/i386/kernel/traps.c~

  1   2   >