On Thu, Apr 17, 2014 at 11:12 AM, Pantelis Antoniou
wrote:
> Hi Alan,
>
> Ugh, very sorry for the late reply; my mailer filed this somewhere I don't
> look at very frequently.
>
> On Mar 28, 2014, at 8:27 PM, delicious quinoa wrote:
>
>> On Tue, Mar 18, 20
On Wed, Apr 16, 2014 at 4:33 PM, Rob Herring wrote:
> On Wed, Apr 16, 2014 at 4:23 PM, delicious quinoa
> wrote:
>> On Thu, Apr 3, 2014 at 3:40 PM, delicious quinoa
>> wrote:
>>> On Fri, Mar 28, 2014 at 1:27 PM, delicious quinoa
>>> wrote:
>>&g
On Thu, Apr 3, 2014 at 3:40 PM, delicious quinoa
wrote:
> On Fri, Mar 28, 2014 at 1:27 PM, delicious quinoa
> wrote:
>> On Tue, Mar 18, 2014 at 4:55 PM, Pantelis Antoniou
>> wrote:
>>> The following patchset introduces Device Tree overlays, a method
>>> of dy
On Mon, Apr 7, 2014 at 5:13 AM, Sebastian Andrzej Siewior
wrote:
> The driver calls irq_alloc_domain_generic_chips() which creates a gc and
> adds it to gc_list. The driver later then calls irq_setup_generic_chip()
> which also initializes the gc and adds it to the gc_list() and this
> corrupts th
On Tue, Apr 8, 2014 at 9:33 AM, Steffen Trumtrar
wrote:
> On Tue, Apr 08, 2014 at 09:29:50AM -0500, Thor Thayer wrote:
>> On Tue, 2014-04-08 at 15:38 +0200, Steffen Trumtrar wrote:
>> > Hi!
>> >
>> > On Mon, Apr 07, 2014 at 04:54:07PM -0500, ttha...@altera.com wrote:
>> > > From: Thor Thayer
>> >
ut unrolling it again and assign both chip_types independently?
>
> If more code makes you happy so be it. I will post the series soon with
> the loop unrolled.
>
>> Sebastian
>
> Sebastian
You could keep the loop but take out the if (i==0). Set the type and
handler after the loop:
irq_gc->chip_types[0]->type = IRQ_TYPE_LEVEL_MASK;
irq_gc->chip_types[0]->handler = handle_level_irq;
irq_gc->chip_types[1]->type = IRQ_TYPE_EDGE_BOTH;
irq_gc->chip_types[1]->handler = handle_edge_irq;
Alan Tull
aka
delicious quinoa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Fri, Mar 28, 2014 at 1:27 PM, delicious quinoa
wrote:
> On Tue, Mar 18, 2014 at 4:55 PM, Pantelis Antoniou
> wrote:
>> The following patchset introduces Device Tree overlays, a method
>> of dynamically altering the kernel's live Device Tree, along with
>> a gen
conditions
> + * appropriately. Either the operation succeeds, or if it fails the
> + * live tree is reverted to the state before the attempt.
> + * Returns 0, or an error if the overlay attempt failed.
> + */
> +int of_overlay(int count, struct of_overlay_info *ovinfo_tab);
;] (do_rmdir+0x120/0x150) from [<8010a800>] (SyS_rmdir+0x20/0x24)
[<8010a800>] (SyS_rmdir+0x20/0x24) from [<8000eac0>] (ret_fast_syscall+0x0/0x30)
Code: e1a04000 e59f0074 eb12b02b e5943010 (e5932018)
---[ end trace 1b8539e83d8e0ecc ]---
./do-overlay-only: line 7: 175 Segmen
On Tue, Mar 18, 2014 at 4:56 PM, Pantelis Antoniou
wrote:
> Introduce DT overlay support.
> Using this functionality it is possible to dynamically overlay a part of
> the kernel's tree with another tree that's been dynamically loaded.
> It is also possible to remove node and properties.
>
> The cr
:11:
error: 'struct irq_chip' has no member named 'irq_request_resources'
/home/atull/repos/linux-socfpga/drivers/gpio/gpio-dwapb.c:254:36:
error: 'dwapb_irq_reqres' undeclared (first use in this function)
/home/atull/repos/linux-socfpga/drivers/gpio/gpio-dwapb.c:255:11:
On Fri, Mar 21, 2014 at 1:14 PM, delicious quinoa
wrote:
> On Thu, Mar 20, 2014 at 2:55 PM, Sebastian Andrzej Siewior
> wrote:
>> The cycloneV has three gpio controllers, each one with 29 gpios. This patch
>> adds the three controller with the gpio driver which is now sittin
here register 0...28.
Hi Sebastian,
The ref manual is wrong. It is 27. The last two aren't pinned out.
Alan Tull
aka
delicious quinoa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo
On Thu, Mar 20, 2014 at 2:55 PM, Sebastian Andrzej Siewior
wrote:
> The cycloneV has three gpio controllers, each one with 29 gpios. This patch
> adds the three controller with the gpio driver which is now sitting the
> gpio tree.
>
> Cc: devicet...@vger.kernel.org
> Signed-off-by: Sebastian Andrz
ionality has changed at some point or maybe
everybody copied the same bad code over and over. I see a lot of
legacy gpio drivers calling irq_create_mapping in their to_irq()
functions. Linus Walleij asked me to create the mappings at probe
time. Please see https://lkml.org/lkml/2014/2/10/154 and the
+++ b/drivers/gpio/Kconfig
@@ -132,7 +132,7 @@ config GPIO_DWAPB
tristate "Synopsys DesignWare APB GPIO driver"
select GPIO_GENERIC
select GENERIC_IRQ_CHIP
- depends on OF_GPIO && IRQ_DOMAIN
+ depends on OF_GPIO
help
Say Y or M h
show support for 1 gpio per port.
>> - gpio-cells = <1>
>
> Patch applied!
>
> You've done a tremendous work on this driver and there is
> absolutely nothing controversial about the bindings, so it is
> my pleasure to include this driver.
>
> Yours,
> Lin
On Tue, Feb 25, 2014 at 5:01 PM, Alan Tull wrote:
> From: Jamie Iles
>
> The Synopsys DesignWare block is used in some ARM devices (picoxcell)
> and can be configured to provide multiple banks of GPIO pins.
>
> Signed-off-by: Jamie Iles
> Signed-off-by: Alan Tull
> Reviewed-by: Sebastian Hessel
On Mon, Feb 24, 2014 at 6:20 AM, Linus Walleij wrote:
> On Wed, Feb 12, 2014 at 5:17 PM, delicious quinoa
> wrote:
>
>> I am wondering about the change in usage of
>> irq_find_mapping/irq_create_mapping. It seems like all the GPIO
>> drivers that use irq domains d
On Mon, Feb 10, 2014 at 5:06 AM, Linus Walleij wrote:
> Hi Alan, this is starting to look good. I's like an ACK from a DT
> maintainer on the bindings but can't see anything really controversial
> about them.
>
> On Thu, Feb 6, 2014 at 11:06 PM, Alan Tull wrote:
>
>> +static int dwapb_gpio_to_irq
struct dwapb_gpio_port *port)
>> +{
>> + struct gpio_chip *gc = &port->bgc.gc;
>> + struct device_node *node = gc->of_node;
>> + struct irq_chip_generic *irq_gc;
>> + unsigned int hwirq, ngpio = gc->ngpio;
>> + struct irq_chip_type *ct;
>> + int reg, err, irq;
>> +
>> + if (of_get_property(node, "interrupts", ®) == NULL)
>> + return;
>
> of_get_property can take a NULL lenp (core OF code depends on this
> fact), so you don't need the somewhat confusing ® here.
>
> Cheers,
> Mark.
Hi Mark,
Thanks for the feedback. I have made the changes in v11, which I just sent out.
Alan Tull
aka
delicious quinoa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Thu, Jan 30, 2014 at 3:32 PM, Steffen Trumtrar
wrote:
> On Thu, Jan 30, 2014 at 03:15:11PM -0600, delicious quinoa wrote:
>> On Thu, Jan 30, 2014 at 2:50 PM, Steffen Trumtrar
>> wrote:
>> > Hi!
>> >
>> > On Thu, Jan 30, 2014 at 01:40:04PM -0600, de
On Thu, Jan 30, 2014 at 2:50 PM, Steffen Trumtrar
wrote:
> Hi!
>
> On Thu, Jan 30, 2014 at 01:40:04PM -0600, delicious quinoa wrote:
>> On Thu, Dec 12, 2013 at 3:08 AM, Steffen Trumtrar
>> wrote:
>>
>> > Second: The interrupt is registered as "GIC 37"
On Thu, Dec 12, 2013 at 3:08 AM, Steffen Trumtrar
wrote:
> Second: The interrupt is registered as "GIC 37", which is a real interrupt on
> the Socfpga. I would expect it to be marked as "GPIO 2xx" (or something in
> that
> range). The interrupt from the gpiochip itself isn't registered at all ?!
On Thu, Dec 12, 2013 at 3:08 AM, Steffen Trumtrar
wrote:
> Sorry for chiming in late. I tested your driver on the Sockit and the GPIOs
> work fine (basically just tested the 4 HPS LEDS that are on this board).
>
> With the interrupt support I had a little trouble though:
> The Sockit has an ADXL34
On Fri, Dec 6, 2013 at 3:09 PM, Alan Tull wrote:
> From: Alan Tull
>
> Hi Linus,
>
> If you don't have any further comments, can you take this patch?
>
> Alan
Basically, this is a driver that Jamie wrote and was upstreaming a few
years ago. For some reason it never quite made it into the kernel
On Thu, Dec 5, 2013 at 4:53 PM, delicious quinoa
wrote:
> On Thu, Dec 5, 2013 at 10:54 AM, Jamie Iles wrote:
>> Hi Alan,
>>
>> One minor comment below, otherwise looks great!
>>
>> Signed-off-by: Jamie Iles
>>
>> Thanks,
>>
>> Jamie
On Wed, Dec 4, 2013 at 5:56 AM, Mark Rutland wrote:
> On Tue, Dec 03, 2013 at 04:41:16PM +, Alan Tull wrote:
>> From: Jamie Iles
>>
>> The Synopsys DesignWare block is used in some ARM devices (picoxcell)
>> and can be configured to provide multiple banks of GPIO pins.
>>
>> Signed-off-by: Al
On Thu, Dec 5, 2013 at 10:54 AM, Jamie Iles wrote:
> Hi Alan,
>
> One minor comment below, otherwise looks great!
>
> Signed-off-by: Jamie Iles
>
> Thanks,
>
> Jamie
>
> On Tue, Dec 03, 2013 at 10:41:16AM -0600, Alan Tull wrote:
>> diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.
On Thu, Nov 7, 2013 at 6:33 AM, Sebastian Hesselbarth
wrote:
> On 11/06/13 23:49, Alan Tull wrote:
>>
>> From: Jamie Iles
>>
>> The Synopsys DesignWare block is used in some ARM devices (picoxcell)
>> and can be configured to provide multiple banks of GPIO pins.
>>
>> Signed-off-by: Alan Tull
>>
On Tue, Nov 5, 2013 at 12:41 PM, Pantelis Antoniou
wrote:
> +
> + pr_info("%s: Applied #%d overlay segments @%d\n", __func__,
> + od->ovinfo_cnt, od->id);
> +
This could be pr_debug so that we get normally get silence unless
something fails, like insmod.
Also please t
On Wed, Nov 6, 2013 at 5:44 PM, Sebastian Hesselbarth
wrote:
>>> +struct dwapb_gpio {
>>> + struct device *dev;
>>> + void __iomem*regs;
>>> + struct dwapb_gpio_port *ports;
>>> + unsigned intnr_ports;
>>> + struct irq_domain *
On Wed, Nov 6, 2013 at 5:09 PM, Fabio Estevam wrote:
> On Wed, Nov 6, 2013 at 8:49 PM, Alan Tull wrote:
>
>> +
>> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> + gpio->regs = devm_ioremap_resource(&pdev->dev, res);
>> + if (!gpio->regs) {
>> + err = -E
On Tue, Nov 5, 2013 at 3:32 PM, Sebastian Hesselbarth
wrote:
> On 11/05/2013 05:55 PM, Alan Tull wrote:
>>
>> From: Alan Tull
>>
>> * Changes to get gpio-dwapb (originally v3.2-rc7) driver building and
>> working on current kernel.
>> * Use linear irq domain.
>> * Fix setting irq edge t
On Tue, Oct 8, 2013 at 4:44 PM, Greg Kroah-Hartman
wrote:
> On Tue, Oct 08, 2013 at 12:00:14PM -0500, Alan Tull wrote:
>> On Fri, 2013-10-04 at 16:33 -0700, Greg Kroah-Hartman wrote:
>> > On Fri, Oct 04, 2013 at 11:12:13AM -0700, H. Peter Anvin wrote:
>> > > On 10/04/2013 10:44 AM, Michal Simek wr
nder /proc, such as 'cat new-ip.dtb > /proc/device-tree'
Alan Tull
Altera Corp.
On Thu, Feb 21, 2013 at 3:53 PM, Pantelis Antoniou
wrote:
> Hi Alan,
>
> On Feb 21, 2013, at 1:25 PM, delicious quinoa wrote:
>
>> I like where this is heading. I'm interested in a
I like where this is heading. I'm interested in a use case where IP
can be loaded into a FPGA, then add a blob to the device tree and load
some drivers.
I see your github tree. If I wanted to cherry-pick your code and play
around with it, which branch should I use? not-capebus-21?
Thanks,
Alan
37 matches
Mail list logo
