Re: [PATCH] tools/nolibc: Add support for SPARC

2025-03-17 Thread Chris Torek
s never used, so that a per process mode bit suffices just as well. Still, the offset went in. Chris

Re: [PATCH v3 2/2] selftests: sched: skip cs_prctl_test for systems with core scheduling disabled

2025-02-26 Thread Chris Hyser
har *argv[]) > if (keypress) > delay = -1; > > + check_core_sched(); > + > srand(time(NULL)); > > /* put into separate process group */ > -- > 2.43.5 So assuming a return code of 4 means skip (and I believe you stated that affirmatively before), then this should solve the problem. Thanks for fixing this. Reviewed-by: Chris Hyser -chrish

Re: [PATCH v2 2/2] selftests: sched: skip cs_prctl_test for systems with core scheduling disabled

2025-02-24 Thread Chris Hyser
>From: Sinadin Shan >Sent: Monday, February 24, 2025 7:10 AM >To: Shrikanth Hegde; sh...@kernel.org >Cc: linux-kselft...@vger.kernel.org; linux-kernel@vger.kernel.org; Chris Hyser >Subject: Re: [PATCH v2 2/2] selftests: sched: skip cs_prctl_test for systems >with core schedul

Re: [PATCH] selftests: sched: add sched as a default selftest target

2025-02-20 Thread Chris Hyser
From: Chris Hyser Sent: Thursday, February 20, 2025 11:21 PM To: Sinadin Shan; Shrikanth Hegde Cc: linux-kselft...@vger.kernel.org; linux-kernel@vger.kernel.org; sh...@kernel.org Subject: Re: [PATCH] selftests: sched: add sched as a default selftest target > > From: Sinadin Shan

Re: [PATCH] selftests: sched: add sched as a default selftest target

2025-02-20 Thread Chris Hyser
From: Sinadin Shan Sent: Thursday, February 20, 2025 11:23 AM To: Chris Hyser; Shrikanth Hegde Cc: linux-kselft...@vger.kernel.org; linux-kernel@vger.kernel.org; sh...@kernel.org Subject: Re: [PATCH] selftests: sched: add sched as a default selftest target >> I guess my question is w

Re: [PATCH] selftests: sched: add sched as a default selftest target

2025-02-20 Thread Chris Hyser
From: Sinadin Shan Sent: Thursday, February 20, 2025 9:52 AM To: Shrikanth Hegde; Chris Hyser Cc: linux-kselft...@vger.kernel.org; linux-kernel@vger.kernel.org; sh...@kernel.org Subject: Re: [PATCH] selftests: sched: add sched as a default selftest target > On 20-02-2025 01:15 pm, Shrika

Re: [PATCH] selftests: sched: add sched as a default selftest target

2025-02-19 Thread Chris Hyser
> From: Sinadin Shan > Sent: Wednesday, February 19, 2025 1:46 AM > To: sh...@kernel.org > Cc: linux-kselft...@vger.kernel.org; linux-kernel@vger.kernel.org; Chris > Hyser; Sinadin Shan > Subject: [PATCH] selftests: sched: add sched as a default selftest target > > The s

Re: qrtr/mhi: NULL-deref with in-kernel pd-mapper

2024-11-05 Thread Chris Lew
On 11/4/2024 9:08 PM, Johan Hovold wrote: On Mon, Nov 04, 2024 at 04:26:15PM -0800, Chris Lew wrote: On 11/1/2024 8:01 AM, Johan Hovold wrote: [8.825593] Unable to handle kernel NULL pointer dereference at virtual address 0034 . [9.002030] CPU: 10 UID: 0 PID: 11

Re: qrtr/mhi: NULL-deref with in-kernel pd-mapper

2024-11-04 Thread Chris Lew
On 11/1/2024 8:01 AM, Johan Hovold wrote: Hi, I just ran into a NULL-deref in a qrts/mhi path during boot of the x1e80100 CRD for the second time. First time was with a 6.11 kernel (but I never got around to reporting it) and today it happened again with 6.12-rc5. Both times I was using the

Re: [PATCH] remoteproc: qcom: pas: Make remoteproc name human friendly

2024-10-29 Thread Chris Lew
he identifier for the remoteproc instance. It matches the typical names used when we speak about each instance, while still being unique. Signed-off-by: Bjorn Andersson --- drivers/remoteproc/qcom_q6v5_pas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Chris Lew

Re: [PATCH v2 1/2] rpmsg: glink: Handle rejected intent request better

2024-10-23 Thread Chris Lew
arrived => return -ETIMEDOUT - Abort TX, the edge is going away => return -ECANCELLED - Intent request was rejected => return -EAGAIN - Intent request was accepted, and an intent arrived => return 0 This patch was developed with input from Sarannya S, Deepak Kumar Singh, and Chris Lew.

Re: [PATCH v2 2/2] soc: qcom: pmic_glink: Handle GLINK intent allocation rejections

2024-10-23 Thread Chris Lew
(-EAGAIN). Retry the send until intent buffers becomes available, or an actual error occur. To avoid infinitely waiting for the firmware in the event that this misbehaves and no intents arrive, an arbitrary 5 second timeout is used. This patch was developed with input from Chris Lew. Reported

Re: [PATCH 3/3] rpmsg: glink: Introduce packet tracepoints

2024-08-07 Thread Chris Lew
tions(-) Reviewed-by: Chris Lew

Re: [PATCH 2/3] rpmsg: glink: Pass channel to qcom_glink_send_close_ack()

2024-08-07 Thread Chris Lew
| 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Chris Lew

Re: [PATCH 1/3] rpmsg: glink: Tidy up RX advance handling

2024-08-07 Thread Chris Lew
of the various messages. Signed-off-by: Bjorn Andersson --- drivers/rpmsg/qcom_glink_native.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) Reviewed-by: Chris Lew

[PATCH v3] init: staging: Fix missing warning/taint on builtin code

2024-07-05 Thread Ágatha Isabelle Chris Moreira Guedes
introduced but I think they're unavoidable. Some IMHO don´t make sense at all, I think they would apply for most regular macros but initcall macros are just way different. Fixes: 061b1bd394ca ("Staging: add TAINT_CRAP for all drivers/staging code") Signed-off-by: Ágatha Isabell

Re: [PATCH v2] init: staging: Fix missing warning/taint on builtin code

2024-07-05 Thread Ágatha Isabelle Chris Moreira Guedes
Hello, Please disregard this one, there will be a v3 soon. There were some oversights on my side regarding some review points, and also the code itself. On Thu, Jul 04, 2024 at 09:20:49PM GMT, Ágatha Isabelle Chris Moreira Guedes wrote: > diff --git a/init/main.c b/init/main.c >

[PATCH v2] init: staging: Fix missing warning/taint on builtin code

2024-07-04 Thread Ágatha Isabelle Chris Moreira Guedes
introduced but I think they're unavoidable. Some IMHO don´t make sense at all, I think they would apply for most regular macros but initcall macros are just way different. Signed-off-by: Ágatha Isabelle Chris Moreira Guedes --- CHANGELOG v2: - Changed the way we hook into the initcal

Re: [PATCH] staging: Fix missing warning/taint on builtin code

2024-07-02 Thread Ágatha Isabelle Chris Moreira Guedes
On Tue, Jul 02, 2024 at 09:50:49AM GMT, Uwe Kleine-König wrote: > Hello Ágatha, > > On Tue, Jul 02, 2024 at 02:44:31AM -0300, Ágatha Isabelle Chris Moreira > Guedes wrote: > > ACKNOWLEDGEMENTS > > Thanks for Jookia, heat and ukleinek for the important comments & &

[PATCH] staging: Fix missing warning/taint on builtin code

2024-07-01 Thread Ágatha Isabelle Chris Moreira Guedes
through initcalls and not through load_module(). This might prevent relevant information of being available on a bug report (i.e. on a panic log) among other possible problems. Signed-off-by: Ágatha Isabelle Chris Moreira Guedes --- ACKNOWLEDGEMENTS Thanks for Jookia, heat and ukleinek for the

Re: [PATCH 2/2] remoteproc: qcom: select AUXILIARY_BUS

2024-06-26 Thread Chris Lew
@@ config QCOM_PIL_INFO config QCOM_RPROC_COMMON tristate + select AUXILIARY_BUS config QCOM_Q6V5_COMMON tristate Reviewed-by: Chris Lew

Re: [PATCH 1/2] soc: qcom: add missing pd-mapper dependencies

2024-06-26 Thread Chris Lew
_OCMEM config QCOM_PD_MAPPER tristate "Qualcomm Protection Domain Mapper" select QCOM_QMI_HELPERS + select QCOM_PDR_MSG + select AUXILIARY_BUS depends on NET && QRTR default QCOM_RPROC_COMMON help Reviewed-by: Chris Lew

Re: [PATCH v9 1/5] soc: qcom: pdr: protect locator_addr with the main mutex

2024-06-24 Thread Chris Lew
otection Domain Restart helpers") Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Steev Klimaszewski Tested-by: Alexey Minnekhanov Signed-off-by: Dmitry Baryshkov Reviewed-by: Chris Lew

Re: [PATCH V2 2/2] soc: qcom: smp2p: Introduce tracepoint support

2024-06-11 Thread Chris Lew
On 6/11/2024 5:33 AM, Sudeepgoud Patil wrote: This commit introduces tracepoint support for smp2p, enabling logging of communication between local and remote processors. The tracepoints include information about the remote processor ID, remote subsystem name, negotiation details, supported fea

Re: [PATCH V2 1/2] soc: qcom: smp2p: Add remote name into smp2p irq devname

2024-06-11 Thread Chris Lew
On 6/11/2024 9:06 AM, Bjorn Andersson wrote: On Tue, Jun 11, 2024 at 06:03:50PM +0530, Sudeepgoud Patil wrote: Add smp2p irq devname which fetches remote name from respective smp2p dtsi node, which makes the wakeup source distinguishable in irq wakeup prints. Signed-off-by: Sudeepgoud Patil

Re: [PATCH v8 5/5] remoteproc: qcom: enable in-kernel PD mapper

2024-06-07 Thread Chris Lew
changed, 109 insertions(+) Thanks for looking into whether this could be implemented as a remoteproc subdevice. Reviewed-by: Chris Lew

Re: [PATCH v8 4/5] soc: qcom: add pd-mapper implementation

2024-06-07 Thread Chris Lew
- drivers/soc/qcom/Kconfig | 11 + drivers/soc/qcom/Makefile | 1 + drivers/soc/qcom/pdr_internal.h | 14 + drivers/soc/qcom/qcom_pd_mapper.c | 676 ++ drivers/soc/qcom/qcom_pdr_msg.c | 34 ++ 5 files changed, 736 insertions(+) Reviewed-by: Chris Lew

Re: [PATCH v8 2/5] soc: qcom: pdr: fix parsing of domains lists

2024-06-05 Thread Chris Lew
goto out; - for (i = domains_read; i < resp->domain_list_len; i++) { + for (i = 0; i < resp->domain_list_len; i++) { entry = &resp->domain_list[i]; if (strnlen(entry->name, sizeof(entry->name)) == sizeof(entry->name)) Reviewed-by: Chris Lew

Re: [PATCH v8 1/5] soc: qcom: pdr: protect locator_addr with the main mutex

2024-06-05 Thread Chris Lew
t is locator_addr. Wouldn't this delay other work like new/del server notifications if this qmi service is delayed or non-responsive? Thanks, Chris if (resp->resp.result != QMI_RESULT_SUCCESS_V01) { pr_err("PDR: %s get domain list failed: 0x%x\n", @@

Re: [PATCH V1] rpmsg: glink: Make glink smem interrupt wakeup capable

2024-06-04 Thread Chris Lew
may stall. The glink protocol traffic not tied to a TX_DATA command, such as intent requests, wouldn't wake the system even if the channel is configured to be wake capable. Thanks, Chris Thanks and regards, Signed-off-by: Deepak Kumar Singh ---   drivers/rpmsg/qcom_glink_smem.c |

Re: [PATCH V1] soc: qcom: smp2p: Introduce tracepoint support

2024-04-30 Thread Chris Lew
On 4/29/2024 12:55 AM, Sudeepgoud Patil wrote: Introduce tracepoint support for smp2p providing useful logging for communication between clients. Let's add some more description as to why these tracepoint are useful. Do they help us track latency? debugging information for us? for clients?

Re: [PATCH v7 6/6] remoteproc: qcom: enable in-kernel PD mapper

2024-04-30 Thread Chris Lew
On 4/26/2024 6:36 PM, Dmitry Baryshkov wrote: On Sat, 27 Apr 2024 at 04:03, Chris Lew wrote: On 4/24/2024 2:28 AM, Dmitry Baryshkov wrote: diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c b/drivers/remoteproc/qcom_q6v5_adsp.c index 1d24c9b656a8..02d0c626b03b 100644 --- a/drivers

Re: [PATCH v7 6/6] remoteproc: qcom: enable in-kernel PD mapper

2024-04-26 Thread Chris Lew
on. I'm not an expert on remoteproc organization but this was just a thought. Thanks! Chris + ret = qcom_q6v5_prepare(&adsp->q6v5); + if (ret) + goto put_pdm; + ret = adsp_map_carveout(rproc); if (ret) { dev_err(adsp->dev, &qu

Re: [PATCH v7 5/6] soc: qcom: add pd-mapper implementation

2024-04-26 Thread Chris Lew
On 4/24/2024 2:28 AM, Dmitry Baryshkov wrote: +static int qcom_pdm_start(void) +{ + const struct of_device_id *match; + const struct qcom_pdm_domain_data * const *domains; + struct device_node *root; + int ret, i; + + root = of_find_node_by_path("/"); + if

Re: [PATCH v7 4/6] soc: qcom: qmi: add a way to remove running service

2024-04-25 Thread Chris Lew
On 4/24/2024 2:28 AM, Dmitry Baryshkov wrote: Add qmi_del_server(), a pair to qmi_add_server(), a way to remove running server from the QMI socket. This is e.g. necessary for pd-mapper, which needs to readd a server each time the DSP is started or s/readd/read/ stopped. Tested-by: Neil Ar

Re: [PATCH v7 1/6] soc: qcom: pdr: protect locator_addr with the main mutex

2024-04-25 Thread Chris Lew
it as an ordered_workqueue? Even in a fast pdr scenario I don't think we would see a race condition between these two functions. The other access these two functions do race against is in the pdr_notifier_work. I think you would need to protect locator_addr in pdr_get_domain_list since the qmi_send_request there uses 'pdr->locator_addr'. Thanks! Chris

Re: [PATCH V1] net: qrtr: ns: Ignore ENODEV failures in ns

2023-12-26 Thread Chris Lew
wrote: From: Chris Lew Ignore the ENODEV failures returned by kernel_sendmsg(). These errors indicate that either the local port has been closed or the remote has gone down. Neither of these scenarios are fatal and will eventually be handled through packets that are later queued on the control port

RE: [PATCH] x86/sgx: Charge proper mem_cgroup for usage due to EPC reclamation by cgroups

2023-11-09 Thread Chris Yan (HE/HIM)
Tested by: Chris Yan

Re: [PATCH v2 2/2] powerpc/legacy_serial: Use early_ioremap()

2021-04-20 Thread Chris Packham
message is gone and I still get console output. Tested-by: Chris Packham > arch/powerpc/kernel/legacy_serial.c | 33 + > 1 file changed, 29 insertions(+), 4 deletions(-) > > diff --git a/arch/powerpc/kernel/legacy_serial.c > b/arch/powerpc/kernel/leg

[PATCH] USB: Add reset-resume quirk for WD19's Realtek Hub

2021-04-20 Thread chris . chiu
From: Chris Chiu Realtek Hub (0bda:5487) in Dell Dock WD19 sometimes fails to work after the system resumes from suspend with remote wakeup enabled device connected: [ 1947.640907] hub 5-2.3:1.0: hub_ext_port_status failed (err = -71) [ 1947.641208] usb 5-2.3-port5: cannot disable (err = -71

Re: [PATCH v3] USB: Don't set USB_PORT_FEAT_SUSPEND on WD19's Realtek Hub

2021-04-20 Thread Chris Chiu
On Tue, Apr 20, 2021 at 11:28 PM Alan Stern wrote: > > On Tue, Apr 20, 2021 at 03:14:56PM +0800, Chris Chiu wrote: > > On Mon, Apr 19, 2021 at 10:19 PM Alan Stern > > wrote: > > > > > > On Mon, Apr 19, 2021 at 01:11:38AM -0400, Chris Chiu wrote: > > &g

[PATCH 1/1 v10] x86/power use crc32 instead of md5 for hibernation e820 integrity check

2021-04-20 Thread Chris von Recklinghausen
erify the consistent of e820 memory map by md5 digest") Reviewed-by: Eric Biggers Tested-by: Dexuan Cui Reviewed-by: Dexuan Cui Signed-off-by: Chris von Recklinghausen --- v1 -> v2 bump up RESTORE_MAGIC v2 -> v3 move embelishment from cover letter to commit comments (no code

[PATCH 1/1 v9] use crc32 instead of md5 for hibernation e820 integrity check

2021-04-20 Thread Chris von Recklinghausen
erify the consistent of e820 memory map by md5 digest") Signed-off-by: Chris von Recklinghausen --- v1 -> v2 bump up RESTORE_MAGIC v2 -> v3 move embelishment from cover letter to commit comments (no code change) v3 -> v4 add note to comments that md5 isn't used

Re: [PATCH v3] USB: Don't set USB_PORT_FEAT_SUSPEND on WD19's Realtek Hub

2021-04-20 Thread Chris Chiu
On Mon, Apr 19, 2021 at 10:19 PM Alan Stern wrote: > > On Mon, Apr 19, 2021 at 01:11:38AM -0400, Chris Chiu wrote: > > Sorry that I didn't make myself clear. I found that if I applied > > RESET_RESUME > > quirk on the problematic hub, the Set-Port-Feature(suspend)

Broadcom 9460 raid card takes too long at system resuming

2021-04-19 Thread Chris Chiu
0:45:00.0: JBOD sequence map support : Yes [ 104.550585] megaraid_sas :45:00.0: PCI Lane Margining support: No [ 104.550999] megaraid_sas :45:00.0: megasas_enable_intr_fusion is called outbound_intr_mask:0x4000 Chris

Re: [PATCH v3] USB: Don't set USB_PORT_FEAT_SUSPEND on WD19's Realtek Hub

2021-04-18 Thread Chris Chiu
On Fri, Apr 16, 2021 at 11:39 AM Alan Stern wrote: > > On Fri, Apr 16, 2021 at 09:24:30AM +0800, Chris Chiu wrote: > > On Fri, Apr 16, 2021 at 2:46 AM Alan Stern > > wrote: > > > > > > On Fri, Apr 16, 2021 at 12:13:43AM +0800, Chris Chiu wrote: > > &g

Re: [PATCH v5] printk: Userspace format enumeration support

2021-04-16 Thread Chris Down
Joe Perches writes: On Fri, 2021-04-16 at 14:56 +0100, Chris Down wrote: Any better suggestions? :-) A gcc plugin that looks for functions marked __printf(fmt, pos) so any const fmt is stored. I fail to see any way in which that can solve the problem described, which is mobility of the

Re: [PATCH v5] printk: Userspace format enumeration support

2021-04-16 Thread Chris Down
ntry, with semantics that if it's some sentinel value, look at the format itself for the format, otherwise if it's some other value, the level field itself is the level. This will work, but it's pretty ugly. Any better suggestions? :-) Thanks, Chris

[PATCH 1/1 v9] use crc32 instead of md5 for hibernation e820 integrity check

2021-04-16 Thread Chris von Recklinghausen
erify the consistent of e820 memory map by md5 digest") Signed-off-by: Chris von Recklinghausen --- v1 -> v2 bump up RESTORE_MAGIC v2 -> v3 move embelishment from cover letter to commit comments (no code change) v3 -> v4 add note to comments that md5 isn't used

Re: [PATCH v3] USB: Don't set USB_PORT_FEAT_SUSPEND on WD19's Realtek Hub

2021-04-15 Thread Chris Chiu
On Fri, Apr 16, 2021 at 2:46 AM Alan Stern wrote: > > On Fri, Apr 16, 2021 at 12:13:43AM +0800, Chris Chiu wrote: > > One thing worth mentioning here, I never hit the hub_ext_port_status -71 > > problem if I resume by waking up from the keyboard connected to the hub. >

[PATCH v8 1/1] use crc32 instead of md5 for hibernation e820 integrity check

2021-04-15 Thread Chris von Recklinghausen
inadvertent deviations. Fixes: 62a03defeabd ("PM / hibernate: Verify the consistent of e820 memory map by md5 digest") Signed-off-by: Chris von Recklinghausen --- v1 -> v2 bump up RESTORE_MAGIC v2 -> v3 move embelishment from cover letter to commit comments (no code

Re: [PATCH v3] USB: Don't set USB_PORT_FEAT_SUSPEND on WD19's Realtek Hub

2021-04-15 Thread Chris Chiu
On Thu, Apr 15, 2021 at 8:32 PM Greg KH wrote: > > On Thu, Apr 15, 2021 at 07:48:56PM +0800, chris.c...@canonical.com wrote: > > From: Chris Chiu > > > > Realtek Hub (0bda:5487) in Dell Dock WD19 sometimes fails to work > > after the system resumes from susp

[PATCH v3] USB: Don't set USB_PORT_FEAT_SUSPEND on WD19's Realtek Hub

2021-04-15 Thread chris . chiu
From: Chris Chiu Realtek Hub (0bda:5487) in Dell Dock WD19 sometimes fails to work after the system resumes from suspend with remote wakeup enabled device connected: [ 1947.640907] hub 5-2.3:1.0: hub_ext_port_status failed (err = -71) [ 1947.641208] usb 5-2.3-port5: cannot disable (err = -71

[PATCH v4 6/6] i2c: mpc: Drop duplicate message from devm_platform_ioremap_resource()

2021-04-14 Thread Chris Packham
From: Andy Shevchenko devm_platform_ioremap_resource() prints a message in case of error. Drop custom one. Signed-off-by: Andy Shevchenko Reviewed-by: Chris Packham Signed-off-by: Chris Packham --- drivers/i2c/busses/i2c-mpc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff

[PATCH v4 3/6] i2c: mpc: Use devm_clk_get_optional()

2021-04-14 Thread Chris Packham
From: Andy Shevchenko The peripheral clock is optional and we may get an -EPROBE_DEFER error code which would not be propagated correctly, fix this by using devm_clk_get_optional(). Signed-off-by: Andy Shevchenko Reviewed-by: Chris Packham Signed-off-by: Chris Packham --- drivers/i2c/busses

[PATCH v4 5/6] i2c: mpc: Use device_get_match_data() helper

2021-04-14 Thread Chris Packham
From: Andy Shevchenko Use the device_get_match_data() helper instead of open coding. Signed-off-by: Andy Shevchenko Reviewed-by: Chris Packham Signed-off-by: Chris Packham --- drivers/i2c/busses/i2c-mpc.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a

[PATCH v4 1/6] i2c: mpc: Interrupt driven transfer

2021-04-14 Thread Chris Packham
timeout if we take too long between bytes in a transfer. Signed-off-by: Chris Packham --- Notes: Changes in v4: - Split license/copyright change to separate patch - Remove MPC_I2C_ACTION_INVALID - make action_str const - Remove __func__ from dev_dbg output - Use Tx ACK/Rx ACK

[PATCH v4 4/6] i2c: mpc: Remove CONFIG_PM_SLEEP ifdeffery

2021-04-14 Thread Chris Packham
From: Andy Shevchenko Use __maybe_unused for the suspend()/resume() hooks and get rid of the CONFIG_PM_SLEEP ifdeffery to improve the code. Signed-off-by: Andy Shevchenko Reviewed-by: Chris Packham Signed-off-by: Chris Packham --- Notes: Changes in v4: - Fix compile error due to

[PATCH v4 2/6] i2c: mpc: Update license and copyright

2021-04-14 Thread Chris Packham
Use SPDX-License-Identifier and add copyright for Allied Telesis because of the reasonably large rewrite in the preceding patch. Signed-off-by: Chris Packham --- Notes: Changes in v4: - New, split out from "i2c: mpc: Interrupt driven transfer" drivers/i2c/busses/i2c-

[PATCH v4 0/6] i2c: mpc: Refactor to improve responsiveness

2021-04-14 Thread Chris Packham
i2c: mpc: Use device_get_match_data() helper i2c: mpc: Drop duplicate message from devm_platform_ioremap_resource() Chris Packham (2): i2c: mpc: Interrupt driven transfer i2c: mpc: Update license and copyright drivers/i2c/busses/i2c-mpc.c | 492 +++ 1 file ch

Re: [PATCH v1 2/4] i2c: mpc: Remove CONFIG_PM_SLEEP ifdeffery

2021-04-14 Thread Chris Packham
On 15/04/21 12:14 am, Andy Shevchenko wrote: > On Tue, Apr 13, 2021 at 11:43:25PM +0000, Chris Packham wrote: >> On 14/04/21 2:37 am, Andy Shevchenko wrote: >>> Use __maybe_unused for the suspend()/resume() hooks and get rid of >>> the CONFIG_PM_SLEEP ifdeffery to impr

Re: [PATCH] USB: Don't set USB_PORT_FEAT_SUSPEND on WD19's Realtek Hub

2021-04-14 Thread Chris Chiu
On Wed, Apr 14, 2021 at 10:32 PM Alan Stern wrote: > > On Wed, Apr 14, 2021 at 01:07:43PM +0800, Chris Chiu wrote: > > Thanks for the instructions. I can hit the same timeout problem with > > runtime PM. The > > fail rate seems the same as normal PM. (around 1/4 ~ 1/7

Re: [PATCH] USB: Don't set USB_PORT_FEAT_SUSPEND on WD19's Realtek Hub

2021-04-13 Thread Chris Chiu
On Tue, Apr 13, 2021 at 10:44 PM Alan Stern wrote: > > On Tue, Apr 13, 2021 at 03:52:14PM +0800, Chris Chiu wrote: > > On Mon, Apr 12, 2021 at 11:12 PM Alan Stern > > wrote: > > > > > > On Mon, Apr 12, 2021 at 11:00:06PM +0800, chris.c...@canonical.com wrot

Re: [PATCH] [v4] Input: Add "Select" button to Microsoft Xbox One controller.

2021-04-13 Thread Chris Ye
That line was using tab + 4 spaces on the left and was reformatted to use 2 tabs. If you don't like it I've uploaded patch v5 not touching that line. On Tue, Apr 13, 2021 at 5:34 AM Bastien Nocera wrote: > > On Tue, 2021-04-13 at 01:02 +, Chris Ye wrote: > > Add

[PATCH] [v5] Input: Add "Select" button to Microsoft Xbox One controller.

2021-04-13 Thread Chris Ye
Add "Select" button input capability and input event mapping for Microsoft Xbox One controller. From product site this is also referred as "Share" button. Fixed Microsoft Xbox One controller select button not working under USB connection. Signed-off-by: Chris Ye --- dr

Re: [PATCH v1 4/4] i2c: mpc: Drop duplicate message from devm_platform_ioremap_resource()

2021-04-13 Thread Chris Packham
On 14/04/21 2:37 am, Andy Shevchenko wrote: > devm_platform_ioremap_resource() prints a message in case of error. > Drop custom one. > > Signed-off-by: Andy Shevchenko Reviewed-by: Chris Packham > --- > drivers/i2c/busses/i2c-mpc.c | 4 +--- > 1 file changed, 1 inse

Re: [PATCH v1 3/4] i2c: mpc: Use device_get_match_data() helper

2021-04-13 Thread Chris Packham
On 14/04/21 2:37 am, Andy Shevchenko wrote: > Use the device_get_match_data() helper instead of open coding. > > Signed-off-by: Andy Shevchenko Reviewed-by: Chris Packham > --- > drivers/i2c/busses/i2c-mpc.c | 12 > 1 file changed, 4 insertions(+), 8 deletions

Re: [PATCH v1 2/4] i2c: mpc: Remove CONFIG_PM_SLEEP ifdeffery

2021-04-13 Thread Chris Packham
On 14/04/21 2:37 am, Andy Shevchenko wrote: > Use __maybe_unused for the suspend()/resume() hooks and get rid of > the CONFIG_PM_SLEEP ifdeffery to improve the code. > > Signed-off-by: Andy Shevchenko > --- > drivers/i2c/busses/i2c-mpc.c | 12 ++-- > 1 file changed, 2 insertions(+), 10

Re: [PATCH v1 1/4] i2c: mpc: Use devm_clk_get_optional()

2021-04-13 Thread Chris Packham
On 14/04/21 2:37 am, Andy Shevchenko wrote: > The peripheral clock is optional and we may get an -EPROBE_DEFER error code > which would not be propagated correctly, fix this by using > devm_clk_get_optional(). > > Signed-off-by: Andy Shevchenko Reviewed-by: Chris Packham None o

Re: [PATCH v3 2/4] i2c: mpc: Interrupt driven transfer

2021-04-13 Thread Chris Packham
On 14/04/21 10:28 am, Chris Packham wrote: > > On 14/04/21 1:52 am, Andy Shevchenko wrote: >> On Tue, Apr 13, 2021 at 8:10 AM Chris Packham >> wrote: >>> The fsl-i2c controller will generate an interrupt after every byte >>> transferred. Make use of this inte

Re: [PATCH v3 2/4] i2c: mpc: Interrupt driven transfer

2021-04-13 Thread Chris Packham
On 14/04/21 1:52 am, Andy Shevchenko wrote: > On Tue, Apr 13, 2021 at 8:10 AM Chris Packham > wrote: >> The fsl-i2c controller will generate an interrupt after every byte >> transferred. Make use of this interrupt to drive a state machine which >> allows the next part of

[PATCH v7 1/1] use crc32 instead of md5 for hibernation e820 integrity check

2021-04-13 Thread Chris von Recklinghausen
inadvertent deviations. Signed-off-by: Chris von Recklinghausen --- v1 -> v2 bump up RESTORE_MAGIC v2 -> v3 move embelishment from cover letter to commit comments (no code change) v3 -> v4 add note to comments that md5 isn't used for encryption here. v4 -> v5 reword c

[PATCH v2] USB: Don't set USB_PORT_FEAT_SUSPEND on WD19's Realtek Hub

2021-04-13 Thread chris . chiu
From: Chris Chiu Realtek Hub (0bda:5487) in Dell Dock WD19 sometimes fails to work after the system resumes from suspend with remote wakeup enabled device connected: [ 1947.640907] hub 5-2.3:1.0: hub_ext_port_status failed (err = -71) [ 1947.641208] usb 5-2.3-port5: cannot disable (err = -71

Re: [PATCH] USB: Don't set USB_PORT_FEAT_SUSPEND on WD19's Realtek Hub

2021-04-13 Thread Chris Chiu
On Mon, Apr 12, 2021 at 11:12 PM Alan Stern wrote: > > On Mon, Apr 12, 2021 at 11:00:06PM +0800, chris.c...@canonical.com wrote: > > From: Chris Chiu > > > > Realtek Hub (0bda:5413) in Dell Dock WD19 sometimes fails to work > > after the system resumes from susp

Re: [PATCH v3 3/3] MAINTAINERS: Add Chris Packham as FREESCALE MPC I2C maintainer

2021-04-12 Thread Chris Packham
On 13/04/21 5:09 pm, Chris Packham wrote: > Add Chris Packham as FREESCALE MPC I2C maintainer. > > Signed-off-by: Chris Packham Sorry for the duplicate. I had existing output from an earlier invocation of git format-patch lying around. "[PATCH v3 4/4] MAINTAINERS: ..." is th

[PATCH v3 4/4] MAINTAINERS: Add Chris Packham as FREESCALE MPC I2C maintainer

2021-04-12 Thread Chris Packham
Add Chris Packham as FREESCALE MPC I2C maintainer. Signed-off-by: Chris Packham --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 56e9e4d777d8..3bc77ba8cd05 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7135,6 +7135,13 @@ S

[PATCH v3 1/4] i2c: mpc: use device managed APIs

2021-04-12 Thread Chris Packham
Use device managed functions an clean up error handling. Signed-off-by: Chris Packham Signed-off-by: Wolfram Sang --- Notes: Changes in v3: - Assuming 09aab7add7bf is reverted I've folded in the fix from Wei Yongjun[1] into the original patch. If Wei's patch is appl

[PATCH v3 3/4] i2c: mpc: Remove redundant NULL check

2021-04-12 Thread Chris Packham
redundant so remove the check. Reported-by: Wolfram Sang Signed-off-by: Chris Packham --- drivers/i2c/busses/i2c-mpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c index 9818f9f6a553..c30687483147 100644 --- a/drivers

[PATCH v3 0/4] i2c: mpc: Refactor to improve responsiveness

2021-04-12 Thread Chris Packham
verted. I've tested on T2081 and P2041 based systems with a number of i2c and smbus devices. Also this time I included a few iterations of module insert/remove which would have caught the earlier errors. Chris Packham (4): i2c: mpc: use device managed APIs i2c: mpc: Interrupt driven tr

[PATCH v3 2/4] i2c: mpc: Interrupt driven transfer

2021-04-12 Thread Chris Packham
timeout if we take too long between bytes in a transfer. Signed-off-by: Chris Packham --- Notes: Changes in v3: - use WARN/WARN_ON instead of BUG/BUG_ON Changes in v2: - add static_assert for state debug strings - remove superfluous space drivers/i2c/busses/i2c-mpc.c | 434

[PATCH v3 3/3] MAINTAINERS: Add Chris Packham as FREESCALE MPC I2C maintainer

2021-04-12 Thread Chris Packham
Add Chris Packham as FREESCALE MPC I2C maintainer. Signed-off-by: Chris Packham --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 56e9e4d777d8..3bc77ba8cd05 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7135,6 +7135,13 @@ S

[PATCH] [v4] Input: Add "Select" button to Microsoft Xbox One controller.

2021-04-12 Thread Chris Ye
Add "Select" button input capability and input event mapping for Microsoft Xbox One controller. From product site this is also referred as "Share" button. Fixed Microsoft Xbox One controller select button not working under USB connection. Signed-off-by: Chris Ye --- dr

Re: [PATCH v2 5/6] i2c: mpc: use device managed APIs

2021-04-12 Thread Chris Packham
On 13/04/21 11:21 am, Chris Packham wrote: > > On 13/04/21 10:52 am, Andy Shevchenko wrote: >> On Mon, Mar 29, 2021 at 4:54 AM Chris Packham >> wrote: >>> Use device managed functions an clean up error handling. >> For the god sake how have you tested this? >&

Re: [PATCH v2 5/6] i2c: mpc: use device managed APIs

2021-04-12 Thread Chris Packham
On 13/04/21 10:52 am, Andy Shevchenko wrote: > On Mon, Mar 29, 2021 at 4:54 AM Chris Packham > wrote: >> Use device managed functions an clean up error handling. > For the god sake how have you tested this? > The patch is broken. I've clearly missed the remove path in my

Re: [PATCH v6 1/1] use crc32 instead of md5 for hibernation e820 integrity check

2021-04-12 Thread Chris von Recklinghausen
On 4/12/21 3:27 PM, Ard Biesheuvel wrote: On Mon, 12 Apr 2021 at 21:20, Eric Biggers wrote: On Mon, Apr 12, 2021 at 03:04:58PM -0400, Chris von Recklinghausen wrote: On 4/12/21 1:45 PM, Eric Biggers wrote: On Mon, Apr 12, 2021 at 10:09:32AM -0400, Chris von Recklinghausen wrote: Suspend

Re: [PATCH v6 1/1] use crc32 instead of md5 for hibernation e820 integrity check

2021-04-12 Thread Chris von Recklinghausen
On 4/12/21 3:20 PM, Eric Biggers wrote: On Mon, Apr 12, 2021 at 03:04:58PM -0400, Chris von Recklinghausen wrote: On 4/12/21 1:45 PM, Eric Biggers wrote: On Mon, Apr 12, 2021 at 10:09:32AM -0400, Chris von Recklinghausen wrote: Suspend fails on a system in fips mode because md5 is used for

Re: [PATCH v6 1/1] use crc32 instead of md5 for hibernation e820 integrity check

2021-04-12 Thread Chris von Recklinghausen
On 4/12/21 1:45 PM, Eric Biggers wrote: On Mon, Apr 12, 2021 at 10:09:32AM -0400, Chris von Recklinghausen wrote: Suspend fails on a system in fips mode because md5 is used for the e820 integrity check and is not available. Use crc32 instead. This patch changes the integrity check algorithm

[PATCH] USB: Don't set USB_PORT_FEAT_SUSPEND on WD19's Realtek Hub

2021-04-12 Thread chris . chiu
From: Chris Chiu Realtek Hub (0bda:5413) in Dell Dock WD19 sometimes fails to work after the system resumes from suspend with remote wakeup enabled device connected: [ 1947.640907] hub 5-2.3:1.0: hub_ext_port_status failed (err = -71) [ 1947.641208] usb 5-2.3-port5: cannot disable (err = -71

[PATCH v6 1/1] use crc32 instead of md5 for hibernation e820 integrity check

2021-04-12 Thread Chris von Recklinghausen
grity check. Fixes: 62a03defeabd ("PM / hibernate: Verify the consistent of e820 memory map by md5 digest") Signed-off-by: Chris von Recklinghausen --- v1 -> v2 bump up RESTORE_MAGIC v2 -> v3 move embelishment from cover letter to commit comments (no code change) v3

Re: [PATCH v2 4/6] i2c: mpc: make interrupt mandatory and remove polling code

2021-04-11 Thread Chris Packham
On 11/04/21 8:16 am, Wolfram Sang wrote: > On Mon, Mar 29, 2021 at 02:52:04PM +1300, Chris Packham wrote: >> All the in-tree dts files that use one of the compatible strings from >> i2c-mpc.c provide an interrupt property. By making this mandatory we >> can simplify the code

Re: [PATCH v2 6/6] i2c: mpc: Interrupt driven transfer

2021-04-11 Thread Chris Packham
On 11/04/21 8:13 am, Wolfram Sang wrote: > On Mon, Mar 29, 2021 at 02:52:06PM +1300, Chris Packham wrote: >> The fsl-i2c controller will generate an interrupt after every byte >> transferred. Make use of this interrupt to drive a state machine which >> allows the next

Re: [PATCH] [v2] Input: Add "Share" button to Microsoft Xbox One controller.

2021-04-09 Thread Chris Ye
Quickly pair with, play on, and switch between devices " Should we override the product button name and name it "Select" in driver? I am ok with either way but can we have a name everyone can agree on and move forward? Thanks! Chris On Tue, Mar 23, 2021 at 2:52 PM Chris Ye wrote:

Re: [PATCH v4 1/1] use crc32 instead of md5 for hibernation e820 integrity check

2021-04-09 Thread Chris von Recklinghausen
On 4/9/21 12:56 PM, David Laight wrote: From: Chris von Recklinghausen Sent: 08 April 2021 11:46 Suspend fails on a system in fips mode because md5 is used for the e820 integrity check and is not available. Use crc32 instead. Prior to this patch, MD5 is used only to create a digest to ensure

Re: [PATCH] mm: page_counter: mitigate consequences of a page_counter underflow

2021-04-08 Thread Chris Down
was a more straight-forward correction inside the spinlock section. I didn't carry it forward into the lockless page counters for simplicity, but it turns out this is quite useful in practice. ] Signed-off-by: Johannes Weiner Acked-by: Chris Down --- mm/page_counter.c | 8 ++-- 1 file ch

Re: [PATCH v5 1/1] use crc32 instead of md5 for hibernation e820 integrity check

2021-04-08 Thread Chris von Recklinghausen
On 4/8/21 11:30 AM, Eric Biggers wrote: On Thu, Apr 08, 2021 at 09:15:06AM -0400, Chris von Recklinghausen wrote: Suspend fails on a system in fips mode because md5 is used for the e820 integrity check and is not available. Use crc32 instead. This patch changes the integrity check algorithm

[PATCH v5 1/1] use crc32 instead of md5 for hibernation e820 integrity check

2021-04-08 Thread Chris von Recklinghausen
Dexuan Cui Reviewed-by: Dexuan Cui Signed-off-by: Chris von Recklinghausen --- v1 -> v2 bump up RESTORE_MAGIC v2 -> v3 move embelishment from cover letter to commit comments (no code change) v3 -> v4 add note to comments that md5 isn't used for encryption here. v4 -> v5

[PATCH v4 1/1] use crc32 instead of md5 for hibernation e820 integrity check

2021-04-08 Thread Chris von Recklinghausen
Dexuan Cui Reviewed-by: Dexuan Cui Signed-off-by: Chris von Recklinghausen --- v1 -> v2 bump up RESTORE_MAGIC v2 -> v3 move embelishment from cover letter to commit comments (no code change) v3 -> v4 add note to comments that md5 isn't used for encryption here. arch/x8

[PATCH v3 1/1] use crc32 instead of md5 for hibernation e820 integrity check

2021-04-07 Thread Chris von Recklinghausen
use crc32 instead of md5 since crc32 is available in both FIPS and non-FIPS modes. Fixes: 62a03defeabd ("PM / hibernate: Verify the consistent of e820 memory map by md5 digest") Tested-by: Dexuan Cui Reviewed-by: Dexuan Cui Signed-off-by: Chris von Recklinghausen --- v1 ->

[PATCH 1/1] SUNRPC: Handle major timeout in xprt_adjust_timeout()

2021-04-04 Thread Chris Dion
which the ETIMEOUT is processed back to the caller, the cpu spinning stops, and normal operations continue Fixes: 7de62bc09fe6 ("SUNRPC dont update timeout value on connection reset") Signed-off-by: Chris Dion --- Hello, We recently have noticed an issue where we see a cpu spin

Re: Fix hibernation in FIPS mode?

2021-04-01 Thread Chris von Recklinghausen
ity checking here AFAICS. It might be made a fallback option if MD5 is not available, but making it the default would be somewhat over the top IMO. Would ghash be a better choice? It produces the same size digest as md5. Does anyone have any other suggestions of algorithms to try? Thanks,

  1   2   3   4   5   6   7   8   9   10   >