Re: Linux, tcpdump and vlan

2007-07-19 Thread andrei radulescu-banu
During debugging, I noticed that dev_queue_xmit() is called twice for tx vlan frames. This results in a frame being passed twice to a packet socket bound to 'any' interface. If the packet socket is bound to a specific interface, though, it will get only one copy of the tx frame, which is good.

Re: Linux, tcpdump and vlan

2007-07-19 Thread andrei radulescu-banu
> [Ben] If tcpdump and/or bridging needs to disable the hw-accel, then it can explicitly do so by some API. That is better than overloading the promisc flag in my opinion. I guess I could be persuaded in the end. But let me still play devil advocate. The semantics of 'promiscuous', in my opin

Re: Linux, tcpdump and vlan

2007-07-19 Thread andrei radulescu-banu
>> [Andrei] VLAN_TX_SKB_CB() is perfect for that. > [Patrick, Stephen] No its not. Its only legal to use while something has > ownership of the skb. Between VLAN devices and real devices qdiscs are free to use it. All right, using VLAN_TX_SKB_CB() is a bad idea. In that case, we need to amend t

Re: Linux, tcpdump and vlan

2007-07-19 Thread andrei radulescu-banu
One additional thought: with the proposed changes in my prev message, the driver can be set to hw vlan accelerated mode, even if no vlan interfaces are configured. We would not have to switch hw vlan accelerated mode anymore, when vlan interfaces are created or destroyed. _

Re: Linux, tcpdump and vlan

2007-07-19 Thread andrei radulescu-banu
ut going out and have already been set up for the opposite mode. Any comments on what is the expected behavior of 'tcpdump -i eth0.2' vs. 'tcpdump -i eth0'? Andrei Radulescu-Banu Brix Networks _

Linux, tcpdump and vlan

2007-07-18 Thread andrei radulescu-banu
g 'tcpdump -I eth0.2'? Perhaps the packet socket should silently display all frames on eth0, so running 'tcpdump -i eth0' is equivalent to 'tcpdump -i eth0.2' Thoughts? Comments? Please cc [EMAIL PROTECTED], I am not subs