E check, ACK this part.
But I don't know in what case the buffer[0] could be zero, if it
happens, better to set elength 1 then goto next_desc? (I'm not a
maintainer, pleas also consider others' opinion)
--
Adam Lee
http://adam8157.info
--
To unsubscribe from this list: send the li
++-
> 1 file changed, 10 insertions(+), 9 deletions(-)
Fixed a booting hang on some Lenovo laptops.
Tested-by: Adam Lee
--
Adam Lee
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majo
On Tue, Nov 19, 2013 at 11:08:06AM -0700, Myron Stowe wrote:
> On Mon, Nov 18, 2013 at 10:57 PM, Adam Lee wrote:
> > On Mon, Nov 18, 2013 at 10:38:17AM -0700, Bjorn Helgaas wrote:
> >> [+cc Myron, Amos, Thomas, Ben]
> >>
> >> On Mon, Nov 18, 2013 at 2:40 AM
On Mon, Nov 18, 2013 at 10:38:17AM -0700, Bjorn Helgaas wrote:
> [+cc Myron, Amos, Thomas, Ben]
>
> On Mon, Nov 18, 2013 at 2:40 AM, Adam Lee wrote:
> > This patch adds the PCI_EXP_FLAGS_SLOT check back before setting
> > hotplug bridge, which is omitted by an
This patch adds the PCI_EXP_FLAGS_SLOT check back before setting
hotplug bridge, which is omitted by an API switching commit,
59875ae489609b2267548dc85160c5f0f0c6f9d4 "PCI/core: Use PCI Express
Capability accessors".
Some Lenovo laptops hang in booting without this fix.
Signed-off-by
f-by: peter.guo
> ---
> drivers/mmc/host/sdhci-pci.c | 208
> ++
> 1 file changed, 208 insertions(+)
I'm enabling "O2 Micro, Inc. Device [1217:8520]" on some laptops, it
works after this patch applied.
Chris, please take a loo
eaff000+cb000]
Signed-off-by: Adam Lee
---
drivers/bluetooth/btusb.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 7a7e5f8..23df968 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb
at 4 ip 7f8b2eb55236 sp
7fff53ff6920 error 4 in bluetoothd[7f8b2eaff000+cb000]
Signed-off-by: Adam Lee
---
drivers/bluetooth/btusb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 7a7e5f8..05a38a2 100644
---
On Tue, Jul 09, 2013 at 10:55:01AM +0800, Adam Lee wrote:
> On Mon, Jul 08, 2013 at 11:50:54AM -0700, Marcel Holtmann wrote:
> > Hi Adam,
> >
> > > PTR_ERR() returns a long type value, but btusb_setup_intel() and
> > > btusb_setup_intel_patching(
x86_64, you will see the bug.
PS, about other subsystems, I also think returning PTR_ERR() from a
function calls returning int considered harmful sometimes, will talk
about that in other thread.
Great thanks.
--
Regards,
Adam Lee
Hardware Enablement
#include
static inline long PTR_ERR(const v
On Fri, Jul 05, 2013 at 10:59:47AM +0800, Adam Lee wrote:
> On Fri, Jul 05, 2013 at 10:37:07AM +0800, Yang Bai wrote:
> > The return value of btusb_setup_intel is compared with 0. Code as:
> >
> > drivers/bluetooth/btusb.c:
> > static int btusb_probe(struct usb_interf
n value is compared with number
"0", doesn't break the judgement.
But it still overflows stack without this fix.
> On Thu, Jul 4, 2013 at 8:43 PM, Adam Lee wrote:
>
> PTR_ERR() returns a long type value, but btusb_setup_intel() and
> btusb_setup_intel_patching()
to modify the return values
but not extend btusb_setup_intel() and btusb_setup_intel_patching()'s
return types. This is harmless, because the return values were only
used to comparing number 0.
Signed-off-by: Adam Lee
---
drivers/bluetooth/btusb.c | 14 +++---
1 file changed, 7 insertio
On Thu, Apr 25, 2013 at 02:33:06PM +0800, Adam Lee wrote:
> On Wed, Apr 24, 2013 at 11:17:52AM +0200, Laurent Pinchart wrote:
> > Hi Adam,
> >
> > Thanks for the patch.
> >
> > On Wednesday 24 April 2013 15:57:19 adam@canonical.com wrote:
> > >
e LEDs",
I will drop [PATCH 3/3] to discussion again when I got the documentation.
--
Regards,
Adam Lee
Hardware Enablement
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Not all 0-15 LEDs are available for all models, sometimes it's even not
safe. This patch return -NODEV while operating uninitialized LEDs.
Signed-off-by: Adam Lee
---
drivers/platform/x86/thinkpad_acpi.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/dr
On Fri, Jun 07, 2013 at 01:22:39PM +, Matthew Garrett wrote:
> On Fri, 2013-06-07 at 16:20 +0800, Adam Lee wrote:
> > Some new Lenovo or ThinkPad laptops don't have EC controllable LEDs.
> > This patch adds their quirks.
>
> Can you detect this case? If this is a ne
Not all 0-15 LEDs are available for all models, sometimes it's even not
safe. This patch return -NODEV while operating uninitialized LEDs.
Signed-off-by: Adam Lee
---
drivers/platform/x86/thinkpad_acpi.c |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/pla
On Fri, Jun 07, 2013 at 10:53:50AM +0200, Bjørn Mork wrote:
> Adam Lee writes:
>
> > --- a/drivers/platform/x86/thinkpad_acpi.c
> > +++ b/drivers/platform/x86/thinkpad_acpi.c
> > @@ -5401,9 +5401,12 @@ static int led_write(char *buf)
> > return -ENO
Some new Lenovo or ThinkPad laptops don't have EC controllable LEDs,
they control LEDs by BIOS functions, and return ACPI Warning while
operating LEDs by EC.
These patches set some quirks, optimize led_init() and led_write() to
avoid that warning.
Adam Lee (3):
thinkpad_acpi: return -
Some new Lenovo or ThinkPad laptops don't have EC controllable LEDs,
their LED quirks are 0. This patch set led_supported=TPACPI_LED_NONE
when quirk equals 0.
Signed-off-by: Adam Lee
---
drivers/platform/x86/thinkpad_acpi.c | 13 ++---
1 file changed, 10 insertions(+), 3 dele
Not all 0-15 LEDs are available for all models, sometimes it's even not
safe. This patch return -NODEV while operating uninitialized LEDs.
Signed-off-by: Adam Lee
---
drivers/platform/x86/thinkpad_acpi.c |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/pla
Some new Lenovo or ThinkPad laptops don't have EC controllable LEDs.
This patch adds their quirks.
Signed-off-by: Adam Lee
---
drivers/platform/x86/thinkpad_acpi.c |6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platfor
On Tue, May 14, 2013 at 03:38:17PM +0800, Adam Lee wrote:
> On some systems we need a way to disable MMC card support in a MMC/SD
> card slot due to the legal concern.
>
> Add support in the core SD/MMC code to support this.
CC more addresses.
Yes, this capability seems odd, but li
On some systems we need a way to disable MMC card support in a MMC/SD
card slot due to the legal concern.
Add support in the core SD/MMC code to support this.
Signed-off-by: Doug Anderson
Signed-off-by: Alim Akhtar
Signed-off-by: Adam Lee
---
drivers/mmc/core/core.c |2 +-
include/linux
On Wed, Apr 24, 2013 at 11:17:52AM +0200, Laurent Pinchart wrote:
> Hi Adam,
>
> Thanks for the patch.
>
> On Wednesday 24 April 2013 15:57:19 adam@canonical.com wrote:
> > From: Adam Lee
> >
> > This reverts commit 3dae8b41dc5651f8eb22cf310e8b116480ba25b7
From: Adam Lee
This reverts commit 3dae8b41dc5651f8eb22cf310e8b116480ba25b7.
1, I do have a Chicony webcam, implements autosuspend in a broken way,
make `poweroff` performs rebooting when its autosuspend enabled.
2, There are other webcams which don't support autosuspend too, like
ig to olddefconfig without adding oldnoconfig as a backup.
> The make oldnoconfig works much better than its backup of:
>yes '' | make oldconfig
>
> But due to this change, and the fact that ktest is used to build lots of
> older kernels (and for bisects), it forgoes the old
le is not necessary, I made it a empty target, so its
last-modification time will be checked by Make only when it exists.
Signed-off-by: Adam Lee
---
scripts/package/Makefile |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/scripts/package/Makefile b/scripts/pa
On Sat, Sep 01, 2012 at 01:05:17AM +0800, Adam Lee wrote:
> As 67d34a6a391369269a2e5dba8a5f42cc4cd50231 said, 'oldnoconfig' doesn't
> set new symbols to 'n', but instead sets it to their default values.
>
> So, this patch replaces 'oldnoconfig' wit
ame 'oldnoconfig' as an alias,
because people already are dependent on its behavior with the
counter-intuitive name.
v3: use a better way an add comments about alias in conf.c
Signed-off-by: Adam Lee
---
scripts/kconfig/Makefile | 12 +---
scripts/kconfig/conf.c | 25 +
ame 'oldnoconfig' as an alias,
because people already are dependent on its behavior with the
counter-intuitive name.
Signed-off-by: Adam Lee
---
scripts/kconfig/Makefile | 12 +---
scripts/kconfig/conf.c | 12 ++--
tools/testing/ktest/ktest.pl | 15 +++--
On Thu, Aug 23, 2012 at 04:10:01PM -0400, Steven Rostedt wrote:
> Sorry for the late reply.
>
> On Fri, 2012-08-17 at 15:16 +0800, Adam Lee wrote:
> > As 67d34a6a391369269a2e5dba8a5f42cc4cd50231 said, 'oldnoconfig' doesn't
> > set new symbols to 'n'
On Fri, Aug 17, 2012 at 02:57:28PM +0800, Adam Lee wrote:
> As 67d34a6a391369269a2e5dba8a5f42cc4cd50231 said, the make target
> 'oldnoconfig' is a misnomer. It doesn't set new symbols to 'n', but
> instead sets it to their default values.
>
> This patc
or during invocation of make when ARCH set to
s390x, ppc64 or some machine hardware name else. Lots of scripts will
have no need to hack(like what we did in Red Hat), just use `uname -m`.
Signed-off-by: Adam Lee
---
Makefile | 37 -
1 file changed, 8 inserti
onf.c fixed in another mail, "[PATCH] [Signed-off]
kconfig: document oldnoconfig to what it really does in conf.c"
Signed-off-by: Adam Lee
---
scripts/kconfig/Makefile | 6 +++---
scripts/kconfig/conf.c | 18 +-
tools/testing/ktest/ktest.pl | 15 +++--
fig' to 'olddefconfig'
Signed-off-by: Adam Lee
---
scripts/kconfig/conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
index 0dc4a2c..6875680 100644
--- a/scripts/kconfig/conf.c
+++ b/scripts/kconfig/conf.c
@@
As 67d34a6a391369269a2e5dba8a5f42cc4cd50231 said, the make target
'oldnoconfig' is a misnomer. It doesn't set new symbols to 'n', but
instead sets it to their default values.
This patch fixes the document in conf.c, and will submit another patch
to replace 'oldnoconfig' to 'olddefconfig'
---
scri
38 matches
Mail list logo
