Re: [PATCH v3 0/3] PCI: endpoint: fix bug for 2 APIs and simplify 1 API

2024-12-12 Thread Zijun Hu
On 2024/12/12 17:35, Dan Carpenter wrote: > On Tue, Dec 10, 2024 at 10:00:17PM +0800, Zijun Hu wrote: >> This patch series is to fix bug for APIs >> - devm_pci_epc_destroy(). >> - pci_epf_remove_vepf(). >> >> and simplify APIs below: >> - pci_e

[PATCH v1] Bluetooth: btusb: add shutdown function for wcn6855

2020-12-18 Thread Zijun Hu
From: Tim Jiang we should send hci reset command before bt turn off, which can reset bt firmware status. Signed-off-by: Tim Jiang --- drivers/bluetooth/btusb.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 03b83

[PATCH v1] Bluetooth: btusb: support download nvm with different board id for wcn6855

2020-12-02 Thread Zijun Hu
From: Tim Jiang we define many nvm files for wcn6855 btsoc and host driver should find the correct nvm file based on board ID and then download it. Signed-off-by: Tim Jiang --- drivers/bluetooth/btusb.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/dr

[PATCH v1] Bluetooth: support download nvm with different board id for wcn6855

2020-11-30 Thread Zijun Hu
From: Tim Jiang we define many nvm files for wcn6855 btsoc and host driver should find the correct nvm file based on board ID and then download it. Signed-off-by: Tim Jiang --- drivers/bluetooth/btusb.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/driv

Re: [PATCH v1] sched/cfs: Fix pick_next_entity() implementation error

2020-07-01 Thread Zijun Hu
thanks for your explanation. you are right. @lest should be used as reference point to compare. Please ignore this patch. On 7/1/2020 6:47 PM, Vincent Guittot wrote: > On Wed, 1 Jul 2020 at 12:07, Zijun Hu wrote: >> >> sched_entity @se not static @left should be compared >&g

[PATCH v1] sched/cfs: Fix pick_next_entity() implementation error

2020-07-01 Thread Zijun Hu
sched_entity @se not static @left should be compared to pick up @cfs_rq->next. Signed-off-by: Zijun Hu --- kernel/sched/fair.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 658aa7a2ae6f..4790f2d851ad 100644 --- a/ker

[PATCH v1] Bluetooth: btmtkuart: Use serdev_device_write_buf() instead of serdev_device_write()

2020-05-29 Thread Zijun Hu
serdev_device_write() is not appropriate at here because serdev_device_write_wakeup() is not used to release completion hold by the former at @write_wakeup member of struct serdev_device_ops. Fix by using serdev_device_write_buf() instead of serdev_device_write(). Signed-off-by: Zijun Hu

[PATCH v4] Bluetooth: hci_qca: Improve controller ID info log level

2020-05-29 Thread Zijun Hu
Controller ID info got by VSC EDL_PATCH_GETVER is very important, so improve its log level from DEBUG to INFO. Signed-off-by: Zijun Hu --- Changes in v4: - correct coding style of qca_read_soc_version() Changes in v3: - correct coding style Changes in v2: - adjust controller ID info print

[PATCH v5] bluetooth: hci_qca: Fix QCA6390 memdump failure

2020-05-29 Thread Zijun Hu
01 08 78 05 00 ca f7 41 it is mistook for controller missing packets, so results in page fault after overwriting memdump buffer allocated. Fixed by ignoring QCA6390 sequence number check and checking buffer space before writing. Signed-off-by: Zijun Hu Tested-by: Zijun Hu --- Changes in v5

Re: [PATCH v1] Bluetooth: hci_qca: Fix qca6390 enable failure after warm reboot

2020-05-29 Thread Zijun Hu
On 5/29/2020 7:45 PM, Marcel Holtmann wrote: > Hi Zijun, > >> On May 29, 2020, at 04:29, Zijun Hu wrote: >> >> Warm reboot can not reset controller qca6390 due to >> lack of controllable power supply, so causes firmware >> download failure durin

[PATCH v2] Bluetooth: hci_qca: Fix qca6390 enable failure after warm reboot

2020-05-29 Thread Zijun Hu
Warm reboot can not reset controller qca6390 due to lack of controllable power supply, so causes firmware download failure during enable. Fixed by sending VSC EDL_SOC_RESET to reset qca6390 within added device shutdown implementation. Signed-off-by: Zijun Hu Tested-by: Zijun Hu --- Changes in

[PATCH v4] bluetooth: hci_qca: Fix QCA6390 memdump failure

2020-05-28 Thread Zijun Hu
01 08 78 05 00 ca f7 41 it is mistook for controller missing packets, so results in page fault after overwriting memdump buffer allocated. Fixed by ignoring QCA6390 sequence number check and checking buffer space before writing. Signed-off-by: Zijun Hu Tested-by: Zijun Hu --- Changes in v4

[PATCH v1] Bluetooth: hci_qca: Fix qca6390 enable failure after warm reboot

2020-05-28 Thread Zijun Hu
Warm reboot can not reset controller qca6390 due to lack of controllable power supply, so causes firmware download failure during enable. Fixed by sending VSC EDL_SOC_RESET to reset qca6390 within added device shutdown implementation. Signed-off-by: Zijun Hu Tested-by: Zijun Hu --- drivers

Re: [PATCH v2] bluetooth: hci_qca: Fix QCA6390 memdump failure

2020-05-28 Thread Zijun Hu
On 5/29/2020 2:26 AM, Abhishek Pandit-Subedi wrote: > Hi, > > On Wed, May 27, 2020 at 11:19 PM Zijun Hu wrote: >> >> >> >> On 5/28/2020 11:42 AM, Abhishek Pandit-Subedi wrote: >>> Hi Zijun, >>> >>> On Tue, May 26, 2020 at 8:37 PM Z

[PATCH v2] bluetooth: hci_qca: Fix suspend/resume functionality failure

2020-05-28 Thread Zijun Hu
@dev parameter of qca_suspend()/qca_resume() represents serdev_device, but it is mistook for hci_dev and causes succedent unexpected memory access. Fix by taking @dev as serdev_device. Fixes: 41d5b25fed0 ("Bluetooth: hci_qca: add PM support") Signed-off-by: Zijun Hu --- Changes in v2

Re: [PATCH v3] Bluetooth: hci_qca: Improve controller ID info log level

2020-05-28 Thread Zijun Hu
On 5/28/2020 11:17 PM, Matthias Kaehlcke wrote: > On Thu, May 28, 2020 at 07:03:17PM +0800, Zijun Hu wrote: >> Controller ID info got by VSC EDL_PATCH_GETVER is very >> important, so improve its log level from DEBUG to INFO. >> >> Signed-off-by: Zijun Hu > >

Re: [PATCH v3] bluetooth: hci_qca: Fix qca6390 enable failure after warm reboot

2020-05-28 Thread Zijun Hu
On 5/28/2020 11:44 PM, Matthias Kaehlcke wrote: > On Thu, May 28, 2020 at 01:04:25PM +0800, Zijun Hu wrote: >> >> >> On 5/28/2020 12:48 AM, Matthias Kaehlcke wrote: >>> Hi Zijun, >>> >>> On Wed, May 27, 2020 at 10:32:39AM +0800, Zijun Hu

[PATCH v3] bluetooth: hci_qca: Fix QCA6390 memdump failure

2020-05-28 Thread Zijun Hu
01 08 78 05 00 ca f7 41 it is mistook for controller missing packets, so results in page fault after overwriting memdump buffer allocated. it is fixed by ignoring QCA6390 sequence number error and checking buffer space before writing. Signed-off-by: Zijun Hu --- drivers/bluetooth/hci_qca.c | 45

[PATCH v5] bluetooth: hci_qca: Fix qca6390 enable failure after warm reboot

2020-05-28 Thread Zijun Hu
Warm reboot can not restore qca6390 controller baudrate to default due to lack of controllable BT_EN pin or power supply, so fails to download firmware after warm reboot. Fixed by sending EDL_SOC_RESET VSC to reset controller within added device shutdown implementation. Signed-off-by: Zijun Hu

[PATCH v3] Bluetooth: hci_qca: Improve controller ID info log level

2020-05-28 Thread Zijun Hu
Controller ID info got by VSC EDL_PATCH_GETVER is very important, so improve its log level from DEBUG to INFO. Signed-off-by: Zijun Hu --- drivers/bluetooth/btqca.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth

[PATCH v1] bluetooth: hci_qca: Fix suspend/resume functionality failure

2020-05-28 Thread Zijun Hu
@dev parameter of qca_suspend()/qca_resume() represents serdev_device, but it is mistook for hci_dev and causes succedent unexpected memory access. Fix by taking @dev as serdev_device. Signed-off-by: Zijun Hu --- drivers/bluetooth/hci_qca.c | 12 1 file changed, 8 insertions(+), 4

Re: [PATCH v2] Bluetooth: hci_qca: Improve controller ID info log level

2020-05-28 Thread Zijun Hu
On 5/28/2020 4:16 PM, Marcel Holtmann wrote: > Hi Zijun, > >> Controller ID info got by VSC EDL_PATCH_GETVER is very >> important, so improve its log level from DEBUG to INFO. >> >> Signed-off-by: Zijun Hu >> --- >> drivers/bluetooth/btqca.c | 12 ++

Re: [PATCH v4] bluetooth: hci_qca: Fix qca6390 enable failure after warm reboot

2020-05-28 Thread Zijun Hu
y sending EDL_SOC_RESET VSC to reset controller >> within added device shutdown implementation. >> >> Signed-off-by: Zijun Hu >> --- >> drivers/bluetooth/hci_qca.c | 33 + >> 1 file changed, 33 insertions(+) >> >> diff --git a

Re: [PATCH v2] bluetooth: hci_qca: Fix QCA6390 memdump failure

2020-05-27 Thread Zijun Hu
On 5/28/2020 11:42 AM, Abhishek Pandit-Subedi wrote: > Hi Zijun, > > On Tue, May 26, 2020 at 8:37 PM Zijun Hu wrote: >> >> QCA6390 memdump VSE sometimes come to bluetooth driver >> with wrong sequence number as illustrated as follows: >> frame # in DEC: frame

[PATCH v4] bluetooth: hci_qca: Fix qca6390 enable failure after warm reboot

2020-05-27 Thread Zijun Hu
Warm reboot can not restore qca6390 controller baudrate to default due to lack of controllable BT_EN pin or power supply, so fails to download firmware after warm reboot. Fixed by sending EDL_SOC_RESET VSC to reset controller within added device shutdown implementation. Signed-off-by: Zijun Hu

Re: [PATCH v3] bluetooth: hci_qca: Fix qca6390 enable failure after warm reboot

2020-05-27 Thread Zijun Hu
On 5/28/2020 12:48 AM, Matthias Kaehlcke wrote: > Hi Zijun, > > On Wed, May 27, 2020 at 10:32:39AM +0800, Zijun Hu wrote: >> Warm reboot can not restore qca6390 controller baudrate >> to default due to lack of controllable BT_EN pin or power >> supply, so fails to d

[PATCH v2] bluetooth: hci_qca: Fix QCA6390 memdump failure

2020-05-26 Thread Zijun Hu
01 08 78 05 00 ca f7 41 it is mistook for controller missing packets, so results in page fault after overwriting memdump buffer allocated. it is fixed by ignoring QCA6390 sequence number error and checking buffer space before writing. Signed-off-by: Zijun Hu --- drivers/bluetooth/hci_qca.c | 45

[PATCH v2] Bluetooth: hci_qca: Improve controller ID info log level

2020-05-26 Thread Zijun Hu
Controller ID info got by VSC EDL_PATCH_GETVER is very important, so improve its log level from DEBUG to INFO. Signed-off-by: Zijun Hu --- drivers/bluetooth/btqca.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth

[PATCH v3] bluetooth: hci_qca: Fix qca6390 enable failure after warm reboot

2020-05-26 Thread Zijun Hu
Warm reboot can not restore qca6390 controller baudrate to default due to lack of controllable BT_EN pin or power supply, so fails to download firmware after warm reboot. Fixed by sending EDL_SOC_RESET VSC to reset controller within added device shutdown implementation. Signed-off-by: Zijun Hu

[PATCH v1] bluetooth: hci_qca: Fix QCA6390 memdump failure

2020-05-26 Thread Zijun Hu
01 08 78 05 00 ca f7 41 it is mistook for controller missing packets, so results in page fault after overwriting memdump buffer allocated. it is fixed by ignoring QCA6390 sequence number error and checking buffer space before writing. Signed-off-by: Zijun Hu --- drivers/bluetooth/hci_qca.c | 45

[PATCH v1] Bluetooth: hci_qca: Improve controller ID info log level

2020-05-25 Thread Zijun Hu
Controller ID info got by VSC EDL_PATCH_GETVER is very important, so improve its log level from DEBUG to INFO. Signed-off-by: Zijun Hu --- drivers/bluetooth/btqca.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c

[PATCH v2] bluetooth: hci_qca: Fix qca6390 enable failure after warm reboot

2020-05-25 Thread Zijun Hu
Warm reboot can not restore qca6390 controller baudrate to default due to lack of controllable BT_EN pin or power supply, so fails to download firmware after warm reboot. Fixed by sending EDL_SOC_RESET VSC to reset controller within added device shutdown implementation. Signed-off-by: Zijun Hu

[PATCH v1] bluetooth: hci_qca: Fix qca6390 enable failure after warm reboot

2020-05-25 Thread Zijun Hu
Warm reboot can not restore qca6390 controller baudrate to default due to lack of controllable BT_EN pin or power supply, so fails to download firmware after warm reboot. Fixed by sending EDL_SOC_RESET VSC to reset controller within added device shutdown implementation. Signed-off-by: Zijun Hu