This patch provides chip-specific support for Crystal Cove. Crystal
Cove is the PMIC in Baytrail-T platform.
Also adds Intel SoC PMIC support to the build files.
Signed-off-by: Yang, Bin
Signed-off-by: Zhu, Lejun
---
v2:
- Add regmap_config for Crystal Cove.
v3:
- Convert IRQ config to
:
- Add comment to describe what is done in _find_gpio_irq().
- Remove i2c id. Only keep ACPI id and match it in _probe().
- Further fix of coding style issues.
- Add the GPIO patch, to merge it along with the MFD changes.
Zhu, Lejun (3):
mfd: intel_soc_pmic: Core driver
mfd: intel_soc_pmic: Crystal
This patch provides the common I2C driver code for Intel SoC PMICs.
Signed-off-by: Yang, Bin
Signed-off-by: Zhu, Lejun
---
v2:
- Use regmap instead of creating our own I2C read/write callbacks.
- Add one missing EXPORT_SYMBOL.
- Remove duplicate code and put them into pmic_regmap_load_from_hw
-off-by: Yang, Bin
Signed-off-by: Zhu, Lejun
Reviewed-by: Mika Westerberg
Reviewed-by: Alexandre Courbot
Reviewed-by: Linus Walleij
---
v5:
- Fix the order of doing gpiochip_add() and gpiochip_irqchip_add().
- Add it to this patch set, to merge it along with the MFD changes.
---
drivers/gpio
On 2014/5/30 17:28, Lee Jones wrote:
>> +static const struct i2c_device_id intel_soc_pmic_i2c_id[] = {
>> +{"INT33FD:00", (kernel_ulong_t)&intel_soc_pmic_config_crc},
>> +{ }
>> +};
>> +MODULE_DEVICE_TABLE(i2c, intel_soc_pmic_i2c_id);
>> +
>> +static st
On 2014/5/30 16:08, Lee Jones wrote:
+static int intel_soc_pmic_find_gpio_irq(struct device *dev)
+{
+ struct gpio_desc *desc;
+ int irq;
+
+ desc = devm_gpiod_get_index(dev, KBUILD_MODNAME, 0);
>>>
>>> What does "KBUILD_MODNAME" translate to?
>>
>> It translates
On 5/29/2014 7:40 PM, Lee Jones wrote:
> [...]
>
>> +static int intel_soc_pmic_find_gpio_irq(struct device *dev)
>> +{
>> +struct gpio_desc *desc;
>> +int irq;
>> +
>> +desc = devm_gpiod_get_index(dev, KBUILD_MODNAME, 0);
>
> What does "KBUILD_MODNAME" translate to?
It translates i
On 5/29/2014 7:49 PM, Lee Jones wrote:
> On Thu, 29 May 2014, Zhu, Lejun wrote:
>
>> This patch provides chip-specific support for Crystal Cove. Crystal
>> Cove is the PMIC in Baytrail-T platform.
(...)
>> +enum crystal_cove_irq {
>> +PWRSRC_IRQ = 0,
>
On 5/29/2014 7:43 PM, Lee Jones wrote:
>> This patch adds Intel SoC PMIC support to the build files.
> These changes shouldn't really be in a separate patch.
I'll move them into the first (core.c) patch.
Best Regards
Lejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kern
On 5/29/2014 9:51 PM, Linus Walleij wrote:
> On Thu, May 29, 2014 at 9:21 AM, Zhu, Lejun wrote:
>
>> Devices based on Intel SoC products such as Baytrail have a Power
>> Management IC. In the PMIC there are subsystems for voltage regulation,
>> A/D conversion, GP
On 5/29/2014 9:37 PM, Linus Walleij wrote:
> On Tue, May 27, 2014 at 2:04 PM, Grygorii Strashko
> wrote:
>> On 05/27/2014 11:46 AM, Mika Westerberg wrote:
(...)
>
> My idea is that you should call gpiochip_add() *first* and then
> add the IRQs to the chip. In succession.
>
> Rationale: with dy
-off-by: Yang, Bin
Signed-off-by: Zhu, Lejun
---
v2:
- Use IRQ chip helper to provide irqdomain.
- Implement .remove and can now build as a module.
- Various fix for unreadable or ugly code pieces.
v3:
- More fix in irq_handler and probe.
v4:
- Minor fix of one return statement.
v5
This patch provides the common I2C driver code for Intel SoC PMICs.
Signed-off-by: Yang, Bin
Signed-off-by: Zhu, Lejun
---
v2:
- Use regmap instead of creating our own I2C read/write callbacks.
- Add one missing EXPORT_SYMBOL.
- Remove duplicate code and put them into pmic_regmap_load_from_hw
This patch provides chip-specific support for Crystal Cove. Crystal
Cove is the PMIC in Baytrail-T platform.
Signed-off-by: Yang, Bin
Signed-off-by: Zhu, Lejun
---
v2:
- Add regmap_config for Crystal Cove.
v3:
- Convert IRQ config to regmap_irq_chip.
v4:
- Cleanup include files.
- Remove
This patch adds Intel SoC PMIC support to the build files.
Signed-off-by: Yang, Bin
Signed-off-by: Zhu, Lejun
---
v2:
- Add select REGMAP_I2C.
v3:
- Add select REGMAP_IRQ.
v4:
- No change.
---
drivers/mfd/Kconfig | 12
drivers/mfd/Makefile | 3 +++
2 files changed, 15 insertions
cleanup.
v4:
- Remove all exported APIs which are wrappers of regmap API, export
the regmap in data structure instead.
- Combine intel_soc_pmic_core.c and intel_soc_pmic_i2c.c
- Clean up include files.
- Remove useless members of struct intel_soc_pmic_config.
- Fix various coding style issues.
Zhu
On 5/27/2014 11:35 PM, Lee Jones wrote:
>> This patch provides the common code for the intel_soc_pmic MFD driver, such
>> as read/write register and set up IRQ.
(...)
>> +/*
>> +* Set and clear multiple bits of a PMIC register
>> +*/
>> +int intel_soc_pmic_update(int reg, u8 val, u8 mask)
>> +{
On 5/27/2014 7:20 PM, Mark Brown wrote:
> On Tue, May 27, 2014 at 08:48:58AM +0800, Zhu, Lejun wrote:
>> On 5/26/2014 10:51 PM, Mark Brown wrote:
>
>>>> We created these names to hide the implementation of how read/write is
>>>> done from other platform sp
On 5/27/2014 5:11 PM, Linus Walleij wrote:
> On Wed, May 21, 2014 at 7:22 AM, Zhu, Lejun wrote:
>
>> Devices based on Intel SoC products such as Baytrail have a Power
>> Management IC. In the PMIC there are subsystems for voltage regulation,
>> A/D conversion, GP
On 5/27/2014 5:24 PM, Grygorii Strashko wrote:
> Hi Lejun,
>
> On 05/27/2014 08:38 AM, Alexandre Courbot wrote:
>> On Fri, May 23, 2014 at 11:00 AM, Zhu, Lejun
>> wrote:
>>> +static int crystalcove_gpio_probe(struct platform_device *pdev)
>>> +{
>>
On 5/27/2014 1:38 PM, Alexandre Courbot wrote:
> On Fri, May 23, 2014 at 11:00 AM, Zhu, Lejun
> wrote:
>> +static void crystalcove_update_irq_type(int gpio, int type)
>> +{
>> + u8 ctli = GPIO_TO_CTL(gpio, I);
>> +
>> + type &= IRQ_TYPE_EDG
Devices based on Intel SoC products such as Baytrail have a Power Management
IC. This patch adds Intel SoC PMIC support to the build files.
v2:
- Add select REGMAP_I2C.
v3:
- Add select REGMAP_IRQ.
Signed-off-by: Yang, Bin
Signed-off-by: Zhu, Lejun
---
drivers/mfd/Kconfig | 12
Crystal Cove is the PMIC in Baytrail-T platform. This patch provides
chip-specific support for Crystal Cove.
v2:
- Add regmap_config for Crystal Cove.
v3:
- Convert IRQ config to regmap_irq_chip.
Signed-off-by: Yang, Bin
Signed-off-by: Zhu, Lejun
---
drivers/mfd/intel_soc_pmic_crc.c | 175
managed allocations.
Signed-off-by: Yang, Bin
Signed-off-by: Zhu, Lejun
---
drivers/mfd/intel_soc_pmic_i2c.c | 150 +++
1 file changed, 150 insertions(+)
create mode 100644 drivers/mfd/intel_soc_pmic_i2c.c
diff --git a/drivers/mfd/intel_soc_pmic_i2c.c b/drivers
cleanup.
Zhu, Lejun (4):
mfd: intel_soc_pmic: Core driver
mfd: intel_soc_pmic: I2C interface
mfd: intel_soc_pmic: Crystal Cove support
mfd: intel_soc_pmic: Build files
drivers/mfd/Kconfig| 12 +++
drivers/mfd/Makefile | 3 +
drivers/mfd/intel_soc_pmic_core.c
regmap-irq. Remove our own pmic_regmap_* and IRQ handling code.
- Remove intel_soc_pmic_dev() because gpio driver no longer uses it.
- Remove intel_soc_pmic_set_pdata() because currently it's not used.
- Use EXPORT_SYMBOL_GPL for exposed APIs.
Signed-off-by: Yang, Bin
Signed-off-by: Zhu,
On 5/26/2014 10:51 PM, Mark Brown wrote:
> On Mon, May 26, 2014 at 02:01:11PM +0800, Zhu, Lejun wrote:
>> On 5/24/2014 1:49 AM, Mark Brown wrote:
>
>>> There should also be no need to add extra locking around regmap calls,
>>> the regmap API has locking as st
On 5/24/2014 1:53 AM, Mark Brown wrote:
> On Fri, May 23, 2014 at 08:40:27AM +0800, Zhu, Lejun wrote:
>
>> +static int pmic_i2c_lookup_gpio(struct device *dev, int acpi_index)
>> +{
>> +struct gpio_desc *desc;
>> +int gpio;
>> +
>> +
On 5/24/2014 1:49 AM, Mark Brown wrote:
> On Fri, May 23, 2014 at 08:40:26AM +0800, Zhu, Lejun wrote:
>
>> +struct device *intel_soc_pmic_dev(void)
>> +{
>> +return pmic->dev;
>> +}
>> +EXPORT_SYMBOL(intel_soc_pmic_dev);
>
> Why do you need to
On 5/23/2014 6:08 PM, Lee Jones wrote:
>
> Why are you re-sending this?
>
Hi,
My mail server reported that it failed to send [PATCH v2 1/4] to LKML,
so I resent the whole series, only to get it properly archived.
Sorry for the confusion.
Best Regards
Lejun
--
To unsubscribe from this list: se
:
- Use IRQ chip helper to provide irqdomain.
- Implement .remove and can now build as a module.
- Various fix for unreadable or ugly code pieces.
v3:
- More fix in irq_handler and probe.
v4:
- Minor fix of one return statement.
Signed-off-by: Yang, Bin
Signed-off-by: Zhu, Lejun
Reviewed-by: Mika
On 5/22/2014 7:15 PM, Mika Westerberg wrote:
> I suppose this is dependent on the MFD driver right? If so, this should
> probably be merged along with that patch.
>
The MFD driver has been submitted on LKML as well. I think these two
drivers can be pulled into corresponding trees, and meet each
: Yang, Bin
Signed-off-by: Zhu, Lejun
---
drivers/mfd/intel_soc_pmic_core.c | 521 +
drivers/mfd/intel_soc_pmic_core.h | 83 ++
include/linux/mfd/intel_soc_pmic.h | 29 +++
3 files changed, 633 insertions(+)
create mode 100644 drivers/mfd
Crystal Cove is the PMIC in Baytrail-T platform. This patch provides
chip-specific support for Crystal Cove.
v2:
- Add regmap_config for Crystal Cove.
Signed-off-by: Yang, Bin
Signed-off-by: Zhu, Lejun
---
drivers/mfd/intel_soc_pmic_crc.c | 165 +++
1 file
The Intel SoC PMIC devices are connected to the CPU via the I2C
interface. This patch provides support of the related I2C operations.
v2:
- Use regmap instead of creating our own I2C read/write callbacks.
Signed-off-by: Yang, Bin
Signed-off-by: Zhu, Lejun
---
drivers/mfd/intel_soc_pmic_i2c.c
support for Crystal Cove.
v2:
- Use regmap instead of creating our own I2C read/write callbacks.
- Add one missing EXPORT_SYMBOL.
- Remove some duplicate code and put them into pmic_regmap_load_from_hw.
Zhu, Lejun (4):
mfd: intel_soc_pmic: Core driver
mfd: intel_soc_pmic: I2C interface
mfd
Devices based on Intel SoC products such as Baytrail have a Power
Management IC. This patch adds Intel SoC PMIC support to the build files.
v2:
- Add select REGMAP_I2C.
Signed-off-by: Yang, Bin
Signed-off-by: Zhu, Lejun
---
drivers/mfd/Kconfig | 11 +++
drivers/mfd/Makefile | 3
Crystal Cove is the PMIC in Baytrail-T platform. This patch provides
chip-specific support for Crystal Cove.
v2:
- Add regmap_config for Crystal Cove.
Signed-off-by: Yang, Bin
Signed-off-by: Zhu, Lejun
---
drivers/mfd/intel_soc_pmic_crc.c | 165 +++
1 file
The Intel SoC PMIC devices are connected to the CPU via the I2C
interface. This patch provides support of the related I2C operations.
v2:
- Use regmap instead of creating our own I2C read/write callbacks.
Signed-off-by: Yang, Bin
Signed-off-by: Zhu, Lejun
---
drivers/mfd/intel_soc_pmic_i2c.c
Devices based on Intel SoC products such as Baytrail have a Power
Management IC. This patch adds Intel SoC PMIC support to the build files.
v2:
- Add select REGMAP_I2C.
Signed-off-by: Yang, Bin
Signed-off-by: Zhu, Lejun
---
drivers/mfd/Kconfig | 11 +++
drivers/mfd/Makefile | 3
support for Crystal Cove.
v2:
- Use regmap instead of creating our own I2C read/write callbacks.
- Add one missing EXPORT_SYMBOL.
- Remove some duplicate code and put them into pmic_regmap_load_from_hw.
Zhu, Lejun (4):
mfd: intel_soc_pmic: Core driver
mfd: intel_soc_pmic: I2C interface
mfd
:
- Use IRQ chip helper to provide irqdomain.
- Implement .remove and can now build as a module.
- Various fix for unreadable or ugly code pieces.
v3:
- More fix in irq_handler and probe.
Signed-off-by: Yang, Bin
Signed-off-by: Zhu, Lejun
---
drivers/gpio/Kconfig| 13 ++
drivers/gpio
:
- Use IRQ chip helper to provide irqdomain.
- Implement .remove and can now build as a module.
- Various fix for unreadable or ugly code pieces.
Signed-off-by: Yang, Bin
Signed-off-by: Zhu, Lejun
---
drivers/gpio/Kconfig| 13 ++
drivers/gpio/Makefile | 1 +
drivers/gpio/gpio
Devices based on Intel SoC products such as Baytrail have a Power
Management IC. This patch adds Intel SoC PMIC support to the build files.
Signed-off-by: Yang, Bin
Signed-off-by: Zhu, Lejun
---
drivers/mfd/Kconfig | 10 ++
drivers/mfd/Makefile | 3 +++
2 files changed, 13 insertions
On 5/20/2014 10:58 PM, Lee Jones wrote:
>> This patch provides the common code for the intel_soc_pmic MFD driver,
>> such as read/write register and set up IRQ.
>>
>> Signed-off-by: Yang, Bin
>> Signed-off-by: Zhu, Lejun
>> ---
>>
On 5/20/2014 10:55 PM, Lee Jones wrote:
> On Wed, 14 May 2014, Zhu, Lejun wrote:
>
>> Devices based on Intel SoC products such as Baytrail have a Power
>> Management IC. In the PMIC there are subsystems for voltage regulation,
>> A/D conversion, GPIO and PWMs. The PMIC i
On 5/19/2014 10:13 PM, Mathias Nyman wrote:
> On 05/19/2014 03:27 AM, Zhu, Lejun wrote:
>>
>>
>> On 5/17/2014 1:33 AM, Linus Walleij wrote:
>>> On Wed, May 14, 2014 at 5:44 PM, Zhu, Lejun
>>> wrote:
>>>
>>>> Devices based on Intel S
On 5/20/2014 4:30 PM, Mika Westerberg wrote:
> On Mon, May 19, 2014 at 01:39:33PM +0300, Mika Westerberg wrote:
>> On Wed, May 14, 2014 at 11:44:07PM +0800, Zhu, Lejun wrote:
>>> Devices based on Intel SoC products such as Baytrail have a Power
>>> Management IC. In th
On 5/17/2014 1:46 AM, Daniel Glöckner wrote:
> Hi Lejun,
>
> On Wed, May 14, 2014 at 11:44:07PM +0800, Zhu, Lejun wrote:
>> This patch adds support for the GPIO function in Crystal Cove.
>
> in our device ACPI makes use of "virtual" GPIOs that have numbers from
&
On 5/17/2014 10:37 PM, Alexandre Courbot wrote:
> On Thu, May 15, 2014 at 12:44 AM, Zhu, Lejun
> wrote:
>> Devices based on Intel SoC products such as Baytrail have a Power
>> Management IC. In the PMIC there are subsystems for voltage regulation,
>> A/D conversion, GP
On 5/17/2014 1:33 AM, Linus Walleij wrote:
> On Wed, May 14, 2014 at 5:44 PM, Zhu, Lejun wrote:
>
>> Devices based on Intel SoC products such as Baytrail have a Power
>> Management IC. In the PMIC there are subsystems for voltage regulation,
>> A/D conversion, GP
-off-by: Yang, Bin
Signed-off-by: Zhu, Lejun
---
drivers/gpio/Kconfig| 9 ++
drivers/gpio/Makefile | 1 +
drivers/gpio/gpio-crystalcove.c | 323
3 files changed, 333 insertions(+)
create mode 100644 drivers/gpio/gpio-crystalcove.c
Devices based on Intel SoC products such as Baytrail have a Power
Management IC. This patch adds Intel SoC PMIC support to the build files.
Signed-off-by: Yang, Bin
Signed-off-by: Zhu, Lejun
---
drivers/mfd/Kconfig | 10 ++
drivers/mfd/Makefile | 3 +++
2 files changed, 13 insertions
Devices based on Intel SoC products such as Baytrail have a Power
Management IC. In the PMIC there are subsystems for voltage regulation,
A/D conversion, GPIO and PWMs. The PMIC in Baytrail-T platform is called
Crystal Cove.
This series contains common code for these PMICs, and device specific
sup
Crystal Cove is the PMIC in Baytrail-T platform. This patch provides
chip-specific support for Crystal Cove.
Signed-off-by: Yang, Bin
Signed-off-by: Zhu, Lejun
---
drivers/mfd/intel_soc_pmic_crc.c | 157 +++
1 file changed, 157 insertions(+)
create mode
This patch provides the common code for the intel_soc_pmic MFD driver,
such as read/write register and set up IRQ.
Signed-off-by: Yang, Bin
Signed-off-by: Zhu, Lejun
---
drivers/mfd/intel_soc_pmic_core.c | 543 +
drivers/mfd/intel_soc_pmic_core.h | 83
The Intel SoC PMIC devices are connected to the CPU via the I2C
interface. This patch provides support of the related I2C operations.
Signed-off-by: Yang, Bin
Signed-off-by: Zhu, Lejun
---
drivers/mfd/intel_soc_pmic_i2c.c | 158 +++
1 file changed, 158
When the system has zero or one button available, trying to rmmod
soc_button_array will cause crash. Fix this by properly handling -ENODEV
in probe().
Signed-off-by: Lejun Zhu
---
drivers/input/misc/soc_button_array.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/misc/soc_but
Hi Dmitry,
On 3/29/2014 4:47 AM, Dmitry Torokhov wrote:
> Hi Lejun,
>
> On Fri, Mar 28, 2014 at 02:02:43AM +0800, Zhu, Lejun wrote:
>> +
>> +static struct soc_button_info soc_button_tbl[] = {
>> +{"power", 0, KEY_POWER, 0, 1, -1},
>> +{"ho
This patch adds support for the GPIO buttons on some Intel Bay Trail
tablets originally running Windows 8. The ACPI description of these
buttons follows "Windows ACPI Design Guide for SoC Platforms".
v2:
- Change the driver name to "SoC button array".
- Use platform_device_alloc() instead of static
On 3/27/2014 4:20 AM, Dmitry Torokhov wrote:
> On Wed, Mar 26, 2014 at 05:04:04PM +, One Thousand Gnomes wrote:
>> On Wed, 26 Mar 2014 13:01:36 +0800
>> "Zhu, Lejun" wrote:
>>
>>> This patch adds support for the GPIO buttons on some Intel Bay Trail
This patch adds support for the GPIO buttons on some Intel Bay Trail
tablets originally running Windows 8. The ACPI description of these
buttons follows "Windows ACPI Design Guide for SoC Platforms".
Signed-off-by: Lejun Zhu
---
drivers/input/misc/Kconfig | 10 ++
drivers/input/misc/M
62 matches
Mail list logo
