On Tue, Apr 08, 2014 at 10:21:37AM +0200, Mateusz Guzik wrote:
> On Tue, Apr 08, 2014 at 03:12:22PM +0800, Zheng Liu wrote:
> >
> > +int __close_fds(struct files_struct *files, int lowfd)
> > +{
> > + struct file *file;
> > + struct fdtable *fdt;
> >
From: Zheng Liu
This commit adds a new syscall called closefrom(2) which is almost the
same as closefrom(2) in FreeBSD. This syscall will close all open file
descriptors that is greater than or equal to the fd that is indicated
by caller. It is really useful for an application that has opened
From: Zheng Liu
Now dirty_backgraound_ratio/dirty_ratio contains a percentage of total avaiable
memory, which contains free pages and reclaimable pages. The number of these
pages is not equal to the number of total system memory. But they are described
as a percentage of total system memory in
Hello,
On Wed, Oct 02, 2013 at 09:36:59AM -0600, T Makphaibulchoke wrote:
> Instead of using a single per super block mutex, s_orphan_lock, to serialize
> all orphan list updates, a separate mutex and spinlock are used to
> protect the on disk and in memory orphan lists respecvitely.
>
> At the s
Hi Al,
On Sat, Jul 20, 2013 at 12:36:13AM +0100, Al Viro wrote:
> On Fri, Jul 19, 2013 at 08:14:05PM +0800, Zheng Liu wrote:
> > Hi Dave,
> >
> > After applied this patch, the problem has been fixed in my own sand box.
> > But that would be great if you could give it
ext3 file system.
Thanks,
- Zheng
From: Zheng Liu
When we try to open a file with O_TMPFILE flag, we will trigger a bug.
The root cause is that in ext4_orphan_add() we check ->i_nlink == 0 and
this check always fails because we set ->i_nli
Hi Dave,
Thanks for reporting this.
On Wed, Jul 17, 2013 at 12:19:44PM -0400, Dave Jones wrote:
> Seen while fuzzing..
>
> kernel BUG at fs/ext4/namei.c:2572!
> invalid opcode: [#1] PREEMPT SMP DEBUG_PAGEALLOC
> Modules linked in: dlci bridge stp hidp cmtp kernelcapi l2tp_ppp l2tp_netlink
On Sun, Jul 14, 2013 at 11:12:58AM +0800, Sam Ben wrote:
> On 07/02/2013 10:37 AM, Zheng Liu wrote:
> >On Mon, Jul 01, 2013 at 09:16:46AM -0700, Dave Hansen wrote:
> >>On 06/28/2013 07:20 PM, Zheng Liu wrote:
> >>>>>IOW, a process needing to do a bunch of MAP_P
Hi Daniel,
On Mon, Jun 24, 2013 at 02:34:00PM +0800, Daniel J Blueman wrote:
> On 16 April 2013 15:37, Daniel J Blueman wrote:
> > When using e4defrag on a ext4 filesystem created a month ago, I ran
> > into this fatal page fault [1]
> > while running e4defrag on 3.9-rc6 (Ubuntu mainline).
> >
>
On Mon, Jul 01, 2013 at 09:43:29PM -0700, Dave Hansen wrote:
> On 07/01/2013 07:37 PM, Zheng Liu wrote:
> > FWIW, it would be great if we can let MAP_POPULATE flag support shared
> > mappings because in our product system there has a lot of applications
> > that uses mmap(2
On Mon, Jul 01, 2013 at 09:16:46AM -0700, Dave Hansen wrote:
> On 06/28/2013 07:20 PM, Zheng Liu wrote:
> >> > IOW, a process needing to do a bunch of MAP_POPULATEs isn't
> >> > parallelizable, but one using this mechanism would be.
> > I look at the
On 06/28/2013 11:48 PM, Dave Hansen wrote:
> On 06/27/2013 10:47 PM, Zheng Liu wrote:
>>> I've been doing some testing involving large amounts of
>>> page cache. It's quite painful to get hundreds of GB
>>> of page cache mapped in, especially when I am
Hi Dave,
On Thu, Jun 27, 2013 at 04:16:05PM -0700, Dave Hansen wrote:
>
> I've been doing some testing involving large amounts of
> page cache. It's quite painful to get hundreds of GB
> of page cache mapped in, especially when I am trying to
> do it in parallel threads. This is true even when
On Mon, Jun 24, 2013 at 10:37:57AM +, Sidorov, Andrei wrote:
> On 24.06.2013 13:36, Namjae Jeon wrote:
> > Currently, we can try implementing dave's suggesstion of introducing a
> > new flag FALLOC_FL_COLLAPSE_RANGE for falloctae instead of individual
> > ioctls for both XFS and EXT4. Thanks.
>
Hi Stephen,
On Jun 19, 2013, at 3:27 PM, Stephen Rothwell wrote:
> Hi Andrew,
>
> Today's linux-next merge of the akpm tree got a conflict in
> fs/ext4/extents_status.c between commit 6480bad916be ("ext4: improve
> extent cache shrink mechanism to avoid to burn CPU time") from the ext
> tree an
On Mon, Jun 17, 2013 at 10:51:34PM -0400, Theodore Ts'o wrote:
> On Tue, Jun 18, 2013 at 10:25:48AM +0800, Zheng Liu wrote:
> > Ah, sorry, I forgot to mention that this patch bases against ext4/master
> > branch. Now ext4/dev branch has some regression when I run xfstests.
&
On Mon, Jun 17, 2013 at 02:12:10PM -0700, Dave Hansen wrote:
> On 06/17/2013 03:10 AM, Zheng Liu wrote:
> > Dave, that would be great if you could do your testing again to confirm
> > this patch is useful.
>
> I was able to apply this to Ted's
>
> https://
On Fri, Jun 14, 2013 at 02:00:54PM -0400, Theodore Ts'o wrote:
> On Sat, Jun 15, 2013 at 01:00:28AM +0800, Zheng Liu wrote:
> > > I have a suggestion for how to address this: Keep a timestamp of when
> > > the list last has been sorted in struct ext4_super_info. When
>
On Fri, Jun 14, 2013 at 08:57:44AM -0700, Dave Hansen wrote:
> On 06/14/2013 07:09 AM, Zheng Liu wrote:
> > - INIT_LIST_HEAD(&scanned);
> > -
> > spin_lock(&sbi->s_es_lru_lock);
> > + list_sort(NULL, &sbi->s_es_lru, ext4_inode_touch_time_cm
On Fri, Jun 14, 2013 at 10:02:15AM -0400, Theodore Ts'o wrote:
> On Fri, Jun 14, 2013 at 10:09:40PM +0800, Zheng Liu wrote:
> > This commit tries to fix this problem. Now a new member called
> > i_touch_when is added into ext4_inode_info to record the last access
> > tim
of ext4 tree.
Any comment or suggestion is welcome.
Thanks,
- Zheng
Subject: [PATCH] ext4: improve extent cache shrink mechanism to avoid to burn
CPU time
From: Zheng Liu
Now we maintain an proper in-order LRU list in ext4 to reclaim entries
from ext
On Thu, Jun 13, 2013 at 09:35:17AM -0400, Theodore Ts'o wrote:
> On Thu, Jun 13, 2013 at 09:27:15PM +0800, Zheng Liu wrote:
> > Thanks for your suggestion. But, sorry, I couldn't get your point here.
> > As you suggested above, we can tag each inode with the
Hi Ted,
On Wed, Jun 12, 2013 at 04:48:54PM -0400, Theodore Ts'o wrote:
> On Wed, Jun 12, 2013 at 08:09:14AM -0700, Dave Hansen wrote:
> > You could make per-cpu LRUs, and batch movement on and off the global
> > LRU once the local ones get to be a certain size. Or, you could keep
> > them cpu-loc
On Wed, Jun 12, 2013 at 08:09:14AM -0700, Dave Hansen wrote:
> On 06/12/2013 12:17 AM, Zheng Liu wrote:
> > On Tue, Jun 11, 2013 at 04:22:16PM -0700, Dave Hansen wrote:
> >> I've got a test case which I intended to use to stress the VM a bit. It
> >> fills memor
Hi Dave
Thanks for reporting this.
On Tue, Jun 11, 2013 at 04:22:16PM -0700, Dave Hansen wrote:
> I've got a test case which I intended to use to stress the VM a bit. It
> fills memory up with page cache a couple of times. It essentially runs
> 30 or so cp's in parallel.
Could you please share
s, no matter they are dirty or not, except the ordered case.
>
> Signed-off-by: Li Wang
> Signed-off-by: Yunchuan Wen
> Reviewed-by: Zheng Liu
FWIW, you could Cc me but you couldn't add 'Reviewed-by' here because in
first version I give a comment to you, and I don
On Mon, May 13, 2013 at 11:08:11PM +0400, Alexey Khoroshilov wrote:
> Hi, Ted!
>
> Our tests for ext4 with targeted fault injection were stalled in
> Uninterruptible Sleep State
> when they simulate a memory allocation failure in ext4_init_io_end() while it
> is called from
> mpage_da_submit_i
On Mon, May 13, 2013 at 05:17:27PM +0200, Jan Kara wrote:
> On Mon 13-05-13 21:56:43, Zheng Liu wrote:
> > On Mon, May 13, 2013 at 03:18:09PM +0200, Jan Kara wrote:
> > > On Sun 12-05-13 13:04:59, EUNBONG SONG wrote:
> > > >
> > > >
> > >
On Mon, May 13, 2013 at 03:18:09PM +0200, Jan Kara wrote:
> On Sun 12-05-13 13:04:59, EUNBONG SONG wrote:
> >
> >
> > >> Since at this point it's safer to rollback the change and we can
> > >> investigate more deeply how to fix it correctly for the next
> > >> development cycle, this is the patch
On Mon, May 13, 2013 at 09:53:25AM +, EUNBONG SONG wrote:
>
>
> > Hi all,
>
> > First of all I couldn't reproduce this regression in my sand box. So
> > the following speculation is only my guess. I suspect that the commit
> > (ae4647fb) isn't root cause. It just uncover a potential bug t
00:03:42 2013 -0400
>
> jbd2: reduce journal_head size
>
> Remove unused t_cow_tid field (ext4 copy-on-write support doesn't seem
> to be happening) and change b_modified and b_jlist to bitfields thus
> saving 8 bytes in the structure.
>
> Signed-o
On Wed, Apr 24, 2013 at 01:08:17PM +0200, Lukáš Czerner wrote:
> On Tue, 23 Apr 2013, Zheng Liu wrote:
[snip]
> > > > Also update respective tracepoints to use signed long long type for
> > > > partial_cluster.
> > > The patch looks OK. You
On Sat, Apr 20, 2013 at 03:42:41PM +0200, Jan Kara wrote:
> On Tue 09-04-13 11:14:26, Lukas Czerner wrote:
> > Currently punch hole is disabled in file systems with bigalloc
> > feature enabled. However the recent changes in punch hole patch should
> > make it easier to support punching holes on bi
quot;Theodore Ts'o"
Reviewed-by: Zheng Liu
Regards,
- Zheng
> ---
> fs/ext4/balloc.c | 2 +-
> fs/ext4/ialloc.c | 2 +-
> fs/ext4/mmp.c| 4 ++--
> fs/ext4/super.c | 2 +-
> 4 files changed, 5 insertions(+), 5
[Cc ext4 mailing list to let other folks know]
On Tue, Apr 16, 2013 at 03:37:31PM +0800, Daniel J Blueman wrote:
> When using e4defrag on a ext4 filesystem created a month ago, I ran
> into this fatal page fault [1]
> while running e4defrag on 3.9-rc6 (Ubuntu mainline).
>
> e2fsdump output is at
On 04/20/2013 06:05 AM, Alexey Khoroshilov wrote:
> If ext4_fill_super() failed after extents status shrinker
> has been registered, the shrinker is left in a global list
> while the memory, it sits in, is already freed.
> Oops is not so bad scenario after that.
>
> Found by Linux File System Veri
org/patch/233397/
>> I hope this should fix all known issues
>
> Zheng Liu also sent a patch:
>
> [PATCH] ext4: fix a big-endian bug when an extent is zeroed out
>
> When I try to apply all three of those to 3.9-4c4, the 2nd one from Dmitry
> fails:
>
> $ cat ~
On 04/04/2013 12:36 AM, Theodore Ts'o wrote:
> From: Zheng Liu
>
> From: Zheng Liu
>
> When an extent was zeroed out, we forgot to do convert from cpu to le16.
> It could make us hit a BUG_ON when we try to write dirty pages out. So
> fix it.
>
> [ Also fi
arse to check this
problem. I think the following patch could fix this bug.
Regards,
- Zheng
Subject: [PATCH] ext4: fix a big-endian bug when an extent is zeroed out
From: Zheng Liu
When an extent was zeroed out, we forgot to do convert from cpu to le16.
It could make us hit a BUG_ON when we try to
Hi Mel,
Thanks for reporting it.
On 04/02/2013 10:27 PM, Mel Gorman wrote:
> I'm testing a page-reclaim-related series on my laptop that is partially
> aimed at fixing long stalls when doing metadata-intensive operations on
> low memory such as a git checkout. I've been running 3.9-rc2 with the
>
On Tue, Apr 02, 2013 at 01:47:44PM +0400, Dmitry Monakhov wrote:
> On Mon, 1 Apr 2013 23:15:07 -0700 (PDT), Christian Kujau
> wrote:
> > Hi,
> >
> > my machine (PowerBook G4) just crashed and the only thing netconsole was
> > able to transmit was:
> >
> > [ cut here ]
On Tue, Mar 12, 2013 at 09:28:11AM -0400, Theodore Ts'o wrote:
> On Tue, Mar 12, 2013 at 03:16:06PM +0800, Zheng Liu wrote:
> >
> > Ted, I am wandering if we need to Cc this patch to stable kernel. We
> > don't receive any report to complaint it, though, but i
On Tue, Mar 12, 2013 at 07:48:10AM +0100, Markus Trippelsdorf wrote:
> On 2013.03.12 at 14:44 +0800, Zheng Liu wrote:
> > On Tue, Mar 12, 2013 at 07:16:24AM +0100, Markus Trippelsdorf wrote:
> > > On 2013.03.11 at 23:30 -0400, Theodore Ts'o wrote:
> > > > On Tu
On Tue, Mar 12, 2013 at 07:16:24AM +0100, Markus Trippelsdorf wrote:
> On 2013.03.11 at 23:30 -0400, Theodore Ts'o wrote:
> > On Tue, Mar 12, 2013 at 11:00:58AM +0800, Zheng Liu wrote:
> > >
> > > Thanks for reporting this problem. My deepest apologies.
> >
; > and 3.9-rc1.
> >
> > I've started a full bisection from v3.8 to todays git tree. It will take
> > ~13 steps. However it's already late here in Germany. I will continue
> > the bisection tomorrow and report back.
>
> The issue started with:
>
&
On 02/28/2013 03:19 AM, Dave Jones wrote:
> On Wed, Feb 27, 2013 at 07:56:25PM +0100, Markus Trippelsdorf wrote:
> > On 2013.02.27 at 13:49 -0500, Theodore Ts'o wrote:
> >
> > > Markus, Dave, can you confirm that this fixes your problem?
> >
> > Yes, it fixes the issue.
>
> Looks like it's
mber 688923213. When viewed in hex, block number
> 152052301 (from the syslog) is 0x910224D, while block number 688923213
> is 0x2910224D. Note the missing "0x2000" in the block number.
>
> Reported-by: Markus Trippelsdorf
> Reported-by: Dave Jones
> Cc:
On Tue, Feb 19, 2013 at 09:22:40AM +0800, Li Zefan wrote:
> There's a long long-standing bug...As long as I don't know when it dates
> from.
>
> I've written and attached a simple program to reproduce this bug, and it can
> immediately trigger the bug in my box. It uses two threads, one keeps call
On Thu, Jan 31, 2013 at 04:07:57PM -0800, Andrew Morton wrote:
[snip]
> > c) i_mutex doesn't allow any paralellism of operations using it and some
> >filesystems workaround this for specific cases (e.g. DIO reads). Using
> >range locking allows for concurrent operations (e.g. writes, DIO) o
64(3, 0, 1048576, POSIX_FADV_WILLNEED) = 0 <0.000474>
> After: fadvise64(3, 0, 1048576, POSIX_FADV_WILLNEED) = 0 <0.63>
I do a simple test in my desktop, which reads 128k data. W/o this patch,
this syscall takes 32us, and w/ this patch it takes 7us. You can add:
Tested-by: Zheng Liu
>
On Fri, Dec 21, 2012 at 01:28:27PM -0800, Andy Lutomirski wrote:
> The onus is currently on filesystems to call file_update_time
> somewhere in the page_mkwrite path. This is unfortunate for three
> reasons:
>
> 1. page_mkwrite on a locked page should be fast. ext4, for example,
>often sleep
On Thu, Dec 13, 2012 at 12:08:11AM -0800, Darrick J. Wong wrote:
> diff --git a/mm/bounce.c b/mm/bounce.c
> index 0420867..fa11935 100644
> --- a/mm/bounce.c
> +++ b/mm/bounce.c
> @@ -178,6 +178,38 @@ static void bounce_end_io_read_isa(struct bio *bio, int
> err)
> __bounce_end_io_read(bio,
On Sun, Dec 16, 2012 at 03:15:49PM +1100, Dave Chinner wrote:
> On Sun, Dec 16, 2012 at 03:35:49AM +, Eric Wong wrote:
> > Dave Chinner wrote:
> > > On Sun, Dec 16, 2012 at 12:25:49AM +, Eric Wong wrote:
> > > > Alan Cox wrote:
> > > > > On Sat, 15 Dec 2012 00:54:48 +
> > > > > Eric W
On Thu, Nov 29, 2012 at 06:00:00PM +0800, zwu.ker...@gmail.com wrote:
> From: Zhi Yong Wu
Please write a commit log to describe this patch, even though it is
quite simple and straightfoward
Otherwise, it looks good to me.
Reviewed-by: Zheng Liu
Rega
Commit-ID: 12f8f74b2a4d26c4facfa7ef99487cf0930f6ef7
Gitweb: http://git.kernel.org/tip/12f8f74b2a4d26c4facfa7ef99487cf0930f6ef7
Author: Zheng Liu
AuthorDate: Thu, 8 Nov 2012 16:58:46 -0800
Committer: Arnaldo Carvalho de Melo
CommitDate: Fri, 9 Nov 2012 11:34:49 -0300
perf test: fix a
On Tue, Nov 06, 2012 at 05:00:19PM +0800, Zhi Yong Wu wrote:
> On Tue, Nov 6, 2012 at 4:39 PM, Zheng Liu wrote:
> > On Mon, Nov 05, 2012 at 10:29:39AM +0800, Zhi Yong Wu wrote:
> >> On Fri, Nov 2, 2012 at 4:41 PM, Zheng Liu wrote:
> >> > On Fri, Nov 02, 2012 at
On Mon, Nov 05, 2012 at 10:29:39AM +0800, Zhi Yong Wu wrote:
> On Fri, Nov 2, 2012 at 4:41 PM, Zheng Liu wrote:
> > On Fri, Nov 02, 2012 at 02:38:29PM +0800, Zhi Yong Wu wrote:
> >> Here also has another question.
> >>
> >> How to save the file temper
Hi Zhiyong,
On Thu, Oct 25, 2012 at 11:08:55PM +0800, zwu.ker...@gmail.com wrote:
[snip]
> @@ -199,6 +342,54 @@ err:
> }
>
> /*
> + * Main function to update access frequency from read/writepage(s) hooks
> + */
> +inline void hot_update_freqs(struct inode *inode, u64 start,
> +
On Wed, Oct 17, 2012 at 02:34:15PM +0800, Zhi Yong Wu wrote:
> >> diff --git a/fs/hot_tracking.h b/fs/hot_tracking.h
> >> index d19e64a..7a79a6d 100644
> >> --- a/fs/hot_tracking.h
> >> +++ b/fs/hot_tracking.h
> >> @@ -36,6 +36,9 @@
> >> */
> >> #define TIME_TO_KICK 400
> >>
> >> +/* set how oft
On Wed, Oct 10, 2012 at 06:07:22PM +0800, zwu.ker...@gmail.com wrote:
> From: Zhi Yong Wu
>
> NOTE:
>
> The patchset is currently post out mainly to make sure
> it is going in the correct direction and hope to get some
> helpful comments from other guys.
> For more infomation, please check h
Hi Zhi Yong,
[cut...]
> +3. The Design
> +
> +These include the following parts:
> +
> +* Hooks in existing vfs functions to track data access frequency
> +
> +* New rbtrees for tracking access frequency of inodes and sub-file
^^^ s/rbtrees/radix-trees
> +ranges (hot_rb.c)
On Thu, Sep 27, 2012 at 04:39:20PM -0400, Theodore Ts'o wrote:
> On Thu, Sep 27, 2012 at 01:31:28PM -0700, Hugh Dickins wrote:
> > Kernel build with CONFIG_DEBUG_SLAB or CONFIG_SLUB_DEBUG slub_debug=FPZ
> > gives me kernel BUG at fs/ext4/extents_status.c:142! That's the
> > BUG_ON(es->start + es->
On Sun, Sep 09, 2012 at 04:50:47PM -0400, Jeff Garzik wrote:
> On 09/09/2012 04:36 PM, Hugh Dickins wrote:
> >On Sun, Sep 9, 2012 at 1:28 PM, Jeff Garzik wrote:
> >>I'll send Linus a patch to disable.
> >
> >Thanks, but no, the change in question hasn't reached Linus yet, it's
> >just a linux-next
On Wed, Jul 25, 2012 at 07:53:34PM +0530, Ashish Sangwan wrote:
> While performing punch hole for an inode, i_disksize is not changed.
> So, there is no need to add the inode to orphan list.
>
> Signed-off-by: Ashish Sangwan
> Signed-off-by: Namjae Jeon
Acked-by: Zheng Liu
On Mon, Jun 25, 2012 at 11:24:35AM +0100, Mel Gorman wrote:
> On Tue, Jun 19, 2012 at 02:49:01PM +0900, Minchan Kim wrote:
> > Hi everybody!
> >
> > Recently, there are some efforts to handle system memory pressure.
> >
> > 1) low memory notification - [1]
> > 2) fallocate(VOLATILE) - [2]
> > 3)
On Tue, Jul 17, 2012 at 09:31:06AM +0300, Dan Carpenter wrote:
> We recently changed how the locking worked here, but this error path was
> missed.
>
> Signed-off-by: Dan Carpenter
Sorry, it is my fault. Thanks for pointing out this bug.
Regards,
Zheng
>
> diff --git a/fs/ext4/inode.c b/fs/e
Hi Sheng-Hui,
It seems that there has a patch to fix it.
http://www.spinics.net/lists/linux-ext4/msg32611.html
Regards,
Zheng
On Fri, Jul 6, 2012 at 2:26 PM, Wang Sheng-Hui wrote:
> The left and right extents merge is done by
> ext4_ext_try_to_merge. No specific left/right
> fun calls any more.
67 matches
Mail list logo
