RE: [PATCH 0/5 v3] Porting RapidIO driver from ppc to powerpc architecture and adding memory mapped RapidIO driver.

Yes, I'm working on it. Do not worry about it. Wei. > -Original Message- > From: Kumar Gala [mailto:[EMAIL PROTECTED] > Sent: Tuesday, October 30, 2007 4:31 AM > To: [EMAIL PROTECTED] > Cc: Zhang Wei-r63237; [EMAIL PROTECTED]; > [EMAIL PROTECTED]; [EMAIL PROT

RE: [PATCH 5/5] Add DMA engine driver for Freescale MPC85xxprocessors.

Hi, > > +static void fsl_dma_set_src(dma_addr_t addr, > > + struct dma_async_tx_descriptor > *tx, int index) > > +{ > > What is index supposed to mean? It's not used, or documented > anywhere than > I can see. I've also got more document here. Hi, Dan, could you giv

RE: [PATCH 5/5] Add DMA engine driver for Freescale MPC85xx processors.

Hi, Dan, Does I have followed your new API? :-) > > --- > Greetings, > > Please copy me on any updates to this driver, drivers/dma, or > crypto/async_tx. Ok. > > Below are a few review comments... > > Regards, > Dan > > > +/** > > + * fsl_dma_alloc_descriptor - Allocate descriptor from >

RE: [PATCH 5/5] Add DMA engine driver for Freescale MPC85xx processors.

> > If this is experimental, perhaps you should mark the depends line as > such > depends on on DMA_ENGINE && PPC && EXPERIMENTAL I'll add EXPERIMENTAL for MPC83xx only. > > [...] > > >+ > >+fsl_dma_memcpy_issue_pending(chan); > >+while (fsl_dma_is_complete(chan, cookie, NULL, NU

RE: [PATCH 5/5] Add DMA engine driver for Freescale MPC85xx processors.

Hi, > --- /dev/null > > +++ b/drivers/dma/fsldma.c > > @@ -0,0 +1,995 @@ > > Thanks for using kernel-doc notation. However, ... > > > +/** > > + * fsl_dma_alloc_descriptor - Allocate descriptor from > channel's DMA pool. > > Function parameters need to be listed & described here. > See Docume

RE: [PATCH 3/5 v3] Add the platform device support with RapidIO to MPC8641HPCN platform.

Hi, Arnd, I can change it as you metioned now. Thanks! -zw > -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Arnd Bergmann > Sent: Sunday, July 29, 2007 9:57 PM > To: [EMAIL PROTECTED] > Cc: Zhang Wei-r63237; [EMAIL PROTECTED];

RE: [PATCH 1/5 v3] Add the explanation and a sample of RapidIO OF node to the document of booting-without-of.txt file.

Hi, Kumar, > + RapidIO is a definition of a system interconnect. This node add > > + the support for RapidIO processor in kernel. The node name is > > + suggested to be 'rapidio'. > > + > > + Required properties: > > + > > +- compatible : Using "fsl,rapidio-delta" for Freescale PowerPC

RE: [PATCH 4/5 v3] Add RapidIO support to powerpc architecture.

Hi, Kumar, > -Original Message- > From: Kumar Gala [mailto:[EMAIL PROTECTED] > On Jul 26, 2007, at 3:42 AM, Zhang Wei wrote: > > > This patch adds the RapidIO support to the powerpc architecture. > > Some files are moved from ppc. OF-tree and OF-device supports are > > added. > > New

RE: [PATCH 3/4] Extend the DMA-engine API.

Hi, Dan, Thanks! I get it. It's so lucky we have the same target. When your patch could be accepted? Cheers, Wei. > -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Dan Williams > Sent: Thursday, July 12, 2007 12:57 AM > To: Z

RE: [PATCH 3/4] Extend the DMA-engine API.

Hi, Dan, Do you mention here: http://marc.info/?l=linux-raid&m=118290909614463&w=2 ? I see the async_tx is located at crypto/ of the above page, but my patch is for DMA engine in drivers/dma and for DMA engine driver. Thanks! Wei. > -Original Message- > Subject: Re: [PATCH 3/4] Extend t

RE: [PATCH 1/5 v2] Add the explanation and a sample of RapidIO DTS sector to the document of booting-without-of.txt file.

Hi, Segher, > DTS sector to the document of booting-without-of.txt file. > > >>> +- #address-cells : Address representation for > >> "rapidio" devices. > >>> + This field represents the number of cells needed > to represent > >>> + the RapidIO address of the registers. For > >> s

RE: [PATCH 1/5 v2] Add the explanation and a sample of RapidIO DTS sector to the document of booting-without-of.txt file.

Hi, Segher, > > +- #address-cells : Address representation for > "rapidio" devices. > > + This field represents the number of cells needed to represent > > + the RapidIO address of the registers. For > supporting more than > > + 32-bits RapidIO address, this field should be

RE: [PATCH 3/5 v2] Add the platform device support with RapidIO to MPC8641HPCN platform.

Hi, Arnd, > > On Wednesday 27 June 2007, Zhang Wei wrote: > > +static struct of_device_id mpc86xx_of_ids[] = { > > +   { .type = "soc", }, > > +   { .compatible = "fsl,rapidio-delta", }, > > +   {}, > > +}; > > + > > +static __init int mpc86xx_of_device_init(void) > > +{ > > +   

RE: [PATCH 1/5] Add the explanation and sample of RapidIO DTS sector to the document of booting-without-of.txt file.

Hi, Kumar and Segher, > > > "..8641.." "..8641d.." "..8548.." "..8548e.." "..8543.." > "..8543e.." > > "..8572.." "..8572e.." "..8567.." "..8567e.." "..8568.." "..8568e.." > > You don't need to mention _all_ compatible devices in > the "compatible" property, only the few that matter; > typical

RE: [PATCH 1/5] Add the explanation and sample of RapidIO DTS sector to the document of booting-without-of.txt file.

Hi, Segher, > > >>> +- device_type : Should be "rapidio" > >> > >> There is no OF binding, so no. > > > > So, we need to define it. > > If you want to. Until that has been done, don't use > a "device_type". Linux won't use it, anyway. Do you have another ideas about that? Only remove it?

RE: [PATCH 1/5] Add the explanation and sample of RapidIO DTS sector to the document of booting-without-of.txt file.

Hi, Segher, > -Original Message- > Subject: Re: [PATCH 1/5] Add the explanation and sample of > RapidIO DTS sector to the document of booting-without-of.txt file. > > > + k) RapidIO > > + > > + Required properties: > > + > > +- device_type : Should be "rapidio" > > There is no

RE: [PATCH 2/5] Add RapidIO sector to MPC8641HPCN board dts file.

Hi, Phil, > > +++ b/arch/powerpc/boot/dts/mpc8641_hpcn.dts > > @@ -329,6 +329,19 @@ > > >; > > }; > > > > + [EMAIL PROTECTED] { > > + device_type = "rapidio"; > > + compatible = "fsl,rapidio-v1.0"; > > +