Re: [PATCH] mm/memcontrol.c: make mem_cgroup_read_stat() read all interested stat item in one go

2014-04-16 Thread Zhan Jianyu
On Wed, Apr 16, 2014 at 5:22 PM, Michal Hocko wrote: > cannot say I like the new code much more than the previous one and > I've never seen the old one being a bottleneck. So I am not entirely > fond of optimization without a good reason. (Hint, if you are optimizing > something always show us num

Re: [PATCH] cgroup: print pretty format in /proc/cgroups

2014-04-15 Thread Zhan Jianyu
On Tue, Apr 15, 2014 at 8:51 PM, Tejun Heo wrote: > The problem there is that there could be programs / scripts parsing it > assuming single tab between entries. It surely is ugly but do we > care? Oh, you are right. It is an exposed user interface. This will make lots of administrator unhappy ;

Re: [PATCH] kprobes: be more permissive when user specifies both symbol name and address

2014-04-15 Thread Zhan Jianyu
On Tue, Apr 15, 2014 at 4:27 PM, Masami Hiramatsu wrote: > > Plus, if the p->offset and offs are different, fail too. Oh, yeah, I have did this check it patch too. BTW, I found that the offset has different types in kallsyms_lookup(which is unsigned long) and in struct kprobe(which is unsigne

Re: [PATCH] kprobes: be more permissive when user specifies both symbol name and address

2014-04-15 Thread Zhan Jianyu
On Mon, Apr 14, 2014 at 11:00 PM, Masami Hiramatsu wrote: > if (p->addr) { > if (p->symbol) { > sym = kallsyms_lookup(p->addr, ... &offs ...); > if (strcmp(sym,p->symbol) != 0 || offs != p->offset) { > pr_warning("Error! ..."); > goto fail; > } > } > } else if (p->symbo

Re: [BUG] A panic caused by null pointer dereference aftering updating to

2014-04-14 Thread Zhan Jianyu
On Tue, Apr 15, 2014 at 8:14 AM, Eric Dumazet wrote: > > Zhan, could you try following patch, thanks ! > > drivers/net/vxlan.c |4 ++-- > include/net/dst.h | 14 +++--- > include/net/inet6_connection_sock.h |2 +- > include/net/inet_connection_s

Re: [BUG] A panic caused by null pointer dereference aftering updating to

2014-04-14 Thread Zhan Jianyu
On Mon, Apr 14, 2014 at 11:19 PM, James Chapman wrote: > Please send the complete oops message. Hi, complete oops message is : [ 100.243737] BUG: unable to handle kernel NULL pointer dereference at 02c0 [ 100.244985] IP: [] ip_queue_xmit+0x20/0x3e0 [ 100.262266] PGD 0 [ 100.2883

Re: [PATCH] blkdev: use an efficient way to check merge flags

2014-04-03 Thread Zhan Jianyu
On Thu, Apr 3, 2014 at 2:13 AM, Jan Kara wrote: > OK, but have you checked the generated code is actually any better? This > is something I'd expect a compiler might be able to optimize anyway. And the > original code looks more readable to me. Hi, Jan, I've disassemble the code on my x86_64 b

Re: [PATCH] Documentation: SubmittingPatches: mention our new Facebook group

2014-04-01 Thread Zhan Jianyu
On Wed, Apr 2, 2014 at 12:23 AM, Steven Rostedt wrote: > Liked-by: Steven Rostedt lovely Liked-by :-) Liked-by: Jianyu Zhan Regards, Jianyu Zhan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo i

Re: [PATCH] mm/slab.c: cleanup outdated comments and unify variables naming

2014-03-03 Thread Zhan Jianyu
confusion. So this patch cleans up them. > > Acked-by: Christoph Lameter Thanks, Christoph Lameter. -- Regards, Zhan Jianyu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at ht

Re: [PATCH 07/14] vrange: Purge volatile pages when memory is tight

2013-10-07 Thread Zhan Jianyu
vrange flag should be squashed into the vm_flags ? I am not sure . -- Regards, Zhan Jianyu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.ht

Re: [PATCH RESEND] mm/vmscan : use vmcan_swappiness( ) basing on MEMCG config to elimiate unnecessary runtime cost

2013-09-04 Thread Zhan Jianyu
me and not even generate a > branch for this. > Hi, Johannes Weiner, Thanks for your comment ;) Andrew has pointed this out and this patch is abandoned. -- Regards, Zhan Jianyu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a messag

Re: [PATCH] Documentation/memory-barriers: fix a error that mistakes a CPU notion in Section Transitivity

2013-08-30 Thread Zhan Jianyu
to explain why a should guarantee this. Signed-off-by: Zhan Jianyu --- Documentation/memory-barriers.txt | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/Documentation/memory-barriers.txt b/Documentation/memory-barriers.txt index fa5d8a9..590a5a9 100644 --- a/Docu

Re: [linux-next-20130422] Bug in SLAB?

2013-04-28 Thread Zhan Jianyu
a look at commit e3366016? Cc: linux...@kvack.org -- Regards, Zhan Jianyu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/