> Cc: Andrew Morton
> > Cc: Doug Ledford
> > Cc: linux-r...@vger.kernel.org
> > Cc: linux...@kvack.org
> > Signed-off-by: John Hubbard
>
> I meant...
>
> Reviewed-by: Ira Weiny
>
> just a bit too quick on the keyboard before lunch... ;-)
>
>
On Thu, May 10, 2018 at 09:02:26AM +0200, Christophe JAILLET wrote:
> If an error occurs, 'mlx4_en_destroy_netdev()' is called.
> It then calls 'mlx4_en_free_resources()' which does the needed resources
> cleanup.
>
> So, doing some explicit kfree in the error handling path would lead to
> some do
ng 'netdev_tx_t' in this driver too.
>
> Signed-off-by: Luc Van Oostenryck
Reviewed-by: Yuval Shaia
> ---
> drivers/net/ethernet/micrel/ks8851_mll.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/micrel/ks8851_mll
ng 'netdev_tx_t' in this driver too.
>
> Signed-off-by: Luc Van Oostenryck
Reviewed-by: Yuval Shaia
> ---
> drivers/infiniband/ulp/ipoib/ipoib_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.
Signed-off-by: Yuval Shaia
---
v1 ->v2:
* Fix typo in commit message
---
include/linux/kernel.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/kernel.h b/include/linux/kernel.h
index ce51455e2adf..a5b4ba3bdb61 100644
--- a/include/linux/kernel.h
++
On Tue, Apr 10, 2018 at 09:06:26AM +0200, Ingo Molnar wrote:
>
> * Yuval Shaia wrote:
>
> > Signed-off-by: Yuval Shaia
> > ---
> > include/linux/kernel.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/linu
Signed-off-by: Yuval Shaia
---
include/linux/kernel.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/kernel.h b/include/linux/kernel.h
index ce51455e2adf..a5b4ba3bdb61 100644
--- a/include/linux/kernel.h
+++ b/include/linux/kernel.h
@@ -651,7 +651,7 @@ do
Fix use-after-free
Besides that - lgtm.
Reviewed-by: Yuval Shaia
> ---
> drivers/net/ethernet/mellanox/mlx5/core/fpga/ipsec.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fpga/ipsec.c
> b/drivers/net/e
On Tue, Mar 13, 2018 at 06:13:45PM +0200, Yuval Shaia wrote:
> On Tue, Mar 13, 2018 at 05:07:22PM +0200, Liran Alon wrote:
> > Before this commit, dev_forward_skb() always cleared packet's
> > per-network-namespace info. Even if the packet doesn't cross
> > network n
bedit mark 1337
> tc filter add dev veth-b parent : basic match 'meta(nf_mark eq 1337)'
> action simple "skb->mark 1337!"
> dmesg -C
> ping 12.0.0.2
> dmesg
>
> Before this change, the above will print nothing to dmesg.
> After this change, "s
know, sorry about that. I'll test it as soon as I can.
> Thanks for the response.
Reviewed-by: Yuval Shaia
Tested-by: Yuval Shaia
>
> Cheers,
> Hernán
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
eof(struct rds_rdma_args)))
> + return -EINVAL;
> args = CMSG_DATA(cmsg);
> *rdma_bytes += args->remote_vec.bytes;
> }
Reviewed-by: Yuval Shaia
> --
> 2.4.11
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Nov 09, 2017 at 04:38:13PM +, Salil Mehta wrote:
> This patch migrates the HNS3 driver code from use of depricated PCI
> MSI/MSI-X interrupt vector allocation/free APIs to new common APIs.
>
> Signed-off-by: Salil Mehta
> Suggested-by: Christoph Hellwig
> ---
>
On Wed, Nov 08, 2017 at 11:56:06AM +, Salil Mehta wrote:
> This patch migrates the HNS3 driver code from use of depricated PCI
> MSI/MSI-X interrupt vector allocation/free APIs to new common APIs.
>
> Signed-off-by: Salil Mehta
> Suggested-by: Christoph Hellwig
> ---
> .../ethernet/hisilico
goto mbx_err;
> -mbx_err:
> +
> kfree(cmd);
> return status;
Reviewed-by: Yuval Shaia
> }
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
d to reset stats = %d", status);
> + pr_err("Failed to reset stats = %d\n", status);
> goto err;
> }
> }
> --
Reviewed-by: Yuval Shaia
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Sep 26, 2017 at 12:21:44PM +0530, Arvind Yadav wrote:
> pr_err() messages should end with a new-line to avoid other messages
> being concatenated.
>
> Signed-off-by: Arvind Yadav
> ---
> drivers/infiniband/hw/ocrdma/ocrdma_stats.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
MR > 512MB, not
> supported for Connect-IB\n");
> goto error;
> }
> use_umr = false;
> --
> 1.9.1
FWIW,
Reviewed-by: Yuval Shaia
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
@ -1016,7 +1015,6 @@ static struct bnxt_re_qp *bnxt_re_create_shadow_qp
> if (!qp)
> return NULL;
>
> - memset(qp, 0, sizeof(*qp));
> qp->rdev = rdev;
>
> /* Initialize the shadow QP structure from the QP1 values */
> --
> 2.7.4
> - u16 *availible_vpp, u8 *vpp_p_up);
> + u16 *available_vpp, u8 *vpp_p_up);
> /**
> * mlx4_ALLOCATE_VPP_set - Distribution of VPPs among differnt priorities.
> * The total number of VPPs assigned to all for a port must not exceed
> - * the
r.
>
> Fix it by marking the packet for loopback if the destination
> address appears in rxe's gid table.
>
> Signed-off-by: Marcel Apfelbaum
Reviewed-by: Yuval Shaia
Tested-by: Yuval Shaia
> ---
> drivers/infiniband/sw/rxe/rxe_net.c | 47
>
> > + endfor_ifa(in_dev);
>
> The above endfor_ifa should move to below.
Please ignore, my mistake.
>
> > +out:
On Wed, Jul 26, 2017 at 05:52:48PM +0300, Marcel Apfelbaum wrote:
> Currently a packet is marked for loopback only if the source and
> destination address match. This is not enough when multiple
> gids are present in rxe's gid table and the traffic is
> from one gid to another.
>
> Fix it by marki
On Mon, Jun 05, 2017 at 03:39:02PM +0800, Jia-Ju Bai wrote:
> The driver may sleep under a spin lock, and the function call path is:
> post_one_send (acquire the lock by spin_lock_irqsave)
> init_send_wqe
> copy_from_user --> may sleep
>
> To fix it, the lock is released before copy_from_use
On Thu, Jun 01, 2017 at 04:28:55PM +0800, Jia-Ju Bai wrote:
> The driver may sleep under a spin lock, and the function call path is:
> post_one_send (acquire the lock by spin_lock_irqsave)
> init_send_wqe
> copy_from_user --> may sleep
>
> To fix it, the lock is released before copy_from_use
, vchnl_msg);
> - else
> - vchnl_pf_send_get_ver_resp(dev, vf_id, vchnl_msg);
> + vchnl_pf_send_get_ver_resp(dev, vf_id, vchnl_msg);
> return I40IW_SUCCESS;
> }
> for (iw_vf_idx = 0; iw_vf_idx &
,7 @@ static inline int ib_speed_enum_to_int(int speed)
> static int ipoib_get_link_ksettings(struct net_device *netdev,
> struct ethtool_link_ksettings *cmd)
> {
> - struct ipoib_dev_priv *priv = netdev_priv(netdev);
> + struct ipoib_dev_pr
into the hard header')
> Reported-by: Norbert P
> Signed-off-by: Honggang Li
> ---
> drivers/infiniband/ulp/ipoib/ipoib_main.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c
> b/drivers/infiniband/ulp/ipoib/ipoib
us fix affected source code places.
>
> Signed-off-by: Markus Elfring
Reviewed-by: Yuval Shaia
> ---
> drivers/infiniband/ulp/ipoib/ipoib_main.c | 13 +++--
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c
On Wed, Apr 05, 2017 at 05:21:22PM +0200, SF Markus Elfring wrote:
> > I found that the fix brings no harm to the existing code.
>
> How do you think about to take another look at remaining update candidates
> at other source code places for this Linux module?
You mean the other patches in this p
On Wed, Apr 05, 2017 at 05:06:58PM +0200, Johannes Thumshirn wrote:
> On Wed, Apr 05, 2017 at 04:54:40PM +0200, SF Markus Elfring wrote:
> > >> @@ -7324,8 +7324,9 @@ struct qib_devdata *qib_init_iba7322_funcs(struct
> > >> pci_dev *pdev,
> > >> actual_cnt -= dd->num_pports;
> > >>
gt; > the array allocations in lines 264 and 268?
>
> Do you refer to source code places here which are affected by the update step
> "[PATCH 4/5] IB/qib: Use kcalloc() in qib_init_pportdata()"?
Oops, please ignore.
>
>
> > Besides that:
> > Reviewed-by: Yuval Shaia
>
> Do you find the proposed change for the shown data types really acceptable
> in these function calls?
I found that the fix brings no harm to the existing code.
>
> Regards,
> Markus
On Wed, Apr 05, 2017 at 03:51:52PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Wed, 5 Apr 2017 09:43:54 +0200
>
> * A multiplication for the size determination of a memory allocation
> indicated that an array data structure should be processed.
> Thus use the corresponding
es_shadow),
> + GFP_KERNEL);
Not related to this patch but is related to your patch-set - can you check
the array allocations in lines 264 and 268?
Besides that:
Reviewed-by: Yuval Shaia
> if (!ppd->congestion_entries_shadow)
>
sizeof(*dd->cspec->sendgrhchk),
> + GFP_KERNEL);
> + dd->cspec->sendibchk = kmalloc_array(sbufcnt,
> + sizeof(*dd->cspec->sendibchk),
> +
d *ibpd,
> if (!mr)
> return ERR_PTR(-ENOMEM);
>
> - mr->pages = kcalloc(max_num_sg, sizeof(u64), GFP_KERNEL);
> + mr->pages = kcalloc(max_num_sg, sizeof(*mr->pages), GFP_KERNEL);
Reviewed-by: Yuval Shaia
> if (!mr->pages) {
>
qe)
> + return -EINVAL;
> ibcq->cqe = new_cnt;
> - return status;
> + return 0;
Reviewed-by: Yuval Shaia
> }
>
> static void ocrdma_flush_cq(struct ocrdma_cq *cq)
> --
> 2.12.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
MEM);
>
> mr->pages = kcalloc(max_num_sg, sizeof(*mr->pages), GFP_KERNEL);
> - if (!mr->pages) {
> - status = -ENOMEM;
> + if (!mr->pages)
> goto pl_err;
> - }
>
Reviewed-by: Yuval Shaia
> status = ocrdma_get_pbl_i
; @@ -769,11 +768,10 @@ int ocrdma_dealloc_pd(struct ib_pd *ibpd)
>
> if (is_ucontext_pd(uctx, pd)) {
> ocrdma_release_ucontext_pd(uctx);
> - return status;
> + return 0;
> }
> }
> -
uctx->cntxt_pd = NULL;
> - goto err;
> + return status;
> }
>
> uctx->cntxt_pd->uctx = uctx;
> uctx->cntxt_pd->ibpd.device = &dev->ibdev;
> -err:
> - return status;
> + return 0;
> }
Reviewed-by: Yuval Sh
&stop);
> - } else {
> - expand = ocrdma_poll_rcqe(qp, cqe, ibwc, &polled,
> - &stop);
> - }
> + expand = is_cqe_for_sq(cqe)
> + ? ocrdma_poll_scqe(qp, cqe, ibwc, &polled, &stop)
> + : ocrdma_poll_rcqe(qp, cqe, ibwc, &polled, &stop);
> if (expand)
> goto expand_cqe;
> if (stop)
> --
Reviewed-by: Yuval Shaia
> 2.12.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Mar 08, 2017 at 08:48:39PM +0530, Devesh Sharma wrote:
> Acked-By: Devesh Sharma
Reviewed-by: Yuval Shaia
>
> On Wed, Mar 8, 2017 at 7:04 PM, SF Markus Elfring
> wrote:
> > From: Markus Elfring
> > Date: Wed, 8 Mar 2017 12:50:14 +0100
> > MIME-Versi
uct ib_pd *ibpd,
> if (srq->idx_bit_fields == NULL)
> goto arm_err;
> memset(srq->idx_bit_fields, 0xff,
> -srq->bit_fields_len * sizeof(u32));
> + srq->bit_fields_len * sizeof(*srq->idx
ev *dev)
>
> dev->stag_arr = kcalloc(OCRDMA_MAX_STAG, sizeof(*dev->stag_arr),
> GFP_KERNEL);
> - if (dev->stag_arr == NULL)
> + if (!dev->stag_arr)
> goto alloc_err;
Reviewed-by: Yuval Shaia
>
> ocrdma_alloc_pd_pool(dev);
>
{
> struct ocrdma_mqe *mqe;
>
> - mqe = kzalloc(sizeof(struct ocrdma_mqe), GFP_KERNEL);
> + mqe = kzalloc(sizeof(*mqe), GFP_KERNEL);
> if (!mqe)
> return NULL;
> mqe->hdr.spcl_sge_cnt_emb |=
Reviewed-by: Yuval Shaia
> --
> 2.1
dev_info)
> struct ocrdma_dev *dev;
>
> dev = (struct ocrdma_dev *)ib_alloc_device(sizeof(*dev));
> - if (!dev) {
> - pr_err("Unable to allocate ib device\n");
> + if (!dev)
> return NULL;
> - }
> +
Reviewed-
ystem=0x%x\n",
> (rsp->subsys_op & OCRDMA_MBX_RSP_OPCODE_MASK) >>
> OCRDMA_MBX_RSP_OPCODE_SHIFT,
> (rsp->subsys_op & OCRDMA_MBX_RSP_SUBSYS_MASK) >>
> OCRDMA_MBX_RSP_SUBSYS_SHIFT);
ormation out like the following.
>
> Comparison to NULL could be written !…
Good to know.
Reviewed-by: Yuval Shaia
>
> Thus fix the affected source code places.
Above line can be removed.
>
> Signed-off-by: Markus Elfring
> ---
> drivers/infiniband/hw/ocrdma/ocrdma_hw.
o
> *dev_info)
> u8 lstate = 0;
> struct ocrdma_dev *dev;
>
> - dev = (struct ocrdma_dev *)ib_alloc_device(sizeof(struct ocrdma_dev));
> + dev = (struct ocrdma_dev *)ib_alloc_device(sizeof(*dev));
> if (!dev) {
> pr_err(&
On Wed, Mar 08, 2017 at 01:58:49PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Tue, 7 Mar 2017 20:16:16 +0100
>
> Replace the specification of two data structures by pointer dereferences
> as the parameter for the operator "sizeof" to make the corresponding size
> determination
gt; u16 cq_id)
> ocrdma_process_acqe(dev, cqe);
> else if (cqe->valid_ae_cmpl_cons & OCRDMA_MCQE_CMPL_MASK)
> ocrdma_process_mcqe(dev, cqe);
> - memset(cqe, 0, sizeof(struct ocrdma_mcqe));
> + memset(cqe,
dev *dev)
> struct ocrdma_get_ctrl_attribs_rsp *ctrl_attr_rsp;
> struct mgmt_hba_attribs *hba_attribs;
>
> - mqe = kzalloc(sizeof(struct ocrdma_mqe), GFP_KERNEL);
> + mqe = kzalloc(sizeof(*mqe), GFP_KERNEL);
> if (!mqe)
> return status;
>
gt; ocrdma_qp *qp,
> if (status)
> goto mbx_err;
> rsp = (struct ocrdma_query_qp_rsp *)cmd;
> - memcpy(param, &rsp->params, sizeof(struct ocrdma_qp_params));
> + memcpy(param, &rsp->params, sizeof(*param));
> mbx_err:
> kfree(cmd)
;
> struct ocrdma_mqe cmd;
> -
> - struct ocrdma_get_dcbx_cfg_req *req = NULL;
> - struct ocrdma_get_dcbx_cfg_rsp *rsp = NULL;
> + struct ocrdma_get_dcbx_cfg_req *req;
> + struct ocrdma_get_dcbx_cfg_rsp *rsp;
Reviewed-by: Yuval Shaia
> str
On Wed, Mar 08, 2017 at 01:41:00PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Tue, 7 Mar 2017 18:23:54 +0100
>
> * Multiplications for the size determination of memory allocations
> indicated that array data structures should be processed.
> Thus reuse the corresponding fu
x_cfg_rsp));
> - memcpy(dcbxcfg, &rsp->cfg, sizeof(struct ocrdma_dcbx_cfg));
> -
> + ocrdma_le32_to_cpu(rsp, sizeof(*rsp));
> + memcpy(dcbxcfg, &rsp->cfg, sizeof(*dcbxcfg));
> mbx_err:
> dma_free_coherent(&pdev->dev, cmd.hdr.pyld_len, req, pa);
>
22,8 @@ void ipoib_dma_unmap_tx(struct ipoib_dev_priv *priv,
> int off;
>
> if (skb_headlen(skb)) {
> - ib_dma_unmap_single(priv->ca, mapping[0], skb_headlen(skb),
> - DMA_TO_DEVICE);
> + dma_unmap_single(priv-&
WIW compiled also on SPARC
Reviewed-by: Yuval Shaia
>
> Signed-off-by: Zhouyi Zhou
> ---
> drivers/infiniband/hw/nes/nes_nic.c | 5 +++--
> drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c | 6 +-
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 +--
> drivers/
One minor comment inline.
Besides that:
Reviewed-by: Yuval Shaia
On Sun, Aug 28, 2016 at 12:00:18AM +0800, Baoyou Xie wrote:
> We get 1 warning when biuld kernel with W=1:
s/biuld/build
> drivers/infiniband/hw/cxgb4/qp.c:686:6: warning: no previous prototype for
> '_free_
On Wed, Nov 18, 2015 at 02:25:23PM +0100, Petr Mladek wrote:
> Kthreads are currently implemented as an infinite loop. Each
> has its own variant of checks for terminating, freezing,
> awakening. In many cases it is unclear to say in which state
> it is and sometimes it is done a wrong way.
>
> Th
60 matches
Mail list logo
