[PATCH] vduse: relicense under GPL-2.0 OR BSD-3-Clause

2024-11-18 Thread Yongji Xie
Dual-license the vduse kernel header file to dual GPL-2.0 OR BSD-3-Clause license to make it possible to ship it with DPDK (under BSD-3-Clause) for older distros. Signed-off-by: Yongji Xie --- include/uapi/linux/vduse.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include

Re: Re: Re: [PATCH] vduse: avoid using __GFP_NOFAIL

2024-08-12 Thread Yongji Xie
On Mon, Aug 12, 2024 at 3:00 PM Jason Wang wrote: > > On Thu, Aug 8, 2024 at 6:52 PM Yongji Xie wrote: > > > > On Thu, Aug 8, 2024 at 10:58 AM Jason Wang wrote: > > > > > > On Wed, Aug 7, 2024 at 2:52 PM Yongji Xie wrote: > > > > > >

Re: Re: [PATCH] vduse: avoid using __GFP_NOFAIL

2024-08-08 Thread Yongji Xie
On Thu, Aug 8, 2024 at 1:50 PM Jason Wang wrote: > > On Wed, Aug 7, 2024 at 2:54 PM Yongji Xie wrote: > > > > On Wed, Aug 7, 2024 at 12:38 PM Jason Wang wrote: > > > > > > On Wed, Aug 7, 2024 at 11:13 AM Yongji Xie > > > wrote: > > > >

Re: Re: [PATCH] vduse: avoid using __GFP_NOFAIL

2024-08-08 Thread Yongji Xie
On Thu, Aug 8, 2024 at 10:58 AM Jason Wang wrote: > > On Wed, Aug 7, 2024 at 2:52 PM Yongji Xie wrote: > > > > On Mon, Aug 5, 2024 at 4:21 PM Jason Wang wrote: > > > > > > Barry said [1]: > > > > > > """ > > > mm doe

Re: [PATCH] vduse: avoid using __GFP_NOFAIL

2024-08-06 Thread Yongji Xie
On Wed, Aug 7, 2024 at 12:38 PM Jason Wang wrote: > > On Wed, Aug 7, 2024 at 11:13 AM Yongji Xie wrote: > > > > On Wed, Aug 7, 2024 at 10:39 AM Jason Wang wrote: > > > > > > On Tue, Aug 6, 2024 at 11:10 AM Yongji Xie > > > wrote: > > >

Re: [PATCH] vduse: avoid using __GFP_NOFAIL

2024-08-06 Thread Yongji Xie
On Mon, Aug 5, 2024 at 4:21 PM Jason Wang wrote: > > Barry said [1]: > > """ > mm doesn't support non-blockable __GFP_NOFAIL allocation. Because > __GFP_NOFAIL without direct reclamation may just result in a busy > loop within non-sleepable contexts. > ""“ > > Unfortuantely, we do that under read

Re: [PATCH] vduse: avoid using __GFP_NOFAIL

2024-08-06 Thread Yongji Xie
On Wed, Aug 7, 2024 at 10:39 AM Jason Wang wrote: > > On Tue, Aug 6, 2024 at 11:10 AM Yongji Xie wrote: > > > > On Tue, Aug 6, 2024 at 10:28 AM Jason Wang wrote: > > > > > > On Mon, Aug 5, 2024 at 6:42 PM Yongji Xie wrote: > > > > > >

Re: [PATCH] vduse: avoid using __GFP_NOFAIL

2024-08-05 Thread Yongji Xie
On Tue, Aug 6, 2024 at 10:28 AM Jason Wang wrote: > > On Mon, Aug 5, 2024 at 6:42 PM Yongji Xie wrote: > > > > On Mon, Aug 5, 2024 at 4:24 PM Jason Wang wrote: > > > > > > On Mon, Aug 5, 2024 at 4:21 PM Jason Wang wrote: > > > > > > >

Re: [PATCH] vduse: avoid using __GFP_NOFAIL

2024-08-05 Thread Yongji Xie
On Mon, Aug 5, 2024 at 4:24 PM Jason Wang wrote: > > On Mon, Aug 5, 2024 at 4:21 PM Jason Wang wrote: > > > > Barry said [1]: > > > > """ > > mm doesn't support non-blockable __GFP_NOFAIL allocation. Because > > __GFP_NOFAIL without direct reclamation may just result in a busy > > loop within non

Re: [PATCH v7 3/3] vduse: enable Virtio-net device type

2024-01-09 Thread Yongji Xie
On Tue, Jan 9, 2024 at 7:10 PM Maxime Coquelin wrote: > > This patch adds Virtio-net device type to the supported > devices types. > > Initialization fails if the device does not support > VIRTIO_F_VERSION_1 feature, in order to guarantee the > configuration space is read-only. It also fails with

Re: [PATCH v7 2/3] vduse: Temporarily fail if control queue feature requested

2024-01-09 Thread Yongji Xie
On Tue, Jan 9, 2024 at 7:10 PM Maxime Coquelin wrote: > > Virtio-net driver control queue implementation is not safe > when used with VDUSE. If the VDUSE application does not > reply to control queue messages, it currently ends up > hanging the kernel thread sending this command. > > Some work is

Re: [RFC] locking/rwsem: Avoid issuing wakeup before setting the reader waiter to nil

2018-12-17 Thread Yongji Xie
On Mon, 17 Dec 2018 at 19:37, Peter Zijlstra wrote: > > On Mon, Dec 10, 2018 at 11:12:52PM +0800, Yongji Xie wrote: > > Hi Peter, > > > > Please let me know If there is any progress on this issue. Thank you! > > Right, sorry, my brain was filled with snot and didn&#x

Re: [RFC] locking/rwsem: Avoid issuing wakeup before setting the reader waiter to nil

2018-12-10 Thread Yongji Xie
On Fri, 30 Nov 2018 at 06:17, Peter Zijlstra wrote: > > On Thu, Nov 29, 2018 at 01:34:21PM -0800, Davidlohr Bueso wrote: > > I messed up something such that waiman was not in the thread. Ccing. > > > > > On Thu, 29 Nov 2018, Waiman Long wrote: > > > > > > > That can be costly for x86 which will no

Re: [RFC] locking/rwsem: Avoid issuing wakeup before setting the reader waiter to nil

2018-11-29 Thread Yongji Xie
On Thu, 29 Nov 2018 at 21:45, Peter Zijlstra wrote: > > On Thu, Nov 29, 2018 at 02:12:32PM +0100, Peter Zijlstra wrote: > > > > +Cc davidlohr and waiman > > > Urgh; so the case where the cmpxchg() fails because it already has a > > wakeup in progress, which then 'violates' our expectation of when

[RFC] locking/rwsem: Avoid issuing wakeup before setting the reader waiter to nil

2018-11-29 Thread Yongji Xie
From: Xie Yongji Our system encountered a problem recently, the khungtaskd detected some process hang on mmap_sem. But the odd thing was that one task which is not on mmap_sem.wait_list still sleeps in rwsem_down_read_failed(). Through code inspection, we found a potential bug can lead to this.

Re: [PATCH v3 0/7] PCI: Add support for enforcing all MMIO BARs not to share PAGE_SIZE

2016-07-11 Thread Yongji Xie
Hi Bjorn, Any comment on V3? Thanks, Yongji On 2016/6/30 18:53, Yongji Xie wrote: This series aims to add an option for PCI resource allocator to force BARs not to share PAGE_SIZE. This would make sense to VFIO driver. Because current VFIO implementation disallows to mmap sub-page(size

Re: [PATCH v3 3/7] PCI: Do not disable memory decoding in pci_reassigndev_resource_alignment()

2016-07-01 Thread Yongji Xie
Hi Gavin, On 2016/7/1 8:50, Gavin Shan wrote: On Thu, Jun 30, 2016 at 06:53:09PM +0800, Yongji Xie wrote: We should not disable memory decoding when we reassign alignment in pci_reassigndev_resource_alignment(). It's meaningless and have some side effect. For example, some fixup func

Re: [PATCH v3 5/7] PCI: Do not use IORESOURCE_STARTALIGN to identify bridge resources

2016-07-01 Thread Yongji Xie
Hi Gavin, On 2016/7/1 10:34, Gavin Shan wrote: On Thu, Jun 30, 2016 at 06:53:11PM +0800, Yongji Xie wrote: Now we use the IORESOURCE_STARTALIGN to identify bridge resources in __assign_resources_sorted(). That's quite fragile. We may also set flag IORESOURCE_STARTALIGN for SR-IOV resourc

Re: [PATCH v3 4/7] PCI: Add a new option for resource_alignment to reassign alignment

2016-06-30 Thread Yongji Xie
Hi Gavin, On 2016/7/1 10:25, Gavin Shan wrote: On Thu, Jun 30, 2016 at 06:53:10PM +0800, Yongji Xie wrote: When using resource_alignment kernel parameter, the current implement reassigns the alignment by changing resources' size which can potentially break some drivers. For example

Re: [PATCH v3 2/7] PCI: Ignore enforced alignment to VF BARs

2016-06-30 Thread Yongji Xie
Hi Gavin, On 2016/7/1 14:05, Gavin Shan wrote: On Fri, Jul 01, 2016 at 01:27:17PM +0800, Yongji Xie wrote: On Thu, Jun 30, 2016 at 06:53:08PM +0800, Yongji Xie wrote: VF BARs are read-only zeroes according to SRIOV spec, the normal way(writing BARs) of allocating resources wouldn'

Re: [PATCH v3 2/7] PCI: Ignore enforced alignment to VF BARs

2016-06-30 Thread Yongji Xie
Hi Gavin, On 2016/7/1 8:39, Gavin Shan wrote: On Thu, Jun 30, 2016 at 06:53:08PM +0800, Yongji Xie wrote: VF BARs are read-only zeroes according to SRIOV spec, the normal way(writing BARs) of allocating resources wouldn't be applied to VFs. The VFs' resources would be allocated when

Re: [PATCH v3 1/7] PCI: Ignore enforced alignment when kernel uses existing firmware setup

2016-06-30 Thread Yongji Xie
Hi Gavin, On 2016/7/1 8:28, Gavin Shan wrote: On Thu, Jun 30, 2016 at 06:53:07PM +0800, Yongji Xie wrote: PCI resources allocator will use firmware setup and not try to reassign resource when PCI_PROBE_ONLY or IORESOURCE_PCI_FIXED is set. The enforced alignment in

[PATCH v3 7/7] PCI: Add a macro to set default alignment for all PCI devices

2016-06-30 Thread Yongji Xie
fault on some platforms such as PowerNV platform which would easily see those sub-page BARs because of its 64K page. To achieve that, we add a macro PCIBIOS_DEFAULT_ALIGNMENT to set default alignment for all PCI devices and define it on PowerNV platform. Signed-off-by: Yongji Xie --- arch/powerpc/incl

[PATCH v3 5/7] PCI: Do not use IORESOURCE_STARTALIGN to identify bridge resources

2016-06-30 Thread Yongji Xie
quot;. In this patch, we try to use a more robust way to identify bridge resources. Signed-off-by: Yongji Xie --- drivers/pci/setup-bus.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c index 55641a3..216ddbc 10064

[PATCH v3 3/7] PCI: Do not disable memory decoding in pci_reassigndev_resource_alignment()

2016-06-30 Thread Yongji Xie
obing. Signed-off-by: Yongji Xie --- drivers/pci/pci.c |8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 6ae02de..6241cfc 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -4820,7 +4820,6 @@

[PATCH v3 1/7] PCI: Ignore enforced alignment when kernel uses existing firmware setup

2016-06-30 Thread Yongji Xie
d not re-allocated. Signed-off-by: Yongji Xie --- drivers/pci/pci.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index c8b4dbd..be8f72c 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -4760,6 +4760,13 @@ static resource_s

[PATCH v3 2/7] PCI: Ignore enforced alignment to VF BARs

2016-06-30 Thread Yongji Xie
ngless and will release the allocated resources which leads to a bug. Signed-off-by: Yongji Xie --- drivers/pci/pci.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index be8f72c..6ae02de 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -

[PATCH v3 0/7] PCI: Add support for enforcing all MMIO BARs not to share PAGE_SIZE

2016-06-30 Thread Yongji Xie
g memory decoding when reassigning the alignment - Only enable default alignment on PowerNV platform Changelog v2: - Ignore enforced alignment to VF BARs on pci_reassigndev_resource_alignment() Yongji Xie (7): PCI: Ignore enforced alignment when kernel uses existing firmware setup PCI: Ignore

[PATCH v3 6/7] PCI: Add support for enforcing all MMIO BARs to be page aligned

2016-06-30 Thread Yongji Xie
lignment of all MMIO BARs to be at least PAGE_SIZE so that one BAR's mmio page would not be shared with other BARs. Signed-off-by: Yongji Xie --- Documentation/kernel-parameters.txt |2 ++ drivers/pci/pci.c | 60 --- 2 files changed,

[PATCH v3 4/7] PCI: Add a new option for resource_alignment to reassign alignment

2016-06-30 Thread Yongji Xie
ption "noresize" for the parameter to solve this problem. Signed-off-by: Yongji Xie --- Documentation/kernel-parameters.txt |5 - drivers/pci/pci.c | 35 +-- 2 files changed, 29 insertions(+), 11 deletions(-) diff --git a/Docum

[PATCH v5] vfio-pci: Allow to mmap sub-page MMIO BARs if the mmio page is exclusive

2016-06-30 Thread Yongji Xie
e BAR. And it's hard to access this BAR in userspace because we have no way to get the BAR's location in a page. Signed-off-by: Yongji Xie --- drivers/vfio/pci/vfio_pci.c | 88 --- drivers/vfio/pci/vfio_pci_private.h |8 2 files chang

Re: [PATCH v4] vfio-pci: Allow to mmap sub-page MMIO BARs if the mmio page is exclusive

2016-06-29 Thread Yongji Xie
On 2016/6/30 10:53, Alex Williamson wrote: On Thu, 30 Jun 2016 10:40:23 +0800 Yongji Xie wrote: Hi Alex, On 2016/6/30 4:03, Alex Williamson wrote: On Tue, 28 Jun 2016 13:47:23 -0600 Alex Williamson wrote: On Tue, 28 Jun 2016 18:09:46 +0800 Yongji Xie wrote: Hi, Alex On 2016/6

Re: [PATCH v4] vfio-pci: Allow to mmap sub-page MMIO BARs if the mmio page is exclusive

2016-06-29 Thread Yongji Xie
Hi Alex, On 2016/6/30 4:03, Alex Williamson wrote: On Tue, 28 Jun 2016 13:47:23 -0600 Alex Williamson wrote: On Tue, 28 Jun 2016 18:09:46 +0800 Yongji Xie wrote: Hi, Alex On 2016/6/25 0:43, Alex Williamson wrote: On Fri, 24 Jun 2016 23:37:02 +0800 Yongji Xie wrote: Hi, Alex

Re: [PATCH v4] vfio-pci: Allow to mmap sub-page MMIO BARs if the mmio page is exclusive

2016-06-28 Thread Yongji Xie
Hi, Alex On 2016/6/25 0:43, Alex Williamson wrote: On Fri, 24 Jun 2016 23:37:02 +0800 Yongji Xie wrote: Hi, Alex On 2016/6/24 11:37, Alex Williamson wrote: On Fri, 24 Jun 2016 10:52:58 +0800 Yongji Xie wrote: On 2016/6/24 0:12, Alex Williamson wrote: On Mon, 30 May 2016 21:06:37 +0800

Re: [PATCH v4] vfio-pci: Allow to mmap sub-page MMIO BARs if the mmio page is exclusive

2016-06-24 Thread Yongji Xie
Hi, Alex On 2016/6/24 11:37, Alex Williamson wrote: On Fri, 24 Jun 2016 10:52:58 +0800 Yongji Xie wrote: On 2016/6/24 0:12, Alex Williamson wrote: On Mon, 30 May 2016 21:06:37 +0800 Yongji Xie wrote: +static void vfio_pci_probe_mmaps(struct vfio_pci_device *vdev) +{ + struct

Re: [PATCH v4] vfio-pci: Allow to mmap sub-page MMIO BARs if the mmio page is exclusive

2016-06-23 Thread Yongji Xie
Hi, Alex On 2016/6/24 0:12, Alex Williamson wrote: On Mon, 30 May 2016 21:06:37 +0800 Yongji Xie wrote: Current vfio-pci implementation disallows to mmap sub-page(size < PAGE_SIZE) MMIO BARs because these BARs' mmio page may be shared with other BARs. This will cause some performanc

Re: [PATCH v4] vfio-pci: Allow to mmap sub-page MMIO BARs if the mmio page is exclusive

2016-06-22 Thread Yongji Xie
Hi, Alex On 2016/6/23 6:04, Alex Williamson wrote: On Mon, 30 May 2016 21:06:37 +0800 Yongji Xie wrote: Current vfio-pci implementation disallows to mmap sub-page(size < PAGE_SIZE) MMIO BARs because these BARs' mmio page may be shared with other BARs. This will cause some performanc

Re: [RESEND PATCH v2 1/4] PCI: Ignore resource_alignment if PCI_PROBE_ONLY was set\\

2016-06-21 Thread Yongji Xie
On 2016/6/21 10:16, Yongji Xie wrote: On 2016/6/21 9:43, Bjorn Helgaas wrote: On Thu, Jun 02, 2016 at 01:46:48PM +0800, Yongji Xie wrote: The resource_alignment will releases memory resources allocated by firmware so that kernel can reassign new resources later on. But this will cause the

Re: [RESEND PATCH v2 4/4] PCI: Add support for enforcing all MMIO BARs to be page aligned

2016-06-20 Thread Yongji Xie
On 2016/6/21 10:26, Bjorn Helgaas wrote: On Thu, Jun 02, 2016 at 01:46:51PM +0800, Yongji Xie wrote: When vfio passthrough a PCI device of which MMIO BARs are smaller than PAGE_SIZE, guest will not handle the mmio accesses to the BARs which leads to mmio emulations in host. This is because

Re: [RESEND PATCH v2 1/4] PCI: Ignore resource_alignment if PCI_PROBE_ONLY was set\\

2016-06-20 Thread Yongji Xie
On 2016/6/21 9:43, Bjorn Helgaas wrote: On Thu, Jun 02, 2016 at 01:46:48PM +0800, Yongji Xie wrote: The resource_alignment will releases memory resources allocated by firmware so that kernel can reassign new resources later on. But this will cause the problem that no resources can be allocated

Re: [RESEND PATCH v2 3/4] PCI: Add a new option for resource_alignment to reassign alignment

2016-06-20 Thread Yongji Xie
On 2016/6/21 9:57, Bjorn Helgaas wrote: On Thu, Jun 02, 2016 at 01:46:50PM +0800, Yongji Xie wrote: When using resource_alignment kernel parameter, the current implement reassigns the alignment by changing resources' size which can potentially break some drivers. For example, the driver

Re: [RESEND PATCH v2 2/4] PCI: Do not Use IORESOURCE_STARTALIGN to identify bridge resources

2016-06-20 Thread Yongji Xie
On 2016/6/21 9:50, Bjorn Helgaas wrote: On Thu, Jun 02, 2016 at 01:46:49PM +0800, Yongji Xie wrote: Now we use the IORESOURCE_STARTALIGN to identify bridge resources in __assign_resources_sorted(). That's quite fragile. We can't make sure that the PCI devices' resourc

Re: [RESEND PATCH v2 0/6] vfio-pci: Add support for mmapping MSI-X table

2016-06-08 Thread Yongji Xie
Hi, Eric On 2016/6/8 15:41, Auger Eric wrote: Hi Yongji, Le 02/06/2016 à 08:09, Yongji Xie a écrit : Current vfio-pci implementation disallows to mmap the page containing MSI-X table in case that users can write directly to MSI-X table and generate an incorrect MSIs. However, this will

Re: [RESEND PATCH v2 2/6] PCI: Set PCI_BUS_FLAGS_MSI_REMAP if MSI controller enables IRQ remapping

2016-06-06 Thread Yongji Xie
-ci/linux/commits/Yongji-Xie/PCI-Add-a-new-PCI_BUS_FLAGS_MSI_REMAP-flag/20160530-215348 base: https://github.com/awilliam/linux-vfio.git next config: arm-allmodconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 5.3.1-8) 5.3.1 20160205 reproduce: wget https

Re: [RESEND PATCH v2 2/6] PCI: Set PCI_BUS_FLAGS_MSI_REMAP if MSI controller enables IRQ remapping

2016-06-06 Thread Yongji Xie
-ci/linux/commits/Yongji-Xie/PCI-Add-a-new-PCI_BUS_FLAGS_MSI_REMAP-flag/20160530-215348 base: https://github.com/awilliam/linux-vfio.git next config: arm-sa1100 (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 5.3.1-8) 5.3.1 20160205 reproduce: wget https://git.kernel.org

Re: [RESEND PATCH v2 0/6] vfio-pci: Add support for mmapping MSI-X table

2016-06-02 Thread Yongji Xie
2016 14:09:57 +0800 Yongji Xie wrote: Current vfio-pci implementation disallows to mmap the page containing MSI-X table in case that users can write directly to MSI-X table and generate an incorrect MSIs. However, this will cause some performance issue when there are some critical device

[RESEND PATCH v2 1/6] PCI: Add a new PCI_BUS_FLAGS_MSI_REMAP flag

2016-06-01 Thread Yongji Xie
chs. With this flag enabled, we can easily know whether it's safe to expose MSI-X tables of PCI BARs to userspace. Some usespace drivers such as VFIO may benefit from this. [1] https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1138820.html Signed-off-by: Yongji Xie --- include/lin

[RESEND PATCH v2 2/6] PCI: Set PCI_BUS_FLAGS_MSI_REMAP if MSI controller enables IRQ remapping

2016-06-01 Thread Yongji Xie
. [1] https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1138820.html Signed-off-by: Yongji Xie --- drivers/pci/msi.c | 15 +++ drivers/pci/probe.c |3 +++ include/linux/msi.h |5 - 3 files changed, 22 insertions(+), 1 deletion(-) diff --git a/drivers/pci

[RESEND PATCH v2 6/6] vfio-pci: Allow to expose MSI-X table to userspace if interrupt remapping is enabled

2016-06-01 Thread Yongji Xie
directly. Signed-off-by: Yongji Xie --- drivers/vfio/pci/vfio_pci.c | 17 ++--- drivers/vfio/pci/vfio_pci_rdwr.c |3 ++- 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c index 188b1ff..6bae388 100644

[RESEND PATCH v2 0/6] vfio-pci: Add support for mmapping MSI-X table

2016-06-01 Thread Yongji Xie
://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1138820.html Yongji Xie (6): PCI: Add a new PCI_BUS_FLAGS_MSI_REMAP flag PCI: Set PCI_BUS_FLAGS_MSI_REMAP if MSI controller enables IRQ remapping PCI: Set PCI_BUS_FLAGS_MSI_REMAP if IOMMU have capability of IRQ remapping iommu: Set

[RESEND PATCH v2 4/6] iommu: Set PCI_BUS_FLAGS_MSI_REMAP on iommu driver initialization

2016-06-01 Thread Yongji Xie
Some iommu drivers would be initialized after PCI device enumeration. So PCI_BUS_FLAGS_MSI_REMAP would not be set when probing PCI devices although IOMMU enables capability of IRQ remapping. This patch tests this capability and set the flag when iommu driver is initialized. Signed-off-by: Yongji

[RESEND PATCH v2 5/6] pci-ioda: Set PCI_BUS_FLAGS_MSI_REMAP for IODA host bridge

2016-06-01 Thread Yongji Xie
Any IODA host bridge have the capability of IRQ remapping. So we set PCI_BUS_FLAGS_MSI_REMAP when this kind of host birdge is detected. Signed-off-by: Yongji Xie Reviewed-by: Alexey Kardashevskiy --- arch/powerpc/platforms/powernv/pci-ioda.c |8 1 file changed, 8 insertions

[RESEND PATCH v2 3/6] PCI: Set PCI_BUS_FLAGS_MSI_REMAP if IOMMU have capability of IRQ remapping

2016-06-01 Thread Yongji Xie
. Signed-off-by: Yongji Xie --- drivers/pci/probe.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index 2b9e3ba..15a33e2 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -16,6 +16,7 @@ #include #include #include +#include

[RESEND PATCH v2 1/4] PCI: Ignore resource_alignment if PCI_PROBE_ONLY was set

2016-06-01 Thread Yongji Xie
use firmware setup and not to reassign any resources. To solve this problem, this patch ignores resource_alignment if PCI_PROBE_ONLY was set. Signed-off-by: Yongji Xie --- drivers/pci/pci.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index

[RESEND PATCH v2 4/4] PCI: Add support for enforcing all MMIO BARs to be page aligned

2016-06-01 Thread Yongji Xie
ld not be applied to VFs whose BARs are always page aligned and should be never reassigned according to SRIOV spec. Signed-off-by: Yongji Xie --- Documentation/kernel-parameters.txt |2 ++ arch/powerpc/include/asm/pci.h |2 ++ drivers/pci/pci.c

[RESEND PATCH v2 3/4] PCI: Add a new option for resource_alignment to reassign alignment

2016-06-01 Thread Yongji Xie
ption "noresize" for the parameter to solve this problem. Signed-off-by: Yongji Xie --- Documentation/kernel-parameters.txt |5 - drivers/pci/pci.c | 35 +-- 2 files changed, 29 insertions(+), 11 deletions(-) diff --git a/Docum

[RESEND PATCH v2 2/4] PCI: Do not Use IORESOURCE_STARTALIGN to identify bridge resources

2016-06-01 Thread Yongji Xie
ridge resources. Signed-off-by: Yongji Xie --- drivers/pci/setup-bus.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c index 55641a3..216ddbc 100644 --- a/drivers/pci/setup-bus.c +++ b/drivers/pci/setup-bus.c @@ -390,6 +

[RESEND PATCH v2 0/4] PCI: Add support for enforcing all MMIO BARs not to share PAGE_SIZE

2016-06-01 Thread Yongji Xie
PCI BARs; patch 4 modified resource_alignment to support syntax which can be used to enforce the alignment of all MMIO BARs to be at least PAGE_SIZE. Changelog v2: - Ignore enforced alignment to VF BARs on pci_reassigndev_resource_alignment() Yongji Xie (4): PCI: Ignore resource_alig

[PATCH v2 5/6] pci-ioda: Set PCI_BUS_FLAGS_MSI_REMAP for IODA host bridge

2016-05-30 Thread Yongji Xie
Any IODA host bridge have the capability of IRQ remapping. So we set PCI_BUS_FLAGS_MSI_REMAP when this kind of host birdge is detected. Signed-off-by: Yongji Xie Reviewed-by: Alexey Kardashevskiy --- arch/powerpc/platforms/powernv/pci-ioda.c |8 1 file changed, 8 insertions

[PATCH v2 6/6] vfio-pci: Allow to expose MSI-X table to userspace if interrupt remapping is enabled

2016-05-30 Thread Yongji Xie
directly. Signed-off-by: Yongji Xie --- drivers/vfio/pci/vfio_pci.c | 17 ++--- drivers/vfio/pci/vfio_pci_rdwr.c |3 ++- 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c index 188b1ff..6bae388 100644

[PATCH v2 4/6] iommu: Set PCI_BUS_FLAGS_MSI_REMAP on iommu driver initialization

2016-05-30 Thread Yongji Xie
Some iommu drivers would be initialized after PCI device enumeration. So PCI_BUS_FLAGS_MSI_REMAP would not be set when probing PCI devices although IOMMU enables capability of IRQ remapping. This patch tests this capability and set the flag when iommu driver is initialized. Signed-off-by: Yongji

[PATCH v2 2/6] PCI: Set PCI_BUS_FLAGS_MSI_REMAP if MSI controller enables IRQ remapping

2016-05-30 Thread Yongji Xie
. [1] https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1138820.html Signed-off-by: Yongji Xie --- drivers/pci/msi.c | 15 +++ drivers/pci/probe.c |3 +++ include/linux/msi.h |5 - 3 files changed, 22 insertions(+), 1 deletion(-) diff --git a/drivers/pci

[PATCH v2 0/6] vfio-pci: Add support for mmapping MSI-X table

2016-05-30 Thread Yongji Xie
://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1138820.html Yongji Xie (6): PCI: Add a new PCI_BUS_FLAGS_MSI_REMAP flag PCI: Set PCI_BUS_FLAGS_MSI_REMAP if MSI controller enables IRQ remapping PCI: Set PCI_BUS_FLAGS_MSI_REMAP if IOMMU have capability of IRQ remapping iommu: Set

[PATCH v2 1/6] PCI: Add a new PCI_BUS_FLAGS_MSI_REMAP flag

2016-05-30 Thread Yongji Xie
chs. With this flag enabled, we can easily know whether it's safe to expose MSI-X tables of PCI BARs to userspace. Some usespace drivers such as VFIO may benefit from this. [1] https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1138820.html Signed-off-by: Yongji Xie --- include/lin

[PATCH v2 3/6] PCI: Set PCI_BUS_FLAGS_MSI_REMAP if IOMMU have capability of IRQ remapping

2016-05-30 Thread Yongji Xie
. Signed-off-by: Yongji Xie --- drivers/pci/probe.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index 2b9e3ba..15a33e2 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -16,6 +16,7 @@ #include #include #include +#include

[PATCH v4] vfio-pci: Allow to mmap sub-page MMIO BARs if the mmio page is exclusive

2016-05-30 Thread Yongji Xie
e BAR. And it's hard to access this BAR in userspace because we have no way to get the BAR's location in a page. Signed-off-by: Yongji Xie --- drivers/vfio/pci/vfio_pci.c | 87 --- drivers/vfio/pci/vfio_pci_private.h |8 2 files chang

[PATCH v2 4/4] PCI: Add support for enforcing all MMIO BARs to be page aligned

2016-05-30 Thread Yongji Xie
ld not be applied to VFs whose BARs are always page aligned and should be never reassigned according to SRIOV spec. Signed-off-by: Yongji Xie --- Documentation/kernel-parameters.txt |2 ++ arch/powerpc/include/asm/pci.h |2 ++ drivers/pci/pci.c

[PATCH v2 3/4] PCI: Add a new option for resource_alignment to reassign alignment

2016-05-30 Thread Yongji Xie
ption "noresize" for the parameter to solve this problem. Signed-off-by: Yongji Xie --- Documentation/kernel-parameters.txt |5 - drivers/pci/pci.c | 35 +-- 2 files changed, 29 insertions(+), 11 deletions(-) diff --git a/Docum

[PATCH v2 1/4] PCI: Ignore resource_alignment if PCI_PROBE_ONLY was set

2016-05-30 Thread Yongji Xie
use firmware setup and not to reassign any resources. To solve this problem, this patch ignores resource_alignment if PCI_PROBE_ONLY was set. Signed-off-by: Yongji Xie --- drivers/pci/pci.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index

[PATCH v2 0/4] PCI: Add support for enforcing all MMIO BARs not to share PAGE_SIZE

2016-05-30 Thread Yongji Xie
PCI BARs; patch 4 modified resource_alignment to support syntax which can be used to enforce the alignment of all MMIO BARs to be at least PAGE_SIZE. Changelog v2: - Ignore enforced alignment to VF BARs on pci_reassigndev_resource_alignment() Yongji Xie (4): PCI: Ignore resource_alig

[PATCH v2 2/4] PCI: Do not Use IORESOURCE_STARTALIGN to identify bridge resources

2016-05-30 Thread Yongji Xie
ridge resources. Signed-off-by: Yongji Xie --- drivers/pci/setup-bus.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c index 55641a3..216ddbc 100644 --- a/drivers/pci/setup-bus.c +++ b/drivers/pci/setup-bus.c @@ -390,6 +

Re: [PATCH 2/5] iommu: Set PCI_BUS_FLAGS_MSI_REMAP if IOMMU have capability of IRQ remapping

2016-05-24 Thread Yongji Xie
On 2016/5/25 5:11, Bjorn Helgaas wrote: On Wed, Apr 27, 2016 at 08:43:27PM +0800, Yongji Xie wrote: The capability of IRQ remapping is abstracted on IOMMU side on some archs. There is a existing flag IOMMU_CAP_INTR_REMAP for this. To have a universal flag to test this capability for different

Re: [PATCH 3/5] PCI: Set PCI_BUS_FLAGS_MSI_REMAP if MSI controller supports IRQ remapping

2016-05-24 Thread Yongji Xie
On 2016/5/25 5:04, Bjorn Helgaas wrote: On Wed, Apr 27, 2016 at 08:43:28PM +0800, Yongji Xie wrote: On ARM HW the capability of IRQ remapping is abstracted on MSI controller side. MSI_FLAG_IRQ_REMAPPING is used to advertise this [1]. To have a universal flag to test this capability for

Re: [PATCH 1/5] PCI: Add a new PCI_BUS_FLAGS_MSI_REMAP flag

2016-05-24 Thread Yongji Xie
On 2016/5/25 4:55, Bjorn Helgaas wrote: On Wed, Apr 27, 2016 at 08:43:26PM +0800, Yongji Xie wrote: We introduce a new pci_bus_flags, PCI_BUS_FLAGS_MSI_REMAP which indicates all devices on the bus are protected by the hardware which supports IRQ remapping(intel naming). This changelog is

Re: [PATCH v3] vfio-pci: Allow to mmap sub-page MMIO BARs if the mmio page is exclusive

2016-05-24 Thread Yongji Xie
On 2016/5/23 23:20, Alex Williamson wrote: On Mon, 23 May 2016 11:45:34 +0800 Yongji Xie wrote: On 2016/5/20 6:33, Alex Williamson wrote: On Thu, 12 May 2016 18:20:51 +0800 Yongji Xie wrote: Current vfio-pci implementation disallows to mmap sub-page(size < PAGE_SIZE) MMIO BARs beca

Re: [PATCH v3] vfio-pci: Allow to mmap sub-page MMIO BARs if the mmio page is exclusive

2016-05-23 Thread Yongji Xie
On 2016/5/20 6:33, Alex Williamson wrote: On Thu, 12 May 2016 18:20:51 +0800 Yongji Xie wrote: Current vfio-pci implementation disallows to mmap sub-page(size < PAGE_SIZE) MMIO BARs because these BARs' mmio page may be shared with other BARs. This will cause some performance issues

[PATCH v3] vfio-pci: Allow to mmap sub-page MMIO BARs if the mmio page is exclusive

2016-05-12 Thread Yongji Xie
e BAR. And it's hard to access this BAR in userspace because we have no way to get the BAR's location in a page. Signed-off-by: Yongji Xie --- drivers/vfio/pci/vfio_pci.c | 70 +++ drivers/vfio/pci/vfio_pci_private.h |8 2 files chang

Re: [PATCH v2] vfio-pci: Allow to mmap sub-page MMIO BARs if the mmio page is exclusive

2016-05-11 Thread Yongji Xie
On 2016/5/11 23:10, Bjorn Helgaas wrote: On Wed, May 11, 2016 at 07:34:19PM +0800, Yongji Xie wrote: Current vfio-pci implementation disallows to mmap sub-page(size < PAGE_SIZE) MMIO BARs because these BARs' mmio page may be shared with other BARs. This will cause some performance iss

[PATCH v2] vfio-pci: Allow to mmap sub-page MMIO BARs if the mmio page is exclusive

2016-05-11 Thread Yongji Xie
esources to reserve the remaind of the page which hot-add device's BAR might be assigned into. Signed-off-by: Yongji Xie --- drivers/vfio/pci/vfio_pci.c | 85 --- drivers/vfio/pci/vfio_pci_private.h |8 2 files changed, 86 insertions(+)

Re: [PATCH 5/5] vfio-pci: Allow to mmap MSI-X table if interrupt remapping is supported

2016-05-05 Thread Yongji Xie
On 2016/5/5 20:15, Tian, Kevin wrote: From: Yongji Xie [mailto:xyj...@linux.vnet.ibm.com] Sent: Thursday, May 05, 2016 7:43 PM Hi David and Kevin, On 2016/5/5 17:54, David Laight wrote: From: Tian, Kevin Sent: 05 May 2016 10:37 ... Acutually, we are not aimed at accessing MSI-X table

Re: [PATCH 5/5] vfio-pci: Allow to mmap MSI-X table if interrupt remapping is supported

2016-05-05 Thread Yongji Xie
On 2016/5/5 17:36, Tian, Kevin wrote: From: Yongji Xie Sent: Tuesday, May 03, 2016 3:34 PM On 2016/5/3 14:22, Tian, Kevin wrote: From: Yongji Xie [mailto:xyj...@linux.vnet.ibm.com] Sent: Tuesday, May 03, 2016 2:08 PM On 2016/5/3 13:34, Tian, Kevin wrote: From: Yongji Xie Sent: Wednesday

Re: [PATCH 5/5] vfio-pci: Allow to mmap MSI-X table if interrupt remapping is supported

2016-05-05 Thread Yongji Xie
Hi David and Kevin, On 2016/5/5 17:54, David Laight wrote: From: Tian, Kevin Sent: 05 May 2016 10:37 ... Acutually, we are not aimed at accessing MSI-X table from guest. So I think it's safe to passthrough MSI-X table if we can make sure guest kernel would not touch MSI-X table in normal cod

Re: [PATCH] vfio-pci: Allow to mmap sub-page MMIO BARs if the mmio page is exclusive

2016-05-03 Thread Yongji Xie
On 2016/5/3 14:11, Tian, Kevin wrote: From: Yongji Xie [mailto:xyj...@linux.vnet.ibm.com] Sent: Tuesday, May 03, 2016 1:52 PM + + if (!(res->start & ~PAGE_MASK)) { + /* +* Add shadow resource for sub-page bar who

Re: [PATCH 5/5] vfio-pci: Allow to mmap MSI-X table if interrupt remapping is supported

2016-05-03 Thread Yongji Xie
On 2016/5/3 14:22, Tian, Kevin wrote: From: Yongji Xie [mailto:xyj...@linux.vnet.ibm.com] Sent: Tuesday, May 03, 2016 2:08 PM On 2016/5/3 13:34, Tian, Kevin wrote: From: Yongji Xie Sent: Wednesday, April 27, 2016 8:43 PM This patch enables mmapping MSI-X tables if hardware supports

Re: [PATCH 5/5] vfio-pci: Allow to mmap MSI-X table if interrupt remapping is supported

2016-05-02 Thread Yongji Xie
On 2016/5/3 13:34, Tian, Kevin wrote: From: Yongji Xie Sent: Wednesday, April 27, 2016 8:43 PM This patch enables mmapping MSI-X tables if hardware supports interrupt remapping which can ensure that a given pci device can only shoot the MSIs assigned for it. With MSI-X table mmapped, we also

Re: [PATCH] vfio-pci: Allow to mmap sub-page MMIO BARs if the mmio page is exclusive

2016-05-02 Thread Yongji Xie
On 2016/5/3 10:59, Tian, Kevin wrote: From: Yongji Xie Sent: Wednesday, April 27, 2016 8:22 PM Current vfio-pci implementation disallows to mmap sub-page(size < PAGE_SIZE) MMIO BARs because these BARs' mmio page may be shared with other BARs. This will cause some performance issues

[PATCH 5/5] vfio-pci: Allow to mmap MSI-X table if interrupt remapping is supported

2016-04-27 Thread Yongji Xie
: Yongji Xie --- drivers/vfio/pci/vfio_pci.c |7 +-- drivers/vfio/pci/vfio_pci_rdwr.c |3 ++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c index 98059df..7eba77d 100644 --- a/drivers/vfio/pci/vfio_pci.c +++ b

[PATCH 3/5] PCI: Set PCI_BUS_FLAGS_MSI_REMAP if MSI controller supports IRQ remapping

2016-04-27 Thread Yongji Xie
. [1] http://www.spinics.net/lists/kvm/msg130256.html Signed-off-by: Yongji Xie --- drivers/pci/msi.c | 12 drivers/pci/probe.c |3 +++ include/linux/msi.h |6 +- 3 files changed, 20 insertions(+), 1 deletion(-) diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c index

[PATCH 1/5] PCI: Add a new PCI_BUS_FLAGS_MSI_REMAP flag

2016-04-27 Thread Yongji Xie
ists/kvm/msg130256.html Signed-off-by: Yongji Xie --- include/linux/pci.h |1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/pci.h b/include/linux/pci.h index 27df4a6..d619228 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -193,6 +193,7 @@ typedef unsigned short _

[PATCH 4/5] pci-ioda: Set PCI_BUS_FLAGS_MSI_REMAP for IODA host bridge

2016-04-27 Thread Yongji Xie
Any IODA host bridge have the capability of IRQ remapping. So we set PCI_BUS_FLAGS_MSI_REMAP when this kind of host birdge is detected. Signed-off-by: Yongji Xie --- arch/powerpc/platforms/powernv/pci-ioda.c |8 1 file changed, 8 insertions(+) diff --git a/arch/powerpc/platforms

[PATCH 0/5] vfio-pci: Add support for mmapping MSI-X table

2016-04-27 Thread Yongji Xie
we introduce a new bus_flags PCI_BUS_FLAGS_MSI_REMAP to test this capability on PCI side for different archs. The patch 3 are based on the proposed patchset[1]. [1] http://www.spinics.net/lists/kvm/msg130256.html Yongji Xie (5): PCI: Add a new PCI_BUS_FLAGS_MSI_REMAP flag iommu: Set

[PATCH 2/5] iommu: Set PCI_BUS_FLAGS_MSI_REMAP if IOMMU have capability of IRQ remapping

2016-04-27 Thread Yongji Xie
. Signed-off-by: Yongji Xie --- drivers/iommu/iommu.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c index 0e3b009..5d2b6f6 100644 --- a/drivers/iommu/iommu.c +++ b/drivers/iommu/iommu.c @@ -813,6 +813,16 @@ struct iommu_group

[PATCH] vfio-pci: Allow to mmap sub-page MMIO BARs if the mmio page is exclusive

2016-04-27 Thread Yongji Xie
shadow resource to reserve the remaind of the page which hot-add device's BAR might be assigned into. Signed-off-by: Yongji Xie --- drivers/vfio/pci/vfio_pci.c | 58 ++- drivers/vfio/pci/vfio_pci_private.h |8 + 2 files changed, 59 insertions(+)

[PATCH 2/4] PCI: Do not Use IORESOURCE_STARTALIGN to identify bridge resources

2016-04-27 Thread Yongji Xie
ridge resources. Signed-off-by: Yongji Xie --- drivers/pci/setup-bus.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c index 55641a3..216ddbc 100644 --- a/drivers/pci/setup-bus.c +++ b/drivers/pci/setup-bus.c @@ -390,6 +

[PATCH 0/4] PCI: Add support for enforcing all MMIO BARs not to share PAGE_SIZE

2016-04-27 Thread Yongji Xie
PCI BARs; patch 4 modified resource_alignment to support syntax which can be used to enforce the alignment of all MMIO BARs to be at least PAGE_SIZE. Yongji Xie (4): PCI: Ignore resource_alignment if PCI_PROBE_ONLY was set PCI: Do not Use IORESOURCE_STARTALIGN to identify bridge resources PCI: A

[PATCH 3/4] PCI: Add a new option for resource_alignment to reassign alignment

2016-04-27 Thread Yongji Xie
ption "noresize" for the parameter to solve this problem. Signed-off-by: Yongji Xie --- Documentation/kernel-parameters.txt |5 - drivers/pci/pci.c | 35 +-- 2 files changed, 29 insertions(+), 11 deletions(-) diff --git a/Docum

[PATCH 4/4] PCI: Add support for enforcing all MMIO BARs to be page aligned

2016-04-27 Thread Yongji Xie
to enforce the alignment of all MMIO BARs to be at least PAGE_SIZE so that one BAR's mmio page would not be shared with other BARs. And we also define a macro PCIBIOS_MIN_ALIGNMENT to enable this automatically on PPC64 platform which can easily hit this issue because its PAGE_SIZE is 64KB. S

[PATCH 1/4] PCI: Ignore resource_alignment if PCI_PROBE_ONLY was set

2016-04-27 Thread Yongji Xie
use firmware setup and not to reassign any resources. To solve this problem, this patch ignores resource_alignment if PCI_PROBE_ONLY was set. Signed-off-by: Yongji Xie --- drivers/pci/pci.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index

Re: [RFC v6 00/10] vfio-pci: Allow to mmap sub-page MMIO BARs and MSI-X table

2016-04-26 Thread Yongji Xie
On 2016/4/27 0:40, Alex Williamson wrote: On Mon, 25 Apr 2016 18:05:53 +0800 Yongji Xie wrote: Hi Alex, Any comment? TBH, I shuffled this to the bottom of the review pile because you're depending on a patch series for ARM MSI mapping that's still very much in flux. You've

Re: [RFC v6 04/10] PCI: Add support for enforcing all MMIO BARs to be page aligned

2016-04-25 Thread Yongji Xie
On 2016/4/26 13:41, Alexey Kardashevskiy wrote: On 04/18/2016 08:56 PM, Yongji Xie wrote: When vfio passthrough a PCI device of which MMIO BARs are smaller than PAGE_SIZE, guest will not handle the mmio accesses to the BARs which leads to mmio emulations in host. This is because vfio will not

  1   2   >