RE: Re: [PATCH] mm, oom_adj: avoid meaningless loop to find processes sharing mm

2018-10-08 Thread Yong-Taek Lee
> >On 2018/10/08 15:14, Yong-Taek Lee wrote: >>> On 2018/10/08 10:19, Yong-Taek Lee wrote: >>>> @@ -1056,6 +1056,7 @@ static int __set_oom_adj(struct file *file, int >>>> oom_adj, bool legacy) >>>> struct mm_struct *mm = NULL; >>

RE: Re: [PATCH] mm, oom_adj: avoid meaningless loop to find processes sharing mm

2018-10-07 Thread Yong-Taek Lee
>On 2018/10/08 10:19, Yong-Taek Lee wrote: >> @@ -1056,6 +1056,7 @@ static int __set_oom_adj(struct file *file, int >> oom_adj, bool legacy) >> struct mm_struct *mm = NULL; >> struct task_struct *task; >> int err = 0; >> +

[PATCH] mm, oom_adj: avoid meaningless loop to find processes sharing mm

2018-10-07 Thread Yong-Taek Lee
It is introduced by commit 44a70adec910 ("mm, oom_adj: make sure processes sharing mm have same view of oom_score_adj"). Most of user process's mm_users is bigger than 1 but only one thread group. In this case, for_each_process loop meaninglessly try to find processes which sharing same mm even tho