[PATCH v2 1/1] net: Fix use of proc_fs

2020-12-14 Thread Yonatan Linik
not checked before, so everything was working even when CONFIG_PROC_FS=n. The fix here is simply to add the necessary #ifdef. This also fixes a similar error in tls_proc.c, that was found by Jakub Kicinski. Signed-off-by: Yonatan Linik --- net/packet/af_packet.c | 2 ++ net/tls/tls_proc.c |

[PATCH v2 0/1] net: Fix use of proc_fs

2020-12-14 Thread Yonatan Linik
similar error in tls_proc.c, found by Jakub Kicinski. Yonatan Linik (1): net: Fix use of proc_fs net/packet/af_packet.c | 2 ++ net/tls/tls_proc.c | 3 +++ 2 files changed, 5 insertions(+) base-commit: bbf5c979011a099af5dc76498918ed7df445635b -- 2.25.1

Re: [PATCH 1/1] net: Fix use of proc_fs

2020-12-13 Thread Yonatan Linik
On Sat, Dec 12, 2020 at 11:51 PM Jakub Kicinski wrote: > > On Sat, 12 Dec 2020 23:39:20 +0200 Yonatan Linik wrote: > > On Sat, Dec 12, 2020 at 9:48 PM Jakub Kicinski wrote: > > > > > > On Fri, 11 Dec 2020 18:37:49 +0200 Yonatan Linik wrote: > > > >

Re: [PATCH 1/1] net: Fix use of proc_fs

2020-12-12 Thread Yonatan Linik
On Sat, Dec 12, 2020 at 9:48 PM Jakub Kicinski wrote: > > On Fri, 11 Dec 2020 18:37:49 +0200 Yonatan Linik wrote: > > proc_fs was used, in af_packet, without a surrounding #ifdef, > > although there is no hard dependency on proc_fs. > > That caused the initialization of

Re: [PATCH 1/1] net: Fix use of proc_fs

2020-12-12 Thread Yonatan Linik
e changes to the way it behaved when procfs was enabled. If you decide that's a better solution I will happily change it. -- Yonatan Linik

[PATCH 0/1] net: Fix use of proc_fs

2020-12-11 Thread Yonatan Linik
This patch fixes the failure of af_packet module initialization when CONFIG_PROC_FS=n. The commit message itself has a pretty thorough explanation. I will just add that I made sure this fixes the problem, both by using socket from userspace and by looking at kernel logs. Yonatan Linik (1): net

[PATCH 1/1] net: Fix use of proc_fs

2020-12-11 Thread Yonatan Linik
not checked before, so everything was working even when CONFIG_PROC_FS=n. The fix here is simply to add the necessary #ifdef. Signed-off-by: Yonatan Linik --- net/packet/af_packet.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index 2b3