On Mon, 2020-11-09 at 10:03 +0800, Weiyi Lu wrote:
> Add MT8192 imp i2c wrapper clock provider
>
> Signed-off-by: Weiyi Lu
> ---
> drivers/clk/mediatek/Kconfig | 6 ++
> drivers/clk/mediatek/Makefile | 1 +
> drivers/clk/mediatek/clk-mt8192-imp_iic_wrap.c |
On Thu, 2020-10-22 at 20:37 +0800, Weiyi Lu wrote:
> Add MT8192 imp i2c wrapper c clock provider
>
> Signed-off-by: Weiyi Lu
> ---
> drivers/clk/mediatek/Kconfig | 6 +++
> drivers/clk/mediatek/Makefile| 1 +
> drivers/clk/mediatek/clk-mt8192-imp_iic_wra
On Fri, 2020-09-25 at 14:54 +0800, Ikjoon Jang wrote:
> This patch enables 36bit dma address support to spi-mtk-nor.
> Currently this is enabled only for mt8192-nor.
>
> Signed-off-by: Ikjoon Jang
> ---
>
> (no changes since v1)
>
> drivers/spi/spi-mtk-nor.c | 18 +-
> 1 file c
On Fri, 2020-09-18 at 16:31 +0800, Ikjoon Jang wrote:
> This patch enables 36bit dma address support to spi-mtk-nor.
> Currently 36bit dma addressing is enabled only for mt8192-nor.
>
> Signed-off-by: Ikjoon Jang
> ---
>
> (no changes since v1)
>
> drivers/spi/spi-mtk-nor.c | 19 ++
eric definitions for bus
frequencies". You should have
Fixes: 90224e6468e1 ("i2c: drivers: Use generic definitions for bus
frequencies")
You can have my reviewed by after you add fixes.
Reviewed-by: Yingjoe Chen
Joe.C
>
> Signed-off-by: Qii Wang
> ---
> drive
On Wed, 2020-08-12 at 15:13 -0700, Dmitry Torokhov wrote:
> Hi,
>
> On Tue, Aug 11, 2020 at 09:47:23AM +0800, Yingjoe Chen wrote:
> > Hi,
> >
> >
> > On Mon, 2020-08-10 at 14:40 +0800, Fengping Yu wrote:
> > > From: "fengping.yu"
> >
Hi,
On Mon, 2020-08-10 at 14:40 +0800, Fengping Yu wrote:
> From: "fengping.yu"
>
> This patch add devicetree bindings for Mediatek matrix keypad driver.
>
> Signed-off-by: fengping.yu
> ---
> .../devicetree/bindings/input/mtk-kpd.yaml| 87 +++
> 1 file changed, 87 insert
On Mon, 2020-08-03 at 14:15 +0800, Crystal Guo wrote:
> Introduce force-update method for assert and deassert interface,
> which force the write operation in case the read already happens
> to return the correct value.
>
> Signed-off-by: Crystal Guo
> ---
> drivers/reset/reset-ti-syscon.c | 15 +
On Tue, 2020-08-04 at 10:15 +0200, Philipp Zabel wrote:
> On Mon, 2020-08-03 at 14:15 +0800, Crystal Guo wrote:
> > The TI syscon reset controller provides a common reset management,
> > and should be suitable for other SOCs. Add compatible "generic-reset",
> > which denotes to use a common reset-c
Hi,
Summary should specified this patch is for MediaTek:
dt-bindings: add MediaTek keypad devicetree documentation
On Mon, 2020-07-27 at 19:45 +0800, Fengping Yu wrote:
> From: "fengping.yu"
> Add Mediatek matrix keypad dt-bindings doc as yaml schema.
>
> Signed-off-by: fengping.yu
> ---
>
you can have:
Reviewed-by: Yingjoe Chen
Joe.C
On Wed, 2020-07-22 at 20:31 +0800, Qii Wang wrote:
> With the apdma remove hand-shake signal, it need to keep i2c and
> apdma in sync manually.
>
Looks good to me,
Reviewed-by: Yingjoe Chen
Just a reminder, we have another patch 'i2c: mediatek: Add to support
continuous mode
On Wed, 2020-07-22 at 20:31 +0800, Qii Wang wrote:
> Replace 'support_33bits with 'dma_max_support' for DMA mask
> operation, and replace 'mtk_i2c_set_4g_mode' with 'upper_32_bits'.
This doesn't explain why we need this patch. How about:
Newer MTK chip support more than 8GB of dram. Replace suppo
On Fri, 2020-07-03 at 12:41 +0800, Chao Hao wrote:
> Given the fact that we are adding more and more plat_data bool values,
> it would make sense to use a u32 flags register and add the appropriate
> macro definitions to set and check for a flag present.
> No functional change.
>
> Cc: Yong Wu
>
Hi Qiangming,
When you send new version, you should
- Add version number in subject, so we know this is a new one.
- List what's changed in this patch after ---, so reviewer knows where
we should check.
On Tue, 2020-06-23 at 15:42 +0800, Qiangming Xia wrote:
> From: "qiangming.xia"
>
>
Sorry for late review.
On Thu, 2020-05-14 at 21:09 +0800, Qii Wang wrote:
> This patch adds a algorithm to calculate some ac-timing parameters
> which can fully meet I2C Spec.
>
> Signed-off-by: Qii Wang
> ---
> drivers/i2c/busses/i2c-mt65xx.c | 328
> +---
On Fri, 2020-06-19 at 16:06 +0800, Qiangming Xia wrote:
> From: "qiangming.xia"
Please make 'From:' the same to Signed-off-by.
> Mediatek i2c controller support for continuous mode,
> it allow to transfer once multiple writing messages of equal length.
So the limitations are writing to s
On Fri, 2020-05-15 at 14:40 +0300, Andy Shevchenko wrote:
> On Fri, May 15, 2020 at 11:30:16AM +0200, Marco Felsch wrote:
> > On 20-05-15 14:20, Fengping Yu wrote:
>
> ...
>
> > > + depends on OF && HAVE_CLK
> >
> > Please drop those deps and instead use:
>
> +1
>
> > depends on ARCH_MEDIATEK
On Thu, 2019-08-22 at 13:57 +0800, Hsin-Yi Wang wrote:
> When doing i2cdetect quick write mode, we would get transfer
> error ENOMEM, and i2cdetect shows there's no device at the address.
> Quoting from mt8183 datasheet, the number of transfers to be
> transferred in one transaction should be set t
On Thu, 2019-08-22 at 14:58 +0800, Sam Shih wrote:
> This updates bindings for MT7628 pwm controller.
>
> Signed-off-by: Sam Shih
> ---
> Documentation/devicetree/bindings/pwm/pwm-mediatek.txt | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pwm/pwm
On Wed, 2019-07-03 at 01:42 -0700, Joe Perches wrote:
> On Wed, 2019-07-03 at 16:30 +0800, Miles Chen wrote:
> > This change reports a warning when "default n" is used.
> >
> > I have seen several "remove default n" patches, so I think
> > it might be helpful to add this test in checkpatch.
> >
>
On Wed, 2019-07-03 at 01:42 -0700, Joe Perches wrote:
> On Wed, 2019-07-03 at 16:30 +0800, Miles Chen wrote:
> > This change reports a warning when "default n" is used.
> >
> > I have seen several "remove default n" patches, so I think
> > it might be helpful to add this test in checkpatch.
> >
>
If I2C_M_RECV_LEN check failed, msgs[i].buf allocated by memdup_user
will not be freed. Pump index up so it will be freed.
Fixes: 838bfa6049fb ("i2c-dev: Add support for I2C_M_RECV_LEN")
Signed-off-by: Yingjoe Chen
---
Only check arm64 defconfig build pass.
I haven't test it si
ruct mt6397_rtc *rtc;
> + const struct of_device_id *of_id;
> int ret;
>
> rtc = devm_kzalloc(&pdev->dev, sizeof(struct mt6397_rtc), GFP_KERNEL);
> @@ -341,6 +367,13 @@ static int mtk_rtc_probe(struct platform_device *pdev)
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> rtc->addr_base = res->start;
>
> + of_id = of_match_device(mt6397_rtc_of_match, &pdev->dev);
> + if (!of_id) {
This will never happens, but I'm fine with it.
Review-by: Yingjoe Chen
Joe.C
On Mon, 2019-04-29 at 11:25 +0800, Nicolas Boichat wrote:
> pinctrl variants that include pinctrl-mtk-common-v2.h (and not
> pinctrl-mtk-common.h) also need to use mtk_eint_pm_ops to setup
> wake mask properly, so copy over the pm_ops to v2.
>
> It is not easy to merge the 2 copies (or move
> mtk_
On Sat, 2019-03-23 at 22:15 +0100, Fabien Parent wrote:
> 'top_base' memory region is optional. Check that the resource is valid
> before using it. This avoid getting a "invalid resource" error message
> printed by the kernel.
>
> Signed-off-by: Fabien Parent
> ---
> drivers/mmc/host/mtk-sd.c |
Hi,
Should use 'rtc: mt6397: ' as prefix for this patch.
On Mon, 2019-03-11 at 11:46 +0800, Hsin-Hsiung Wang wrote:
> From: Ran Bi
>
> This add support for the MediaTek MT6358 RTC. MT6397 mfd will pass
> RTC_WRTGR address offset to RTC driver.
>
> Signed-off-by: Ran Bi
> ---
> drivers/rt
On Mon, 2018-12-17 at 11:15 +0800, Chuanjia Liu wrote:
> On Thu, 2018-12-13 at 11:33 -0800, Sean Wang wrote:
> > On Thu, Dec 13, 2018 at 1:36 AM wrote:
> > >
> > > From: Chuanjia Liu
> > >
> > > This patch add gpio vritual number select,avoid virtual gpio set SMT.
> >
> > s/gpio/GPIO/
> > s/vrit
On Tue, 2018-12-11 at 13:37 +0800, Long Cheng wrote:
> 1. add uart APDMA controller device node
> 2. add uart 0/1/2/3/4/5 DMA function
>
> Signed-off-by: Long Cheng
> ---
> arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 50
> +
> 1 file changed, 50 insertions(+)
>
>
On Wed, 2018-11-07 at 23:18 +0530, Manivannan Sadhasivam wrote:
> Add devicetree bindings for Mediatek MT6797 SoC Pin Controller.
>
> Signed-off-by: Manivannan Sadhasivam
> ---
> .../bindings/pinctrl/pinctrl-mt6797.txt | 83 +
> include/dt-bindings/pinctrl/mt6797-pinfunc.h | 1368 ++
On Wed, 2018-08-08 at 22:57 +0200, Wolfram Sang wrote:
> On Sat, Jul 07, 2018 at 05:29:54PM +0800, Jun Gao wrote:
> > From: Jun Gao
> >
> > This function is needed by i2c_get_dma_safe_msg_buf() potentially.
> > It is used to free DMA safe buffer when DMA operation fails.
> >
> > Signed-off-by: J
Sean,
Looks good to me. You can add if you want:
Reviewed-by: Yingjoe Chen
Joe.C
On Mon, 2017-10-23 at 15:16 +0800, sean.w...@mediatek.com wrote:
> From: Sean Wang
>
> This patch introduces the driver for the RTC on MT7622 SoC.
>
> Signed-off-by: Sean Wang
> ---
>
On Tue, 2017-10-17 at 17:40 +0800, sean.w...@mediatek.com wrote:
> From: Sean Wang
>
> Add device-tree binding for MediaTek SoC based RTC
>
> Cc: devicet...@vger.kernel.org
> Signed-off-by: Sean Wang
> Acked-by: Rob Herring
> ---
> .../devicetree/bindings/rtc/rtc-mediatek.txt| 21
> +
On Tue, 2017-10-17 at 17:40 +0800, sean.w...@mediatek.com wrote:
> From: Sean Wang
>
> This patch introduces the driver for the RTC on MT7622 SoC.
>
> Signed-off-by: Sean Wang
> ---
> drivers/rtc/Kconfig | 10 ++
> drivers/rtc/Makefile | 1 +
> drivers/rtc/rtc-mt7622.c | 418
> +++
On Tue, 2017-10-17 at 17:40 +0800, sean.w...@mediatek.com wrote:
> From: Sean Wang
>
> This patch introduces the driver for the RTC on MT7622 SoC.
>
> Signed-off-by: Sean Wang
> ---
> drivers/rtc/Kconfig | 10 ++
> drivers/rtc/Makefile | 1 +
> drivers/rtc/rtc-mt7622.c | 418
> +++
On Fri, 2017-09-29 at 09:56 +0800, Chaotian Jing wrote:
> On Wed, 2017-09-27 at 09:18 +0800, Chaotian Jing wrote:
> > On Wed, 2017-09-27 at 00:33 +0200, Ulf Hansson wrote:
> > > On 14 September 2017 at 04:10, Chaotian Jing
> > > wrote:
> > > > On Wed, 2017-09-13 at 09:10 -0500, Rob Herring wrote:
On Tue, 2017-09-26 at 10:02 +0800, Ryder Lee wrote:
> This patch updates pio, usb and crypto nodes to make them be consistent
> with the binding documents.
>
> Signed-off-by: Ryder Lee
> ---
> arch/arm/boot/dts/mt7623.dtsi | 52
> ++-
> 1 file changed, 27
On Wed, 2017-08-16 at 11:59 +0800, Mars Cheng wrote:
> Hi Rob, Stephen, Matthias
>
> gentle ping.
>
> Thanks.
>
> On Tue, 2017-08-08 at 16:13 +0800, Mars Cheng wrote:
> > Mars Cheng (3):
> > clk: mediatek: add mt6755 clock ID
> > clk: mediatek: add clk support for MT6755
> > soc: mediate
gt; DMA mode.
> >
>
> These two resend patches only modify commit message.
> Thanks!
>
> Jun
Looks good to me, so for new version:
Reviewed-by: Yingjoe Chen
Joe.C
>
> > Signed-off-by: Jun Gao
> > ---
> > drivers/i2c/busses/i2c-mt65xx.c | 18 +++
On Wed, 2017-08-09 at 15:43 +0800, Jun Gao wrote:
> From: Jun Gao
>
> Add i2c compatible for MT7622. Compare to MT8173 i2c controller,
> MT7622 limit message size to 255, and not support 4GB DMA mode.
Jun,
Do you mean message numbers?
Joe.C
>
> Signed-off-by: Jun Gao
> ---
> drivers/i2c/
On Tue, 2017-07-18 at 17:49 +0800, sean.w...@mediatek.com wrote:
> From: Chenglin Xu
>
> The MT6380 is a regulator found those boards with MediaTek MT7622 SoC
> It is connected as a slave to the SoC using MediaTek PMIC wrapper which
> is the common interface connecting with Mediatek made various
On Wed, 2017-08-02 at 14:03 +0800, Zhiyong Tao wrote:
> On Tue, 2017-08-01 at 17:14 +0800, Yingjoe Chen wrote:
> >
> > Hi Zhiyong,
> >
> >
> >
> > On Mon, 2017-07-31 at 16:22 +0800, Zhiyong Tao wrote:
> > <...>
> > > 3)Add "s
On Mon, 2017-07-31 at 15:36 +0800, sean.w...@mediatek.com wrote:
<...>
> diff --git a/arch/arm/boot/dts/mt7623-evb.dts
> b/arch/arm/boot/dts/mt7623-evb.dts
> index b60b41c..0686ad7 100644
> --- a/arch/arm/boot/dts/mt7623-evb.dts
> +++ b/arch/arm/boot/dts/mt7623-evb.dts
> @@ -14,6 +14,7 @@
>
> /
Hi Zhiyong,
On Mon, 2017-07-31 at 16:22 +0800, Zhiyong Tao wrote:
<...>
> 3)Add "spec_dir_set" and "spec_dir_get" in "mtk_pinctrl_devdata".
> 4)Change "spec_dir_set" and add "spec_dir_get" in "pinctrl-mt2701.c"
> and "pinctrl-mtk-common.c".
I think these deserve another patch.
Please also e
On Fri, 2017-07-28 at 19:37 +0800, YT Shen wrote:
> diff --git a/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
> b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
> new file mode 100644
> index 000..1e135af
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
<...>
> + timer {
> +
On Mon, 2017-07-31 at 16:22 +0800, Zhiyong Tao wrote:
> This series includes three patches:
> 1.Add mt2712 compatible node in binding document.
> 2.Add mt2712 pinctrl device node.
> 3.Add mt2712 pinctrl driver.
>
> Zhiyong Tao (3):
> dt-bindings: pinctrl: mt2712: add binding document
> arm64:
: Yingjoe Chen
---
Hi,
This was sent in Jun 2016[1].
I think we should check every configs for help text.
Please let me know if there's anything need to change.
Thanks
Joe.C
[1] https://lkml.org/lkml/2016/6/24/360
---
scripts/checkpatch.pl |8 +++-
1 file changed, 7 insertions(+), 1 del
[Resend due to bad mail format, sorry about the noise if you got two]
On Tue, 2017-07-18 at 17:49 +0800, sean.w...@mediatek.com wrote:
> From: Sean Wang
>
> fixup those warnings such as lines over 80 words and parenthesis
> alignment which would be complained by checkpatch.pl.
>
> Signed-off-b
On Tue, 2017-07-18 at 17:49 +0800, sean.w...@mediatek.com wrote:
> From: Sean Wang
>
> Signed-off-by: Chenglin Xu
> Signed-off-by: Sean Wang
> Acked-by: Rob Herring
> ---
> Documentation/devicetree/bindings/soc/mediatek/pwrap.txt | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/D
On Thu, 2017-06-22 at 16:43 +0800, Erin Lo wrote:
> From: Weiqing Kong
>
> This patch adds board related config for backlight
>
> Signed-off-by: Weiqing Kong
> Signed-off-by: Erin Lo
> ---
> arch/arm/boot/dts/mt2701-evb.dts | 29 +
> 1 file changed, 29 insertions(+
On Tue, 2016-11-08 at 14:09 +0800, Yong Mao wrote:
> From: yong mao
>
> Add description of mmc3 for supporting sdio feature
>
> Signed-off-by: Yong Mao
> Signed-off-by: Chaotian Jing
> ---
> arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 82
> +++
> 1 file changed, 8
On Tue, 2016-09-06 at 14:35 +0800, Tiffany Lin wrote:
> Add Tiffany Lin and Andrew-CT Chen as maintainers for
> Mediatek MT8173 vcodec drivers
>
> Signed-off-by: Tiffany Lin
> Signed-off-by: Andrew-CT Chen
> ---
> MAINTAINERS |9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a
On Mon, 2016-07-11 at 15:10 +0200, Matthias Brugger wrote:
>
> On 11/07/16 10:56, James Liao wrote:
>
> [...]
>
> > @@ -467,28 +386,54 @@ static int scpsys_probe(struct platform_device
> > *pdev)
> > if (PTR_ERR(scpd->supply) == -ENODEV)
> >
Current help text check only check a config option if it is followed
by another config.
Adding check for help text if the next entry is menuconfig, choice/
endchoice, comment, menu/endmenu, if/endif, source or end of file.
Signed-off-by: Yingjoe Chen
---
checkpatch Kconfig checking stuff again
If a Kconfig config option doesn't specify 'default', the default
will be n. Adding 'default n' is unnecessary.
Add a test to warn about this.
Signed-off-by: Yingjoe Chen
---
scripts/checkpatch.pl | 7 +++
1 file changed, 7 insertions(+)
diff --git a/script
On Mon, 2016-06-13 at 15:26 +0800, Garlic Tseng wrote:
> Add machine driver and config option for MT2701.
>
> Signed-off-by: Garlic Tseng
> ---
> sound/soc/mediatek/Kconfig | 21 ++
> sound/soc/mediatek/Makefile| 1 +
> sound/soc/mediatek/mt2701/Makefile
On Mon, 2016-06-13 at 15:26 +0800, Garlic Tseng wrote:
> Modify mt8173 driver implementation to use common structure.
>
> Signed-off-by: Garlic Tseng
> ---
> sound/soc/mediatek/Kconfig| 11 +
> sound/soc/mediatek/Makefile | 3 +-
> sound/soc/mediatek/comm
Hi,
Thanks for the review.
On Mon, 2016-06-06 at 20:10 +0100, Andy Whitcroft wrote:
> On Mon, Jun 06, 2016 at 09:43:15AM -0700, Joe Perches wrote:
> > On Sat, 2016-06-04 at 13:10 +0800, Yingjoe Chen wrote:
> > > If a Kconfig config option doesn't specify 'default&#
Current help text check only check a config option if it is followed
by another config.
Adding check for help text if the next entry is menuconfig, choice/
endchoice, comment, menu/endmenu, if/endif, source or end of file.
Signed-off-by: Yingjoe Chen
---
scripts/checkpatch.pl | 8 +++-
1
If a Kconfig config option doesn't specify 'default', the default
will be n. Adding 'default n' is unnecessary.
Add a test to warn about this.
Signed-off-by: Yingjoe Chen
---
For this series, rebase to v4.7-rc1 and dropped 'relax Kconfig help text
line number thres
On Thu, 2016-05-12 at 19:49 +0800, yt.s...@mediatek.com wrote:
> From: YT Shen
>
> Add device tree binding documentation for the display subsystem in
> Mediatek SoC MT2701
>
> Signed-off-by: YT Shen
> ---
> .../bindings/display/mediatek/mediatek,disp.txt|1 +
> 1 file changed, 1 insert
On Fri, 2016-04-22 at 22:32 +0800, Yingjoe Chen wrote:
> If a Kconfig config option doesn't specify 'default', the default
> will be n. Adding 'default n' is unnecessary.
>
> Add a test to warn about this.
>
> Signed-off-by: Yingjoe Chen
> ---
>
Current threshold is too strict and many upstream patch doesn't pass
this test. Relax it.
Signed-off-by: Yingjoe Chen
---
In v4.6-rc1, 171 new config options was added, and 87 of those options
have < 4 lines and 24 options have only 1 line. After this change,
checkpatch only raise warn
Current help text check only check a config option if it is followed
by another config.
Adding check for help text if the next entry is menuconfig, choice/
endchoice, comment, menu/endmenu, if/endif, source or end of file.
Signed-off-by: Yingjoe Chen
---
Change in v2:
- Change according to Joe
If a Kconfig config option doesn't specify 'default', the default
will be n. Adding 'default n' is unnecessary.
Add a test to warn about this.
Signed-off-by: Yingjoe Chen
---
Change in v2:
- Change according to Joe Perches' suggestion
scripts/checkpatch.pl
On Thu, 2016-04-21 at 10:16 -0700, Joe Perches wrote:
> On Thu, 2016-04-21 at 21:28 +0800, Yingjoe Chen wrote:
> > If a Kconfig config option doesn't specify 'default', the default
> > will be n. Adding 'default n' is unnecessary.
> >
> >
On Thu, 2016-04-21 at 10:06 -0700, Joe Perches wrote:
> On Thu, 2016-04-21 at 21:28 +0800, Yingjoe Chen wrote:
> > Current help text check only check a config option if it is followed
> > by another config.
> > Adding check for help text if the next entry is menuconfig,
On Thu, 2016-04-21 at 10:39 -0700, Andi Kleen wrote:
> On Thu, Apr 21, 2016 at 10:00:07AM -0700, Joe Perches wrote:
> > On Thu, 2016-04-21 at 21:28 +0800, Yingjoe Chen wrote:
> > > Current threshold is too strict and many upstream patch doesn't pass
> > > this test.
Current help text check only check a config option if it is followed
by another config.
Adding check for help text if the next entry is menuconfig, choice/
endchoice, comment, menu/endmenu, if/endif, source or end of file.
Signed-off-by: Yingjoe Chen
---
scripts/checkpatch.pl | 11
Current threshold is too strict and many upstream patch doesn't pass
this test. Relax it.
Signed-off-by: Yingjoe Chen
---
In v4.6-rc1, 171 new config options was added, and 87 of those options
have < 4 lines and 24 options have only 1 line. After this change,
checkpatch only raise warn
If a Kconfig config option doesn't specify 'default', the default
will be n. Adding 'default n' is unnecessary.
Add a test to warn about this.
Signed-off-by: Yingjoe Chen
---
scripts/checkpatch.pl | 7 +++
1 file changed, 7 insertions(+)
diff --git a/script
On Fri, 2016-04-15 at 10:02 +0800, James Liao wrote:
> Hi Yingjoe,
>
> On Thu, 2016-04-14 at 18:56 +0800, Yingjoe Chen wrote:
> > On Thu, 2016-04-14 at 16:16 +0800, James Liao wrote:
> > > From: Shunli Wang
> > >
> > > Add power dt-bindings for MT270
On Thu, 2016-04-14 at 20:14 +0800, Garlic Tseng wrote:
> Move mt8173 driver to another folder.
>
> The software control sequence of mt2701 is very different from that of mt8173,
> so this patch moves mt8173 code to another folder.
>
>
> Signed-off-by: Garlic Tseng
> ---
> sound/soc/mediatek/Ma
On Thu, 2016-04-14 at 20:14 +0800, Garlic Tseng wrote:
> Add machine driver and config option for MT2701.
>
> Signed-off-by: Garlic Tseng
> ---
> sound/soc/mediatek/Kconfig | 21 ++
> sound/soc/mediatek/Makefile| 3 +
> sound/soc/mediatek/mt2701/Makefile
On Thu, 2016-04-14 at 16:16 +0800, James Liao wrote:
> From: Shunli Wang
>
> Add power dt-bindings for MT2701.
>
> Signed-off-by: Shunli Wang
> Signed-off-by: James Liao
> Acked-by: Rob Herring
> Reviewed-by: Kevin Hilman
> ---
> .../devicetree/bindings/soc/mediatek/scpsys.txt| 12 +
e the debounce time array name to
"debounce_time" for readability.
Signed-off-by: Yingjoe Chen
---
This was based on v4.6-rc1
Change since v1:
- Improve commit message.
- Change dbnc_arr name to debounce_time
---
drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 9 +
1 file change
Daniel,
Thanks for your review.
On Fri, 2016-04-01 at 22:28 +0800, Daniel Kurtz wrote:
> Hi Yingjoe,
>
> On Fri, Apr 1, 2016 at 9:51 PM, Yingjoe Chen
> wrote:
> > The debounce time unit for gpio_chip.set_debounce is us but
> > mtk_gpio_set_debounce regard it as ms.
The debounce time unit for gpio_chip.set_debounce is us but
mtk_gpio_set_debounce regard it as ms.
Fix this by correct debounce time array dbnc_arr so it can find correct
debounce setting.
Signed-off-by: Yingjoe Chen
---
drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 3 ++-
1 file changed, 2
On Thu, 2016-03-31 at 11:08 +0200, John Crispin wrote:
>
> On 31/03/2016 04:32, Yingjoe Chen wrote:
> > On Thu, 2016-03-31 at 09:40 +0800, Henry Chen wrote:
> >> On Wed, 2016-03-30 at 11:18 +0200, John Crispin wrote:
> >>> Hi,
> >>>
> >>
On Thu, 2016-03-31 at 09:40 +0800, Henry Chen wrote:
> On Wed, 2016-03-30 at 11:18 +0200, John Crispin wrote:
> > Hi,
> >
> > small nitpick inline
> >
> > On 30/03/2016 09:25, Henry Chen wrote:
> > > Some sub driver like RTC module need irq domain from parent to create
> > > irq mapping when driv
On Wed, 2016-03-02 at 12:31 +, Robin Murphy wrote:
> Hi Yong,
>
> On 23/02/16 23:02, Yong Wu wrote:
> > Mediatek extend bit9 in the lvl1 and lvl2 pgtable descriptor of the
> > Short-descriptor as the 4GB mode in which the dram size will be
> > over 4GB.
> >
> > We add a special quirk for this
On Thu, 2016-02-11 at 18:07 -0800, Hongzhou Yang wrote:
> On Fri, 2016-02-05 at 14:52 +0100, Linus Walleij wrote:
> > On Thu, Feb 4, 2016 at 4:03 AM, Hongzhou Yang
> > wrote:
> > > On Wed, 2016-02-03 at 09:24 +0800, Biao Huang wrote:
> > >> Since input-enable/disable and input-schmitt-enable/disab
On Thu, 2016-02-04 at 14:48 +0100, Matthias Brugger wrote:
>
> On 28/12/15 09:07, Yingjoe Chen wrote:
> > On Mon, 2015-12-28 at 15:09 +0800, Biao Huang wrote:
> >> Add mt2701 support using mediatek common pinctrl driver.
> >> MT2701 have some special pins need an ex
e() for support 4g mode.
> ---
> drivers/i2c/busses/i2c-mt65xx.c | 42
> +
> 1 file changed, 42 insertions(+)
Looks good to me, Thanks.
Reviewed-by: Yingjoe Chen
Joe.C
On Fri, 2016-01-29 at 09:35 +0800, Liguo Zhang wrote:
> If 4GB mode is enable, we should add 4gb mode support in i2c driver.
nit: enabled
However, after looking at it longer, the commit message doesn't make
much sense to me.
> Set 4GB mode register to support 4GB mode.
>
> Signed-off-by: Liguo Z
On Mon, 2016-01-25 at 10:53 +0100, John Crispin wrote:
> With ore SoCs being added the list of helper functions like these would
> grow. While at it also add a new flag "bridge" and use that insted of
> pwrap_is_mt8173() where appropriate.
typos?
s/ore/more/
s/insted/instead/
I think you mean "h
nit for the subject:
soc: mediatek: PMIC wrap:: SPI_WRITE needs a different bitmask for
MT2701/7623
^^ extra : here.
Otherwise the patch looks good to me.
Joe.C
On Mon, 2016-01-25 at 10:53 +0100, John Crispin wrote:
> MT2701 and MT7623 use a different bitmask for the S
Hi John,
Thanks for preparing the patch.
On Mon, 2016-01-25 at 10:53 +0100, John Crispin wrote:
> This patch adds a new struct pwrap_slv_type that we use to store the slave
> specific data. The patch adds 2 new helper functions to access the dew
> registers. The slave type is looked up via the
On Thu, 2016-01-21 at 10:28 +0800, Yingjoe Chen wrote:
> On Tue, 2016-01-12 at 16:31 +0800, James Liao wrote:
> > Add a Kconfig to define clock configuration for each SoC, and
> > modify the Makefile to build drivers that only selected in config.
> >
> > Signed-off-by:
On Tue, 2016-01-12 at 16:31 +0800, James Liao wrote:
> Add a Kconfig to define clock configuration for each SoC, and
> modify the Makefile to build drivers that only selected in config.
>
> Signed-off-by: Shunli Wang
> Signed-off-by: James Liao
> ---
> drivers/clk/Kconfig | 1 +
> dr
On Mon, 2015-12-28 at 15:09 +0800, Biao Huang wrote:
> Add mt2701 support using mediatek common pinctrl driver.
> MT2701 have some special pins need an extra setting register
> than other ICs, so adding this support to common code.
>
> Signed-off-by: Biao Huang
> Acke
On Wed, 2015-12-23 at 12:00 +, Mark Brown wrote:
> On Wed, Dec 23, 2015 at 06:16:08PM +0800, Henry Chen wrote:
>
> Please fix your mail client to word wrap within paragraphs at something
> substantially less than 80 columns. Doing this makes your messages much
> easier to read and reply to.
>
xpect. Apply this now won't cause any problem
either, unless someone think we should stink to current orders.
So I think we could apply this now:
Acked-by: Yingjoe Chen
Joe.C
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of
On Mon, 2015-12-21 at 14:51 +0800, Daniel Kurtz wrote:
> On Fri, Dec 18, 2015 at 11:06 PM, Yingjoe Chen
> wrote:
> > On Fri, 2015-12-18 at 12:21 +0800, Daniel Kurtz wrote:
> >> Move pinctrl initialization earlier in boot so that real devices can find
> >> their p
12 +-
> drivers/pinctrl/mediatek/pinctrl-mtk-mt2701.h | 2323
> +
> 6 files changed, 2945 insertions(+), 1 deletion(-)
> create mode 100644 drivers/pinctrl/mediatek/pinctrl-mt2701.c
> create mode 100644 drivers/pinctrl/mediatek/pinctrl-mtk-mt2701.h
This patch
On Fri, 2015-12-18 at 12:21 +0800, Daniel Kurtz wrote:
> Move pinctrl initialization earlier in boot so that real devices can find
> their pctldev without probe deferring.
>
> Signed-off-by: Daniel Kurtz
> ---
> drivers/pinctrl/mediatek/pinctrl-mt6397.c | 2 +-
> drivers/pinctrl/mediatek/pinctrl
The returned configs from pinconf_generic_parse_dt_config() is
duplicated from original. Make it clear it must be freed when no
longer necessary.
Signed-off-by: Yingjoe Chen
---
It seems memleak in pinctrl-mtk-common.c[1] is not alone. After a quick
glance I notice similar issues in drivers
On Wed, 2015-11-25 at 11:50 +0100, Matthias Brugger wrote:
>
> On 18/11/15 04:30, Bayi Cheng wrote:
> > Add Mediatek nor flash node
> >
> > Signed-off-by: Bayi Cheng
> > Acked-by: Brian Norris
> > ---
> > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 18 +-
> > 1 file changed, 17
k issue.
> According to Yingjoe's comment, add return checek for
> pinconf_generic_parse_dt_config.
Reviewed-by: Yingjoe Chen
Joe.C
> drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 27
> -
> 1 file changed, 17 insertions(+), 10 deletions(-)
>
>
On Mon, 2015-11-16 at 20:22 -0800, Hongzhou Yang wrote:
> configs will kmemdup to dup_configs in pictrl util function.
> So configs need to be freed.
>
> Signed-off-by: Hongzhou Yang
> ---
> Fix a memleak issue.
>
> drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 24 ++--
1 - 100 of 318 matches
Mail list logo
