Re: Question about the "EXPERIMENTAL" tag for dax in XFS

2021-02-28 Thread Yasunori Goto
an imagine if a device like usb memory stick is removed surprisingly, kernel/filesystem need to reject writeback at the time, and discard page cache. Then, I can understand that unbinding operation is essential for such case. But I don't know why PMEM device/namespace allows unbinding operation like surprising removal event. Thanks, -- Yasunori Goto

Re: [PATCH] libnvdimm: clean up command definitions

2017-08-29 Thread Yasunori Goto
> On Tue, Aug 29, 2017 at 3:09 AM, Yasunori Goto wrote: > >> On Mon, Aug 28, 2017 at 6:03 PM, Yasunori Goto > >> wrote: > >> >> On Mon, Aug 28, 2017 at 1:50 PM, Jerry Hoemann > >> >> wrote: > >> >> > > >> >> &

Re: [PATCH] libnvdimm: clean up command definitions

2017-08-29 Thread Yasunori Goto
> On Mon, Aug 28, 2017 at 6:03 PM, Yasunori Goto wrote: > >> On Mon, Aug 28, 2017 at 1:50 PM, Jerry Hoemann > >> wrote: > >> > > >> > On Mon, Aug 28, 2017 at 08:45:32AM -0700, Dan Williams wrote: > >> >> Remove the command payloads

Re: [PATCH] libnvdimm: clean up command definitions

2017-08-28 Thread Yasunori Goto
and libndctl > defines some general helpers for issuing commands. Maybe I don't understand your idea yet, let me confirm it. Certainly, current acpi driver does not need these definitions. But, I think nfit_test.ko will need them to emulate these features. Do you intend that libndctl-nfit.h should be defined at "include/uapi/linux/" directory? Otherwise, it should be defined at "tools/testing/nvdimm/" or "tools/testing/nvdimm/test" ? Thanks, --- Yasunori Goto

Re: [RFC]Pid conversion between pid namespace

2014-07-03 Thread Yasunori Goto
rchy under /proc/ns_hierarchy like: > init_ns->ns1->ns2 (as the result of readlink) > ->ns3 > We knew that t3 in ns2, and its hierarchy. > > How these ideas looks like? > Any comments would be appreciated. > > Thanks, > - Chen > > &

Re: [-mm PATCH] register_memory/unregister_memory clean ups

2008-02-12 Thread Yasunori Goto
ll. > > static void free_usemap(unsigned long *usemap) > { > if (!usemap_ > return; > > if (PageSlab(virt_to_page(usemap))) { > kfree(usemap) > } else if (is_vmalloc_addr(usemap)) { > vfree(usemap); >

Re: [PATCH] [5/8] Fix logic error in 64bit memory hotadd

2008-02-12 Thread Yasunori Goto
n x86, E8500 chipset has the feature of memory-hotplug. (I searched a data-sheet from intel site.) http://download.intel.com/design/chipsets/e8500/datashts/30674501.pdf (6.3.8 IMI Hot-Plug) So, it depends on how many server uses it, I think. Thanks. -- Yasunori Goto -- To unsubscribe f

Re: [-mm PATCH] register_memory/unregister_memory clean ups

2008-02-12 Thread Yasunori Goto
???() | |nothing calls? | +-->unregister_memory_section() | |call | +---> remove_memory_block() | |call | +> unregister_memory() unregister_memory_section() is only externed in linux/memo

Re: [RFC][PATCH v2 7/7] Do not recompute msgmni anymore if explicitely set by user

2008-02-05 Thread Yasunori Goto
f automatic recomputing. If user would like to change this value, it should be turned off. Otherwise, his requrest will be rejected with some messages. Probably, user can understand easier than this side effect. Bye. -- Yasunori Goto -- To unsubscribe from this list: send the line "unsu

Re: [RFC][PATCH 1/2]: MM: Make Paget Tables Relocatable--Conditional TLB Flush

2008-01-23 Thread Yasunori Goto
> if (mm == current->active_mm) { > flush_tlb_current(mm); > if (atomic_read(&mm->mm_users) <= 1) { -- Yasunori Goto -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL

Re: [RFC] Document about lowmem_reserve_ratio

2008-01-17 Thread Yasunori Goto
ge document for it. Signed-off-by: Yasunori Goto <[EMAIL PROTECTED]> --- Documentation/filesystems/proc.txt | 76 + 1 file changed, 61 insertions(+), 15 deletions(-) Index: current/Documentation

[RFC] Document about lowmem_reserve_ratio

2008-01-17 Thread Yasunori Goto
review it. Thanks. --- Though the lower_zone_protection was changed to lowmem_reserve_ratio, the document has been not changed. The lowmem_reserve_ratio seems quite hard to estimate, but there is no guidance. This patch is to change document for it. Signed-off-by: Yasunori Goto <[EM

Re: [RFC PATCH 4/4] [RESEND] Recomputing msgmni on memory add / remove

2008-01-15 Thread Yasunori Goto
> Yasunori Goto wrote: > > Hello Nadia-san. > > > > > >>@@ -118,6 +122,10 @@ struct ipc_namespace { > >>size_t shm_ctlall; > >>int shm_ctlmni; > >>int shm_tot; > >>+ > >>+#i

Re: [RFC PATCH 4/4] [RESEND] Recomputing msgmni on memory add / remove

2008-01-15 Thread Yasunori Goto
space have different callback for the future? BTW, have you ever tested this patch? If you don't have any test environment for memory hotplug code, then I'll check it. :-) Bye. -- Yasunori Goto -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: sparsemem: Make SPARSEMEM_VMEMMAP selectable

2007-12-09 Thread Yasunori Goto
Looks good to me. Thanks. Acked-by: Yasunori Goto <[EMAIL PROTECTED]> > > From: Geoff Levand <[EMAIL PROTECTED]> > > SPARSEMEM_VMEMMAP needs to be a selectable config option to > support building the kernel both with and without sparsemem > vmemmap support. T

Re: PS3: trouble with SPARSEMEM_VMEMMAP and kexec

2007-12-09 Thread Yasunori Goto
> Yasunori Goto wrote: > >> On Thu, 6 Dec 2007, Geert Uytterhoeven wrote: > >> > On Thu, 6 Dec 2007, Yasunori Goto wrote: > >> > > > I'll try Milton's suggestion to pre-allocate the memory early. It > >> > > > seems > >

Re: PS3: trouble with SPARSEMEM_VMEMMAP and kexec

2007-12-06 Thread Yasunori Goto
> On Thu, 6 Dec 2007, Geert Uytterhoeven wrote: > > On Thu, 6 Dec 2007, Yasunori Goto wrote: > > > > I'll try Milton's suggestion to pre-allocate the memory early. It seems > > > > that should work as long as nothing else before the hot-plug mem is

Re: PS3: trouble with SPARSEMEM_VMEMMAP and kexec

2007-12-05 Thread Yasunori Goto
(However, I think Milton-san's suggestion is very desirable. If preallocation of hotadd works on ia64 too, I'm very glad.) Thanks. -- Yasunori Goto -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More ma

Re: [Patch](Resend) mm/sparse.c: Improve the error handling for sparse_add_one_section()

2007-11-28 Thread Yasunori Goto
Looks good to me. Thanks. Acked-by: Yasunori Goto <[EMAIL PROTECTED]> > On Tue, Nov 27, 2007 at 10:53:45AM -0800, Dave Hansen wrote: > >On Tue, 2007-11-27 at 10:26 +0800, WANG Cong wrote: > >> > >> @@ -414,7 +418,7 @@ int sparse_add_on

Re: [Patch](Resend) mm/sparse.c: Improve the error handling for sparse_add_one_section()

2007-11-27 Thread Yasunori Goto
; + kfree(usemap); > return ret; > } > #endif > I guess you think __kfree_section_memmap() is not necessary due to no implementation. But, it is still available when CONFIG_SPARSEMEM_VMEMMAP is off. So, it should not be removed. Bye. -- Yasunori Goto - To u

Re: [Patch] mm/sparse.c: Improve the error handling for sparse_add_one_section()

2007-11-26 Thread Yasunori Goto
ee_section_memmap(memmap, nr_pages); > + > return ret; > } > #endif Hmm. When sparse_init_one_section() returns error, memmap and usemap should be free. Thanks for your fixing. -- Yasunori Goto - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: EIP is at device_shutdown+0x32/0x60

2007-11-15 Thread Yasunori Goto
; > Yes, that fixes the problem for me! > > Can anyone else verify this? I confirmed it fixed the problem. :-) Thanks. -- Yasunori Goto - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo

Re: EIP is at device_shutdown+0x32/0x60

2007-11-15 Thread Yasunori Goto
red, dev->driver pointed kset_ktype's address, and dev->driver->shutdown was the address of bus_type_list. So, Oops was caused by "Illegal operation fault". kset_ktypes is pointed by system_kset. If my understanding is correct, this loop can't distinguish between struct

[PATCH] Add IORESOUCE_BUSY flag for System RAM take 2.

2007-11-05 Thread Yasunori Goto
of x86-64. This patch fix it. This patch adds IORESOURCE_BUSY to avoid potential overlap mapping by PCI device. Signed-off-by: Yasunori Goto <[EMAIL PROTECTED]> Signed-off-by: Badari Pulavarty <[EMAIL PROTECTED]> --- arch/ia64/kernel/efi.c |6 ++ kernel/resource.c |2

[PATCH] Add IORESOUCE_BUSY flag for System RAM (Re: [Question] How to represent SYSTEM_RAM in kerenel/resouce.c)

2007-11-01 Thread Yasunori Goto
IORESOURCE_BUSY for them to avoid potential overlap mapping by PCI device. Signed-off-by: Yasunori Goto <[EMAIL PROTECTED]> --- arch/ia64/kernel/efi.c |6 ++ mm/memory_hotplug.c|2 +- 2 files changed, 3 insertions(+), 5 deletions(-) Index: current/arch/ia64/kernel

Re: [PATCH] Fix warning in mm/slub.c

2007-10-22 Thread Yasunori Goto
n shoudn't call this >* callback. So, we must fail. >*/ > - BUG_ON(atomic_read(&n->nr_slabs)); > + BUG_ON(atomic_long_read(&n->nr_slabs)); > > s->node[offline_node] = NULL; >

Re: [Patch](memory hotplug) Make kmem_cache_node for SLUB on memory online to avoid panic(take 3)

2007-10-18 Thread Yasunori Goto
> On Thu, 18 Oct 2007 12:25:37 +0900 Yasunori Goto <[EMAIL PROTECTED]> wrote: > > > > > This patch fixes panic due to access NULL pointer > > of kmem_cache_node at discard_slab() after memory online. > > > > When memory online is called, kmem_cache_n

Re: [Patch](memory hotplug) Make kmem_cache_node for SLUB on memory online to avoid panic(take 3)

2007-10-18 Thread Yasunori Goto
ome things over there as well. Though the fix may be better for it, my priority is very low for it now. -- Yasunori Goto - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[Patch](memory hotplug) Make kmem_cache_node for SLUB on memory online to avoid panic(take 3)

2007-10-17 Thread Yasunori Goto
. Please apply. Signed-off-by: Yasunori Goto <[EMAIL PROTECTED]> --- mm/slub.c | 115 ++ 1 file changed, 115 insertions(+) Index: current/mm/slub.c === --- curren

[Patch 002/002](memory hotplug) rearrange patch for notifier of memory hotplug

2007-10-17 Thread Yasunori Goto
because returned page is not used again. - Make CANCEL events for rollingback when error occurs. - Delete MEM_MAPPING_INVALID notification. It will be not used. - Fix compile error of (un)register_memory_notifier(). Signed-off-by: Yasunori Goto <[EMAIL PROTECTED]> --- drivers/base/

[Patch 001/002](memory hotplug) Make description of memory hotplug notifier in document

2007-10-17 Thread Yasunori Goto
Add description about event notification callback routine to the document. Signed-off-by: Yasunori Goto <[EMAIL PROTECTED]> --- Documentation/memory-hotplug.txt | 58 --- 1 file changed, 55 insertions(+), 3 deletions(-) Index: current/Documentation/

[Patch 000/002](memory hotplug) Rearrange notifier of memory hotplug (take 2)

2007-10-17 Thread Yasunori Goto
y for SLUB but also for others. So, I extracted this from it. This patch set is for 2.6.23-mm1. I tested this patch on my ia64 box. Please apply. Bye. -- Yasunori Goto - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL

Re: [Patch 002/002] Create/delete kmem_cache_node for SLUB on memory online callback

2007-10-12 Thread Yasunori Goto
> On Fri, 12 Oct 2007, Yasunori Goto wrote: > > > > > + down_read(&slub_lock); > > > > + list_for_each_entry(s, &slab_caches, list) { > > > > + local_node = page_to_nid(virt_to_page(s)); >

Re: [Patch 002/002] Create/delete kmem_cache_node for SLUB on memory online callback

2007-10-11 Thread Yasunori Goto
> On Fri, 12 Oct 2007, Yasunori Goto wrote: > > > If pages on the new node available, slub can use it before making > > new kmem_cache_nodes. So, this callback should be called > > BEFORE pages on the node are available. > > If its called before pages on the n

Re: [Patch 001/002] extract kmem_cache_shrink

2007-10-11 Thread Yasunori Goto
> On Fri, 12 Oct 2007, Yasunori Goto wrote: > > > Make kmem_cache_shrink_node() for callback routine of memory hotplug > > notifier. This is just extract a part of kmem_cache_shrink(). > > Could we just call kmem_cache_shrink? It will do the shrink on every node >

Re: [Patch 001/002] Make description of memory hotplug notifier in document

2007-10-11 Thread Yasunori Goto
> Looks good. Some suggestions on improving the wording. Thanks! I'll fix them. Bye. > > On Fri, 12 Oct 2007, Yasunori Goto wrote: > > > +MEMORY_GOING_ONLINE > > + This is notified before memory online. If some structures must be > > prepared > > +

[Patch 002/002] Create/delete kmem_cache_node for SLUB on memory online callback

2007-10-11 Thread Yasunori Goto
shrink cache, then slab_mem_offline_callback() is called later. Signed-off-by: Yasunori Goto <[EMAIL PROTECTED]> --- mm/slub.c | 117 ++ 1 file changed, 117 insertions(+) Index: current/mm/

[Patch 001/002] extract kmem_cache_shrink

2007-10-11 Thread Yasunori Goto
Make kmem_cache_shrink_node() for callback routine of memory hotplug notifier. This is just extract a part of kmem_cache_shrink(). Signed-off-by: Yasunori Goto <[EMAIL PROTECTED]> --- mm/slub.c | 111 ++ 1 file changed, 61 inse

[Patch 000/002] Make kmem_cache_node for SLUB on memory online to avoid panic(take 2)

2007-10-11 Thread Yasunori Goto
node. Incidentally, it is freed on memory offline if it becomes not necessary. This is the first user of the callback of memory notifier, and requires its rearrange patch set. This patch set is for 2.6.23-rc8-mm2. I tested this patch on my ia64 box. Please apply. Bye. -- Yasunori Goto

[Patch 002/002] rearrange patch for notifier of memory hotplug

2007-10-11 Thread Yasunori Goto
because returned page is not used again. - Make CANCEL events for rollingback when error occurs. - Delete MEM_MAPPING_INVALID notification. It will be not used. - Fix compile error of (un)register_memory_notifier(). Signed-off-by: Yasunori Goto <[EMAIL PROTECTED]> --- drivers/base/

[Patch 001/002] Make description of memory hotplug notifier in document

2007-10-11 Thread Yasunori Goto
Add description about event notification callback routine to the document. Signed-off-by: Yasunori Goto <[EMAIL PROTECTED]> --- Documentation/memory-hotplug.txt | 56 --- 1 file changed, 53 insertions(+), 3 deletions(-) Index: current/Documentation/

[Patch 000/002] Rearrange notifier of memory hotplug

2007-10-11 Thread Yasunori Goto
only for SLUB but also for others. So, I extracted this from it. This patch set is for 2.6.23-rc8-mm2. I tested this patch on my ia64 box. Please apply. Bye. -- Yasunori Goto - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL

Re: [Patch / 002](memory hotplug) Callback function to create kmem_cache_node.

2007-10-03 Thread Yasunori Goto
> On Wed, 3 Oct 2007, Yasunori Goto wrote: > > > > > > > That would work. But it would be better to shrink the cache first. The > > > first 2 slabs on a node may be empty and the shrinking will remove those. > > > If you do not shrink then

Re: [Patch / 002](memory hotplug) Callback function to create kmem_cache_node.

2007-10-03 Thread Yasunori Goto
> On Tue, 2 Oct 2007, Yasunori Goto wrote: > > > Do you mean that just nr_slabs should be checked like followings? > > I'm not sure this is enough. > > > > : > > if (s->node[nid]) { > > n = get_node(s, nid); > > if (!atomic_r

Re: x86 patches was Re: -mm merge plans for 2.6.24

2007-10-02 Thread Yasunori Goto
omitted by ia64 bootstrap. > After boot, only Node 4 has valid memory (but have no cpu.) > > Maybe this is memory-interleave by firmware config. >From memory-hotplug view, memory-less node is very helpful. It can define and arrange some "halfway conditions" of node hot-plug. I guess that node unpluging code will be simpler by it. Bye. -- Yasunori Goto - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [Patch / 002](memory hotplug) Callback function to create kmem_cache_node.

2007-10-01 Thread Yasunori Goto
> On Mon, 1 Oct 2007, Yasunori Goto wrote: > > > +#ifdef CONFIG_MEMORY_HOTPLUG > > +static void __slab_callback_offline(int nid) > > +{ > > + struct kmem_cache_node *n; > > + struct kmem_cache *s; > > + > > + list_for_each_entry(s, &

Re: [Patch 000/002](memory hotplug) Fix NULL pointer access of kmem_cache_node when hot-add.

2007-10-01 Thread Yasunori Goto
I'm sorry. There are 2 patches for this fix. Subtitle should be [Patch 000/002]. :-( -- Yasunori Goto - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majo

[Patch / 002](memory hotplug) Callback function to create kmem_cache_node.

2007-10-01 Thread Yasunori Goto
BEFORE pages on the node are available. Signed-off-by: Yasunori Goto <[EMAIL PROTECTED]> --- mm/slub.c | 79 ++ 1 file changed, 79 insertions(+) Index: current/mm/

[Patch / 001](memory hotplug) fix some defects of memory notifer callback interface.

2007-10-01 Thread Yasunori Goto
ating per node structure before the node's pages are available. - Fix compile error of (un)register_memory_notifier(). Signed-off-by: Yasunori Goto <[EMAIL PROTECTED]> --- drivers/base/memory.c | 10 +++--- include/linux/memory.h | 16 2 files change

[Patch / 000](memory hotplug) Fix NULL pointer access of kmem_cache_node when hot-add.

2007-10-01 Thread Yasunori Goto
node. This is the first user of the callback of memory notifier. So, the first patch is to change some defects of it. This patch set is for 2.6.23-rc8-mm2. I tested this patch on my ia64 box. Please apply. Bye. -- Yasunori Goto - To unsubscribe from this list: send the line "unsubs

Re: [PATCH -mm] mm: Fix memory hotplug + sparsemem build.

2007-09-13 Thread Yasunori Goto
> On Fri, 14 Sep 2007 11:02:43 +0900 Yasunori Goto <[EMAIL PROTECTED]> wrote: > > > > > /* call arch's memory hotadd */ > > > > > > > > > > OK, we're getting into a mess here. This patch fixes > > > update-n_h

Re: [PATCH -mm] mm: Fix memory hotplug + sparsemem build.

2007-09-13 Thread Yasunori Goto
> On Tue, 11 Sep 2007 18:37:12 +0900 Yasunori Goto <[EMAIL PROTECTED]> wrote: > > > > > > > + if (onlined_pages){ > > > > > > Nit, needs a space there before the '{'. > > > > Ah, Ok. I attached fixed patch in this ma

[Patch] Fix panic of cpu online with memory less node

2007-09-11 Thread Yasunori Goto
When a cpu is onlined on memory-less-node box, kernel panics due to touch NULL pointer of pgdat->kswapd. Current kswapd runs only nodes which have memory. So, calling of set_cpus_allowed() is not necessary for memory-less node. This is fix for it. Signed-off-by: Yasunori Goto <[EMAIL PRO

Re: [PATCH -mm] mm: Fix memory hotplug + sparsemem build.

2007-09-11 Thread Yasunori Goto
d-by: Andy Whitcroft <[EMAIL PROTECTED]> Thanks for your explanation. You mentioned all of my intention correctly. :-) Fix kswapd doesn't run when memory is added on memory-less-node. Fix compile error of zone->node when CONFIG_NUMA is off. Signed-off-by: Yasunori Goto <[EMAI

Re: [PATCH -mm] mm: Fix memory hotplug + sparsemem build.

2007-09-11 Thread Yasunori Goto
emory less node now. It should run when the node has memory.) I would like to merge them like following if you don't mind. Bye. --- Fix kswapd doesn't run when memory is added on memory-less-node. Fix compile error of zone->node when CONFIG_NUMA is off. Signed-off-by: Yasunori Go

[PATCH] Fix find_next_best_node (Re: [BUG] 2.6.23-rc3-mm1 Kernel panic - not syncing: DMA: Memory would be corrupted)

2007-08-23 Thread Yasunori Goto
d-off-by: Yasunori Goto <[EMAIL PROTECTED]> --- mm/page_alloc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: current/mm/page_alloc.c === --- current.orig/mm/page_alloc.c2007-08-24 16:03:17.

Re: [BUG] 2.6.23-rc3-mm1 Kernel panic - not syncing: DMA: Memory would be corrupted

2007-08-23 Thread Yasunori Goto
printk("%s flags=%0x order=%d ret=%p\n",__func__, flags, order, ret); if (ret && address_needs_mapping(hwdev, virt_to_bus(ret))) { /* * The allocated memory isn't reachable by the device. -- Yasunori Goto - To unsubscribe f

Re: [2.6 patch] mm/migrate.c: cleanups

2007-08-02 Thread Yasunori Goto
ic int putback_lru_pages(struct list_head *l) > { > struct page *page; > struct page *page2; > > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to [EMAIL PROTECTED] > More majordomo info at h

[Doc] Memory hotplug document take 3

2007-08-02 Thread Yasunori Goto
d "Current status". --- Signed-off-by: KAMEZAWA Hiroyuki <[EMAIL PROTECTED]> Signed-off-by: Yasunori Goto <[EMAIL PROTECTED]> Documentation/memory-hotplug.txt | 322 +++ 1 files changed, 322 insertions(+) Index: makedocument/

Re: [RFC][Doc] memory hotplug documentaion take 2.

2007-07-27 Thread Yasunori Goto
> +script. This will be done in automatically. > > drop "in" Ok. > > +If firmware supports NUMA-node hotplug, and define object of _HID > > "ACPI0004", > >

[RFC][Doc] memory hotplug documentaion take 2.

2007-07-27 Thread Yasunori Goto
add a document for memory hotplug to describe "How to use" and "Current status". --- Signed-off-by: KAMEZAWA Hiroyuki <[EMAIL PROTECTED]> Signed-off-by: Yasunori Goto <[EMAIL PROTECTED]> Documentation/memory-hotplug.txt | 322 +++

Re: [PATCH][22/37] Clean up duplicate includes in include/linux/memory_hotplug.h

2007-07-22 Thread Yasunori Goto
Oops. This should be Thanks! Acked-by: Yasunori Goto <[EMAIL PROTECTED]> > Hi, > > This patch cleans up duplicate includes in > include/linux/memory_hotplug.h > > > Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> > --- > > diff --git

Re: x86_64 memory hotplug simulation support?

2007-07-05 Thread Yasunori Goto
new memory to use them. - rebuild zonelist. But, unplug code just do logical offline. physicall hot-unplug must be necessary for test phase 1. Hmm. I don't know what is necessary for suspend2. But, some works looks still necessary for each way. Thanks. -- Yasunori Goto

Re: x86_64 memory hotplug simulation support?

2007-07-04 Thread Yasunori Goto
tell me how/what do you expect memory hotplug simulation exactly? Memory hot-add code is included in kernel. And, remove(unplug) code has developed (and hopefully, it will be merged to -mm after some cleanups, I think.) I would like to make sure what is necessary. Thanks. -- Yasunori Goto - To

Re: [PATCH 5/7] Introduce a means of compacting memory within a zone

2007-06-19 Thread Yasunori Goto
holes in normal zone. When it is changed to normal pfn_valid(), no panic occurs. Hmmm. Bye. -- Yasunori Goto - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] mm: More __meminit annotations.

2007-06-17 Thread Yasunori Goto
> On Mon, Jun 18, 2007 at 02:49:24PM +0900, Yasunori Goto wrote: > > > -static inline unsigned long zone_absent_pages_in_node(int nid, > > > +static inline unsigned long __meminit zone_absent_pages_in_node(int nid, > > >

Re: [PATCH] mm: More __meminit annotations.

2007-06-17 Thread Yasunori Goto
unsigned long zone_type, > unsigned long *zholes_size) > { I thought __meminit is not effective for these static functions, because they are inlined function. So, it depends on caller's defenition. Is it wrong? Bye. -- Y

Re: mm: Fix memory/cpu hotplug section mismatch and oops.

2007-06-14 Thread Yasunori Goto
Thanks. I tested compile with cpu/memory hotplug off/on. It was OK. Acked-by: Yasunori Goto <[EMAIL PROTECTED]> > (This is a resend of the earlier patch, this issue still needs to be > fixed.) > > When building with memory hotplug enabled and cpu hotplug disabled, we

Re: mm: memory/cpu hotplug section mismatch.

2007-06-11 Thread Yasunori Goto
p users. But, cpu/memory hotpluggable box is very rare. And it should be in init section for many people. This kind of issue is caused by initialization of pgdat/zone. I think __nodeinit is enough and desirable. Bye. -- Yasunori Goto - To unsubscribe from this list: send the line "unsubs

Re: [PATCH] sparsemem: Shut up unused symbol compiler warnings.

2007-05-31 Thread Yasunori Goto
> On Fri, Jun 01, 2007 at 02:26:17PM +0900, Yasunori Goto wrote: > > I think this issue is fixed by > > move-three-functions-that-are-only-needed-for.patch in current -mm tree. > > Is it not enough? > > > That's possible, I hadn't checked -mm. This was

Re: [PATCH] sparsemem: Shut up unused symbol compiler warnings.

2007-05-31 Thread Yasunori Goto
if (!valid_section_nr(pnum)) > + continue; > + > + map = sparse_early_mem_map_alloc(pnum); > + if (!map) > + continue; > + sparse_init_one_section(__nr_to_section(pnum), pnum, map); > + } > +} > &g

[PATCH](memory hotplug) Fix unnecessary calling of init_currenty_empty_zone()

2007-05-29 Thread Yasunori Goto
ory leak of zone's wait_table. This patch is tested on my ia64 box with 2.6.22-rc2-mm1. Signed-off-by: Yasunori Goto <[EMAIL PROTECTED]> mm/memory_hotplug.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) Index: vmemmap/mm/me

Re: Section mismatch warnings (was Re: [PATCH] early_pfn_to_nid needs to be __meminit)

2007-05-09 Thread Yasunori Goto
an before. Some of them are not defined as __init even if it's called at just boottime. This is simple to fix. Second case is that the functions judge which functions should call (boottime or normal) by themselves. pte_alloc_one_kernel() looks its case. In this case, they must be registered in whitelis

[RFC] memory hotremove patch take 2 [09/10] (direct isolation for remove)

2007-05-08 Thread Yasunori Goto
destination page of migration. This was cause of eternal loop in offline_pages(). Signed-off-by: Yasunori Goto <[EMAIL PROTECTED]> include/linux/page_isolation.h | 14 mm/Kconfig |1 mm/migrate.c | 46 ++

Re: [RFC] memory hotremove patch take 2 [07/10] (delay freeing anon_vma)

2007-05-08 Thread Yasunori Goto
by mm->sem. but we can't do it. So, just delaying freeing anon_vma. Signed-Off-By: KAMEZAWA Hiroyuki <[EMAIL PROTECTED]> Signed-off-by: Yasunori Goto <[EMAIL PROTECTED]> include/linux/migrate.h|2 ++ include/linux/page_isolation.h | 14 ++ include/lin

[RFC] memory hotremove patch take 2 [08/10] (memap init alignment)

2007-05-08 Thread Yasunori Goto
If there is small hole at end of a section, there are not initialized pages. To find it, messy check is necessary at many place of memory remove code. But, reserved bit by initialization is enough for most case of them. Signed-off-by: Yasunori Goto <[EMAIL PROTECTED]> mm/page_alloc.c

[RFC] memory hotremove patch take 2 [05/10] (make basic remove code)

2007-05-08 Thread Yasunori Goto
need more work on loop algorythm and policy. Signed-Off-By: KAMEZAWA Hiroyuki <[EMAIL PROTECTED]> Signed-off-by: Yasunori Goto <[EMAIL PROTECTED]> include/linux/memory_hotplug.h |1 mm/Kconfig |8 + mm/memory_hotplug.c

[RFC] memory hotremove patch take 2 [06/10] (ia64's remove_memory code)

2007-05-08 Thread Yasunori Goto
Call offline pages from remove_memory(). Signed-off-by: Yasunori Goto <[EMAIL PROTECTED]> Signed-Off-By: KAMEZAWA Hiroyuki <[EMAIL PROTECTED]> arch/ia64/mm/init.c | 13 - 1 files changed, 12 insertions(+), 1 deletion(-) Index: current_test/arch/ia

[RFC] memory hotremove patch take 2 [10/10] (retry swap-in page)

2007-05-08 Thread Yasunori Goto
There is a race condition between swap-in and unmap_and_move(). When swap-in occur, page_mapped might be not set yet. So, unmap_and_move() gives up at once, and tries later. Signed-off-by: Yasunori Goto <[EMAIL PROTECTED]> mm/migrate.c |5 + 1 files changed, 5 insertions(+)

[RFC] memory hotremove patch take 2 [03/10] (drain all pages)

2007-05-08 Thread Yasunori Goto
This patch add function drain_all_pages(void) to drain all pages on per-cpu-freelist. Page isolation will catch them in free_one_page. Signed-Off-By: KAMEZAWA Hiroyuki <[EMAIL PROTECTED]> Signed-off-by: Yasunori Goto <[EMAIL PROTECTED]> include/linux/page_isolation.h |1 + mm/

[RFC] memory hotremove patch take 2 [04/10] (isolate all free pages)

2007-05-08 Thread Yasunori Goto
Isolate all freed pages (means in buddy_list) in the range. See page_buddy() and free_one_page() function if unsure. Signed-Off-By: KAMEZAWA Hiroyuki <[EMAIL PROTECTED]> Signed-off-by: Yasunori Goto <[EMAIL PROTECTED]> include/linux/page_isolation.h |1 mm/

[RFC] memory hotremove patch take 2 [02/10] (make page unused)

2007-05-08 Thread Yasunori Goto
<[EMAIL PROTECTED]> Signed-off-by: Yasunori Goto <[EMAIL PROTECTED]> include/linux/mmzone.h |8 + include/linux/page_isolation.h | 52 +++ mm/Kconfig |7 + mm/page_alloc.c| 187 + 4 f

[RFC] memory hotremove patch take 2 [01/10] (counter of removable page)

2007-05-08 Thread Yasunori Goto
Show #of Movable pages and vmstat. Signed-Off-By: KAMEZAWA Hiroyuki <[EMAIL PROTECTED]> Signed-off-by: Yasunori Goto <[EMAIL PROTECTED]> arch/ia64/mm/init.c|2 ++ drivers/base/node.c|4 fs/proc/proc_misc.c|4 include/linux/kernel.h |2 ++ i

[RFC] memory hotremove patch take 2 [00/10]

2007-05-08 Thread Yasunori Goto
atch --- support page migration without acquiring mm->sem. need careful debug... ==other fixes== [8] round up end_pfn at memmap_init [9] page isolation ASAP when memory-hotremove case. [10] fix swapping-in page panic. -- Yasunori Goto - To unsubscribe from this list: send the line &q

[Patch] Fix unnecesary meminit

2007-05-08 Thread Yasunori Goto
r any module anytime. > > Both function are relatively small so better avoid playing games and > drop the __meminit tag. Ok. This is the patch. --- This is to fix unnecessary __meminit definition. These are exported for kernel modules. I compiled on ia64/x86-64 with memory hotpl

Re: [Patch] Fix section mismatch of memory hotplug related code.

2007-05-07 Thread Yasunori Goto
> On Fri, May 04, 2007 at 05:04:21PM -0700, Andrew Morton wrote: > > On Thu, 05 Apr 2007 17:01:02 +0900 > > Yasunori Goto <[EMAIL PROTECTED]> wrote: > > > > > Hello. > > > > > > This is to fix many section mismatches of code related to memor

Re: fragmentation avoidance Re: 2.6.22 -mm merge plans

2007-05-07 Thread Yasunori Goto
handle-kernelcore=-generic > > I believe Yasunori Goto is looking at these from the perspective of memory > hot-remove and has caught a few bugs in the past. Goto-san may be able to > comment on whether they have been reviewed recently. Hmm, I don't think my review is en

Re: [PATCH 2/2] Align ZONE_MOVABLE to a MAX_ORDER_NR_PAGES boundary

2007-04-24 Thread Yasunori Goto
Looks good. :-) Thanks. Acked-by: Yasunori Goto <[EMAIL PROTECTED]> > > The boot memory allocator makes assumptions on the alignment of zone > boundaries even though the buddy allocator has no requirements on the > alignment of zones. This may cause boot problems i

Re: [PATCH]Fix parsing kernelcore boot option for ia64

2007-04-24 Thread Yasunori Goto
> patch checks the zone boundaries when freeing pages from the bootmem > allocator. Anyway, the patch works well. Bye. -- Yasunori Goto - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo in

Re: [PATCH]Fix parsing kernelcore boot option for ia64

2007-04-24 Thread Yasunori Goto
its code can be common code. This is fix for it. I tested this patch on my ia64 box. Signed-off-by: Yasunori Goto <[EMAIL PROTECTED]> - arch/i386/kernel/setup.c |1 - arch/ia64/kernel/efi.c |2 -- arch/powerpc/kernel/prom.c |1 - arch/ppc/mm/init.c

Re: [PATCH] Make new setting of panic_on_oom

2007-04-23 Thread Yasunori Goto
This patch makes new setting for its request. This is tested on my ia64 box which has 3 nodes. Please apply. Signed-off-by: Yasunori Goto <[EMAIL PROTECTED]> Signed-off-by: Benjamin LaHaise <[EMAIL PROTECTED]> --- Documentation/sysctl/vm.txt | 23 +

Re: [PATCH]Fix parsing kernelcore boot option for ia64

2007-04-23 Thread Yasunori Goto
> On Fri, 13 Apr 2007 14:26:22 +0900 Yasunori Goto <[EMAIL PROTECTED]> wrote: > > > Hello. > > > > cmdline_parse_kernelcore() should return the next pointer of boot option > > like memparse() doing. If not, it is cause of eternal loop on ia64 box.

Re: [PATCH] Make new setting of panic_on_oom

2007-04-20 Thread Yasunori Goto
anic ASAP even if they are used. This patch makes new setting for its request. This is not tested yet. But it would work. Please apply. Signed-off-by: Yasunori Goto <[EMAIL PROTECTED]> --- Documentation/sysctl/vm.txt | 23 +-- mm/oom_kill.c |3 +++

[PATCH] Make new setting of panic_on_oom

2007-04-20 Thread Yasunori Goto
lease apply. Signed-off-by: Yasunori Goto <[EMAIL PROTECTED]> --- Documentation/sysctl/vm.txt | 23 +-- mm/oom_kill.c |3 +++ 2 files changed, 20 insertions(+), 6 deletions(-) Index: panic_on_oom2/Documentation/sy

Re: [PATCH] sysctl_panic_on_oom broken

2007-04-17 Thread Yasunori Goto
emory remain due to cpuset/mempolicy setting, some people may want failover soon. Of course some other people don't want panic if free memory remain. I think it depends on user. If panic_on_oom is 1, only panic if mempolicy/cpuset is not used. And if panic_on_oom is 2, panic on all case. Thi

[PATCH]Fix parsing kernelcore boot option for ia64

2007-04-12 Thread Yasunori Goto
Hello. cmdline_parse_kernelcore() should return the next pointer of boot option like memparse() doing. If not, it is cause of eternal loop on ia64 box. This patch is for 2.6.21-rc6-mm1. Signed-off-by: Yasunori Goto <[EMAIL PROTECTED]> arch/ia64/kernel/efi.c |2 +- include/linu

[Patch] Fix section mismatch of memory hotplug related code.

2007-04-05 Thread Yasunori Goto
Hello. This is to fix many section mismatches of code related to memory hotplug. I checked compile with memory hotplug on/off on ia64 and x86-64 box. This patch is for 2.6.21-rc5-mm4. Please apply. Signed-off-by: Yasunori Goto <[EMAIL PROTECTED]> --- arch/ia64/mm/discontig.c

[Patch] Add white list into modpost.c for memory hotplug code and ia64's machvec section

2007-04-05 Thread Yasunori Goto
and zone_wait_table_init() into white list. In addition, ia64's .machvec section is function table of some platform dependent code. It is mixture of .init.text and normal text. These reference of __init functions are valid too. This is for 2.6.21-rc5-mm4. Please apply. Signed-off-by: Yas

[RFC:PATCH]regster memory init functions into white list of section mismatch.

2007-03-28 Thread Yasunori Goto
d zone_wait_table_init() into white list. Please comment. If there is a more good way, please let me know... Thanks. P.S. Pattarn 10 is for ia64 (not for memory hotplug). ia64's .machvec section is mixture table of .init functions and normal text. It is defined for platform de

Re: 2.6.21-rc4-mm1 + 3 hot-fixes -- WARNING: could not find versions for .tmp_versions/built-in.mod

2007-03-23 Thread Yasunori Goto
mory hotplug code has __meminit for its purpose. But, I suspect that many other places of memory hotplug code may have same issue. I will chase them. BTW, does -mm code checks more strict than stock kernel? I can't see these warnings in 2.6.21-rc4. Bye. -- Yasunori Goto - To unsub

  1   2   >