Re: [RFC PATCH 2/7] RDMA/rxe: Convert the triple tasklets to workqueues

2022-09-12 Thread Yanjun Zhu
在 2022/9/12 15:58, matsuda-dais...@fujitsu.com 写道: On Mon, Sep 12, 2022 12:09 AM Bart Van Assche wrote: On 9/11/22 00:10, Yanjun Zhu wrote: I also implemented a workqueue for rxe. IMO, can we add a variable to decide to use tasklet or workqueue? If user prefer using tasklet, he can set the

Re: [RFC PATCH 2/7] RDMA/rxe: Convert the triple tasklets to workqueues

2022-09-12 Thread Yanjun Zhu
在 2022/9/11 23:08, Bart Van Assche 写道: On 9/11/22 00:10, Yanjun Zhu wrote: I also implemented a workqueue for rxe. IMO, can we add a variable to decide to use tasklet or workqueue? If user prefer using tasklet, he can set the variable to use tasklet. And the default is tasklet. Set the

Re: [RFC PATCH 2/7] RDMA/rxe: Convert the triple tasklets to workqueues

2022-09-11 Thread Yanjun Zhu
在 2022/9/7 10:43, Daisuke Matsuda 写道: In order to implement On-Demand Paging on the rxe driver, triple tasklets (requester, responder, and completer) must be allowed to sleep so that they can trigger page fault when pages being accessed are not present. This patch replaces the tasklets with work

Re: [PATCH] r8169: add enable_aspm parameter

2019-07-08 Thread Yanjun Zhu
On 2019/7/8 14:37, AceLan Kao wrote: We have many commits in the driver which enable and then disable ASPM function over and over again. commit b75bb8a5b755 ("r8169: disable ASPM again") commit 0866cd15029b ("r8169: enable ASPM on RTL8106E") commit 94235460f9ea ("r8169: Align ASPM/C

Re: [PATCH] net: sun: cassini: Cleanup license conflict

2019-01-21 Thread Yanjun Zhu
On 2019/1/19 0:30, Shannon Nelson wrote: On Fri, Jan 18, 2019 at 2:51 AM Thomas Gleixner wrote: The recent addition of SPDX license identifiers to the files in drivers/net/ethernet/sun created a licensing conflict. The cassini driver files contain a proper license notice: * This program

Re: [PATCH] net: nvidia: forcedeth: Fix two possible concurrency use-after-free bugs

2019-01-08 Thread Yanjun Zhu
On 2019/1/9 11:20, Jia-Ju Bai wrote: On 2019/1/9 10:35, Yanjun Zhu wrote: On 2019/1/9 10:03, Jia-Ju Bai wrote: On 2019/1/9 9:24, Yanjun Zhu wrote: On 2019/1/8 20:57, Jia-Ju Bai wrote: On 2019/1/8 20:54, Zhu Yanjun wrote: 在 2019/1/8 20:45, Jia-Ju Bai 写道: In drivers/net/ethernet

Re: [PATCH] net: nvidia: forcedeth: Fix two possible concurrency use-after-free bugs

2019-01-08 Thread Yanjun Zhu
On 2019/1/9 10:03, Jia-Ju Bai wrote: On 2019/1/9 9:24, Yanjun Zhu wrote: On 2019/1/8 20:57, Jia-Ju Bai wrote: On 2019/1/8 20:54, Zhu Yanjun wrote: 在 2019/1/8 20:45, Jia-Ju Bai 写道: In drivers/net/ethernet/nvidia/forcedeth.c, the functions nv_start_xmit() and nv_start_xmit_optimized

Re: [PATCH] net: nvidia: forcedeth: Fix two possible concurrency use-after-free bugs

2019-01-08 Thread Yanjun Zhu
On 2019/1/8 20:57, Jia-Ju Bai wrote: On 2019/1/8 20:54, Zhu Yanjun wrote: 在 2019/1/8 20:45, Jia-Ju Bai 写道: In drivers/net/ethernet/nvidia/forcedeth.c, the functions nv_start_xmit() and nv_start_xmit_optimized() can be concurrently executed with nv_poll_controller(). nv_start_xmit    line

Re: KASAN: null-ptr-deref Read in rds_ib_get_mr

2018-05-11 Thread Yanjun Zhu
On 2018/5/12 0:58, Santosh Shilimkar wrote: On 5/11/2018 12:48 AM, Yanjun Zhu wrote: On 2018/5/11 13:20, DaeRyong Jeong wrote: We report the crash: KASAN: null-ptr-deref Read in rds_ib_get_mr Note that this bug is previously reported by syzkaller. https://syzkaller.appspot.com/bug?id

Re: [rds-devel] KASAN: null-ptr-deref Read in rds_ib_get_mr

2018-05-11 Thread Yanjun Zhu
On 2018/5/11 18:46, Sowmini Varadhan wrote: On (05/11/18 15:48), Yanjun Zhu wrote: diff --git a/net/rds/ib_rdma.c b/net/rds/ib_rdma.c index e678699..2228b50 100644 --- a/net/rds/ib_rdma.c +++ b/net/rds/ib_rdma.c @@ -539,11 +539,17 @@ void rds_ib_flush_mrs(void) void *rds_ib_get_mr(struct

Re: KASAN: null-ptr-deref Read in rds_ib_get_mr

2018-05-11 Thread Yanjun Zhu
On 2018/5/11 13:20, DaeRyong Jeong wrote: We report the crash: KASAN: null-ptr-deref Read in rds_ib_get_mr Note that this bug is previously reported by syzkaller. https://syzkaller.appspot.com/bug?id=0bb56a5a48b000b52aa2b0d8dd20b1f545214d91 Nonetheless, this bug has not fixed yet, and we hope

Re: [PATCH] mlx4_core: allocate 4KB ICM chunks

2018-05-10 Thread Yanjun Zhu
On 2018/5/11 7:31, Qing Huang wrote: When a system is under memory presure (high usage with fragments), the original 256KB ICM chunk allocations will likely trigger kernel memory management to enter slow path doing memory compact/migration ops in order to complete high order memory allocations.

Re: [PATCH v4] nvmet,rxe: defer ip datagram sending to tasklet

2018-05-08 Thread Yanjun Zhu
On 2018/5/8 17:02, Alexandru Moise wrote: This addresses 3 separate problems: 1. When using NVME over Fabrics we may end up sending IP packets in interrupt context, we should defer this work to a tasklet. [ 50.939957] WARNING: CPU: 3 PID: 0 at kernel/softirq.c:161 __local_bh_enable_ip+0x1f

Re: [PATCH v3] nvmet,rxe: defer ip datagram sending to tasklet

2018-05-07 Thread Yanjun Zhu
On 2018/5/8 4:58, Alexandru Moise wrote: This addresses 3 separate problems: 1. When using NVME over Fabrics we may end up sending IP packets in interrupt context, we should defer this work to a tasklet. [ 50.939957] WARNING: CPU: 3 PID: 0 at kernel/softirq.c:161 __local_bh_enable_ip+0x1f/

Re: [PATCH] nvmet,rxe: defer ip datagram sending to tasklet

2018-05-07 Thread Yanjun Zhu
On 2018/5/7 6:20, Alexandru Moise wrote: When using NVME over Fabrics we may end up sending IP packets in interrupt context, we should defer this work to a tasklet. [ 50.939957] WARNING: CPU: 3 PID: 0 at kernel/softirq.c:161 __local_bh_enable_ip+0x1f/0xa0 [ 50.942602] CPU: 3 PID: 0 Comm: s

Re: [PATCH] IB/rxe: add RXE_START_MASK for rxe_opcode IB_OPCODE_RC_SEND_ONLY_INV

2018-04-25 Thread Yanjun Zhu
On 2018/4/26 11:52, Jianchao Wang wrote: w/o RXE_START_MASK, the last_psn of IB_OPCODE_RC_SEND_ONLY_INV will not be updated in update_wqe_psn, and the corresponding wqe will not be acked in rxe_completer due to its last_psn is zero. Finally, the other wqe will also not be able to be acked, beca

Re: [PATCH] IB/core: Make ib_mad_client_id atomic

2018-04-18 Thread Yanjun Zhu
On 2018/4/18 22:24, Håkon Bugge wrote: Two kernel threads may get the same value for agent.hi_tid, if the agents are registered for different ports. As of now, this works, as the agent list is per port. It is however confusing and not future robust. Hence, making it atomic. Signed-off-by: Håk

Re: [PATCH] IB/IPoIB: Replace netdev_priv with ipoib_priv for ipoib_get_link_ksettings

2017-05-18 Thread Yanjun Zhu
On 2017/5/11 20:40, Leon Romanovsky wrote: On Thu, May 11, 2017 at 03:31:10PM +0300, Yuval Shaia wrote: On Thu, May 11, 2017 at 08:14:28PM +0800, Honggang LI wrote: From: Honggang Li ipoib_dev_init accesses the private data for IPoIB net_device with ipoib_priv. ipoib_get_link_ksettings shou

Re: [PATCH] IB/IPoIB: Replace netdev_priv with ipoib_priv for ipoib_get_link_ksettings

2017-05-18 Thread Yanjun Zhu
On 2017/5/11 20:14, Honggang LI wrote: From: Honggang Li ipoib_dev_init accesses the private data for IPoIB net_device with ipoib_priv. ipoib_get_link_ksettings should do as ipoib_dev_init. Otherwise kernel panic. [ 27.271938] IPv6: ADDRCONF(NETDEV_CHANGE): mlx5_ib0.8006: link becomes read