Re: [PATCH] xfs: fail dax mount if reflink is enabled on a partition

2022-09-19 Thread Yang , Xiao/杨 晓
olume. https://lore.kernel.org/linux-xfs/20211129102203.2243509-1-...@lst.de/ 2) I can reproduce the failure of generic/482 without thin-volume. 3) Is it necessary to make thin-volume support DAX. Is there any use case for the requirement? Best Regards, Xiao Yang On 2022/9/16 10:04, Yang, Xia

Re: [PATCH] xfs: fail dax mount if reflink is enabled on a partition

2022-09-15 Thread Yang , Xiao/杨 晓
On 2022/9/15 18:14, Yang, Xiao/杨 晓 wrote: On 2022/9/15 0:28, Darrick J. Wong wrote: On Wed, Sep 14, 2022 at 08:34:26AM -0400, Brian Foster wrote: On Wed, Sep 14, 2022 at 05:38:02PM +0800, Yang, Xiao/杨 晓 wrote: On 2022/9/14 14:44, Yang, Xiao/杨 晓 wrote: On 2022/9/9 21:01, Brian Foster wrote

Re: [PATCH] xfs: fail dax mount if reflink is enabled on a partition

2022-09-15 Thread Yang , Xiao/杨 晓
On 2022/9/15 0:28, Darrick J. Wong wrote: On Wed, Sep 14, 2022 at 08:34:26AM -0400, Brian Foster wrote: On Wed, Sep 14, 2022 at 05:38:02PM +0800, Yang, Xiao/杨 晓 wrote: On 2022/9/14 14:44, Yang, Xiao/杨 晓 wrote: On 2022/9/9 21:01, Brian Foster wrote: Yes.. I don't recall all the interna

Re: [PATCH] xfs: fail dax mount if reflink is enabled on a partition

2022-09-14 Thread Yang , Xiao/杨 晓
On 2022/9/14 14:44, Yang, Xiao/杨 晓 wrote: On 2022/9/9 21:01, Brian Foster wrote: Yes.. I don't recall all the internals of the tools and test, but IIRC it relied on discard to perform zeroing between checkpoints or some such and avoid spurious failures. The purpose of running on dm-thi

Re: [PATCH] xfs: fail dax mount if reflink is enabled on a partition

2022-09-13 Thread Yang , Xiao/杨 晓
On 2022/9/9 21:01, Brian Foster wrote: Yes.. I don't recall all the internals of the tools and test, but IIRC it relied on discard to perform zeroing between checkpoints or some such and avoid spurious failures. The purpose of running on dm-thin was merely to provide reliable discard zeroing beha

Re: [PATCH] net: compat: fix msg_controllen overflow in scm_detach_fds_compat()

2019-06-04 Thread Yang Xiao
On Tue, Jun 4, 2019 at 8:46 PM Daniel Borkmann wrote: > > On 06/04/2019 02:31 PM, Young Xiao wrote: > > There is a missing check between kmsg->msg_controllen and cmlen, > > which can possibly lead to overflow. > > > > This bug is similar to vulnerability that was fixed in commit 6900317f5eff > > (

Re: [PATCH] media: davinci: vpif_capture: fix memory leak in vpif_probe()

2019-06-04 Thread Yang Xiao
On Tue, Jun 4, 2019 at 4:15 PM Lad, Prabhakar wrote: > > Hi Young, > > Thanks for the patch. > > On Tue, Jun 4, 2019 at 8:49 AM Young Xiao <92siuy...@gmail.com> wrote: > > > > If vpif_probe() fails on v4l2_device_register() and vpif_probe_complete(), > > then memory allocated at initialize_vpif()

Re: [PATCH] media: davinci: vpif_capture: fix memory leak in vpif_probe()

2019-06-04 Thread Yang Xiao
Yes, you are correct. I will fix the issue and resubmit the patch again. On Mon, Jun 3, 2019 at 7:55 PM Hans Verkuil wrote: > > On 5/29/19 3:09 PM, Young Xiao wrote: > > If vpif_probe() fails on vpif_probe_complete(), then memory > > allocated at initialize_vpif() for global vpif_obj.dev[i] > > b

Re: [PATCH] ipv6: Prevent overrun when parsing v6 header options

2019-06-04 Thread Yang Xiao
me time, there are bugs in mip6_destopt_offset() and mip6_destopt_offset(), which is similar to CVE-2017-7542. On Sat, Jun 1, 2019 at 1:35 AM Eric Dumazet wrote: > > > > On 5/30/19 8:04 PM, Yang Xiao wrote: > > On Fri, May 31, 2019 at 1:17 AM Eric Dumazet wrote: > >>

Re: [PATCH] ipvlan: Don't propagate IFF_ALLMULTI changes on down interfaces.

2019-06-03 Thread Yang Xiao
Based on your explanation, I found that the patch I submitted is useless. Great thanks and sorry for the trouble. On Mon, Jun 3, 2019 at 3:54 PM Xin Long wrote: > > On Mon, Jun 3, 2019 at 11:22 AM Young Xiao <92siuy...@gmail.com> wrote: > > > > Clearing the IFF_ALLMULTI flag on a down interface c

Re: [PATCH] ipv6: Prevent overrun when parsing v6 header options

2019-05-31 Thread Yang Xiao
On Fri, May 31, 2019 at 11:57 PM Eric Dumazet wrote: > > > > On 5/31/19 7:54 AM, Herbert Xu wrote: > > On Fri, May 31, 2019 at 07:50:06AM -0700, Eric Dumazet wrote: > >> > >> What do you mean by should ? > >> > >> Are they currently already linearized before the function is called, > >> or is it m

Re: [PATCH] ipv6: Prevent overrun when parsing v6 header options

2019-05-30 Thread Yang Xiao
On Fri, May 31, 2019 at 1:17 AM Eric Dumazet wrote: > > > > On 5/30/19 8:28 AM, Young Xiao wrote: > > The fragmentation code tries to parse the header options in order > > to figure out where to insert the fragment option. Since nexthdr points > > to an invalid option, the calculation of the size

Re: [PATCH] amd64-agp: fix arbitrary kernel memory writes

2019-05-29 Thread Yang Xiao
I am not so sure about taking off the cast, just to be in line with patch in 194b3da873fd. The comment can be deleted. On Wed, May 29, 2019 at 4:35 PM Greg KH wrote: > > On Wed, May 29, 2019 at 12:52:01PM +0800, Young Xiao wrote: > > pg_start is copied from userspace on AGPIOC_BIND and AGPIOC_UNB

Re: [PATCH] ipv4: tcp_input: fix stack out of bounds when parsing TCP options.

2019-05-29 Thread Yang Xiao
Indeed, condition opsize < 2 and opsize > length can deduce that length >= 2. However, before the condition (if opsize < 2), there may be one-byte out-of-bound access in line 12. I'm not sure whether I have put it very clearly. On Wed, May 29, 2019 at 10:20 PM Eric Dumazet wrote: > > On Wed, May

Re: [PATCH] vboxguest: check for private_data before trying to close it.

2019-05-28 Thread Yang Xiao
Based on your explanation, file->private_data can not be NULL before call vbg_core_close_session method all the time, since file->private_data is always set. Am I right? On Tue, May 28, 2019 at 9:19 PM Hans de Goede wrote: > > Hi, > > On 28-05-19 14:47, Young Xiao wrote: > > vbg_misc_device_close