Re: [PATCH v2 08/12] drm: bridge/dw_hdmi: add audio config interfaces

2015-02-03 Thread Yang Kuankuan
On 02/02/2015 08:09 AM, Russell King - ARM Linux wrote: On Mon, Feb 02, 2015 at 07:32:05AM -0500, Yang Kuankuan wrote: On 02/02/2015 06:53 AM, Russell King - ARM Linux wrote: On Mon, Feb 02, 2015 at 12:02:50PM +0800, Daniel Kurtz wrote: Hi ykk, On Sat, Jan 31, 2015 at 10:34 PM, Yang

Re: [PATCH v2 08/12] drm: bridge/dw_hdmi: add audio config interfaces

2015-02-02 Thread Yang Kuankuan
On 02/02/2015 08:09 AM, Russell King - ARM Linux wrote: On Mon, Feb 02, 2015 at 07:32:05AM -0500, Yang Kuankuan wrote: On 02/02/2015 06:53 AM, Russell King - ARM Linux wrote: On Mon, Feb 02, 2015 at 12:02:50PM +0800, Daniel Kurtz wrote: Hi ykk, On Sat, Jan 31, 2015 at 10:34 PM, Yang

Re: [PATCH v2 01/12] drm: bridge/dw_hdmi: adjust n/cts setting order

2015-02-02 Thread Yang Kuankuan
On 01/31/2015 06:07 AM, Russell King - ARM Linux wrote: On Fri, Jan 30, 2015 at 06:25:30AM -0500, Yakir Yang wrote: For Designerware HDMI, the following write sequence is recommended: 1. aud_n3 (set bit ncts_atomic_write if desired) 2. aud_cts3 (set CTS_manual and CTS value if desired/enabled)

Re: [PATCH v2 0/12] Those patches is used for dw_hdmi audio support

2015-02-02 Thread Yang Kuankuan
On 01/31/2015 07:00 AM, Russell King - ARM Linux wrote: On Fri, Jan 30, 2015 at 06:23:51AM -0500, Yakir Yang wrote: We found Designware hdmi driver only support audio clock config, we can not play sound through it. To add Designware HDMI Audio support, we make those patch set: 1): modify n/c

Re: [PATCH v2 08/12] drm: bridge/dw_hdmi: add audio config interfaces

2015-02-02 Thread Yang Kuankuan
On 02/02/2015 06:53 AM, Russell King - ARM Linux wrote: On Mon, Feb 02, 2015 at 12:02:50PM +0800, Daniel Kurtz wrote: Hi ykk, On Sat, Jan 31, 2015 at 10:34 PM, Yang Kuankuan wrote: On 01/31/2015 06:48 AM, Russell King - ARM Linux wrote: +void hdmi_audio_clk_enable(struct dw_hdmi *hdmi

Re: [PATCH v2 05/12] drm: rockchip/vop: filter interlace display mode

2015-02-02 Thread Yang Kuankuan
On 02/02/2015 03:00 AM, Daniel Kurtz wrote: Hi ykk, On Fri, Jan 30, 2015 at 7:29 PM, Yakir Yang wrote: RK3288's VOP do not support INTERLACE display mode, so we should remove those modes out of mode_ok list. Signed-off-by: Yakir Yang Reviewed-by: Daniel Kurtz Can you move this patch out

Re: [PATCH v2 08/12] drm: bridge/dw_hdmi: add audio config interfaces

2015-01-31 Thread Yang Kuankuan
On 01/31/2015 06:48 AM, Russell King - ARM Linux wrote: On Fri, Jan 30, 2015 at 06:32:23AM -0500, Yakir Yang wrote: +static void hdmi_config_audio(struct dw_hdmi *hdmi, + struct hdmi_audio_fmt *aud_fmt) +{ + if (aud_fmt) + hdmi->aud_fmt = *aud_fmt

Re: [PATCH v2 12/12] dt-bindings: Add documentation for Rockchip dw-hdmi-audio

2015-01-31 Thread Yang Kuankuan
On 01/31/2015 06:36 AM, Russell King - ARM Linux wrote: On Fri, Jan 30, 2015 at 06:44:13AM -0500, Yakir Yang wrote: Required properties: - compatible: platform specific - cpu-of-node: the device node of cpu_dai Signed-off-by: Yakir Yang --- Changes in v2: - remove codec-name and codec-dai-nam

Re: [PATCH v2 06/12] drm: bridge/dw_hdmi: add audio support for more display resolutions

2015-01-31 Thread Yang Kuankuan
On 01/31/2015 06:20 AM, Russell King - ARM Linux wrote: On Fri, Jan 30, 2015 at 06:30:39AM -0500, Yakir Yang wrote: Add more n/cts values, in that case we can support audio for more display resolutions (128 * SampleRate = PixelClock * N / CTS). Where do these come from? The iMX6 manuals give

Re: [PATCH v2 04/12] drm: rockchip/dw_hdmi_rockchip: add resume/suspend support

2015-01-31 Thread Yang Kuankuan
On 01/31/2015 06:13 AM, Russell King - ARM Linux wrote: On Fri, Jan 30, 2015 at 06:28:59AM -0500, Yakir Yang wrote: Signed-off-by: Yakir Yang --- Changes in v2: - Add suspend/resume support for dw_hdmi_rockchip driver drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 13 + 1 file c

Re: [PATCH v2 02/12] drm: bridge/dw_hdmi: add audio sample channel status setting

2015-01-31 Thread Yang Kuankuan
On 01/31/2015 06:08 AM, Russell King - ARM Linux wrote: On Fri, Jan 30, 2015 at 06:27:10AM -0500, Yakir Yang wrote: When transmitting IEC60985 linear PCM audio, we configure the Aduio Sample Channel Status information of all the channel status bits in the IEC60958 frame. Signed-off-by: Yakir Y

Re: [PATCH v2 03/12] drm: bridge/dw_hdmi: add irq control to suspend/resume

2015-01-31 Thread Yang Kuankuan
On 01/31/2015 06:11 AM, Russell King - ARM Linux wrote: On Fri, Jan 30, 2015 at 06:28:00AM -0500, Yakir Yang wrote: diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c index 2ded957..13f26af 100644 --- a/drivers/gpu/drm/bridge/dw_hdmi.c +++ b/drivers/gpu/drm/bridge/