Re: [PATCH bpf-next v3 2/4] bpf: Add log for attaching tracing programs to functions in deny list

2025-07-23 Thread Yafang Shao
gt; $ ./fentry > libbpf: prog 'migrate_disable': BPF program load failed: -EINVAL > libbpf: prog 'migrate_disable': -- BEGIN PROG LOAD LOG -- > Attaching tracing programs to function 'migrate_disable' is rejected. > > Suggested-by: Leon Hwang > Signed-o

Re: [PATCH bpf-next v3 1/4] bpf: Show precise rejected function when attaching fexit/fmod_ret to __noreturn functions

2025-07-23 Thread Yafang Shao
rog 'fexit': -- BEGIN PROG LOAD LOG -- > Attaching fexit/fmod_ret to __noreturn function 'do_exit' is rejected. > > Suggested-by: Leon Hwang > Signed-off-by: KaFai Wan Acked-by: Yafang Shao > --- > kernel/bpf/verifier.c | 3 +

Re: [PATCH bpf-next 2/3] bpf: Show precise rejected function when attaching to __btf_id functions

2025-07-11 Thread Yafang Shao
On Fri, Jul 11, 2025 at 1:19 AM Alexei Starovoitov wrote: > > On Thu, Jul 10, 2025 at 9:27 AM KaFai Wan wrote: > > > > Show the precise rejected function name when attaching tracing to > > __btf_id functions. > > > > $ ./fentry > > libbpf: prog 'migrate_disable': BPF program load failed: -EINVAL

Re: [PATCH v2 2/2] livepatch: Replace tasklist_lock with RCU

2025-02-25 Thread Yafang Shao
On Wed, Feb 26, 2025 at 2:33 AM Josh Poimboeuf wrote: > > On Sun, Feb 23, 2025 at 02:20:46PM +0800, Yafang Shao wrote: > > +++ b/kernel/livepatch/patch.c > > @@ -95,7 +95,12 @@ static void notrace klp_ftrace_handler(unsigned long ip, > > > > patc

[PATCH v2 1/2] livepatch: Add comment to clarify klp_add_nops()

2025-02-22 Thread Yafang Shao
Add detailed comments to clarify the purpose of klp_add_nops() function. These comments are based on Petr's explanation[0]. Link: https://lore.kernel.org/all/z6xua7d0eu_yd...@pathway.suse.cz/ [0] Suggested-by: Petr Mladek Suggested-by: Josh Poimboeuf Signed-off-by: Yafang Shao --- k

[PATCH v2 2/2] livepatch: Replace tasklist_lock with RCU

2025-02-22 Thread Yafang Shao
@jpoimboe/ [1] Signed-off-by: Yafang Shao --- include/linux/livepatch.h | 4 ++-- kernel/fork.c | 2 +- kernel/livepatch/patch.c | 7 ++- kernel/livepatch/transition.c | 35 ++- kernel/livepatch/transition.h | 1 + 5 files changed, 24

[PATCH v2 0/2] livepatch: some improvements

2025-02-22 Thread Yafang Shao
the root cause is identified, I will submit the fix separately. v1: https://lore.kernel.org/live-patching/20250211062437.46811-1-laoar.s...@gmail.com/ Yafang Shao (2): livepatch: Add comment to clarify klp_add_nops() livepatch: Replace tasklist_lock with RCU include/linux/livepatch.h |

Re: [RFC PATCH 0/2] livepatch: Add support for hybrid mode

2025-02-09 Thread Yafang Shao
On Sat, Feb 8, 2025 at 10:49 AM Yafang Shao wrote: > > On Fri, Feb 7, 2025 at 7:01 PM Petr Mladek wrote: > > > > On Wed 2025-02-05 14:16:42, Yafang Shao wrote: > > > On Tue, Feb 4, 2025 at 9:05 PM Petr Mladek wrote: > > > > > > > > On Mon 2025-

Re: [RFC PATCH 0/2] livepatch: Add support for hybrid mode

2025-02-09 Thread Yafang Shao
On Sun, Feb 9, 2025 at 11:57 AM Alexei Starovoitov wrote: > > On Sat, Feb 8, 2025 at 11:32 AM Josh Poimboeuf wrote: > > > > On Sat, Feb 08, 2025 at 07:47:12AM -0800, Alexei Starovoitov wrote: > > > On Fri, Feb 7, 2025 at 10:42 PM Yafang Shao wrote: > > > >

Re: [RFC PATCH 0/2] livepatch: Add support for hybrid mode

2025-02-07 Thread Yafang Shao
On Fri, Feb 7, 2025 at 2:01 AM Song Liu wrote: > > On Wed, Feb 5, 2025 at 6:55 PM Yafang Shao wrote: > [...] > > > I think we should first understand why the trampoline is not > > > freed. > > > > IIUC, the fexit works as follows, > > >

Re: [RFC PATCH 2/2] livepatch: Implement livepatch hybrid mode

2025-02-07 Thread Yafang Shao
On Sat, Feb 8, 2025 at 12:59 AM Josh Poimboeuf wrote: > > On Fri, Feb 07, 2025 at 11:16:45AM +0800, Yafang Shao wrote: > > On Fri, Feb 7, 2025 at 10:31 AM Josh Poimboeuf wrote: > > > Why does this happen? > > > > It occurs during the KLP transition. It seems like

Re: [RFC PATCH 2/2] livepatch: Implement livepatch hybrid mode

2025-02-07 Thread Yafang Shao
On Fri, Feb 7, 2025 at 9:58 PM Petr Mladek wrote: > > On Thu 2025-02-06 10:35:11, Yafang Shao wrote: > > On Thu, Feb 6, 2025 at 12:03 AM Petr Mladek wrote: > > > > > > On Wed 2025-02-05 10:54:47, Yafang Shao wrote: > > > > On Tue, Feb 4, 2025 at 9:21 PM

Re: [RFC PATCH 0/2] livepatch: Add support for hybrid mode

2025-02-07 Thread Yafang Shao
On Fri, Feb 7, 2025 at 7:01 PM Petr Mladek wrote: > > On Wed 2025-02-05 14:16:42, Yafang Shao wrote: > > On Tue, Feb 4, 2025 at 9:05 PM Petr Mladek wrote: > > > > > > On Mon 2025-02-03 17:44:52, Yafang Shao wrote: > > > > On Fri, Jan

Re: [RFC PATCH 2/2] livepatch: Implement livepatch hybrid mode

2025-02-07 Thread Yafang Shao
On Fri, Feb 7, 2025 at 5:36 PM Petr Mladek wrote: > > On Fri 2025-02-07 11:16:45, Yafang Shao wrote: > > On Fri, Feb 7, 2025 at 10:31 AM Josh Poimboeuf wrote: > > > On Mon, Jan 27, 2025 at 02:35:26PM +0800, Yafang Shao wrote: > > > > - Temporary Loss of Patc

Re: [RFC PATCH 2/2] livepatch: Implement livepatch hybrid mode

2025-02-06 Thread Yafang Shao
On Fri, Feb 7, 2025 at 10:31 AM Josh Poimboeuf wrote: > > On Mon, Jan 27, 2025 at 02:35:26PM +0800, Yafang Shao wrote: > > The atomic replace livepatch mechanism was introduced to handle scenarios > > where we want to unload a specific livepatch without unloading others. > &

Re: [RFC PATCH 0/2] livepatch: Add support for hybrid mode

2025-02-05 Thread Yafang Shao
On Thu, Feb 6, 2025 at 1:59 AM Song Liu wrote: > > On Wed, Feb 5, 2025 at 6:43 AM Yafang Shao wrote: > > > > On Tue, Feb 4, 2025 at 5:53 AM Song Liu wrote: > > > > > > On Mon, Feb 3, 2025 at 1:45 AM Yafang Shao wrote: > > > [...] > > >

Re: [RFC PATCH 2/2] livepatch: Implement livepatch hybrid mode

2025-02-05 Thread Yafang Shao
On Thu, Feb 6, 2025 at 12:03 AM Petr Mladek wrote: > > On Wed 2025-02-05 10:54:47, Yafang Shao wrote: > > On Tue, Feb 4, 2025 at 9:21 PM Petr Mladek wrote: > > > > > > On Mon 2025-01-27 23:34:50, Yafang Shao wrote: > > > > On Mon, J

Re: [RFC PATCH 0/2] livepatch: Add support for hybrid mode

2025-02-05 Thread Yafang Shao
On Tue, Feb 4, 2025 at 5:53 AM Song Liu wrote: > > On Mon, Feb 3, 2025 at 1:45 AM Yafang Shao wrote: > [...] > > > > If you’re managing a large fleet of servers, this issue is far from > > negligible. > > > > > > > > > Can you provid

Re: [RFC PATCH 0/2] livepatch: Add support for hybrid mode

2025-02-04 Thread Yafang Shao
On Tue, Feb 4, 2025 at 9:05 PM Petr Mladek wrote: > > On Mon 2025-02-03 17:44:52, Yafang Shao wrote: > > On Fri, Jan 31, 2025 at 9:18 PM Miroslav Benes wrote: > > > > > > > > > > > > > + What exactly is meant by frequent replacements (busy lo

Re: [RFC PATCH 2/2] livepatch: Implement livepatch hybrid mode

2025-02-04 Thread Yafang Shao
On Tue, Feb 4, 2025 at 9:21 PM Petr Mladek wrote: > > On Mon 2025-01-27 23:34:50, Yafang Shao wrote: > > On Mon, Jan 27, 2025 at 10:31 PM Petr Mladek wrote: > > > > > > On Mon 2025-01-27 14:35:26, Yafang Shao wrote: > > > > The atomic replace li

Re: [RFC PATCH 0/2] livepatch: Add support for hybrid mode

2025-02-03 Thread Yafang Shao
On Fri, Jan 31, 2025 at 9:18 PM Miroslav Benes wrote: > > > > > > > + What exactly is meant by frequent replacements (busy loop?, once a > > > minute?) > > > > The script: > > > > #!/bin/bash > > while true; do > > yum install -y ./kernel-livepatch-6.1.12-0.x86_64.rpm > > ./appl

Re: [RFC PATCH 2/2] livepatch: Implement livepatch hybrid mode

2025-01-27 Thread Yafang Shao
On Mon, Jan 27, 2025 at 10:31 PM Petr Mladek wrote: > > On Mon 2025-01-27 14:35:26, Yafang Shao wrote: > > The atomic replace livepatch mechanism was introduced to handle scenarios > > where we want to unload a specific livepatch without unloading others. > > However, it

Re: [RFC PATCH 0/2] livepatch: Add support for hybrid mode

2025-01-27 Thread Yafang Shao
On Mon, Jan 27, 2025 at 9:46 PM Petr Mladek wrote: > > On Mon 2025-01-27 14:35:24, Yafang Shao wrote: > > The atomic replace livepatch mechanism was introduced to handle scenarios > > where we want to unload a specific livepatch without unloading others. > > However, it

[RFC PATCH 2/2] livepatch: Implement livepatch hybrid mode

2025-01-26 Thread Yafang Shao
lore.kernel.org/live-patching/CALOAHbA9WHPjeZKUcUkwULagQjTMfqAdAg+akqPzbZ7Byc=q...@mail.gmail.com/ [0] Signed-off-by: Yafang Shao --- kernel/livepatch/core.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c index 5e0c2caa0af8..f820b50c1b26

[RFC PATCH 0/2] livepatch: Add support for hybrid mode

2025-01-26 Thread Yafang Shao
pport it in kpatch[1] Link: https://lore.kernel.org/live-patching/CALOAHbA9WHPjeZKUcUkwULagQjTMfqAdAg+akqPzbZ7Byc=q...@mail.gmail.com/ [0] Link: https://github.com/dynup/kpatch [1] Yafang Shao (2): livepatch: Add replaceable attribute livepatch: Implement livepatch hybrid mode include/li

[RFC PATCH 1/2] livepatch: Add replaceable attribute

2025-01-26 Thread Yafang Shao
Add a new attribute "replaceable" to allow the coexsist of both atomic replace livepatch and non atomic replace livepatch. If the replaceable is set to 0, the livepatch won't be replaced by a atomic replace livepatch. This is a preparation for the followup patch. Signed-off-

Re: [PATCH bpf v5 2/2] selftests/bpf: fix perf_event link info name_len assertion

2024-10-06 Thread Yafang Shao
...@mail.gmail.com/ > Fixes: 23cf7aa539dc ("selftests/bpf: Add selftest for fill_link_info") > Signed-off-by: tyrone-wu > Acked-by: Jiri Olsa Acked-by: Yafang Shao > --- > V4 -> V5: no change > > V3 -> V4: > Link: https://lore.kernel.org/bpf/Zv_PP6

Re: [PATCH bpf v5 1/2] bpf: fix unpopulated name_len field in perf_event link info

2024-10-06 Thread Yafang Shao
.com/ > Fixes: 1b715e1b0ec5 ("bpf: Support ->fill_link_info for perf_event") > Signed-off-by: tyrone-wu > Acked-by: Jiri Olsa LGTM Acked-by: Yafang Shao > --- > V4 -> V5: > Link: > https://lore.kernel.org/bpf/caloahbc5xm7cbfhau3z5x2pquhihecnwaptjcwiovqtkmdz...@

Re: [PATCH bpf v4 1/2] bpf: fix unpopulated name_len field in perf_event link info

2024-10-05 Thread Yafang Shao
On Fri, Oct 4, 2024 at 11:40 PM tyrone-wu wrote: > > Previously when retrieving `bpf_link_info.perf_event` for > kprobe/uprobe/tracepoint, the `name_len` field was not populated by the > kernel, leaving it to reflect the value initially set by the user. This > behavior was inconsistent with how ot

[PATCH] delayacct: clear right task's flag after blkio completes

2021-04-14 Thread Yafang Shao
helpers, after that change, the callsite will specifilly set the right task, which should make it less error prone. Signed-off-by: Yafang Shao Cc: Tejun Heo Cc: Josh Snyder --- include/linux/delayacct.h | 20 ++-- mm/memory.c | 8 2 files changed, 14 ins

Re: [PATCH v2 0/6] sched: support schedstats for RT sched class

2021-04-06 Thread Yafang Shao
On Sat, Mar 27, 2021 at 6:13 PM Yafang Shao wrote: > > We want to measure the latency of RT tasks in our production > environment with schedstats facility, but currently schedstats is only > supported for fair sched class. In order to support if for other sched > classes, we

[PATCH v2 6/6] sched, rt: support schedstats for RT sched class

2021-03-27 Thread Yafang Shao
elay=1001238954 [ns] [ In sleep.sh, it sleeps 1 sec each time. ] [l...@intel.com: reported build failure in prev version] Signed-off-by: Yafang Shao Cc: kernel test robot --- kernel/sched/rt.c | 137 ++ 1 file changed, 137 insertions(+) diff --g

[PATCH v2 5/6] sched, rt: support sched_stat_runtime tracepoint for RT sched class

2021-03-27 Thread Yafang Shao
48[039] d.h. 113.521352: sched_stat_runtime: comm=stress pid=9748 runtime=998203 [ns] vruntime=0 [ns] Signed-off-by: Yafang Shao --- kernel/sched/rt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c index 34ad07fb924e..ae5282484710 100644 --- a/ke

[PATCH v2 4/6] sched: introduce task block time in schedstats

2021-03-27 Thread Yafang Shao
it is more critital than S state. So it is worth to add a metric to measure it. Signed-off-by: Yafang Shao --- include/linux/sched.h | 2 ++ kernel/sched/debug.c | 6 -- kernel/sched/stats.c | 1 + 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/include/linux/sched.h b/in

[PATCH v2 3/6] sched: make schedstats helpers independent of fair sched class

2021-03-27 Thread Yafang Shao
re in prev version] Signed-off-by: Yafang Shao Acked-by: Mel Gorman Cc: kernel test robot --- kernel/sched/fair.c | 133 +++ kernel/sched/stats.c | 103 + kernel/sched/stats.h | 34 +++ 3 files changed, 156 insertio

[PATCH v2 2/6] sched: make struct sched_statistics independent of fair sched class

2021-03-27 Thread Yafang Shao
6.0~6.1 kernel.sched_schedstats=1 6.2~6.46.2~6.4 No obvious impact on the sched performance. No functional change. [l...@intel.com: reported build failure in prev version] Signed-off-by: Yafang Shao Acked-by: Mel Gorman Cc: kernel test robot --- include/lin

[PATCH v2 0/6] sched: support schedstats for RT sched class

2021-03-27 Thread Yafang Shao
Mel. - make struct schedstats independent of fair sched class Yafang Shao (6): sched, fair: use __schedstat_set() in set_next_entity() sched: make struct sched_statistics independent of fair sched class sched: make schedstats helpers independent of fair sched class sched: introduce task block t

[PATCH v2 1/6] sched, fair: use __schedstat_set() in set_next_entity()

2021-03-27 Thread Yafang Shao
schedstat_enabled() has been already checked, so we can use __schedstat_set() directly. Signed-off-by: Yafang Shao Acked-by: Mel Gorman --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index aaa0dfa29d53

Re: [PATCH v6 resend 0/3] mm, vsprintf: dump full information of page flags in pGp

2021-03-19 Thread Yafang Shao
On Fri, Mar 19, 2021 at 6:13 PM Yafang Shao wrote: > > The existed pGp shows the names of page flags only, rather than the full > information including section, node, zone, last cpuipid and kasan tag. > While it is not easy to parse these information manually because there > are

[PATCH v6 resend 2/3] mm, slub: don't combine pr_err with INFO

2021-03-19 Thread Yafang Shao
(slab|head) - after the patch [ 6343.396602] Slab 0x4382e02b objects=33 used=3 fp=0x9ae06ffc flags=0x17c0010200(slab|head) [1]. https://lore.kernel.org/linux-mm/b9c0f2b6-e9b0-0c36-ebdd-2bc684c5a...@redhat.com/#t Suggested-by: Vlastimil Babka Signed-off-by: Yafang Shao Acked-by

[PATCH v6 resend 0/3] mm, vsprintf: dump full information of page flags in pGp

2021-03-19 Thread Yafang Shao
the test cases, per Andy Yafang Shao (3): mm, slub: use pGp to print page flags mm, slub: don't combine pr_err with INFO vsprintf: dump full information of page flags in pGp Documentation/core-api/printk-formats.rst | 2 +- lib/test_printf.c | 90 ++

[PATCH v6 resend 3/3] vsprintf: dump full information of page flags in pGp

2021-03-19 Thread Yafang Shao
f) The documentation and test cases are also updated. The output of the test cases as follows, [68599.816764] test_printf: loaded. [68599.819068] test_printf: all 388 tests passed [68599.830367] test_printf: unloaded. [l...@intel.com: reported issues in the prev version in test_printf.c] Signe

[PATCH v6 resend 1/3] mm, slub: use pGp to print page flags

2021-03-19 Thread Yafang Shao
ut is, [ 8846.517809] INFO: Slab 0xf42a2c60 objects=33 used=3 fp=0x60d32ca8 flags=0x17c0010200(slab|head) Signed-off-by: Yafang Shao Reviewed-by: David Hildenbrand Reviewed-by: Vlastimil Babka Acked-by: David Rientjes Acked-by: Christoph Lameter Reviewed-by: Matthew Wilcox (Oracle) Rev

Re: linux-next: Tree for Mar 10 (lib/test_printf.c)

2021-03-14 Thread Yafang Shao
On Wed, Mar 10, 2021 at 5:52 PM Petr Mladek wrote: > > On Tue 2021-03-09 21:57:48, Randy Dunlap wrote: > > On 3/9/21 8:02 PM, Stephen Rothwell wrote: > > > Hi all, > > > > > > > on i386 (at least): > > > > ../lib/test_printf.c: In function 'page_flags_test': > > ../lib/test_printf.c:595:17: error:

[PATCH v6 2/3] mm, slub: don't combine pr_err with INFO

2021-03-14 Thread Yafang Shao
(slab|head) - after the patch [ 6343.396602] Slab 0x4382e02b objects=33 used=3 fp=0x9ae06ffc flags=0x17c0010200(slab|head) [1]. https://lore.kernel.org/linux-mm/b9c0f2b6-e9b0-0c36-ebdd-2bc684c5a...@redhat.com/#t Suggested-by: Vlastimil Babka Signed-off-by: Yafang Shao Acked-by

[PATCH v6 1/3] mm, slub: use pGp to print page flags

2021-03-14 Thread Yafang Shao
ut is, [ 8846.517809] INFO: Slab 0xf42a2c60 objects=33 used=3 fp=0x60d32ca8 flags=0x17c0010200(slab|head) Signed-off-by: Yafang Shao Reviewed-by: David Hildenbrand Reviewed-by: Vlastimil Babka Acked-by: David Rientjes Acked-by: Christoph Lameter Reviewed-by: Matthew Wilcox (Oracle) Rev

[PATCH v6 3/3] vsprintf: dump full information of page flags in pGp

2021-03-14 Thread Yafang Shao
f) The documentation and test cases are also updated. The output of the test cases as follows, [68599.816764] test_printf: loaded. [68599.819068] test_printf: all 388 tests passed [68599.830367] test_printf: unloaded. [l...@intel.com: reported issues in the prev version in test_printf.c] Signe

[PATCH v6 0/3] mm, vsprintf: dump full information of page flags in pGp

2021-03-14 Thread Yafang Shao
the test cases, per Andy Yafang Shao (3): mm, slub: use pGp to print page flags mm, slub: don't combine pr_err with INFO vsprintf: dump full information of page flags in pGp Documentation/core-api/printk-formats.rst | 2 +- lib/test_printf.c | 90 ++

[PATCH 1/1] vsprintf: dump full information of page flags in pGp fix

2021-02-22 Thread Yafang Shao
e flags in pGp" [1] [1]. https://lore.kernel.org/linux-mm/20210215155141.47432-1-laoar.s...@gmail.com/ Signed-off-by: Yafang Shao Cc: Petr Mladek Cc: Matthew Wilcox Cc: Andy Shevchenko Cc: Vlastimil Babka Cc: Miaohe Lin Cc: Joe Perches Cc: David Hildenbrand --- lib/vsprintf.c | 2 +-

Re: [PATCH v5 3/3] vsprintf: dump full information of page flags in pGp

2021-02-22 Thread Yafang Shao
On Mon, Feb 22, 2021 at 8:38 PM Petr Mladek wrote: > > Hello, > > first, I am sorry for the late reply. I have marked the thread as > proceed by mistake last week... > > > On Mon 2021-02-15 23:51:41, Yafang Shao wrote: > > Currently the pGp only shows the names of p

Re: [PATCH v5 3/3] vsprintf: dump full information of page flags in pGp

2021-02-22 Thread Yafang Shao
On Mon, Feb 15, 2021 at 11:53 PM Yafang Shao wrote: > > Currently the pGp only shows the names of page flags, rather than > the full information including section, node, zone, last cpupid and > kasan tag. While it is not easy to parse these information manually > because there

[PATCH v5 2/3] mm, slub: don't combine pr_err with INFO

2021-02-15 Thread Yafang Shao
(slab|head) - after the patch [ 6343.396602] Slab 0x4382e02b objects=33 used=3 fp=0x9ae06ffc flags=0x17c0010200(slab|head) [1]. https://lore.kernel.org/linux-mm/b9c0f2b6-e9b0-0c36-ebdd-2bc684c5a...@redhat.com/#t Suggested-by: Vlastimil Babka Signed-off-by: Yafang Shao Acked-by

[PATCH v5 0/3] mm, vsprintf: dump full information of page flags in pGp

2021-02-15 Thread Yafang Shao
x of it, per Joe and Matthew - introduce new format instead of changing pGp, per Andy v2: - various coding improvement, per Joe, Miaohe, Vlastimil and Andy - remove the prefix completely in patch #2, per Vlastimil - Update the test cases, per Andy Yafang Shao (3): mm, slub: use pGp to print p

[PATCH v5 3/3] vsprintf: dump full information of page flags in pGp

2021-02-15 Thread Yafang Shao
f) The documentation and test cases are also updated. The output of the test cases as follows, [11585.830272] test_printf: loaded. [11585.830454] test_printf: all 388 tests passed [11585.831401] test_printf: unloaded. Signed-off-by: Yafang Shao Cc: David Hildenbrand Cc: Joe Perches Cc: Miaohe

[PATCH v5 1/3] mm, slub: use pGp to print page flags

2021-02-15 Thread Yafang Shao
ut is, [ 8846.517809] INFO: Slab 0xf42a2c60 objects=33 used=3 fp=0x60d32ca8 flags=0x17c0010200(slab|head) Signed-off-by: Yafang Shao Reviewed-by: David Hildenbrand Reviewed-by: Vlastimil Babka Acked-by: David Rientjes Acked-by: Christoph Lameter Reviewed-by: Matthew Wilcox (Oracle) Rev

Re: [PATCH v4 3/3] vsprintf: dump full information of page flags in pGp

2021-02-10 Thread Yafang Shao
On Wed, Feb 10, 2021 at 8:51 PM Petr Mladek wrote: > > On Wed 2021-02-10 00:21:37, Yafang Shao wrote: > > On Tue, Feb 9, 2021 at 9:53 PM Petr Mladek wrote: > > > > > > On Tue 2021-02-09 18:56:13, Yafang Shao wrote: > > > > Currently the pGp only

Re: [PATCH v4 3/3] vsprintf: dump full information of page flags in pGp

2021-02-09 Thread Yafang Shao
On Tue, Feb 9, 2021 at 9:53 PM Petr Mladek wrote: > > On Tue 2021-02-09 18:56:13, Yafang Shao wrote: > > Currently the pGp only shows the names of page flags, rather than > > the full information including section, node, zone, last cpupid and > > kasan tag. While it is

[PATCH v4 3/3] vsprintf: dump full information of page flags in pGp

2021-02-09 Thread Yafang Shao
f) The documentation and test cases are also updated. The output of the test cases as follows, [ 501.485081] test_printf: loaded. [ 501.485768] test_printf: all 388 tests passed [ 501.488762] test_printf: unloaded. Signed-off-by: Yafang Shao Cc: David Hildenbrand Cc: Joe Perches Cc: Miaohe

[PATCH v4 2/3] mm, slub: don't combine pr_err with INFO

2021-02-09 Thread Yafang Shao
(slab|head) - after the patch [ 6343.396602] Slab 0x4382e02b objects=33 used=3 fp=0x9ae06ffc flags=0x17c0010200(slab|head) [1]. https://lore.kernel.org/linux-mm/b9c0f2b6-e9b0-0c36-ebdd-2bc684c5a...@redhat.com/#t Suggested-by: Vlastimil Babka Signed-off-by: Yafang Shao Acked-by

[PATCH v4 1/3] mm, slub: use pGp to print page flags

2021-02-09 Thread Yafang Shao
ut is, [ 8846.517809] INFO: Slab 0xf42a2c60 objects=33 used=3 fp=0x60d32ca8 flags=0x17c0010200(slab|head) Signed-off-by: Yafang Shao Reviewed-by: David Hildenbrand Reviewed-by: Vlastimil Babka Acked-by: David Rientjes Acked-by: Christoph Lameter Reviewed-by: Matthew Wilcox (Oracle) Rev

[PATCH v4 0/3] mm, vsprintf: dump full information of page flags in pGp

2021-02-09 Thread Yafang Shao
anging pGp, per Andy v2: - various coding improvement, per Joe, Miaohe, Vlastimil and Andy - remove the prefix completely in patch #2, per Vlastimil - Update the test cases, per Andy Yafang Shao (3): mm, slub: use pGp to print page flags mm, slub: don't combine pr_err with INFO vsprin

Re: [PATCH v3 0/3] mm, vsprintf: introduce new format to dump full information of page flags

2021-02-08 Thread Yafang Shao
On Mon, Feb 8, 2021 at 8:20 PM Matthew Wilcox wrote: > > On Mon, Feb 08, 2021 at 06:14:36PM +0800, Yafang Shao wrote: > > To avoid breaking some tools which parsing pGp via debugfs or affecting > > the printf buffer, other new formats are introduced, so the user can choose >

[PATCH v3 1/3] mm, slub: use pGp to print page flags

2021-02-08 Thread Yafang Shao
ut is, [ 8846.517809] INFO: Slab 0xf42a2c60 objects=33 used=3 fp=0x60d32ca8 flags=0x17c0010200(slab|head) Reviewed-by: David Hildenbrand Reviewed-by: Vlastimil Babka Acked-by: David Rientjes Acked-by: Christoph Lameter Signed-off-by: Yafang Shao --- mm/slub.c | 5 +++-- 1 file chang

[PATCH v3 2/3] mm, slub: don't combine pr_err with INFO

2021-02-08 Thread Yafang Shao
(slab|head) - after the patch [ 6343.396602] Slab 0x4382e02b objects=33 used=3 fp=0x9ae06ffc flags=0x17c0010200(slab|head) [1]. https://lore.kernel.org/linux-mm/b9c0f2b6-e9b0-0c36-ebdd-2bc684c5a...@redhat.com/#t Suggested-by: Vlastimil Babka Cc: David Hildenbrand Signed-off-b

[PATCH v3 0/3] mm, vsprintf: introduce new format to dump full information of page flags

2021-02-08 Thread Yafang Shao
- the possible impact on debugfs and the fix of it, per Joe and Matthew - introduce new format instead of changing pGp, per Andy v2: - various coding improvement, per Joe, Miaohe, Vlastimil and Andy - remove the prefix completely in patch #2, per Vlastimil - Update the test cases, per Andy Yafang Shao

[PATCH v3 3/3] vsprintf: introduce new format to dump full information of page flags

2021-02-08 Thread Yafang Shao
hew Wilcox Signed-off-by: Yafang Shao --- Documentation/core-api/printk-formats.rst | 2 + lib/test_printf.c | 126 +++--- lib/vsprintf.c| 115 +++- 3 files changed, 226 insertions(+), 17 deletions(-) diff --git

Re: [PATCH v2 3/3] vsprintf: dump full information of page flags in pGp

2021-02-02 Thread Yafang Shao
On Tue, Feb 2, 2021 at 12:16 AM Andy Shevchenko wrote: > > On Mon, Feb 01, 2021 at 09:49:59PM +0800, Yafang Shao wrote: > > On Mon, Feb 1, 2021 at 9:27 PM Andy Shevchenko > > wrote: > > > On Mon, Feb 01, 2021 at 07:56:10PM +0800, Yafang Shao wrote: > >

Re: [PATCH v2 3/3] vsprintf: dump full information of page flags in pGp

2021-02-01 Thread Yafang Shao
On Mon, Feb 1, 2021 at 10:15 PM Matthew Wilcox wrote: > > On Mon, Feb 01, 2021 at 07:56:10PM +0800, Yafang Shao wrote: > > - Before the patch, > > [ 6343.396602] Slab 0x4382e02b objects=33 used=3 > > fp=0x9ae06ffc flags=0x17c0010200(slab|head) &

Re: [PATCH v2 3/3] vsprintf: dump full information of page flags in pGp

2021-02-01 Thread Yafang Shao
On Mon, Feb 1, 2021 at 9:34 PM Andy Shevchenko wrote: > > On Mon, Feb 01, 2021 at 02:23:33PM +0100, David Hildenbrand wrote: > > On 01.02.21 12:56, Yafang Shao wrote: > > > Currently the pGp only shows the names of page flags, rather than > > > the full information

Re: [PATCH v2 3/3] vsprintf: dump full information of page flags in pGp

2021-02-01 Thread Yafang Shao
On Mon, Feb 1, 2021 at 9:27 PM Andy Shevchenko wrote: > > On Mon, Feb 01, 2021 at 07:56:10PM +0800, Yafang Shao wrote: > > Currently the pGp only shows the names of page flags, rather than > > the full information including section, node, zone, last cpupid and > > kasan t

Re: [PATCH v2 3/3] vsprintf: dump full information of page flags in pGp

2021-02-01 Thread Yafang Shao
On Mon, Feb 1, 2021 at 9:05 PM Joe Perches wrote: > > On Mon, 2021-02-01 at 19:56 +0800, Yafang Shao wrote: > > Currently the pGp only shows the names of page flags, rather than > > the full information including section, node, zone, last cpupid and > > kasan tag. While

[PATCH v2 3/3] vsprintf: dump full information of page flags in pGp

2021-02-01 Thread Yafang Shao
tation and test cases are also updated. Cc: David Hildenbrand Cc: Joe Perches Cc: Miaohe Lin Cc: Vlastimil Babka Cc: Andy Shevchenko Signed-off-by: Yafang Shao --- Documentation/core-api/printk-formats.rst | 2 +- lib/test_printf.c | 65 ++- lib/

[PATCH v2 2/3] mm, slub: don't combine pr_err with INFO

2021-02-01 Thread Yafang Shao
(slab|head) - after the patch [ 6343.396602] Slab 0x4382e02b objects=33 used=3 fp=0x9ae06ffc flags=0x17c0010200(slab|head) [1]. https://lore.kernel.org/linux-mm/b9c0f2b6-e9b0-0c36-ebdd-2bc684c5a...@redhat.com/#t Suggested-by: Vlastimil Babka Cc: David Hildenbrand Signed-off-b

[PATCH v2 1/3] mm, slub: use pGp to print page flags

2021-02-01 Thread Yafang Shao
ut is, [ 8846.517809] INFO: Slab 0xf42a2c60 objects=33 used=3 fp=0x60d32ca8 flags=0x17c0010200(slab|head) Reviewed-by: David Hildenbrand Reviewed-by: Vlastimil Babka Acked-by: David Rientjes Signed-off-by: Yafang Shao --- mm/slub.c | 5 +++-- 1 file changed, 3 insertions(+), 2 dele

[PATCH v2 0/3] mm, vsprintf: dump full information of page flags in pGp

2021-02-01 Thread Yafang Shao
est_printf: unloaded. v2: - various coding improvement, per Joe, Miaohe, Vlastimil and Andy - remove the prefix completely in patch #2, per Vlastimil - Update the test cases, per Andy Yafang Shao (3): mm, slub: use pGp to print page flags mm, slub: don't combine pr_err with INFO vspr

Re: [PATCH 3/3] printk: dump full information of page flags in pGp

2021-01-28 Thread Yafang Shao
On Thu, Jan 28, 2021 at 10:50 PM Andy Shevchenko wrote: > > On Thu, Jan 28, 2021 at 09:18:24PM +0800, Yafang Shao wrote: > > On Thu, Jan 28, 2021 at 8:11 PM Andy Shevchenko > > wrote: > > ... > > > Thanks for the explanation. > > I will change it as you s

Re: [PATCH 0/3] mm, printk: dump full information of page flags in pGp

2021-01-28 Thread Yafang Shao
On Thu, Jan 28, 2021 at 8:12 PM Andy Shevchenko wrote: > > On Thu, Jan 28, 2021 at 10:19:44AM +0800, Yafang Shao wrote: > > Currently the pGp only shows the names of page flags, rather than > > the full information including section, node, zone, last cpupid and > > kasan t

Re: [PATCH 3/3] printk: dump full information of page flags in pGp

2021-01-28 Thread Yafang Shao
On Thu, Jan 28, 2021 at 8:11 PM Andy Shevchenko wrote: > > On Thu, Jan 28, 2021 at 10:19:47AM +0800, Yafang Shao wrote: > > Currently the pGp only shows the names of page flags, rather than > > the full information including section, node, zone, last cpupid and > > kasan t

Re: [PATCH 3/3] printk: dump full information of page flags in pGp

2021-01-28 Thread Yafang Shao
On Thu, Jan 28, 2021 at 6:42 PM Vlastimil Babka wrote: > > On 1/28/21 3:19 AM, Yafang Shao wrote: > > Currently the pGp only shows the names of page flags, rather than > > the full information including section, node, zone, last cpupid and > > kasan tag. While it is

Re: [PATCH 2/3] mm, slub: don't combine pr_err with INFO

2021-01-28 Thread Yafang Shao
On Thu, Jan 28, 2021 at 6:35 PM Vlastimil Babka wrote: > > On 1/28/21 3:19 AM, Yafang Shao wrote: > > It is strange to combine "pr_err" with "INFO", so let's clean them up. > > This patch is motivated by David's comment[1]. > >

Re: [PATCH 3/3] printk: dump full information of page flags in pGp

2021-01-27 Thread Yafang Shao
On Thu, Jan 28, 2021 at 10:52 AM Miaohe Lin wrote: > > Hi: > On 2021/1/28 10:19, Yafang Shao wrote: > > Currently the pGp only shows the names of page flags, rather than > > the full information including section, node, zone, last cpupid and > > kasan tag. While it

Re: [PATCH 3/3] printk: dump full information of page flags in pGp

2021-01-27 Thread Yafang Shao
On Thu, Jan 28, 2021 at 10:35 AM Joe Perches wrote: > > On Thu, 2021-01-28 at 10:19 +0800, Yafang Shao wrote: > > Currently the pGp only shows the names of page flags, rather than > > the full information including section, node, zone, last cpupid and > > kasan tag. While

[PATCH 0/3] mm, printk: dump full information of page flags in pGp

2021-01-27 Thread Yafang Shao
=33 used=3 fp=0x6d0779d1 flags=0x17c0010200(Node 0x0,Zone 0x2,Lastcpupid 0x1f,slab|head) Yafang Shao (3): mm, slub: use pGp to print page flags mm, slub: don't combine pr_err with INFO printk: dump full information of page flags in pGp lib/

[PATCH 3/3] printk: dump full information of page flags in pGp

2021-01-27 Thread Yafang Shao
|head) Cc: David Hildenbrand Signed-off-by: Yafang Shao --- lib/vsprintf.c | 42 +- 1 file changed, 41 insertions(+), 1 deletion(-) diff --git a/lib/vsprintf.c b/lib/vsprintf.c index 3b53c73580c5..bd809f4f1b82 100644 --- a/lib/vsprintf.c +++ b/lib/vsprintf.c

[PATCH 1/3] mm, slub: use pGp to print page flags

2021-01-27 Thread Yafang Shao
ut is, [ 8846.517809] INFO: Slab 0xf42a2c60 objects=33 used=3 fp=0x60d32ca8 flags=0x17c0010200(slab|head) Reviewed-by: David Hildenbrand Signed-off-by: Yafang Shao --- mm/slub.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index 69742ab

[PATCH 2/3] mm, slub: don't combine pr_err with INFO

2021-01-27 Thread Yafang Shao
r the patch [ 6312.639698] ERR: Slab 0x6d1133b9 objects=33 used=3 fp=0x6d0779d1 flags=0x17c0010200(slab|head) [1]. https://lore.kernel.org/linux-mm/b9c0f2b6-e9b0-0c36-ebdd-2bc684c5a...@redhat.com/#t Cc: David Hildenbrand Signed-off-by: Yafang Shao --- mm/slub.c | 10

Re: [xfs] db962cd266: Assertion_failed

2021-01-04 Thread Yafang Shao
On Sat, Jan 2, 2021 at 5:53 AM Dave Chinner wrote: > > On Fri, Jan 01, 2021 at 05:10:49PM +0800, Yafang Shao wrote: > > On Thu, Dec 31, 2020 at 10:46 AM kernel test robot > > wrote: > . > > > [ 552.905799] XFS: Assertion failed: !current->journal_info, file

Re: [xfs] db962cd266: Assertion_failed

2021-01-01 Thread Yafang Shao
on reservation recursion") > url: > https://github.com/0day-ci/linux/commits/Yafang-Shao/xfs-avoid-transaction-reservation-recursion/20201222-092315 > base: https://git.kernel.org/cgit/fs/xfs/xfs-linux.git for-next > > in testcase: filebench > version: filebench-x86_64-22620e6-1

Re: [PATCH 3/6] sched: make struct sched_statistics independent of fair sched class

2020-12-01 Thread Yafang Shao
On Tue, Dec 1, 2020 at 8:41 PM Mel Gorman wrote: > > On Tue, Dec 01, 2020 at 07:54:13PM +0800, Yafang Shao wrote: > > If we want to use schedstats facility, we should move out of > > struct sched_statistics from the struct sched_entity or add it into other > > sctructs

Re: [PATCH 4/6] sched: make schedstats helpers independent of fair sched class

2020-12-01 Thread Yafang Shao
On Tue, Dec 1, 2020 at 8:46 PM Mel Gorman wrote: > > On Tue, Dec 01, 2020 at 07:54:14PM +0800, Yafang Shao wrote: > > The original prototype of the schedstats helpers are > > > > update_stats_wait_*(struct cfs_rq *cfs_rq, struct sched_entity *se) > > > > The cf

[PATCH 5/6] sched, rt: support sched_stat_runtime tracepoint for RT sched class

2020-12-01 Thread Yafang Shao
time=0 [ns] stress-9748[039] d.h. 113.521352: sched_stat_runtime: comm=stress pid=9748 runtime=998203 [ns] vruntime=0 [ns] Signed-off-by: Yafang Shao --- kernel/sched/rt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c index 2d

[PATCH 6/6] sched, rt: support schedstats for RT sched class

2020-12-01 Thread Yafang Shao
eep-15582 [041] dN.. 1732.814348: sched_stat_sleep: comm=sleep.sh pid=15474 delay=1001223130 [ns] sleep-15584 [041] dN.. 1733.815908: sched_stat_sleep: comm=sleep.sh pid=15474 delay=1001238954 [ns] [ In sleep.sh, it sleeps 1 sec each time. ] Signed-off-by: Yafang Shao --

[PATCH 4/6] sched: make schedstats helpers independent of fair sched class

2020-12-01 Thread Yafang Shao
Gorman Signed-off-by: Yafang Shao --- kernel/sched/fair.c | 140 +++ kernel/sched/stats.c | 104 kernel/sched/stats.h | 32 ++ 3 files changed, 157 insertions(+), 119 deletions(-) diff --git a/kernel/sched/fair.c b

[PATCH 2/6] sched, fair: use __schedstat_set() in set_next_entity()

2020-12-01 Thread Yafang Shao
schedstat_enabled() has been already checked, so we can use __schedstat_set() directly. Signed-off-by: Yafang Shao --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 8ff1daa3d9bb..7e7c03cede94 100644 --- a

[PATCH 3/6] sched: make struct sched_statistics independent of fair sched class

2020-12-01 Thread Yafang Shao
. }; After the patch it is clearly that both of se or rt_se can easily get the sched_statistics by a task_struct or a task_group. Signed-off-by: Yafang Shao --- include/linux/sched.h| 3 +- kernel/sched/core.c | 24 --- kernel/sched/deadline.c | 4 +- kernel/sched/debug.c |

[PATCH 1/6] sched: don't include stats.h in sched.h

2020-12-01 Thread Yafang Shao
igned-off-by: Yafang Shao --- kernel/sched/core.c | 1 + kernel/sched/deadline.c | 1 + kernel/sched/debug.c | 1 + kernel/sched/fair.c | 1 + kernel/sched/idle.c | 1 + kernel/sched/rt.c| 2 +- kernel/sched/sched.h | 6 +- kernel/sched/stats.c | 1 + kernel/

[PATCH 0/6] sched: support schedstats for RT sched class

2020-12-01 Thread Yafang Shao
s well. Detailed examples of the output of schedstats for RT tasks are in patch #6. Changes since RFC: - improvement of schedstats helpers, per Mel. - make struct schedstats independent of fair sched class Yafang Shao (6): sched: don't include stats.h in sched.h sched, fair: use __sched

Re: [RFC PATCH v3 0/5] sched: support schedstats for RT sched class

2020-11-27 Thread Yafang Shao
On Sat, Nov 28, 2020 at 12:12 AM Yafang Shao wrote: > > We want to measure the latency of RT tasks in our production > environment with schedstats facility, but currently schedstats is only > supported for fair sched class. This patch enable it for RT sched class > as well.

[RFC PATCH v3 4/5] sched: make schedstats helpers independent of fair sched class

2020-11-27 Thread Yafang Shao
Gorman Signed-off-by: Yafang Shao --- kernel/sched/fair.c | 140 +++ kernel/sched/stats.c | 104 kernel/sched/stats.h | 32 ++ 3 files changed, 157 insertions(+), 119 deletions(-) diff --git a/kernel/sched/fair.c b

[RFC PATCH v3 3/5] sched: make struct sched_statistics independent of fair sched class

2020-11-27 Thread Yafang Shao
. }; After the patch it is clearly that both of se or rt_se can easily get the sched_statistics by a task_struct or a task_group. Signed-off-by: Yafang Shao --- include/linux/sched.h| 3 +- kernel/sched/core.c | 24 --- kernel/sched/deadline.c | 4 +- kernel/sched/debug.c |

  1   2   3   4   >