tag in the description.
Fixes: 30bb9811856f ("x86/topology: Avoid wasting 128k for package id array")
Thanks,
Yasuaki Ishimatsu
On 02/05/2018 10:51 PM, Masayoshi Mizuma wrote:
> From: Masayoshi Mizuma
>
> When a physical cpu is hot-removed, the following warning message
> a
w you still think 12M is large. But the latest Fujitsu server
supports 448 CPUs.
The issue may occur with trace_buf_size=10M on the system. Additionally the
number of CPU
in a server is increasing year by year. So the issue will occurs even if we
don't specify
large trace buffer.
Thanks,
Yasuaki
[5.028681] node 6 initialised, 15982779 pages in 673ms
[5.716102] node 7 initialised, 15987304 pages in 687ms
[5.727855] smp: Bringing up secondary CPUs ...
[5.745937] x86: Booting SMP configuration:
Thanks,
Yasuaki Ishimatsu
On 11/14/2017 06:46 AM, Mel Gorman wrote:
> On Mon, Nov
On 11/14/2017 10:53 AM, Mel Gorman wrote:
> On Tue, Nov 14, 2017 at 10:39:19AM -0500, YASUAKI ISHIMATSU wrote:
>>
>>
>> On 11/14/2017 06:46 AM, Mel Gorman wrote:
>>> On Mon, Nov 13, 2017 at 12:48:36PM -0500, YASUAKI ISHIMATSU wrote:
>>>> When using trac
On 11/14/2017 06:46 AM, Mel Gorman wrote:
> On Mon, Nov 13, 2017 at 12:48:36PM -0500, YASUAKI ISHIMATSU wrote:
>> When using trace_buf_size= boot option, memory allocation of ring buffer
>> for trace fails as follows:
>>
>> [ ] x86: Booting SMP configuration:
>&g
o allocation failure occurs.
Thanks,
Yasuaki Ishimatsu
t; smpboot_thread_fn
=> kthread
=> ret_from_fork
<...>-1322 [187] d..1 1300.660985: irq_do_set_affinity: irq: 127
ret 2 mask: 186-187 eff: 186
<...>-1322 [187] d..1 1300.660993:
=> native_cpu_disable
=> take_cpu_down
=> multi_cpu_stop
=> cpu_sto
Hi Thomas,
Sorry for the late reply.
I'll apply the patches and retest in this week.
Please wait a while.
Thanks,
Yasuaki Ishimatsu
On 10/04/2017 05:04 PM, Thomas Gleixner wrote:
> On Tue, 3 Oct 2017, Thomas Gleixner wrote:
>> Can you please apply the debug patch below.
>
&
On 09/16/2017 11:02 AM, Thomas Gleixner wrote:
> On Sat, 16 Sep 2017, Thomas Gleixner wrote:
>> On Thu, 14 Sep 2017, YASUAKI ISHIMATSU wrote:
>>> Here are one irq's info of megasas:
>>>
>>> - Before offline CPU
>>> /proc/irq/70/smp_affinity_list
bit value, the patch defines find_{smallest|biggest}_section_pfn()
as unsigned long.
Signed-off-by: Yasuaki Ishimatsu
---
mm/memory_hotplug.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index 38c3c37..120e45b 100644
--- a/mm
section_nr_to_pfn() does not calculate
correct pfn.
To make callers use proper arg, the patch changes the macros to
inline functions.
Signed-off-by: Yasuaki Ishimatsu
---
include/linux/mmzone.h | 10 --
mm/memory_hotplug.c| 2 +-
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git
On 09/13/2017 09:33 AM, Thomas Gleixner wrote:
> On Wed, 13 Sep 2017, Kashyap Desai wrote:
>>> On 09/12/2017 08:15 PM, YASUAKI ISHIMATSU wrote:
>>>> + linux-scsi and maintainers of megasas
>
>>>>> In my server, IRQ#66-89 are sent to CPU#24-29. And if I
Hi Michal,
On 09/13/2017 01:59 AM, Michal Hocko wrote:
> On Tue 12-09-17 13:05:39, YASUAKI ISHIMATSU wrote:
>> Hi Michal,
>>
>> Thanks you for reviewing my patch.
>>
>> On 09/12/2017 08:49 AM, Michal Hocko wrote:
>>> On Fri 08-09-17 16:43:04, YASUAKI ISHI
+ linux-scsi and maintainers of megasas
When offlining CPU, I/O stops. Do you have any ideas?
On 09/07/2017 04:23 PM, YASUAKI ISHIMATSU wrote:
> Hi Mark and Christoph,
>
> Sorry for the late reply. I appreciated that you fixed the issue on kvm
> environment.
> But the issue
Hi Michal,
Thanks you for reviewing my patch.
On 09/12/2017 08:49 AM, Michal Hocko wrote:
> On Fri 08-09-17 16:43:04, YASUAKI ISHIMATSU wrote:
>> __remove_section() calls __remove_zone() to shrink zone and pgdat.
>> But due to wrong castings, __remvoe_zone() cannot shrink zo
. __remove_section() calculates start_pfn using section_nr_to_pfn()
and scn_nr. section_nr_to_pfn() just shifts scn_nr by
PFN_SECTION_SHIFT bit. But since scn_nr is defined as int,
section_nr_to_pfn() always return 32 bit value.
The patch fixes the wrong castings.
Signed-off-by: Yasuaki Ishimatsu
0
[...] R13: 7f0bd751f9c0 R14: 7f0bd751f700 R15:
---
Thanks,
Yasuaki Ishimatsu
On 08/21/2017 09:37 AM, Marc Zyngier wrote:
> On 21/08/17 14:18, Christoph Hellwig wrote:
>> Can you try the patch below please?
>>
>> ---
>> From d5f59cb7a62
Hi Marc,
On 08/09/2017 07:42 AM, Marc Zyngier wrote:
> On Tue, 8 Aug 2017 15:25:35 -0400
> YASUAKI ISHIMATSU wrote:
>
>> Hi Thomas,
>>
>> When offlining all CPUs except cpu0, system hung up with the following
>> message.
>>
>> [...] INFO: task
ddress. Is this required by the current hot-plug memory code?
>>>>>>
>>>>>
>>>>> Wow! So great, It seems this is required by the hot-plug memory code.
>>>>>
>>>>> yesterday, I tested the patch in Qemu with 4 node and e
d IRQs on CPU hotplug
Thanks,
Yasuaki Ishimatsu
d IRQs on CPU hotplug
Thanks,
Yasuaki Ishimatsu
use 1G memory.
>>>>> But actually, we should have 4G normally.
>>>>
>>>> So do you have assumption on the order of immovable nodes and movable
>>>> nodes? E.g above your example of nodes, immovable nodes have to be the
>>>> lowest addre
On 08/02/2017 01:49 AM, joeyli wrote:
> Hi YASUAKI,
>
> On Tue, Aug 01, 2017 at 03:21:38PM -0400, YASUAKI ISHIMATSU wrote:
>> Hi Joey,
>>
>> On 07/23/2017 05:18 AM, joeyli wrote:
> [...snip]
>>>>>
>>>>
>>>> At least Yasuaki ra
ple because I do not see how it
>>> fits into the container and online/offline scenario.
>>>
>>
>> At least Yasuaki raised similar behavior for container in 2013.
>> It's similar to the DVD player case, user space application needs
>> to do something then t
just do memory hot-add.
But if I hot add the memory after hot removing a memory, the issue occurs 100%.
Thanks,
Yasuaki Ishimatsu
vice. So currently
the userspace is responsible for the whole container offlining.
Thanks,
Yasuaki Ishimatsu
`
>
> - After a couple of years, can we let the container hot-remove
>process transparently?
> - Except udev rule, does there have any other mechanism to trigger
>
Kernel can't be randomized to be above the limit.
I confirmed that mem= works correctly.
Tested-by: Yasuaki Ishimatsu
Thanks,
Yasuaki Ishimatsu
>
> *) kernel-parameters.txt doesn't tell the updated behaviour of memmap=.
>
> This patchset tries to solve above issues, and
; Signed-off-by: Michal Hocko
> ---
Reviewed-by: Yasuaki Ishimatsu
Thanks,
Yasuaki Ishimatsu
> mm/memory_hotplug.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 9ed251811ec3..342332f2936
> This patch shouldn't have any visible effect
>
> Signed-off-by: Michal Hocko
> ---
Reviewed-by: Yasuaki Ishimatsu
Thanks,
Yasuaki Ishimatsu
> include/linux/mmzone.h | 2 +-
> mm/memory_hotplug.c| 23 +--
> mm/page_alloc.c| 8
On 03/13/2017 05:19 AM, Michal Hocko wrote:
On Fri 10-03-17 12:39:27, Yasuaki Ishimatsu wrote:
On 03/10/2017 08:58 AM, Michal Hocko wrote:
[...]
OK so I did with -m 2G,slots=4,maxmem=4G -numa node,mem=1G -numa node,mem=1G
which generated
[...]
[0.00] ACPI: SRAT: Node 0 PXM 0 [mem
rictions, it seems to have made management of
these zone structs simple.
Thanks,
Yasuaki Ishimatsu
This would explain why onlining from the last block actually works but
to me this sounds like a completely crappy behavior. All we need to
guarantee AFAICS is that Normal and Movable zones do not ov
TAB was replaced to white spaces. So please apply this one.
---
From: Yasuaki Ishimatsu
Date: Fri, 3 Feb 2017 15:18:03 -0500
Subject: [PATCH] mm/memory_hotplug: Remove unnecessary code from
get_page_bootmem()
The following patch is not applied correctly.
http://lkml.kernel.org/r/2c29bd9f
Hi Andrew,
Please apply the following patch into your tree because patch
("mm/memory_hotplug: set magic number to page->freelsit instead of
page->lru.next")
is not applied correctly.
---
From: Yasuaki Ishimatsu
Date: Fri, 3 Feb 2017 15:18:03 -0500
Subject: [PATCH] Remove unnec
(+), 178 deletions(-)
I tested physical CPU hot-add and remove with your patch-set.
And I confirmed that the patch-set works good to me.
Tested-by: Yasuaki Ishimatsu
Thanks,
Yasuaki Ishimatsu
On 01/30/2017 11:56 AM, Thomas Gleixner wrote:
On Mon, 30 Jan 2017, Yasuaki Ishimatsu wrote:
Hi Thomas,
Do you have any idea to fix the issue?
If you have the idea, please send me the patch.
Yes, I have a patch, but need to do some tests and get changelogs
written. Will keep you updated
Hi Thomas,
Do you have any idea to fix the issue?
If you have the idea, please send me the patch.
Thanks,
Yasuaki Ishimatsu
On 01/24/2017 02:54 PM, Thomas Gleixner wrote:
On Tue, 24 Jan 2017, Yasuaki Ishimatsu wrote:
rapl_cpu_prepare() must be called after logical package id of CPU
is set by
Hi Thomas,
Thank you for your review.
I'm not familiar with the component.
So I need your help to fix the issue.
Thanks,
Yasuaki Ishimatsu
On 01/24/2017 02:54 PM, Thomas Gleixner wrote:
On Tue, 24 Jan 2017, Yasuaki Ishimatsu wrote:
rapl_cpu_prepare() must be called after logical packa
() is called
after topology_update_package_map().
Fixes: 9de8d686955b ("perf/x86/intel/rapl: Convert it to a per package
facility")
Signed-off-by: Yasuaki Ishimatsu
CC: Thomas Gleixner
---
arch/x86/events/intel/rapl.c | 11 ++-
include/linux/cpuhotplug.h | 2 +-
2 files
of changing
the memory zone from ZONE_NORMAL to ZONE_MOVABLE
Fixes: df429ac03936 ("memory-hotplug: more general validation of zone during
online")
Signed-off-by: Yasuaki Ishimatsu
Reviewed-by: Reza Arbab
---
from v2:
- Add the user-visible runtime effects of this fix
from v1:
-
Hi Andrew
On 01/09/2017 06:27 PM, Andrew Morton wrote:
On Tue, 13 Dec 2016 15:29:49 -0500 Yasuaki Ishimatsu
wrote:
online_{kernel|movable} is used to change the memory zone to
ZONE_{NORMAL|MOVABLE} and online the memory.
To check that memory zone can be changed, zone_can_shift() is used
.
Cc: Zhang Rui
Cc: Eduardo Valentin
Cc: linux...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Jacob von Chorus
Tested-by: Yasuaki Ishimatsu
Thanks,
Yasuaki Ishimatsu
---
drivers/thermal/thermal_core.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff
On 01/03/2017 11:45 PM, Zhang Rui wrote:
On Wed, 2017-01-04 at 12:35 +0800, Zhang Rui wrote:
On Thu, 2016-12-15 at 16:47 -0500, Yasuaki Ishimatsu wrote:
When offlining all cores on a CPU, the following system panic
occurs:
BUG: unable to handle kernel NULL pointer dereference at (null)
IP
Here are two patches for memory hotplug:
Yasuaki Ishimatsu (2):
mm/sparse: use page_private() to get page->private value
mm/memory_hotplug: set magic number to page->freelsit instead
of page->lru.next
arch/x86/mm/init_64.c | 2 +-
mm/memory_hotplug.c | 5 +++--
mm
y occurs.
Until freeing the pages of page table allocated from bootmem allocator,
the page->freelist is never used. So the patch sets magic number to
page->freelist instead of page->lru.next.
Signed-off-by: Yasuaki Ishimatsu
---
arch/x86/mm/init_64.c | 2 +-
mm/memory_hotplug.c | 5 +++--
free_map_bootmem() uses page->private directly to set
removing_section_nr argument. But to get page->private
value, page_private() has been prepared.
So free_map_bootmem() should use page_private() instead of
page->private.
Signed-off-by: Yasuaki Ishimatsu
---
mm/sparse.c | 2 +
Here are two patches for memory hotplug:
Yasuaki Ishimatsu (2):
mm/sparse: use page_private() to get page->private value
mm/memory_hotplug: set magic number to page->freelsit instead
of page->lru.next
arch/x86/mm/init_64.c | 2 +-
mm/memory_hotplug.c | 4 ++--
mm
free_map_bootmem() uses page->private directly to set
removing_section_nr argument. But to get page->private
value, page_private() has been prepared.
So free_map_bootmem() should use page_private() instead of
page->private.
Signed-off-by: Yasuaki Ishimatsu
---
mm/sparse.c | 2 +
y occurs.
Until freeing the pages of page table allocated from bootmem allocator,
the page->freelist is never used. So the patch sets magic number to
page->freelist instead of page->lru.next.
Signed-off-by: Yasuaki Ishimatsu
---
arch/x86/mm/init_64.c | 2 +-
mm/memory_hotplug.c | 4 ++--
On 12/19/2016 11:21 PM, Eduardo Valentin wrote:
Hey Yasuaki San,
On Thu, Dec 15, 2016 at 04:47:08PM -0500, Yasuaki Ishimatsu wrote:
When offlining all cores on a CPU, the following system panic
occurs:
BUG: unable to handle kernel NULL pointer dereference at (null)
IP: strlen+0x0/0x20
Call
dds thermal_zone_remove_device_groups() to free
tz->device.groups and set NULL pointer.
Signed-off-by: Yasuaki Ishimatsu
CC: Zhang Rui
CC: Eduardo Valentin
---
drivers/thermal/thermal_core.c | 3 ++-
drivers/thermal/thermal_core.h | 1 +
drivers/thermal/thermal_sysfs.c | 6 ++
3 files changed, 9 inse
be
onlined.
The patch changes the return type of zone_can_shift() so that memory
is not onlined when memory zone cannot be changed.
Fixes: df429ac03936 ("memory-hotplug: more general validation of zone during
online")
Signed-off-by: Yasuaki Ishimatsu
CC: Reza Arbab
---
from v1:
-
Hi Reza,
Thank you for your review.
On 12/13/2016 10:54 AM, Reza Arbab wrote:
On Mon, Dec 12, 2016 at 03:29:04PM -0500, Yasuaki Ishimatsu wrote:
--- a/drivers/base/memory.c
+++ b/drivers/base/memory.c
@@ -410,15 +410,13 @@ static ssize_t show_valid_zones(struct device *dev,
sprintf(buf
be
onlined.
The patch changes the return type of zone_can_shift() so that memory
is not onlined when memory zone cannot be changed.
Fixes: df429ac03936 ("memory-hotplug: more general validation of zone during
online")
Signed-off-by: Yasuaki Ishimatsu
CC: Reza Arbab
---
drivers/bas
Could you review the patch?
On 10/27/2016 11:56 AM, Yasuaki Ishimatsu wrote:
If CONFIG_NVM is disabled, loading null_block module with use_lightnvm=1
fails. But there are no messages and documents related to the failure.
So the patch adds the notes to use LightNVM.
Signed-off-by: Yasuaki
If CONFIG_NVM is disabled, loading null_block module with use_lightnvm=1
fails. But there are no messages and documents related to the failure.
So the patch adds the notes to use LightNVM.
Signed-off-by: Yasuaki Ishimatsu
Cc: Jens Axboe
---
Documentation/block/null_blk.txt | 2 +-
drivers
On Mon, 9 May 2016 12:53:39 -0500
Reza Arbab wrote:
> Since zone_can_shift() is being used to validate the target zone during
> onlining, it should also be used to determine the content of valid_zones.
>
> Signed-off-by: Reza Arbab
> ---
Looks good to me.
Reviewd-by: Ya
by: Reza Arbab
> ---
Looks good to me.
Reviewd-by: Yasuaki Ishimatsu
Thanks,
Yasuaki Ishimatsu
> include/linux/memory_hotplug.h | 2 ++
> mm/memory_hotplug.c| 42
> +++---
> 2 files changed, 37 insertions(+), 7 deletions(-)
>
On Wed, 11 May 2016 14:23:26 -0500
Reza Arbab wrote:
> On Wed, May 11, 2016 at 08:17:41AM -0700, Yasuaki Ishimatsu wrote:
> >On Tue, 10 May 2016 15:39:43 -0500
> >Reza Arbab wrote:
> >
> >> + if (idx < target) {
> >> + /* pages must be at
On Tue, 10 May 2016 15:39:43 -0500
Reza Arbab wrote:
> On Tue, May 10, 2016 at 11:08:56AM -0700, Yasuaki Ishimatsu wrote:
> >On Mon, 9 May 2016 12:53:38 -0500
> >Reza Arbab wrote:
> >> * If X is lower than Y, the onlined memory must lie at the end of X.
> >
nnot be changed the zone by above the two conditions. So the conditions
shouold be removed.
Thanks,
Yasuaki Ishimatsu
>
> Add zone_can_shift() to make this determination.
>
> Signed-off-by: Reza Arbab
> ---
> include/linux/memory_hotplug.h |
On Mon, 9 May 2016 12:53:37 -0500
Reza Arbab wrote:
> Add move_pfn_range(), a wrapper to call move_pfn_range_left() or
> move_pfn_range_right().
>
> No functional change. This will be utilized by a later patch.
>
> Signed-off-by: Reza Arbab
Looks good to me.
Reviewed-by:
-0x209fff]
SRAT: Node 2 PXM 2 [mem 0x20a000-0x309fff]
SRAT: Node 3 PXM 3 [mem 0x30a000-0x409fff]
So when booting up the system with mem=0x20a000, Memory of
Node 2 and 3 are ignored and the Nodes become memoryless node.
Thanks,
Yasuaki Ishimatsu
On Thu, 19 Nov 2015 12:22:10 +0800
_MOVABLE by default.
> If we want the node to be assigned to ZONE_NORMAL,
> we can do it as follows:
> "echo online_kernel > /sys/devices/system/memory/memoryXXX/state"
>
> Signed-off-by: liuchangsheng
> Signed-off-by: Xiaofeng Yan
> Tested-by: Dongdong Fan
after the end of the ZONE_NORMAL it will always return 1
> > and then the whole node will be added to ZONE_MOVABLE by default.
> > If we want the node to be assigned to ZONE_NORMAL,
> > we can do it as follows:
> > "echo online_kernel > /sys/devices/system/memory/memor
itecture that uses memory_probe_store to reserve memory,
> this can interrupt the memory reservation process. This patch modifies
> memory_probe_store to take the hotplug sysfs lock to prevent the online
> of added memory before the completion of the probe.
>
> Signed-off-by: John
rt >> PAGE_SHIFT;
> pg_data_t *pgdat = NODE_DATA(nid);
> struct zone *movable_zone = pgdat->node_zones + ZONE_MOVABLE;
> + struct zone *pre_zone = pgdat->node_zones + (ZONE_MOVABLE - 1);
> +
> + if (movable_node_is_enabled()
> + && zon
x27;t you fix workqueue directly?
Thanks,
Yasuaki Ishimatsu
On Thu, 10 Sep 2015 12:27:42 +0800
Tang Chen wrote:
> The whole patch-set aims at solving this problem:
>
> [Problem]
>
> cpuid <-> nodeid mapping is firstly established at boot time. And workqueue
-added memory to ZONE_NORMAL by default.
> If users use a udev rule as below:
>
> SUBSYSTEM=="memory", ACTION=="add", ATTR{state}=="offline",
> ATTR{state}="online"
>
> it will online the memory as normal memory, which will not be hotplu
On Mon, 12 Oct 2015 09:37:17 +0800
Xishi Qiu wrote:
> On 2015/10/9 23:41, Yasuaki Ishimatsu wrote:
>
> >
> > On Thu, 8 Oct 2015 10:21:05 +0800
> > Xishi Qiu wrote:
> >
> >> If kernelcore was not specified, or the kernelcore size is zero
> >&
nel by sysctl, user can create
movable memory by only the following udev rule.
SUBSYSTEM=="memory", ACTION=="add", ATTR{state}=="offline", ATTR{state}="online"
Thanks,
Yasuaki Ishimatsu
>
> And a sysctl interface is also unnecessary. I think one
o? I read the code but I could not find that you
mention.
Thanks,
Yasuaki Ishimatsu
> than totalpages, there is no ZONE_MOVABLE. We should fill the zone
> with both kernel memory and movable memory.
>
> Signed-off-by: Xishi Qiu
> ---
> mm/page_alloc.c | 7 +--
> 1 fi
On Wed, 30 Sep 2015 17:33:42 +0800
Xishi Qiu wrote:
> If user set "movablecore=xx" to a large number, corepages will overflow,
> this patch fix the problem.
>
> Signed-off-by: Xishi Qiu
> ---
Looks good to me.
Reviewed-by: Yasuaki Ishimatsu
Thanks,
Yasuaki Ishi
Hi Changsheng,
Thank you for your comments.
I'm on vacation. So After that, I'll repost the patch.
Thanks,
Yasuaki Ishimatsu
On Sun, 6 Sep 2015 16:33:42 +0800
Changsheng Liu wrote:
>
>
> On 9/1/2015 23:37, Yasuaki Ishimatsu wrote:
> > On Mon, 31 Aug 2015 01:58:40
ows:
> "echo online_kernel > /sys/devices/system/memory/memoryXXX/state"
>
> If the memory is added to movable zone defaultly,
> the user can offline it and add it to other zone again.
> But if the memory is added to normal zone defaultly,
> the user will not offline the
es + ZONE_MOVABLE;
>
> + if (movable_node_is_enabled())
> + return 1;
> +
> if (zone_is_empty(movable_zone))
> return 0;
Your patch cannot prevent from creating ZONE_MOVABLE before/in
ZONE_NORAML. Please check that start PFN of hot added memory i
will puts before/in
ZONE_NORMAL.
You must prevent from creating ZONE_MOVABLE before/in ZONE_NORMAL.
Thanks,
Yasuaki Ishimatsu
>
> --
> 1.7.1
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majord...@kvack.org. For more info on Linu
the value of the file
> named removable under some memory blocks is 0.
For this, we prepared online_movable. When memory is onlined by online_movable,
the memory move from ZONE_NORMAL to ZONE_MOVABLE.
Ex.
# echo online_movable > /sys/devices/system/memory/memoryXXX/state
Thanks,
Yasu
Hi Matt,
Thank you for the information.
Your patch looks good to me.
Thanks,
Yasuaki Ishimatsu
On Wed, 12 Aug 2015 12:00:25 +0100
Matt Fleming wrote:
> On Tue, 11 Aug, at 01:31:05PM, Yasuaki Ishimatsu wrote:
> > When hot adding a CPU and onlining it, the following WARN_ON() message
hot added CPU, the WARN_ON() are always shown:
To fix the issue, the patch moves WARN_ON()s from intel_cqm_cpu_prepare() to
cqm_pick_event_reader() which is called at CPU_STARTING notification.
Signed-off-by: Yasuaki Ishimatsu
CC: Peter Zijlstra
Cc: Thomas Gleixner
Cc: Vikas Shivappa
Cc: Kan
On Fri, 3 Jul 2015 09:26:05 +0800
Tang Chen wrote:
>
> On 07/02/2015 11:02 PM, Yasuaki Ishimatsu wrote:
> > Hi Tang,
> >
> >> On my box, if I run lscpu, the output looks like this:
> >>
> >> NUMA node0 CPU(s): 0-14,128-142
> >> NUMA
gt; Node 2 and 3 are not exist, but they are online.
According your description of patch, node 4 and 5 are mistakenly
set to online. Why does lscpu show the above result?
Thanks,
Yasuaki Ishimatsu
On Wed, 1 Jul 2015 15:55:30 +0800
Tang Chen wrote:
>
> On 07/01/2015 02:25 PM, Xishi Qi
On Fri, 12 Jun 2015 13:06:42 +0200
Michal Simek wrote:
> Fix kernel-doc format validation to be able to use kernel-doc
> script for checking it.
>
> Signed-off-by: Michal Simek
> ---
Reviewed-by: Yasuaki Ishimatsu
Thanks,
Yasuaki Ishimatsu
>
> drivers/f
> hotplug routine will skip the init of new zone when hot re-add the node, and
> the wait_table still points to the freed memory, then we will access the
> invalid
> address when trying to wake up the waiting people after the i/o operation with
> the page is done, such as men
Hi Gu,
Before 8 months, I posted the following patch to relate
cpuid to apicid.
https://lkml.org/lkml/2014/9/3/1120
Could you try this patch?
Thanks,
Yasuaki Ishimatsu
On Thu, 14 May 2015 19:33:33 +0800
Gu Zheng wrote:
> Yasuaki Ishimatsu found that with node online/offline, cpu<
On Wed, 22 Apr 2015 09:34:40 +0800
Xishi Qiu wrote:
> On 2015/4/22 0:21, Yasuaki Ishimatsu wrote:
>
> >
> > On Tue, 21 Apr 2015 18:15:31 +0800
> > Xishi Qiu wrote:
> >
> >> Hot remove nodeXX, then hot add nodeXX. If BIOS report cpu first, it will
7c9fff] // 1781.11 - 1783.79
> [0.00] node 0: [mem 0x6fb1c000-0x6fb1cfff]
> [0.00] node 0: [mem 0x6fba3000-0x6fff]
> ...
>
> start_page = ea0001bd -> pfn=0x6F400 -> 1780M, in node0, right!
> end_page = ea0001bd7fc0 ->
On Mon, 20 Apr 2015 11:42:10 +0800
Xishi Qiu wrote:
> On 2015/4/20 11:29, Yasuaki Ishimatsu wrote:
>
> >
> > On Mon, 20 Apr 2015 10:45:45 +0800
> > Xishi Qiu wrote:
> >
> >> On 2015/4/20 9:42, Gu Zheng wrote:
> >>
> >>> Hi
On Mon, 20 Apr 2015 10:45:45 +0800
Xishi Qiu wrote:
> On 2015/4/20 9:42, Gu Zheng wrote:
>
> > Hi Xishi,
> > On 04/18/2015 04:05 AM, Yasuaki Ishimatsu wrote:
> >
> >>
> >> Your patches will fix your issue.
> >> But, if BIOS reports
On Mon, 20 Apr 2015 10:59:37 +0800
Xishi Qiu wrote:
> On 2015/4/20 10:09, Gu Zheng wrote:
>
> > Hi Ishimatsu, Xishi,
> >
> > On 04/20/2015 10:11 AM, Yasuaki Ishimatsu wrote:
> >
> >>
> >>> When hot adding memory and creating new
On Mon, 20 Apr 2015 09:33:10 +0800
Xishi Qiu wrote:
> On 2015/4/18 4:05, Yasuaki Ishimatsu wrote:
>
> >
> > Your patches will fix your issue.
> > But, if BIOS reports memory first at node hot add, pgdat can
> > not be initialized.
> >
>
> When hot adding memory and creating new node, the node is offline.
> And after calling node_set_online(), the node becomes online.
>
> Oh, sorry. I misread your ptaches.
>
Please ignore it...
Thanks,
Yasuaki Ishimatsu
On
Yasuaki Ishimatsu wrote:
>
> When hot addin
When hot adding memory and creating new node, the node is offline.
And after calling node_set_online(), the node becomes online.
Oh, sorry. I misread your ptaches.
Thanks,
Yasuaki Ishimatsu
On Mon, 20 Apr 2015 09:33:10 +0800
Xishi Qiu wrote:
> On 2015/4/18 4:05, Yasuaki Ishimatsu wr
ode is
offline because node_set_online() is not called yet. So if applying
your patches, the pgdat is not initialized in this case.
Thanks,
Yasuaki Ishimatsu
On Fri, 17 Apr 2015 18:50:32 +0800
Xishi Qiu wrote:
> Hot remove nodeXX, then hot add nodeXX. If BIOS report cpu first, it
Hi Dave,
On Tue, 7 Apr 2015 11:33:55 +0800
Dave Young wrote:
> On 04/06/15 at 07:26am, Yasuaki Ishimatsu wrote:
> > Hi,
> >
> > On Fri, 3 Apr 2015 15:15:13 +0800
> > Dave Young wrote:
> >
> > > Hi,
> > >
> > > On 04/02/15 at 12:3
Hi,
On Fri, 3 Apr 2015 15:15:13 +0800
Dave Young wrote:
> Hi,
>
> On 04/02/15 at 12:36pm, Yasuaki Ishimatsu wrote:
> >
> > On Wed, 1 Apr 2015 12:53:46 +0800
> > Dave Young wrote:
> >
> > > I got below kernel panic during kdump test on Thinkpad T
0x2d00 - 0x37bf
> One of the reserved regions: 0x4000 - 0x4010
>
> The above reserved region includes 0x40004000, a page excluded in
> trim_snb_memory. For this memblock reserved region the nid is not set it is
> still default value MAX_NUMNODES. later node_set callba
d by writing over end of numa mask bitmap.
> > >>
> > >> numa_clear_kernel_node try to set node id in a mask bitmap, it iterating
> > >> all
> > >> reserved region and assume every regions have valid nid. It is not true
> > >&
Hi Lai,
Thanks you for posting the patch-set.
I'll try your it next Monday. So, please wait a while.
Thanks,
Yasuaki Ishimatsu
(2015/01/14 17:54), Lai Jiangshan wrote:
> Hi, All
>
> This patches are un-changloged, un-compiled, un-booted, un-tested,
> they are just shits, I
#endif
80
81 #ifndef cpu_to_node
82 static inline int cpu_to_node(int cpu)
83 {
84 return per_cpu(numa_node, cpu);
85 }
86 #endif
87
88 #ifndef set_numa_node
Thanks,
Yasuaki Ishimatsu
(2014/12/15 10:34), Lai Jiangshan wrote:
On 12/13/2014 01:13 AM, Y
156187] [] kthread+0xe1/0x100
[ 890.156187] [] ? kthread_create_on_node+0x1b0/0x1b0
[ 890.156187] [] ret_from_fork+0x7c/0xb0
[ 890.156187] [] ? kthread_create_on_node+0x1b0/0x1b0
[ 890.156187] ---[ end trace 39abbfc9f93402f4 ]---
Thanks,
Yasuaki Ishimatsu
(2014/12/12 19:19), Lai Jiangshan
1 - 100 of 635 matches
Mail list logo
