Re: [QUESTION] problems report: rcu_read_unlock_special() called in irq_exit() causes dead loop

On 2025/7/3 1:24, Joel Fernandes wrote: > > > On 7/2/2025 6:59 AM, Joel Fernandes wrote: >> >> >> On 7/2/2025 5:14 AM, Qi Xi wrote: >>> Hi Joel, >>> >>> After applying the 2 patches, the problem still exists. Compared to the >>> previous >>> fixes which did solve the problem, the difference i

Re: [PATCH 2/2] rcu: Fix lockup when RCU reader used while IRQ exiting

+cc (Qi, my colleague who helps testing the modification) On 2025/6/10 20:23, Frederic Weisbecker wrote: > Le Mon, Jun 09, 2025 at 02:01:24PM -0400, Joel Fernandes a écrit : >> During rcu_read_unlock_special(), if this happens during irq_exit(), we ...skipped... We have tested the below modifica

Re: [QUESTION] problems report: rcu_read_unlock_special() called in irq_exit() causes dead loop

On 2025/6/4 9:35, Joel Fernandes wrote: > On Tue, Jun 03, 2025 at 03:22:42PM -0400, Joel Fernandes wrote: >> >> >> On 6/3/2025 3:03 PM, Joel Fernandes wrote: >>> >>> >>> On 6/3/2025 2:59 PM, Joel Fernandes wrote: >>>> On Fri, May 30, 2

Re: [QUESTION] problems report: rcu_read_unlock_special() called in irq_exit() causes dead loop

Hi Joel, On 2025/5/29 0:30, Joel Fernandes wrote: > On Wed, May 21, 2025 at 5:43 AM Xiongfeng Wang > wrote: >> >> Hi RCU experts, >> >> When I ran syskaller in Linux 6.6 with CONFIG_PREEMPT_RCU enabled, I got >> the following soft lockup. The Calltrace is t

[QUESTION] problems report: rcu_read_unlock_special() called in irq_exit() causes dead loop

Hi RCU experts, When I ran syskaller in Linux 6.6 with CONFIG_PREEMPT_RCU enabled, I got the following soft lockup. The Calltrace is too long. I put it in the end. The issue can also be reproduced in the latest kernel. The issue is as follows. CPU3 is waiting for a spin_lock, which is got by CPU1

Re: [PATCH 0/4] PCI: Correct function names in the header

Hi, Krzysztof On 2021/3/26 9:07, Krzysztof Wilczyński wrote: > Hi, > > [...] >> PCI: acpi_pcihp: Correct acpi_pci_check_ejectable() function name in >> the header >> PCI/AER: Correct function names in the header >> PCI/PME: Correct pcie_pme_init() function name in the header >> PCI/AT

Re: [PATCH 2/4] PCI/AER: Correct function names in the header

Hi Rafael, On 2021/3/26 1:30, Rafael J. Wysocki wrote: > On Thu, Mar 25, 2021 at 8:50 AM Xiongfeng Wang > wrote: >> >> Fixes the following W=1 kernel build warning(s): >> >> drivers/pci/pcie/aer.c:138: warning: expecting prototype for >> enabl

[PATCH 3/4] PCI/PME: Correct pcie_pme_init() function name in the header

Fixes the following W=1 kernel build warning(s): drivers/pci/pcie/pme.c:469: warning: expecting prototype for pcie_pme_service_init(). Prototype was for pcie_pme_init() instead Reported-by: Hulk Robot Signed-off-by: Xiongfeng Wang --- drivers/pci/pcie/pme.c | 2 +- 1 file changed, 1

[PATCH 0/4] PCI: Correct function names in the header

Xiongfeng Wang (4): PCI: acpi_pcihp: Correct acpi_pci_check_ejectable() function name in the header PCI/AER: Correct function names in the header PCI/PME: Correct pcie_pme_init() function name in the header PCI/ATS: Correct pci_max_pasids() function name in header drivers/pci/ats.c

[PATCH 4/4] PCI/ATS: Correct pci_max_pasids() function name in header

Fixes the following W=1 kernel build warning(s): drivers/pci/ats.c:490: warning: expecting prototype for pci_max_pasid(). Prototype was for pci_max_pasids() instead Reported-by: Hulk Robot Signed-off-by: Xiongfeng Wang --- drivers/pci/ats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 1/4] PCI: acpi_pcihp: Correct acpi_pci_check_ejectable() function name in the header

Fixes the following W=1 kernel build warning(s): drivers/pci/hotplug/acpi_pcihp.c:167: warning: expecting prototype for acpi_pcihp_check_ejectable(). Prototype was for acpi_pci_check_ejectable() instead Reported-by: Hulk Robot Signed-off-by: Xiongfeng Wang --- drivers/pci/hotplug

[PATCH 2/4] PCI/AER: Correct function names in the header

disable_ecrc_checking() instead drivers/pci/pcie/aer.c:1450: warning: expecting prototype for aer_service_init(). Prototype was for pcie_aer_init() instead Reported-by: Hulk Robot Signed-off-by: Xiongfeng Wang --- drivers/pci/pcie/aer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions

[PATCH v2] IB/mthca: fix return value of error branch in mthca_init_cq()

.6.12-rc2") Reported-by: Hulk Robot Signed-off-by: Xiongfeng Wang --- drivers/infiniband/hw/mthca/mthca_cq.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/mthca/mthca_cq.c b/drivers/infiniband/hw/mthca/mthca_cq.c index c3cfea2..119b257

Re: [PATCH] IB/mthca: fix return value of error branch in mthca_init_cq()

Hi, Jason Thanks for your reply ! On 2020/11/19 23:30, Jason Gunthorpe wrote: > On Thu, Nov 19, 2020 at 08:38:49PM +0800, Xiongfeng Wang wrote: >> We return 'err' in the error branch, but this variable may be set as >> zero by the above code. Fix it by setting &

[PATCH] misc: pci_endpoint_test: fix return value of error branch

We return 'err' in the error branch, but this variable may be set as zero before. Fix it by setting 'err' as a negative value before we goto the error label. Fixes: e03327122e2c ("pci_endpoint_test: Add 2 ioctl commands") Reported-by: Hulk Robot Signed-off-by: Xio

[PATCH] IB/mthca: fix return value of error branch in mthca_init_cq()

We return 'err' in the error branch, but this variable may be set as zero by the above code. Fix it by setting 'err' as a negative value before we goto the error label. Reported-by: Hulk Robot Signed-off-by: Xiongfeng Wang --- drivers/infiniband/hw/mthca/mthca_cq.c | 5 +

Re: [PATCH v2] drm/sun4i: dw-hdmi: fix error return code in sun8i_dw_hdmi_bind()

On 2020/11/18 1:47, Jernej Škrabec wrote: > Dne ponedeljek, 16. november 2020 ob 02:09:29 CET je Xiongfeng Wang > napisal(a): >> Fix to return a negative error code from the error handling case instead >> of 0 in function sun8i_dw_hdmi_bind(). >> >> Fixes: b7c74

[PATCH v2] drm/sun4i: dw-hdmi: fix error return code in sun8i_dw_hdmi_bind()

Fix to return a negative error code from the error handling case instead of 0 in function sun8i_dw_hdmi_bind(). Fixes: b7c7436a5ff0 ("drm/sun4i: Implement A83T HDMI driver") Reported-by: Hulk Robot Signed-off-by: Xiongfeng Wang Reviewed-by: Jernej Skrabec --- drivers/gpu

Re: [PATCH] drm/sun4i: dw-hdmi: fix error return code in sun8i_dw_hdmi_bind()

Hi! On 2020/11/14 2:01, Jernej Škrabec wrote: > Hi! > > Thanks for the patch. > > Dne četrtek, 12. november 2020 ob 14:14:51 CET je Xiongfeng Wang napisal(a): >> Fix to return a negative error code from the error handling case instead >> of 0 in function sun8i_

[PATCH] drm/i915/gvt: return error when failing to take the module reference

as self load module") Reported-by: Hulk Robot Signed-off-by: Xiongfeng Wang --- drivers/gpu/drm/i915/gvt/kvmgt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c index ad8a9df..778eb8c 100644 --- a/driv

[PATCH] drm/sun4i: dw-hdmi: fix error return code in sun8i_dw_hdmi_bind()

Fix to return a negative error code from the error handling case instead of 0 in function sun8i_dw_hdmi_bind(). Fixes: b7c7436a5ff0 ("drm/sun4i: Implement A83T HDMI driver") Reported-by: Hulk Robot Signed-off-by: Xiongfeng Wang --- drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 1 + 1 file

[PATCH v3] EDAC/mc_sysfs: Add missing newlines when printing {max,dimm}_location

-off-by: Xiongfeng Wang Signed-off-by: Borislav Petkov Suggested-by: Joe Perches --- drivers/edac/edac_mc_sysfs.c | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c index 4e6aca5..2f9f1e7 100644

Re: [PATCH v2] EDAC/mc_sysfs: Add missing newlines when printing {max,dimm}_location

On 2020/9/18 0:25, Borislav Petkov wrote: > On Thu, Sep 17, 2020 at 07:38:57PM +0800, Xiongfeng Wang wrote: >> I am not sure if snprintf will return a value larger than its second input >> paramter 'size'. > > The comment over snprintf() says > >

Re: [PATCH v2] EDAC/mc_sysfs: Add missing newlines when printing {max,dimm}_location

Hi , On 2020/9/17 1:00, Borislav Petkov wrote: > On Mon, Sep 14, 2020 at 10:48:54AM +0800, Xiongfeng Wang wrote: >> @@ -813,15 +817,21 @@ static ssize_t mci_max_location_show(struct device >> *dev, >> char *data) >> { >>

[PATCH v2] EDAC/mc_sysfs: Add missing newlines when printing {max,dimm}_location

-off-by: Xiongfeng Wang --- drivers/edac/edac_mc_sysfs.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c index 4e6aca5..bf0e075 100644 --- a/drivers/edac/edac_mc_sysfs.c +++ b/drivers/edac

Re: [PATCH] EDAC/mc_sysfs: add missing newlines when printing 'max(dimm)_location'

On 2020/9/10 19:00, Borislav Petkov wrote: > On Fri, Sep 04, 2020 at 04:19:23PM +0800, Xiongfeng Wang wrote: >> When I cat 'max_location' and 'dimm_location' by sysfs, it displays as >> follows. It's better to add a newline for easy reading. >>

[PATCH] EDAC/mc_sysfs: add missing newlines when printing 'max(dimm)_location'

m_location memory 0 [root@localhost /]# Signed-off-by: Xiongfeng Wang --- I am not sure if there are some userspace tools using this file. --- drivers/edac/edac_mc_sysfs.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac

[PATCH] test_power: add missing newlines when printing parameters by sysfs

# cat usb_online onroot@syzkaller:/sys/module/test_power/parameters# Signed-off-by: Xiongfeng Wang --- drivers/power/supply/test_power.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/power/supply/test_power.c b/drivers/power/supply/test_power.c index 04acd76..4895ee5 100644

[PATCH] ipmi: add a newline when printing parameter 'panic_op' by sysfs

When I cat ipmi_msghandler parameter 'panic_op' by sysfs, it displays as follows. It's better to add a newline for easy reading. root@(none):/# cat /sys/module/ipmi_msghandler/parameters/panic_op noneroot@(none):/# Signed-off-by: Xiongfeng Wang --- drivers/char/ipmi/ipmi_m

[PATCH] scsi: target: tcmu: add a missing newline when printing parameters

When I cat module paramter 'global_max_data_area_mb' by sysfs, it displays as follows. It's better to add a newline for easy reading. root@(none):/# cat /sys/module/target_core_user/parameters/global_max_data_area_mb 2048noneroot@(none):/# Signed-off-by: Xiongfeng Wang ---

Re: [Question] About SECCOMP issue for ILP32

On 2020/9/1 2:15, Yury Norov wrote: > On Mon, Aug 31, 2020 at 5:48 AM Xiongfeng Wang > wrote: >> >> Hi Yury, >> > > Hi Xiongfeng, > > [restore CC list] > > Haven't seen this before. What kernel / glibc / ltp do you use? The kernel version

[Question] About SECCOMP issue for ILP32

Hi Yury, We were testing the ILP32 feature and came accross a problem. Very apperaciate it if you could give us some help ! We compile the LTP testsuite with '-mabi=ilp32' and run it on a machine with kernel and glibc applied with ILP32 patches. But we failed on one testcase, prctl04. It print th

[PATCH v2] net-sysfs: add a newline when printing 'tx_timeout' by sysfs

When I cat 'tx_timeout' by sysfs, it displays as follows. It's better to add a newline for easy reading. root@syzkaller:~# cat /sys/devices/virtual/net/lo/queues/tx-0/tx_timeout 0root@syzkaller:~# Signed-off-by: Xiongfeng Wang --- net/core/net-sysfs.c | 2 +- 1 file changed, 1

[PATCH v2] ipmi/watchdog: add missing newlines when printing parameters by sysfs

odule/ipmi_watchdog/parameters/preop preop_noneroot@(none):/# Signed-off-by: Xiongfeng Wang --- drivers/char/ipmi/ipmi_watchdog.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/char/ipmi/ipmi_watchdog.c b/drivers/char/ipmi/ipmi_watchdog.c index 55986e1..f7

Re: [PATCH] ipmi/watchdog: add missing newlines when printing parameters by sysfs

On 2020/7/21 10:00, Joe Perches wrote: > On Tue, 2020-07-21 at 09:20 +0800, Xiongfeng Wang wrote: >> On 2020/7/21 3:52, Corey Minyard wrote: >>> On Mon, Jul 20, 2020 at 10:03:25AM +0800, Xiongfeng Wang wrote: >>>> When I cat some ipmi_watchdog parameters by sysf

Re: [PATCH] net-sysfs: add a newline when printing 'tx_timeout' by sysfs

Hi, On 2020/7/21 8:44, David Miller wrote: > From: Xiongfeng Wang > Date: Mon, 20 Jul 2020 19:17:49 +0800 > >> -return sprintf(buf, "%lu", trans_timeout); >> +return sprintf(buf, "%lu\n", trans_timeout); > > Better to replace it with 

Re: [PATCH] ipmi/watchdog: add missing newlines when printing parameters by sysfs

Hi Corey, Thanks for your reply ! On 2020/7/21 3:52, Corey Minyard wrote: > On Mon, Jul 20, 2020 at 10:03:25AM +0800, Xiongfeng Wang wrote: >> When I cat some ipmi_watchdog parameters by sysfs, it displays as >> follows. It's better to add a newline for easy reading. >

[PATCH] net-sysfs: add a newline when printing 'tx_timeout' by sysfs

When I cat 'tx_timeout' by sysfs, it displays as follows. It's better to add a newline for easy reading. root@syzkaller:~# cat /sys/devices/virtual/net/lo/queues/tx-0/tx_timeout 0root@syzkaller:~# Signed-off-by: Xiongfeng Wang --- net/core/net-sysfs.c | 2 +- 1 file changed, 1

[PATCH] Input: ati_remote2 - add missing newlines when printing module parameters

ff-by: Xiongfeng Wang --- drivers/input/misc/ati_remote2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/misc/ati_remote2.c b/drivers/input/misc/ati_remote2.c index 305f0160506a..8a36d78fed63 100644 --- a/drivers/input/misc/ati_remote2.c +++ b/drivers/input

[PATCH] dlmfs: add a newline when printing 'capabilities' by sysfs

When I cat module parameter 'capabilities' by sysfs, it displays as follows. It's better to add a newline for easy reading. root@syzkaller:~# cat /sys/module/ocfs2_dlmfs/parameters/capabilities bast stackglueroot@syzkaller:~# Signed-off-by: Xiongfeng Wang --- fs/ocfs2/dl

[PATCH] Input: psmouse: add a newline when printing 'proto' by sysfs

When I cat parameter 'proto' by sysfs, it displays as follows. It's better to add a newline for easy reading. root@syzkaller:~# cat /sys/module/psmouse/parameters/proto autoroot@syzkaller:~# Signed-off-by: Xiongfeng Wang --- drivers/input/mouse/psmouse-base.c | 2 +- 1

[PATCH] ipmi/watchdog: add missing newlines when printing parameters by sysfs

odule/ipmi_watchdog/parameters/preop preop_noneroot@(none):/# Signed-off-by: Xiongfeng Wang --- drivers/char/ipmi/ipmi_watchdog.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/char/ipmi/ipmi_watchdog.c b/drivers/char/ipmi/ipmi_watchdog.c index 55986e1..3e

Re: [PATCH v2] scsi: scsi_transport_sas: add missing newline when printing 'enable' by sysfs

Hi, On 2020/7/19 4:25, Bart Van Assche wrote: > On 2020-07-17 01:44, Xiongfeng Wang wrote: >> diff --git a/drivers/scsi/scsi_transport_sas.c >> b/drivers/scsi/scsi_transport_sas.c >> index 182fd25..e443dee 100644 >> --- a/drivers/scsi/scsi_transport_

[PATCH v2] scsi: scsi_transport_sas: add missing newline when printing 'enable' by sysfs

When I cat sysfs file 'enable' below 'sas_phy', it displays as follows. It's better to add a newline for easy reading. [root@localhost ~]# cat /sys/devices/pci:00/:00:0d.0/:0f:00.0/host3/phy-3:2/sas_phy/phy-3:2/enable 1[root@localhost ~]# Signed-off-by: Xi

Re: [PATCH] [SCSI] libsas: add missing newline when printing 'enable' by sysfs

Hi John, On 2020/7/17 15:54, John Garry wrote: > On 17/07/2020 08:36, Xiongfeng Wang wrote: > > Hi, > > I think "scsi: scsi_transport_sas: " would be a better subject prefix, as this > is not libsas code. > >> When I cat sysfs file 'enable' b

[PATCH] PCI/ASPM: add missing newline when printing parameter 'policy' by sysfs

When I cat ASPM parameter 'policy' by sysfs, it displays as follows. It's better to add a newline for easy reading. [root@localhost ~]# cat /sys/module/pcie_aspm/parameters/policy [default] performance powersave powersupersave [root@localhost ~]# Signed-off-by: Xiongfeng Wang -

[PATCH] [SCSI] libsas: add missing newline when printing 'enable' by sysfs

When I cat sysfs file 'enable' below 'sas_phy', it displays as follows. It's better to add a newline for easy reading. [root@localhost ~]# cat /sys/devices/pci:00/:00:0d.0/:0f:00.0/host3/phy-3:2/sas_phy/phy-3:2/enable 1[root@localhost ~]# Signed-off-by: Xio

Re: [PATCH] cpufreq: cppc: Reorder code and remove apply_hisi_workaround variable

> Signed-off-by: Viresh Kumar > --- > Xiongfeng Wang, will it be possible for you to give this a try as I > can't really test it locally. I have tested it on D05. It works well. Tested-by: Xiongfeng Wang Thanks, Xiongfeng > > drivers/cpufreq/cppc_cpufreq.c | 91 +

[PATCH 0/2] ACPI: sysfs: add missing newlines when printing acpi module parameters

parameters]# [root@localhost parameters]# cat trace_method_name (null)[root@localhost parameters]# cat trace_state disable[root@localhost parameters]# Xiongfeng Wang (2): ACPI: EC: add a newline when printing module parameter 'ec_event_clearing' ACPI: sysfs: add missing newlines

[PATCH 2/2] ACPI: sysfs: add missing newlines when printing module parameters

Add newlines for several module parameters printed by sysfs. Signed-off-by: Xiongfeng Wang --- drivers/acpi/sysfs.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/acpi/sysfs.c b/drivers/acpi/sysfs.c index 3a89909..6ad142d 100644 --- a/drivers/acpi

[PATCH 1/2] ACPI: EC: add a newline when printing module parameter 'ec_event_clearing'

When I cat acpi module parameter '/sys/module/acpi/parameters/ec_event_clearing', it displays as follows. It is better to add a newline for easy reading. [root@hulk-202 ~]# cat /sys/module/acpi/parameters/ec_event_clearing query[root@hulk-202 ~]# Signed-off-by: Xiongfeng Wang --- dr

Re: [Question]: about 'cpuinfo_cur_freq' shown in sysfs when the CPU is in idle state

00, Rafael J. Wysocki wrote: >>> On Thu, Jun 4, 2020 at 6:41 AM Viresh Kumar wrote: >>>> >>>> On 04-06-20, 09:32, Xiongfeng Wang wrote: >>>>> On 2020/6/3 21:39, Rafael J. Wysocki wrote: >>>>>> The frequency value obtained by kick

Re: [Question]: about 'cpuinfo_cur_freq' shown in sysfs when the CPU is in idle state

Hi Rafael, Thanks for your reply ! On 2020/6/3 21:39, Rafael J. Wysocki wrote: > On Wed, Jun 3, 2020 at 9:52 AM Viresh Kumar wrote: >> >> On 02-06-20, 11:34, Xiongfeng Wang wrote: >>> Hi Viresh, >>> >>> Sorry to disturb you about another problem as

[Question]: about 'cpuinfo_cur_freq' shown in sysfs when the CPU is in idle state

Hi Viresh, Sorry to disturb you about another problem as follows. CPPC use the increment of Desired Performance counter and Reference Performance counter to get the CPU frequency and show it in sysfs through 'cpuinfo_cur_freq'. But ACPI CPPC doesn't specifically define the behavior of these two c

[PATCH v5 1/2] cpufreq: change '.set_boost' to act on only one policy

lso we move the lock from 'set_boost()' to 'store_cpb()' for acpi_cpufreq. Signed-off-by: Xiongfeng Wang Suggested-by: Viresh Kumar --- drivers/cpufreq/acpi-cpufreq.c | 14 ++- drivers/cpufreq/cpufreq.c | 57 +++--- include

[PATCH v5 0/2] add SW BOOST support for CPPC

the policy rather than each CPU in the system for 'acpi-cpufreq' add 'Suggested-by' Xiongfeng Wang (2): cpufreq: change '.set_boost' to act on only one policy CPPC: add support for SW BOOST drivers/cpufreq/acpi-cpufreq.c | 14 ++- driver

[PATCH v5 2/2] CPPC: add support for SW BOOST

n Nominal Performance, boost feature is enabled by default. Because SW BOOST is disabled by default, so, after this patch, boost feature is disabled by default even if boost is enabled by firmware. Signed-off-by: Xiongfeng Wang Suggested-by: Viresh Kumar --- drivers/cpufreq/cppc_cpufreq.c | 39 +

Re: [PATCH v4 1/2] cpufreq: change '.set_boost' to act on only one policy

Hi Rafael, Thanks for your reply ! On 2020/5/28 20:48, Rafael J. Wysocki wrote: > On Friday, May 22, 2020 5:34:35 AM CEST Xiongfeng Wang wrote: >> Macro 'for_each_active_policy()' is defined internally. To avoid some >> cpufreq driver needing this macro to iterate

[PATCH v4 0/2] add SW BOOST support for CPPC

nce in non-boost mode. If the Highest Performance is greater than the Nominal Performance, we assume SW BOOST is supported. v3->v4: run 'boost_set_msr_each' for each CPU in the policy rather than each CPU in the system for 'acpi-cpufreq' add 'Sugges

[PATCH v4 2/2] CPPC: add support for SW BOOST

n Nominal Performance, boost feature is enabled by default. Because SW BOOST is disabled by default, so, after this patch, boost feature is disabled by default even if boost is enabled by firmware. Signed-off-by: Xiongfeng Wang Suggested-by: Viresh Kumar --- drivers/cpufreq/cppc_cpufreq.c | 39 +

[PATCH v4 1/2] cpufreq: change '.set_boost' to act on only one policy

t_trigger_state()' iterate over all the policies to set boost for the system. This is preparation for adding SW BOOST support for CPPC. Signed-off-by: Xiongfeng Wang Suggested-by: Viresh Kumar --- drivers/cpufreq/acpi-cpufreq.c | 10 drivers/cpufreq/cpufreq.c | 53 +++

Re: [RFC PATCH v3 2/2] CPPC: add support for SW BOOST

Hi Viresh, On 2020/5/20 13:00, Viresh Kumar wrote: > On 19-05-20, 19:41, Xiongfeng Wang wrote: >> To add SW BOOST support for CPPC, we need to get the max frequency of >> boost mode and non-boost mode. ACPI spec 6.2 section 8.4.7.1 describe >> the following two CPC regi

Re: [PATCH] firmware: arm_sdei: remove unused interfaces

Hi James, On 2020/5/19 23:47, James Morse wrote: > Hi Xiongfeng, > > On 05/05/2020 03:08, Xiongfeng Wang wrote: >> On 2020/5/5 1:14, James Morse wrote: >>> Hi Christoph, >>> >>> (CC: +Xiongfeng) >>> >>> Thanks for the reminder - I was j

Re: [RFC PATCH v3 1/2] cpufreq: change '.set_boost' to act on only one policy

On 2020/5/19 19:41, Xiongfeng Wang wrote: > Macro 'for_each_active_policy()' is defined internally. To avoid some > cpufreq driver needing this macro to iterate over all the policies in > '.set_boost' callback, we redefine '.set_boost' to act on only

[RFC PATCH v3 1/2] cpufreq: change '.set_boost' to act on only one policy

t_trigger_state()' iterate over all the policies to set boost for the system. This is preparation for adding SW BOOST support for CPPC. Signed-off-by: Xiongfeng Wang --- drivers/cpufreq/acpi-cpufreq.c | 4 ++-- drivers/cpufreq/cpufreq.c | 53 +--

[RFC PATCH v3 0/2] add SW BOOST support for CPPC

nce in non-boost mode. If the Highest Performance is greater than the Nominal Performance, we assume SW BOOST is supported. Xiongfeng Wang (2): cpufreq: change '.set_boost' to act on only one policy CPPC: add support for SW BOOST drivers/cpufreq/acpi-cpufreq.c | 4 ++-- drivers/cp

[RFC PATCH v3 2/2] CPPC: add support for SW BOOST

n Nominal Performance, boost feature is enabled by default. Because SW BOOST is disabled by default, so, after this patch, boost feature is disabled by default even if boost is enabled by firmware. Signed-off-by: Xiongfeng Wang --- drivers/cpufreq/cppc_cpufreq.c | 39 ++

Re: [PATCH v2 20/20] cpufreq: Return zero on success in boost sw setting

Hi Rafael, On 2020/5/18 19:05, Rafael J. Wysocki wrote: > On Mon, May 18, 2020 at 12:56 PM Serge Semin > wrote: >> >> On Mon, May 18, 2020 at 12:51:15PM +0200, Rafael J. Wysocki wrote: >>> On Mon, May 18, 2020 at 12:46 PM Serge Semin >>> wrote: On Mon, May 18, 2020 at 12:41:19PM +0200,

Re: [RFC PATCH v2 1/3] cpufreq: handle the return value of '.set_boost()' properly

Hi Viresh, On 2020/5/18 19:43, Viresh Kumar wrote: > On 18-05-20, 13:16, Viresh Kumar wrote: >> On 18-05-20, 15:10, Xiongfeng Wang wrote: >>> 'freq_qos_update_request()' called by 'cpufreq_boost_set_sw()' reutrns 1 >>> when the effective constraint v

Re: [RFC PATCH 2/3] cpufreq: Add SW BOOST support for drivers without frequency table

Hi Viresh, Thanks for your reply ! On 2020/5/18 15:53, Viresh Kumar wrote: > Sorry for the delay from my side in replying to this thread. > > On 15-05-20, 09:49, Xiongfeng Wang wrote: >> On 2020/5/14 22:16, Rafael J. Wysocki wrote: >>> On Friday, May 8, 2020 11:11:0

[RFC PATCH v2 2/3] cpufreq: export 'cpufreq_policy_list' and make macro 'for_each_*_policy' public

Export variable 'cpufreq_policy_list' and make macro 'for_each_*_policy" public. This is preparation for adding SW BOOST support for CPPC. Signed-off-by: Xiongfeng Wang --- drivers/cpufreq/cpufreq.c | 16 ++-- include/linux/cpufreq.h | 14 ++

[RFC PATCH v2 1/3] cpufreq: handle the return value of '.set_boost()' properly

'freq_qos_update_request()' called by 'cpufreq_boost_set_sw()' reutrns 1 when the effective constraint value of frequency QoS has changed. It's not an error code. So handle the return value 1 of '.set_boost()' in 'cpufreq_boost_trigger_state()&#

[RFC PATCH v2 3/3] CPPC: add support for SW BOOST

n Nominal Performance, boost feature is enabled by default. Because SW BOOST is disabled by default, so, after this patch, boost feature is disabled by default even if boost is enabled by firmware. Signed-off-by: Xiongfeng Wang --- drivers/cpufreq/cppc_cpufreq.c | 42 +

[RFC PATCH v2 0/3] add SW BOOST support for CPPC

nce in non-boost mode. If the Highest Performance is greater than the Nominal Performance, we assume SW BOOST is supported. Xiongfeng Wang (3): cpufreq: handle the return value of '.set_boost()' properly cpufreq: export 'cpufreq_policy_list' and make macro 'for_each_*

Re: [RFC PATCH 2/3] cpufreq: Add SW BOOST support for drivers without frequency table

On 2020/5/14 22:16, Rafael J. Wysocki wrote: > On Friday, May 8, 2020 11:11:03 AM CEST Xiongfeng Wang wrote: >> Software-managed BOOST get the boost frequency by check the flag >> CPUFREQ_BOOST_FREQ at driver's frequency table. But some cpufreq driver >> don't hav

Re: [RFC PATCH 1/3] cpufreq: fix the return value in 'cpufreq_boost_set_sw()'

Hi Rafael, Thanks for your reply ! On 2020/5/14 21:54, Rafael J. Wysocki wrote: > On Friday, May 8, 2020 11:11:02 AM CEST Xiongfeng Wang wrote: >> When I try to add SW BOOST support for CPPC, I got the following error: >> cpufreq: cpufreq_boost_trigger_state: Cannot enable B

Re: [PATCH] [media] tw686x: add a missing newline when printing parameter 'dma_mode'

Hi Ezequiel, Thanks for your reply ! On 2020/5/14 3:32, Ezequiel Garcia wrote: > On Mon, 11 May 2020 at 05:49, Xiongfeng Wang > wrote: >> >> When I cat module parameter 'dma_mode' by sysfs, it displays as follows. >> It is better to add a newline for easy rea

[PATCH] scsi: fcoe: add a newline when printing 'fcoe_transport' by sysfs

When I print 'fcoe_transport' by sysfs, it displays as follows. It is better to add a newline for easy reading. [root@hulk-202 ~]# cat /sys/module/libfcoe/parameters/show Attached FCoE transports:fcoe [root@hulk-202 ~]# Signed-off-by: Xiongfeng Wang --- drivers/scsi/fcoe/fcoe_trans

[PATCH] media: uvcvideo: add a missing newline when printing parameter 'clock'

When I cat module parameter 'clock' by sysfs, it displays as follows. It is better to add a newline for easy reading. [root@hulk-202 ~]# cat /sys/module/uvcvideo/parameters/clock CLOCK_MONOTONIC[root@hulk-202 ~]# Signed-off-by: Xiongfeng Wang --- drivers/media/usb/uvc/uvc_driver.c |

[PATCH] [media] tw686x: add a missing newline when printing parameter 'dma_mode'

When I cat module parameter 'dma_mode' by sysfs, it displays as follows. It is better to add a newline for easy reading. [root@hulk-202 ~]# cat /sys/module/tw686x/parameters/dma_mode memcpy[root@hulk-202 ~]# Signed-off-by: Xiongfeng Wang --- drivers/media/pci/tw686x/tw686x-core.c

[PATCH] md: add a newline when printing parameter 'start_ro' by sysfs

Add a missing newline when printing module parameter 'start_ro' by sysfs. Signed-off-by: Xiongfeng Wang --- drivers/md/md.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/md.c b/drivers/md/md.c index 271e8a5..acffcc0 100644 --- a/drivers/md/md.c +++ b/

[PATCH] RDMA/srpt: Add a newline when printing parameter 'srpt_service_guid' by sysfs

When I cat module parameter 'srpt_service_guid', it displays as follows. It is better to add a newline for easy reading. [root@hulk-202 ~]# cat /sys/module/ib_srpt/parameters/srpt_service_guid 0x0205cdfffe8346b9[root@hulk-202 ~]# Signed-off-by: Xiongfeng Wang --- drivers/infiniban

[RFC PATCH 3/3] CPPC: add support for SW BOOST

n Nominal Performance, boost feature is enabled by default. Because SW BOOST is disabled by default, so, after this patch, boost feature is disabled by default even if boost is enabled by firmware. Signed-off-by: Xiongfeng Wang --- drivers/cpufreq/cppc_cpufreq.c | 17 +++-- 1 file chang

[RFC PATCH 1/3] cpufreq: fix the return value in 'cpufreq_boost_set_sw()'

ot a error code on failures. But for 'cpufreq_driver.set_boost()', a nonzero return value means failure. So change 'ret' to zero when 'freq_qos_update_request()' returns a positive value. Signed-off-by: Xiongfeng Wang --- drivers/cpufreq/cpufreq.c | 2 ++ 1 file change

[RFC PATCH 0/3] add SW BOOST support for CPPC

nce in non-boost mode. If the Highest Performance is greater than the Nominal Performance, we assume SW BOOST is supported. Xiongfeng Wang (3): cpufreq: fix the return value in 'cpufreq_boost_set_sw()' cpufreq: Add SW BOOST support for drivers without frequency table CPPC: add

[RFC PATCH 2/3] cpufreq: Add SW BOOST support for drivers without frequency table

frequency table, we add members in 'cpufreq_policy.cpufreq_cpuinfo' to record the max frequency of boost mode and non-boost mode. The cpufreq driver initialize these two members when probing. Signed-off-by: Xiongfeng Wang --- drivers/cpufreq/cpufreq.c | 23 +++ inc

[PATCH 1/2] sunrpc: add missing newline when printing parameter 'pool_mode' by sysfs

When I cat parameter '/sys/module/sunrpc/parameters/pool_mode', it displays as follows. It is better to add a newline for easy reading. [root@hulk-202 ~]# cat /sys/module/sunrpc/parameters/pool_mode global[root@hulk-202 ~]# Signed-off-by: Xiongfeng Wang --- net/sunrpc/svc.c | 10 +++

[PATCH 2/2] sunrpc: add missing newline when printing parameter 'auth_hashtable_size' by sysfs

When I cat parameter '/sys/module/sunrpc/parameters/auth_hashtable_size', it displays as follows. It is better to add a newline for easy reading. [root@hulk-202 ~]# cat /sys/module/sunrpc/parameters/auth_hashtable_size 16[root@hulk-202 ~]# Signed-off-by: Xiongfeng Wang --- net/sun

[PATCH 0/2] sunrpc: add missing newline when printing module parameters by sysfs

When I cat parameters below ''/sys/module/sunrpc/parameters/', I found the following two parameter need a new line. [root@hulk-202 ~]# cat /sys/module/sunrpc/parameters/pool_mode global[root@hulk-202 ~]# cat /sys/module/sunrpc/parameters/auth_hashtable_size 16[root@hulk-202 ~]#

Re: [RFC PATCH] cpufreq: add support for HiSilicon SoC HIP09

Hi Sudeep, Thanks for your reply. On 2020/4/30 17:55, Sudeep Holla wrote: > On Thu, Apr 30, 2020 at 02:19:59PM +0800, Xiongfeng Wang wrote: >> HiSilicon SoC has a separate System Control Processor(SCP) dedicated for >> clock frequency adjustment and has been using the cpufreq

Re: [PATCH] firmware: arm_sdei: remove unused interfaces

Hi James, On 2020/5/5 1:14, James Morse wrote: > Hi Christoph, > > (CC: +Xiongfeng) > > Thanks for the reminder - I was just searching for who was using this. Thanks for CC me. We do have a driver that are using it. > > On 04/05/2020 17:42, Christoph Hellwig wrote: >> The export symbols to re

[RFC PATCH] cpufreq: add support for HiSilicon SoC HIP09

e for OS to write frequency adjustment registers directly when CPU Boost is supported. So we add a new SoC implementation-specific(SiP) Service Call for this situation. Signed-off-by: Xiongfeng Wang --- drivers/cpufreq/Kconfig.arm| 7 + drivers/cpufreq/Makefile | 1 + drivers

[PATCH] scsi: dpt_i2o: Remove always false 'chan < 0' statement

The channel index is represented by an unsigned variable 'u32 chan'. We don't need to check whether it is less than zero. The following statement is always false and let's remove it. 'chan < 0' Reported-by: Hulk Robot Signed-off-by: Xiongfeng Wang ---

[PATCH] powerpc/ps3: Move static keyword to the front of declaration

} static vuart_bus_priv; ^ Reported-by: Hulk Robot Signed-off-by: Xiongfeng Wang --- drivers/ps3/ps3-vuart.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ps3/ps3-vuart.c b/drivers/ps3/ps3-vuart.c index ddaa5ea..8e80e09 100644 --- a/drivers/ps3/ps3-vuart.c +++

[PATCH] platform/x86: thinkpad_acpi: Remove always false 'value < 0' statement

Since 'value' is declared as unsigned long, the following statement is always false. value < 0 So let's remove it. Reported-by: Hulk Robot Signed-off-by: Xiongfeng Wang --- drivers/platform/x86/thinkpad_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[PATCH] pci: get pm runtime ref before resetting bus

'pm_runtime_get' to avoid saving the configuration space of the bridge when the bus is being reset. Signed-off-by: Xiongfeng Wang --- drivers/pci/pci.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 9cae66c..0079

Re: [PATCH v2] pciehp: fix a race between pciehp and removing operations by sysfs

On 2019/8/11 16:07, Lukas Wunner wrote: > On Mon, Aug 05, 2019 at 08:32:58PM +0800, Xiongfeng Wang wrote: >> When we remove a slot by sysfs. >> 'pci_stop_and_remove_bus_device_locked()' will be called. This function >> will get the global mutex lock 'pci

Re: [RFC PATCH] pciehp: use completion to wait irq_thread 'pciehp_ist'

Hi, Lukas On 2019/8/6 15:24, Lukas Wunner wrote: > On Thu, Jul 04, 2019 at 03:50:38PM +0800, Xiongfeng Wang wrote: >> When I use the following command to power on a slot which has been >> powered off already. >> echo 1 > /sys/bus/pci/slots/22/power >> It prints the f

[PATCH v2] pciehp: fix a race between pciehp and removing operations by sysfs

t triggered by pciehp interrupt and removing through 'sysfs', should not be excuted at the same time. This patch add a global variable to mark that one of these operations is under processing. When this variable is set, if another operation is requested, it will be rejected. Si

Re: [PATCH] pciehp: fix a race between pciehp and removing operations by sysfs

On 2019/8/2 8:36, Bjorn Helgaas wrote: > On Mon, Feb 26, 2018 at 08:41:15PM +0800, Xiongfeng Wang wrote: >> From: Xiongfeng Wang >> >> When I run a stress test about pcie hotplug and removing operations by >> sysfs, I got a hange task, and the following call trace is

  1   2   3   >