Re: [PATCH v7 1/4] can: m_can: Create a m_can platform framework

2019-03-08 Thread Wolfgang Grandegger
Am 08.03.19 um 18:52 schrieb Dan Murphy: > On 3/8/19 11:40 AM, Wolfgang Grandegger wrote: >> Hello Dan, >> >> Am 08.03.19 um 18:25 schrieb Dan Murphy: >>> On 3/8/19 11:08 AM, Wolfgang Grandegger wrote: >>>> Hello, >>>> >>>> Am 0

Re: [PATCH v7 1/4] can: m_can: Create a m_can platform framework

2019-03-08 Thread Wolfgang Grandegger
Hello Dan, Am 08.03.19 um 18:25 schrieb Dan Murphy: > On 3/8/19 11:08 AM, Wolfgang Grandegger wrote: >> Hello, >> >> Am 08.03.19 um 16:48 schrieb Dan Murphy: >>> Wolfgang >>> >>> On 3/8/19 8:41 AM, Wolfgang Grandegger wrote: >>>>

Re: [PATCH v7 1/4] can: m_can: Create a m_can platform framework

2019-03-08 Thread Wolfgang Grandegger
Hello, Am 08.03.19 um 16:48 schrieb Dan Murphy: > Wolfgang > > On 3/8/19 8:41 AM, Wolfgang Grandegger wrote: >> Hello Dan, >> >> thinking more about it... >> >> Am 08.03.19 um 14:29 schrieb Wolfgang Grandegger: >>> Hello Dan, >>> &

Re: [PATCH v7 1/4] can: m_can: Create a m_can platform framework

2019-03-08 Thread Wolfgang Grandegger
Hello Dan, thinking more about it... Am 08.03.19 um 14:29 schrieb Wolfgang Grandegger: > Hello Dan, > > Am 08.03.19 um 13:44 schrieb Dan Murphy: >> Wolfgang >> >> On 3/8/19 4:10 AM, Wolfgang Grandegger wrote: >>> Hallo Dan, >>> >>> Am 05.

Re: [PATCH v7 1/4] can: m_can: Create a m_can platform framework

2019-03-08 Thread Wolfgang Grandegger
Hello Dan, Am 08.03.19 um 13:44 schrieb Dan Murphy: > Wolfgang > > On 3/8/19 4:10 AM, Wolfgang Grandegger wrote: >> Hallo Dan, >> >> Am 05.03.19 um 16:52 schrieb Dan Murphy: >>> Create a m_can platform framework that peripherial >>> devices can regi

Re: [PATCH v7 2/4] can: m_can: Rename m_can_priv to m_can_classdev

2019-03-08 Thread Wolfgang Grandegger
Am 05.03.19 um 16:52 schrieb Dan Murphy: > Rename the common m_can_priv class structure to > m_can_classdev as this is more descriptive. > > Signed-off-by: Dan Murphy > --- > > v7 - Fixed remaining checkpatch issues, renamed priv to cdev - > https://lore.kernel.org/patchwork/patch/1047219/ >

Re: [PATCH v7 1/4] can: m_can: Create a m_can platform framework

2019-03-08 Thread Wolfgang Grandegger
Hallo Dan, Am 05.03.19 um 16:52 schrieb Dan Murphy: > Create a m_can platform framework that peripherial > devices can register to and use common code and register sets. > The peripherial devices may provide read/write and configuration > support of the IP. > > Signed-off-by: Dan Murphy > --- >

Re: [PATCH v6 4/4] can: tcan4x5x: Add tcan4x5x driver to the kernel

2019-03-04 Thread Wolfgang Grandegger
Hello Dan, Am 04.03.19 um 20:07 schrieb Dan Murphy: > Wolfgang > > On 3/4/19 12:29 PM, Wolfgang Grandegger wrote: >> Hello Dan, >> >> Am 01.03.19 um 19:50 schrieb Dan Murphy: >>> Add the TCAN4x5x SPI CAN driver. This device uses the >>> Bosc

Re: [PATCH v6 4/4] can: tcan4x5x: Add tcan4x5x driver to the kernel

2019-03-04 Thread Wolfgang Grandegger
Hello Dan, Am 01.03.19 um 19:50 schrieb Dan Murphy: > Add the TCAN4x5x SPI CAN driver. This device uses the > Bosch MCAN IP core along with a SPI interface map. > Register to the MCAN common core code to manage the MCAN IP. > > This device has a special method to indicate a write/read > operatio

Re: [PATCH v6 2/4] can: m_can: Rename m_can_priv to m_can_classdev

2019-03-04 Thread Wolfgang Grandegger
Am 04.03.19 um 19:14 schrieb Dan Murphy: > Wolfgang > > On 3/4/19 11:31 AM, Wolfgang Grandegger wrote: >> Hello, >> >> there are still "LTL" after renaming m_can_priv to m_can_classdev. >> > > Yes I know but some of those become unreadable

Re: [PATCH v6 1/4] can: m_can: Create a m_can platform framework

2019-03-04 Thread Wolfgang Grandegger
Am 04.03.19 um 18:22 schrieb Dan Murphy: > Wolfgang > > On 3/4/19 10:56 AM, Wolfgang Grandegger wrote: >> Hello Dan, >> >> the series already looks quite good. I still realized a few (minor) >> issues while browsing the patch/code... >> > >

Re: [PATCH v6 2/4] can: m_can: Rename m_can_priv to m_can_classdev

2019-03-04 Thread Wolfgang Grandegger
Hello, there are still "LTL" after renaming m_can_priv to m_can_classdev. Am 01.03.19 um 19:50 schrieb Dan Murphy: > Rename the common m_can_priv class structure to > m_can_classdev as this is more descriptive. If you change the struct name, I think you should also change the variable name to so

Re: [PATCH v6 1/4] can: m_can: Create a m_can platform framework

2019-03-04 Thread Wolfgang Grandegger
Hello Dan, the series already looks quite good. I still realized a few (minor) issues while browsing the patch/code... Am 01.03.19 um 19:50 schrieb Dan Murphy: > Create a m_can platform framework that peripherial > devices can register to and use common code and register sets. > The peripherial d

Re: [PATCH v5 1/5] can: m_can: Create a m_can platform framework

2019-02-28 Thread Wolfgang Grandegger
Am 14.02.19 um 19:27 schrieb Dan Murphy: > Create a m_can platform framework that peripherial > devices can register to and use common code and register sets. > The peripherial devices may provide read/write and configuration> support of > the IP. > > Signed-off-by: Dan Murphy > --- > > v5 -

Re: [PATCH v5 5/5] can: tcan4x5x: Add tcan4x5x driver to the kernel

2019-02-28 Thread Wolfgang Grandegger
Am 28.02.19 um 19:03 schrieb Dan Murphy: > > Wolfgang > > On 2/28/19 11:50 AM, Wolfgang Grandegger wrote: >> >> >> Am 14.02.19 um 19:27 schrieb Dan Murphy: >>> Add the TCAN4x5x SPI CAN driver. This device >>> uses the Bosch MCAN IP core along

Re: [PATCH v5 2/5] can: m_can: Migrate the m_can code to use the framework

2019-02-28 Thread Wolfgang Grandegger
Hello Dan, Am 28.02.19 um 18:57 schrieb Dan Murphy: > Wolfgang > > On 2/28/19 11:33 AM, Wolfgang Grandegger wrote: >> Am 14.02.19 um 19:27 schrieb Dan Murphy: >>> Migrate the m_can code to use the m_can_platform framework >>> code. >>> >>> Sign

Re: [PATCH v5 5/5] can: tcan4x5x: Add tcan4x5x driver to the kernel

2019-02-28 Thread Wolfgang Grandegger
Am 14.02.19 um 19:27 schrieb Dan Murphy: > Add the TCAN4x5x SPI CAN driver. This device > uses the Bosch MCAN IP core along with a SPI > interface map. Leverage the MCAN common core > code to manage the MCAN IP. > > This device has a special method to indicate a > write/read operation on the

Re: [PATCH v5 2/5] can: m_can: Migrate the m_can code to use the framework

2019-02-28 Thread Wolfgang Grandegger
Am 14.02.19 um 19:27 schrieb Dan Murphy: > Migrate the m_can code to use the m_can_platform framework > code. > > Signed-off-by: Dan Murphy > --- > > v5 - Updated copyright, change m_can_classdev to m_can_priv, removed extra > KCONFIG flag - https://lore.kernel.org/patchwork/patch/1033095/ > >

Re: [PATCH v5 0/5] M_CAN Framework re-write

2019-02-28 Thread Wolfgang Grandegger
Hello, Am 14.02.19 um 19:27 schrieb Dan Murphy: > Hello > > OK I did not give up on this patch series just got a little preoccupied with > some other kernel work. But here is the update per the comments. > > It should be understood I broke these out for reviewability. > For instance the first p

Re: [PATCH v5 0/5] M_CAN Framework re-write

2019-02-24 Thread Wolfgang Grandegger
Hello Dan, Am 22.02.19 um 18:05 schrieb Dan Murphy: > Wolfgang > > On 2/22/19 6:50 AM, Dan Murphy wrote: >> Wolfgang >> >> On 2/22/19 3:38 AM, Wolfgang Grandegger wrote: >>> Hello Dan, >>> >>> what kernel version is that patch series for. I h

Re: [PATCH v5 0/5] M_CAN Framework re-write

2019-02-22 Thread Wolfgang Grandegger
Hello Dan, what kernel version is that patch series for. I have problems to apply it! Wolfgang. Am 21.02.19 um 17:41 schrieb Wolfgang Grandegger: > Hello Dan, > > I will have a closer look end of this week! > > Wolfgang. > > Am 21.02.19 um 17:24 schrieb Dan Murphy: >

Re: [PATCH v5 0/5] M_CAN Framework re-write

2019-02-21 Thread Wolfgang Grandegger
Hello Dan, I will have a closer look end of this week! Wolfgang. Am 21.02.19 um 17:24 schrieb Dan Murphy: > Bump > > On 2/14/19 12:27 PM, Dan Murphy wrote: >> Hello >> >> OK I did not give up on this patch series just got a little preoccupied with >> some other kernel work. But here is the upd

Re: [PATCH v4 1/4] can: m_can: Create a m_can platform framework

2019-01-22 Thread Wolfgang Grandegger
Hello Dan, Am 22.01.19 um 14:04 schrieb Dan Murphy: > Wolfgang > > Thanks for the review > > On 1/22/19 2:16 AM, Wolfgang Grandegger wrote: >> Hello Dan, >> >> looks already quite good... >> >> Am 17.01.19 um 21:05 schrieb Dan Murphy: >>&

Re: [PATCH v4 2/4] can: m_can: Migrate the m_can code to use the framework

2019-01-22 Thread Wolfgang Grandegger
Hello Dan, Am 22.01.19 um 14:37 schrieb Dan Murphy: > Wolfgang > > On 1/22/19 3:35 AM, Wolfgang Grandegger wrote: >> Hello, >> >> Am 17.01.19 um 21:05 schrieb Dan Murphy: >>> Migrate the m_can code to use the m_can_platform framework >>

Re: [PATCH v4 4/4] can: tcan4x5x: Add tcan4x5x driver to the kernel

2019-01-22 Thread Wolfgang Grandegger
Hello, Am 17.01.19 um 21:06 schrieb Dan Murphy: > Add the TCAN4x5x SPI CAN driver. This device > uses the Bosch MCAN IP core along with a SPI > interface map. Leverage the MCAN common core > code to manage the MCAN IP. > > This device has a special method to indicate a > write/read operation on

Re: [PATCH v4 2/4] can: m_can: Migrate the m_can code to use the framework

2019-01-22 Thread Wolfgang Grandegger
Hello, Am 17.01.19 um 21:05 schrieb Dan Murphy: > Migrate the m_can code to use the m_can_platform framework > code. > > Signed-off-by: Dan Murphy > --- > drivers/net/can/m_can/Kconfig | 12 + > drivers/net/can/m_can/Makefile | 4 +- > drivers/net/can/m_can/m_can.c

Re: [PATCH v4 1/4] can: m_can: Create a m_can platform framework

2019-01-22 Thread Wolfgang Grandegger
Hello Dan, looks already quite good... Am 17.01.19 um 21:05 schrieb Dan Murphy: > Create a m_can platform framework that peripherial > devices can register to and use common code and register sets. > The peripherial devices may provide read/write and configuration > support of the IP. > > Signed

Re: [PATCH v4 1/4] can: m_can: Create a m_can platform framework

2019-01-17 Thread Wolfgang Grandegger
Hello Dan, Am 17.01.19 um 21:08 schrieb Dan Murphy: > Wolfgang > > On 1/17/19 2:05 PM, Dan Murphy wrote: >> Create a m_can platform framework that peripherial >> devices can register to and use common code and register sets. >> The peripherial devices may provide read/write and configuration >> s

Re: [RFC PATCH 1/3] can: m_can: Create m_can core to leverage common code

2019-01-11 Thread Wolfgang Grandegger
Hello Dan, Am 10.01.19 um 13:53 schrieb Dan Murphy: > Wolfgang > > On 1/10/19 1:44 AM, Wolfgang Grandegger wrote: >> Hello Dan, >> >> sorry for my late response on that topic... >> >> Am 09.01.19 um 21:58 schrieb Dan Murphy: >>> Wolfgang >&

Re: [RFC PATCH 1/3] can: m_can: Create m_can core to leverage common code

2019-01-09 Thread Wolfgang Grandegger
Hello Dan, sorry for my late response on that topic... Am 09.01.19 um 21:58 schrieb Dan Murphy: > Wolfgang > > On 11/3/18 5:45 AM, Wolfgang Grandegger wrote: >> Hello Dan, >> >> Am 31.10.2018 um 21:15 schrieb Dan Murphy: >>> Wolfgang >>> >>>

Re: [PATCH v4 1/1] can: ucan: add driver for Theobroma Systems UCAN devices

2018-04-08 Thread Wolfgang Grandegger
(canid & CAN_EFF_FLAG) > + canid_mask |= CAN_EFF_MASK | CAN_EFF_FLAG; > + else > + canid_mask |= CAN_SFF_MASK; > + > + if (canid & ~canid_mask) > + netdev_warn(up->netdev, > +

Re: [PATCH v3 0/1] can: ucan: add driver for Theobroma Systems UCAN devices

2018-03-23 Thread Wolfgang Grandegger
Am 23.03.2018 um 10:40 schrieb Jakob Unterwurzacher: > On 23.03.18 09:32, Wolfgang Grandegger wrote: >>> * add __func__ to all errors and warnings, and to info where it made >>> sense >> >> The final output messages in the driver should especially be useful f

Re: [PATCH v3 1/1] can: ucan: add driver for Theobroma Systems UCAN devices

2018-03-23 Thread Wolfgang Grandegger
Am 22.03.2018 um 14:53 schrieb Jakob Unterwurzacher: > The UCAN driver supports the microcontroller-based USB/CAN > adapters from Theobroma Systems. There are two form-factors > that run essentially the same firmware: > > * Seal: standalone USB stick ( https://www.theobroma-systems.com/seal ) >

Re: [PATCH v3 0/1] can: ucan: add driver for Theobroma Systems UCAN devices

2018-03-23 Thread Wolfgang Grandegger
Hello Jacob, Am 22.03.2018 um 14:53 schrieb Jakob Unterwurzacher: > This is v3 of the Theobroma Systems CAN/USB adapter driver > upstreaming effort. > > Featured v2 -> v3 changes: > * count error frames as data packets > * use canid_t for all can ids > * use BIT(x) instead of (1 << x) > * use __l

Re: [PATCH v2 1/1] can: ucan: add driver for Theobroma Systems UCAN devices

2018-03-14 Thread Wolfgang Grandegger
Am 14.03.2018 um 20:07 schrieb Jakob Unterwurzacher: On 14.03.18 11:04, Wolfgang Grandegger wrote:  (000.000443)  can0  2034   [8]  00 0C 00 00 00 00 78 00 ERRORFRAME     controller-problem{rx-error-warning,tx-error-warning}     transceiver-status     no-acknowledgement-on-tx     error

Re: [PATCH v2 1/1] can: ucan: add driver for Theobroma Systems UCAN devices

2018-03-14 Thread Wolfgang Grandegger
Hello Jakob, Am 14.03.2018 um 10:48 schrieb Jakob Unterwurzacher: > On 14.03.18 10:25, Wolfgang Grandegger wrote: >>> Counting the state changes is one thing but you should also generate >>> error messages for them. >> >> The usual test here is: >>

Re: rx_packets/bytes stats for error frames

2018-03-14 Thread Wolfgang Grandegger
Am 14.03.2018 um 10:36 schrieb Marc Kleine-Budde: On 03/14/2018 10:09 AM, Jakob Unterwurzacher wrote: On 14.03.18 08:51, Marc Kleine-Budde wrote: + memcpy(cf->data, m->msg.can_msg.data, cf->can_dlc); + + /* don't count error frames as real packets */ + if (!(canid &

Re: [PATCH v2 1/1] can: ucan: add driver for Theobroma Systems UCAN devices

2018-03-14 Thread Wolfgang Grandegger
Am 14.03.2018 um 10:17 schrieb Wolfgang Grandegger: Am 14.03.2018 um 10:14 schrieb Jakob Unterwurzacher: On 14.03.18 10:11, Wolfgang Grandegger wrote: +    /* handle error frames */ +    canid = le32_to_cpu(m->msg.can_msg.id); +    if (canid & CAN_E

Re: [PATCH v2 1/1] can: ucan: add driver for Theobroma Systems UCAN devices

2018-03-14 Thread Wolfgang Grandegger
Hello, Am 13.03.2018 um 18:35 schrieb Jakob Unterwurzacher: The UCAN driver supports the microcontroller-based USB/CAN adapters from Theobroma Systems. There are two form-factors that run essentially the same firmware: * Seal: standalone USB stick ( https://www.theobroma-systems.com/seal ) * M

Re: [PATCH v2 1/1] can: ucan: add driver for Theobroma Systems UCAN devices

2018-03-14 Thread Wolfgang Grandegger
Am 14.03.2018 um 10:14 schrieb Jakob Unterwurzacher: On 14.03.18 10:11, Wolfgang Grandegger wrote: +    /* handle error frames */ +    canid = le32_to_cpu(m->msg.can_msg.id); +    if (canid & CAN_ERR_FLAG) { +    ucan_handle_error_frame(up, m, canid); +    /* drop frame

Re: [PATCH v4 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

2017-03-20 Thread Wolfgang Grandegger
Hello Akshay, Am 20.03.2017 um 16:14 schrieb Akshay Bhat: Hi Wolfgang, On 03/19/2017 12:17 PM, Wolfgang Grandegger wrote: Hello Akshay, I still see some improvements... Am 17.03.2017 um 22:10 schrieb Akshay Bhat: This patch adds support for the Holt HI-311x CAN controller. The HI311x CAN

Re: [PATCH v4 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

2017-03-19 Thread Wolfgang Grandegger
interfaces with the host over SPI. Datasheet: www.holtic.com/documents/371-hi-3110_v-rev-jpdf.do Signed-off-by: Akshay Bhat --- v3 -> v4: Address comments from Wolfgang Grandegger: - Add support for CAN warning state reporting - Add support for reporting tx/rx error counts in bus error messa

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

2017-03-18 Thread Wolfgang Grandegger
Hello Akshay, Am 17.03.2017 um 19:28 schrieb Akshay Bhat: Hi Wolfgang, On 03/17/2017 01:04 PM, Wolfgang Grandegger wrote: Hm, that's unusual. Cable disconnected and then send a message: $ grep /proc/interrupts; sleep 10; /proc/interrupts should make things clear. But maybe it'

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

2017-03-17 Thread Wolfgang Grandegger
Hi Akshay, Am 17.03.2017 um 17:00 schrieb Akshay Bhat: Hi Wolfgang, On 03/17/2017 03:39 AM, Wolfgang Grandegger wrote: Hello Akshay, Am 16.03.2017 um 23:29 schrieb Akshay Bhat: Hi Wolfgang, On 03/16/2017 04:02 PM, Wolfgang Grandegger wrote: Looks much better now! There are message for

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

2017-03-17 Thread Wolfgang Grandegger
Hello Akshay, Am 17.03.2017 um 08:39 schrieb Wolfgang Grandegger: Hello Akshay, Am 16.03.2017 um 23:29 schrieb Akshay Bhat: Hi Wolfgang, On 03/16/2017 04:02 PM, Wolfgang Grandegger wrote: Looks much better now! There are message for state changes to error warning and passive. Just the

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

2017-03-17 Thread Wolfgang Grandegger
Hello Akshay, Am 16.03.2017 um 23:29 schrieb Akshay Bhat: Hi Wolfgang, On 03/16/2017 04:02 PM, Wolfgang Grandegger wrote: Looks much better now! There are message for state changes to error warning and passive. Just the following message is not correct: (000.200824) can0 2004 [8

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

2017-03-16 Thread Wolfgang Grandegger
Hello Akshay, Am 16.03.2017 um 18:06 schrieb Akshay Bhat: > Hi Wolfgang, > > On 03/15/2017 05:42 AM, Wolfgang Grandegger wrote: >> Hello Akshay, >> > ..snip.. >>> >>> So here is my plan: >>> - Have the bus error interrupt always enabled &g

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

2017-03-15 Thread Wolfgang Grandegger
Hello Akshay, Am 15.03.2017 um 05:44 schrieb Akshay Bhat: Hi Wolfgang, On Tue, Mar 14, 2017 at 2:08 PM, Wolfgang Grandegger wrote: ...snip /disconnect cable can0 2088 [8] 00 00 00 19 00 00 28 00 ERRORFRAME protocol-violation{{}{acknowledge-slot}} bus

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

2017-03-15 Thread Wolfgang Grandegger
Hello Akshay, Am 15.03.2017 um 05:44 schrieb Akshay Bhat: Hi Wolfgang, On Tue, Mar 14, 2017 at 2:08 PM, Wolfgang Grandegger wrote: ...snip /disconnect cable can0 2088 [8] 00 00 00 19 00 00 28 00 ERRORFRAME protocol-violation{{}{acknowledge-slot}} bus

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

2017-03-14 Thread Wolfgang Grandegger
Am 14.03.2017 um 19:08 schrieb Wolfgang Grandegger: Hello Akshay, Am 14.03.2017 um 17:20 schrieb Akshay Bhat: Hi Wolfgang, On 03/14/2017 08:11 AM, Wolfgang Grandegger wrote: ... snip ... A few other things to check: Run "cangen" and monitor the message with "candump -e a

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

2017-03-14 Thread Wolfgang Grandegger
Hello Akshay, Am 14.03.2017 um 17:20 schrieb Akshay Bhat: Hi Wolfgang, On 03/14/2017 08:11 AM, Wolfgang Grandegger wrote: ... snip ... A few other things to check: Run "cangen" and monitor the message with "candump -e any,0:0,#FFF". Then 1) disconnect the cable or

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

2017-03-14 Thread Wolfgang Grandegger
Hallo Akshay, Am 13.03.2017 um 16:38 schrieb Akshay Bhat: Hi Wolfgang, On 03/09/2017 12:36 PM, Wolfgang Grandegger wrote: Hello, doing a quick review... I realized a few issues... Am 17.01.2017 um 20:22 schrieb Akshay Bhat: ... snip ... A few other things to check: Run "cangen

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

2017-03-09 Thread Wolfgang Grandegger
Hello, doing a quick review... I realized a few issues... Am 17.01.2017 um 20:22 schrieb Akshay Bhat: This patch adds support for the Holt HI-311x CAN controller. The HI311x CAN controller is capable of transmitting and receiving standard data frames, extended data frames and remote frames. The

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

2017-03-09 Thread Wolfgang Grandegger
Hello Akshay, Am 09.03.2017 um 13:34 schrieb Akshay Bhat: On 03/09/2017 04:59 AM, Wolfgang Grandegger wrote: Hello Akshay, unfortunately there are not many CAN controllers for the SPI bus. I just know the MPC251x, which behaves badly (message losses) under Linux, especially at hight bit

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

2017-03-09 Thread Wolfgang Grandegger
Hello Akshay, unfortunately there are not many CAN controllers for the SPI bus. I just know the MPC251x, which behaves badly (message losses) under Linux, especially at hight bit-rates due to insufficient RX buffering. What is your experience with that driver for the HI-311x? Thanks, Wolfga

Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller driver

2016-08-09 Thread Wolfgang Grandegger
Am 09.08.2016 um 08:10 schrieb Andreas Werner: On Mon, Aug 08, 2016 at 04:35:34PM +0200, Wolfgang Grandegger wrote: Am 08.08.2016 um 16:05 schrieb Andreas Werner: On Mon, Aug 08, 2016 at 02:28:39PM +0200, Wolfgang Grandegger wrote: ---snip--- + + ndev = alloc_candev(sizeof(struct

Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller driver

2016-08-08 Thread Wolfgang Grandegger
Am 08.08.2016 um 16:05 schrieb Andreas Werner: On Mon, Aug 08, 2016 at 02:28:39PM +0200, Wolfgang Grandegger wrote: Hello, Am 08.08.2016 um 13:39 schrieb Andreas Werner: On Mon, Aug 08, 2016 at 11:27:25AM +0200, Wolfgang Grandegger wrote: Hello Andreas, a first quick review Am

Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller driver

2016-08-08 Thread Wolfgang Grandegger
Hello, Am 08.08.2016 um 13:39 schrieb Andreas Werner: On Mon, Aug 08, 2016 at 11:27:25AM +0200, Wolfgang Grandegger wrote: Hello Andreas, a first quick review Am 26.07.2016 um 11:16 schrieb Andreas Werner: This CAN Controller is found on MEN Chameleon FPGAs. The driver/device supports

Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller driver

2016-08-08 Thread Wolfgang Grandegger
Hello Andreas, a first quick review Am 26.07.2016 um 11:16 schrieb Andreas Werner: This CAN Controller is found on MEN Chameleon FPGAs. The driver/device supports the CAN2.0 specification. There are 255 RX and 255 Tx buffer within the IP. The pointer for the buffer are handled by HW to mak

Re: [PATCH v5 2/5] can: kvaser_usb: Consolidate and unify state change handling

2015-01-21 Thread Wolfgang Grandegger
On Wed, 21 Jan 2015 10:36:47 -0500, "Ahmed S. Darwish" wrote: > On Wed, Jan 21, 2015 at 03:00:15PM +, Andri Yngvason wrote: >> Quoting Ahmed S. Darwish (2015-01-21 14:43:23) >> > Hi! > > ... > >> > <-- Unplug the cable --> >> > >> > (000.009106) can0 2080 [8] 00 00 00 00 00 00 08

Re: [PATCH v5 2/5] can: kvaser_usb: Consolidate and unify state change handling

2015-01-21 Thread Wolfgang Grandegger
On Wed, 21 Jan 2015 10:33:19 +, Andri Yngvason wrote: > Quoting Ahmed S. Darwish (2015-01-20 21:45:37) >> From: Ahmed S. Darwish >> >> Replace most of the can interface's state and error counters >> handling with the new can-dev can_change_state() mechanism. >> >> Suggested-by: Andri Yngvas

Re: FlexCAN on i.MX28 interrupt flooding retrying send

2014-03-07 Thread Wolfgang Grandegger
On 03/07/2014 02:36 PM, Stanislav Meduna wrote: > On 07.03.2014 09:46, Marc Kleine-Budde wrote: > >> Adding the linux-can mailinglist to Cc. > > I am not subscribed so maybe that's why the original mail > did not get through - I did Cc: linux-...@vger.kernel.org > >> Your kernel is missing the p

Re: FlexCAN on i.MX28 interrupt flooding retrying send

2014-03-07 Thread Wolfgang Grandegger
On 03/07/2014 09:16 AM, Marc Kleine-Budde wrote: > Adding the linux-can mailinglist to Cc. > > Marc > > On 03/07/2014 09:08 AM, Stanislav Meduna wrote: >> Hi, >> >> I am using a FlexCAN CAN controller on a Freescale i.MX28 platform [1]. >> If a packet is being sent when the bus is disconnected, I

Re: [PATCH v3] can: c_can: Speed up rx_poll function

2013-11-03 Thread Wolfgang Grandegger
On 11/01/2013 10:36 AM, Markus Pargmann wrote: > This patch speeds up the rx_poll function by reducing the number of > register reads. > > Replace the 32bit register read by a 16bit register read. Currently > the 32bit register read is implemented by using 2 16bit reads. This is > inefficient as w

Re: [PATCH 6/6 v11] gpio: Add block gpio to several gpio drivers

2012-12-20 Thread Wolfgang Grandegger
On 12/20/2012 08:08 AM, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 22:22 Wed 19 Dec , Roland Stigge wrote: >> This patch adds block GPIO support to several gpio drivers. >> >> This implements block GPIO only for some selected drivers since block GPIO is >> an optional feature which may not be

Re: [PATCH RESEND 0/6 v10] gpio: Add block GPIO

2012-12-17 Thread Wolfgang Grandegger
On 12/18/2012 06:55 AM, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 20:47 Mon 17 Dec , Wolfgang Grandegger wrote: >> On 12/17/2012 07:02 PM, Roland Stigge wrote: >>> On 12/17/2012 06:37 PM, Wolfgang Grandegger wrote: >>>>/* Do synchronous data out

Re: [PATCH RESEND 0/6 v10] gpio: Add block GPIO

2012-12-17 Thread Wolfgang Grandegger
On 12/17/2012 10:33 PM, Roland Stigge wrote: > On 17/12/12 20:47, Wolfgang Grandegger wrote: >> On 12/17/2012 07:02 PM, Roland Stigge wrote: >>> On 12/17/2012 06:37 PM, Wolfgang Grandegger wrote: >>>>/* Do synchronous data output with a single write access */ &

Re: [PATCH RESEND 0/6 v10] gpio: Add block GPIO

2012-12-17 Thread Wolfgang Grandegger
On 12/17/2012 07:02 PM, Roland Stigge wrote: > On 12/17/2012 06:37 PM, Wolfgang Grandegger wrote: >> /* Do synchronous data output with a single write access */ >> __raw_writel(~mask, pio + PIO_OWDR); >> __raw_writel(mask, pio + PIO_OWER); >> __raw

Re: [PATCH RESEND 0/6 v10] gpio: Add block GPIO

2012-12-17 Thread Wolfgang Grandegger
On 12/17/2012 06:15 PM, Roland Stigge wrote: > On 12/17/2012 05:28 PM, Wolfgang Grandegger wrote: >> On 12/17/2012 02:51 PM, Roland Stigge wrote: >>> Hi Wolfgang, >>>> And I guess Russell is right: If possible, we should write outputs >>>> simultaneously

Re: [PATCH RESEND 0/6 v10] gpio: Add block GPIO

2012-12-17 Thread Wolfgang Grandegger
On 12/17/2012 02:51 PM, Roland Stigge wrote: > Hi Wolfgang, > > On 12/17/2012 02:32 PM, Roland Stigge wrote: >> And I guess Russell is right: If possible, we should write outputs >> simultaneously via ODSR (plus OWER/OWDR/OWSR) instead of separate set/clear. >> >> I wonder if we need to save/resto

Re: [PATCH RESEND 0/6 v10] gpio: Add block GPIO

2012-12-17 Thread Wolfgang Grandegger
On 12/17/2012 01:10 PM, Russell King - ARM Linux wrote: > On Mon, Dec 17, 2012 at 12:51:32PM +0100, Wolfgang Grandegger wrote: >> +static void at91_gpiolib_set_block(struct gpio_chip *chip, unsigned long >> mask, unsigned long val) >> +{ >> +struc

Re: [PATCH RESEND 0/6 v10] gpio: Add block GPIO

2012-12-17 Thread Wolfgang Grandegger
On 12/17/2012 12:37 PM, Wolfgang Grandegger wrote: > Hi Roland, > > On 12/15/2012 12:49 AM, Roland Stigge wrote: >> Hi Wolfgang, >> >> thank you for the patch! >> >> On 14/12/12 18:58, Wolfgang Grandegger wrote: >>> +static void at91_gpiolib

Re: [PATCH RESEND 0/6 v10] gpio: Add block GPIO

2012-12-17 Thread Wolfgang Grandegger
Hi Roland, On 12/15/2012 12:49 AM, Roland Stigge wrote: > Hi Wolfgang, > > thank you for the patch! > > On 14/12/12 18:58, Wolfgang Grandegger wrote: >> +static void at91_gpiolib_set_block(struct gpio_chip *chip, unsigned long >> mask, unsigned long val) >>

Re: [PATCH RESEND 0/6 v10] gpio: Add block GPIO

2012-12-14 Thread Wolfgang Grandegger
via DT > * Example implementations in several gpio drivers since they need > special accessor functions for block wise GPIO access > * Fix for race condition in gpiolib on device creation > > Signed-off-by: Roland Stigge > Tested by: Wolfgang Grandegger I'm going to re-

Re: [PATCH 3/6 v9] gpio: Add userland device interface to block GPIO

2012-12-05 Thread Wolfgang Grandegger
On 12/05/2012 11:20 PM, Roland Stigge wrote: > Hi Wolfgang, > > On 05/12/12 20:01, Wolfgang Grandegger wrote: >>> + for (i = 0; i < block->ngpio; i++) { >>> + status = gpio_request(block->gpio[i], "gpioblock dev"); >>

Re: [PATCH 3/6 v9] gpio: Add userland device interface to block GPIO

2012-12-05 Thread Wolfgang Grandegger
On 12/04/2012 09:39 PM, Roland Stigge wrote: > This patch adds a character device interface to the block GPIO system. > > Signed-off-by: Roland Stigge > --- > Documentation/ABI/testing/dev-gpioblock | 34 + > drivers/gpio/gpiolib.c | 208 > +++

Re: [PATCH 0/6 v8] gpio: Add block GPIO

2012-12-05 Thread Wolfgang Grandegger
Hi Roland, On 12/04/2012 09:39 PM, Roland Stigge wrote: > Hi Wolfgang, > > On 03/12/12 10:17, Wolfgang Grandegger wrote: >> I re-tried v8 on my AT91-SAM9G45 board and it works fine if >> CONFIG_GPIO_SYSFS is enable. Unfortunately, the access via misc device >> fails

Re: [PATCH 0/6 v8] gpio: Add block GPIO

2012-12-03 Thread Wolfgang Grandegger
* Added functions for GPIO block registration > * Added more error checking > * Bit remapping bugfix > > Changes since v1: > * API change to 32/64 bit word, bit masks > > Thanks to Ryan Mallon, Linus Walleij, Stijn Devriendt, Jean-Christophe > Plagniol-Villard, Mark Brown, G

Re: [PATCH] CAN: sja1000: Add support for Connect Tech Inc's Canpro/104-Plus Opto CAN board

2012-10-16 Thread Wolfgang Grandegger
ow. > > Thanks, The above two lines should go ... > Signed-off-by: Muhammad Ghias > --- ... here (out of the commit message). Apart from that the patch looks good. You can add my Acked-by: Wolfgang Grandegger Thanks for your contribution. Wolfgang. -- To unsubscribe fr

TRACE_EVENT without ARGS

2012-09-21 Thread Wolfgang Grandegger
Hello, I would like to define trace events for functions without arguments, e.g. my_yield(). But TRACE_EVENT requires at least one argument to be defined and I also have not found an example in the kernel sources, apart from: $ cat include/trace/events/xen.h ... TRACE_EVENT(xen_mmu_flush_tl

Re: [PATCH can-next v3 1/2] can: add tx/rx LED trigger support

2012-07-31 Thread Wolfgang Grandegger
hould call can_led_init(), can_led_exit() and > can_led_event() as needed. > > Supported events are: > - CAN_LED_EVENT_OPEN: turn on tx/rx LEDs > - CAN_LED_EVENT_STOP: turn off tx/rx LEDs > - CAN_LED_EVENT_TX: trigger tx LED blink > - CAN_LED_EVENT_RX: trigger tx LED blink >

Re: 2.6.24-rc8-rt1: Strange latencies on mpc5200 powerpc - RCU issue?

2008-01-30 Thread Wolfgang Grandegger
Paul E. McKenney wrote: > On Wed, Jan 30, 2008 at 11:45:01AM +0100, Wolfgang Grandegger wrote: >> Paul E. McKenney wrote: >>> On Wed, Jan 30, 2008 at 09:18:49AM +0100, Wolfgang Grandegger wrote: >>>> Paul E. McKenney wrote: >>>>> On Tue, Jan 29, 2008 a

Re: 2.6.24-rc8-rt1: Strange latencies on mpc5200 powerpc - RCU issue?

2008-01-30 Thread Wolfgang Grandegger
Paul E. McKenney wrote: > On Wed, Jan 30, 2008 at 09:18:49AM +0100, Wolfgang Grandegger wrote: >> Paul E. McKenney wrote: >>> On Tue, Jan 29, 2008 at 02:38:04PM +0100, Wolfgang Grandegger wrote: >>>> Luotao Fu wrote: >>>>> Hi, >>>>> >

Re: 2.6.24-rc8-rt1: Strange latencies on mpc5200 powerpc - RCU issue?

2008-01-30 Thread Wolfgang Grandegger
Paul E. McKenney wrote: > On Tue, Jan 29, 2008 at 02:38:04PM +0100, Wolfgang Grandegger wrote: >> Luotao Fu wrote: >>> Hi, >>> >>> Wolfgang Grandegger wrote: >>> .. >>>> Do you still get high latencies with: >>

Re: 2.6.24-rc8-rt1: Strange latencies on mpc5200 powerpc - RCU issue?

2008-01-29 Thread Wolfgang Grandegger
Luotao Fu wrote: > Hi, > > Wolfgang Grandegger wrote: > .. >> Do you still get high latencies with: >> >> CONFIG_PREEMPT_RCU_BOOST=y >> CONFIG_RCU_TRACE=y >> CONFIG_NO_HZ is not set >> >> With this setting I have not yet realize

Re: 2.6.24-rc8-rt1: Strange latencies on mpc5200 powerpc

2008-01-28 Thread Wolfgang Grandegger
Hi Fu, Luotao Fu wrote: > Hi, > > I took some time today and went through Wolfgangs scenarios partly. Now > some results from my side. I ran my tests on a 2.6.24-rt1 > > Wolfgang Grandegger wrote: > > I also did some more measurements and made, by chance, interesting

Re: 2.6.24-rc8-rt1: Strange latencies on mpc5200 powerpc

2008-01-24 Thread Wolfgang Grandegger
Wolfgang Grandegger wrote: > Hi Fu, > > Luotao Fu wrote: >> Hi folks, >> >> On Thu, Jan 17, 2008 at 11:13:26AM +0100, Wolfgang Grandegger wrote: >>> It builds and runs fine on my Icecube-MPC5200 board, now also with the >>> latency tracer enabled. Th

Re: 2.6.24-rc8-rt1: Strange latencies on mpc5200 powerpc

2008-01-23 Thread Wolfgang Grandegger
Hi Fu, Luotao Fu wrote: > Hi folks, > > On Thu, Jan 17, 2008 at 11:13:26AM +0100, Wolfgang Grandegger wrote: >> It builds and runs fine on my Icecube-MPC5200 board, now also with the >> latency tracer enabled. That's great. Still, "cyclictest -n -p80 -i1000" &

Re: 2.6.24-rc8-rt1

2008-01-17 Thread Wolfgang Grandegger
Robert Schwebel wrote: > On Thu, Jan 17, 2008 at 11:13:26AM +0100, Wolfgang Grandegger wrote: >> # ./cyclictest -n -p80 -i1000 -b400 >> >> [...] >> >> Well, I'm not sure if this is the correct way to do it. Is there some >> doc on how to use

Re: 2.6.24-rc8-rt1

2008-01-17 Thread Wolfgang Grandegger
Steven Rostedt wrote: > On Thu, 17 Jan 2008, Daniel Walker wrote: > >> On Thu, 2008-01-17 at 19:17 +0100, Wolfgang Grandegger wrote: >>> [0.733248] TCP bind hash table entries: 2048 (order: 3, 57344 >>> bytes) >>> [0.741132] TCP: Hash tables con

Re: 2.6.24-rc8-rt1

2008-01-17 Thread Wolfgang Grandegger
Daniel Walker wrote: > On Thu, 2008-01-17 at 19:17 +0100, Wolfgang Grandegger wrote: >> [0.733248] TCP bind hash table entries: 2048 (order: 3, 57344 >> bytes) >> [0.741132] TCP: Hash tables configured (established 2048 bind >> 2048) >> [0.747981] TCP

Re: 2.6.24-rc8-rt1

2008-01-17 Thread Wolfgang Grandegger
Daniel Walker wrote: > On Thu, 2008-01-17 at 11:13 +0100, Wolfgang Grandegger wrote: >> Steven Rostedt wrote: >>> We are pleased to announce the 2.6.24-rc8-rt1 tree, which can be >>> downloaded from the location: >>> >>> http://rt.et.redhat.com/downl

Re: 2.6.24-rc8-rt1

2008-01-17 Thread Wolfgang Grandegger
Steven Rostedt wrote: > We are pleased to announce the 2.6.24-rc8-rt1 tree, which can be > downloaded from the location: > > http://rt.et.redhat.com/download/ It builds and runs fine on my Icecube-MPC5200 board, now also with the latency tracer enabled. That's great. Still, "cyclictest -n -p80

Re: v2.6.21-rt3

2007-05-18 Thread Wolfgang Grandegger
Thomas Gleixner wrote: Please do not top post ! On Fri, 2007-05-18 at 11:10 +0300, emin ak wrote: Yes, 2.6.21 was compiled and boot successfully for ppc, Is 85xx family supported for powerpc arch? I don't know. You might ask the folks on the ppc mailing list. E.g. check http://lxr.free-elec