Re: [PATCH net-next 1/1] rtnetlink: request RTM_GETLINK by pid or fd

2018-01-23 Thread Wolfgang Bumiller
On Tue, Jan 23, 2018 at 10:30:09AM +0100, Jiri Benc wrote: > On Mon, 22 Jan 2018 23:25:41 +0100, Christian Brauner wrote: > > This is not necessarily true in scenarios where I move a network device > > via RTM_NEWLINK + IFLA_NET_NS_PID into a network namespace I haven't > > created. Here is an exam

Re: [PATCH linux 2/2] net sched actions: fix refcount decrement on error

2017-04-15 Thread Wolfgang Bumiller
> On April 15, 2017 at 8:20 PM Cong Wang wrote: > > > On Fri, Apr 14, 2017 at 2:08 AM, Wolfgang Bumiller > wrote: > > Before I do that - trying to wrap my head around the interdependencies > > here better to be thorough - I noticed that tcf_hash_release() can &g

Re: [PATCH linux 2/2] net sched actions: fix refcount decrement on error

2017-04-14 Thread Wolfgang Bumiller
On Thu, Apr 13, 2017 at 11:03:37AM -0700, Cong Wang wrote: > On Thu, Apr 13, 2017 at 1:06 AM, Wolfgang Bumiller > wrote: > > On Wed, Apr 12, 2017 at 09:27:31PM -0700, Cong Wang wrote: > >> Instead of duplicating code, you can add the check > >> to the module_put()

Re: [PATCH linux 2/2] net sched actions: fix refcount decrement on error

2017-04-13 Thread Wolfgang Bumiller
On Wed, Apr 12, 2017 at 09:27:31PM -0700, Cong Wang wrote: > On Wed, Apr 12, 2017 at 7:21 AM, Wolfgang Bumiller > wrote: > > If memory allocation for nla_memdup_cookie() fails > > module_put has to be guarded by the same condition as it was > > before the TCA_ACT_COOKIE

[RFC PATCH linux 0/2] net sched actions: access to uninitialized data and error handling

2017-04-12 Thread Wolfgang Bumiller
Apr 12 09:19:35 testmachine kernel: ---[ end trace 89cb022ec57f7bd1 ]--- Wolfgang Bumiller (2): net sched actions: fix access to uninitialized data net sched actions: fix refcount decrement on error net/sched/act_api.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) -- 2.11.0

[PATCH linux 1/2] net sched actions: fix access to uninitialized data

2017-04-12 Thread Wolfgang Bumiller
Signed-off-by: Wolfgang Bumiller --- net/sched/act_api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/act_api.c b/net/sched/act_api.c index b70aa57319ea..8cc883c063f0 100644 --- a/net/sched/act_api.c +++ b/net/sched/act_api.c @@ -604,7 +604,7 @@ struct tc_action

[PATCH linux 2/2] net sched actions: fix refcount decrement on error

2017-04-12 Thread Wolfgang Bumiller
->init() then * ACT_P_CREATED is not returned (a zero is). */ Signed-off-by: Wolfgang Bumiller --- Note that I'm unsure about this patch. The hangups weren't very reliable and I couldn't actually reproduce them when building from git/master (as I can only test a fraction of my u

[RFC PATCH] cgroup, cpuset: add cpuset.remap_cpus

2016-12-22 Thread Wolfgang Bumiller
Changes a cpuset, recursively remapping all its descendants to the new range. Signed-off-by: Wolfgang Bumiller --- Currently once a cpuset cgroup has a subdirectory it's impossible to remove cpu without manually recursing through the cgroup file system. The problem gets worse if you wa