Re: [PATCH] kselftest/arm64/gcs/basic-gcs: Respect parent directory CFLAGS

2025-09-18 Thread Will Deacon
On Tue, 16 Sep 2025 18:51:35 +0200, Thomas Weißschuh wrote: > basic-gcs has it's own make rule to handle the special compiler > invocation to build against nolibc. This rule does not respect the > $(CFLAGS) passed by the Makefile from the parent directory. > However these $(CFLAGS) set up the inclu

Re: [PATCH v21 4/8] fork: Add shadow stack support to clone3()

2025-09-18 Thread Will Deacon
On Thu, Sep 18, 2025 at 01:38:53PM +0100, Will Deacon wrote: > On Tue, Sep 16, 2025 at 12:12:09AM +0100, Mark Brown wrote: > > Unlike with the normal stack there is no API for configuring the shadow > > stack for a new thread, instead the kernel will dynamically allocate a >

Re: [PATCH v21 4/8] fork: Add shadow stack support to clone3()

2025-09-18 Thread Will Deacon
On Tue, Sep 16, 2025 at 12:12:09AM +0100, Mark Brown wrote: > Unlike with the normal stack there is no API for configuring the shadow > stack for a new thread, instead the kernel will dynamically allocate a > new shadow stack with the same size as the normal stack. This appears to > be due to the s

Re: [PATCH v2] selftests/arm64: Fix grammatical error in string literals

2025-09-08 Thread Will Deacon
On Wed, 27 Aug 2025 00:49:13 +0300, Nikola Z. Ivanov wrote: > Fix grammatical error in + > construct related to memory allocation checks. > In essence change "Failed to allocated" to "Failed to allocate". > > Applied to arm64 (for-next/selftests), thanks! [1/1] selftests/arm64: Fix grammatica

Re: [PATCH v2] selftests: arm64: Check fread return value in exec_target

2025-09-08 Thread Will Deacon
On Fri, 08 Aug 2025 13:38:30 +0530, Bala-Vignesh-Reddy wrote: > Fix -Wunused-result warning generated when compiled with gcc 13.3.0, > by checking fread's return value and handling errors, preventing > potential failures when reading from stdin. > > Fixes compiler warning: > warning: ignoring retu

Re: [PATCH v2] selftests: arm64: Fix -Waddress warning in tpidr2 test

2025-09-08 Thread Will Deacon
On Thu, 07 Aug 2025 17:12:29 +0530, Bala-Vignesh-Reddy wrote: > Resolve compiler warning about always true condition in ksft_test_result > in tpidr2, passing actual function. > > This silences -Waddress warning while maintaining test functionality. > > Fixes compiler warning (similar for other fu

Re: [PATCH 0/2] kselftest/arm64/gcs: Cleanups for basic-gcs.c

2025-09-08 Thread Will Deacon
On Thu, 21 Aug 2025 17:13:01 +0200, Thomas Weißschuh wrote: > Two small cleanups. > > Applied to arm64 (for-next/selftests), thanks! [1/2] kselftest/arm64/gcs: Correctly check return value when disabling GCS https://git.kernel.org/arm64/c/740cdafd0d99 [2/2] kselftest/arm64/gcs: Use nolibc

Re: [PATCH] kselftest/arm64: Log error codes in sve-ptrace

2025-09-08 Thread Will Deacon
On Tue, 12 Aug 2025 15:37:00 +0100, Mark Brown wrote: > Use ksft_perror() to report error codes from failing ptrace operations to > make it easier to interpret logs when things go wrong. > > Applied to arm64 (for-next/selftests), thanks! [1/1] kselftest/arm64: Log error codes in sve-ptrace

[PATCH 2/2] vsock/virtio: Fix message iterator handling on transmit path

2025-08-18 Thread Will Deacon
nsport_fill_skb_full() to restore the previous iterator behaviour. Cc: Hillf Danton Cc: Stefano Garzarella Cc: Stefan Hajnoczi Cc: "Michael S. Tsirkin" Cc: Jason Wang Reported-by: syzbot+b4d960daf7a3c7c2b...@syzkaller.appspotmail.com Signed-off-by: Will Deacon --- net/vmw_vsock

[PATCH 1/2] net: Introduce skb_copy_datagram_from_iter_full()

2025-08-18 Thread Will Deacon
Cc: Eric Dumazet Cc: Jakub Kicinski Cc: "David S. Miller" Cc: Alexander Viro Signed-off-by: Will Deacon --- include/linux/skbuff.h | 2 ++ net/core/datagram.c| 14 ++ 2 files changed, 16 insertions(+) diff --git a/include/linux/skbuff.h b/include/linux/skbu

[PATCH 0/2] Fix vsock error-handling regression introduced in v6.17-rc1

2025-08-18 Thread Will Deacon
David S. Miller" Cc: Eric Dumazet Cc: Hillf Danton Cc: Jakub Kicinski Cc: Jason Wang Cc: "Michael S. Tsirkin" Cc: Paolo Abeni Cc: Stefan Hajnoczi Cc: Stefano Garzarella --->8 Will Deacon (2): net: Introduce skb_copy_datagram_from_iter_full() vsock/virtio: Fix messa

Re: [syzbot] [kvm?] [net?] [virt?] WARNING in virtio_transport_send_pkt_info

2025-08-18 Thread Will Deacon
On Sat, Aug 16, 2025 at 06:34:29AM -0400, Michael S. Tsirkin wrote: > On Fri, Aug 15, 2025 at 04:48:00PM +0100, Will Deacon wrote: > > On Fri, Aug 15, 2025 at 01:00:59PM +0100, Will Deacon wrote: > > > On Fri, Aug 15, 2025 at 06:44:47AM -0400, Michael S. Tsirkin wrote: > >

Re: [syzbot] [kvm?] [net?] [virt?] WARNING in virtio_transport_send_pkt_info

2025-08-15 Thread Will Deacon
On Fri, Aug 15, 2025 at 01:00:59PM +0100, Will Deacon wrote: > On Fri, Aug 15, 2025 at 06:44:47AM -0400, Michael S. Tsirkin wrote: > > On Fri, Aug 15, 2025 at 11:09:24AM +0100, Will Deacon wrote: > > > On Tue, Aug 12, 2025 at 06:15:46AM -0400, Michael S. Tsirkin wrote: > >

Re: [syzbot] [kvm?] [net?] [virt?] WARNING in virtio_transport_send_pkt_info

2025-08-15 Thread Will Deacon
On Fri, Aug 15, 2025 at 06:44:47AM -0400, Michael S. Tsirkin wrote: > On Fri, Aug 15, 2025 at 11:09:24AM +0100, Will Deacon wrote: > > On Tue, Aug 12, 2025 at 06:15:46AM -0400, Michael S. Tsirkin wrote: > > > On Tue, Aug 12, 2025 at 03:03:02AM -0700, syzbot wr

Re: [syzbot] [kvm?] [net?] [virt?] WARNING in virtio_transport_send_pkt_info

2025-08-15 Thread Will Deacon
port_send_pkt_info > > OK so the issue triggers on > commit 6693731487a8145a9b039bc983d77edc47693855 > Author: Will Deacon > Date: Thu Jul 17 10:01:16 2025 +0100 > > vsock/virtio: Allocate nonlinear SKBs for handling large transmit bu

Re: [RESEND PATCH] selftests/pidfd: align stack to fix SP alignment exception

2025-07-21 Thread Will Deacon
On Fri, Jul 18, 2025 at 03:10:32PM -0600, Shuah Khan wrote: > Can you take a look at this and let me know if this change looks > good to you both. > > I can take this through my tree after your reviews. I never got to the point of fully understanding how the test was supposed to work, but it is t

Re: [PATCH] kselftest/arm4: Provide local defines for AT_HWCAP3

2025-07-17 Thread Will Deacon
On Tue, 15 Jul 2025 22:11:41 +0100, Mark Brown wrote: > Some build environments for the selftests are not picking up the newly > added AT_HWCAP3 when using the libc headers, even with headers_install > (which we require already for the arm64 selftests). As a quick fix add > local definitions of th

[PATCH v4 0/9] vsock/virtio: SKB allocation improvements

2025-07-17 Thread Will Deacon
: "Eugenio Pérez" Cc: linux-kernel@vger.kernel.org Cc: net...@vger.kernel.org Cc: virtualizat...@lists.linux.dev --->8 Will Deacon (9): vhost/vsock: Avoid allocating arbitrarily-sized SKBs vsock/virtio: Validate length in packet header before skb_put() vsock/virtio: Move len

[PATCH v4 7/9] vhost/vsock: Allocate nonlinear SKBs for handling large receive buffers

2025-07-17 Thread Will Deacon
packet header in the SKB and the receive data in the fragments. Finally, add a debug warning if virtio_vsock_skb_rx_put() is ever called on an SKB with a non-zero length, as this would be destructive for the nonlinear case. Reviewed-by: Stefano Garzarella Signed-off-by: Will Deacon --- drivers

[PATCH v4 9/9] vsock/virtio: Allocate nonlinear SKBs for handling large transmit buffers

2025-07-17 Thread Will Deacon
packet header in the SKB and the transmit data in the fragments. Note that this affects both the vhost and virtio transports. Reviewed-by: Stefano Garzarella Signed-off-by: Will Deacon --- net/vmw_vsock/virtio_transport_common.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff

[PATCH v4 6/9] vsock/virtio: Move SKB allocation lower-bound check to callers

2025-07-17 Thread Will Deacon
already has a check against the maximum packet size, extend its bounds checking to consider the minimum packet size and remove the check from virtio_vsock_alloc_linear_skb(). Reviewed-by: Stefano Garzarella Signed-off-by: Will Deacon --- drivers/vhost/vsock.c| 3 ++- include/linux

[PATCH v4 8/9] vsock/virtio: Rename virtio_vsock_skb_rx_put()

2025-07-17 Thread Will Deacon
In preparation for using virtio_vsock_skb_rx_put() when populating SKBs on the vsock TX path, rename virtio_vsock_skb_rx_put() to virtio_vsock_skb_put(). No functional change. Reviewed-by: Stefano Garzarella Signed-off-by: Will Deacon --- drivers/vhost/vsock.c| 2 +- include/linux

[PATCH v4 5/9] vsock/virtio: Rename virtio_vsock_alloc_skb()

2025-07-17 Thread Will Deacon
Signed-off-by: Will Deacon --- drivers/vhost/vsock.c | 2 +- include/linux/virtio_vsock.h| 3 ++- net/vmw_vsock/virtio_transport.c| 2 +- net/vmw_vsock/virtio_transport_common.c | 2 +- 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/vhost

[PATCH v4 3/9] vsock/virtio: Move length check to callers of virtio_vsock_skb_rx_put()

2025-07-17 Thread Will Deacon
vhost code already has similar logic in vhost_vsock_alloc_skb(). Reviewed-by: Stefano Garzarella Signed-off-by: Will Deacon --- drivers/vhost/vsock.c| 2 +- include/linux/virtio_vsock.h | 9 ++--- net/vmw_vsock/virtio_transport.c | 4 +++- 3 files changed, 6 insertions(+), 9

[PATCH v4 2/9] vsock/virtio: Validate length in packet header before skb_put()

2025-07-17 Thread Will Deacon
gone wonky. Validate the length as advertised by the packet header before calling virtio_vsock_skb_rx_put(). Cc: Fixes: 71dc9ec9ac7d ("virtio/vsock: replace virtio_vsock_pkt with sk_buff") Signed-off-by: Will Deacon --- net/vmw_vsock/virtio_transport.c | 12 ++-- 1 file c

[PATCH v4 1/9] vhost/vsock: Avoid allocating arbitrarily-sized SKBs

2025-07-17 Thread Will Deacon
("virtio/vsock: replace virtio_vsock_pkt with sk_buff") Reviewed-by: Stefano Garzarella Signed-off-by: Will Deacon --- drivers/vhost/vsock.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c index 802153e23073..66

[PATCH v4 4/9] vsock/virtio: Resize receive buffers so that each SKB fits in a 4K page

2025-07-17 Thread Will Deacon
pages entirely. Reviewed-by: Stefano Garzarella Signed-off-by: Will Deacon --- include/linux/virtio_vsock.h | 7 ++- net/vmw_vsock/virtio_transport.c | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/include/linux/virtio_vsock.h b/include/linux/virtio_vsock.h index

Re: [PATCH v3 0/9] vsock/virtio: SKB allocation improvements

2025-07-15 Thread Will Deacon
On Tue, Jul 15, 2025 at 12:01:56PM +0200, Stefano Garzarella wrote: > On Mon, Jul 14, 2025 at 04:20:54PM +0100, Will Deacon wrote: > > Hi folks, > > > > Here is version three of the patches I previously posted here: > > > > v1: https://lore.kernel.org/r/2025

Re: [PATCH 1/2] bpf, arm64: remove structs on stack constraint

2025-07-15 Thread Will Deacon
On Tue, Jul 15, 2025 at 04:02:25PM +0200, Alexis Lothoré wrote: > On Tue Jul 15, 2025 at 3:32 PM CEST, Will Deacon wrote: > > On Wed, Jul 09, 2025 at 10:36:55AM +0200, Alexis Lothoré (eBPF Foundation) > > wrote: > >> While introducing support for 9+ arguments for tracin

Re: [PATCH 1/2] bpf, arm64: remove structs on stack constraint

2025-07-15 Thread Will Deacon
On Wed, Jul 09, 2025 at 10:36:55AM +0200, Alexis Lothoré (eBPF Foundation) wrote: > While introducing support for 9+ arguments for tracing programs on > ARM64, commit 9014cf56f13d ("bpf, arm64: Support up to 12 function > arguments") has also introduced a constraint preventing BPF trampolines > fr

[PATCH v3 9/9] vsock/virtio: Allocate nonlinear SKBs for handling large transmit buffers

2025-07-14 Thread Will Deacon
packet header in the SKB and the transmit data in the fragments. No that this affects both the vhost and virtio transports. Reviewed-by: Stefano Garzarella Signed-off-by: Will Deacon --- net/vmw_vsock/virtio_transport_common.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff

[PATCH v3 8/9] vsock/virtio: Rename virtio_vsock_skb_rx_put()

2025-07-14 Thread Will Deacon
In preparation for using virtio_vsock_skb_rx_put() when populating SKBs on the vsock TX path, rename virtio_vsock_skb_rx_put() to virtio_vsock_skb_put(). No functional change. Reviewed-by: Stefano Garzarella Signed-off-by: Will Deacon --- drivers/vhost/vsock.c| 2 +- include/linux

[PATCH v3 5/9] vsock/virtio: Rename virtio_vsock_alloc_skb()

2025-07-14 Thread Will Deacon
In preparation for nonlinear allocations for large SKBs, rename virtio_vsock_alloc_skb() to virtio_vsock_alloc_linear_skb() to indicate that it returns linear SKBs unconditionally and switch all callers over to this new interface for now. No functional change. Signed-off-by: Will Deacon

[PATCH v3 7/9] vhost/vsock: Allocate nonlinear SKBs for handling large receive buffers

2025-07-14 Thread Will Deacon
packet header in the SKB and the receive data in the fragments. Finally, add a debug warning if virtio_vsock_skb_rx_put() is ever called on an SKB with a non-zero length, as this would be destructive for the nonlinear case. Signed-off-by: Will Deacon --- drivers/vhost/vsock.c| 8

[PATCH v3 6/9] vsock/virtio: Move SKB allocation lower-bound check to callers

2025-07-14 Thread Will Deacon
already has a check against the maximum packet size, extend its bounds checking to consider the minimum packet size and remove the check from virtio_vsock_alloc_linear_skb(). Signed-off-by: Will Deacon --- drivers/vhost/vsock.c| 3 ++- include/linux/virtio_vsock.h | 3 --- 2 files changed, 2

[PATCH v3 4/9] vsock/virtio: Resize receive buffers so that each SKB fits in a 4K page

2025-07-14 Thread Will Deacon
pages entirely. Signed-off-by: Will Deacon --- include/linux/virtio_vsock.h | 7 ++- net/vmw_vsock/virtio_transport.c | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/include/linux/virtio_vsock.h b/include/linux/virtio_vsock.h index 97465f378ade..879f1dfa7d3a 100644

[PATCH v3 3/9] vsock/virtio: Move length check to callers of virtio_vsock_skb_rx_put()

2025-07-14 Thread Will Deacon
vhost code already has similar logic in vhost_vsock_alloc_skb(). Signed-off-by: Will Deacon --- drivers/vhost/vsock.c| 2 +- include/linux/virtio_vsock.h | 9 ++--- net/vmw_vsock/virtio_transport.c | 4 +++- 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers

[PATCH v3 2/9] vsock/virtio: Validate length in packet header before skb_put()

2025-07-14 Thread Will Deacon
gone wonky. Validate the length as advertised by the packet header before calling virtio_vsock_skb_rx_put(). Cc: Fixes: 71dc9ec9ac7d ("virtio/vsock: replace virtio_vsock_pkt with sk_buff") Signed-off-by: Will Deacon --- net/vmw_vsock/virtio_transport.c | 12 ++-- 1 file c

[PATCH v3 0/9] vsock/virtio: SKB allocation improvements

2025-07-14 Thread Will Deacon
: Stefan Hajnoczi Cc: Stefano Garzarella Cc: "Michael S. Tsirkin" Cc: Jason Wang Cc: "Eugenio Pérez" Cc: linux-kernel@vger.kernel.org Cc: net...@vger.kernel.org Cc: virtualizat...@lists.linux.dev --->8 Will Deacon (9): vhost/vsock: Avoid allocating arbitrarily-si

[PATCH v3 1/9] vhost/vsock: Avoid allocating arbitrarily-sized SKBs

2025-07-14 Thread Will Deacon
("virtio/vsock: replace virtio_vsock_pkt with sk_buff") Signed-off-by: Will Deacon --- drivers/vhost/vsock.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c index 802153e23073..66a0f060770e 100644 --- a/drivers/vho

Re: [PATCH v2 6/8] vhost/vsock: Allocate nonlinear SKBs for handling large receive buffers

2025-07-13 Thread Will Deacon
On Wed, Jul 02, 2025 at 06:50:59PM +0200, Stefano Garzarella wrote: > On Tue, Jul 01, 2025 at 05:45:05PM +0100, Will Deacon wrote: > > -static inline struct sk_buff *virtio_vsock_alloc_skb(unsigned int size, > > gfp_t mask) > > +static

Re: [PATCH v2 5/8] vsock/virtio: Add vsock helper for linear SKB allocation

2025-07-13 Thread Will Deacon
On Wed, Jul 02, 2025 at 06:40:17PM +0200, Stefano Garzarella wrote: > On Tue, Jul 01, 2025 at 05:45:04PM +0100, Will Deacon wrote: > > In preparation for nonlinear allocations for large SKBs, introduce a > > new virtio_vsock_alloc_linear_skb() helper to return linear SKBs > >

Re: [PATCH v2 4/8] vsock/virtio: Resize receive buffers so that each SKB fits in a page

2025-07-13 Thread Will Deacon
On Wed, Jul 02, 2025 at 03:16:19PM +0200, Stefano Garzarella wrote: > On Tue, Jul 01, 2025 at 08:14:00PM +0100, David Laight wrote: > > On Tue, 1 Jul 2025 17:45:03 +0100 > > Will Deacon wrote: > > > > > When allocating receive buffers for the vsock virtio RX virtqu

Re: [PATCH v2 3/8] vsock/virtio: Move length check to callers of virtio_vsock_skb_rx_put()

2025-07-13 Thread Will Deacon
On Wed, Jul 02, 2025 at 06:28:37PM +0200, Stefano Garzarella wrote: > On Tue, Jul 01, 2025 at 05:45:02PM +0100, Will Deacon wrote: > > virtio_vsock_skb_rx_put() only calls skb_put() if the length in the > > packet header is not zero even though skb_put() handles this case

Re: [PATCH v2 0/8] vsock/virtio: SKB allocation improvements

2025-07-13 Thread Will Deacon
On Fri, Jul 04, 2025 at 05:50:16PM +0800, Lei Yang wrote: > I tested this series of patches with virtio-net regression tests, > everything works fine. > > Tested-by: Lei Yang Thanks, but this series doesn't touch virtio-net: it's purely about the virtio transport for vsock. Do the virtio-net reg

Re: [PATCH rcu 06/13] torture: Provide EXPERT Kconfig option for arm64 KCSAN torture.sh runs

2025-07-11 Thread Will Deacon
pt to provide this option, but only for --kcsan runs on > arm64 systems. > > Signed-off-by: Paul E. McKenney > Cc: Marco Elver > Cc: Dmitry Vyukov > Cc: Catalin Marinas > Cc: Will Deacon > Cc: > Cc: > Signed-off-by: Neeraj Upadhyay (AMD) > --- > tools/t

[PATCH v2 8/8] vsock/virtio: Allocate nonlinear SKBs for handling large transmit buffers

2025-07-01 Thread Will Deacon
packet header in the SKB and the transmit data in the fragments. No that this affects both the vhost and virtio transports. Signed-off-by: Will Deacon --- net/vmw_vsock/virtio_transport_common.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/vmw_vsock

[PATCH v2 0/8] vsock/virtio: SKB allocation improvements

2025-07-01 Thread Will Deacon
sts.linux.dev --->8 Will Deacon (8): vhost/vsock: Avoid allocating arbitrarily-sized SKBs vsock/virtio: Validate length in packet header before skb_put() vsock/virtio: Move length check to callers of virtio_vsock_skb_rx_put() vsock/virtio: Resize receive buffers so that each SKB

[PATCH v2 7/8] vsock/virtio: Rename virtio_vsock_skb_rx_put() to virtio_vsock_skb_put()

2025-07-01 Thread Will Deacon
In preparation for using virtio_vsock_skb_rx_put() when populating SKBs on the vsock TX path, rename virtio_vsock_skb_rx_put() to virtio_vsock_skb_put(). No functional change. Reviewed-by: Stefano Garzarella Signed-off-by: Will Deacon --- drivers/vhost/vsock.c| 2 +- include/linux

[PATCH v2 6/8] vhost/vsock: Allocate nonlinear SKBs for handling large receive buffers

2025-07-01 Thread Will Deacon
destructive for the nonlinear case. Signed-off-by: Will Deacon --- drivers/vhost/vsock.c| 11 +-- include/linux/virtio_vsock.h | 32 +--- 2 files changed, 30 insertions(+), 13 deletions(-) diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c index

[PATCH v2 1/8] vhost/vsock: Avoid allocating arbitrarily-sized SKBs

2025-07-01 Thread Will Deacon
("virtio/vsock: replace virtio_vsock_pkt with sk_buff") Signed-off-by: Will Deacon --- drivers/vhost/vsock.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c index 802153e23073..66a0f060770e 100644 --- a/drivers/vho

[PATCH v2 5/8] vsock/virtio: Add vsock helper for linear SKB allocation

2025-07-01 Thread Will Deacon
In preparation for nonlinear allocations for large SKBs, introduce a new virtio_vsock_alloc_linear_skb() helper to return linear SKBs unconditionally and switch all callers over to this new interface for now. No functional change. Signed-off-by: Will Deacon --- drivers/vhost/vsock.c

[PATCH v2 4/8] vsock/virtio: Resize receive buffers so that each SKB fits in a page

2025-07-01 Thread Will Deacon
-by: Will Deacon --- include/linux/virtio_vsock.h | 1 - net/vmw_vsock/virtio_transport.c | 7 ++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/include/linux/virtio_vsock.h b/include/linux/virtio_vsock.h index eb6980aa19fd..1b5731186095 100644 --- a/include/linux

[PATCH v2 3/8] vsock/virtio: Move length check to callers of virtio_vsock_skb_rx_put()

2025-07-01 Thread Will Deacon
credit messages, augment the existing length checks in virtio_transport_rx_work() to elide the call for zero-length payloads. Note that the vhost code already has similar logic in vhost_vsock_alloc_skb(). Signed-off-by: Will Deacon --- include/linux/virtio_vsock.h | 4 +--- net/vmw_vsock

[PATCH v2 2/8] vsock/virtio: Validate length in packet header before skb_put()

2025-07-01 Thread Will Deacon
gone wonky. Validate the length as advertised by the packet header before calling virtio_vsock_skb_rx_put(). Cc: Fixes: 71dc9ec9ac7d ("virtio/vsock: replace virtio_vsock_pkt with sk_buff") Signed-off-by: Will Deacon --- net/vmw_vsock/virtio_transport.c | 12 ++-- 1 file c

Re: [PATCH 3/5] vhost/vsock: Allocate nonlinear SKBs for handling large receive buffers

2025-07-01 Thread Will Deacon
On Tue, Jul 01, 2025 at 12:44:58PM +0200, Stefano Garzarella wrote: > On Mon, Jun 30, 2025 at 03:20:57PM +0100, Will Deacon wrote: > > On Fri, Jun 27, 2025 at 12:45:45PM +0200, Stefano Garzarella wrote: > > > On Wed, Jun 25, 2025 at 02:15:41PM +0100, Will Deacon wrote: > >

Re: [PATCH 5/5] vhost/vsock: Allocate nonlinear SKBs for handling large transmit buffers

2025-06-30 Thread Will Deacon
Jun 25, 2025 at 02:15:43PM +0100, Will Deacon wrote: > > When transmitting a vsock packet, virtio_transport_send_pkt_info() calls > > virtio_transport_alloc_skb() to allocate and fill SKBs with the transmit > > data. Unfortunately, these are always linear allocations and can >

Re: [PATCH 3/5] vhost/vsock: Allocate nonlinear SKBs for handling large receive buffers

2025-06-30 Thread Will Deacon
On Fri, Jun 27, 2025 at 12:45:45PM +0200, Stefano Garzarella wrote: > On Wed, Jun 25, 2025 at 02:15:41PM +0100, Will Deacon wrote: > > When receiving a packet from a guest, vhost_vsock_handle_tx_kick() > > calls vhost_vsock_alloc_skb() to allocate and fill an SKB with the &

Re: [PATCH 2/5] vsock/virtio: Resize receive buffers so that each SKB fits in a page

2025-06-30 Thread Will Deacon
On Fri, Jun 27, 2025 at 12:41:48PM +0200, Stefano Garzarella wrote: > On Wed, Jun 25, 2025 at 02:15:40PM +0100, Will Deacon wrote: > > When allocating receive buffers for the vsock virtio RX virtqueue, an > > SKB is allocated with a 4140 data payload (the 44-byt

Re: [PATCH 1/5] vhost/vsock: Avoid allocating arbitrarily-sized SKBs

2025-06-30 Thread Will Deacon
On Fri, Jun 27, 2025 at 12:36:46PM +0200, Stefano Garzarella wrote: > On Wed, Jun 25, 2025 at 02:15:39PM +0100, Will Deacon wrote: > > vhost_vsock_alloc_skb() returns NULL for packets advertising a length > > larger than VIRTIO_VSOCK_MAX_PKT_BUF_SIZE in the packet header. However, &

Re: [PATCH 0/5] vsock/virtio: SKB allocation improvements

2025-06-30 Thread Will Deacon
On Fri, Jun 27, 2025 at 12:51:45PM +0200, Stefano Garzarella wrote: > On Wed, Jun 25, 2025 at 02:15:38PM +0100, Will Deacon wrote: > > We're using vsock extensively in Android as a channel over which we can > > route binder transactions to/from virtual machines manage

Re: [PATCH v4] arm64: Implement HAVE_LIVEPATCH

2025-06-26 Thread Will Deacon
see more about the rationale. That aside, the code looks good to me. The sooner we can move over to the generic entry code, the better. Acked-by: Will Deacon Will

[PATCH 5/5] vhost/vsock: Allocate nonlinear SKBs for handling large transmit buffers

2025-06-25 Thread Will Deacon
header in the SKB and the transmit data in the fragments. Signed-off-by: Will Deacon --- net/vmw_vsock/virtio_transport_common.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c index

[PATCH 4/5] vsock/virtio: Rename virtio_vsock_skb_rx_put() to virtio_vsock_skb_put()

2025-06-25 Thread Will Deacon
In preparation for using virtio_vsock_skb_rx_put() when populating SKBs on the vsock TX path, rename virtio_vsock_skb_rx_put() to virtio_vsock_skb_put(). No functional change. Signed-off-by: Will Deacon --- drivers/vhost/vsock.c| 2 +- include/linux/virtio_vsock.h | 2 +- net

[PATCH 2/5] vsock/virtio: Resize receive buffers so that each SKB fits in a page

2025-06-25 Thread Will Deacon
-by: Will Deacon --- include/linux/virtio_vsock.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/linux/virtio_vsock.h b/include/linux/virtio_vsock.h index 36fb3edfa403..67ffb64325ef 100644 --- a/include/linux/virtio_vsock.h +++ b/include/linux/virtio_vsock.h @@ -111,7

[PATCH 1/5] vhost/vsock: Avoid allocating arbitrarily-sized SKBs

2025-06-25 Thread Will Deacon
check before the SKB allocation so that an iovec larger than VIRTIO_VSOCK_MAX_PKT_BUF_SIZE + the header size is rejected outright. The subsequent check on the length field in the header can then simply check that the allocated SKB is indeed large enough to hold the packet. Signed-off-by: Will

[PATCH 3/5] vhost/vsock: Allocate nonlinear SKBs for handling large receive buffers

2025-06-25 Thread Will Deacon
header in the SKB and the receive data in the fragments. Signed-off-by: Will Deacon --- drivers/vhost/vsock.c| 15 +-- include/linux/virtio_vsock.h | 31 +-- 2 files changed, 34 insertions(+), 12 deletions(-) diff --git a/drivers/vhost/vsock.c b

[PATCH 0/5] vsock/virtio: SKB allocation improvements

2025-06-25 Thread Will Deacon
Cheers, Will Cc: Keir Fraser Cc: Steven Moreland Cc: Frederick Mayle Cc: Stefan Hajnoczi Cc: Stefano Garzarella Cc: "Michael S. Tsirkin" Cc: Jason Wang Cc: "Eugenio Pérez" Cc: net...@vger.kernel.org Cc: virtualizat...@lists.linux.dev --->8 Will Deacon (5):

Re: [PATCH v3 1/2] arm64: Implement arch_stack_walk_reliable

2025-05-20 Thread Will Deacon
On Mon, May 19, 2025 at 02:41:06PM +0100, Mark Rutland wrote: > I've pushed a arm64/stacktrace-updates branch [1] with fixups for those > as two separate commits atop this one. If that looks good to you I > suggest we post that as a series and ask Will and Catalin to take that > as-is. Yes, please

Re: [PATCH v3 0/2] arm64: livepatch: Enable livepatch without sframe

2025-05-19 Thread Will Deacon
On Fri, May 16, 2025 at 09:53:36AM -0700, Song Liu wrote: > On Thu, Apr 10, 2025 at 8:17 AM Petr Mladek wrote: > > > [...] > > > > > > [1] > > > https://lore.kernel.org/live-patching/20250127213310.2496133-1-wn...@google.com/ > > > [2] > > > https://lore.kernel.org/live-patching/20250129232936.1

Re: [PATCH] kselftest/arm64: Set default OUTPUT path when undefined

2025-05-16 Thread Will Deacon
On Thu, 15 May 2025 13:18:39 +0800, tanze wrote: > When running 'make' in tools/testing/selftests/arm64/ without explicitly > setting the OUTPUT variable, the build system will creates test > directories (e.g., /bti) in the root filesystem due to OUTPUT defaulting > to an empty string. This causes

Re: [PATCH] selftests/pidfd: align stack to fix SP alignment exception

2025-04-04 Thread Will Deacon
On Wed, Mar 19, 2025 at 10:59:57AM +0800, Shuai Xue wrote: > + ARM maintainers for review. > > 在 2025/3/12 14:15, Shuai Xue 写道: > > The pidfd_test fails on the ARM64 platform with the following error: > > > > Bail out! pidfd_poll check for premature notification on child thread > > exec tes

Re: [PATCH 10/19] sched,arm64: Handle CPU isolation on last resort fallback rq selection

2025-01-08 Thread Will Deacon
On Sun, Jan 05, 2025 at 12:22:33AM +0100, Frederic Weisbecker wrote: > Le Fri, Jan 03, 2025 at 03:27:03PM +0000, Will Deacon a écrit : > > Maybe we could have a helper to consolidate things a little? > > > > static inline const struct cpumask * > > __task_cpu_possible

Re: [PATCH 10/19] sched,arm64: Handle CPU isolation on last resort fallback rq selection

2025-01-03 Thread Will Deacon
On Wed, Dec 11, 2024 at 04:40:23PM +0100, Frederic Weisbecker wrote: > When a kthread or any other task has an affinity mask that is fully > offline or unallowed, the scheduler reaffines the task to all possible > CPUs as a last resort. > > This default decision doesn't mix up very well with nohz_

Re: [PATCH net-next v16 06/26] kref/refcount: implement kref_put_sock()

2024-12-19 Thread Will Deacon
ng the refcount to 0. > > Cc: Will Deacon (maintainer:ATOMIC INFRASTRUCTURE) > Cc: Peter Zijlstra (maintainer:ATOMIC INFRASTRUCTURE) > Cc: Boqun Feng (reviewer:ATOMIC INFRASTRUCTURE) > Cc: Mark Rutland (reviewer:ATOMIC INFRASTRUCTURE) > Cc: Andrew Morton > Signed-off-by: An

Re: [PATCH v2 0/2] kselftest/arm64: fp-stress signal delivery interval improvements

2024-11-07 Thread Will Deacon
> kselftest/arm64: Increase frequency of signal delivery in fp-stress > kselftest/arm64: Poll less often while waiting for fp-stress children With these changes, I was easily able to reproduce the SVCR=0 bug so: Acked-by: Will Deacon for both. Will

Re: [PATCH 11/20] sched: Handle CPU isolation on last resort fallback rq selection

2024-10-28 Thread Will Deacon
Hi Frederic, Thanks for having a crack at this, but I'm pretty confused now so please prepare for a bunch of silly questions! On Tue, Oct 15, 2024 at 03:48:55PM +0200, Frederic Weisbecker wrote: > Le Tue, Oct 08, 2024 at 11:54:35AM +0100, Will Deacon a écrit : > > On Fri, Sep 27,

Re: [PATCH 11/20] sched: Handle CPU isolation on last resort fallback rq selection

2024-10-08 Thread Will Deacon
On Fri, Sep 27, 2024 at 12:48:59AM +0200, Frederic Weisbecker wrote: > When a kthread or any other task has an affinity mask that is fully > offline or unallowed, the scheduler reaffines the task to all possible > CPUs as a last resort. > > This default decision doesn't mix up very well with nohz_

Re: [PATCH RESEND v8 16/16] bpf: remove CONFIG_BPF_JIT dependency on CONFIG_MODULES of

2024-05-17 Thread Will Deacon
Hi Klara, On Fri, May 17, 2024 at 01:00:31AM +0200, Klara Modin wrote: > On 2024-05-05 18:06, Mike Rapoport wrote: > > From: "Mike Rapoport (IBM)" > > > > BPF just-in-time compiler depended on CONFIG_MODULES because it used > > module_alloc() to allocate memory for the generated code. > > > > S

Re: [PATCH 1/4] KVM: delete .change_pte MMU notifier callback

2024-04-19 Thread Will Deacon
On Thu, Apr 18, 2024 at 12:53:26PM -0700, Sean Christopherson wrote: > On Thu, Apr 18, 2024, Will Deacon wrote: > > On Mon, Apr 15, 2024 at 10:03:51AM -0700, Sean Christopherson wrote: > > > On Sat, Apr 13, 2024, Marc Zyngier wrote: > > > > On Fri, 12 Apr 2024 15:54

Re: [PATCH 1/4] KVM: delete .change_pte MMU notifier callback

2024-04-18 Thread Will Deacon
On Mon, Apr 15, 2024 at 10:03:51AM -0700, Sean Christopherson wrote: > On Sat, Apr 13, 2024, Marc Zyngier wrote: > > On Fri, 12 Apr 2024 15:54:22 +0100, Sean Christopherson > > wrote: > > > > > > On Fri, Apr 12, 2024, Marc Zyngier wrote: > > > > On

Re: [PATCH 1/4] KVM: delete .change_pte MMU notifier callback

2024-04-12 Thread Will Deacon
rn false; > -} > - > bool kvm_age_gfn(struct kvm *kvm, struct kvm_gfn_range *range) > { > u64 size = (range->end - range->start) << PAGE_SHIFT; Thanks. It's nice to see this code retire: Acked-by: Will Deacon Also, if you're in the business of hacking t

Re: [PATCH untested] vhost: order avail ring reads after index updates

2024-03-27 Thread Will Deacon
> some places treat it as an empty ring, others - non empty. > This patch does not attempt to change the existing behaviour. > > Cc: sta...@vger.kernel.org > Reported-by: Gavin Shan > Reported-by: Will Deacon > Suggested-by: Will Deacon > Fixes: 275bf960ac69 (&qu

Re: [PATCH] virtio_ring: Fix the stale index in available ring

2024-03-26 Thread Will Deacon
On Tue, Mar 26, 2024 at 11:43:13AM +, Will Deacon wrote: > On Tue, Mar 26, 2024 at 09:38:55AM +, Keir Fraser wrote: > > On Tue, Mar 26, 2024 at 03:49:02AM -0400, Michael S. Tsirkin wrote: > > > > Secondly, the debugging code is enhanced so that t

Re: [PATCH] virtio_ring: Fix the stale index in available ring

2024-03-26 Thread Will Deacon
On Tue, Mar 26, 2024 at 09:38:55AM +, Keir Fraser wrote: > On Tue, Mar 26, 2024 at 03:49:02AM -0400, Michael S. Tsirkin wrote: > > > Secondly, the debugging code is enhanced so that the available head for > > > (last_avail_idx - 1) is read for twice and recorded. It means the > > > available >

Re: [PATCH] virtio_ring: Fix the stale index in available ring

2024-03-19 Thread Will Deacon
On Tue, Mar 19, 2024 at 02:59:23PM +1000, Gavin Shan wrote: > On 3/19/24 02:59, Will Deacon wrote: > > On Thu, Mar 14, 2024 at 05:49:23PM +1000, Gavin Shan wrote: > > > The issue is reported by Yihuang Yu who have 'netperf' test on > > > NVidia's grace-gra

Re: [PATCH] virtio_ring: Fix the stale index in available ring

2024-03-19 Thread Will Deacon
On Tue, Mar 19, 2024 at 03:36:31AM -0400, Michael S. Tsirkin wrote: > On Mon, Mar 18, 2024 at 04:59:24PM +0000, Will Deacon wrote: > > On Thu, Mar 14, 2024 at 05:49:23PM +1000, Gavin Shan wrote: > > > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c > &

Re: [PATCH] virtio_ring: Fix the stale index in available ring

2024-03-18 Thread Will Deacon
On Thu, Mar 14, 2024 at 05:49:23PM +1000, Gavin Shan wrote: > The issue is reported by Yihuang Yu who have 'netperf' test on > NVidia's grace-grace and grace-hopper machines. The 'netperf' > client is started in the VM hosted by grace-hopper machine, > while the 'netperf' server is running on grace

Re: [PATCH] iommu/qcom: restore IOMMU state if needed

2023-12-12 Thread Will Deacon
On Wed, 11 Oct 2023 19:57:26 +0200, Luca Weiss wrote: > From: Vladimir Lypak > > If the IOMMU has a power domain then some state will be lost in > qcom_iommu_suspend and TZ will reset device if we don't call > qcom_scm_restore_sec_cfg before accessing it again. > > > [...] Applied to will (for

Re: [PATCH v3 04/13] mm/execmem, arch: convert remaining overrides of module_alloc to execmem

2023-11-07 Thread Will Deacon
On Mon, Oct 30, 2023 at 09:00:53AM +0200, Mike Rapoport wrote: > On Thu, Oct 26, 2023 at 11:24:39AM +0100, Will Deacon wrote: > > On Thu, Oct 26, 2023 at 11:58:00AM +0300, Mike Rapoport wrote: > > > On Mon, Oct 23, 2023 at 06:14:20PM +0100, Will Deacon wrote: > > > >

Re: [PATCH v3 04/13] mm/execmem, arch: convert remaining overrides of module_alloc to execmem

2023-10-26 Thread Will Deacon
On Thu, Oct 26, 2023 at 11:58:00AM +0300, Mike Rapoport wrote: > On Mon, Oct 23, 2023 at 06:14:20PM +0100, Will Deacon wrote: > > On Mon, Sep 18, 2023 at 10:29:46AM +0300, Mike Rapoport wrote: > > > diff --git a/arch/arm64/kernel/module.c b/arch/arm64/kernel/module.c > &

Re: [PATCH v3 07/13] arm64, execmem: extend execmem_params for generated code allocations

2023-10-23 Thread Will Deacon
; -{ > - return __vmalloc_node_range(PAGE_SIZE, 1, VMALLOC_START, VMALLOC_END, > - GFP_KERNEL, PAGE_KERNEL_ROX, VM_FLUSH_RESET_PERMS, > - NUMA_NO_NODE, __builtin_return_address(0)); > -} It's slightly curious that we didn't clear the tag here, so it's nice that it all happens magically with your series: Acked-by: Will Deacon Will

Re: [PATCH v3 04/13] mm/execmem, arch: convert remaining overrides of module_alloc to execmem

2023-10-23 Thread Will Deacon
Hi Mike, On Mon, Sep 18, 2023 at 10:29:46AM +0300, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > Extend execmem parameters to accommodate more complex overrides of > module_alloc() by architectures. > > This includes specification of a fallback range required by arm, arm64 > and powerp

Re: [PATCH v2 00/14] Clean up RPM bus clocks remnants

2023-09-18 Thread Will Deacon
On Tue, 12 Sep 2023 15:31:38 +0200, Konrad Dybcio wrote: > After the recent cleanups ([1], [2]) some in-tree abusers that directly > accessed the RPM bus clocks, effectively circumventing and working > against the efforts of the interconnect framework, were found. > > Patches 1-5 drop deprecated r

Re: [RFC][PATCH] locking: Generic ticket-lock

2021-04-19 Thread Will Deacon
On Wed, Apr 14, 2021 at 12:16:38PM +0200, Peter Zijlstra wrote: > How's this then? Compile tested only on openrisc/simple_smp_defconfig. > > diff --git a/include/asm-generic/qspinlock.h b/include/asm-generic/qspinlock.h > index d74b13825501..a7a1296b0b4d 100644 > --- a/include/asm-generic/qspinloc

Re: [PATCH v5] arm64: Enable perf events based hard lockup detector

2021-04-19 Thread Will Deacon
On Mon, Apr 12, 2021 at 05:31:13PM +0530, Sumit Garg wrote: > On Tue, 30 Mar 2021 at 18:00, Sumit Garg wrote: > > On Tue, 30 Mar 2021 at 14:07, Lecopzer Chen > > wrote: > > > > > On Fri, 15 Jan 2021 at 17:32, Sumit Garg > > > > > wrote: > > > > > > > > > > > > With the recent feature added to

Re: [PATCH v2 1/3] iommu: io-pgtable: add DART pagetable format

2021-04-19 Thread Will Deacon
On Fri, Apr 09, 2021 at 09:38:15PM +0200, Arnd Bergmann wrote: > On Fri, Apr 9, 2021 at 6:56 PM Sven Peter wrote: > > On Wed, Apr 7, 2021, at 12:44, Will Deacon wrote: > > > On Sun, Mar 28, 2021 at 09:40:07AM +0200, Sven Peter wrote: > > > > > > > + cfg-&

Re: [PATCH v6 02/10] arm64: perf: Enable PMU counter direct access for perf event

2021-04-19 Thread Will Deacon
On Thu, Apr 08, 2021 at 01:38:17PM -0500, Rob Herring wrote: > On Thu, Apr 8, 2021 at 6:08 AM Mark Rutland wrote: > > On Wed, Apr 07, 2021 at 01:44:37PM +0100, Will Deacon wrote: > > > On Thu, Apr 01, 2021 at 02:45:21PM -0500, Rob Herring wrote: > > > > On Wed,

Re: [PATCH V6 1/4] arch_topology: Rename freq_scale as arch_freq_scale

2021-04-19 Thread Will Deacon
On Wed, Mar 10, 2021 at 10:53:23AM +0530, Viresh Kumar wrote: > Rename freq_scale to a less generic name, as it will get exported soon > for modules. Since x86 already names its own implementation of this as > arch_freq_scale, lets stick to that. > > Suggested-by: Will Deacon

Re: [PATCH 1/3] arm64: ptrace: Add is_syscall_success to handle compat

2021-04-19 Thread Will Deacon
On Fri, Apr 16, 2021 at 02:34:41PM +0100, Mark Rutland wrote: > On Fri, Apr 16, 2021 at 01:33:22PM +0100, Catalin Marinas wrote: > > On Fri, Apr 16, 2021 at 03:55:31PM +0800, He Zhe wrote: > > > The general version of is_syscall_success does not handle 32-bit > > > compatible case, which would caus

  1   2   3   4   5   6   7   8   9   10   >