Re: [Ocfs2-devel] [PATCH] ocfs2: Remove unneeded return variable

2021-02-04 Thread Wengang Wang
Actually I think the macro of map_flag() is ugly. Yang may want to fix that first. Thanks, Wengang On 2/3/21 9:12 PM, Joseph Qi wrote: NAK. This was discussed before, please refer: https://oss.oracle.com/pipermail/ocfs2-devel/2020-April/014969.html Thanks, Joseph On 2/4/21 11:12 AM, Yang Li

Re: [Ocfs2-devel] [PATCH 1/2] ocfs2: add last unlock times in locking_state

2019-05-28 Thread Wengang
not introduced by your change, well, it may lead to wrong stats... thanks, wengang static inline void ocfs2_track_lock_refresh(struct ocfs2_lock_res *lockres) @@ -3093,8 +3096,10 @@ static void *ocfs2_dlm_seq_next(struct seq_file *m, void *v, loff_t *pos) *- Lock stats printed * Ne

Re: [Ocfs2-devel] [PATCH V3 2/2] ocfs2: add locking filter debugfs file

2019-05-24 Thread Wengang Wang
Hi Gang, OK, I was thinking you are dumping the new last access time field too. thanks, wengang On 2019/5/23 19:15, Gang He wrote: Hello Wengang, This patch is used to add a filter attribute(the default value is 0), the kernel module can use this attribute value to filter the lock resources

Re: [Ocfs2-devel] [PATCH V3 2/2] ocfs2: add locking filter debugfs file

2019-05-23 Thread Wengang
Hi Gang, Could you paste an example of outputs before patch VS that after patch? I think that would directly show what the patch does. thanks, wengang On 05/23/2019 03:40 AM, Gang He wrote: Add locking filter debugfs file, which is used to filter lock resources dump from locking_state debugfs

Re: [PATCH] mm: use this_cpu_cmpxchg_double in put_cpu_partial

2018-11-26 Thread Wengang Wang
On 2018/11/26 16:36, Wei Yang wrote: On Mon, Nov 26, 2018 at 08:57:54AM -0800, Wengang Wang wrote: On 2018/11/25 17:59, Wei Yang wrote: On Tue, Nov 20, 2018 at 10:58 AM zhong jiang wrote: On 2018/11/17 9:33, Wengang Wang wrote: The this_cpu_cmpxchg makes the do-while loop pass as long

Re: [PATCH] mm: use this_cpu_cmpxchg_double in put_cpu_partial

2018-11-26 Thread Wengang Wang
On 2018/11/25 17:59, Wei Yang wrote: On Tue, Nov 20, 2018 at 10:58 AM zhong jiang wrote: On 2018/11/17 9:33, Wengang Wang wrote: The this_cpu_cmpxchg makes the do-while loop pass as long as the s->cpu_slab->partial as the same value. It doesn't care what happened to that slab. I

Re: [PATCH] mm: use this_cpu_cmpxchg_double in put_cpu_partial

2018-11-20 Thread Wengang Wang
t will win the compare with s->cpu_partial and go ahead to unfreeze the partial slabs. Though it may be not a perfect fix for this issue, it really fixes (or workarounds) the issue here. I'd like to skip my patch.. <=== Copy ends thanks, wengang On 2018/11/20 19:02, Wei Yang wrote

Re: [PATCH] mm: use this_cpu_cmpxchg_double in put_cpu_partial

2018-11-20 Thread Wengang Wang
Hi Zhong, On 2018/11/19 18:18, zhong jiang wrote: On 2018/11/17 9:33, Wengang Wang wrote: The this_cpu_cmpxchg makes the do-while loop pass as long as the s->cpu_slab->partial as the same value. It doesn't care what happened to that slab. Interrupt is not disabled, and new all

Re: [PATCH] mm: use this_cpu_cmpxchg_double in put_cpu_partial

2018-11-20 Thread Wengang Wang
Hi Wei, On 2018/11/17 17:02, Wei Yang wrote: On Fri, Nov 16, 2018 at 05:33:35PM -0800, Wengang Wang wrote: The this_cpu_cmpxchg makes the do-while loop pass as long as the s->cpu_slab->partial as the same value. It doesn't care what happened to that slab. Interrupt is not disabl

[PATCH] mm: use this_cpu_cmpxchg_double in put_cpu_partial

2018-11-16 Thread Wengang Wang
ly want no alloc/free happen in between, but just want to make sure the first slab did expereince a remove and re-add. This patch is more to call for ideas. Signed-off-by: Wengang Wang --- mm/slub.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/mm/slub

Re: [PATCH v1] xen/grant-table: log the lack of grants

2017-07-13 Thread Wengang
Hi, Anyone can you please review this patch? thanks, wengang On 07/07/2017 11:23 AM, Wengang Wang wrote: log a message when we enter this situation: 1) we already allocated the max number of available grants from hypervisor and 2) we still need more (but the request fails because of 1

[PATCH v1] xen/grant-table: log the lack of grants

2017-07-07 Thread Wengang Wang
. Signed-off-by: Wengang Wang Reviewed-by: Konrad Rzeszutek Wilk Reviewed-by: Junxiao Bi --- drivers/xen/grant-table.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c index d6786b8..2c6a911 100644 --- a/drivers/xen/grant

tasklet_kill makes sure no future re-schedule?

2016-07-28 Thread Wengang
some other code from rescheduling the lasklet". But I want a confirm here please! Thanks, Wengang

Re: [Ocfs2-devel] [PATCH 1/1] OCFS2: Remove NULL assignments on static

2014-04-08 Thread Wengang
Hi Fabian, What's the badness if we do the assignments? thanks, wengang 于 2014年04月09日 04:13, Fabian Frederick 写道: static values are automatically initialized to NULL. Cc: Andrew Morton Cc: ocfs2-de...@oss.oracle.com Signed-off-by: Fabian Frederick --- fs/ocfs2/cluster/tcp.c | 2 +-

Re: [PATCH] add check do_direct_IO() return val

2007-07-26 Thread wengang wang
that patch. thanks, wengang. **Joe Jin wrote: This is the patch for check do_direct_IO() return val. At do_direct_IO(), sometimes dio_get_page() will return -EFAULT/-ENOMEM, according to orig source, it will go on left work. buf for dio_get_page() return a error will made many useful member