[PATCH] vhost/vsock: initialize vhost_vsock->hash

2019-03-28 Thread Vitaly Mayatskikh
There's no current valid use case when uninitialized hash can be read before being written, however let's keep every vhost_vsock field initialized just for clarity. Signed-off-by: Vitaly Mayatskikh --- drivers/vhost/vsock.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dri

[PATCH] vhost: zero vhost_vsock memory on allocation

2019-03-26 Thread Vitaly Mayatskikh
uce with open/ioctl after trashing the RAM. Signed-off-by: Vitaly Mayatskikh --- drivers/vhost/vsock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c index bb5fc0e..9e7cb13 100644 --- a/drivers/vhost/vsock.c +++ b/drivers/vhost/vsoc

Re: [git pull] vfs.git fixes

2017-10-11 Thread Vitaly Mayatskikh
On Wed, 11 Oct 2017 00:54:57 -0400, Al Viro wrote: > > Fairly old DIO bug caught by Andreas (3.10+) and several slightly > younger blk_rq_map_user_iov() bugs, both on map and copy codepaths (Vitaly > and me). I ran work.iov_iter changeset through our smoke test few days ago - no apparent s

Re: mmotm 2016-08-02-15-53 uploaded

2017-10-10 Thread Vitaly Mayatskikh
On Tue, 10 Oct 2017 20:48:34 -0400, Changwei Ge wrote: > > Hi Andrew and Vitaly, > > I do agree that patch ee8f7fcbe638 ("ocfs2/dlm: continue to purge > recovery lockres when recovery master goes down", 2016-08-02) introduced > an issue. It makes DLM recovery can't pick up a new master for an

Re: [PATCH] fix unbalanced page refcounting in bio_map_user_iov

2017-09-24 Thread Vitaly Mayatskikh
On Sun, 24 Sep 2017 10:27:39 -0400, Al Viro wrote: > BTW, there's something fishy in bio_copy_user_iov(). If the area we'd asked > for > had been too large for a single bio, we are going to create a bio and have > bio_add_pc_page() eventually fill it up to limit. Then we return into > __blk_rq

Re: [PATCH] fix unbalanced page refcounting in bio_map_user_iov

2017-09-21 Thread Vitaly Mayatskikh
Reproducer (needs SCSI disk): #include #include #include #include #include #include #include #include #include #define NR_IOS 1 #define NR_IOVECS 8 #define SG_IO 0x2285 int main(int argc, char *argv[]) { int fd, i, j; unsigned char *buf, *ptr, cdb[10]; sg_i

[PATCH] fix unbalanced page refcounting in bio_map_user_iov

2017-09-21 Thread Vitaly Mayatskikh
bio_map_user_iov and bio_unmap_user do unbalanced pages refcounting if IO vector has small consecutive buffers belonging to the same page. bio_add_pc_page merges them into one, but the page reference is never dropped. Signed-off-by: Vitaly Mayatskikh diff --git a/block/bio.c b/block/bio.c index

Re: PPC64 AT_IGNOREPPC question

2007-09-10 Thread Vitaly Mayatskikh
:) and didn't notice any specialities for AT_IGNOREPPC. -- Vitaly Mayatskikh <[EMAIL PROTECTED]> Kernel development Red Hat Czech, Brno Phone: +420 532 294 111 IRC: vitaly on #kernel, #brno GPG: 0x4BA2E8FB - To unsubscribe from this list: send the line "unsubscribe linux-k

PPC64 AT_IGNOREPPC question

2007-09-07 Thread Vitaly Mayatskikh
include/asm-powerpc/elf.h:289 Why we need the second AT_IGNOREPPC entry here? There is a mm_struct->saved_auxv overflow on PPC64 with AT_VECTOR_SIZE == 44 (may be on PPC32 too, not checked) when adding all entries to it. I've removed the second AT_IGNOREPCC from ARCH_DLINFO to prevent overflowi

[PATCH 2.6.21] Return available first timeslice to the creator, not parent

2007-08-30 Thread Vitaly Mayatskikh
ad_create (creator) failed\n"); exit(EXIT_FAILURE); } pthread_join(t, NULL); exit(EXIT_SUCCESS); } /// /// fork_exit.stp //